[jira] [Commented] (AMBARI-21592) Log Feeder properties should be handled by one class

2017-08-04 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-21592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114175#comment-16114175
 ] 

Hudson commented on AMBARI-21592:
-

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #7846 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/7846/])
AMBARI-21592 Log Feeder properties should be handled by one class (mgergely: 
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=27386c3d9eae250a72f3b23308c752e5e32765c1])
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
* (add) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederPropertiesUtil.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
* (edit) 
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java


> Log Feeder properties should be handled by one class
> 
>
> Key: AMBARI-21592
> URL: https://issues.apache.org/jira/browse/AMBARI-21592
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-logsearch
>Affects Versions: 3.0.0
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
> Fix For: 3.0.0
>
> Attachments: AMBARI-21592.patch
>
>
> Log Feeder properties are scattered all over the code, with their 
> documentation, putting large blocks of codes into several classes. Instead of 
> it they should be handled by one class together with their documentation and 
> default values, having all the rest of the classes asking that one for their 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AMBARI-21592) Log Feeder properties should be handled by one class

2017-08-04 Thread Miklos Gergely (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-21592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114148#comment-16114148
 ] 

Miklos Gergely commented on AMBARI-21592:
-

committed to trunk:
{code:java}
commit 27386c3d9eae250a72f3b23308c752e5e32765c1
Author: Miklos Gergely 
Date:   Fri Aug 4 11:03:51 2017 +0200

AMBARI-21592 Log Feeder properties should be handled by one class (mgergely)

Change-Id: I3193f3b7a4b7f64ed7d60191f446640500b46a0e
{code}

> Log Feeder properties should be handled by one class
> 
>
> Key: AMBARI-21592
> URL: https://issues.apache.org/jira/browse/AMBARI-21592
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-logsearch
>Affects Versions: 3.0.0
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
> Fix For: 3.0.0
>
> Attachments: AMBARI-21592.patch
>
>
> Log Feeder properties are scattered all over the code, with their 
> documentation, putting large blocks of codes into several classes. Instead of 
> it they should be handled by one class together with their documentation and 
> default values, having all the rest of the classes asking that one for their 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AMBARI-21592) Log Feeder properties should be handled by one class

2017-07-27 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-21592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104112#comment-16104112
 ] 

Hadoop QA commented on AMBARI-21592:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12879258/AMBARI-21592.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-logsearch/ambari-logsearch-logfeeder.

Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/11881//console

This message is automatically generated.

> Log Feeder properties should be handled by one class
> 
>
> Key: AMBARI-21592
> URL: https://issues.apache.org/jira/browse/AMBARI-21592
> Project: Ambari
>  Issue Type: Improvement
>  Components: ambari-logsearch
>Affects Versions: 3.0.0
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
> Fix For: 3.0.0
>
> Attachments: AMBARI-21592.patch
>
>
> Log Feeder properties are scattered all over the code, with their 
> documentation, putting large blocks of codes into several classes. Instead of 
> it they should be handled by one class together with their documentation and 
> default values, having all the rest of the classes asking that one for their 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)