[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[
https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241424#comment-16241424
]
ASF GitHub Bot commented on ARROW-1771:
---
wesm closed pull request #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API
test in parquet-cpp
URL: https://github.com/apache/arrow/pull/1288
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 22b475146..69d505233 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -171,6 +171,7 @@ ADD_ARROW_TEST(array-test)
ADD_ARROW_TEST(buffer-test)
ADD_ARROW_TEST(memory_pool-test)
ADD_ARROW_TEST(pretty_print-test)
+ADD_ARROW_TEST(public-api-test)
ADD_ARROW_TEST(status-test)
ADD_ARROW_TEST(type-test)
ADD_ARROW_TEST(table-test)
diff --git a/cpp/src/arrow/public-api-test.cc b/cpp/src/arrow/public-api-test.cc
new file mode 100644
index 0..8298d748f
--- /dev/null
+++ b/cpp/src/arrow/public-api-test.cc
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "arrow/api.h"
+
+#ifdef DCHECK
+#error "DCHECK should not be visible from Arrow public headers."
+#endif
+
+#include
+
+TEST(_, _) {}
diff --git a/cpp/src/arrow/util/bit-util.h b/cpp/src/arrow/util/bit-util.h
index d6415f3c7..cab3c9ee7 100644
--- a/cpp/src/arrow/util/bit-util.h
+++ b/cpp/src/arrow/util/bit-util.h
@@ -57,7 +57,6 @@
#include
#include
-#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
#include "arrow/util/type_traits.h"
#include "arrow/util/visibility.h"
@@ -301,7 +300,7 @@ static inline int Log2(uint64_t x) {
/// \brief Count the number of leading zeros in a 32 bit integer.
static inline int64_t CountLeadingZeros(uint32_t value) {
- DCHECK_NE(value, 0);
+// DCHECK_NE(value, 0);
#if defined(__clang__) || defined(__GNUC__)
return static_cast(__builtin_clz(value));
#elif defined(_MSC_VER)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] ARROW-1749 Breaks Public API test in parquet-cpp
> --
>
> Key: ARROW-1771
> URL: https://issues.apache.org/jira/browse/ARROW-1771
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.7.1
>Reporter: Phillip Cloud
>Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[
https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241422#comment-16241422
]
ASF GitHub Bot commented on ARROW-1771:
---
wesm commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API
test in parquet-cpp
URL: https://github.com/apache/arrow/pull/1288#issuecomment-342364208
You might like my bash function for pre-checkin
```bash
function arrow_preflight {
ARROW_PREFLIGHT_DIR=$HOME/code/arrow/cpp/preflight
mkdir -p $ARROW_PREFLIGHT_DIR
pushd $ARROW_PREFLIGHT_DIR
arrow_cmake
ninja format
ninja lint
popd
pushd $HOME/code/arrow/python
flake8 --count pyarrow
flake8 --count --config=.flake8.cython pyarrow
popd
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] ARROW-1749 Breaks Public API test in parquet-cpp
> --
>
> Key: ARROW-1771
> URL: https://issues.apache.org/jira/browse/ARROW-1771
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.7.1
>Reporter: Phillip Cloud
>Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[
https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241421#comment-16241421
]
ASF GitHub Bot commented on ARROW-1771:
---
wesm commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API
test in parquet-cpp
URL: https://github.com/apache/arrow/pull/1288#issuecomment-342364208
You might like my bash function for pre-checkin
```
function arrow_preflight {
ARROW_PREFLIGHT_DIR=$HOME/code/arrow/cpp/preflight
mkdir -p $ARROW_PREFLIGHT_DIR
pushd $ARROW_PREFLIGHT_DIR
arrow_cmake
ninja format
ninja lint
popd
pushd $HOME/code/arrow/python
flake8 --count pyarrow
flake8 --count --config=.flake8.cython pyarrow
popd
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] ARROW-1749 Breaks Public API test in parquet-cpp
> --
>
> Key: ARROW-1771
> URL: https://issues.apache.org/jira/browse/ARROW-1771
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.7.1
>Reporter: Phillip Cloud
>Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240833#comment-16240833 ] ASF GitHub Bot commented on ARROW-1771: --- cpcloud commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342276239 @wesm The most recent commit includes an example of what I'm talking about. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240830#comment-16240830 ] ASF GitHub Bot commented on ARROW-1771: --- wesm commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342275011 Well, somewhere we need a test executable that is using the public API headers. I think the risk is that unit tests may include non-public headers (including gtest and other things) and so it may be hard to isolate the exact things we want to test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240715#comment-16240715 ] ASF GitHub Bot commented on ARROW-1771: --- cpcloud commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342248233 I'll add a `public-api-test` in this PR that test that `DCHECK` isn't defined and we can keep adding to it as needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240704#comment-16240704 ] ASF GitHub Bot commented on ARROW-1771: --- cpcloud commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342248642 @wesm Actually, is there any reason we shouldn't just prevent compilation if `DCHECK` is defined when including `arrow/api.h`? This would of course only fail to compile if someone is compiling tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240706#comment-16240706 ] ASF GitHub Bot commented on ARROW-1771: --- cpcloud commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342248842 so instead of a full blown test executable we have somethign like this: ```c++ #ifdef DCHECK #error "helpful message" #endif ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240702#comment-16240702 ] ASF GitHub Bot commented on ARROW-1771: --- cpcloud commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342248233 I'll add a `public-ap-test` in this PR that test that `DCHECK` isn't defined and we can keep adding to it as needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1771) [C++] ARROW-1749 Breaks Public API test in parquet-cpp
[ https://issues.apache.org/jira/browse/ARROW-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240550#comment-16240550 ] ASF GitHub Bot commented on ARROW-1771: --- wesm commented on issue #1288: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp URL: https://github.com/apache/arrow/pull/1288#issuecomment-342211947 Good catch, time to add a public API test suite in Arrow, too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [C++] ARROW-1749 Breaks Public API test in parquet-cpp > -- > > Key: ARROW-1771 > URL: https://issues.apache.org/jira/browse/ARROW-1771 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Affects Versions: 0.7.1 >Reporter: Phillip Cloud >Assignee: Phillip Cloud > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
