[jira] [Commented] (ARROW-2356) [JS] JSON reader fails on FixedSizeBinary data buffer
[
https://issues.apache.org/jira/browse/ARROW-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415785#comment-16415785
]
ASF GitHub Bot commented on ARROW-2356:
---
TheNeuralBit closed pull request #1796: ARROW-2356: [JS] Fix JSON Reader
FixedSizeBinary Vectors
URL: https://github.com/apache/arrow/pull/1796
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/js/bin/integration.js b/js/bin/integration.js
index 2aeb14d0e..73162b6a8 100755
--- a/js/bin/integration.js
+++ b/js/bin/integration.js
@@ -106,13 +106,13 @@ switch (mode) {
jsonPaths.forEach((p, i) => {
args.push('-j', p, '-a', arrowPaths[i]);
});
-child_process.spawnSync(
+process.exitCode = child_process.spawnSync(
gulp, args,
{
cwd: path.resolve(__dirname, '..'),
stdio: ['ignore', 'inherit', 'inherit']
}
-);
+).status || process.exitCode || 0;
// for (let i = -1, n = jsonPaths.length; ++i < n;) {
// const jsonPath = jsonPaths[i];
// const arrowPath = arrowPaths[i];
diff --git a/js/src/ipc/reader/json.ts b/js/src/ipc/reader/json.ts
index 10819986f..67bb5ca2d 100644
--- a/js/src/ipc/reader/json.ts
+++ b/js/src/ipc/reader/json.ts
@@ -106,7 +106,7 @@ export class JSONDataLoader extends TypeDataLoader {
return new Uint8Array(int64DataFromJSON(sources[offset] as
string[]));
} else if (DataType.isDecimal(type) === true) {
return new Uint8Array(decimalDataFromJSON(sources[offset] as
string[]));
-} else if (DataType.isBinary(type) === true) {
+} else if (DataType.isBinary(type) === true ||
DataType.isFixedSizeBinary(type) === true) {
return new Uint8Array(binaryDataFromJSON(sources[offset] as
string[]));
} else if (DataType.isBool(type) === true) {
return new Uint8Array(packBools(sources[offset] as
number[]).buffer);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JS] JSON reader fails on FixedSizeBinary data buffer
> -
>
> Key: ARROW-2356
> URL: https://issues.apache.org/jira/browse/ARROW-2356
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
>Affects Versions: JS-0.3.1
>Reporter: Paul Taylor
>Assignee: Paul Taylor
>Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.0
>
>
> The JSON reader doesn't ingest the FixedSizeBinary data buffer correctly, and
> we haven't known about it because the JS integration test runner is
> accidentally exiting with code 0 on failures.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2356) [JS] JSON reader fails on FixedSizeBinary data buffer
[ https://issues.apache.org/jira/browse/ARROW-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415718#comment-16415718 ] ASF GitHub Bot commented on ARROW-2356: --- TheNeuralBit commented on issue #1796: ARROW-2356: [JS] Fix JSON Reader FixedSizeBinary Vectors URL: https://github.com/apache/arrow/pull/1796#issuecomment-376547752 This looks good to me, CI failure seems unrelated. Created https://github.com/apache/arrow/pull/1799 to make sure that the fix to integration.js will actually cause a CI failure when it should. Will merge once that's finished. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JS] JSON reader fails on FixedSizeBinary data buffer > - > > Key: ARROW-2356 > URL: https://issues.apache.org/jira/browse/ARROW-2356 > Project: Apache Arrow > Issue Type: Bug > Components: JavaScript >Affects Versions: JS-0.3.1 >Reporter: Paul Taylor >Assignee: Paul Taylor >Priority: Major > Labels: pull-request-available > Fix For: JS-0.4.0 > > > The JSON reader doesn't ingest the FixedSizeBinary data buffer correctly, and > we haven't known about it because the JS integration test runner is > accidentally exiting with code 0 on failures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2356) [JS] JSON reader fails on FixedSizeBinary data buffer
[ https://issues.apache.org/jira/browse/ARROW-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414758#comment-16414758 ] ASF GitHub Bot commented on ARROW-2356: --- trxcllnt opened a new pull request #1796: ARROW-2356: [JS] Fix JSON Reader FixedSizeBinary Vectors URL: https://github.com/apache/arrow/pull/1796 Resolves https://issues.apache.org/jira/browse/ARROW-2356 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [JS] JSON reader fails on FixedSizeBinary data buffer > - > > Key: ARROW-2356 > URL: https://issues.apache.org/jira/browse/ARROW-2356 > Project: Apache Arrow > Issue Type: Bug > Components: JavaScript >Affects Versions: JS-0.3.1 >Reporter: Paul Taylor >Assignee: Paul Taylor >Priority: Major > Labels: pull-request-available > Fix For: JS-0.4.0 > > > The JSON reader doesn't ingest the FixedSizeBinary data buffer correctly, and > we haven't known about it the JS integration test runner is accidentally > exiting with code 0 on failures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
