Re: [PR] Switch Perl library from JSON::XS to JSON::MaybeXS [avro]

2024-06-12 Thread via GitHub 


jjatria commented on PR #2952:
URL: https://github.com/apache/avro/pull/2952#issuecomment-2162418876

   @martin-g I've sent in an account request :bow: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Switch Perl library from JSON::XS to JSON::MaybeXS [avro]

2024-06-12 Thread via GitHub 


martin-g commented on PR #2952:
URL: https://github.com/apache/avro/pull/2952#issuecomment-2162449444

   Approved it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] AVRO-3998 - Switch Perl library from JSON::XS to JSON::MaybeXS [avro]

2024-06-12 Thread via GitHub 


jjatria commented on PR #2952:
URL: https://github.com/apache/avro/pull/2952#issuecomment-2162764214

   @martin-g: There's a ticket now: 
https://issues.apache.org/jira/browse/AVRO-3998


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (AVRO-3998) Switch Perl library from JSON::XS to JSON::MaybeXS

2024-06-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AVRO-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated AVRO-3998:
-
Labels: pull-request-available  (was: )

> Switch Perl library from JSON::XS to JSON::MaybeXS
> --
>
> Key: AVRO-3998
> URL: https://issues.apache.org/jira/browse/AVRO-3998
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: José Joaquín Atria
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Perl library currently depends directly on JSON::XS, which forces a 
> decision of the JSON backend on the user. Perl currently has a number of 
> compatible backends, including JSON::PP, which is shipped with Perl itself.
> The JSON::MaybeXS library serves as a compatibility layer to allow users to 
> select the JSON backend that matches their stack, rather than forcing them to 
> install a specific one, while still benefiting from the performance boost of 
> XS libraries if they are available.
> Note that AVRO-1514 already exists aiming to clean up some dependencies, 
> including replacing JSON::XS with plain JSON, a different compatibility layer.
> While the other changes in AVRO-1514 I think are desirable, that ticket seems 
> to have stalled, and JSON::MaybeXS seems like a better alternative since it 
> also supports Cpanel::JSON::XS as an additional possible backend.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (AVRO-3999) Avoid warnings in Perl test suite

2024-06-12 Thread Jira 


 [ 
https://issues.apache.org/jira/browse/AVRO-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

José Joaquín Atria updated AVRO-3999:
-
Description: 
The test suite generated several warnings which could easily be avoided. 
Specifically an undefined value being stringified in t/03_bin_decode.t, and 
exiting a subroutine via next in xt/schema.t. See output below for illustration:

 
{code:java}
$ ./build.sh test
include /home/user/avro/lang/perl/inc/Module/Install.pm
include inc/Module/Install/Metadata.pm
include inc/Module/Install/Base.pm
include inc/Module/Install/ReadmeFromPod.pm
readme_from lib/Avro.pm to txt
include inc/Module/Install/Repository.pm
Cannot determine repository URL
include inc/Module/Install/MakeMaker.pm
include inc/Module/Install/Makefile.pm
Generating a Unix-style Makefile
Writing Makefile for Avro
Writing MYMETA.yml and MYMETA.json
Writing META.yml
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/BinaryEncoder.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/DataFileWriter.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/BinaryDecoder.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/DataFileReader.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/DataFile.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/Schema.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/Protocol/Message.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro/Protocol.pm
sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro.pm
PERL_DL_NONLAZY=1 "/home/user/.perl/perls/perl-5.36.0/bin/perl" 
"-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef 
*Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" 
t/*.t xt/*.t
t/00_compile.t . ok
t/01_names.t ... ok
t/01_schema.t .. ok
t/02_bin_encode.t .. ok
t/03_bin_decode.t .. 1/? Use of uninitialized value in concatenation (.) or 
string at /home/user/.perl/perls/perl-5.36.0/lib/site_perl/5.36.0/Error.pm line 
288.
t/03_bin_decode.t .. ok
t/04_datafile.t  ok
t/05_protocol.t  ok
xt/interop.t ... ok
xt/pod.t ... ok
xt/schema.t  1/? Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subroutine via next at xt/schema.t line 26.
Exiting subrout

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.5.0 to 3.6.0 in /lang/java [avro]

2024-06-12 Thread via GitHub 


Fokko commented on PR #2919:
URL: https://github.com/apache/avro/pull/2919#issuecomment-2162894537

   Thanks again for the review @slachiewicz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] AVRO-3995 [C++] Require C++17 to compile Avro [avro]

2024-06-12 Thread via GitHub 


Fokko commented on PR #2949:
URL: https://github.com/apache/avro/pull/2949#issuecomment-2162896451

   @Gerrit0 Can you rebase now https://github.com/apache/avro/pull/2931 is in?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] AVRO-3999 - Avoid warnings in Perl test suite [avro]

2024-06-12 Thread via GitHub 


martin-g commented on PR #2953:
URL: https://github.com/apache/avro/pull/2953#issuecomment-2163035060

   Thank you, @jjatria !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (AVRO-3999) Avoid warnings in Perl test suite

2024-06-12 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AVRO-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated AVRO-3999:
-
Labels: pull-request-available  (was: )

> Avoid warnings in Perl test suite
> -
>
> Key: AVRO-3999
> URL: https://issues.apache.org/jira/browse/AVRO-3999
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: José Joaquín Atria
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test suite generated several warnings which could easily be avoided. 
> Specifically an undefined value being stringified in t/03_bin_decode.t, and 
> exiting a subroutine via next in xt/schema.t. See output below for 
> illustration:
>  
> {code:java}
> $ ./build.sh test
> include /home/user/avro/lang/perl/inc/Module/Install.pm
> include inc/Module/Install/Metadata.pm
> include inc/Module/Install/Base.pm
> include inc/Module/Install/ReadmeFromPod.pm
> readme_from lib/Avro.pm to txt
> include inc/Module/Install/Repository.pm
> Cannot determine repository URL
> include inc/Module/Install/MakeMaker.pm
> include inc/Module/Install/Makefile.pm
> Generating a Unix-style Makefile
> Writing Makefile for Avro
> Writing MYMETA.yml and MYMETA.json
> Writing META.yml
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryEncoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileWriter.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryDecoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileReader.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFile.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Schema.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol/Message.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro.pm
> PERL_DL_NONLAZY=1 "/home/user/.perl/perls/perl-5.36.0/bin/perl" 
> "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef 
> *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" 
> t/*.t xt/*.t
> t/00_compile.t . ok
> t/01_names.t ... ok
> t/01_schema.t .. ok
> t/02_bin_encode.t .. ok
> t/03_bin_decode.t .. 1/? Use of uninitialized value in concatenation (.) or 
> string at /home/user/.perl/perls/perl-5.36.0/lib/site_perl/5.36.0/Error.pm 
> line 288.
> t/03_bin_decode.t .. ok
> t/04_datafile.t  ok
> t/05_protocol.t  ok
> xt/interop.t ... ok
> xt/pod.t ... ok
> xt/schema.t  1/? Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/sc

[jira] [Commented] (AVRO-3999) Avoid warnings in Perl test suite

2024-06-12 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/AVRO-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854435#comment-17854435
 ] 

ASF subversion and git services commented on AVRO-3999:
---

Commit 072b51fb548c35fee192917ef1d3cdbd944ef53b in avro's branch 
refs/heads/main from José Joaquín Atria
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=072b51fb5 ]

AVRO-3999 - Avoid warnings in Perl test suite (#2953)

* Add error message when schema do not match in Perl

When the schema did not match in a call to Avro::BinaryDecoder::decode,
a Avro::Schema::Error::Mismatch error was thrown without a body. This
was generating a warning when trying to stringify an undefined value,
and resulted in the empty string being used as the error message, which
was not veryb informative.

This change adds a message which should solve both issues.

* Do not exit sub via next in Perl tests

This silences a loud warning in xt/schema.t

> Avoid warnings in Perl test suite
> -
>
> Key: AVRO-3999
> URL: https://issues.apache.org/jira/browse/AVRO-3999
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: José Joaquín Atria
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test suite generated several warnings which could easily be avoided. 
> Specifically an undefined value being stringified in t/03_bin_decode.t, and 
> exiting a subroutine via next in xt/schema.t. See output below for 
> illustration:
>  
> {code:java}
> $ ./build.sh test
> include /home/user/avro/lang/perl/inc/Module/Install.pm
> include inc/Module/Install/Metadata.pm
> include inc/Module/Install/Base.pm
> include inc/Module/Install/ReadmeFromPod.pm
> readme_from lib/Avro.pm to txt
> include inc/Module/Install/Repository.pm
> Cannot determine repository URL
> include inc/Module/Install/MakeMaker.pm
> include inc/Module/Install/Makefile.pm
> Generating a Unix-style Makefile
> Writing Makefile for Avro
> Writing MYMETA.yml and MYMETA.json
> Writing META.yml
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryEncoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileWriter.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryDecoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileReader.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFile.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Schema.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol/Message.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro.pm
> PERL_DL_NONLAZY=1 "/home/user/.perl/perls/perl-5.36.0/bin/perl" 
> "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef 
> *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" 
> t/*.t xt/*.t
> t/00_compile.t . ok
> t/01_names.t ... ok
> t/01_schema.t .. ok
> t/02_bin_encode.t .. ok
> t/03_bin_decode.t .. 1/? Use of uninitialized value in concatenation (.) or 
> string at /home/user/.perl/perls/perl-5.36.0/lib/site_perl/5.36.0/Error.pm 
> line 288.
> t/03_bin_decode.t .. ok
> t/04_datafile.t  ok
> t/05_protocol.t  ok
> xt/interop.t ... ok
> xt/pod.t ... ok
> xt/schema.t  1/? Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting

[jira] [Resolved] (AVRO-3999) Avoid warnings in Perl test suite

2024-06-12 Thread Martin Tzvetanov Grigorov (Jira) 


 [ 
https://issues.apache.org/jira/browse/AVRO-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Tzvetanov Grigorov resolved AVRO-3999.
-
Fix Version/s: 1.12.0
 Assignee: Martin Tzvetanov Grigorov
   Resolution: Fixed

> Avoid warnings in Perl test suite
> -
>
> Key: AVRO-3999
> URL: https://issues.apache.org/jira/browse/AVRO-3999
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: José Joaquín Atria
>Assignee: Martin Tzvetanov Grigorov
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The test suite generated several warnings which could easily be avoided. 
> Specifically an undefined value being stringified in t/03_bin_decode.t, and 
> exiting a subroutine via next in xt/schema.t. See output below for 
> illustration:
>  
> {code:java}
> $ ./build.sh test
> include /home/user/avro/lang/perl/inc/Module/Install.pm
> include inc/Module/Install/Metadata.pm
> include inc/Module/Install/Base.pm
> include inc/Module/Install/ReadmeFromPod.pm
> readme_from lib/Avro.pm to txt
> include inc/Module/Install/Repository.pm
> Cannot determine repository URL
> include inc/Module/Install/MakeMaker.pm
> include inc/Module/Install/Makefile.pm
> Generating a Unix-style Makefile
> Writing Makefile for Avro
> Writing MYMETA.yml and MYMETA.json
> Writing META.yml
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryEncoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileWriter.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/BinaryDecoder.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFileReader.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/DataFile.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Schema.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol/Message.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/  >blib/lib/Avro/Protocol.pm
> sed -e s/++MODULE_VERSION++/1.12.0-SNAPSHOT/ blib/lib/Avro.pm
> PERL_DL_NONLAZY=1 "/home/user/.perl/perls/perl-5.36.0/bin/perl" 
> "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef 
> *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" 
> t/*.t xt/*.t
> t/00_compile.t . ok
> t/01_names.t ... ok
> t/01_schema.t .. ok
> t/02_bin_encode.t .. ok
> t/03_bin_decode.t .. 1/? Use of uninitialized value in concatenation (.) or 
> string at /home/user/.perl/perls/perl-5.36.0/lib/site_perl/5.36.0/Error.pm 
> line 288.
> t/03_bin_decode.t .. ok
> t/04_datafile.t  ok
> t/05_protocol.t  ok
> xt/interop.t ... ok
> xt/pod.t ... ok
> xt/schema.t  1/? Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.t line 26.
> Exiting subroutine via next at xt/schema.

[jira] [Resolved] (AVRO-3998) Switch Perl library from JSON::XS to JSON::MaybeXS

2024-06-12 Thread Martin Tzvetanov Grigorov (Jira) 


 [ 
https://issues.apache.org/jira/browse/AVRO-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Tzvetanov Grigorov resolved AVRO-3998.
-
Fix Version/s: 1.12.0
 Assignee: Fokko Driesprong
   Resolution: Fixed

> Switch Perl library from JSON::XS to JSON::MaybeXS
> --
>
> Key: AVRO-3998
> URL: https://issues.apache.org/jira/browse/AVRO-3998
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: José Joaquín Atria
>Assignee: Fokko Driesprong
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Perl library currently depends directly on JSON::XS, which forces a 
> decision of the JSON backend on the user. Perl currently has a number of 
> compatible backends, including JSON::PP, which is shipped with Perl itself.
> The JSON::MaybeXS library serves as a compatibility layer to allow users to 
> select the JSON backend that matches their stack, rather than forcing them to 
> install a specific one, while still benefiting from the performance boost of 
> XS libraries if they are available.
> Note that AVRO-1514 already exists aiming to clean up some dependencies, 
> including replacing JSON::XS with plain JSON, a different compatibility layer.
> While the other changes in AVRO-1514 I think are desirable, that ticket seems 
> to have stalled, and JSON::MaybeXS seems like a better alternative since it 
> also supports Cpanel::JSON::XS as an additional possible backend.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-2434) Make the supported Perl version consistent

2024-06-12 Thread Jira 


[ 
https://issues.apache.org/jira/browse/AVRO-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854446#comment-17854446
 ] 

José Joaquín Atria commented on AVRO-2434:
--

The line in Avro.pm was changed to "use 5.010_001" on 
[https://github.com/apache/avro/commit/eb21a2148b552d3df2db251558c7986ffb2bc833]
 as part of AVRO-2547.

As of 12/06/2024, the minimum version of Perl that the code requires is 5.10.1 
(which according to [cpan.rocks|https://cpan.rocks/] is the most common minimum 
required version):
{code:java}
$ perlver .


   --  
 | file| explicit | syntax | external |
 | -- |
 | Makefile.PL | ~| ~  | n/a  |
 | share/interop-data-generate | ~| v5.6.0 | n/a  |
 | inc/Module/Install.pm   | v5.6.0   | v5.6.0 | n/a  |
 | inc/Module/Install/Repository.pm| v5.5.0   | v5.6.0 | n/a  |
 | inc/Module/Install/Makefile.pm  | ~| v5.5.0 | n/a  |
 | inc/Module/Install/ReadmeFromPod.pm | v5.6.0   | v5.6.0 | n/a  |
 | inc/Module/Install/MakeMaker.pm | ~| ~  | n/a  |
 | inc/Module/Install/Metadata.pm  | ~| v5.5.0 | n/a  |
 | inc/Module/Install/Base.pm  | ~| ~  | n/a  |
 | xt/schema.t | ~| v5.6.0 | n/a  |
 | xt/interop.t| ~| v5.6.0 | n/a  |
 | xt/pod.t| ~| ~  | n/a  |
 | lib/Avro.pm | v5.10.1  | v5.6.0 | n/a  |
 | lib/Avro/DataFile.pm| ~| v5.6.0 | n/a  |
 | lib/Avro/Protocol.pm| ~| v5.6.0 | n/a  |
 | lib/Avro/DataFileWriter.pm  | ~| v5.6.0 | n/a  |
 | lib/Avro/Schema.pm  | ~| v5.6.0 | n/a  |
 | lib/Avro/DataFileReader.pm  | ~| v5.8.0 | n/a  |
 | lib/Avro/BinaryDecoder.pm   | ~| v5.6.0 | n/a  |
 | lib/Avro/BinaryEncoder.pm   | ~| v5.6.0 | n/a  |
 | lib/Avro/Protocol/Message.pm| ~| v5.6.0 | n/a  |
 | bin/avro-to-json| ~| v5.6.0 | n/a  |
 | t/04_datafile.t | ~| v5.6.0 | n/a  |
 | t/01_schema.t   | ~| v5.6.0 | n/a  |
 | t/05_protocol.t | ~| v5.6.0 | n/a  |
 | t/00_compile.t  | ~| ~  | n/a  |
 | t/03_bin_decode.t   | ~| v5.6.0 | n/a  |
 | t/02_bin_encode.t   | ~| v5.6.0 | n/a  |
 | t/01_names.t| ~| v5.6.0 | n/a  |
 | -- |
 | Minimum explicit version : v5.10.1 |
 | Minimum syntax version   : v5.8.0  |
 | Minimum version of perl  : v5.10.1 |
   --  
{code}
Note that that is not necessarily the same as the minimum version of Perl that 
Apache is willing to commit to support.

FWIW, the version in BUILD.md comes from AVRO-2238 where it seems to have been 
changed accidentally. Maybe [~Fokko] remembers how/why that happened?

If we can get away with moving to 5.24 then there are all sorts of nice modern 
goodies we can start using, like Object::Pad and Feature::Compat::Try.

> Make the supported Perl version consistent
> --
>
> Key: AVRO-2434
> URL: https://issues.apache.org/jira/browse/AVRO-2434
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: Kengo Seki
>Priority: Major
>
> According to BUILD.md, the supported Perl version seems to be 5.24.1+, while 
> Avro.pm says 5.8.1+.
> {code:title=BUILD.md}
> The following packages must be installed before Avro can be built:
> (snip)
>  - Perl: Perl 5.24.1 or greater, gmake, Module::Install,
> {code}
> {code:title=lang/perl/lib/Avro.pm}
> use 5.008_001;
> {code}
> Which version is the right one? If the former is, we should simply update 
> Avro.pm too.
> If the latter is, we should update BUILD.md and Dockerfile to use Perl 5.8.1 
> for building and testing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-1830) Avro-Perl DataFileReader chokes when avro.codec is absent

2024-06-12 Thread Jira 


[ 
https://issues.apache.org/jira/browse/AVRO-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854463#comment-17854463
 ] 

José Joaquín Atria commented on AVRO-1830:
--

This change seems reasonable to me. It would be good to have a test case to go 
with it.

The only thing I'm not sure about is whether we would want the default 'null' 
string to be in `Avro::DataFileReader::read_file_header` or in 
`Avro::DataFile::is_codec_valid`. I would personally have made the change in 
the later, but doing it in the former seems more consistent with the behaviour 
of the Avro::DataFileWriter constructor.

Either way, this change makes the code more compliant with the spec.

> Avro-Perl DataFileReader chokes when avro.codec is absent
> -
>
> Key: AVRO-1830
> URL: https://issues.apache.org/jira/browse/AVRO-1830
> Project: Apache Avro
>  Issue Type: Bug
>  Components: perl
>Affects Versions: 1.8.0
>Reporter: SK Liew
>Priority: Minor
> Attachments: Avro-1830.patch
>
>
> When a container does not specify its "avro.codec", it should be assumed to 
> be "null". An exception is thrown when I try to read such a container using 
> Avro::DataFileReader. The error happens at Avro/DataFileReader.pm line 101.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-1514) Clean up perl API dependencies

2024-06-12 Thread Jira 


[ 
https://issues.apache.org/jira/browse/AVRO-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854467#comment-17854467
 ] 

José Joaquín Atria commented on AVRO-1514:
--

Ten years later, the current minimal version of Perl is 5.10.1, but a recent 
change (merged as part of AVRO-3998) changed the dependency on JSON::XS to 
JSON::MaybeXS, with the same rationale as in this ticket (that depending on a 
compatibility layer allows users to decide what backend to use).

> Clean up perl API dependencies
> --
>
> Key: AVRO-1514
> URL: https://issues.apache.org/jira/browse/AVRO-1514
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: perl
>Reporter: John Karp
>Assignee: John Karp
>Priority: Minor
> Attachments: AVRO-1514-0.patch
>
>
> If we assume a non-ancient perl (>=5.8.1), we can clean up the dependencies:
> (build) Module::Install: bundle it
> (build) Module::Install::ReadmeFromPod: keep
> (build) Module::Install::Repository: remove, hardcode repository value 
> instead of autodetecting
> (build) Test::More 0.88: keep, but note requisite version built in starting 
> at 5.10.1
> (test) Test::Exception: keep
> (test) Test::Pod: declare (missing in Makefile.PL)
> (test/run) Math::BigInt: don't declare, now built-in
> (run) JSON::XS: replace with JSON to not tie to a backend
> (run) parent: keep, but note built-in starting at 5.10.1
> (run) Compress::Zlib: keep, but note built-in starting at 5.9.3
> (run) IO::String: replace with perl 5.8 functionality
> (run) Encode: don't declare, now built-in
> (run) Regexp::Common: keep
> (run) Object::Tiny: keep
> (run) Try::Tiny: keep



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3179) ClassCastException: java.math.BigDecimal cannot be cast to java.nio.ByteBuffer

2024-06-12 Thread Sylwester Lachiewicz (Jira) 


[ 
https://issues.apache.org/jira/browse/AVRO-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854510#comment-17854510
 ] 

Sylwester Lachiewicz commented on AVRO-3179:


[~cesuciso] Do you still have problems with BigDecimals or it's now solved?

> ClassCastException: java.math.BigDecimal cannot be cast to java.nio.ByteBuffer
> --
>
> Key: AVRO-3179
> URL: https://issues.apache.org/jira/browse/AVRO-3179
> Project: Apache Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.10.2
>Reporter: MarcelKobain
>Priority: Blocker
> Attachments: table.avsc
>
>
> Hello,
> I think we have the same problem as AVRO-2212.
> I have classCassException with a bigDecimal.
>  
> Context : 
> I am doing an ETL with postgres >> KafkaConnect >> KafkaStream
> I get schemas with mvn schema-registry:download
>  I generate pojo with : mvn clean avro:schema
> Then I launch my app to stream a table source to a table target
> see schema here : [^table.avsc]
>  
> I have fixed passing on the 1.10.1 version and it works. But When i take 
> 1.10.2 I have the bug : 
> Caused by: java.lang.ClassCastException: java.math.BigDecimal cannot be cast 
> to java.nio.ByteBufferCaused by: java.lang.ClassCastException: 
> java.math.BigDecimal cannot be cast to java.nio.ByteBuffer at 
> postgres.table.Value.put(Value.java:240) at 
> org.apache.avro.generic.GenericData.setField(GenericData.java:818) at 
> org.apache.avro.specific.SpecificDatumReader.readField(SpecificDatumReader.java:139)
>  at 
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:247)
>  at 
> org.apache.avro.specific.SpecificDatumReader.readRecord(SpecificDatumReader.java:123)
>  at 
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:179)
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-2715) Building with Visual Studio and Snappy enabled fails

2024-06-12 Thread Sylwester Lachiewicz (Jira) 


[ 
https://issues.apache.org/jira/browse/AVRO-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854512#comment-17854512
 ] 

Sylwester Lachiewicz commented on AVRO-2715:


PR has been merged to master and it's part of Avro 1.11.0 release. 
Issie should be closed.

> Building with Visual Studio and Snappy enabled fails
> 
>
> Key: AVRO-2715
> URL: https://issues.apache.org/jira/browse/AVRO-2715
> Project: Apache Avro
>  Issue Type: Bug
> Environment: * Windows 10
>  * Microsoft Visual Studio 2019
>  * CMake 3.15
>  * Target architecture: x64
>Reporter: Michael Spector
>Priority: Major
>
> I'm getting the following error:
> {code:java}
> ...\Projects\avro\lang\c++\impl\DataFile.cc(32,10): fatal error C1083: Cannot 
> open include file: 'snappy.h': No such file or directory 
> [C:\Users\mispecto\Projects\avro\lang\c++\build\avrocpp.vcxproj]
> ...\Projects\avro\lang\c++\impl\DataFile.cc(32,10): fatal error C1083: Cannot 
> open include file: 'snappy.h': No such file or directory 
> [C:\Users\mispecto\Projects\avro\lang\c++\build\avrocpp_s.vcxproj]{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-3852) Support Java 21

2024-06-12 Thread Sylwester Lachiewicz (Jira) 


[ 
https://issues.apache.org/jira/browse/AVRO-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854514#comment-17854514
 ] 

Sylwester Lachiewicz commented on AVRO-3852:


Should be closed.

> Support Java 21
> ---
>
> Key: AVRO-3852
> URL: https://issues.apache.org/jira/browse/AVRO-3852
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: build, java
>Affects Versions: 1.12.0
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> We should support most LTS versions so we should move the current validation 
> CI jobs to test against Java 21 and do the required fixes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (AVRO-2848) Snappy-java1.1.7.5 has error log in mvn-site

2024-06-12 Thread Sylwester Lachiewicz (Jira) 


[ 
https://issues.apache.org/jira/browse/AVRO-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854517#comment-17854517
 ] 

Sylwester Lachiewicz commented on AVRO-2848:


It's a Maven reporting plugin issue and was fixed in the newer version. Safe to 
ignore.

> Snappy-java1.1.7.5 has error log in mvn-site
> 
>
> Key: AVRO-2848
> URL: https://issues.apache.org/jira/browse/AVRO-2848
> Project: Apache Avro
>  Issue Type: Bug
>  Components: build, java
>Reporter: Zezeng Wang
>Priority: Minor
>
> When I use the mvn site test in lang / java, the snappy-java error log 
> appears, but the mvn site result is successful, which confuses me.
> I am not sure if this is avro bypass check, or a problem with snappy-java, or 
> a problem with maven, I just want to make a record, maybe someone familiar 
> with this can know the problem immediately without spending extra time.
> error log：
> {code:java}
> [DEBUG] Extension realms for project 
> org.xerial.snappy:snappy-java:bundle:1.1.7.5: (none)
> [DEBUG] Looking up Lifecyle mappings for packaging bundle from 
> ClassRealm[plexus.core, parent: null]
> [WARNING] Unable to create Maven project for 
> org.xerial.snappy:snappy-java:jar:1.1.7.5 from repository.
> org.apache.maven.project.ProjectBuildingException: Some problems were 
> encountered while processing the POMs:
> [ERROR] Unknown packaging: bundle @ 6, column 16
>   at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:195)
>   at 
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:368)
>   at 
> org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository(RepositoryUtils.java:125)
>   at 
> org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.getDependencyRow(DependencyManagementRenderer.java:253)
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] AVRO-3995 [C++] Require C++17 to compile Avro [avro]

2024-06-12 Thread via GitHub 


Gerrit0 commented on PR #2949:
URL: https://github.com/apache/avro/pull/2949#issuecomment-2164211263

   @Fokko done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] AVRO-3995 [C++] Require C++17 to compile Avro [avro]

2024-06-12 Thread via GitHub 


martin-g commented on code in PR #2949:
URL: https://github.com/apache/avro/pull/2949#discussion_r1637606433


##
lang/c++/impl/avrogencpp.cc:
##
@@ -728,28 +719,15 @@ void CodeGen::generate(const ValidSchema &schema) {
 os_ << "#ifndef " << h << "\n";
 os_ << "#define " << h << "\n\n\n";
 
-os_ << "#include \n";
-#if __cplusplus >= 201703L
-os_ << "#include \n";
-#else
-if (useCpp17_)
-os_ << "#include \n";
-else
-os_ << "#include \"boost/any.hpp\"\n";
-#endif
-os_ << "#include \"" << includePrefix_ << "Specific.hh\"\n"
+os_ << "#include \n"
+<< "#include \n"
+<< "#include \"" << includePrefix_ << "Specific.hh\"\n"
 << "#include \"" << includePrefix_ << "Encoder.hh\"\n"
 << "#include \"" << includePrefix_ << "Decoder.hh\"\n"
 << "\n";
 
-vector nsVector;
 if (!ns_.empty()) {
-boost::algorithm::split_regex(nsVector, ns_, boost::regex("::"));
-for (vector::const_iterator it =
- nsVector.begin();
- it != nsVector.end(); ++it) {
-os_ << "namespace " << *it << " {\n";
-}
+os_ << "namespace " << ns_ << " {\n";

Review Comment:
   Does this still work the same way ?
   `ns_` is a String that was split by `::` in the old version of the code. Now 
it is just printed as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org