[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222494#comment-17222494 ] Tyson Hamilton commented on BEAM-6595: -- PR was merged, closing. Please add a description with remaining work if there is more to do and reopen the issue. > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P3 > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137388#comment-17137388 ] Beam JIRA Bot commented on BEAM-6595: - This issue was marked "stale-P2" and has not received a public comment in 14 days. It is now automatically moved to P3. If you are still affected by it, you can comment and move it back to P2. > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P3 > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17122938#comment-17122938 ] Beam JIRA Bot commented on BEAM-6595: - This issue is P2 but has been unassigned without any comment for 60 days so it has been labeled "stale-P2". If this issue is still affecting you, we care! Please comment and remove the label. Otherwise, in 14 days the issue will be moved to P3. Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed explanation of what these priorities mean. > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Kenneth Knowles >Priority: P2 > Labels: stale-P2 > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012444#comment-17012444 ] Kenneth Knowles commented on BEAM-6595: --- What has happened is that we have been releasing RCs where the exact commit with the changed version is not pushed to GitHub. > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012440#comment-17012440 ] Kenneth Knowles commented on BEAM-6595: --- See https://lists.apache.org/thread.html/205472bdaf3c2c5876533750d417c19b0d1078131a3dc04916082ce8%40%3Cdev.beam.apache.org%3E > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012166#comment-17012166 ] Udi Meiri commented on BEAM-6595: - build_release_candidate.sh is broken due to https://github.com/apache/beam/pull/7735. We have been releasing -SNAPSHOT versions for a while due to this. https://issues.apache.org/jira/browse/BEAM-9079 > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-6595) build_release_candidate.sh should not push to apache org on github
[ https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810366#comment-16810366 ] Kenneth Knowles commented on BEAM-6595: --- Working on this, I want to note that it is OK to publish to various places, as that is required. The places that it does, and make sense, are: - SVN staging for the source, java, and python artifacts - PR for the javadocs and pydocs (only pushes to the user's github) - pushing the RC tag to apache/beam seems acceptable as part of this > build_release_candidate.sh should not push to apache org on github > -- > > Key: BEAM-6595 > URL: https://issues.apache.org/jira/browse/BEAM-6595 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > Labels: triaged > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the build_release_candidate.sh does many things beyond the build > - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT > - Makes a local commit > - Pushes commits to release branch > - Reverts on failure, pushes those to release branch > Instead, the release manager should determine what gets pushed. It is less > fragile of a process and avoids cruft getting pushed and churning the branch. > The only thing the plugin is really good for is flipping SNAPSHOT away and > back. And it isn't even that great because that's Java only and other > languages are at non-SNAPSHOT anyhow. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
