[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=213716=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213716 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 15/Mar/19 11:46 Start Date: 15/Mar/19 11:46 Worklog Time Spent: 10m Work Description: alafanechere commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-473255833 Hello @jbonofre , I still have this [issue](https://issues.apache.org/jira/browse/BEAM-6516) with the IO. Is there a specific configuration of the queue to make the consumption / ack of message work seamless with the Beam ? I tried to bypass the problem by patching the IO and using autoack on arrival but it looks like bad design... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 213716) Time Spent: 15h (was: 14h 50m) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.9.0 > > Time Spent: 15h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=213715=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213715 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 15/Mar/19 11:45 Start Date: 15/Mar/19 11:45 Worklog Time Spent: 10m Work Description: alafanechere commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-473255833 Hello @jbonofre , I still have this [issue](https://issues.apache.org/jira/browse/BEAM-6516) with the IO. Is there a specific configuration of the queue to make the consumption / ack of message work seamlessly with the Beam ? I tried to bypass the problem by patching the IO and using autoack on arrival but it looks like bad design... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 213715) Time Spent: 14h 50m (was: 14h 40m) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.9.0 > > Time Spent: 14h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=184846=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184846 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 14/Jan/19 15:44 Start Date: 14/Jan/19 15:44 Worklog Time Spent: 10m Work Description: alafanechere commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-454050841 I juste created the JIRA : https://jira.apache.org/jira/browse/BEAM-6424 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184846) Time Spent: 14.5h (was: 14h 20m) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.9.0 > > Time Spent: 14.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=184847=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184847 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 14/Jan/19 15:44 Start Date: 14/Jan/19 15:44 Worklog Time Spent: 10m Work Description: alafanechere commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-454050841 Thanks ! I juste created the JIRA : https://jira.apache.org/jira/browse/BEAM-6424 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184847) Time Spent: 14h 40m (was: 14.5h) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.9.0 > > Time Spent: 14h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=184844=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184844 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 14/Jan/19 15:34 Start Date: 14/Jan/19 15:34 Worklog Time Spent: 10m Work Description: jbonofre commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-454047121 @alafanechere by the way, I can create the Jira for you (and I will assign the Jira to me). Please let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184844) Time Spent: 14h 20m (was: 14h 10m) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.9.0 > > Time Spent: 14h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=184842=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184842
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 14/Jan/19 15:31
Start Date: 14/Jan/19 15:31
Worklog Time Spent: 10m
Work Description: alafanechere commented on issue #1729: [BEAM-1240]
Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#issuecomment-454046116
I tried to use the `RabbitMqIO` with the direct runner to generate an
unbounded `PCollection` from a queue. I encounter a NPE :
java.lang.NullPointerException
at
org.apache.beam.runners.direct.UnboundedReadEvaluatorFactory$UnboundedReadEvaluator.processElement
(UnboundedReadEvaluatorFactory.java:169)
...
After investigation it looks like it's caused by the fact that no default is
given to
`checkpointMark.oldestTimestamp`. `getWatermark()` is called before the
mutation of the currentTimestamp variable, raising a NPE. I fixed the problem
on my side, reimplementing the class and overriding `getWatermark` to return
`Instant.now()` if `checkpointMark.oldestTimestamp` is null :
```
@Override
publicInstantgetWatermark() {
if (checkpointMark.oldestTimestamp == null) {
returnInstant.now();
}
return checkpointMark.oldestTimestamp;
}
```
It looks likes this bug as already been raised [on
Jira](https://jira.apache.org/jira/browse/BEAM-1240?focusedCommentId=16566869=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16566869)
and on [Stack
Overflow](https://stackoverflow.com/questions/54042757/read-rabbitmq-from-beam-dataflow)
Do you think it's a problem that needs to be corrected ? Is there any
workaround you might think of ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184842)
Time Spent: 14h (was: 13h 50m)
> Create RabbitMqIO
> -
>
> Key: BEAM-1240
> URL: https://issues.apache.org/jira/browse/BEAM-1240
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 14h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=158571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158571
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 25/Oct/18 07:56
Start Date: 25/Oct/18 07:56
Worklog Time Spent: 10m
Work Description: echauchot closed pull request #1729: [BEAM-1240] Create
RabbitMqIO
URL: https://github.com/apache/beam/pull/1729
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/io/rabbitmq/build.gradle
b/sdks/java/io/rabbitmq/build.gradle
new file mode 100644
index 000..bef18f9309e
--- /dev/null
+++ b/sdks/java/io/rabbitmq/build.gradle
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+applyJavaNature()
+
+description = "Apache Beam :: SDKs :: Java :: IO :: RabbitMQ"
+ext.summary = "IO to read and write to a RabbitMQ broker."
+
+dependencies {
+ compile library.java.guava
+ shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
+ shadow library.java.joda_time
+ shadow "com.rabbitmq:amqp-client:4.6.0"
+ testCompile project(path: ":beam-runners-direct-java", configuration:
"shadow")
+ testCompile "org.apache.qpid:qpid-broker:0.28"
+ testCompile "org.apache.qpid:qpid-broker-core:0.28"
+ testCompile library.java.junit
+ testCompile library.java.hamcrest_core
+ testCompile library.java.hamcrest_library
+ testCompile library.java.slf4j_api
+ testCompile library.java.slf4j_jdk14
+}
diff --git
a/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java
b/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java
new file mode 100644
index 000..d7058120388
--- /dev/null
+++
b/sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java
@@ -0,0 +1,641 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static com.google.common.base.Preconditions.checkArgument;
+
+import com.google.auto.value.AutoValue;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.MessageProperties;
+import com.rabbitmq.client.QueueingConsumer;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.NoSuchElementException;
+import java.util.concurrent.TimeoutException;
+import javax.annotation.Nullable;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.SerializableCoder;
+import org.apache.beam.sdk.io.UnboundedSource;
+import org.apache.beam.sdk.options.PipelineOptions;
+import org.apache.beam.sdk.transforms.DoFn;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.transforms.ParDo;
+import
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[ https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=158469=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158469 ] ASF GitHub Bot logged work on BEAM-1240: Author: ASF GitHub Bot Created on: 25/Oct/18 03:27 Start Date: 25/Oct/18 03:27 Worklog Time Spent: 10m Work Description: jbonofre commented on issue #1729: [BEAM-1240] Create RabbitMqIO URL: https://github.com/apache/beam/pull/1729#issuecomment-432901834 @echauchot Squash & rebase done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 158469) Time Spent: 13h 40m (was: 13.5h) > Create RabbitMqIO > - > > Key: BEAM-1240 > URL: https://issues.apache.org/jira/browse/BEAM-1240 > Project: Beam > Issue Type: New Feature > Components: io-ideas >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 2.8.0 > > Time Spent: 13h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=155328=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155328
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 17/Oct/18 09:56
Start Date: 17/Oct/18 09:56
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #1729:
[BEAM-1240] Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#discussion_r225842769
##
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.Consumer;
+import com.rabbitmq.client.DefaultConsumer;
+import com.rabbitmq.client.Envelope;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.ServerSocket;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.apache.qpid.server.Broker;
+import org.apache.qpid.server.BrokerOptions;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Test of {@link RabbitMqIO}. */
+@RunWith(JUnit4.class)
+public class RabbitMqIOTest implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RabbitMqIOTest.class);
+
+ private static int port;
+ @ClassRule public static TemporaryFolder temporaryFolder = new
TemporaryFolder();
+
+ @Rule public transient TestPipeline p = TestPipeline.create();
+
+ private static transient Broker broker;
+
+ @BeforeClass
+ public static void startBroker() throws Exception {
+try (ServerSocket serverSocket = new ServerSocket(0)) {
+ port = serverSocket.getLocalPort();
+}
+
+System.setProperty("derby.stream.error.field", "MyApp.DEV_NULL");
+broker = new Broker();
+BrokerOptions options = new BrokerOptions();
+options.setConfigProperty(BrokerOptions.QPID_AMQP_PORT,
String.valueOf(port));
+options.setConfigProperty(BrokerOptions.QPID_WORK_DIR,
temporaryFolder.newFolder().toString());
+options.setConfigProperty(BrokerOptions.QPID_HOME_DIR, "src/test/qpid");
+broker.startup(options);
+ }
+
+ @AfterClass
+ public static void stopBroker() {
+broker.shutdown();
+ }
+
+ @Test
+ public void testReadQueue() throws Exception {
+final int maxNumRecords = 10;
+PCollection raw =
+p.apply(
+RabbitMqIO.read()
+.withUri("amqp://guest:guest@localhost:" + port)
+.withQueue("READ")
+.withMaxNumRecords(maxNumRecords));
+PCollection output =
+raw.apply(
+MapElements.into(TypeDescriptors.strings())
+.via(
+(RabbitMqMessage message) ->
+new String(message.getBody(),
StandardCharsets.UTF_8)));
+
+List records =
+generateRecords(maxNumRecords)
+.stream()
+.map(record -> new String(record, StandardCharsets.UTF_8))
+.collect(Collectors.toList());
+PAssert.that(output).containsInAnyOrder(records);
+
+ConnectionFactory connectionFactory = new ConnectionFactory();
+
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=155327=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155327
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 17/Oct/18 09:56
Start Date: 17/Oct/18 09:56
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #1729:
[BEAM-1240] Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#discussion_r225833559
##
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.Consumer;
+import com.rabbitmq.client.DefaultConsumer;
+import com.rabbitmq.client.Envelope;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.ServerSocket;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.apache.qpid.server.Broker;
+import org.apache.qpid.server.BrokerOptions;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Test of {@link RabbitMqIO}. */
+@RunWith(JUnit4.class)
+public class RabbitMqIOTest implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RabbitMqIOTest.class);
+
+ private static int port;
+ @ClassRule public static TemporaryFolder temporaryFolder = new
TemporaryFolder();
+
+ @Rule public transient TestPipeline p = TestPipeline.create();
+
+ private static transient Broker broker;
+
+ @BeforeClass
+ public static void startBroker() throws Exception {
+try (ServerSocket serverSocket = new ServerSocket(0)) {
+ port = serverSocket.getLocalPort();
+}
+
+System.setProperty("derby.stream.error.field", "MyApp.DEV_NULL");
+broker = new Broker();
+BrokerOptions options = new BrokerOptions();
+options.setConfigProperty(BrokerOptions.QPID_AMQP_PORT,
String.valueOf(port));
+options.setConfigProperty(BrokerOptions.QPID_WORK_DIR,
temporaryFolder.newFolder().toString());
+options.setConfigProperty(BrokerOptions.QPID_HOME_DIR, "src/test/qpid");
+broker.startup(options);
+ }
+
+ @AfterClass
+ public static void stopBroker() {
+broker.shutdown();
+ }
+
+ @Test
+ public void testReadQueue() throws Exception {
+final int maxNumRecords = 10;
+PCollection raw =
+p.apply(
+RabbitMqIO.read()
+.withUri("amqp://guest:guest@localhost:" + port)
+.withQueue("READ")
+.withMaxNumRecords(maxNumRecords));
+PCollection output =
+raw.apply(
+MapElements.into(TypeDescriptors.strings())
+.via(
+(RabbitMqMessage message) ->
+new String(message.getBody(),
StandardCharsets.UTF_8)));
+
+List records =
+generateRecords(maxNumRecords)
+.stream()
+.map(record -> new String(record, StandardCharsets.UTF_8))
+.collect(Collectors.toList());
+PAssert.that(output).containsInAnyOrder(records);
+
+ConnectionFactory connectionFactory = new ConnectionFactory();
+
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=155329=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155329
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 17/Oct/18 09:56
Start Date: 17/Oct/18 09:56
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #1729:
[BEAM-1240] Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#discussion_r225856265
##
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.Consumer;
+import com.rabbitmq.client.DefaultConsumer;
+import com.rabbitmq.client.Envelope;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.ServerSocket;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.apache.qpid.server.Broker;
+import org.apache.qpid.server.BrokerOptions;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Test of {@link RabbitMqIO}. */
+@RunWith(JUnit4.class)
+public class RabbitMqIOTest implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RabbitMqIOTest.class);
+
+ private static int port;
+ @ClassRule public static TemporaryFolder temporaryFolder = new
TemporaryFolder();
+
+ @Rule public transient TestPipeline p = TestPipeline.create();
+
+ private static transient Broker broker;
+
+ @BeforeClass
+ public static void startBroker() throws Exception {
+try (ServerSocket serverSocket = new ServerSocket(0)) {
+ port = serverSocket.getLocalPort();
+}
+
+System.setProperty("derby.stream.error.field", "MyApp.DEV_NULL");
+broker = new Broker();
+BrokerOptions options = new BrokerOptions();
+options.setConfigProperty(BrokerOptions.QPID_AMQP_PORT,
String.valueOf(port));
+options.setConfigProperty(BrokerOptions.QPID_WORK_DIR,
temporaryFolder.newFolder().toString());
+options.setConfigProperty(BrokerOptions.QPID_HOME_DIR, "src/test/qpid");
+broker.startup(options);
+ }
+
+ @AfterClass
+ public static void stopBroker() {
+broker.shutdown();
+ }
+
+ @Test
+ public void testReadQueue() throws Exception {
+final int maxNumRecords = 10;
+PCollection raw =
+p.apply(
+RabbitMqIO.read()
+.withUri("amqp://guest:guest@localhost:" + port)
+.withQueue("READ")
+.withMaxNumRecords(maxNumRecords));
+PCollection output =
+raw.apply(
+MapElements.into(TypeDescriptors.strings())
+.via(
+(RabbitMqMessage message) ->
+new String(message.getBody(),
StandardCharsets.UTF_8)));
+
+List records =
+generateRecords(maxNumRecords)
+.stream()
+.map(record -> new String(record, StandardCharsets.UTF_8))
+.collect(Collectors.toList());
+PAssert.that(output).containsInAnyOrder(records);
+
+ConnectionFactory connectionFactory = new ConnectionFactory();
+
[jira] [Work logged] (BEAM-1240) Create RabbitMqIO
[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=154191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154191
]
ASF GitHub Bot logged work on BEAM-1240:
Author: ASF GitHub Bot
Created on: 15/Oct/18 03:46
Start Date: 15/Oct/18 03:46
Worklog Time Spent: 10m
Work Description: jbonofre commented on a change in pull request #1729:
[BEAM-1240] Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#discussion_r225031911
##
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.Consumer;
+import com.rabbitmq.client.DefaultConsumer;
+import com.rabbitmq.client.Envelope;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.ServerSocket;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.DoFn;
+import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.qpid.server.Broker;
+import org.apache.qpid.server.BrokerOptions;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Test of {@link RabbitMqIO}. */
+@RunWith(JUnit4.class)
+public class RabbitMqIOTest implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RabbitMqIOTest.class);
+
+ private static int port;
+ @ClassRule public static TemporaryFolder temporaryFolder = new
TemporaryFolder();
+
+ @Rule public transient TestPipeline p = TestPipeline.create();
+
+ private static transient Broker broker;
+
+ @BeforeClass
+ public static void startBroker() throws Exception {
+try (ServerSocket serverSocket = new ServerSocket(0)) {
+ port = serverSocket.getLocalPort();
+}
+
+System.setProperty("derby.stream.error.field", "MyApp.DEV_NULL");
+broker = new Broker();
+BrokerOptions options = new BrokerOptions();
+options.setConfigProperty(BrokerOptions.QPID_AMQP_PORT,
String.valueOf(port));
+options.setConfigProperty(BrokerOptions.QPID_WORK_DIR,
temporaryFolder.newFolder().toString());
+options.setConfigProperty(BrokerOptions.QPID_HOME_DIR, "src/test/qpid");
+broker.startup(options);
+ }
+
+ @AfterClass
+ public static void stopBroker() {
+broker.shutdown();
+ }
+
+ @Test
+ public void testReadQueue() throws Exception {
+final int maxNumRecords = 10;
+PCollection raw =
+p.apply(
+RabbitMqIO.read()
+.withUri("amqp://guest:guest@localhost:" + port)
+.withQueue("READ")
+.withMaxNumRecords(maxNumRecords));
+PCollection output = raw.apply(ParDo.of(new ConverterFn()));
+
+List records = generateRecords(maxNumRecords);
+PAssert.that(output).containsInAnyOrder(records);
+
+ConnectionFactory connectionFactory = new ConnectionFactory();
+connectionFactory.setUri("amqp://guest:guest@localhost:" + port);
+Connection connection = connectionFactory.newConnection();
+Channel channel = connection.createChannel();
+channel.queueDeclare("READ", false, false, false, null);
+for (byte[] record : records) {
+ channel.basicPublish("", "READ", null, record);
+}
+
+p.run();
+
+channel.close();
