[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=417854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417854 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 07/Apr/20 17:58 Start Date: 07/Apr/20 17:58 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 417854) Time Spent: 3h 50m (was: 3h 40m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3h 50m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=417697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417697 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 07/Apr/20 14:06 Start Date: 07/Apr/20 14:06 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-610407671 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 417697) Time Spent: 3h 40m (was: 3.5h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3h 40m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=417136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417136 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 06/Apr/20 21:20 Start Date: 06/Apr/20 21:20 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-610042807 @chamikaramj any other comments? I might merge as Kamil has approved and your ocmments have been addressed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 417136) Time Spent: 3.5h (was: 3h 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3.5h > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=417135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417135 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 06/Apr/20 21:19 Start Date: 06/Apr/20 21:19 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-610042507 Failure is HDFS integration test. unrelated to this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 417135) Time Spent: 3h 20m (was: 3h 10m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3h 20m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=416508&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416508 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 06/Apr/20 10:57 Start Date: 06/Apr/20 10:57 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-609723986 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 416508) Time Spent: 3h 10m (was: 3h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3h 10m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=416507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416507 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 06/Apr/20 10:56 Start Date: 06/Apr/20 10:56 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-609723916 This time it failed because of `docker-credential-gcloud not installed or not available in PATH`. This is a known issue, we have a ticket for that: https://issues.apache.org/jira/browse/BEAM-8409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 416507) Time Spent: 3h (was: 2h 50m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 3h > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415808 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 22:58 Start Date: 03/Apr/20 22:58 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-608768810 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415808) Time Spent: 2h 50m (was: 2h 40m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2h 50m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415758 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 21:43 Start Date: 03/Apr/20 21:43 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350713 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -657,6 +664,10 @@ def estimate_size(self): kms_key=self.kms_key) size = int(job.statistics.totalBytesProcessed) return size +else: + # Size estimation is best effort. We return 0 as we have no + # access to the query that we're running. + return 0 Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415758) Time Spent: 2h 40m (was: 2.5h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2h 40m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415756 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 21:42 Start Date: 03/Apr/20 21:42 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350549 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 table = bq.get_table( - self.table_reference.projectId, - self.table_reference.datasetId, - self.table_reference.tableId) + table_ref.projectId, table_ref.datasetId, table_ref.tableId) return int(table.numBytes) -else: +elif self.query is not None and self.query.is_accessible(): job = bq._start_query_job( Review comment: if you look at line 663, it is a dry run : ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415756) Time Spent: 2h 20m (was: 2h 10m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2h 20m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415757 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 21:42 Start Date: 03/Apr/20 21:42 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350683 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415757) Time Spent: 2.5h (was: 2h 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2.5h > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415755 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 21:42 Start Date: 03/Apr/20 21:42 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350428 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 table = bq.get_table( - self.table_reference.projectId, - self.table_reference.datasetId, - self.table_reference.tableId) + table_ref.projectId, table_ref.datasetId, table_ref.tableId) return int(table.numBytes) -else: +elif self.query is not None and self.query.is_accessible(): Review comment: It is supported now. In this case, the `self.query` parameter is wrapped by a ValueProvider already. This does not work for `self.table` because it may be a non-string. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415755) Time Spent: 2h 10m (was: 2h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2h 10m > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415705 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 20:06 Start Date: 03/Apr/20 20:06 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-608634124 i dont understand why it's failing on permission issues now.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415705) Remaining Estimate: 0h (was: 10m) Time Spent: 2h (was: 1h 50m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 2h > Remaining Estimate: 0h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415206 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 00:24 Start Date: 03/Apr/20 00:24 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r402668065 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 table = bq.get_table( - self.table_reference.projectId, - self.table_reference.datasetId, - self.table_reference.tableId) + table_ref.projectId, table_ref.datasetId, table_ref.tableId) return int(table.numBytes) -else: +elif self.query is not None and self.query.is_accessible(): job = bq._start_query_job( Review comment: Not from this PR but shouldn't this be a dry run ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415206) Remaining Estimate: 10m (was: 20m) Time Spent: 1h 50m (was: 1h 40m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1h 50m > Remaining Estimate: 10m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415202 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 00:23 Start Date: 03/Apr/20 00:23 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r402668065 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 table = bq.get_table( - self.table_reference.projectId, - self.table_reference.datasetId, - self.table_reference.tableId) + table_ref.projectId, table_ref.datasetId, table_ref.tableId) return int(table.numBytes) -else: +elif self.query is not None and self.query.is_accessible(): job = bq._start_query_job( Review comment: For from this PR but shouldn't this be a dry run ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415202) Remaining Estimate: 0.5h (was: 40m) Time Spent: 1.5h (was: 1h 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1.5h > Remaining Estimate: 0.5h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415205 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 00:23 Start Date: 03/Apr/20 00:23 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r402669567 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 Review comment: We have to return None if size cannot be determined. See spec here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/iobase.py#L157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415205) Remaining Estimate: 20m (was: 0.5h) Time Spent: 1h 40m (was: 1.5h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1h 40m > Remaining Estimate: 20m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415204 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 00:23 Start Date: 03/Apr/20 00:23 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r402669596 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -657,6 +664,10 @@ def estimate_size(self): kms_key=self.kms_key) size = int(job.statistics.totalBytesProcessed) return size +else: + # Size estimation is best effort. We return 0 as we have no + # access to the query that we're running. + return 0 Review comment: Ditto. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415204) Remaining Estimate: 0.5h (was: 40m) Time Spent: 1.5h (was: 1h 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1.5h > Remaining Estimate: 0.5h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415203 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 03/Apr/20 00:23 Start Date: 03/Apr/20 00:23 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r402668608 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def __init__( def estimate_size(self): bq = bigquery_tools.BigQueryWrapper() if self.table_reference is not None: + table_ref = self.table_reference + if (isinstance(self.table_reference, vp.ValueProvider) and + self.table_reference.is_accessible()): +table_ref = bigquery_tools.parse_table_reference( +self.table_reference.get(), self.dataset, self.project) + elif isinstance(self.table_reference, vp.ValueProvider): +# Size estimation is best effort. We return 0 as we have no +# access to the table that we're querying. +return 0 table = bq.get_table( - self.table_reference.projectId, - self.table_reference.datasetId, - self.table_reference.tableId) + table_ref.projectId, table_ref.datasetId, table_ref.tableId) return int(table.numBytes) -else: +elif self.query is not None and self.query.is_accessible(): Review comment: Shouldn't we support ValueProvider for queries as well ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 415203) Remaining Estimate: 0.5h (was: 40m) Time Spent: 1.5h (was: 1h 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1.5h > Remaining Estimate: 0.5h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=414309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414309 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 01/Apr/20 21:58 Start Date: 01/Apr/20 21:58 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-607510701 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414309) Remaining Estimate: 40m (was: 50m) Time Spent: 1h 20m (was: 1h 10m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1h 20m > Remaining Estimate: 40m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=414210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414210 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 01/Apr/20 18:34 Start Date: 01/Apr/20 18:34 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-607421085 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 414210) Remaining Estimate: 50m (was: 1h) Time Spent: 1h 10m (was: 1h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1h 10m > Remaining Estimate: 50m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=413945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413945 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 01/Apr/20 10:07 Start Date: 01/Apr/20 10:07 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-607159015 This looks great! Thank you @pabloem, I have nothing to add This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413945) Remaining Estimate: 1h (was: 1h 10m) Time Spent: 1h (was: 50m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 1h > Remaining Estimate: 1h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=413593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413593 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 31/Mar/20 22:50 Start Date: 31/Mar/20 22:50 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-606925872 r: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413593) Remaining Estimate: 1h 10m (was: 1h 20m) Time Spent: 50m (was: 40m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 50m > Remaining Estimate: 1h 10m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=411785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411785 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 28/Mar/20 19:53 Start Date: 28/Mar/20 19:53 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-605510718 passing pc before formatting: https://builds.apache.org/job/beam_PostCommit_Python37_PR/122/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 411785) Remaining Estimate: 1h 20m (was: 1.5h) Time Spent: 40m (was: 0.5h) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 40m > Remaining Estimate: 1h 20m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=411244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411244 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 27/Mar/20 18:11 Start Date: 27/Mar/20 18:11 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-605181366 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 411244) Remaining Estimate: 1.5h (was: 1h 40m) Time Spent: 0.5h (was: 20m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 0.5h > Remaining Estimate: 1.5h > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=410744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410744 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 27/Mar/20 00:50 Start Date: 27/Mar/20 00:50 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_Vali
[jira] [Work logged] (BEAM-3097) Allow BigQuerySource to take a ValueProvider as a table input.
[ https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=410745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410745 ] ASF GitHub Bot logged work on BEAM-3097: Author: ASF GitHub Bot Created on: 27/Mar/20 00:50 Start Date: 27/Mar/20 00:50 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-604759269 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 410745) Remaining Estimate: 1h 40m (was: 1h 50m) Time Spent: 20m (was: 10m) > Allow BigQuerySource to take a ValueProvider as a table input. > -- > > Key: BEAM-3097 > URL: https://issues.apache.org/jira/browse/BEAM-3097 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ed Mothershaw >Priority: Minor > Original Estimate: 2h > Time Spent: 20m > Remaining Estimate: 1h 40m > > In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389. > When a ValueProvider is input as table the script will fail. -- This message was sent by Atlassian Jira (v8.3.4#803005)
