[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160281=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160281
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:42
Start Date: 29/Oct/18 22:42
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434107788
Well, that testclass already uses countdown latch here [1] or here [2],
which seem to solve similar issues.
Not sure, whether I like it, though. But, as I do not have any insights on
the code under test, I might just be a bit scared :)
[1]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L248
[2]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L751
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160281)
Time Spent: 4.5h (was: 4h 20m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160277=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160277
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:35
Start Date: 29/Oct/18 22:35
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434106134
Interesting. Can you put up your change? I had noticed the use of mocks
shared between threads, which is explicitly unsupported by Mockito, yet I'm not
sure our tests really are wrong. I figured we just needed to rewrite these
tests a different way. If we can do it with a latch, that's even better quick
fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160277)
Time Spent: 4h 20m (was: 4h 10m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160256=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160256
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:27
Start Date: 29/Oct/18 22:27
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434104379
Meanwhile I had a look into those failing tests.
Seemingly I was able to reproduce this failure locally, simply by executing
that test in a loop. Interestingly, it failed always at latest after the third
round.
AFAIU, this is a race condition on the thread calling verify [1] and the one
getting the captured value [2]. Obviously, the latter will fail if the first
did not complete yet.
To verify that observation, I added a countdown latch to ensure, thread_1
did finish the verification before accessing the value. With that change, that
(local) issue seemed to be fixed.
Feels unhealthy.
[1]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L736-L737
[2]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L666
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160256)
Time Spent: 4h 10m (was: 4h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160182
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 20:16
Start Date: 29/Oct/18 20:16
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 18543ced40d..edeafb73703 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -608,7 +608,7 @@ class BeamModulePlugin implements Plugin {
// Ensure that tests are packaged and part of the artifact set.
project.task('packageTests', type: Jar) {
-classifier = 'tests'
+classifier = 'tests-unshaded'
from project.sourceSets.test.output
}
project.artifacts.archives project.packageTests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160182)
Time Spent: 4h (was: 3h 50m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160148=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160148
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 19:46
Start Date: 29/Oct/18 19:46
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-434052779
Green including postcommit. Please take a look.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160148)
Time Spent: 3h 40m (was: 3.5h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160055=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160055
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:43
Start Date: 29/Oct/18 16:43
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433984777
Noting here too that it was only postcommits where parallel was enabled.
That was an oversight on my part. These tests run in both precommit and
postcommit, so enabling parallel in both at the same time will catch more
things like this next time around.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160055)
Time Spent: 3.5h (was: 3h 20m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160049=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160049
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:39
Start Date: 29/Oct/18 16:39
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433983150
The test that failed was using Mockito argument capture across threads, and
explicitly unsupported practice. It seems extremely likely that it was the
parallel build that caused that test to start failing. Just another data point
in moving forwards with parallel build efforts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160049)
Time Spent: 3h 20m (was: 3h 10m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160048
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:37
Start Date: 29/Oct/18 16:37
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433982459
OK, slightly more thinking and there's this: The failure was a unit test,
not an integration test. It is run in both precommit and postcommit, but only
postcommit failed. And only postcommit had enabled parallel builds. So I would
guess that the classifier fix is OK.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160048)
Time Spent: 3h 10m (was: 3h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160043
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:30
Start Date: 29/Oct/18 16:30
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433979726
R: @adude3141 @swegner
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160043)
Time Spent: 3h (was: 2h 50m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160042=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160042
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:30
Start Date: 29/Oct/18 16:30
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433979552
Also, notably #6864 only re-enable parallel builds for postcommit. That was
an oversight on my part. If it had also re-enabled for precommit, it would
likely have been caught there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160042)
Time Spent: 2h 50m (was: 2h 40m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160040=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160040
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:29
Start Date: 29/Oct/18 16:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433979093
Seed job has re-disabled parallel builds for postcommits, so going to run
them against just this fix. This fix also speeds things up for local dev, so
has value on its own.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160040)
Time Spent: 2.5h (was: 2h 20m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160041=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160041
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:29
Start Date: 29/Oct/18 16:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868#issuecomment-433979153
run java postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160041)
Time Spent: 2h 40m (was: 2.5h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[ https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160039=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160039 ] ASF GitHub Bot logged work on BEAM-5887: Author: ASF GitHub Bot Created on: 29/Oct/18 16:26 Start Date: 29/Oct/18 16:26 Worklog Time Spent: 10m Work Description: kennknowles opened a new pull request #6868: [BEAM-5887] Rollforward "Fix classifier for unshaded tests" URL: https://github.com/apache/beam/pull/6868 Rolling forward this fix, which we can test against postcommit without re-enabling parallel builds. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 160039) Time Spent: 2h 20m (was: 2h 10m) > packageTests and shadowTestJar write the same file >
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160033=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160033
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:23
Start Date: 29/Oct/18 16:23
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433977018
:-(
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160033)
Time Spent: 2h 10m (was: 2h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160029=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160029
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:17
Start Date: 29/Oct/18 16:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433974309
Filed https://issues.apache.org/jira/browse/BEAM-5908 and will track
rollbacks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160029)
Time Spent: 2h (was: 1h 50m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160025=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160025
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 16:07
Start Date: 29/Oct/18 16:07
Worklog Time Spent: 10m
Work Description: swegner commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433970529
FYI, Java PostCommits broke as part of this change:
https://github.com/apache/beam/pull/6864
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 160025)
Time Spent: 1h 50m (was: 1h 40m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159792
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 01:43
Start Date: 29/Oct/18 01:43
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/job_PostCommit_Java_GradleBuild.groovy
b/.test-infra/jenkins/job_PostCommit_Java_GradleBuild.groovy
index 81a47631ec1..e2b1515bad0 100644
--- a/.test-infra/jenkins/job_PostCommit_Java_GradleBuild.groovy
+++ b/.test-infra/jenkins/job_PostCommit_Java_GradleBuild.groovy
@@ -43,8 +43,6 @@
PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java_GradleBuild', 'Run Java
commonJobProperties.setGradleSwitches(delegate)
// Specify maven home on Jenkins, needed by Maven archetype integration
tests.
switches('-Pmaven_home=/home/jenkins/tools/maven/apache-maven-3.5.2')
- // BEAM-5035: Parallel builds are very flaky
- switches('--no-parallel')
}
}
}
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 18543ced40d..edeafb73703 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -608,7 +608,7 @@ class BeamModulePlugin implements Plugin {
// Ensure that tests are packaged and part of the artifact set.
project.task('packageTests', type: Jar) {
-classifier = 'tests'
+classifier = 'tests-unshaded'
from project.sourceSets.test.output
}
project.artifacts.archives project.packageTests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159792)
Time Spent: 1h 40m (was: 1.5h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159790=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159790
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 01:43
Start Date: 29/Oct/18 01:43
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433764128
I think this is clear enough to merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159790)
Time Spent: 1.5h (was: 1h 20m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159782
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 29/Oct/18 00:03
Start Date: 29/Oct/18 00:03
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433754989
Ah... no sorry. forgot to mention:
I ve also that change on google cloud data flow worker thingy switching to
osx libraries, as otherwise it will bark at me on unsatisfied links.
But that should not have any impact on this issue at all.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159782)
Time Spent: 1h 20m (was: 1h 10m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159781
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 23:58
Start Date: 28/Oct/18 23:58
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433754633
LGTM
@kennknowles
I can confirm that
a: The change in commit '53753c8' is the only change I did to get to the
improvements with incremental build (i.e. rebuilding time without any changes
cut to 50% on my machine)
b: after applying that change I was able to enable parallel build (excluding
python/go/website which still cause me headaches), whereas without that fix I m
required to disable parallel build by adding option '--no-parallel'
Of course, that's not a proper testing so should be seen as a hint to
improvement at best.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159781)
Time Spent: 1h 10m (was: 1h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159780=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159780
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:54
Start Date: 28/Oct/18 22:54
Worklog Time Spent: 10m
Work Description: kennknowles edited a comment on issue #6864:
[BEAM-5887] Fix classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433750070
First, this is clearly a bugfix whether or not it works (so only my second
commit is questionable). We shouldn't be writing unshaded artifacts to
classifiers that don't scream `unshaded`. Ultimately "unshaded" sort of means
"funky invalid artifact, use at your own risk".
Now, actually trying to verify: It is crude, but I ran `/gradlew
:beam-sdks-java-core:shadowTestJar :beam-sdks-java-core:packageTests` on master
and on this PR with `fswatch sdks/java/core/build | grep jar` in another shell.
`master`:
```
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
```
This PR:
```
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests-unshaded.jar
```
It doesn't tell me much; I did not work super hard to associate the timings
with tasks, etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159780)
Time Spent: 1h (was: 50m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159779=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159779
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:52
Start Date: 28/Oct/18 22:52
Worklog Time Spent: 10m
Work Description: kennknowles edited a comment on issue #6864:
[BEAM-5887] Fix classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433750070
First, this is clearly a bugfix whether or not it works (so only my second
commit is questionable). We shouldn't be writing unshaded artifacts to
classifiers that don't scream `unshaded`. Ultimately "unshaded" sort of means
"funky invalid artifact, use at your own risk".
Now, actually trying to verify: It is crude, but I ran `/gradlew
:beam-sdks-java-core:shadowTestJar :beam-sdks-java-core:packageTests` on master
and on this PR with `fswatch sdks/java/core/build | grep jar` in another shell.
`master`:
```
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
```
This PR:
```
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests-unshaded.jar
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159779)
Time Spent: 50m (was: 40m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159778=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159778
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:52
Start Date: 28/Oct/18 22:52
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433750070
First, this is clearly a bugfix whether or not it works (so only my second
commit is questionable). We shouldn't be writing unshaded artifacts to
classifiers that don't scream `unshaded`. Ultimately "unshaded" sort of means
"funky invalid artifact, use at your own risk".
Now, actually trying to verify: It is crude, but I ran `/gradlew
:beam-sdks-java-core:shadowTestJar :beam-sdks-java-core:packageTests` on master
and on this PR with `fswatch sdks/java/core/build | grep jar` in another shell.
`master`:
```
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
```
This PR:
```
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests-unshaded.jar
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159778)
Time Spent: 40m (was: 0.5h)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159777
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:32
Start Date: 28/Oct/18 22:32
Worklog Time Spent: 10m
Work Description: swegner commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433747952
I'm very excited about this. Any thoughts on how we can validate that this
actually fixed the flakiness? The linked JIRA mentions using
[inotifywatch](https://linux.die.net/man/1/inotifywatch)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159777)
Time Spent: 0.5h (was: 20m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159776=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159776
]
ASF GitHub Bot logged work on BEAM-5887:
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:29
Start Date: 28/Oct/18 22:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433747598
R: @adude3141
If you give me an LGTM that this is all you did to make the improvement,
I'll merge it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159776)
Time Spent: 20m (was: 10m)
> packageTests and shadowTestJar write the same file
> --
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5887) packageTests and shadowTestJar write the same file
[ https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159759 ] ASF GitHub Bot logged work on BEAM-5887: Author: ASF GitHub Bot Created on: 28/Oct/18 20:35 Start Date: 28/Oct/18 20:35 Worklog Time Spent: 10m Work Description: kennknowles opened a new pull request #6864: [BEAM-5887] Fix classifier for unshaded tests jars URL: https://github.com/apache/beam/pull/6864 Unshaded and shaded tests are being written to the same classifier. This fixes that and restores parallel builds. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 159759) Time Spent: 10m Remaining Estimate: 0h > packageTests and shadowTestJar write the same file >
