[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=189692=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189692 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 24/Jan/19 21:07 Start Date: 24/Jan/19 21:07 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javaDocMethod URL: https://github.com/apache/beam/pull/7532 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189692) Time Spent: 10h 20m (was: 10h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 10h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=189654=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189654 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 24/Jan/19 19:55 Start Date: 24/Jan/19 19:55 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-457334156 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189654) Time Spent: 10h (was: 9h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 10h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=189652=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189652 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 24/Jan/19 19:54 Start Date: 24/Jan/19 19:54 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-457333792 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189652) Time Spent: 9h 40m (was: 9.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=189656=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189656 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 24/Jan/19 20:02 Start Date: 24/Jan/19 20:02 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-457336629 synced to HEAD and now shows all green This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189656) Time Spent: 10h 10m (was: 10h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 10h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=189653=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189653 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 24/Jan/19 19:55 Start Date: 24/Jan/19 19:55 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-457334112 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189653) Time Spent: 9h 50m (was: 9h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=188476=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188476 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 22/Jan/19 20:40 Start Date: 22/Jan/19 20:40 Worklog Time Spent: 10m Work Description: swegner commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-456554858 Thanks, will merge when green. @HuangLED looks like something broke with the rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188476) Time Spent: 9.5h (was: 9h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=188418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188418 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 22/Jan/19 18:38 Start Date: 22/Jan/19 18:38 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-456513114 I self-requested a review to make sure this showed up in https://github.com/pulls/review-requested, just as a system to not let reviews languish. LGTM from any committer is enough for me here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188418) Time Spent: 9h 20m (was: 9h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=188335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188335 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 22/Jan/19 16:53 Start Date: 22/Jan/19 16:53 Worklog Time Spent: 10m Work Description: swegner commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-456474723 This change looks good to me-- please rebase ontop of master to validate current suppressions and then we can merge. I see @kennknowles is also marked for review; did you want a second review before merging? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188335) Time Spent: 9h 10m (was: 9h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=187143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187143 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 23:17 Start Date: 18/Jan/19 23:17 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-455718323 Also, this PR, when merging, most likely will require an update on the suppresions. Ping me beforehand, I can take care of the manual update. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187143) Time Spent: 9h (was: 8h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 9h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=187138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187138 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 23:15 Start Date: 18/Jan/19 23:15 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249212651 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: 3 numbers refer to 3 functions (in the same file) that all violate our check, each number for one distinct function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187138) Time Spent: 8h 50m (was: 8h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=187121=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187121 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 22:48 Start Date: 18/Jan/19 22:48 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249208445 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: Got it. So the 3 numbers here refer to different method lengths? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187121) Time Spent: 8h 40m (was: 8.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=187008=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187008 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 19:36 Start Date: 18/Jan/19 19:36 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249162079 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=187013=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187013 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 19:42 Start Date: 18/Jan/19 19:42 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249163592 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: For conciseness. The intention is indeed to have the full file name (in this particular case BigqueryClient.java is a full file name). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187013) Time Spent: 8.5h (was: 8h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186999=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186999 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 19:00 Start Date: 18/Jan/19 19:00 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249150468 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + + + + + + + + + + + + + + + + + + + + + + + + Review comment: Is this multiple file suppressions collapsed to a single line? And is this just for conciseness? One downside is that it obfuscates a bit where the actual errors are. Perhaps it would be better to have each line here at least have the full filename so that individuals could quickly identify where they need to fix something. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186999) Time Spent: 8h 10m (was: 8h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186998 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 19:00 Start Date: 18/Jan/19 19:00 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#discussion_r249149538 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -30,4 +30,65 @@ + + > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 8h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186648=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186648 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 18/Jan/19 01:21 Start Date: 18/Jan/19 01:21 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-455392831 R: @robertwb @kennknowles CC: @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186648) Time Spent: 7h 50m (was: 7h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186486 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 17/Jan/19 18:29 Start Date: 17/Jan/19 18:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-455278099 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186486) Time Spent: 7h 40m (was: 7.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186484 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 17/Jan/19 18:29 Start Date: 17/Jan/19 18:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-455278031 Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186484) Time Spent: 7h 20m (was: 7h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186485 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 17/Jan/19 18:29 Start Date: 17/Jan/19 18:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Make checkstyle report error on missing javadocmethod URL: https://github.com/apache/beam/pull/7532#issuecomment-455278031 Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186485) Time Spent: 7.5h (was: 7h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186068=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186068 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 17/Jan/19 00:00 Start Date: 17/Jan/19 00:00 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454990516 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186068) Time Spent: 7h 10m (was: 7h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186060=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186060 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 23:46 Start Date: 16/Jan/19 23:46 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454987507 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186060) Time Spent: 7h (was: 6h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 7h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186056=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186056 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 23:31 Start Date: 16/Jan/19 23:31 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454984235 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186056) Time Spent: 6h 50m (was: 6h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 6h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186049=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186049 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 23:11 Start Date: 16/Jan/19 23:11 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454979928 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186049) Time Spent: 6h 40m (was: 6.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 6h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186007=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186007 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 21:37 Start Date: 16/Jan/19 21:37 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454949944 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186007) Time Spent: 6h 20m (was: 6h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 6h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=186004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186004 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 21:30 Start Date: 16/Jan/19 21:30 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454949944 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186004) Time Spent: 6h 10m (was: 6h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 6h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185998 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 21:23 Start Date: 16/Jan/19 21:23 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454947371 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185998) Time Spent: 6h (was: 5h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 6h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185965 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 20:04 Start Date: 16/Jan/19 20:04 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454920457 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185965) Time Spent: 5h 40m (was: 5.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185970=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185970 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 20:12 Start Date: 16/Jan/19 20:12 Worklog Time Spent: 10m Work Description: asfgit commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454922790 SUCCESS --none-- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185970) Time Spent: 5h 50m (was: 5h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185955=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185955 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 19:41 Start Date: 16/Jan/19 19:41 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454912555 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185955) Time Spent: 5.5h (was: 5h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185947=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185947 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 19:29 Start Date: 16/Jan/19 19:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454908415 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185947) Time Spent: 5h 20m (was: 5h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185943=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185943 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 19:17 Start Date: 16/Jan/19 19:17 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454904201 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185943) Time Spent: 5h 10m (was: 5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185935=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185935 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 18:44 Start Date: 16/Jan/19 18:44 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454893262 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185935) Time Spent: 5h (was: 4h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185934=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185934 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 18:43 Start Date: 16/Jan/19 18:43 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454893149 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185934) Time Spent: 4h 50m (was: 4h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 4h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185912=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185912 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 17:51 Start Date: 16/Jan/19 17:51 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454874902 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185912) Time Spent: 4h 40m (was: 4.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 4h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185600=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185600 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 05:36 Start Date: 16/Jan/19 05:36 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454658261 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185600) Time Spent: 4h 20m (was: 4h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 4h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185590 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 05:04 Start Date: 16/Jan/19 05:04 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532#issuecomment-454653125 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185590) Time Spent: 4h 10m (was: 4h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 4h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=185574=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185574 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 16/Jan/19 04:39 Start Date: 16/Jan/19 04:39 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7532: [BEAM-6184]Turn on javadocmethod checkstyle to report error. URL: https://github.com/apache/beam/pull/7532 1. Turn on javadocmethod checkstyle (reports error) 2. Added suppressions to all the violations. Created another beam-6446 to track the future progress of removing suppressions. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ---
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184736 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 14/Jan/19 09:52 Start Date: 14/Jan/19 09:52 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184736) Time Spent: 3h 50m (was: 3h 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3h 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184735 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 14/Jan/19 09:51 Start Date: 14/Jan/19 09:51 Worklog Time Spent: 10m Work Description: robertwb commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453949136 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184735) Time Spent: 3h 40m (was: 3.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184471=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184471 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 12/Jan/19 03:06 Start Date: 12/Jan/19 03:06 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453714516 Was trying to include a few examples on how to define a suppressio. Now the example is moved into xml file as comment. PR Updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184471) Time Spent: 3.5h (was: 3h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184465=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184465 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 12/Jan/19 02:31 Start Date: 12/Jan/19 02:31 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453705069 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184465) Time Spent: 3h 10m (was: 3h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3h 10m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184466 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 12/Jan/19 02:31 Start Date: 12/Jan/19 02:31 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453712318 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184466) Time Spent: 3h 20m (was: 3h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184453 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 12/Jan/19 01:05 Start Date: 12/Jan/19 01:05 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453705069 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184453) Time Spent: 3h (was: 2h 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 3h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184396
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 23:06
Start Date: 11/Jan/19 23:06
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247280005
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageFunction.java
##
@@ -331,10 +331,8 @@ private void fireTimer(
public void close() throws Exception {
// close may be called multiple times when an exception is thrown
if (stageContext != null) {
- try (@SuppressWarnings("unused")
Review comment:
Sounds good to me. If we care about unused variables, we can turn it on
again. Removed the not-needed annotation is an improvement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184396)
Time Spent: 2h 50m (was: 2h 40m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184394=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184394
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 23:04
Start Date: 11/Jan/19 23:04
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247245595
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamTableUtils.java
##
@@ -90,6 +90,7 @@ public static String beamRow2CsvLine(Row row, CSVFormat
csvFormat) {
return writer.toString();
}
+ @SuppressWarnings("checkstyle:JavadocMethod")
Review comment:
Seems like it should have documentation. I suggest `Attempt to cast an
object to a specified Schema.Field.Type @throws IllegalArgumentException if the
value cannot be cast to that type`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184394)
Time Spent: 2h 40m (was: 2.5h)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184390 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 11/Jan/19 22:56 Start Date: 11/Jan/19 22:56 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#discussion_r247278467 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -21,6 +21,11 @@ + + + Review comment: Done. Removed. (apology after pulling from master and push again, the file status gets out of sync). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184390) Time Spent: 2.5h (was: 2h 20m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 2.5h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184350=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184350 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 11/Jan/19 21:05 Start Date: 11/Jan/19 21:05 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#discussion_r247253184 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -21,6 +21,11 @@ + + + Review comment: Good point. sending an update This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184350) Time Spent: 2h 20m (was: 2h 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 2h 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184347=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184347
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 21:04
Start Date: 11/Jan/19 21:04
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247253024
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/annotations/Experimental.java
##
@@ -39,6 +39,7 @@
ElementType.TYPE
})
@Documented
+@SuppressWarnings("checkstyle:JavadocMethod")
Review comment:
Ok. let me remove this one. I was misled by the @Documented annotation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184347)
Time Spent: 2h (was: 1h 50m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184349
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 21:05
Start Date: 11/Jan/19 21:05
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247253024
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/annotations/Experimental.java
##
@@ -39,6 +39,7 @@
ElementType.TYPE
})
@Documented
+@SuppressWarnings("checkstyle:JavadocMethod")
Review comment:
Ok. let me remove this one. :-) I was misled by the @Documented annotation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184349)
Time Spent: 2h 10m (was: 2h)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184344=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184344
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 21:03
Start Date: 11/Jan/19 21:03
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247252770
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageFunction.java
##
@@ -331,10 +331,8 @@ private void fireTimer(
public void close() throws Exception {
// close may be called multiple times when an exception is thrown
if (stageContext != null) {
- try (@SuppressWarnings("unused")
Review comment:
In this particular place, these @SuppressWarnings were removed because no
longer
needed (that is, without them, none of our tool gives complains).
SuppressWarnings is something that less is always better, thus I took the
liberty removing them. :-)
One side note, and also to @kennknowles 's question: Yes, it should be
either by javac or findbugs. checkstyle does not cover unused. The fact is ,
check/warning on unused-local-variable is completely turned off everywhere in
our code base.
I tested and verified by intentionally adding ones but no tool complains on
that, thus I assume it is intended behavior. If it is not expected (is that
so?), that deserves further investigation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184344)
Time Spent: 1h 50m (was: 1h 40m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184335
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 20:30
Start Date: 11/Jan/19 20:30
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247245058
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/annotations/Experimental.java
##
@@ -39,6 +39,7 @@
ElementType.TYPE
})
@Documented
+@SuppressWarnings("checkstyle:JavadocMethod")
Review comment:
Seems like it should have documentation. I suggest `You can indicate a
category for the experimental feature. This is unused and serves only as a hint
to the reader.`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184335)
Time Spent: 1.5h (was: 1h 20m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184334=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184334
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 20:30
Start Date: 11/Jan/19 20:30
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7454:
[BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247244427
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageFunction.java
##
@@ -331,10 +331,8 @@ private void fireTimer(
public void close() throws Exception {
// close may be called multiple times when an exception is thrown
if (stageContext != null) {
- try (@SuppressWarnings("unused")
Review comment:
This would be a javac or findbugs issue, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184334)
Time Spent: 1.5h (was: 1h 20m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184336=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184336 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 11/Jan/19 20:30 Start Date: 11/Jan/19 20:30 Worklog Time Spent: 10m Work Description: kennknowles commented on pull request #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#discussion_r247244945 ## File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml ## @@ -21,6 +21,11 @@ + + + Review comment: I'm not sure about this one. If it is not in a `src/test` directory then it is not tests, but utility code that needs documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 184336) Time Spent: 1h 40m (was: 1.5h) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 1h 40m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184199=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184199
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 13:07
Start Date: 11/Jan/19 13:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247108510
##
File path:
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java
##
@@ -133,7 +133,7 @@ private static void produce(Map messages)
{
Serializer stringSerializer = new StringSerializer();
Serializer instantSerializer = new InstantSerializer();
-try (@SuppressWarnings("unchecked")
Review comment:
Similarly, this looks valid.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184199)
Time Spent: 1h 20m (was: 1h 10m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=184198=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184198
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 11/Jan/19 13:07
Start Date: 11/Jan/19 13:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454#discussion_r247108408
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageFunction.java
##
@@ -331,10 +331,8 @@ private void fireTimer(
public void close() throws Exception {
// close may be called multiple times when an exception is thrown
if (stageContext != null) {
- try (@SuppressWarnings("unused")
Review comment:
Are these no longer needed by any of our tools?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 184198)
Time Spent: 1h 10m (was: 1h)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=183842=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183842 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 10/Jan/19 18:21 Start Date: 10/Jan/19 18:21 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-453200155 R: @robertwb @kennknowles CC: @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 183842) Time Spent: 1h (was: 50m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 1h > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=183537=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183537 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 10/Jan/19 06:38 Start Date: 10/Jan/19 06:38 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods URL: https://github.com/apache/beam/pull/7454#issuecomment-452987079 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 183537) Time Spent: 50m (was: 40m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Fix For: Not applicable > > Time Spent: 50m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=183473=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183473
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 10/Jan/19 01:05
Start Date: 10/Jan/19 01:05
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7454: [BEAM-6184]
Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454
This PR includes:
1) Enforce javadoc checkstyle rules on public non-trivial (> 30Loc) methods.
2) added an exmaple of @SuppressWarnings("checkstyle:JavadocMethod") in
BeamTableUtils.java
3) Removed a few compiler suppresses that no longer needed (and do not work
with checkstyle's naming convention).
In this PR the violations are shown as warnings, for following step, we
could either
a) keep them as warnings, and switch to error when all are addressed (either
adding comment or suppress).
b) change them into errors, and add explicit suppression rules to all
violations. Contributors eliminate and chop off these violations over time.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [X ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [![Build
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[
https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=172644=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172644
]
ASF GitHub Bot logged work on BEAM-6184:
Author: ASF GitHub Bot
Created on: 06/Dec/18 13:42
Start Date: 06/Dec/18 13:42
Worklog Time Spent: 10m
Work Description: robertwb closed pull request #7213: [BEAM-6184] Add
portable-runner dependency to example pom.xml
URL: https://github.com/apache/beam/pull/7213
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
b/sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
index dcd9748311a9..5f1ba8b3490e 100644
---
a/sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
+++
b/sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml
@@ -167,6 +167,22 @@
+
+ portable-runner
+
+true
+
+
+
+
+ org.apache.beam
+ beam-runners-reference-java
+ ${beam.version}
+ runtime
+
+
+
+
apex-runner
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 172644)
Time Spent: 0.5h (was: 20m)
> PortableRunner dependency missed in wordcount example maven artifact
>
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
>
>
> more context:
> https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=172473=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172473 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 05/Dec/18 20:34 Start Date: 05/Dec/18 20:34 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7213: [BEAM-6184] Add portable-runner dependency to example pom.xml URL: https://github.com/apache/beam/pull/7213#issuecomment-444636635 R: @youngoli This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 172473) Time Spent: 20m (was: 10m) > PortableRunner dependency missed in wordcount example maven artifact > > > Key: BEAM-6184 > URL: https://issues.apache.org/jira/browse/BEAM-6184 > Project: Beam > Issue Type: Improvement > Components: build-system >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > > > more context: > https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=172463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172463 ] ASF GitHub Bot logged work on BEAM-6184: Author: ASF GitHub Bot Created on: 05/Dec/18 19:59 Start Date: 05/Dec/18 19:59 Worklog Time Spent: 10m Work Description: HuangLED opened a new pull request #7213: [BEAM-6184] Add portable-runner dependency to example pom.xml URL: https://github.com/apache/beam/pull/7213 Add portable-runner to example pom.xml's default dependency list. Follow this checklist to help us incorporate your contribution quickly and easily: - [ X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 172463) Time Spent: 10m Remaining Estimate: 0h > PortableRunner dependency missed in wordcount example maven artifact >
