[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187359
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 16:11
Start Date: 19/Jan/19 16:11
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7456: [BEAM-6404] Fix issue
with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455792996
Jira issue: https://issues.apache.org/jira/browse/BEAM-6473
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187359)
Time Spent: 2h (was: 1h 50m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187347
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 15:47
Start Date: 19/Jan/19 15:47
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7456: [BEAM-6404] Fix issue
with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455791083
I see you modified the test. ValidatesRunner in PreCommit would have been
useful here. Fine for me to disable the test if this is a limitation of the
Flink side input, though I'm not sure it is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187347)
Time Spent: 1h 50m (was: 1h 40m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187346
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 15:42
Start Date: 19/Jan/19 15:42
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7456: [BEAM-6404] Fix issue
with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455790695
```
ERROR: test_flattened_side_input (_main_.FlinkRunnerTest)
--
Traceback (most recent call last)
File "apache_beam/runners/portability/fn_api_runner_test.py", line 205, in
test_flattened_side_input
label='CheckFlattenOfSideInput')
File "apache_beam/pipeline.py", line 425, in _exit_
self.run().wait_until_finish()
File "apache_beam/runners/portability/portable_runner.py", line 349, in
wait_until_finish
self._job_id, self._state, self._last_error_message()))
RuntimeError: Pipeline
test_flattened_side_input_1547859357.36_07dcde9b-acfc-4e8d-b930-582f7637a07e
failed in state FAILED: java.lang.IllegalArgumentException: PCollectionNodes
[PCollectionNode
{id=ref_PCollection_PCollection_12, PCollection=unique_name:
"17side3/Map(decode).None" coder_id: "ref_Coder_BytesCoder_1" is_bounded:
BOUNDED windowing_strategy_id: "ref_Windowing_Windowing_1" }
] were consumed but never produced```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187346)
Time Spent: 1h 40m (was: 1.5h)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187345
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 15:40
Start Date: 19/Jan/19 15:40
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7456: [BEAM-6404] Fix issue
with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455790568
The test was passing before. Looks like it broken due to the coder changes
in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187345)
Time Spent: 1.5h (was: 1h 20m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187329
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 09:30
Start Date: 19/Jan/19 09:30
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #7456: [BEAM-6404] Fix
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455764181
Hmm... I think that this is the new test that was always broken on Flink.
I'll see how hard it is to roll forward, otherwise we can disable this in the
meantime.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187329)
Time Spent: 1h 20m (was: 1h 10m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187291
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 02:12
Start Date: 19/Jan/19 02:12
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #7456: [BEAM-6404] Fix
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455740438
The PR break the build
https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink_PR/133/console
1st commit "Cleanup coder windowing." seems to be the cause.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187291)
Time Spent: 1h (was: 50m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=187292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187292
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 19/Jan/19 02:12
Start Date: 19/Jan/19 02:12
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #7456: [BEAM-6404] Fix
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-455740438
The PR break the build
https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink_PR/133/console
2nd commit "[BEAM-6404] Fix issue with side inputs and flatten encoding.."
seems to be the cause.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 187292)
Time Spent: 1h 10m (was: 1h)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=186778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186778
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 18/Jan/19 08:21
Start Date: 18/Jan/19 08:21
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7456: [BEAM-6404]
Fix issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 186778)
Time Spent: 50m (was: 40m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=185240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185240
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 15/Jan/19 12:36
Start Date: 15/Jan/19 12:36
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7456: [BEAM-6404]
Fix issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#discussion_r247874910
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner_transforms.py
##
@@ -591,7 +591,6 @@ def sink_flattens(stages, pipeline_context):
if pcollections[pcoll_in].coder_id != output_coder_id:
# Flatten inputs must all be written with the same coder as is
Review comment:
Thanks. Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 185240)
Time Spent: 40m (was: 0.5h)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=185097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185097
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 15/Jan/19 03:31
Start Date: 15/Jan/19 03:31
Worklog Time Spent: 10m
Work Description: udim commented on pull request #7456: [BEAM-6404] Fix
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#discussion_r247754156
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner_transforms.py
##
@@ -591,7 +591,6 @@ def sink_flattens(stages, pipeline_context):
if pcollections[pcoll_in].coder_id != output_coder_id:
# Flatten inputs must all be written with the same coder as is
Review comment:
I think this comment would be better like this:
`Flatten requires that all its inputs use the same coder as its output. Add
stages to transcode Flatten inputs that do not use the same coder.`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 185097)
Time Spent: 0.5h (was: 20m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[
https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=183652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183652
]
ASF GitHub Bot logged work on BEAM-6404:
Author: ASF GitHub Bot
Created on: 10/Jan/19 10:53
Start Date: 10/Jan/19 10:53
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #7456: [BEAM-6404] Fix
issue with side inputs and flatten encoding.
URL: https://github.com/apache/beam/pull/7456#issuecomment-453054056
R: @udim
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 183652)
Time Spent: 20m (was: 10m)
> FnAPI translation error
> ---
>
> Key: BEAM-6404
> URL: https://issues.apache.org/jira/browse/BEAM-6404
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
>Reporter: Robert Bradshaw
>Assignee: Robert Bradshaw
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> def run(argv=None):
> parser = argparse.ArgumentParser()
> _, pipeline_args = parser.parse_known_args(argv)
> options = pipeline_options.PipelineOptions(pipeline_args)
> numbers = [1, 2]
> with beam.Pipeline(options=options) as p:
> sum_1 = (p
> | 'ReadNumber1' >> transforms.Create(numbers)
> | 'CalculateSum1' >> beam.CombineGlobally(fn_sum))
> sum_2 = (p
> | 'ReadNumber2' >> transforms.Create(numbers)
> | beam.ParDo(_copy_number, pvalue.AsSingleton(sum_1))
> | 'CalculateSum2' >> beam.CombineGlobally(fn_sum))
> _ = ((sum_1, sum_2)
> | beam.Flatten()
> | 'CalculateSum3' >> beam.CombineGlobally(fn_sum)
> | beam.io.WriteToText('out.txt'))
> run()
> {code}
>
> fails with
> KeyError: u'ref_Coder_FastPrimitivesCoder_4_windowed'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6404) FnAPI translation error
[ https://issues.apache.org/jira/browse/BEAM-6404?focusedWorklogId=183651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183651 ] ASF GitHub Bot logged work on BEAM-6404: Author: ASF GitHub Bot Created on: 10/Jan/19 10:52 Start Date: 10/Jan/19 10:52 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #7456: [BEAM-6404] Fix issue with side inputs and flatten encoding. URL: https://github.com/apache/beam/pull/7456 The first commit is just a cleanup that turned out to not be essential to the fix, but was helpful in debugging and resolves a TODO. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 183651)
