[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=186064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186064
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 23:56
Start Date: 16/Jan/19 23:56
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on pull request #7531: [BEAM-6447] 
Turn off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 186064)
Time Spent: 3h 10m  (was: 3h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=186057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186057
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 23:38
Start Date: 16/Jan/19 23:38
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454985815
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 186057)
Time Spent: 3h  (was: 2h 50m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185919
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 18:12
Start Date: 16/Jan/19 18:12
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454882376
 
 
   I think the problem is that the beam1 executor is in a bad state, and this
   keeps getting scheduled on that executor.
   
   On Wed, Jan 16, 2019 at 10:05 AM Ruoyun Huang 
   wrote:
   
   > I don't think re-run updates the merge commit, so I'll need to rebase to
   > have a hope of getting green. Since it is non-urgent I'll do that rather
   > than merge on partial green, even though the tests are obviously not
   > relevant.
   >
   > I have a pending PR with same issue as here. I already tried rebase, then
   > force push to github but no difference. I am trying to run
   > ::beam-runners-google-cloud-dataflow-java-examples:preCommit on my local
   > machine to see what happens.
   >
   > —
   > You are receiving this because your review was requested.
   > Reply to this email directly, view it on GitHub
   > , or mute
   > the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185919)
Time Spent: 2h 40m  (was: 2.5h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185926
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 18:17
Start Date: 16/Jan/19 18:17
Worklog Time Spent: 10m 
  Work Description: HuangLED commented on issue #7531: [BEAM-6447] Turn off 
spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454884287
 
 
   > I think the problem is that the beam1 executor is in a bad state, and this 
keeps getting scheduled on that executor.
   > […](#)
   
   Guess that is the case.  Local run of 
:beam-runners-google-cloud-dataflow-java-examples:preCommit from HEAD passed. 
No issue. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185926)
Time Spent: 2h 50m  (was: 2h 40m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185883
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 17:12
Start Date: 16/Jan/19 17:12
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454861176
 
 
   Java_Examples_Dataflow PreCommit is failing on my PRs as well.
   
   On Wed, Jan 16, 2019 at 8:47 AM Kenn Knowles 
   wrote:
   
   > I don't think re-run updates the merge commit, so I'll need to rebase to
   > have a hope of getting green. Since it is non-urgent I'll do that rather
   > than merge on partial green, even though the tests are obviously not
   > relevant.
   >
   > —
   > You are receiving this because your review was requested.
   > Reply to this email directly, view it on GitHub
   > , or mute
   > the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185883)
Time Spent: 2.5h  (was: 2h 20m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185872
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 16:47
Start Date: 16/Jan/19 16:47
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454851840
 
 
   I don't think re-run updates the merge commit, so I'll need to rebase to 
have a hope of getting green. Since it is non-urgent I'll do that rather than 
merge on partial green, even though the tests are obviously not relevant.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185872)
Time Spent: 2h 20m  (was: 2h 10m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185858
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 16:35
Start Date: 16/Jan/19 16:35
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454847042
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185858)
Time Spent: 2h 10m  (was: 2h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185821
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 14:58
Start Date: 16/Jan/19 14:58
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454808865
 
 
   The virtualenv issue should be fixed on `master`. I'm not sure about the 
other, but it looks like `beam` might not be healthy.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185821)
Time Spent: 2h  (was: 1h 50m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185820
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 14:57
Start Date: 16/Jan/19 14:57
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454808685
 
 
   Run Python_ValidatesRunner_Flink Precommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185820)
Time Spent: 1h 50m  (was: 1h 40m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185774
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 13:46
Start Date: 16/Jan/19 13:46
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454783927
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185774)
Time Spent: 1h 40m  (was: 1.5h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185773
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 13:45
Start Date: 16/Jan/19 13:45
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454783719
 
 
   Run Python_ValidatesRunner_Flink Precommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185773)
Time Spent: 1.5h  (was: 1h 20m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185771
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 13:44
Start Date: 16/Jan/19 13:44
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454783469
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185771)
Time Spent: 1h 20m  (was: 1h 10m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185596
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 05:15
Start Date: 16/Jan/19 05:15
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454654623
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185596)
Time Spent: 1h 10m  (was: 1h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185582
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 05:00
Start Date: 16/Jan/19 05:00
Worklog Time Spent: 10m 
  Work Description: HuangLED commented on issue #7531: [BEAM-6447] Turn off 
spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454652568
 
 
   LGTM.  Thanks! 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185582)
Time Spent: 0.5h  (was: 20m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185589
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 05:03
Start Date: 16/Jan/19 05:03
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454652892
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185589)
Time Spent: 1h  (was: 50m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185585
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 05:02
Start Date: 16/Jan/19 05:02
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454652788
 
 
   Run Java_Examples_Dataflow PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185585)
Time Spent: 40m  (was: 0.5h)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185587
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 05:02
Start Date: 16/Jan/19 05:02
Worklog Time Spent: 10m 
  Work Description: reuvenlax commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454652838
 
 
   Run Portable_Python PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185587)
Time Spent: 50m  (was: 40m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185580
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 04:56
Start Date: 16/Jan/19 04:56
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #7531: [BEAM-6447] Turn 
off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531#issuecomment-454651839
 
 
   R: @HuangLED @swegner
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 185580)
Time Spent: 20m  (was: 10m)

> Spotless paddedCell appears to cause unpredictable behavior
> ---
>
> Key: BEAM-6447
> URL: https://issues.apache.org/jira/browse/BEAM-6447
> Project: Beam
>  Issue Type: Bug
>  Components: build-system
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though 
> spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and 
> https://github.com/apache/beam/pull/7527 spotlessApply was run and the result 
> _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on 
> https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use 
> of paddedCell is to workaround bugs in the underlying formatter (in our case 
> google-java-format). Currently, there is no known bug affecting us, so we 
> should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-6447?focusedWorklogId=185563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185563
 ]

ASF GitHub Bot logged work on BEAM-6447:


Author: ASF GitHub Bot
Created on: 16/Jan/19 04:31
Start Date: 16/Jan/19 04:31
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on pull request #7531: 
[BEAM-6447] Turn off spotless paddedCell
URL: https://github.com/apache/beam/pull/7531
 
 
   Our use of paddedCell seems to have triggered some strange spotlessBehavior 
that is probably a bug in spotless. But we don't need it, so turn it off. It is 
a workaround only if `google-java-format` has a bug.
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   It will help us expedite review of your Pull Request if you tag someone 
(e.g. `@username`) to look at it.
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | --- | --- | --- | ---
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
   Python | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
 | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
  [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
 | --- | --- | ---
   
   
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-