[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=310810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310810 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 11/Sep/19 16:46 Start Date: 11/Sep/19 16:46 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310810) Time Spent: 1.5h (was: 1h 20m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=310747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310747 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 11/Sep/19 15:38 Start Date: 11/Sep/19 15:38 Worklog Time Spent: 10m Work Description: rahul8383 commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-530438387 I am also facing this issue. Can this PR be merged so that the fix can be given in 2.16.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310747) Time Spent: 1h 20m (was: 1h 10m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=309163=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309163 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 09/Sep/19 19:43 Start Date: 09/Sep/19 19:43 Worklog Time Spent: 10m Work Description: charithe commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-529635578 @jbonofre Are you happy with the new change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309163) Time Spent: 1h 10m (was: 1h) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=304400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304400 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 30/Aug/19 17:15 Start Date: 30/Aug/19 17:15 Worklog Time Spent: 10m Work Description: charithe commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-526679679 Ah! That's a good idea. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 304400) Time Spent: 1h (was: 50m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 1h > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=304343=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304343 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 30/Aug/19 15:49 Start Date: 30/Aug/19 15:49 Worklog Time Spent: 10m Work Description: jbonofre commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-526652313 @charithe My suggestion was to provide a default `StatementPreparator` (even if it doesn't do a lot), and so, `StatementPreparator` won't be able to be null. Thoughts ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 304343) Time Spent: 50m (was: 40m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 50m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=302973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302973 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 28/Aug/19 15:44 Start Date: 28/Aug/19 15:44 Worklog Time Spent: 10m Work Description: charithe commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-525804007 I am not sure I follow your reasoning. Can you please elaborate? `StatementPreparator` _can_ be null. I missed that when writing the `ReadRows` class. The change I am suggesting now is very similar to the existing implementation in the `Read` class which handles the null `StatementPreparator` case: https://github.com/apache/beam/blob/7a2b847fc33a5b59275152dc1bd8014284aa4e27/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L646-L651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302973) Time Spent: 40m (was: 0.5h) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Fix For: 2.16.0 > > Time Spent: 40m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=301793=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301793 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 27/Aug/19 08:48 Start Date: 27/Aug/19 08:48 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-525205464 Passing the review to JB, he was taking a look at a fix so he is probably more aware than me. R: @jbonofre This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 301793) Time Spent: 0.5h (was: 20m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=300696=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300696 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 24/Aug/19 11:27 Start Date: 24/Aug/19 11:27 Worklog Time Spent: 10m Work Description: charithe commented on issue #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425#issuecomment-524542880 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 300696) Time Spent: 20m (was: 10m) > JdbcIO.readRows() throws exception when the statementPreparator is not > provided for simple Select statement > --- > > Key: BEAM-8032 > URL: https://issues.apache.org/jira/browse/BEAM-8032 > Project: Beam > Issue Type: Bug > Components: io-java-jdbc >Affects Versions: 2.14.0 >Reporter: Kishor Joshi >Assignee: Charith Ellawala >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > I want to read table data with a query without parameters (select * from > table_name). > As per my understanding, this should not require "StatementPreperator". > However, if I use the newly added "readRows" function, I get an exception > that seems to force me to use the "StatementPreperator". > Stacktrace below. > > java.lang.IllegalArgumentException: statementPreparator can not be null > at > org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument(Preconditions.java:122) > at > org.apache.beam.sdk.io.jdbc.JdbcIO$Read.withStatementPreparator(JdbcIO.java:600) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:499) > at org.apache.beam.sdk.io.jdbc.JdbcIO$ReadRows.expand(JdbcIO.java:410) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:34) > at > com.nokia.csf.dfle.transforms.DfleRdbmsSource.expand(DfleRdbmsSource.java:10) > at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:488) > at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:56) > at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:182) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8032) JdbcIO.readRows() throws exception when the statementPreparator is not provided for simple Select statement
[ https://issues.apache.org/jira/browse/BEAM-8032?focusedWorklogId=300692=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300692 ] ASF GitHub Bot logged work on BEAM-8032: Author: ASF GitHub Bot Created on: 24/Aug/19 10:48 Start Date: 24/Aug/19 10:48 Worklog Time Spent: 10m Work Description: charithe commented on pull request #9425: [BEAM-8032] Fix JDBC readRows exception when statement preparator is null URL: https://github.com/apache/beam/pull/9425 Fixes an `IllegalArgumentException` thrown by the `JdbcIO#readRows` method when the user does not provide a `StatementPreparator`. It is optional in the `JdbcIO#read` method and the behaviour should be the same for the `JdbcIO#readRows` method. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[