[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429168=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429168
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:56
Start Date: 30/Apr/20 17:56
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-622008669


   Run Portable_Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429168)
Time Spent: 10h 10m  (was: 10h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429163=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429163
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:52
Start Date: 30/Apr/20 17:52
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-622006811


   sigh, again ran the test on the previous commit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429163)
Time Spent: 10h  (was: 9h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 10h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429162
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:51
Start Date: 30/Apr/20 17:51
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-622006543


   Run Portable_Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429162)
Time Spent: 9h 50m  (was: 9h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 9h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429144
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:12
Start Date: 30/Apr/20 17:12
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621986469


   And now the previous comment launched tests on ffefeba



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429144)
Time Spent: 9h 40m  (was: 9.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 9h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429143
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:10
Start Date: 30/Apr/20 17:10
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621985196


   For some reason my comment launched tests on dbf0396 instead of ffefeba. 
Trying again



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429143)
Time Spent: 9.5h  (was: 9h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=429138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429138
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 17:03
Start Date: 30/Apr/20 17:03
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621981150


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 429138)
Time Spent: 9h 20m  (was: 9h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 9h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-30 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428965
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 09:46
Start Date: 30/Apr/20 09:46
Worklog Time Spent: 10m 
  Work Description: Tesio commented on a change in pull request #11568:
URL: https://github.com/apache/beam/pull/11568#discussion_r417888379



##
File path: 
sdks/python/apache_beam/examples/streaming_wordcount_debugging_test.py
##
@@ -0,0 +1,109 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Unit test for the streaming wordcount example with debug."""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import unittest
+
+import mock
+
+import apache_beam as beam
+from apache_beam.examples import streaming_wordcount_debugging
+from apache_beam.testing.test_stream import TestStream
+from apache_beam.testing.util import assert_that
+from apache_beam.testing.util import equal_to
+
+# Protect against environments where the PubSub library is not available.
+# pylint: disable=wrong-import-order, wrong-import-position
+try:
+  from google.cloud import pubsub
+except ImportError:
+  pubsub = None
+# pylint: enable=wrong-import-order, wrong-import-position
+
+
+class StreamingWordcountDebugging(unittest.TestCase):
+  @unittest.skipIf(pubsub is None, 'GCP dependencies are not installed')
+  @mock.patch('apache_beam.io.ReadFromPubSub')
+  @mock.patch('apache_beam.io.WriteToPubSub')
+  def test_streaming_wordcount_debugging(self, *unused_mocks):
+def FakeReadFromPubSub(topic=None, subscription=None, values=None):
+  expected_topic = topic
+  expected_subscription = subscription
+
+  def _inner(topic=None, subscription=None):
+assert topic == expected_topic
+assert subscription == expected_subscription
+return TestStream().add_elements(values)
+
+  return _inner
+
+class AssertTransform(beam.PTransform):
+  def __init__(self, matcher):
+self.matcher = matcher
+
+  def expand(self, pcoll):
+assert_that(pcoll, self.matcher)
+
+def FakeWriteToPubSub(topic=None, values=None):
+  expected_topic = topic
+
+  def _inner(topic=None, subscription=None):
+assert topic == expected_topic
+return AssertTransform(equal_to(values))
+
+  return _inner
+
+input_topic = 'projects/fake-beam-test-project/topic/intopic'
+input_values = [
+'150', '151', '152', '153', '154', '210', '211', '212', '213', '214'
+]
+output_topic = 'projects/fake-beam-test-project/topic/outtopic'
+output_values = [
+'150: 1',
+'151: 1',
+'152: 1',
+'153: 1',
+'154: 1',
+'210: 1',
+'211: 1',
+'212: 1',
+'213: 1',
+'214: 1'
+]
+beam.io.ReadFromPubSub = (
+FakeReadFromPubSub(
+topic=input_topic,
+values=list(x.encode('utf-8') for x in input_values)))
+beam.io.WriteToPubSub = (
+FakeWriteToPubSub(
+topic=output_topic,
+values=list(x.encode('utf-8') for x in output_values)))
+streaming_wordcount_debugging.run([

Review comment:
   Yes, I missed that param. Fixed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428965)
Time Spent: 9h 10m  (was: 9h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
> 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428829=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428829
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 30/Apr/20 01:28
Start Date: 30/Apr/20 01:28
Worklog Time Spent: 10m 
  Work Description: udim commented on a change in pull request #11568:
URL: https://github.com/apache/beam/pull/11568#discussion_r417705115



##
File path: 
sdks/python/apache_beam/examples/streaming_wordcount_debugging_test.py
##
@@ -0,0 +1,109 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Unit test for the streaming wordcount example with debug."""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import unittest
+
+import mock
+
+import apache_beam as beam
+from apache_beam.examples import streaming_wordcount_debugging
+from apache_beam.testing.test_stream import TestStream
+from apache_beam.testing.util import assert_that
+from apache_beam.testing.util import equal_to
+
+# Protect against environments where the PubSub library is not available.
+# pylint: disable=wrong-import-order, wrong-import-position
+try:
+  from google.cloud import pubsub
+except ImportError:
+  pubsub = None
+# pylint: enable=wrong-import-order, wrong-import-position
+
+
+class StreamingWordcountDebugging(unittest.TestCase):
+  @unittest.skipIf(pubsub is None, 'GCP dependencies are not installed')
+  @mock.patch('apache_beam.io.ReadFromPubSub')
+  @mock.patch('apache_beam.io.WriteToPubSub')
+  def test_streaming_wordcount_debugging(self, *unused_mocks):
+def FakeReadFromPubSub(topic=None, subscription=None, values=None):
+  expected_topic = topic
+  expected_subscription = subscription
+
+  def _inner(topic=None, subscription=None):
+assert topic == expected_topic
+assert subscription == expected_subscription
+return TestStream().add_elements(values)
+
+  return _inner
+
+class AssertTransform(beam.PTransform):
+  def __init__(self, matcher):
+self.matcher = matcher
+
+  def expand(self, pcoll):
+assert_that(pcoll, self.matcher)
+
+def FakeWriteToPubSub(topic=None, values=None):
+  expected_topic = topic
+
+  def _inner(topic=None, subscription=None):
+assert topic == expected_topic
+return AssertTransform(equal_to(values))
+
+  return _inner
+
+input_topic = 'projects/fake-beam-test-project/topic/intopic'
+input_values = [
+'150', '151', '152', '153', '154', '210', '211', '212', '213', '214'
+]
+output_topic = 'projects/fake-beam-test-project/topic/outtopic'
+output_values = [
+'150: 1',
+'151: 1',
+'152: 1',
+'153: 1',
+'154: 1',
+'210: 1',
+'211: 1',
+'212: 1',
+'213: 1',
+'214: 1'
+]
+beam.io.ReadFromPubSub = (
+FakeReadFromPubSub(
+topic=input_topic,
+values=list(x.encode('utf-8') for x in input_values)))
+beam.io.WriteToPubSub = (
+FakeWriteToPubSub(
+topic=output_topic,
+values=list(x.encode('utf-8') for x in output_values)))
+streaming_wordcount_debugging.run([

Review comment:
   I believe you're missing a save_main_session=False here, otherwise it 
won't run successfully with the pytest-xdist plugin (pickle error). You can 
test it on your machine with `tox -e py37-cloud`.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428829)
Time Spent: 9h  (was: 8h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428770=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428770
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 29/Apr/20 22:44
Start Date: 29/Apr/20 22:44
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621506456


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428770)
Time Spent: 8h 40m  (was: 8.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428771=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428771
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 29/Apr/20 22:44
Start Date: 29/Apr/20 22:44
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621506645


   Waiting to check that streaming_wordcount_debugging_test runs in python 
precommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428771)
Time Spent: 8h 50m  (was: 8h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 8h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428548=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428548
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 29/Apr/20 13:05
Start Date: 29/Apr/20 13:05
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621190636


   R: @udim
   Kindly review the request



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428548)
Time Spent: 8h 20m  (was: 8h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 8h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428549=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428549
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 29/Apr/20 13:05
Start Date: 29/Apr/20 13:05
Worklog Time Spent: 10m 
  Work Description: Tesio edited a comment on pull request #11568:
URL: https://github.com/apache/beam/pull/11568#issuecomment-621190636


   R: @udim



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 428549)
Time Spent: 8.5h  (was: 8h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-04-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=428546=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428546
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 29/Apr/20 13:03
Start Date: 29/Apr/20 13:03
Worklog Time Spent: 10m 
  Work Description: Tesio opened a new pull request #11568:
URL: https://github.com/apache/beam/pull/11568


   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
- [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build
 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410589
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 20:37
Start Date: 26/Mar/20 20:37
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11238: [BEAM-8078] 
Disable test_streaming_wordcount_debugging_it
URL: https://github.com/apache/beam/pull/11238
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410589)
Time Spent: 8h  (was: 7h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410431=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410431
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 17:35
Start Date: 26/Mar/20 17:35
Worklog Time Spent: 10m 
  Work Description: TheNeuralBit commented on issue #11238: [BEAM-8078] 
Disable test_streaming_wordcount_debugging_it
URL: https://github.com/apache/beam/pull/11238#issuecomment-604571494
 
 
   Run Python 3.7 PostCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410431)
Time Spent: 7h 50m  (was: 7h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410430
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 17:29
Start Date: 26/Mar/20 17:29
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #11238: [BEAM-8078] Disable 
test_streaming_wordcount_debugging_it
URL: https://github.com/apache/beam/pull/11238#issuecomment-604567204
 
 
   R: @TheNeuralBit 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410430)
Time Spent: 7h 40m  (was: 7.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410429
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 17:28
Start Date: 26/Mar/20 17:28
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11238: [BEAM-8078] 
Disable test_streaming_wordcount_debugging_it
URL: https://github.com/apache/beam/pull/11238
 
 
   Reenable test_streaming_wordcount_it
   Rename the test in streaming_wordcount_debugging_it_test.py
   
   
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
- [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build
 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410019=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410019
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 01:58
Start Date: 26/Mar/20 01:58
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-604183688
 
 
   I disabled the test; it still needs fixing (see bug for error)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410019)
Time Spent: 7h 20m  (was: 7h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410014=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410014
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 01:45
Start Date: 26/Mar/20 01:45
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11234: [BEAM-8078] 
Disable test_streaming_wordcount_it
URL: https://github.com/apache/beam/pull/11234
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410014)
Time Spent: 7h 10m  (was: 7h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410013=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410013
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 01:42
Start Date: 26/Mar/20 01:42
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #11234: [BEAM-8078] Disable 
test_streaming_wordcount_it
URL: https://github.com/apache/beam/pull/11234#issuecomment-604179290
 
 
   R: @TheNeuralBit 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410013)
Time Spent: 7h  (was: 6h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 7h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410012
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 01:41
Start Date: 26/Mar/20 01:41
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #11234: [BEAM-8078] 
Disable test_streaming_wordcount_it
URL: https://github.com/apache/beam/pull/11234
 
 
   I mistakenly thought this test was passing when it wasn't
   and merged it.
   
   
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
- [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build
 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=410010=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410010
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 26/Mar/20 01:21
Start Date: 26/Mar/20 01:21
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-604173860
 
 
   Yeah, sorry about that. Got confused by the UI
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 410010)
Time Spent: 6h 40m  (was: 6.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=409972=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409972
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 25/Mar/20 23:45
Start Date: 25/Mar/20 23:45
Worklog Time Spent: 10m 
  Work Description: TheNeuralBit commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-604147467
 
 
   This test seems to be failing on jenkins: 
https://builds.apache.org/job/beam_PostCommit_Python2/2057/
   https://builds.apache.org/job/beam_PostCommit_Python37/1982/
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 409972)
Time Spent: 6.5h  (was: 6h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=409777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409777
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 25/Mar/20 19:54
Start Date: 25/Mar/20 19:54
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 409777)
Time Spent: 6h 20m  (was: 6h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 6h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=409773=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409773
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 25/Mar/20 19:52
Start Date: 25/Mar/20 19:52
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-604051436
 
 
   Opened https://issues.apache.org/jira/browse/BEAM-9610 for the flaky 
postcommit test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 409773)
Time Spent: 6h 10m  (was: 6h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408222=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408222
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 19:57
Start Date: 23/Mar/20 19:57
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602823166
 
 
   Trying again
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408222)
Time Spent: 5h 50m  (was: 5h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408223=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408223
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 19:57
Start Date: 23/Mar/20 19:57
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602823472
 
 
   run python 3.7 postcommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408223)
Time Spent: 6h  (was: 5h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 6h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408146
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 18:50
Start Date: 23/Mar/20 18:50
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602789494
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408146)
Time Spent: 5h 40m  (was: 5.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408129
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 18:26
Start Date: 23/Mar/20 18:26
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602776944
 
 
   Run PythonLint PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408129)
Time Spent: 5.5h  (was: 5h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408127=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408127
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 18:26
Start Date: 23/Mar/20 18:26
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602776774
 
 
   run python 3.7 postcommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408127)
Time Spent: 5h 20m  (was: 5h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408115
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 18:14
Start Date: 23/Mar/20 18:14
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r396657477
 
 

 ##
 File path: 
sdks/python/apache_beam/examples/streaming_wordcount_debugging_it_test.py
 ##
 @@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""End-to-end test for the streaming wordcount example with debug."""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import logging
+import unittest
+import uuid
+from builtins import range
+
+from hamcrest.core.core.allof import all_of
+from nose.plugins.attrib import attr
+
+from apache_beam.examples import streaming_wordcount_debugging
+from apache_beam.io.gcp.tests.pubsub_matcher import PubSubMessageMatcher
+from apache_beam.runners.runner import PipelineState
+from apache_beam.testing import test_utils
+from apache_beam.testing.pipeline_verifiers import PipelineStateMatcher
+from apache_beam.testing.test_pipeline import TestPipeline
+
+INPUT_TOPIC = 'wc_topic_input'
+OUTPUT_TOPIC = 'wc_topic_output'
+INPUT_SUB = 'wc_subscription_input'
+OUTPUT_SUB = 'wc_subscription_output'
+
+DEFAULT_INPUT_NUMBERS = 100
+WAIT_UNTIL_FINISH_DURATION = 6 * 60 * 1000  # in milliseconds
+
+
+class StreamingWordcountDebuggingIT(unittest.TestCase):
+  def setUp(self):
+self.test_pipeline = TestPipeline(is_integration_test=True)
+self.project = self.test_pipeline.get_option('project')
+self.setup_pubsub()
+
+  def setup_pubsub(self):
+self.uuid = str(uuid.uuid4())
+
+# Set up PubSub environment.
+from google.cloud import pubsub
+self.pub_client = pubsub.PublisherClient()
+self.input_topic = self.pub_client.create_topic(
+self.pub_client.topic_path(self.project, INPUT_TOPIC + self.uuid))
+self.output_topic = self.pub_client.create_topic(
+self.pub_client.topic_path(self.project, OUTPUT_TOPIC + self.uuid))
+
+self.sub_client = pubsub.SubscriberClient()
+self.input_sub = self.sub_client.create_subscription(
+self.sub_client.subscription_path(self.project, INPUT_SUB + self.uuid),
+self.input_topic.name)
+self.output_sub = self.sub_client.create_subscription(
+self.sub_client.subscription_path(self.project, OUTPUT_SUB + 
self.uuid),
+self.output_topic.name,
+ack_deadline_seconds=60)
+
+  def _inject_numbers(self, topic, num_messages):
+"""Inject numbers as test data to PubSub."""
+logging.debug('Injecting %d numbers to topic %s', num_messages, topic.name)
+for n in range(num_messages):
+  self.pub_client.publish(self.input_topic.name, str(n).encode('utf-8'))
+
+  def tearDown(self):
+test_utils.cleanup_subscriptions(
+self.sub_client, [self.input_sub, self.output_sub])
+test_utils.cleanup_topics(
+self.pub_client, [self.input_topic, self.output_topic])
+
+  @attr('IT')
+  def test_streaming_wordcount_it(self):
+# Build expected dataset.
+expected_msg = [('%d: 1' % num).encode('utf-8')
+for num in range(DEFAULT_INPUT_NUMBERS)]
+
+# Set extra options to the pipeline for test purpose
+state_verifier = PipelineStateMatcher(PipelineState.RUNNING)
+pubsub_msg_verifier = PubSubMessageMatcher(
+self.project, self.output_sub.name, expected_msg, timeout=400)
+extra_opts = {
+'input_subscription': self.input_sub.name,
+'output_topic': self.output_topic.name,
+'wait_until_finish_duration': WAIT_UNTIL_FINISH_DURATION,
+'on_success_matcher': all_of(state_verifier, pubsub_msg_verifier)
+}
+
+# Generate input data and inject to PubSub.
+self._inject_numbers(self.input_topic, DEFAULT_INPUT_NUMBERS)
+
+# Get pipeline options from command argument: --test-pipeline-options,
+# and 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408114=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408114
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 18:12
Start Date: 23/Mar/20 18:12
Worklog Time Spent: 10m 
  Work Description: udim commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r396656529
 
 

 ##
 File path: 
sdks/python/apache_beam/examples/streaming_wordcount_debugging_it_test.py
 ##
 @@ -0,0 +1,115 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""End-to-end test for the streaming wordcount example with debug."""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import logging
+import unittest
+import uuid
+from builtins import range
+
+from hamcrest.core.core.allof import all_of
+from nose.plugins.attrib import attr
+
+from apache_beam.examples import streaming_wordcount_debugging
+from apache_beam.io.gcp.tests.pubsub_matcher import PubSubMessageMatcher
+from apache_beam.runners.runner import PipelineState
+from apache_beam.testing import test_utils
+from apache_beam.testing.pipeline_verifiers import PipelineStateMatcher
+from apache_beam.testing.test_pipeline import TestPipeline
+
+INPUT_TOPIC = 'wc_topic_input'
+OUTPUT_TOPIC = 'wc_topic_output'
+INPUT_SUB = 'wc_subscription_input'
+OUTPUT_SUB = 'wc_subscription_output'
+
+DEFAULT_INPUT_NUMBERS = 100
+WAIT_UNTIL_FINISH_DURATION = 6 * 60 * 1000  # in milliseconds
+
+
+class StreamingWordcountDebuggingIT(unittest.TestCase):
+  def setUp(self):
+self.test_pipeline = TestPipeline(is_integration_test=True)
+self.project = self.test_pipeline.get_option('project')
+self.setup_pubsub()
+
+  def setup_pubsub(self):
+self.uuid = str(uuid.uuid4())
+
+# Set up PubSub environment.
+from google.cloud import pubsub
+self.pub_client = pubsub.PublisherClient()
+self.input_topic = self.pub_client.create_topic(
+self.pub_client.topic_path(self.project, INPUT_TOPIC + self.uuid))
+self.output_topic = self.pub_client.create_topic(
+self.pub_client.topic_path(self.project, OUTPUT_TOPIC + self.uuid))
+
+self.sub_client = pubsub.SubscriberClient()
+self.input_sub = self.sub_client.create_subscription(
+self.sub_client.subscription_path(self.project, INPUT_SUB + self.uuid),
+self.input_topic.name)
+self.output_sub = self.sub_client.create_subscription(
+self.sub_client.subscription_path(self.project, OUTPUT_SUB + 
self.uuid),
+self.output_topic.name,
+ack_deadline_seconds=60)
+
+  def _inject_numbers(self, topic, num_messages):
+"""Inject numbers as test data to PubSub."""
+logging.debug('Injecting %d numbers to topic %s', num_messages, topic.name)
+for n in range(num_messages):
+  self.pub_client.publish(self.input_topic.name, str(n).encode('utf-8'))
+
+  def tearDown(self):
+test_utils.cleanup_subscriptions(
+self.sub_client, [self.input_sub, self.output_sub])
+test_utils.cleanup_topics(
+self.pub_client, [self.input_topic, self.output_topic])
+
+  @attr('IT')
+  def test_streaming_wordcount_it(self):
+# Build expected dataset.
+expected_msg = [('%d: 1' % num).encode('utf-8')
+for num in range(DEFAULT_INPUT_NUMBERS)]
+
+# Set extra options to the pipeline for test purpose
+state_verifier = PipelineStateMatcher(PipelineState.RUNNING)
+pubsub_msg_verifier = PubSubMessageMatcher(
+self.project, self.output_sub.name, expected_msg, timeout=400)
+extra_opts = {
+'input_subscription': self.input_sub.name,
+'output_topic': self.output_topic.name,
+'wait_until_finish_duration': WAIT_UNTIL_FINISH_DURATION,
+'on_success_matcher': all_of(state_verifier, pubsub_msg_verifier)
+}
+
+# Generate input data and inject to PubSub.
+self._inject_numbers(self.input_topic, DEFAULT_INPUT_NUMBERS)
+
+# Get pipeline options from command argument: --test-pipeline-options,
+# and 

[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408066
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 17:10
Start Date: 23/Mar/20 17:10
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602734708
 
 
   Run PythonLint PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408066)
Time Spent: 4h 50m  (was: 4h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408056=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408056
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 16:51
Start Date: 23/Mar/20 16:51
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602723884
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408056)
Time Spent: 4h 40m  (was: 4.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=408035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408035
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 23/Mar/20 16:29
Start Date: 23/Mar/20 16:29
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-602710734
 
 
   run python 3.7 postcommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 408035)
Time Spent: 4.5h  (was: 4h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=407351=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407351
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 21/Mar/20 01:56
Start Date: 21/Mar/20 01:56
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601976783
 
 
   will merge once I get postcommit to run this test and verify it passes
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 407351)
Time Spent: 4h 20m  (was: 4h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=407348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407348
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 21/Mar/20 01:54
Start Date: 21/Mar/20 01:54
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601976548
 
 
   run python 3.7 postcommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 407348)
Time Spent: 4h 10m  (was: 4h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=407264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407264
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 20/Mar/20 21:14
Start Date: 20/Mar/20 21:14
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601913507
 
 
   @Tesio - unfortunately, due to an ongoing issue, jenkins only starts test 
when a committer requests it. This should be resolved but in the meantime, if 
you need to trigger tests feel free to ask on the dev@ list for someone to do 
it.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 407264)
Time Spent: 4h  (was: 3h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=407262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407262
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 20/Mar/20 21:13
Start Date: 20/Mar/20 21:13
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601913195
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 407262)
Time Spent: 3h 50m  (was: 3h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=407253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407253
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 20/Mar/20 21:06
Start Date: 20/Mar/20 21:06
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601910749
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 407253)
Time Spent: 3h 40m  (was: 3.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=406432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406432
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 19/Mar/20 17:44
Start Date: 19/Mar/20 17:44
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601321761
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 406432)
Time Spent: 3.5h  (was: 3h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=406425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406425
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 19/Mar/20 17:39
Start Date: 19/Mar/20 17:39
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601319217
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 406425)
Time Spent: 3h 20m  (was: 3h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=406417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406417
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 19/Mar/20 17:30
Start Date: 19/Mar/20 17:30
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601314853
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 406417)
Time Spent: 3h 10m  (was: 3h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=406006=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406006
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 19/Mar/20 08:52
Start Date: 19/Mar/20 08:52
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-601060116
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 406006)
Time Spent: 3h  (was: 2h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=405875=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405875
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 19/Mar/20 00:47
Start Date: 19/Mar/20 00:47
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-600928606
 
 
   retest this please
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 405875)
Time Spent: 2h 50m  (was: 2h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=405323=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405323
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 18/Mar/20 10:23
Start Date: 18/Mar/20 10:23
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-600540249
 
 
   Run Python PreCommit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 405323)
Time Spent: 2h 40m  (was: 2.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-12 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=402380=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402380
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 12/Mar/20 18:18
Start Date: 12/Mar/20 18:18
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-595394411
 
 
   R: @udim 
   Did you have a chance to look into this request?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 402380)
Time Spent: 2.5h  (was: 2h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-12 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=402378=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402378
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 12/Mar/20 18:17
Start Date: 12/Mar/20 18:17
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-595394411
 
 
   R: @udim , did you have a chance to look into this request?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 402378)
Time Spent: 2h 20m  (was: 2h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-03-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=398611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398611
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 05/Mar/20 19:05
Start Date: 05/Mar/20 19:05
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-595394411
 
 
   @udim , did you have a chance to look into this request?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 398611)
Time Spent: 2h 10m  (was: 2h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-28 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=395134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395134
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 28/Feb/20 16:31
Start Date: 28/Feb/20 16:31
Worklog Time Spent: 10m 
  Work Description: aaltay commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385794953
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   Thank you.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 395134)
Time Spent: 2h  (was: 1h 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-28 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394845=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394845
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 28/Feb/20 11:35
Start Date: 28/Feb/20 11:35
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385648453
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   Fixed that as per comment
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394845)
Time Spent: 1h 50m  (was: 1h 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394528=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394528
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 23:29
Start Date: 27/Feb/20 23:29
Worklog Time Spent: 10m 
  Work Description: aaltay commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385430114
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   I think it is fair to use int() conversion wherever possible and if it does 
not work do something else. Maybe default to time() as at least it will be more 
meaningful than length of a string for the example.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394528)
Time Spent: 1h 40m  (was: 1.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394483=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394483
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 21:52
Start Date: 27/Feb/20 21:52
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385392760
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   Well, as this is an example of debugging functionality - more complicated 
logic could be added during real-time development. Just to keep it simple for 
windowing and applicable for strings as well - what about basing on string's 
length to keep it predictable. And keeping int-base for int values?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394483)
Time Spent: 1.5h  (was: 1h 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394436=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394436
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 20:06
Start Date: 27/Feb/20 20:06
Worklog Time Spent: 10m 
  Work Description: aaltay commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385343245
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   That will be better by making tests reproducible. That will result in 
elements with timestamps across a wide range. Testers would not be able to 
predict what element will be in which window.
   
   we change the input to be a tuple , with a comma 
separation.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394436)
Time Spent: 1h 20m  (was: 1h 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394410=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394410
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 19:08
Start Date: 27/Feb/20 19:08
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385313258
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   Fair point. The reason of that change is to make it work not only with int 
values, as an example is called wordcount. Will it be ok if we will use the 
positive hashed value of "Sometext" as a base for timestamp?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394410)
Time Spent: 1h 10m  (was: 1h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394404=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394404
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 18:52
Start Date: 27/Feb/20 18:52
Worklog Time Spent: 10m 
  Work Description: aaltay commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385304557
 
 

 ##
 File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
 ##
 @@ -71,16 +72,14 @@ def process(
 class AddTimestampFn(beam.DoFn):
   """A DoFn that attaches timestamps to its elements.
 
-  It takes a string of integers and it attaches to each of them
-  a timestamp of its same value.
+  It just takes an element and adds a current timestamp.
 
-  For example, [120, 225, 312] will result in:
-  [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+  For example, Sometext will result in:
+  (Sometext, Timestamp(1234567890).
 
 Review comment:
   Note that this change will make timestamp unpredictable would likely result 
in flaky tests.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394404)
Time Spent: 1h  (was: 50m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394402
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 18:50
Start Date: 27/Feb/20 18:50
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-592118125
 
 
   > > As a high level comment do we need an integration test for 
`streaming_wordcount_debugging_it_test.py`? Integration test for 
`streaming_wordcount_it_test.py` tests for the basic streaming wordcount use 
case. debugging version has more debugging information and a more educational 
purpose.
   > 
   > As I wrote in the bug, my reasoning is that it's example code so it should 
be tested to see that it runs properly.
   
   Ack. Did not see the bug. Assigned this to you for the review.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394402)
Time Spent: 50m  (was: 40m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394364
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 18:05
Start Date: 27/Feb/20 18:05
Worklog Time Spent: 10m 
  Work Description: udim commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-592097456
 
 
   > As a high level comment do we need an integration test for 
`streaming_wordcount_debugging_it_test.py`? Integration test for 
`streaming_wordcount_it_test.py` tests for the basic streaming wordcount use 
case. debugging version has more debugging information and a more educational 
purpose.
   
   As I wrote in the bug, my reasoning is that it's example code so it should 
be tested to see that it runs properly.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394364)
Time Spent: 40m  (was: 0.5h)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394348
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 27/Feb/20 17:38
Start Date: 27/Feb/20 17:38
Worklog Time Spent: 10m 
  Work Description: aaltay commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-592085423
 
 
   As a high level comment do we need an integration test for 
`streaming_wordcount_debugging_it_test.py`? Integration test for 
`streaming_wordcount_it_test.py` tests for the basic streaming wordcount use 
case. debugging version has more debugging information and a more educational 
purpose.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 394348)
Time Spent: 0.5h  (was: 20m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=390088=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390088
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 20/Feb/20 17:29
Start Date: 20/Feb/20 17:29
Worklog Time Spent: 10m 
  Work Description: Tesio commented on issue #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#issuecomment-589213797
 
 
   @udim, kindly review the pull request
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 390088)
Time Spent: 20m  (was: 10m)

> streaming_wordcount_debugging.py is missing a test
> --
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Aleksey Vysotin
>Priority: Minor
>  Labels: beginner, easy, newbie, starter
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount 
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1] 
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-8078) streaming_wordcount_debugging.py is missing a test

2020-02-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=390079=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390079
 ]

ASF GitHub Bot logged work on BEAM-8078:


Author: ASF GitHub Bot
Created on: 20/Feb/20 17:23
Start Date: 20/Feb/20 17:23
Worklog Time Spent: 10m 
  Work Description: Tesio commented on pull request #10914: [BEAM-8078] 
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914
 
 
   **Please** add a meaningful description for your change here
   
   
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
- [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
   Python | [![Build