[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=402582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402582 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 13/Mar/20 00:43 Start Date: 13/Mar/20 00:43 Worklog Time Spent: 10m Work Description: reuvenlax commented on pull request #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 402582) Time Spent: 2.5h (was: 2h 20m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=402547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402547 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 12/Mar/20 23:12 Start Date: 12/Mar/20 23:12 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-598472254 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 402547) Time Spent: 2h 20m (was: 2h 10m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=402463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402463 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 12/Mar/20 20:17 Start Date: 12/Mar/20 20:17 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-598399674 @iemejia wasn't available this week. His remark are fixed. So LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 402463) Time Spent: 2h 10m (was: 2h) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=402300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402300 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 12/Mar/20 16:32 Start Date: 12/Mar/20 16:32 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-598285299 friendly ping: @alexvanboxel @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 402300) Time Spent: 2h (was: 1h 50m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=400428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400428 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 09/Mar/20 22:53 Start Date: 09/Mar/20 22:53 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-596817172 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 400428) Time Spent: 1h 50m (was: 1h 40m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=399970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399970 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 09/Mar/20 04:28 Start Date: 09/Mar/20 04:28 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-596325819 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 399970) Time Spent: 1h 40m (was: 1.5h) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398716 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 21:44 Start Date: 05/Mar/20 21:44 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595462750 > @alexvanboxel are you talking about the RabbitMQ failure? yes (rookie, mistake of me) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398716) Time Spent: 1.5h (was: 1h 20m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398714 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 21:35 Start Date: 05/Mar/20 21:35 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595459415 @alexvanboxel are you talking about the RabbitMQ failure? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398714) Time Spent: 1h 20m (was: 1h 10m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398703 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 21:25 Start Date: 05/Mar/20 21:25 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595455457 The error in the test is my fault, approved a fix without seeing the tests were ran. Just need to be rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398703) Time Spent: 1h 10m (was: 1h) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398637 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 20:01 Start Date: 05/Mar/20 20:01 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595420264 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398637) Time Spent: 1h (was: 50m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398596 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 18:40 Start Date: 05/Mar/20 18:40 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595383277 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398596) Time Spent: 50m (was: 40m) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398479 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 05/Mar/20 16:29 Start Date: 05/Mar/20 16:29 Worklog Time Spent: 10m Work Description: reuvenlax commented on issue #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046#issuecomment-595320745 Run Spotless PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398479) Time Spent: 40m (was: 0.5h) > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[
https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398469&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398469
]
ASF GitHub Bot logged work on BEAM-9442:
Author: ASF GitHub Bot
Created on: 05/Mar/20 16:13
Start Date: 05/Mar/20 16:13
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #11046: [BEAM-9442]
Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388399575
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation
valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+public int reserveSlot() {
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 398469)
Time Spent: 0.5h (was: 20m)
> Schema Select does not properly handle nested nullable fields
> -
>
> Key: BEAM-9442
> URL: https://issues.apache.org/jira/browse/BEAM-9442
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-harness
>Reporter: Reuven Lax
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A select of a nested field should be nullable if any of its parents are
> nullable. So for example, a select of "a.b" should return a field named b
> that is nullable if _either_ of a or b is nullable. Today we only examine b
> to see if the selected fields should be nullable.
> Also the Select transform itself does not properly check for null values, and
> throws NullPointerExceptions when some row values are null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[
https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398337
]
ASF GitHub Bot logged work on BEAM-9442:
Author: ASF GitHub Bot
Created on: 05/Mar/20 12:17
Start Date: 05/Mar/20 12:17
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11046: [BEAM-9442]
Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388257264
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation
valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+public int reserveSlot() {
Review comment:
nit: (slightly related to this PR) can we make `SelectByteBuddyHelpers`
package private please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 398337)
Time Spent: 20m (was: 10m)
> Schema Select does not properly handle nested nullable fields
> -
>
> Key: BEAM-9442
> URL: https://issues.apache.org/jira/browse/BEAM-9442
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-harness
>Reporter: Reuven Lax
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A select of a nested field should be nullable if any of its parents are
> nullable. So for example, a select of "a.b" should return a field named b
> that is nullable if _either_ of a or b is nullable. Today we only examine b
> to see if the selected fields should be nullable.
> Also the Select transform itself does not properly check for null values, and
> throws NullPointerExceptions when some row values are null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9442) Schema Select does not properly handle nested nullable fields
[ https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=397908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397908 ] ASF GitHub Bot logged work on BEAM-9442: Author: ASF GitHub Bot Created on: 04/Mar/20 21:44 Start Date: 04/Mar/20 21:44 Worklog Time Spent: 10m Work Description: reuvenlax commented on pull request #11046: [BEAM-9442] Properly handle nullable fields in Select URL: https://github.com/apache/beam/pull/11046 Fix the selected schema to properly represent nullable nested fields. Fix the schema code to check for null values and not throw NullPointerExceptions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 397908) Remaining Estimate: 0h Time Spent: 10m > Schema Select does not properly handle nested nullable fields > - > > Key: BEAM-9442 > URL: https://issues.apache.org/jira/browse/BEAM-9442 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-harness >Reporter: Reuven Lax >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > A select of a nested field should be nullable if any of its parents are > nullable. So for example, a select of "a.b" should return a field named b > that is nullable if _either_ of a or b is nullable. Today we only examine b > to see if the selected fields should be nullable. > Also the Select transform itself does not properly check for null values, and > throws NullPointerExceptions when some row values are null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
