[jira] [Work logged] (BEAM-9448) Misleading log line: says "downloading" when using cache
[ https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=400272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400272 ] ASF GitHub Bot logged work on BEAM-9448: Author: ASF GitHub Bot Created on: 09/Mar/20 18:15 Start Date: 09/Mar/20 18:15 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #11051: [BEAM-9448] Fix log message for job server cache. URL: https://github.com/apache/beam/pull/11051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 400272) Time Spent: 50m (was: 40m) > Misleading log line: says "downloading" when using cache > > > Key: BEAM-9448 > URL: https://issues.apache.org/jira/browse/BEAM-9448 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Trivial > Labels: portability-flink > Time Spent: 50m > Remaining Estimate: 0h > > https://github.com/apache/beam/blob/8d253ac99d78ef5345245ed71c7cf34328c55d9f/sdks/python/apache_beam/utils/subprocess_server.py#L197 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9448) Misleading log line: says "downloading" when using cache
[ https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=398779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398779 ] ASF GitHub Bot logged work on BEAM-9448: Author: ASF GitHub Bot Created on: 06/Mar/20 00:14 Start Date: 06/Mar/20 00:14 Worklog Time Spent: 10m Work Description: ibzib commented on issue #11051: [BEAM-9448] Fix log message for job server cache. URL: https://github.com/apache/beam/pull/11051#issuecomment-595509792 Run RAT PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 398779) Time Spent: 40m (was: 0.5h) > Misleading log line: says "downloading" when using cache > > > Key: BEAM-9448 > URL: https://issues.apache.org/jira/browse/BEAM-9448 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Trivial > Labels: portability-flink > Time Spent: 40m > Remaining Estimate: 0h > > https://github.com/apache/beam/blob/8d253ac99d78ef5345245ed71c7cf34328c55d9f/sdks/python/apache_beam/utils/subprocess_server.py#L197 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9448) Misleading log line: says "downloading" when using cache
[
https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=398728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398728
]
ASF GitHub Bot logged work on BEAM-9448:
Author: ASF GitHub Bot
Created on: 05/Mar/20 22:18
Start Date: 05/Mar/20 22:18
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #11051: [BEAM-9448] Fix
log message for job server cache.
URL: https://github.com/apache/beam/pull/11051#discussion_r388600537
##
File path: sdks/python/apache_beam/utils/subprocess_server.py
##
@@ -194,9 +194,11 @@ def local_jar(cls, url):
if os.path.exists(url):
return url
else:
- _LOGGER.warning('Downloading job server jar from %s' % url)
cached_jar = os.path.join(cls.JAR_CACHE, os.path.basename(url))
- if not os.path.exists(cached_jar):
+ if os.path.exists(cached_jar):
+_LOGGER.warning('Using cached job server jar from %s' % url)
+ else:
+_LOGGER.warning('Downloading job server jar from %s' % url)
Review comment:
Changed it to `info`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 398728)
Time Spent: 0.5h (was: 20m)
> Misleading log line: says "downloading" when using cache
>
>
> Key: BEAM-9448
> URL: https://issues.apache.org/jira/browse/BEAM-9448
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
>Reporter: Kyle Weaver
>Assignee: Kyle Weaver
>Priority: Trivial
> Labels: portability-flink
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/8d253ac99d78ef5345245ed71c7cf34328c55d9f/sdks/python/apache_beam/utils/subprocess_server.py#L197
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9448) Misleading log line: says "downloading" when using cache
[
https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=398400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398400
]
ASF GitHub Bot logged work on BEAM-9448:
Author: ASF GitHub Bot
Created on: 05/Mar/20 14:23
Start Date: 05/Mar/20 14:23
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #11051: [BEAM-9448] Fix
log message for job server cache.
URL: https://github.com/apache/beam/pull/11051#discussion_r388323826
##
File path: sdks/python/apache_beam/utils/subprocess_server.py
##
@@ -194,9 +194,11 @@ def local_jar(cls, url):
if os.path.exists(url):
return url
else:
- _LOGGER.warning('Downloading job server jar from %s' % url)
cached_jar = os.path.join(cls.JAR_CACHE, os.path.basename(url))
- if not os.path.exists(cached_jar):
+ if os.path.exists(cached_jar):
+_LOGGER.warning('Using cached job server jar from %s' % url)
+ else:
+_LOGGER.warning('Downloading job server jar from %s' % url)
Review comment:
Should this really be WARN? IMHO info would suffice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 398400)
Time Spent: 20m (was: 10m)
> Misleading log line: says "downloading" when using cache
>
>
> Key: BEAM-9448
> URL: https://issues.apache.org/jira/browse/BEAM-9448
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
>Reporter: Kyle Weaver
>Assignee: Kyle Weaver
>Priority: Trivial
> Labels: portability-flink
> Time Spent: 20m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/8d253ac99d78ef5345245ed71c7cf34328c55d9f/sdks/python/apache_beam/utils/subprocess_server.py#L197
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9448) Misleading log line: says "downloading" when using cache
[ https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=398033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398033 ] ASF GitHub Bot logged work on BEAM-9448: Author: ASF GitHub Bot Created on: 05/Mar/20 00:46 Start Date: 05/Mar/20 00:46 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #11051: [BEAM-9448] Fix log message for job server cache. URL: https://github.com/apache/beam/pull/11051 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spa
