[jira] [Commented] (CAMEL-11959) New component YQL
[ https://issues.apache.org/jira/browse/CAMEL-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222971#comment-16222971 ] Carl-Philipp Harmant commented on CAMEL-11959: -- I don't have the rights to assign it to me, so if somebody could, that would be nice. > New component YQL > - > > Key: CAMEL-11959 > URL: https://issues.apache.org/jira/browse/CAMEL-11959 > Project: Camel > Issue Type: New Feature >Reporter: Carl-Philipp Harmant >Priority: Minor > > Add a new component, camel-yql that will allow to obtain data from YQL (Yahoo > Query Language) > https://developer.yahoo.com/yql/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11959) New component YQL
Carl-Philipp Harmant created CAMEL-11959: Summary: New component YQL Key: CAMEL-11959 URL: https://issues.apache.org/jira/browse/CAMEL-11959 Project: Camel Issue Type: New Feature Reporter: Carl-Philipp Harmant Priority: Minor Add a new component, camel-yql that will allow to obtain data from YQL (Yahoo Query Language) https://developer.yahoo.com/yql/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222601#comment-16222601 ] ASF GitHub Bot commented on CAMEL-11387: onders86 closed pull request #2066: CAMEL-11387 - adjust destination filename by calling existing method … URL: https://github.com/apache/camel/pull/2066 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java index 1721c40da12..84d427f875c 100644 --- a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java +++ b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java @@ -447,6 +447,9 @@ public synchronized boolean renameFile(String from, String to) throws GenericFil LOG.debug("Renaming file: {} to: {}", from, to); try { reconnectIfNecessary(); +//make use of the '/' separator because JSch expects this +// as the file separator even on Windows +to = FileUtil.compactPath(to, '/'); channel.rename(from, to); return true; } catch (SftpException e) { This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222602#comment-16222602 ] ASF GitHub Bot commented on CAMEL-11387: Github user onders86 closed the pull request at: https://github.com/apache/camel/pull/2066 > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11958) rest-dsl - Disable vendor extension by default
[ https://issues.apache.org/jira/browse/CAMEL-11958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11958. - Resolution: Fixed > rest-dsl - Disable vendor extension by default > -- > > Key: CAMEL-11958 > URL: https://issues.apache.org/jira/browse/CAMEL-11958 > Project: Camel > Issue Type: Improvement > Components: camel-core, camel-swagger >Affects Versions: 2.20.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.1, 2.21.0 > > > See CAMEL-11957 > As 3rd party API tooling may not support vendor extension and that these > extensions expose implementation details that end users may not want (model > class name, that its Camel etc). > This allows the generated API to be more neutral and clean. > People can turn it back on with the new vendor extension option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11958) rest-dsl - Disable vendor extension by default
Claus Ibsen created CAMEL-11958: --- Summary: rest-dsl - Disable vendor extension by default Key: CAMEL-11958 URL: https://issues.apache.org/jira/browse/CAMEL-11958 Project: Camel Issue Type: Improvement Components: camel-core, camel-swagger Affects Versions: 2.20.0 Reporter: Claus Ibsen Assignee: Claus Ibsen Fix For: 2.20.1, 2.21.0 See CAMEL-11957 As 3rd party API tooling may not support vendor extension and that these extensions expose implementation details that end users may not want (model class name, that its Camel etc). This allows the generated API to be more neutral and clean. People can turn it back on with the new vendor extension option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11957) rest-dsl - Allow to turn off vendor extension in generated api docs
[ https://issues.apache.org/jira/browse/CAMEL-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222382#comment-16222382 ] Claus Ibsen commented on CAMEL-11957: - There is a new apiVendorExtension option on rest configuration you can set to false > rest-dsl - Allow to turn off vendor extension in generated api docs > --- > > Key: CAMEL-11957 > URL: https://issues.apache.org/jira/browse/CAMEL-11957 > Project: Camel > Issue Type: Improvement > Components: camel-core, camel-swagger >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.1, 2.21.0 > > > See SO > https://stackoverflow.com/questions/46975303/suppressing-camel-specific-attributes-from-camel-generated-swagger-definition > We should allow to turn this off -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11957) rest-dsl - Allow to turn off vendor extension in generated api docs
[ https://issues.apache.org/jira/browse/CAMEL-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11957. - Resolution: Fixed Fix Version/s: 2.20.1 > rest-dsl - Allow to turn off vendor extension in generated api docs > --- > > Key: CAMEL-11957 > URL: https://issues.apache.org/jira/browse/CAMEL-11957 > Project: Camel > Issue Type: Improvement > Components: camel-core, camel-swagger >Reporter: Claus Ibsen >Assignee: Claus Ibsen > Fix For: 2.20.1, 2.21.0 > > > See SO > https://stackoverflow.com/questions/46975303/suppressing-camel-specific-attributes-from-camel-generated-swagger-definition > We should allow to turn this off -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11957) rest-dsl - Allow to turn off vendor extension in generated api docs
Claus Ibsen created CAMEL-11957: --- Summary: rest-dsl - Allow to turn off vendor extension in generated api docs Key: CAMEL-11957 URL: https://issues.apache.org/jira/browse/CAMEL-11957 Project: Camel Issue Type: Improvement Components: camel-core, camel-swagger Reporter: Claus Ibsen Assignee: Claus Ibsen Fix For: 2.21.0 See SO https://stackoverflow.com/questions/46975303/suppressing-camel-specific-attributes-from-camel-generated-swagger-definition We should allow to turn this off -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11956) Support Spring 5.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222305#comment-16222305 ] Claus Ibsen commented on CAMEL-11956: - Support for spring 5 is on the roadmap for 2.21 release > Support Spring 5.0.x > > > Key: CAMEL-11956 > URL: https://issues.apache.org/jira/browse/CAMEL-11956 > Project: Camel > Issue Type: Task >Affects Versions: 2.20.0 >Reporter: Guillaume Nodet > Fix For: 2.21.0 > > > Not sure if camel runs correctly with spring 5.0.x, but the OSGi imports and > features exclude 5.x anyway... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222304#comment-16222304 ] ASF GitHub Bot commented on CAMEL-11387: davsclaus commented on issue #2066: CAMEL-11387 - adjust destination filename by calling existing method … URL: https://github.com/apache/camel/pull/2066#issuecomment-339962015 The ticket was reporting SFTP only (eg JCraft). Can this PR only change that one - as the other FTP client has not been reported issues like this, and its better not to change it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11956) Support Spring 5.0.x
[ https://issues.apache.org/jira/browse/CAMEL-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11956: Fix Version/s: 2.21.0 > Support Spring 5.0.x > > > Key: CAMEL-11956 > URL: https://issues.apache.org/jira/browse/CAMEL-11956 > Project: Camel > Issue Type: Task >Affects Versions: 2.20.0 >Reporter: Guillaume Nodet > Fix For: 2.21.0 > > > Not sure if camel runs correctly with spring 5.0.x, but the OSGi imports and > features exclude 5.x anyway... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1662#comment-1662 ] ASF GitHub Bot commented on CAMEL-11387: onders86 commented on a change in pull request #2066: CAMEL-11387 - adjust destination filename by calling existing method … URL: https://github.com/apache/camel/pull/2066#discussion_r147396213 ## File path: components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpOperations.java ## @@ -269,6 +269,9 @@ public boolean deleteFile(String name) throws GenericFileOperationFailedExceptio public boolean renameFile(String from, String to) throws GenericFileOperationFailedException { log.debug("Renaming file: {} to: {}", from, to); try { +//make use of the '/' separator because JSch expects this Review comment: good catch. i will update soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1661#comment-1661 ] ASF GitHub Bot commented on CAMEL-11387: davsclaus commented on a change in pull request #2066: CAMEL-11387 - adjust destination filename by calling existing method … URL: https://github.com/apache/camel/pull/2066#discussion_r147395660 ## File path: components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpOperations.java ## @@ -269,6 +269,9 @@ public boolean deleteFile(String name) throws GenericFileOperationFailedExceptio public boolean renameFile(String from, String to) throws GenericFileOperationFailedException { log.debug("Renaming file: {} to: {}", from, to); try { +//make use of the '/' separator because JSch expects this Review comment: JSch is only used for SftpOperations. So this comment is a bit mis-leading. ftp is using commons-net This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11956) Support Spring 5.0.x
Guillaume Nodet created CAMEL-11956: --- Summary: Support Spring 5.0.x Key: CAMEL-11956 URL: https://issues.apache.org/jira/browse/CAMEL-11956 Project: Camel Issue Type: Task Affects Versions: 2.20.0 Reporter: Guillaume Nodet Not sure if camel runs correctly with spring 5.0.x, but the OSGi imports and features exclude 5.x anyway... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11918) Wrong parent version in connectors/examples/pom.xml
[ https://issues.apache.org/jira/browse/CAMEL-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1630#comment-1630 ] Önder Sezgin commented on CAMEL-11918: -- [~gzurowski] already published the and we did not catch it already. can we close the issue? 2.20.X seems fine. we can maybe fix 2.20.0 branch anyway? do we need it? > Wrong parent version in connectors/examples/pom.xml > --- > > Key: CAMEL-11918 > URL: https://issues.apache.org/jira/browse/CAMEL-11918 > Project: Camel > Issue Type: Task > Components: build system, camel-connector >Affects Versions: 2.20.0 >Reporter: Paolo Antinori >Priority: Minor > Fix For: 2.21.0 > > > {{connectors/examples/pom.xml}} of the released tag {{2.20.0}} still points > to a SNAPSHOT version: > https://github.com/apache/camel/blob/camel-2.20.0/connectors/examples/pom.xml#L27 > This is probably the side effect of using {{maven-release-plugin}} and the > fact that {{connectores/example}} module is detached: > https://github.com/apache/camel/blob/camel-2.20.0/connectors/pom.xml#L40 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11387) SFTP is delivered into incorrect location, without exception (file in subfolder + temp file is created + Camel running on Window & SFTP server running on LINUX)
[ https://issues.apache.org/jira/browse/CAMEL-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222198#comment-16222198 ] Önder Sezgin commented on CAMEL-11387: -- today, i had a chance to test the case from windows client against unix ftp. {{stepwise=false}} does not seem to help. The problem is because the folder structure seems to get created on unix Server with Windows separators and jcraft's rename method needs '/' even if it is on windows. Sending PR soon. > SFTP is delivered into incorrect location, without exception (file in > subfolder + temp file is created + Camel running on Window & SFTP server > running on LINUX) > > > Key: CAMEL-11387 > URL: https://issues.apache.org/jira/browse/CAMEL-11387 > Project: Camel > Issue Type: Bug > Components: camel-sftp >Affects Versions: 2.19.0 > Environment: camel is running on Window, and SFTP server is LINUX >Reporter: Cherry Ngai >Assignee: Önder Sezgin >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > The bug only happens when: > i) file in subfolder > ii) temp file is created > iii) Camel running on Window & SFTP server running on LINUX > Route Configuration: > {code} > from("file://sourceFolder?recursive=true=6"). > to("sftp://username@linuxServer?tempFileName=${file:onlyname}.part;); > {code} > NOTES: added separator=UNIX or AUTO, I got the same issue. > Window Local File: sourceFolder/myfolder1/myfolder2/test.txt > FTPS Remote File Delivered: $linuxServer/myfolder1myfolder2test.txt > NOTES: > * There is no exception throw in 2.19.0, even though the file delivered into > incorrect location. > * In 2.17.3, exception throw at > org.apache.camel.component.file.remote.SftpOperations.renameFile(SftpOperations.java:431)[camel-ftp-2.17.3.jar:2.17.3] > * Without tempFileName, it works perfectly. Issue is around the rename area. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11927) camel-spring-ws - Support for header transformation
[ https://issues.apache.org/jira/browse/CAMEL-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222190#comment-16222190 ] ASF GitHub Bot commented on CAMEL-11927: onders86 commented on issue #2055: CAMEL-11927 - Improve support for soap header transformations - [Than… URL: https://github.com/apache/camel/pull/2055#issuecomment-339945351 @richardgroote , do you mind adding javadoc so that we can update PR and have it merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > camel-spring-ws - Support for header transformation > --- > > Key: CAMEL-11927 > URL: https://issues.apache.org/jira/browse/CAMEL-11927 > Project: Camel > Issue Type: Improvement > Components: camel-spring-ws >Affects Versions: 2.19.3 >Reporter: Richard Groote >Assignee: Önder Sezgin > Fix For: 2.21.0 > > Attachments: CompositeMessageFilter.java, > HeaderTransformationMessageFilter.java, SoapHeaderTest-context.xml, > SoapHeaderTest.java, soap-header-transform.xslt > > > Improve support for soap header transformations: > - The composite message filter is to have multiple filters applied > - Header transformation filters is use to transform the soap header using a > stylesheet. > I was not able to create a pull request for it -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11955) Using @AdviceWith and testing camel-spring-boot startup CamelContext eager
[ https://issues.apache.org/jira/browse/CAMEL-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11955. - Resolution: Fixed > Using @AdviceWith and testing camel-spring-boot startup CamelContext eager > -- > > Key: CAMEL-11955 > URL: https://issues.apache.org/jira/browse/CAMEL-11955 > Project: Camel > Issue Type: Bug > Components: camel-spring-boot, camel-test >Affects Versions: 2.20.0 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > > See > http://camel.465427.n5.nabble.com/CamelSpringBootRunner-and-AdviceWith-tp5814802.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11955) Using @AdviceWith and testing camel-spring-boot startup CamelContext eager
Claus Ibsen created CAMEL-11955: --- Summary: Using @AdviceWith and testing camel-spring-boot startup CamelContext eager Key: CAMEL-11955 URL: https://issues.apache.org/jira/browse/CAMEL-11955 Project: Camel Issue Type: Bug Components: camel-spring-boot, camel-test Affects Versions: 2.20.0 Reporter: Claus Ibsen Assignee: Claus Ibsen Priority: Minor Fix For: 2.20.1, 2.21.0 See http://camel.465427.n5.nabble.com/CamelSpringBootRunner-and-AdviceWith-tp5814802.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Papke closed CAMEL-11948. Thanks for commit and merge to branch. > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221994#comment-16221994 ] Luca Burgazzoli edited comment on CAMEL-11954 at 10/27/17 9:19 AM: --- Fine with me. For consistency we should also rename the ha package in all the modules was (Author: lb): Fine with me > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221994#comment-16221994 ] Luca Burgazzoli commented on CAMEL-11954: - Fine with me > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221965#comment-16221965 ] Claus Ibsen commented on CAMEL-11954: - Should we rename the source code ha package as well, I do like cluster more > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11954: Estimated Complexity: Novice (was: Unknown) > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221955#comment-16221955 ] Claus Ibsen commented on CAMEL-11954: - Yeah they are better names. > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221923#comment-16221923 ] Luca Burgazzoli commented on CAMEL-11954: - I'd go with - routecontrollers - clusterservices > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221921#comment-16221921 ] Claus Ibsen edited comment on CAMEL-11954 at 10/27/17 8:16 AM: --- [~lb] any thoughts? Also we should rename routecontroller to routecontrollers so its like the others (with an ending s) And should ha -> cluster be -> clusters or clustercontrollers or clusterservices was (Author: davsclaus): [~lb] any thoughts? Also we should rename routecontroller to routecontrollers so its like the others (with an ending s) And should ha -> cluster be -> clusters > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11954) Camel JMX name for cluster service
[ https://issues.apache.org/jira/browse/CAMEL-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221921#comment-16221921 ] Claus Ibsen commented on CAMEL-11954: - [~lb] any thoughts? Also we should rename routecontroller to routecontrollers so its like the others (with an ending s) And should ha -> cluster be -> clusters > Camel JMX name for cluster service > -- > > Key: CAMEL-11954 > URL: https://issues.apache.org/jira/browse/CAMEL-11954 > Project: Camel > Issue Type: Improvement > Components: camel-core, jmx >Reporter: Claus Ibsen > Fix For: 2.21.0 > > > We use ha today, which is a bit too short and confusing. > Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (CAMEL-11954) Camel JMX name for cluster service
Claus Ibsen created CAMEL-11954: --- Summary: Camel JMX name for cluster service Key: CAMEL-11954 URL: https://issues.apache.org/jira/browse/CAMEL-11954 Project: Camel Issue Type: Improvement Components: camel-core, jmx Reporter: Claus Ibsen Fix For: 2.21.0 We use ha today, which is a bit too short and confusing. Lets rename this to something better, like cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11952) XSLT options not set when resource URI is http
[ https://issues.apache.org/jira/browse/CAMEL-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11952. - Resolution: Fixed Assignee: Claus Ibsen > XSLT options not set when resource URI is http > -- > > Key: CAMEL-11952 > URL: https://issues.apache.org/jira/browse/CAMEL-11952 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Tyler Flaherty >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > Options included for an XSLT endpoint URI are not applied if the resource is > referenced via HTTP. > In XsltComponent.createEndpoint(), it checks if the resource URI is http > (XsltComponent:179). If it is, ResourceHelper.appendParameters() is called > (XsltComponent:180). > ResourceHelper.appendParameters() adds the parameters to the HTTP URI and > then clears the parameters list (ResourceHelper:336). > By the time setProperties() is called on line 207 of XsltComponent, the > parameters map is empty and nothing gets set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11952) XSLT options not set when resource URI is http
[ https://issues.apache.org/jira/browse/CAMEL-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11952: Fix Version/s: 2.21.0 2.20.1 > XSLT options not set when resource URI is http > -- > > Key: CAMEL-11952 > URL: https://issues.apache.org/jira/browse/CAMEL-11952 > Project: Camel > Issue Type: Bug > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Tyler Flaherty >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > Options included for an XSLT endpoint URI are not applied if the resource is > referenced via HTTP. > In XsltComponent.createEndpoint(), it checks if the resource URI is http > (XsltComponent:179). If it is, ResourceHelper.appendParameters() is called > (XsltComponent:180). > ResourceHelper.appendParameters() adds the parameters to the HTTP URI and > then clears the parameters list (ResourceHelper:336). > By the time setProperties() is called on line 207 of XsltComponent, the > parameters map is empty and nothing gets set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11948: Fix Version/s: 2.20.1 > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11224) aws-sqs producer does not support new FIFO queues
[ https://issues.apache.org/jira/browse/CAMEL-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11224. - Resolution: Fixed Assignee: Claus Ibsen > aws-sqs producer does not support new FIFO queues > - > > Key: CAMEL-11224 > URL: https://issues.apache.org/jira/browse/CAMEL-11224 > Project: Camel > Issue Type: Improvement > Components: camel-aws >Reporter: Emilio Corengia >Assignee: Claus Ibsen > Fix For: 2.21.0 > > > At the moment *aws-sqs producer* does not support the new _FIFO_ queue > mechanism from AWS ([FIFO-queues > ref|http://http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html]). > There is a new parameter, +MessageGroupId+, that is required for FIFO queues > (it is not available on Standard queues). > The message group ID is the tag that specifies that a message belongs to a > specific message group. Messages that belong to the same message group are > always processed one by one, in a strict order relative to the message group > (however, messages that belong to different message groups might be processed > out of order). +Source+: > http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queue-recommendations.html#using-messagegroupid-property. > This improvement consists on adding support for MessageGroupId on the > producer side of aws-sqs. It should be applicable on FIFO queues only. It > could be customizable via URI options. A default strategy should be provided. > This default strategy will generate a unique message group ID for each > message to favor throughput and latency over ordering of messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11224) aws-sqs producer does not support new FIFO queues
[ https://issues.apache.org/jira/browse/CAMEL-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221879#comment-16221879 ] ASF GitHub Bot commented on CAMEL-11224: davsclaus commented on issue #2018: CAMEL-11224 aws-sqs producer does not support new FIFO queues URL: https://github.com/apache/camel/pull/2018#issuecomment-339897686 Thanks for the PR. It has been merged. I wonder if you would mind doing a new PR to update the documentation and talk about FIFO queues and show an example https://github.com/apache/camel/blob/master/components/camel-aws/src/main/docs/aws-sqs-component.adoc This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > aws-sqs producer does not support new FIFO queues > - > > Key: CAMEL-11224 > URL: https://issues.apache.org/jira/browse/CAMEL-11224 > Project: Camel > Issue Type: Improvement > Components: camel-aws >Reporter: Emilio Corengia > Fix For: 2.21.0 > > > At the moment *aws-sqs producer* does not support the new _FIFO_ queue > mechanism from AWS ([FIFO-queues > ref|http://http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html]). > There is a new parameter, +MessageGroupId+, that is required for FIFO queues > (it is not available on Standard queues). > The message group ID is the tag that specifies that a message belongs to a > specific message group. Messages that belong to the same message group are > always processed one by one, in a strict order relative to the message group > (however, messages that belong to different message groups might be processed > out of order). +Source+: > http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queue-recommendations.html#using-messagegroupid-property. > This improvement consists on adding support for MessageGroupId on the > producer side of aws-sqs. It should be applicable on FIFO queues only. It > could be customizable via URI options. A default strategy should be provided. > This default strategy will generate a unique message group ID for each > message to favor throughput and latency over ordering of messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11224) aws-sqs producer does not support new FIFO queues
[ https://issues.apache.org/jira/browse/CAMEL-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221878#comment-16221878 ] Claus Ibsen commented on CAMEL-11224: - Thanks for the PR. It has been merged. I wonder if you would mind doing a new PR to update the documentation and talk about FIFO queues and show an example https://github.com/apache/camel/blob/master/components/camel-aws/src/main/docs/aws-sqs-component.adoc > aws-sqs producer does not support new FIFO queues > - > > Key: CAMEL-11224 > URL: https://issues.apache.org/jira/browse/CAMEL-11224 > Project: Camel > Issue Type: Improvement > Components: camel-aws >Reporter: Emilio Corengia > Fix For: 2.21.0 > > > At the moment *aws-sqs producer* does not support the new _FIFO_ queue > mechanism from AWS ([FIFO-queues > ref|http://http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html]). > There is a new parameter, +MessageGroupId+, that is required for FIFO queues > (it is not available on Standard queues). > The message group ID is the tag that specifies that a message belongs to a > specific message group. Messages that belong to the same message group are > always processed one by one, in a strict order relative to the message group > (however, messages that belong to different message groups might be processed > out of order). +Source+: > http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queue-recommendations.html#using-messagegroupid-property. > This improvement consists on adding support for MessageGroupId on the > producer side of aws-sqs. It should be applicable on FIFO queues only. It > could be customizable via URI options. A default strategy should be provided. > This default strategy will generate a unique message group ID for each > message to favor throughput and latency over ordering of messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11224) aws-sqs producer does not support new FIFO queues
[ https://issues.apache.org/jira/browse/CAMEL-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221876#comment-16221876 ] ASF GitHub Bot commented on CAMEL-11224: davsclaus closed pull request #2018: CAMEL-11224 aws-sqs producer does not support new FIFO queues URL: https://github.com/apache/camel/pull/2018 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ConstantMessageGroupIdStrategy.java b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ConstantMessageGroupIdStrategy.java new file mode 100644 index 000..be5be47b2fd --- /dev/null +++ b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ConstantMessageGroupIdStrategy.java @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.aws.sqs; + +import org.apache.camel.Exchange; + +public class ConstantMessageGroupIdStrategy implements MessageGroupIdStrategy { + +@Override +public String getMessageGroupId(Exchange exchange) { +return "CamelSingleMessageGroup"; +} + +} diff --git a/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageDeduplicationIdStrategy.java b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageDeduplicationIdStrategy.java new file mode 100644 index 000..6a50ffc5967 --- /dev/null +++ b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageDeduplicationIdStrategy.java @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.aws.sqs; + +import org.apache.camel.Exchange; + +public class ExchangeIdMessageDeduplicationIdStrategy implements MessageDeduplicationIdStrategy { + +@Override +public String getMessageDeduplicationId(Exchange exchange) { +return exchange.getExchangeId(); +} + +} diff --git a/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageGroupIdStrategy.java b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageGroupIdStrategy.java new file mode 100644 index 000..af38e10b74f --- /dev/null +++ b/components/camel-aws/src/main/java/org/apache/camel/component/aws/sqs/ExchangeIdMessageGroupIdStrategy.java @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language
[jira] [Commented] (CAMEL-11224) aws-sqs producer does not support new FIFO queues
[ https://issues.apache.org/jira/browse/CAMEL-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221877#comment-16221877 ] ASF GitHub Bot commented on CAMEL-11224: Github user davsclaus closed the pull request at: https://github.com/apache/camel/pull/2018 > aws-sqs producer does not support new FIFO queues > - > > Key: CAMEL-11224 > URL: https://issues.apache.org/jira/browse/CAMEL-11224 > Project: Camel > Issue Type: Improvement > Components: camel-aws >Reporter: Emilio Corengia > Fix For: 2.21.0 > > > At the moment *aws-sqs producer* does not support the new _FIFO_ queue > mechanism from AWS ([FIFO-queues > ref|http://http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html]). > There is a new parameter, +MessageGroupId+, that is required for FIFO queues > (it is not available on Standard queues). > The message group ID is the tag that specifies that a message belongs to a > specific message group. Messages that belong to the same message group are > always processed one by one, in a strict order relative to the message group > (however, messages that belong to different message groups might be processed > out of order). +Source+: > http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queue-recommendations.html#using-messagegroupid-property. > This improvement consists on adding support for MessageGroupId on the > producer side of aws-sqs. It should be applicable on FIFO queues only. It > could be customizable via URI options. A default strategy should be provided. > This default strategy will generate a unique message group ID for each > message to favor throughput and latency over ordering of messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11292) support for Scala 2.12.x
[ https://issues.apache.org/jira/browse/CAMEL-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-11292: Fix Version/s: 2.21.0 > support for Scala 2.12.x > > > Key: CAMEL-11292 > URL: https://issues.apache.org/jira/browse/CAMEL-11292 > Project: Camel > Issue Type: New Feature > Components: camel-scala >Affects Versions: 2.19.0 >Reporter: Sarunas Valaskevicius >Priority: Minor > Fix For: 2.21.0 > > > currently camel-scala depends on Scala 2.11. could this be upgraded to 2.12.x > release? > Same with scalatest. > All possible updates can be seen here - > https://mvnrepository.com/artifact/org.apache.camel/camel-scala/2.19.0 > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11292) support for Scala 2.12.x
[ https://issues.apache.org/jira/browse/CAMEL-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221843#comment-16221843 ] Claus Ibsen commented on CAMEL-11292: - That model has been fixed. But you can just run unit tests of camel-scala, and not all the other stuff. > support for Scala 2.12.x > > > Key: CAMEL-11292 > URL: https://issues.apache.org/jira/browse/CAMEL-11292 > Project: Camel > Issue Type: New Feature > Components: camel-scala >Affects Versions: 2.19.0 >Reporter: Sarunas Valaskevicius >Priority: Minor > Fix For: 2.21.0 > > > currently camel-scala depends on Scala 2.11. could this be upgraded to 2.12.x > release? > Same with scalatest. > All possible updates can be seen here - > https://mvnrepository.com/artifact/org.apache.camel/camel-scala/2.19.0 > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen resolved CAMEL-11948. - Resolution: Fixed Assignee: Claus Ibsen Thanks for the PR > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Assignee: Claus Ibsen >Priority: Minor > Fix For: 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221840#comment-16221840 ] ASF GitHub Bot commented on CAMEL-11948: Github user davsclaus closed the pull request at: https://github.com/apache/camel/pull/2064 > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Priority: Minor > Fix For: 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221839#comment-16221839 ] ASF GitHub Bot commented on CAMEL-11948: davsclaus closed pull request #2064: CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was used URL: https://github.com/apache/camel/pull/2064 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/camel-core/src/main/java/org/apache/camel/impl/MessageSupport.java b/camel-core/src/main/java/org/apache/camel/impl/MessageSupport.java index 4c564b89aa3..a2ae7e73a2a 100644 --- a/camel-core/src/main/java/org/apache/camel/impl/MessageSupport.java +++ b/camel-core/src/main/java/org/apache/camel/impl/MessageSupport.java @@ -33,7 +33,7 @@ * Unless a specific provider wishes to do something particularly clever with * headers you probably want to just derive from {@link DefaultMessage} * - * @version + * @version */ public abstract class MessageSupport implements Message, CamelContextAware, DataTypeAware { private CamelContext camelContext; @@ -48,6 +48,7 @@ public String toString() { return String.format("Message[%s]", messageId == null ? "" : messageId); } +@Override public Object getBody() { if (body == null) { body = createBody(); @@ -55,10 +56,12 @@ public Object getBody() { return body; } +@Override public T getBody(Class type) { return getBody(type, getBody()); } +@Override public Object getMandatoryBody() throws InvalidPayloadException { Object answer = getBody(); if (answer == null) { @@ -97,6 +100,7 @@ public Object getMandatoryBody() throws InvalidPayloadException { return null; } +@Override public T getMandatoryBody(Class type) throws InvalidPayloadException { // eager same instance type test to avoid the overhead of invoking the type converter // if already same type @@ -116,14 +120,16 @@ public Object getMandatoryBody() throws InvalidPayloadException { throw new InvalidPayloadException(e, type, this); } +@Override public void setBody(Object body) { this.body = body; // set data type if in use -if (body != null && camelContext.isUseDataType()) { +if (body != null && camelContext != null && camelContext.isUseDataType()) { this.dataType = new DataType(body.getClass()); } } +@Override public void setBody(Object value, Class type) { Exchange e = getExchange(); if (e != null) { @@ -156,6 +162,7 @@ public boolean hasDataType() { return dataType != null; } +@Override public Message copy() { Message answer = newInstance(); // must copy over CamelContext @@ -166,6 +173,7 @@ public Message copy() { return answer; } +@Override public void copyFrom(Message that) { if (that == this) { // the same instance so do not need to copy @@ -183,6 +191,7 @@ public void copyFrom(Message that) { copyFromWithNewBody(that, that.getBody()); } +@Override public void copyFromWithNewBody(Message that, Object newBody) { if (that == this) { // the same instance so do not need to copy @@ -219,6 +228,7 @@ public void copyFromWithNewBody(Message that, Object newBody) { copyAttachments(that); } +@Override public Exchange getExchange() { return exchange; } @@ -227,14 +237,17 @@ public void setExchange(Exchange exchange) { this.exchange = exchange; } +@Override public CamelContext getCamelContext() { return camelContext; } +@Override public void setCamelContext(CamelContext camelContext) { this.camelContext = camelContext; } +@Override public void copyAttachments(Message that) { // the attachments may be the same instance if the end user has made some mistake // and set the OUT message with the same attachment instance of the IN message etc @@ -270,6 +283,7 @@ protected Object createBody() { return null; } +@Override public String getMessageId() { if (messageId == null) { messageId = createMessageId(); @@ -277,6 +291,7 @@ public String getMessageId() { return this.messageId; } +@Override public void setMessageId(String messageId) { this.messageId = messageId; } diff --git a/camel-core/src/test/java/org/apache/camel/impl/DefaultMessageTest.java
[jira] [Commented] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221834#comment-16221834 ] ASF GitHub Bot commented on CAMEL-11948: Thopap opened a new pull request #2064: CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was used URL: https://github.com/apache/camel/pull/2064 After upgrade camel 2.20.0, some operations fail with a NullPointerException: ``` Caused by: java.lang.NullPointerException at org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) ``` The issue seems to be introduced with the change CAMEL-11380. The issue could be easily reproduced by using the deprecated constructor, where no camelContext is set: ``` Message message = new DefaultMessage(); message.setBody("something"); ``` To remain better backward compatibility, i would suggest a nullcheck in the setBody for cases where the CamelContext is not set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Priority: Minor > Fix For: 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11948) NPE on DefaultMessage setBody if deprecated constructor was used
[ https://issues.apache.org/jira/browse/CAMEL-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221835#comment-16221835 ] ASF GitHub Bot commented on CAMEL-11948: GitHub user Thopap opened a pull request: https://github.com/apache/camel/pull/2064 CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was used After upgrade camel 2.20.0, some operations fail with a NullPointerException: ``` Caused by: java.lang.NullPointerException at org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) ``` The issue seems to be introduced with the change CAMEL-11380. The issue could be easily reproduced by using the deprecated constructor, where no camelContext is set: ``` Message message = new DefaultMessage(); message.setBody("something"); ``` To remain better backward compatibility, i would suggest a nullcheck in the setBody for cases where the CamelContext is not set. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Thopap/camel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2064.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2064 commit 14baabbfaeb6edf53080b27c7984135d7af453d6 Author: Thomas PapkeDate: 2017-10-26T15:31:56Z CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was used commit 4701576cc2f140b829726a1ad529e82090f1e4ee Author: Thomas Papke Date: 2017-10-27T07:02:25Z CAMEL-11948 NPE on DefaultMessage setBody if deprecated constructor was used * Adding test > NPE on DefaultMessage setBody if deprecated constructor was used > > > Key: CAMEL-11948 > URL: https://issues.apache.org/jira/browse/CAMEL-11948 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.20.0 >Reporter: Thomas Papke >Priority: Minor > Fix For: 2.21.0 > > > After upgrade camel 2.20.0, some operations fail with a NullPointerException: > {code} > Caused by: java.lang.NullPointerException > at > org.apache.camel.impl.MessageSupport.setBody(MessageSupport.java:122) > {code} > The issue seems to be introduced with the change CAMEL-11380. > The issue could be easily reproduced by using the deprecated constructor, > where no camelContext is set: > {code} > Message message = new DefaultMessage(); > message.setBody("something"); > {code} > To remain better backward compatibility, i would suggest a nullcheck in the > setBody for cases where the CamelContext is not set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11950) Inconsistent jar versions with apache curator
[ https://issues.apache.org/jira/browse/CAMEL-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-11950. -- Resolution: Fixed > Inconsistent jar versions with apache curator > - > > Key: CAMEL-11950 > URL: https://issues.apache.org/jira/browse/CAMEL-11950 > Project: Camel > Issue Type: Bug > Components: camel-zookeeper >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/2243 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11950) Inconsistent jar versions with apache curator
[ https://issues.apache.org/jira/browse/CAMEL-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221823#comment-16221823 ] ASF GitHub Bot commented on CAMEL-11950: Github user oscerd closed the pull request at: https://github.com/apache/camel/pull/2063 > Inconsistent jar versions with apache curator > - > > Key: CAMEL-11950 > URL: https://issues.apache.org/jira/browse/CAMEL-11950 > Project: Camel > Issue Type: Bug > Components: camel-zookeeper >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/2243 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11950) Inconsistent jar versions with apache curator
[ https://issues.apache.org/jira/browse/CAMEL-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221822#comment-16221822 ] ASF GitHub Bot commented on CAMEL-11950: oscerd closed pull request #2063: [CAMEL-11950] Inconsistent jar versions with apache curator URL: https://github.com/apache/camel/pull/2063 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-zookeeper/pom.xml b/components/camel-zookeeper/pom.xml index 7be8c696576..31cc161656e 100644 --- a/components/camel-zookeeper/pom.xml +++ b/components/camel-zookeeper/pom.xml @@ -71,10 +71,14 @@ org.apache.curator + curator-client + ${curator-version} + + + org.apache.curator curator-framework ${curator-version} - org.apache.curator curator-recipes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Inconsistent jar versions with apache curator > - > > Key: CAMEL-11950 > URL: https://issues.apache.org/jira/browse/CAMEL-11950 > Project: Camel > Issue Type: Bug > Components: camel-zookeeper >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/2243 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CAMEL-11950) Inconsistent jar versions with apache curator
[ https://issues.apache.org/jira/browse/CAMEL-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221821#comment-16221821 ] ASF GitHub Bot commented on CAMEL-11950: oscerd commented on issue #2063: [CAMEL-11950] Inconsistent jar versions with apache curator URL: https://github.com/apache/camel/pull/2063#issuecomment-339888257 Thanks @tdiesler the PR has been merged on 2.20.x and master. I'm closing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Inconsistent jar versions with apache curator > - > > Key: CAMEL-11950 > URL: https://issues.apache.org/jira/browse/CAMEL-11950 > Project: Camel > Issue Type: Bug > Components: camel-zookeeper >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/2243 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (CAMEL-11950) Inconsistent jar versions with apache curator
[ https://issues.apache.org/jira/browse/CAMEL-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino updated CAMEL-11950: - Fix Version/s: 2.21.0 > Inconsistent jar versions with apache curator > - > > Key: CAMEL-11950 > URL: https://issues.apache.org/jira/browse/CAMEL-11950 > Project: Camel > Issue Type: Bug > Components: camel-zookeeper >Reporter: Thomas Diesler >Assignee: Thomas Diesler > Fix For: 2.20.1, 2.21.0 > > > CrossRef: https://github.com/wildfly-extras/wildfly-camel/issues/2243 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (CAMEL-11953) maven connector plugin: connector only properties are ignored in spring boot code generation
[ https://issues.apache.org/jira/browse/CAMEL-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli resolved CAMEL-11953. - Resolution: Fixed > maven connector plugin: connector only properties are ignored in spring boot > code generation > > > Key: CAMEL-11953 > URL: https://issues.apache.org/jira/browse/CAMEL-11953 > Project: Camel > Issue Type: Bug > Components: camel-connector >Affects Versions: 2.20.0 >Reporter: Luca Burgazzoli >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.20.1, 2.21.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)