[jira] [Commented] (CAMEL-15185) Improve Footer on Camel Website
[
https://issues.apache.org/jira/browse/CAMEL-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160362#comment-17160362
]
ASF GitHub Bot commented on CAMEL-15185:
AemieJ commented on a change in pull request #428:
URL: https://github.com/apache/camel-website/pull/428#discussion_r456762637
##
File path: antora-ui-camel/src/js/06-mobile-footer.js
##
@@ -0,0 +1,15 @@
+document.addEventListener('DOMContentLoaded', function () {
Review comment:
While the `:target` selector works with toggling, it causes unnecessary
scrolling in pages. I will try with the use of a `:checked` selector as well
but if it works toggling with the checked selector in this scenario, I think in
that way we could minimize the use of javascript for navbar burger toggling and
the dropdown menu toggling for the mobile version.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve Footer on Camel Website
> ---
>
> Key: CAMEL-15185
> URL: https://issues.apache.org/jira/browse/CAMEL-15185
> Project: Camel
> Issue Type: Improvement
> Components: website
>Reporter: Aashna Jena
>Priority: Major
> Labels: outreachy2020, suggestions
> Attachments: footer-arrangement-626.png, footer-design-2.png,
> footer-design.png, footer-mobile-1.1.png, footer-mobile-1.2.png
>
>
> I have some reservations about the website footer. On the mobile view, the
> footer takes up almost the entire height of my device because the Overview,
> Community and About columns do not fit into one row. Secondly, on the desktop
> view, the header navigation is fixed at the top, so I can view the header
> menu while I'm at the footer of the page. Having same links visible on the
> header menu and footer doesn't make sense to me (Download, Community, Blog
> etc). I do see a lot of websites having menu links on the footer, but they
> don't have a fixed navbar.
> Suggestions : I looked up best practices for footers. I think we can reduce
> the number of links we display on the footer, especially the ones overlapping
> with header menu. We can also add some things (from what I read up on best
> practices) - form for subscribing to the mailing list, sitemap link, contact
> information, link to report a bug on the website, privacy policy/ terms of
> use (if we have) and maybe a subscription for the blog, since we have quite
> informative and regular blog posts. I also really like the idea of having a
> row of social media icons in the footer, which a lot of websites do. This
> will give us the freedom of adding many more icons than on the header menu.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (CAMEL-15274) camel-spring-boot - Add back http endpoint for route information
[ https://issues.apache.org/jira/browse/CAMEL-15274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CAMEL-15274 started by Ramu. > camel-spring-boot - Add back http endpoint for route information > > > Key: CAMEL-15274 > URL: https://issues.apache.org/jira/browse/CAMEL-15274 > Project: Camel > Issue Type: New Feature > Components: camel-spring-boot >Reporter: Claus Ibsen >Assignee: Ramu >Priority: Major > Fix For: 3.x > > > In Camel 2.x we had spring boot actuator that could output route details, eg > a list of the routes and their state, and some metrics. > It was also possible to stop/start routes etc. > However the latter was a concern for security. > But having a basic http endpoint service to dump route details would be good. > It should be disabled by default and only be a read-only service if enabled. > The old code in 2.x can be of inspiration. > And the old code is not compatible with newer spring boot so it needs to be > migrated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CAMEL-15185) Improve Footer on Camel Website
[ https://issues.apache.org/jira/browse/CAMEL-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160414#comment-17160414 ] ASF GitHub Bot commented on CAMEL-15185: AemieJ commented on pull request #428: URL: https://github.com/apache/camel-website/pull/428#issuecomment-660474374 @zregvart I have made use of checkbox for the toggling effect instead of using javascript for the same now! Also as the toggling works with CSS itself, can we adapt this for the dropdown menu item toggling within the navbar as well and the navbar burger as this will minimize the use of javascript as a whole? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Footer on Camel Website > --- > > Key: CAMEL-15185 > URL: https://issues.apache.org/jira/browse/CAMEL-15185 > Project: Camel > Issue Type: Improvement > Components: website >Reporter: Aashna Jena >Priority: Major > Labels: outreachy2020, suggestions > Attachments: footer-arrangement-626.png, footer-design-2.png, > footer-design.png, footer-mobile-1.1.png, footer-mobile-1.2.png > > > I have some reservations about the website footer. On the mobile view, the > footer takes up almost the entire height of my device because the Overview, > Community and About columns do not fit into one row. Secondly, on the desktop > view, the header navigation is fixed at the top, so I can view the header > menu while I'm at the footer of the page. Having same links visible on the > header menu and footer doesn't make sense to me (Download, Community, Blog > etc). I do see a lot of websites having menu links on the footer, but they > don't have a fixed navbar. > Suggestions : I looked up best practices for footers. I think we can reduce > the number of links we display on the footer, especially the ones overlapping > with header menu. We can also add some things (from what I read up on best > practices) - form for subscribing to the mailing list, sitemap link, contact > information, link to report a bug on the website, privacy policy/ terms of > use (if we have) and maybe a subscription for the blog, since we have quite > informative and regular blog posts. I also really like the idea of having a > row of social media icons in the footer, which a lot of websites do. This > will give us the freedom of adding many more icons than on the header menu. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (CAMEL-15310) AWS S3 - Support for more than 1 client in the registry
Christophe Willemsen created CAMEL-15310:
Summary: AWS S3 - Support for more than 1 client in the registry
Key: CAMEL-15310
URL: https://issues.apache.org/jira/browse/CAMEL-15310
Project: Camel
Issue Type: Bug
Components: camel-aws-s3
Affects Versions: 3.4.1, 3.1.0
Reporter: Christophe Willemsen
The `amazonS3Client` query parameter takes the key of the bean in the registry
as argument, however that key is not used.
Actually, today the component supports *ONLY* having 1 bean of type AmazonS3 in
the registry, the following method in the S3Component shows it :
{code:java}
private void checkAndSetRegistryClient(S3Configuration configuration) {
Set clients =
this.getCamelContext().getRegistry().findByType(AmazonS3.class);
if (clients.size() == 1) {
configuration.setAmazonS3Client((AmazonS3)clients.stream().findFirst().get());
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CAMEL-15296) Create sitemap for Camel website
[
https://issues.apache.org/jira/browse/CAMEL-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160511#comment-17160511
]
Aemie commented on CAMEL-15296:
---
[~aashnajena], [~zregvart] we could use that or as stated in one call we can
make use of the sitemap present within the documentation folder. We could make
use of gulp to automate the task and use regex as well. I will just run through
the regex as I tried working with a piece of string and with regex, it works
out.
Let's say we have a string
*s='hey-camel.htmlhey-spring.html'*
and *matchesOfLoc=/(.*?)<\/loc>/g.* When we run
*listOfLoc=s.match(matchesOfLoc),* you get a list of all the loc tag.
With this list, we can run a loop and extract the filename for each. Here, we
have our list as *["hey-camel.html", "hey-spring.html"]*.
I will walk you through to extract the name for a particular element of the
list.
*fileName = matchesOfLoc.exec(listOfLoc[1])*
*title = fileName[1].replace(/^.*[\\\/]/, '')*
*name = title.replace('.html', '')*
Here, your output would be *hey-spring.* With this manner, we could extract the
names of each file through the sitemap itself.
> Create sitemap for Camel website
>
>
> Key: CAMEL-15296
> URL: https://issues.apache.org/jira/browse/CAMEL-15296
> Project: Camel
> Issue Type: New Feature
> Components: website
>Reporter: Aashna Jena
>Priority: Minor
> Labels: outreachy2020
>
> Create a page with links to all documentation pages on the website. Automate
> this process and organise the links category wise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (CAMEL-15310) AWS S3 - Support for more than 1 client in the registry
[
https://issues.apache.org/jira/browse/CAMEL-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Cosentino reassigned CAMEL-15310:
Assignee: Andrea Cosentino
> AWS S3 - Support for more than 1 client in the registry
> ---
>
> Key: CAMEL-15310
> URL: https://issues.apache.org/jira/browse/CAMEL-15310
> Project: Camel
> Issue Type: Bug
> Components: camel-aws-s3
>Affects Versions: 3.1.0, 3.4.1
>Reporter: Christophe Willemsen
>Assignee: Andrea Cosentino
>Priority: Minor
>
> The `amazonS3Client` query parameter takes the key of the bean in the
> registry as argument, however that key is not used.
>
> Actually, today the component supports *ONLY* having 1 bean of type AmazonS3
> in the registry, the following method in the S3Component shows it :
>
>
> {code:java}
> private void checkAndSetRegistryClient(S3Configuration configuration) {
> Set clients =
> this.getCamelContext().getRegistry().findByType(AmazonS3.class);
> if (clients.size() == 1) {
>
> configuration.setAmazonS3Client((AmazonS3)clients.stream().findFirst().get());
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CAMEL-15064) Messages no more received from Google Pubsub
[
https://issues.apache.org/jira/browse/CAMEL-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160541#comment-17160541
]
Ramesh Venkitaswaran commented on CAMEL-15064:
--
This issue still seems to persist with camel 3.4.1 When I don't pass
GOOGLE_APPLICATION_CREDENTIALS, it silently comes up without any errors,
whereas, with Camel 3.1.0, it errors out as expected
> Messages no more received from Google Pubsub
>
>
> Key: CAMEL-15064
> URL: https://issues.apache.org/jira/browse/CAMEL-15064
> Project: Camel
> Issue Type: Bug
> Components: camel-google-pubsub
>Affects Versions: 3.2.0
> Environment: * macOS 10.15.4
> * OpenJDK 11.0.6 2020-01-14
> * I've been able to reproduce the issue on Ubuntu 16, same JDK
>Reporter: Jean-Pierre Matsumoto
>Assignee: Omar Al-Safi
>Priority: Major
> Fix For: 3.4.0
>
>
> With Camel 3.2.0, my route does not receive the messages from Google Pubsub.
> The exact same route works well if I downgrade to 3.1.0.
> I've created following test case to reproduce easily the issue:
> {code:java}
> @Component
> public class SimplePubsubRouteBuilder extends RouteBuilder {
> @Override
> public void configure() throws Exception {
> from("google-pubsub://project-id:subs-name")
> .to("log:myLog?showHeaders=true");
> }
> }{code}
> Result with *Camel 3.2.0*: nothing happens, no errors even with DEBUG log
> level.
> Result with *Camel 3.1.0*: error 404 as expected since Pubsub subscription
> path is invalid.
> I've tried to fix the issue myself with no success. But by tracing with
> debugger, I think the issue is because of bad version of Guava library.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work stopped] (CAMEL-15274) camel-spring-boot - Add back http endpoint for route information
[ https://issues.apache.org/jira/browse/CAMEL-15274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CAMEL-15274 stopped by Ramu. > camel-spring-boot - Add back http endpoint for route information > > > Key: CAMEL-15274 > URL: https://issues.apache.org/jira/browse/CAMEL-15274 > Project: Camel > Issue Type: New Feature > Components: camel-spring-boot >Reporter: Claus Ibsen >Assignee: Ramu >Priority: Major > Fix For: 3.x > > > In Camel 2.x we had spring boot actuator that could output route details, eg > a list of the routes and their state, and some metrics. > It was also possible to stop/start routes etc. > However the latter was a concern for security. > But having a basic http endpoint service to dump route details would be good. > It should be disabled by default and only be a read-only service if enabled. > The old code in 2.x can be of inspiration. > And the old code is not compatible with newer spring boot so it needs to be > migrated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
