[GitHub] carbondata pull request #2783: [HotFix] use unsafe for query model based on ...
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2783#discussion_r221237767 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java --- @@ -120,7 +121,7 @@ private boolean isFG; // whether to clear/free unsafe memory or not - private boolean freeUnsafeMemory = true; + private boolean freeUnsafeMemory; --- End diff -- oh, that will need many changes. I think it's OK to get this value from system property at the beginning and pass the value to the place where it is needed, cause the system property can be modified during processing. And in this scenario, directly using system property will cause problem. ---
[GitHub] carbondata pull request #2783: [HotFix] use unsafe for query model based on ...
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2783#discussion_r221225548 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/model/QueryModel.java --- @@ -120,7 +121,7 @@ private boolean isFG; // whether to clear/free unsafe memory or not - private boolean freeUnsafeMemory = true; + private boolean freeUnsafeMemory; --- End diff -- suggest to remove this variable, use system property whenever it is needed ---
[GitHub] carbondata pull request #2783: [HotFix] use unsafe for query model based on ...
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/2783 [HotFix] use unsafe for query model based on sytem property use unsafe for query model based on sytem property Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata 0928_fix_bloom_jvm_crash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2783.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2783 commit 5f3c1ebf6c7c73bf264b312a8de89d7d95665a51 Author: xuchuanyin Date: 2018-09-28T10:37:07Z use unsafe for query model based on sytem property use unsafe for query model based on sytem property ---
