subject:"\[jira\] \[Commented\] \(CLOUDSTACK\-10317\) In case of multiple\-public ips, snat fails to work for addtional public nics\/network for guest traffic"

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391095#comment-16391095
 ] 

ASF subversion and git services commented on CLOUDSTACK-10317:
--

Commit c0440e8124666fe7c642d8875870b7c09b65ce42 in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c0440e8 ]

CLOUDSTACK-10317: Fix SNAT rules for additional public nics (#2476)

* CLOUDSTACK-10317: Fix SNAT rules for additional public nics

This allows networks with additional public nics to have correct
SNAT iptables rules applied on configuration.

Signed-off-by: Rohit Yadav 

* update based on Wei's suggested change

Signed-off-by: Rohit Yadav 


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391094#comment-16391094
 ] 

ASF subversion and git services commented on CLOUDSTACK-10317:
--

Commit c0440e8124666fe7c642d8875870b7c09b65ce42 in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c0440e8 ]

CLOUDSTACK-10317: Fix SNAT rules for additional public nics (#2476)

* CLOUDSTACK-10317: Fix SNAT rules for additional public nics

This allows networks with additional public nics to have correct
SNAT iptables rules applied on configuration.

Signed-off-by: Rohit Yadav 

* update based on Wei's suggested change

Signed-off-by: Rohit Yadav 


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390941#comment-16390941
 ] 

ASF subversion and git services commented on CLOUDSTACK-10317:
--

Commit c0440e8124666fe7c642d8875870b7c09b65ce42 in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c0440e8 ]

CLOUDSTACK-10317: Fix SNAT rules for additional public nics (#2476)

* CLOUDSTACK-10317: Fix SNAT rules for additional public nics

This allows networks with additional public nics to have correct
SNAT iptables rules applied on configuration.

Signed-off-by: Rohit Yadav 

* update based on Wei's suggested change

Signed-off-by: Rohit Yadav 


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390939#comment-16390939
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

DaanHoogland closed pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py 
b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
index 42992b55123..dbafa1df555 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsAddress.py
@@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.cl.get_eth2_ip())])
 self.fw.append(["mangle", "",
 "-A PREROUTING -i %s -m state --state NEW " % 
self.dev +
 "-j CONNMARK --set-xmark %s/0x" % 
self.dnum])


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390940#comment-16390940
 ] 

ASF subversion and git services commented on CLOUDSTACK-10317:
--

Commit c0440e8124666fe7c642d8875870b7c09b65ce42 in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c0440e8 ]

CLOUDSTACK-10317: Fix SNAT rules for additional public nics (#2476)

* CLOUDSTACK-10317: Fix SNAT rules for additional public nics

This allows networks with additional public nics to have correct
SNAT iptables rules applied on configuration.

Signed-off-by: Rohit Yadav 

* update based on Wei's suggested change

Signed-off-by: Rohit Yadav 


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390392#comment-16390392
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rafaelweingartner commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules 
for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-371314177
 
 
   It seems that everything is ok here, can we proceed with the merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388753#comment-16388753
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370973833
 
 
   Trillian test result (tid-2324)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26230 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2476-t2324-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388267#comment-16388267
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370881992
 
 
   Trillian test result (tid-2317)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29943 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2476-t2317-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 186.17 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.75 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388028#comment-16388028
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370836797
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388026#comment-16388026
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370836631
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388016#comment-16388016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370833080
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1761


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387945#comment-16387945
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: 
Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172553658
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   You are right @ustcweizhou - just tested this. Routing happens *after SNAT* 
hence translating all non-static NATed traffic to the source IP address on eth2 
works even if this means a SNAT rule against eth3, eth4, etc.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387942#comment-16387942
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370818736
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387941#comment-16387941
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172553142
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Thanks all for your discussion and testing, I'll test @ustcweizhou 's fix 
now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387943#comment-16387943
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370818984
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387875#comment-16387875
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix 
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172535132
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   @DagSonsteboSB yes, I think the outgoing IP for the vms without static nat 
should be the source nat IP, in your example 10.100.1.10
   
   In my point of view, the rules applied on ethernet other than eth2 (for 
example eth3) are not needed at all, however it is not harmful to have them. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387836#comment-16387836
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

DagSonsteboSB commented on a change in pull request #2476: CLOUDSTACK-10317: 
Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172526560
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Hi @ustcweizhou - in your scenario - does this not mean you end up SNATing 
on the wrong interface? So lets say you have eth2/VLAN10/10.100.1.10/24 and 
eth3/VLAN20/10.100.2.20/24. With your method that would SNAT to
   
   - A POSTROUTING -o eth3 -j SNAT --to-source 10.100.1.10
   
   So in other words the IP address would be right for the initial source NAT, 
but it would end up being translated on the wrong interface?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387804#comment-16387804
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172520624
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Thanks for confirming that we indeed need to set the device/interface in the 
rule @ustcweizhou. I think it makes sense to have the default packets routed to 
the default public snat ip. I'll let others comment on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387649#comment-16387649
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix 
SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172464559
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   @rhtyd what we are using are
   ```
   diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   index e6aea26..d336e0a 100755
   --- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   +++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
   @@ -400,7 +400,7 @@ class CsIP:
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % 
self.address['public_ip']])
self.fw.append(["nat", "",
   -"-A POSTROUTING -o eth2 -j SNAT --to-source %s" 
% self.address['public_ip']])
   +"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.cl.get_eth2_ip())])
self.fw.append(["mangle", "",
"-A PREROUTING -i %s -m state --state NEW " % 
self.dev +
"-j CONNMARK --set-xmark %s/0x" % 
self.dnum])
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387532#comment-16387532
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370723713
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387531#comment-16387531
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370723519
 
 
   @blueorangutan test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387196#comment-16387196
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370646501
 
 
   Trillian test result (tid-2315)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35308 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2476-t2315-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.34 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 138.71 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386346#comment-16386346
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rafaelweingartner commented on a change in pull request #2476: 
CLOUDSTACK-10317: Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172254964
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Thanks for the explanation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386343#comment-16386343
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172254521
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Yes @rafaelweingartner, the logic is same what is being used in vpc routers, 
see - 
https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L584


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386344#comment-16386344
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT 
rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172254521
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   Yes @rafaelweingartner, the logic is same what as in vpc routers, see - 
https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L584


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386330#comment-16386330
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rafaelweingartner commented on a change in pull request #2476: 
CLOUDSTACK-10317: Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172252984
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##
 @@ -388,7 +388,7 @@ def fw_router(self):
 self.fw.append(["mangle", "",
 "-A VPN_%s -j RETURN" % self.address['public_ip']])
 self.fw.append(["nat", "",
-"-A POSTROUTING -o eth2 -j SNAT --to-source %s" % 
self.address['public_ip']])
+"-A POSTROUTING -o %s -j SNAT --to-source %s" % 
(self.dev, self.address['public_ip'])])
 
 Review comment:
   The attribute `self.dev` is already populated with the correct device name?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386328#comment-16386328
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370483999
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386326#comment-16386326
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370483846
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386320#comment-16386320
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370482352
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1753


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386273#comment-16386273
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

blueorangutan commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370468577
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386272#comment-16386272
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370468520
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Minor
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386271#comment-16386271
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370467906
 
 
   Same logic in vpc:
   
https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L584


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386268#comment-16386268
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional 
public nics
URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-370467906
 
 
   Same logic in vpc: 
https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L480


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386230#comment-16386230
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10317:
-

rhtyd opened a new pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for 
additional public nics
URL: https://github.com/apache/cloudstack/pull/2476
 
 
   This allows networks with additional public nics to have correct SNAT 
iptables rules applied on configuration.
   
   Pinging for review - @ustcweizhou @PaulAngus @DagSonstebo and others.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> In case of multiple-public ips, snat fails to work for addtional public 
> nics/network for guest traffic
> --
>
> Key: CLOUDSTACK-10317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10317
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> If a VR has two+ public nics, traffic from guest VM fails to be NAT-ed 
> correctly for traffic towards additional public nics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

[jira] [Commented] (CLOUDSTACK-10317) In case of multiple-public ips, snat fails to work for addtional public nics/network for guest traffic

34 matches

Site Navigation

Mail list logo

Footer information