[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689522#comment-15689522
 ] 

ASF subversion and git services commented on CLOUDSTACK-8781:
-

Commit e91b734638cc06b50d64ded3822753a20c83ba59 in cloudstack's branch 
refs/heads/master from [~nlivens]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e91b734 ]

CLOUDSTACK-8781 : Superfluous field during VPC creation


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689526#comment-15689526
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/756


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689523#comment-15689523
 ] 

ASF subversion and git services commented on CLOUDSTACK-8781:
-

Commit 9bec7032bea5a0a94978df95467fda5191528e91 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9bec703 ]

Merge pull request #756 from nlivens/CLOUDSTACK-8781

CLOUDSTACK-8781 : Superfluous field during VPC creation

* pr/756:
  CLOUDSTACK-8781 : Superfluous field during VPC creation

Signed-off-by: Rohit Yadav 


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689525#comment-15689525
 ] 

ASF subversion and git services commented on CLOUDSTACK-8781:
-

Commit 9bec7032bea5a0a94978df95467fda5191528e91 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9bec703 ]

Merge pull request #756 from nlivens/CLOUDSTACK-8781

CLOUDSTACK-8781 : Superfluous field during VPC creation

* pr/756:
  CLOUDSTACK-8781 : Superfluous field during VPC creation

Signed-off-by: Rohit Yadav 


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689511#comment-15689511
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
Thanks, merging this now.


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683768#comment-15683768
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
@rhtyd Here are the screen-shots without and with this UI bug fix:


![6a4ded44-adb4-4821-bceb-3eb8c44c79f8](https://cloud.githubusercontent.com/assets/3722369/20486648/d037587a-b000-11e6-9cda-f82e52747626.jpg)


![rsz_screenshot_from_2016-11-21_15-15-52](https://cloud.githubusercontent.com/assets/3722369/20486654/d65af0ae-b000-11e6-9201-d2df4e8bcd7f.jpg)

As pointed out by @nlivens in the previous comment, "The actual Public Load 
Balancer provider is derived from the VPC offering, and not from this extra 
field "Public Load Balancer Provider". So, this field has no use at all since 
it's completely ignored."

The cleaner implementation for this UI tab would be to only list "Public 
Load Balancer Providers" mentioned in the selected VPC offering. Moreover, 
don't show this tab, if there are no "Public Load Balancer Providers" being 
mentioned in the selected VPC offering. Finally, make use of the selected  
"Public Load Balancer Provider" in the actual implementation of the VPC.


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681204#comment-15681204
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
I'm not sure about the changes, but if the mentioned field is not consumed 
anywhere, it LGTM. Can we have a manual UI screenshot to confirm changes since 
this is a pure UI change?


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681154#comment-15681154
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user prashanthvarma commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
@rhtyd, rebased against latest master


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315684#comment-15315684
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user nlivens commented on the issue:

https://github.com/apache/cloudstack/pull/756
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 132
 Hypervisor xenserver
 NetworkType Advanced
 Passed=70
 Failed=1
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_service_offerings.py

 * ContextSuite context=TestServiceOfferings>:setup Failing since 7 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266435#comment-15266435
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/756#issuecomment-216208745
  
@rhtyd, rebased against latest master


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266328#comment-15266328
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/756#issuecomment-216187288
  
@nlivens please rebase against latest master and push -f

LGTM, the removed code (publicLoadBalancerProvider key) is not referenced 
in any of the actions or dataProviders to create and send the `data` payload

tag:easypr


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: Future
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736745#comment-14736745
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/756#issuecomment-138889654
  
Hi @nlivens 

Okay... I will have a look at the code. Very weird to have it there and not 
use it. :)

Cheers,
Wilder


> Superfluous field during VPC creation
> -
>
> Key: CLOUDSTACK-8781
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: UI
>Affects Versions: 4.6.0
>Reporter: Nick Livens
>Assignee: Nick Livens
>Priority: Trivial
> Fix For: 4.6.0
>
> Attachments: addVpc.png
>
>
> When creating a VPC, there is a superfluous field "Public Load Balancer 
> Provider" which is being ignored since the LB Provider is specified in the 
> VPC offering. This might confuse the users whether they can use a different 
> LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8781) Superfluous field during VPC creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716612#comment-14716612
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8781:


GitHub user nlivens opened a pull request:

https://github.com/apache/cloudstack/pull/756

CLOUDSTACK-8781 : Superfluous field during VPC creation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-8781

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #756


commit b1f1b63e28a09503f690fa504ed4861d7a518a67
Author: Nick Livens nick.liv...@nuagenetworks.net
Date:   2015-08-27T12:57:17Z

CLOUDSTACK-8781 : Superfluous field during VPC creation




 Superfluous field during VPC creation
 -

 Key: CLOUDSTACK-8781
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8781
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public(Anyone can view this level - this is the 
 default.) 
  Components: UI
Affects Versions: 4.6.0
Reporter: Nick Livens
Assignee: Nick Livens
Priority: Trivial
 Fix For: 4.6.0

 Attachments: addVpc.png


 When creating a VPC, there is a superfluous field Public Load Balancer 
 Provider which is being ignored since the LB Provider is specified in the 
 VPC offering. This might confuse the users whether they can use a different 
 LB provider than the one specified in the VPC offering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)