[jira] [Commented] (MATH-701) Seeding a default RNG
[
https://issues.apache.org/jira/browse/MATH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143706#comment-13143706
]
Phil Steitz commented on MATH-701:
--
+1 to changing the default in the RandomDataImpl to a Well generator
(documenting this)
+1 as well to trying to find a better default seed (documenting how it works).
Harmony still belongs to us, so we can certainly look at / imitate the impl
there.
The reason that the argumentless constructor exists is to allow users to accept
the default generator. The lazy initialization idiom was chosen because in some
cases, users may choose to invoke the setter instead of passing a generator as
a constructor argument. This is an older style no longer in use much in
[math]. I would be OK getting rid of this - i.e., having the argumentless
constructor take the hit to create a default instance.
-0 for separating out the secure stuff. RandomDataImpl is an aggregate class
that bundles a lot of commonly used random data generation methods. Just as
the random generator is pluggable, so is the secure random generator, which
makes the class convenient to use for applications that require both kinds of
random values. I think its simpler and more convenient to bundle things as
they are. Of course, I have been using this class for a long time, so I may
not be the best judge of what is simplest / easiest to use.
> Seeding a default RNG
> -
>
> Key: MATH-701
> URL: https://issues.apache.org/jira/browse/MATH-701
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles
>Assignee: Gilles
> Fix For: 3.0
>
>
> In "RandomDataImpl":
> {code}
> private RandomGenerator getRan() {
> if (rand == null) {
> rand = new JDKRandomGenerator();
> rand.setSeed(System.currentTimeMillis());
> }
> return rand;
> }
> {code}
> The conditional branch is used by "sample()" in
> "AbstractContinuousDistribution".
> When several "...Distribution" objects are instantiated in a short time
> interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143700#comment-13143700
]
Adrian Cumiskey commented on OGNL-35:
-
patch-OGNL35-v2.txt improves upon and replaces the original one.
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Cumiskey updated OGNL-35:
Attachment: patch-OGNL35-v2.txt
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Cumiskey updated OGNL-35:
Description:
* Flipped equals() everywhere where a variable is tested against a String
constant.
* ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod()
from getSourceSetter() and getSourceAccessor().
* ASTProperty: CPD fix, extracted shared method getSourceString() from
toGetSourceString() and toSetSourceString().
* ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
getSourceAccessor() and getSourceSetter().
was:
* Flipped equals() where variable is tested against String constant.
* CPD: Extracted getSourceBeanMethod() shared method from getSourceSetter() and
getSourceAccessor() in ListPropertyAccessor
Summary: [PATCH] Improvements to {List,Map,Array}PropertyAccessor and
ASTProperty (was: [PATCH] Improvements to {List,Map}PropertyAccessor)
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
>
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-701) Seeding a default RNG
[
https://issues.apache.org/jira/browse/MATH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143559#comment-13143559
]
Gilles commented on MATH-701:
-
IIRC we discarded the solution of passing a RNG in the distribution's
constructor because the "sample" methods was construed as syntactic sugar in
order to access the "RandomData" functionality from within the
"...Distribution" classes.
It was also argued that people who would use this API (instead of directly
instantiating a "RandomDataImpl" object) would be satisfied with a default RNG,
whatever was deemed the best choice by the CM developers. Thus, if another
generator is indeed better, we should just plug it in instead of the current
"JDKRandomGenerator".
In the same line of argument, the possibility of seeding was also supposed to
be given up in exchange for a "sample" API at the distribution level.
In "AbstractContinuousDistribution", we have:
{code}
protected final RandomDataImpl randomData = new RandomDataImpl();
{code}
In effect, there is no reason not to replace that statement with:
{code}
protected final RandomDataImpl randomData = new RandomDataImpl(new
Well44497a());
{code}
As as side note: I don't understand why there is a default constructor in
"RandomDataImpl"; since all the methods need a RNG, it does not make much sense
to allow the object to be constructed without one!
Second side note: Why not separate the "secure" alternatives into another
implementation? There would be "RandomData" (with a "nextHexString" method) and
a "SecureRandomData" (also with a "nextHexString" method, instead of the
current "nextSecureHexString").
Back to this report's issue: The parent class "AbstractWell" seems to suffer
from the same problem because the default constructor calls
{{System.currentTimeMillis()}}.
We should have a look at how "java.util.Random" seeds its default instances so
that they can claim (excerpt form Javadoc):
{noformat}
This constructor sets the seed of the random number generator to a value very
likely to be
distinct from any other invocation of this constructor.
{noformat}
> Seeding a default RNG
> -
>
> Key: MATH-701
> URL: https://issues.apache.org/jira/browse/MATH-701
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles
>Assignee: Gilles
> Fix For: 3.0
>
>
> In "RandomDataImpl":
> {code}
> private RandomGenerator getRan() {
> if (rand == null) {
> rand = new JDKRandomGenerator();
> rand.setSeed(System.currentTimeMillis());
> }
> return rand;
> }
> {code}
> The conditional branch is used by "sample()" in
> "AbstractContinuousDistribution".
> When several "...Distribution" objects are instantiated in a short time
> interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONFIGURATION-470) Extract classes generated by JavaCC
Extract classes generated by JavaCC --- Key: CONFIGURATION-470 URL: https://issues.apache.org/jira/browse/CONFIGURATION-470 Project: Commons Configuration Issue Type: Improvement Components: Build Affects Versions: 1.7 Reporter: Oliver Heger Priority: Minor In the plist package classes generated by JavaCC are used to parse specific configuration files. Currently these files are stored in SVN like regular source files. This does not conform to best practices, is confusing, and requires a special treatment in the configuration of tools like checkstyle or findbugs. It would be better to let these files be generated during the build process by the maven JavaCC plug-in. A working configuration can kindly be borrowed from the OGNL component. The additional generation step should not slow down the build significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated DAEMON-219: --- Attachment: Daemon-219.zip New version of the test zip which is a little cleaner and generates procrun logs in a logs folder in the project (included). > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: Daemon-219.zip, Daemon-219.zip, LdeServer3.reg, > NoKey.PNG, SystemLdeService3.txt, WER8D3F.tmp.WERInternalMetadata.xml, > WERA3BC.tmp.appcompat.txt, WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, > install-lde-service.cmd, ldeservice3-stderr.2011-10-03.log, > ldeservice3-stdout.2011-10-03.log, register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONFIGURATION-469) ConfigurationRuntimeException: Bean class is not specified!
[
https://issues.apache.org/jira/browse/CONFIGURATION-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143529#comment-13143529
]
Oliver Heger commented on CONFIGURATION-469:
Glad to hear that the problem seems to be solved. Can this ticket now be closed?
> ConfigurationRuntimeException: Bean class is not specified!
> ---
>
> Key: CONFIGURATION-469
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-469
> Project: Commons Configuration
> Issue Type: Bug
>Reporter: anvk
>
> I am getting the following error when I use commons configuration under
> JBoss. Standalone application is working fine.
> {code}
> Caused by: org.apache.commons.configuration.ConfigurationRuntimeException:
> org.apache.commons.configuration.ConfigurationRuntimeException:
> org.apache.commons.configuration.ConfigurationRuntimeException: Bean class is
> not specified!
> 11:18:51,642 ERROR [STDERR] at
> org.apache.commons.configuration.beanutils.BeanHelper.createBean(BeanHelper.java:250)
> 11:18:51,642 ERROR [STDERR] at
> org.apache.commons.configuration.beanutils.BeanHelper.createBean(BeanHelper.java:267)
> 11:18:51,642 ERROR [STDERR] at
> org.apache.commons.configuration.beanutils.BeanHelper.createBean(BeanHelper.java:281)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[
https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143527#comment-13143527
]
Gary D. Gregory commented on DAEMON-219:
This was in the Windows event log for the error:
{code:xml}
- http://schemas.microsoft.com/win/2004/08/events/event";>
-
1000
2
100
0x80
15806
Application
us-l-gg03.rocketsoftware.com
-
prunsrv.exe
1.0.7.0
4e3782fe
prunsrv.exe
1.0.7.0
4e3782fe
c005
a460
303c
01cc9a62a551a9ea
C:\Java\commons-daemon-1.0.7\win\amd64\prunsrv.exe
C:\Java\commons-daemon-1.0.7\win\amd64\prunsrv.exe
e3babb7d-0655-11e1-8b15-f0def14aec54
{code}
> prunsrv error 1067 and crash on Windows 7
> -
>
> Key: DAEMON-219
> URL: https://issues.apache.org/jira/browse/DAEMON-219
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.0.7
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_24\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Assignee: Mladen Turk
> Attachments: Daemon-219.zip, LdeServer3.reg, NoKey.PNG,
> SystemLdeService3.txt, WER8D3F.tmp.WERInternalMetadata.xml,
> WERA3BC.tmp.appcompat.txt, WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log,
> install-lde-service.cmd, ldeservice3-stderr.2011-10-03.log,
> ldeservice3-stdout.2011-10-03.log, register.cmd, unregister.cmd
>
>
> I've defined attached cmd file on Windows 7 to install a service.
> I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons
> Daemon Service Runner has stopped working"
> Attaching all details.
> Is there more debug logging I can turn on? The current debug output seems
> minimal.
> This is probably a configuration user error but I cannot tell due to the lack
> of logging.
> Thank you.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-195) "net stop serviceName" prints "Error 109: The pipe has been ended." Stopping via Windows Control Panel hangs.
[ https://issues.apache.org/jira/browse/DAEMON-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143511#comment-13143511 ] Mladen Turk commented on DAEMON-195: This will always happen if the stop method calls System.exit() There is no way to bypass that. On Tomcat you can use --StopMode java and it'll shutdown cleanly. Think we will need to make that as default (at least on Tomcat) > "net stop serviceName" prints "Error 109: The pipe has been ended." Stopping > via Windows Control Panel hangs. > - > > Key: DAEMON-195 > URL: https://issues.apache.org/jira/browse/DAEMON-195 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.5 > Environment: WinXP SP3 32-bit >Reporter: Konstantin Kolinko >Priority: Minor > > This issue was reported for Tomcat 7.0.6: > https://issues.apache.org/bugzilla/show_bug.cgi?id=50673 > To reproduce: > 1. Install apache-tomcat-7.0.6.exe I am installing with default options. I > am not starting Tomcat after installation. > 2. Launch the command prompt window. > 3. The following command succeeds: > net stop Tomcat7 > It prints two localized messages that can be translated as > The "Apache Tomcat 7" service is being started. > The "Apache Tomcat 7" service started successfully.p > 4. The following command apparently fails, but actually it succeeds: > net stop Tomcat7 > It prints two localized messages that are, citing from BZ 50673: > System error 109. > The pipe has been ended. > Note that "The service being stopped" message is not printed. > 5. Repeating the command shows that the service has been stopped: > net stop Tomcat7 > The "Apache Tomcat 7" service has not been started. > The commons-daemon..log contains only the following four lines when > stopping the service with Debug logging enabled: > [2011-01-27 20:18:59] [info] ( :0 ) Stopping service... > [2011-01-27 20:18:59] [debug] ( javajni.c:844 ) argv[0] = stop > [2011-01-27 20:18:59] [debug] ( javajni.c:891 ) Java Worker thread started > org/apache/catalina/startup/Bootstrap:main > [2011-01-27 20:19:00] [debug] ( prunsrv.c:871 ) Waiting for java jni stop > worker to finish... > Stopping the service with Stop button in prunmgr app succeeds without any > messages. > Stopping the service from the Services list in the Control Panel quickly goes > to 50% of progress but then continues to wait forever, without any changes on > the screen. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated DAEMON-219: --- Attachment: Daemon-219.zip Reproduces the issue. See readme.txt in the ZIP for instructions. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: Daemon-219.zip, LdeServer3.reg, NoKey.PNG, > SystemLdeService3.txt, WER8D3F.tmp.WERInternalMetadata.xml, > WERA3BC.tmp.appcompat.txt, WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, > install-lde-service.cmd, ldeservice3-stderr.2011-10-03.log, > ldeservice3-stdout.2011-10-03.log, register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-701) Seeding a default RNG
[
https://issues.apache.org/jira/browse/MATH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143322#comment-13143322
]
Phil Steitz commented on MATH-701:
--
I agree that there is a problem here; but I would solve it in
AbstractContinuousDistribution by passing a seeded generator to the
RandomDataImpl constructor. The code above is for the default case where no
generator has been supplied or set. For sampling, a Well generator would be a
better choice.
> Seeding a default RNG
> -
>
> Key: MATH-701
> URL: https://issues.apache.org/jira/browse/MATH-701
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles
>Assignee: Gilles
> Fix For: 3.0
>
>
> In "RandomDataImpl":
> {code}
> private RandomGenerator getRan() {
> if (rand == null) {
> rand = new JDKRandomGenerator();
> rand.setSeed(System.currentTimeMillis());
> }
> return rand;
> }
> {code}
> The conditional branch is used by "sample()" in
> "AbstractContinuousDistribution".
> When several "...Distribution" objects are instantiated in a short time
> interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DIGESTER-151) The org.apache.commons.digester3.binder.DigesterLoader doesn't allow binding a default org.xml.sax.ErrorHandler
[
https://issues.apache.org/jira/browse/DIGESTER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi resolved DIGESTER-151.
-
Resolution: Fixed
Fix Version/s: 3.2
Fixed on [r1197213|https://svn.apache.org/viewvc?view=revision&revision=1197213]
> The org.apache.commons.digester3.binder.DigesterLoader doesn't allow binding
> a default org.xml.sax.ErrorHandler
> ---
>
> Key: DIGESTER-151
> URL: https://issues.apache.org/jira/browse/DIGESTER-151
> Project: Commons Digester
> Issue Type: Bug
>Affects Versions: 3.2
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
> Fix For: 3.2
>
>
> a custom {{org.xml.sax.ErrorHandler}} can be set only to {{Digester}}
> instance and not to {{DigesterLoader}}.
> API has to be added to set a {{org.xml.sax.ErrorHandler}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-701) Seeding a default RNG
[
https://issues.apache.org/jira/browse/MATH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143300#comment-13143300
]
Gilles commented on MATH-701:
-
No, my point was that the seeding should just be removed: When several
distribution objects are instantiated, we usually don't want the samples to be
the same...
> Seeding a default RNG
> -
>
> Key: MATH-701
> URL: https://issues.apache.org/jira/browse/MATH-701
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles
>Assignee: Gilles
> Fix For: 3.0
>
>
> In "RandomDataImpl":
> {code}
> private RandomGenerator getRan() {
> if (rand == null) {
> rand = new JDKRandomGenerator();
> rand.setSeed(System.currentTimeMillis());
> }
> return rand;
> }
> {code}
> The conditional branch is used by "sample()" in
> "AbstractContinuousDistribution".
> When several "...Distribution" objects are instantiated in a short time
> interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-701) Seeding a default RNG
[
https://issues.apache.org/jira/browse/MATH-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143287#comment-13143287
]
Mikkel Meyer Andersen commented on MATH-701:
I see your point, but at the same time it might be difficult to deal with
correctly. One work-around is to use the serialVersionUID field together with
System.currentTimeMillis(), but I am not sure if that is a good idea nor how
well it can be implemented.
> Seeding a default RNG
> -
>
> Key: MATH-701
> URL: https://issues.apache.org/jira/browse/MATH-701
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles
>Assignee: Gilles
> Fix For: 3.0
>
>
> In "RandomDataImpl":
> {code}
> private RandomGenerator getRan() {
> if (rand == null) {
> rand = new JDKRandomGenerator();
> rand.setSeed(System.currentTimeMillis());
> }
> return rand;
> }
> {code}
> The conditional branch is used by "sample()" in
> "AbstractContinuousDistribution".
> When several "...Distribution" objects are instantiated in a short time
> interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
[
https://issues.apache.org/jira/browse/COLLECTIONS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Schaible reopened COLLECTIONS-386:
Assignee: Joerg Schaible
> CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
> --
>
> Key: COLLECTIONS-386
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 3.2.1
> Environment: commons-collections-3.2.1.jar
>Reporter: Steininger Thomas
>Assignee: Joerg Schaible
>Priority: Critical
> Fix For: 4.0, Nightly Builds
>
>
> public static Collection removeAll(Collection collection, Collection remove) {
> return ListUtils.retainAll(collection, remove);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
[
https://issues.apache.org/jira/browse/COLLECTIONS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Schaible closed COLLECTIONS-386.
--
Resolution: Duplicate
Fix Version/s: 4.0
Closed as Nth duplicate, otherwise we might have it multiple times in the
change log.
> CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
> --
>
> Key: COLLECTIONS-386
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 3.2.1
> Environment: commons-collections-3.2.1.jar
>Reporter: Steininger Thomas
>Assignee: Joerg Schaible
>Priority: Critical
> Fix For: 4.0, Nightly Builds
>
>
> public static Collection removeAll(Collection collection, Collection remove) {
> return ListUtils.retainAll(collection, remove);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
[
https://issues.apache.org/jira/browse/COLLECTIONS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved COLLECTIONS-386.
-
Resolution: Fixed
Already in SVN trunk.
> CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
> --
>
> Key: COLLECTIONS-386
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 3.2.1
> Environment: commons-collections-3.2.1.jar
>Reporter: Steininger Thomas
>Priority: Critical
> Fix For: Nightly Builds
>
>
> public static Collection removeAll(Collection collection, Collection remove) {
> return ListUtils.retainAll(collection, remove);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
[
https://issues.apache.org/jira/browse/COLLECTIONS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated COLLECTIONS-386:
Affects Version/s: 3.2.1
Fix Version/s: Nightly Builds
> CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
> --
>
> Key: COLLECTIONS-386
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 3.2.1
> Environment: commons-collections-3.2.1.jar
>Reporter: Steininger Thomas
>Priority: Critical
> Fix For: Nightly Builds
>
>
> public static Collection removeAll(Collection collection, Collection remove) {
> return ListUtils.retainAll(collection, remove);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
[
https://issues.apache.org/jira/browse/COLLECTIONS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143186#comment-13143186
]
Gary D. Gregory commented on COLLECTIONS-386:
-
This is already fixed in trunk.
> CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
> --
>
> Key: COLLECTIONS-386
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
> Project: Commons Collections
> Issue Type: Bug
> Environment: commons-collections-3.2.1.jar
>Reporter: Steininger Thomas
>Priority: Critical
>
> public static Collection removeAll(Collection collection, Collection remove) {
> return ListUtils.retainAll(collection, remove);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (COLLECTIONS-386) CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
CollectionUtils.removeAll(Collection, Collection) has an CopyPaste-Failure
--
Key: COLLECTIONS-386
URL: https://issues.apache.org/jira/browse/COLLECTIONS-386
Project: Commons Collections
Issue Type: Bug
Environment: commons-collections-3.2.1.jar
Reporter: Steininger Thomas
Priority: Critical
public static Collection removeAll(Collection collection, Collection remove) {
return ListUtils.retainAll(collection, remove);
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-380) FTP connect.error message used instead of SFTP connect.error message
[
https://issues.apache.org/jira/browse/VFS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-380.
-
Resolution: Fixed
Committed revision 1197120.
> FTP connect.error message used instead of SFTP connect.error message
>
>
> Key: VFS-380
> URL: https://issues.apache.org/jira/browse/VFS-380
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_29\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
> Fix For: Nightly Builds
>
>
> If connecting to SFTP fails, the code uses the message key
> {{vfs.provider.ftp/connect.error}} but the resource file defines the SFTP
> specific message {{vfs.provider.sftp/connect.error}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VFS-380) FTP connect.error message used instead of SFTP connect.error message
[
https://issues.apache.org/jira/browse/VFS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated VFS-380:
Summary: FTP connect.error message used instead of SFTP connect.error
message (was: FTP messages used instead of SFTP messages )
> FTP connect.error message used instead of SFTP connect.error message
>
>
> Key: VFS-380
> URL: https://issues.apache.org/jira/browse/VFS-380
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.0
> Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_29\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Assignee: Gary D. Gregory
> Fix For: Nightly Builds
>
>
> If connecting to SFTP fails, the code uses the message key
> {{vfs.provider.ftp/connect.error}} but the resource file defines the SFTP
> specific message {{vfs.provider.sftp/connect.error}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (VFS-380) FTP messages used instead of SFTP messages
FTP messages used instead of SFTP messages
---
Key: VFS-380
URL: https://issues.apache.org/jira/browse/VFS-380
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
If connecting to SFTP fails, the code uses the message key
{{vfs.provider.ftp/connect.error}} but the resource file defines the SFTP
specific message {{vfs.provider.sftp/connect.error}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JEXL-121) Add simple template features
[ https://issues.apache.org/jira/browse/JEXL-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-121. Resolution: Fixed > Add simple template features > > > Key: JEXL-121 > URL: https://issues.apache.org/jira/browse/JEXL-121 > Project: Commons JEXL > Issue Type: Improvement >Reporter: Henri Biestro >Assignee: Henri Biestro > Fix For: 2.1 > > > UnifiedJEXL already allows some form of template but can't be used if loops > or complex conditionals are required. > By allowing a mix of code (directives) and UJEXL expressions in the same > source and pre-processing it to generate a JEXL script, JEXL will gain simple > template abilities. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-218) CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when installed into the file path containing non-ascii character
[ https://issues.apache.org/jira/browse/DAEMON-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143167#comment-13143167 ] Mladen Turk commented on DAEMON-218: Seems I'm the one that forgot the agreement. Sorry for the noise. Cheers -- ^TM > CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when > installed into the file path containing non-ascii character > -- > > Key: DAEMON-218 > URL: https://issues.apache.org/jira/browse/DAEMON-218 > Project: Commons Daemon > Issue Type: Bug >Affects Versions: 1.0.7 >Reporter: Alexey Grishkov >Assignee: Mladen Turk > Fix For: 1.0.8 > > Attachments: prunsrv.c, utils.c > > > Tomcat Service can not be started if Tomcat was installed into the path, > containing non-ASCII (e.g. Japanese or Chinese) symbols. > The problem is apparently due to the improper treatment of non-ascii > characters in the "Java classpath" section of the Service settings. > In tomcat5w.exe GUI or windows registry I could see proper PATH, namely > C:\[ONE CHINESE HIEROGLIPH]\Tomcat 5.5\bin\bootstrap.jar > Unfortunately, service doesn't get started with the following log: > [2006-09-15 18:29:17] [457 javajni.c] [error] FindClass > org/apache/catalina/startup/Bootstrap failed > [2006-09-15 18:29:17] [935 prunsrv.c] [error] Failed loading main > org/apache/catalina/startup/Bootstrap class C:\ss\Tomcat 5.5\bin\bootstrap.jar > [2006-09-15 18:29:17] [1179 prunsrv.c] [error] ServiceStart returned 3 > where the non-ascii symbol gets replaced with improper ascii 'ss' sequence. > Moreover, I tried to define environmental variables PR_CLASSPATH and > PR_STARTPATH instead of using corresponding service params. The result is > exactly the same. > Please, suggest me the workaround to make Tomcat service run. > P.S. The problem is stable either under JRE 1.5.0_02 or 1.4.2_10 (within > tomcat compatibility package). The problem exist apparently under all OS (in > particular, it was detected on Windows 2000 and Windows XP Pro 2002 SP2 > either > Chinese version or standard English with Chinese System locale installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143159#comment-13143159 ] Gary D. Gregory commented on DAEMON-219: Ok, I'll put something together. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143145#comment-13143145 ] Mladen Turk commented on DAEMON-219: Sure, I mean any class would do which causes the core on your box. You can name it the same, but it can have some dummy methods just to cause procrun to break > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MATH-701) Seeding a default RNG
Seeding a default RNG
-
Key: MATH-701
URL: https://issues.apache.org/jira/browse/MATH-701
Project: Commons Math
Issue Type: Bug
Reporter: Gilles
Assignee: Gilles
Fix For: 3.0
In "RandomDataImpl":
{code}
private RandomGenerator getRan() {
if (rand == null) {
rand = new JDKRandomGenerator();
rand.setSeed(System.currentTimeMillis());
}
return rand;
}
{code}
The conditional branch is used by "sample()" in
"AbstractContinuousDistribution".
When several "...Distribution" objects are instantiated in a short time
interval, they are seeded with the same value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DIGESTER-153) Add Constructor support to ObjectCreateRule
Add Constructor support to ObjectCreateRule --- Key: DIGESTER-153 URL: https://issues.apache.org/jira/browse/DIGESTER-153 Project: Commons Digester Issue Type: Improvement Affects Versions: 3.2 Reporter: Simone Tripodi Assignee: Simone Tripodi Fix For: 3.2 As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2] for fully support the Constructors - it basically cannot use elements in the body as constructor arguments - but it could support arguments extracted from attributes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143114#comment-13143114 ] Gary D. Gregory commented on DAEMON-219: Unfortunately, I cannot provide com.seagullsw.appinterface.server.AppInterfaceServer because it is at the core of our proprietary product. It also depends on 60 megs of jars and has a complex configuration. If you describe what you need, I can create something. Is testing with a stub class that does only the sleep help? That would be one .class file, or a jar with one class file. I would hope that such a class would just work and that the problem is somewhere in between the simple and complex example. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-218) CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when installed into the file path containing non-ascii character
[ https://issues.apache.org/jira/browse/DAEMON-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143101#comment-13143101 ] Sebb commented on DAEMON-218: - My recollection was that: "Affects versions" is used to document the versions to which the issue applies. "Fix version" means the first version containing the fix, i.e. the fixed version. For new features it then corresponds to the @since tag (if used). Otherwise, there is little point in having the field. AUIU that is how all the other Commons components use the field. It's also useful to be able to extract all the "Fix Version" = 1.0.8 to see what was fixed in 1.0.8; that should agree with the release notes. > CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when > installed into the file path containing non-ascii character > -- > > Key: DAEMON-218 > URL: https://issues.apache.org/jira/browse/DAEMON-218 > Project: Commons Daemon > Issue Type: Bug >Affects Versions: 1.0.7 >Reporter: Alexey Grishkov >Assignee: Mladen Turk > Fix For: 1.0.8 > > Attachments: prunsrv.c, utils.c > > > Tomcat Service can not be started if Tomcat was installed into the path, > containing non-ASCII (e.g. Japanese or Chinese) symbols. > The problem is apparently due to the improper treatment of non-ascii > characters in the "Java classpath" section of the Service settings. > In tomcat5w.exe GUI or windows registry I could see proper PATH, namely > C:\[ONE CHINESE HIEROGLIPH]\Tomcat 5.5\bin\bootstrap.jar > Unfortunately, service doesn't get started with the following log: > [2006-09-15 18:29:17] [457 javajni.c] [error] FindClass > org/apache/catalina/startup/Bootstrap failed > [2006-09-15 18:29:17] [935 prunsrv.c] [error] Failed loading main > org/apache/catalina/startup/Bootstrap class C:\ss\Tomcat 5.5\bin\bootstrap.jar > [2006-09-15 18:29:17] [1179 prunsrv.c] [error] ServiceStart returned 3 > where the non-ascii symbol gets replaced with improper ascii 'ss' sequence. > Moreover, I tried to define environmental variables PR_CLASSPATH and > PR_STARTPATH instead of using corresponding service params. The result is > exactly the same. > Please, suggest me the workaround to make Tomcat service run. > P.S. The problem is stable either under JRE 1.5.0_02 or 1.4.2_10 (within > tomcat compatibility package). The problem exist apparently under all OS (in > particular, it was detected on Windows 2000 and Windows XP Pro 2002 SP2 > either > Chinese version or standard English with Chinese System locale installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143081#comment-13143081 ] Mladen Turk commented on DAEMON-219: OK, so it seems the registry is there after all ;). The bug is not in the configuration stage. Is there any option for you to provide those classes with some dummy executor so I can debug the procrun? I see you are executing your com.seagullsw.appinterface.server.AppInterfaceServer so if you can just provide that class with some sleep(1000) instead actual run that should do. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-218) CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when installed into the file path containing non-ascii character
[ https://issues.apache.org/jira/browse/DAEMON-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143077#comment-13143077 ] Mladen Turk commented on DAEMON-218: Didn't we agree that the Fix Version/s should reflect the version fixed? We had that discussion couple of months back and the Fix Version/s means: Version fixed not version containing the fix! You were even contacting and opened upstream JIRA ticket for that. So please stop editing those properties, and revert the changes. Regards -- ^TM > CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when > installed into the file path containing non-ascii character > -- > > Key: DAEMON-218 > URL: https://issues.apache.org/jira/browse/DAEMON-218 > Project: Commons Daemon > Issue Type: Bug >Affects Versions: 1.0.7 >Reporter: Alexey Grishkov >Assignee: Mladen Turk > Fix For: 1.0.8 > > Attachments: prunsrv.c, utils.c > > > Tomcat Service can not be started if Tomcat was installed into the path, > containing non-ASCII (e.g. Japanese or Chinese) symbols. > The problem is apparently due to the improper treatment of non-ascii > characters in the "Java classpath" section of the Service settings. > In tomcat5w.exe GUI or windows registry I could see proper PATH, namely > C:\[ONE CHINESE HIEROGLIPH]\Tomcat 5.5\bin\bootstrap.jar > Unfortunately, service doesn't get started with the following log: > [2006-09-15 18:29:17] [457 javajni.c] [error] FindClass > org/apache/catalina/startup/Bootstrap failed > [2006-09-15 18:29:17] [935 prunsrv.c] [error] Failed loading main > org/apache/catalina/startup/Bootstrap class C:\ss\Tomcat 5.5\bin\bootstrap.jar > [2006-09-15 18:29:17] [1179 prunsrv.c] [error] ServiceStart returned 3 > where the non-ascii symbol gets replaced with improper ascii 'ss' sequence. > Moreover, I tried to define environmental variables PR_CLASSPATH and > PR_STARTPATH instead of using corresponding service params. The result is > exactly the same. > Please, suggest me the workaround to make Tomcat service run. > P.S. The problem is stable either under JRE 1.5.0_02 or 1.4.2_10 (within > tomcat compatibility package). The problem exist apparently under all OS (in > particular, it was detected on Windows 2000 and Windows XP Pro 2002 SP2 > either > Chinese version or standard English with Chinese System locale installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143061#comment-13143061 ] Gary D. Gregory commented on DAEMON-219: I just attached a regedit export for the requested key. I also attached cmd files that register and unregister the service. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated DAEMON-219: --- Attachment: unregister.cmd register.cmd LdeServer3.reg Regedit export and cmd files. > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: LdeServer3.reg, NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log, > register.cmd, unregister.cmd > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143051#comment-13143051 ] Adrian Cumiskey commented on OGNL-37: - Its actually worse, the reason ConcurrentModificationException never happened in the previous revision was because the map.remove( value ) operation always requires a key of type String to have a possibility to remove the Entry. It was completely redundant code that would never have possibilty to mutate the map. Thanks again for the swift processing of my patch. > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-218) CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when installed into the file path containing non-ascii character
[ https://issues.apache.org/jira/browse/DAEMON-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated DAEMON-218: Affects Version/s: 1.0.7 Fix Version/s: (was: 1.0.7) 1.0.8 > CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when > installed into the file path containing non-ascii character > -- > > Key: DAEMON-218 > URL: https://issues.apache.org/jira/browse/DAEMON-218 > Project: Commons Daemon > Issue Type: Bug >Affects Versions: 1.0.7 >Reporter: Alexey Grishkov >Assignee: Mladen Turk > Fix For: 1.0.8 > > Attachments: prunsrv.c, utils.c > > > Tomcat Service can not be started if Tomcat was installed into the path, > containing non-ASCII (e.g. Japanese or Chinese) symbols. > The problem is apparently due to the improper treatment of non-ascii > characters in the "Java classpath" section of the Service settings. > In tomcat5w.exe GUI or windows registry I could see proper PATH, namely > C:\[ONE CHINESE HIEROGLIPH]\Tomcat 5.5\bin\bootstrap.jar > Unfortunately, service doesn't get started with the following log: > [2006-09-15 18:29:17] [457 javajni.c] [error] FindClass > org/apache/catalina/startup/Bootstrap failed > [2006-09-15 18:29:17] [935 prunsrv.c] [error] Failed loading main > org/apache/catalina/startup/Bootstrap class C:\ss\Tomcat 5.5\bin\bootstrap.jar > [2006-09-15 18:29:17] [1179 prunsrv.c] [error] ServiceStart returned 3 > where the non-ascii symbol gets replaced with improper ascii 'ss' sequence. > Moreover, I tried to define environmental variables PR_CLASSPATH and > PR_STARTPATH instead of using corresponding service params. The result is > exactly the same. > Please, suggest me the workaround to make Tomcat service run. > P.S. The problem is stable either under JRE 1.5.0_02 or 1.4.2_10 (within > tomcat compatibility package). The problem exist apparently under all OS (in > particular, it was detected on Windows 2000 and Windows XP Pro 2002 SP2 > either > Chinese version or standard English with Chinese System locale installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-215) Cannot set local username and password for a Win32 service
[ https://issues.apache.org/jira/browse/DAEMON-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated DAEMON-215: Fix Version/s: (was: 1.0.7) 1.0.8 > Cannot set local username and password for a Win32 service > -- > > Key: DAEMON-215 > URL: https://issues.apache.org/jira/browse/DAEMON-215 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: win32 / server 2003 >Reporter: wessels >Assignee: Mladen Turk >Priority: Minor > Fix For: 1.0.8 > > Original Estimate: 24h > Remaining Estimate: 24h > > installing a new service without supplying the --ServiceUser > --ServicePassword installs the service correctly but using the LocalSystem > account. If you want to use a local user, which of course has at least the > "log on as a service" right, and supply the credentials via the parameters > you get an error. To be more specific, in service.c line 211, the > CHANGE_SERVICE macro fails with error 87L ERROR_INVALID_PARAMETER. This > happens at least when creating and updating a service. Setting other options > via this macro work fine, just the username password fail (standalone and in > combination with other parameters). > The solution is specifying SERVICE_WIN32_OWN_PROCESS as ServiceType parameter > instead of SERVICE_NO_CHANGE in ChangeServiceConfigW line 27 second parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143034#comment-13143034 ] Hudson commented on OGNL-37: Integrated in ognl #182 (See [https://builds.apache.org/job/ognl/182/]) OGNL-37 - Avoid concurrentModificationException mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197043 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[
https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143023#comment-13143023
]
Maurizio Cucchiara commented on OGNL-37:
Ignore my last message, I have almost forgotten about
{{ConcurrentModificationException}}
> [PATCH] Findbugs fixes
> --
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Assignee: Maurizio Cucchiara
>Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode()
> implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key
> (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of
> super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet
> for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary
> conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[
https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143018#comment-13143018
]
Maurizio Cucchiara commented on OGNL-37:
Once again, thank you Adrian.
I applied your patch with a little exception:
what was
{quote}
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys
are always of type String).
{quote}
has become
{quote}
ExpressionCompiler: Corrected attempt to remove LocalReference (keys was always
of type String).
{quote}
In fact that was the original behavior of ExpressionCompiler (see at row
[699|http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java?r1=1187867&r2=1197034&pathrev=1197034&diff_format=h]).
Don't you agree?
> [PATCH] Findbugs fixes
> --
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
>Reporter: Adrian Cumiskey
>Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode()
> implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key
> (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of
> super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet
> for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary
> conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maurizio Cucchiara resolved OGNL-37. Resolution: Fixed Assignee: Maurizio Cucchiara > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Assignee: Maurizio Cucchiara >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143012#comment-13143012 ] Hudson commented on OGNL-37: Integrated in ognl #181 (See [https://builds.apache.org/job/ognl/181/]) OGNL-37 - Corrected attempt to remove LocalReference (keys was always of type String). OGNL-37 - Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements. OGNL-37 - use valueOf() instead of new for boxing. Adjust unnecessary conditional checking. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197034 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197024 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197020 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlOps.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-219) prunsrv error 1067 and crash on Windows 7
[ https://issues.apache.org/jira/browse/DAEMON-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143007#comment-13143007 ] Mladen Turk commented on DAEMON-219: It would be really helpful if you could attach the registry data for the service. Note that it should be inside HKLM\Software\Wow6432Node\Apache Software Foundation\Procrun 2.0\LdeService3 > prunsrv error 1067 and crash on Windows 7 > - > > Key: DAEMON-219 > URL: https://issues.apache.org/jira/browse/DAEMON-219 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: C:\Java\apache-maven-3.0.3\bin\.. > Java version: 1.6.0_24, vendor: Sun Microsystems Inc. > Java home: C:\Program Files\Java\jdk1.6.0_24\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >Reporter: Gary D. Gregory >Assignee: Mladen Turk > Attachments: NoKey.PNG, SystemLdeService3.txt, > WER8D3F.tmp.WERInternalMetadata.xml, WERA3BC.tmp.appcompat.txt, > WERA3BD.tmp.mdmp, commons-daemon.2011-10-03.log, install-lde-service.cmd, > ldeservice3-stderr.2011-10-03.log, ldeservice3-stdout.2011-10-03.log > > > I've defined attached cmd file on Windows 7 to install a service. > I try to run the service with "prunsrv //TS/LdeService3" and I get "Commons > Daemon Service Runner has stopped working" > Attaching all details. > Is there more debug logging I can turn on? The current debug output seems > minimal. > This is probably a configuration user error but I cannot tell due to the lack > of logging. > Thank you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DIGESTER-152) The org.apache.commons.digester3.binder.DigesterLoader doesn't allow binding a default org.xml.sax.Locator
The org.apache.commons.digester3.binder.DigesterLoader doesn't allow binding a
default org.xml.sax.Locator
--
Key: DIGESTER-152
URL: https://issues.apache.org/jira/browse/DIGESTER-152
Project: Commons Digester
Issue Type: Bug
Affects Versions: 3.2
Reporter: Simone Tripodi
Assignee: Simone Tripodi
Fix For: 3.2
In {{org.apache.commons.digester3.binder.DigesterLoader}} there's no API to set
a default {{org.xml.sax.Locator}} to produced Digester instances
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DAEMON-215) Cannot set local username and password for a Win32 service
[ https://issues.apache.org/jira/browse/DAEMON-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mladen Turk resolved DAEMON-215. Resolution: Fixed Fix Version/s: 1.0.7 Fixed in the trunk by making sure the option is passes when setting username/password > Cannot set local username and password for a Win32 service > -- > > Key: DAEMON-215 > URL: https://issues.apache.org/jira/browse/DAEMON-215 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.0.7 > Environment: win32 / server 2003 >Reporter: wessels >Assignee: Mladen Turk >Priority: Minor > Fix For: 1.0.7 > > Original Estimate: 24h > Remaining Estimate: 24h > > installing a new service without supplying the --ServiceUser > --ServicePassword installs the service correctly but using the LocalSystem > account. If you want to use a local user, which of course has at least the > "log on as a service" right, and supply the credentials via the parameters > you get an error. To be more specific, in service.c line 211, the > CHANGE_SERVICE macro fails with error 87L ERROR_INVALID_PARAMETER. This > happens at least when creating and updating a service. Setting other options > via this macro work fine, just the username password fail (standalone and in > combination with other parameters). > The solution is specifying SERVICE_WIN32_OWN_PROCESS as ServiceType parameter > instead of SERVICE_NO_CHANGE in ChangeServiceConfigW line 27 second parameter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142990#comment-13142990 ] Hudson commented on OGNL-37: Integrated in ognl #180 (See [https://builds.apache.org/job/ognl/180/]) OGNL-37 - Provide equals() and hashcode() implementation to override PropertyDescriptor. OGNL-37 - Use StringBuilder instead of String concatenation with '+'. OGNL-37 - Use StringBuilder instead of String concatenation with '+'. OGNL-37 - Replaced for loops with foreach version. OGNL-37 - Remove int boxing, lets rely on autoboxing. OGNL-37 - Remove unnecessary int boxing and redundant code. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197018 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectIndexedPropertyDescriptor.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197015 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197014 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197011 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197009 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197007 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DAEMON-218) CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when installed into the file path containing non-ascii character
[ https://issues.apache.org/jira/browse/DAEMON-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mladen Turk resolved DAEMON-218. Resolution: Fixed Fix Version/s: 1.0.7 Fixed by using the Wide -> ANSI conversion instead Wide -> UTF8. > CLONE - procrun as tomcat5.exe from Tomcat 5.5.17 does not start, when > installed into the file path containing non-ascii character > -- > > Key: DAEMON-218 > URL: https://issues.apache.org/jira/browse/DAEMON-218 > Project: Commons Daemon > Issue Type: Bug >Reporter: Alexey Grishkov >Assignee: Mladen Turk > Fix For: 1.0.7 > > Attachments: prunsrv.c, utils.c > > > Tomcat Service can not be started if Tomcat was installed into the path, > containing non-ASCII (e.g. Japanese or Chinese) symbols. > The problem is apparently due to the improper treatment of non-ascii > characters in the "Java classpath" section of the Service settings. > In tomcat5w.exe GUI or windows registry I could see proper PATH, namely > C:\[ONE CHINESE HIEROGLIPH]\Tomcat 5.5\bin\bootstrap.jar > Unfortunately, service doesn't get started with the following log: > [2006-09-15 18:29:17] [457 javajni.c] [error] FindClass > org/apache/catalina/startup/Bootstrap failed > [2006-09-15 18:29:17] [935 prunsrv.c] [error] Failed loading main > org/apache/catalina/startup/Bootstrap class C:\ss\Tomcat 5.5\bin\bootstrap.jar > [2006-09-15 18:29:17] [1179 prunsrv.c] [error] ServiceStart returned 3 > where the non-ascii symbol gets replaced with improper ascii 'ss' sequence. > Moreover, I tried to define environmental variables PR_CLASSPATH and > PR_STARTPATH instead of using corresponding service params. The result is > exactly the same. > Please, suggest me the workaround to make Tomcat service run. > P.S. The problem is stable either under JRE 1.5.0_02 or 1.4.2_10 (within > tomcat compatibility package). The problem exist apparently under all OS (in > particular, it was detected on Windows 2000 and Windows XP Pro 2002 SP2 > either > Chinese version or standard English with Chinese System locale installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
[ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142969#comment-13142969 ] Hudson commented on OGNL-37: Integrated in ognl #179 (See [https://builds.apache.org/job/ognl/179/]) OGNL-37 - Modified equals() implementation to take account of super class fields. OGNL-37 - Use Map.entrySet instead of Map.keySet for better performance. mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197002 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1196996 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java > [PATCH] Findbugs fixes > -- > > Key: OGNL-37 > URL: https://issues.apache.org/jira/browse/OGNL-37 > Project: OGNL > Issue Type: Improvement >Reporter: Adrian Cumiskey >Priority: Minor > Attachments: patch-OGNL37.txt > > > ExpressionNode: Use StringBuilder instead of String concatenation with '+'. > ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() > implementation to override PropertyDescriptor. > ExpressionCompiler: Remove redundant attempt to remove LocalReference key > (keys are always of type String). > ASTMethod: Use StringBuilder instead of String concatenation with '+'. > DeclaredMethodCacheEntry: Modified equals() implementation to take account of > super class fields. > OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet > for better performance. Javadoc improvements. > ASTChain: Remove int boxing, lets rely on autoboxing. > ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. > OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary > conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
