[jira] [Commented] (GEOMETRY-25) Class "Geometry"

2019-02-09 Thread Matt Juntunen (JIRA)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764293#comment-16764293
 ] 

Matt Juntunen commented on GEOMETRY-25:
---

These constants are used quite a bit in commons-geometry and I generally find 
myself writing them frequently when I'm working in other codebases. You don't 
think they should be exposed to users?

> Class "Geometry"
> 
>
> Key: GEOMETRY-25
> URL: https://issues.apache.org/jira/browse/GEOMETRY-25
> Project: Apache Commons Geometry
>  Issue Type: Task
>  Components: core
>Reporter: Gilles
>Priority: Major
> Fix For: 1.0
>
>
> Class only holds trivial constants.
> Better move to an "internal" package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEOMETRY-42) Vector2D signedArea() Method

2019-02-09 Thread Matt Juntunen (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEOMETRY-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Juntunen updated GEOMETRY-42:
--
Description: 
We should add the following method to {{Vector2D}}:
{code:java}
public double signedArea(Vector2D v) { /* */ }
{code}
This method will return the signed area of the parallelogram formed by taking 
the current instance and the given vector as sides.

This method should replace the existing {{cross}} method in {{Vector2D}} since 
it performs a similar operation and the cross product is not defined in 2 
dimensions.

 

Pull request: [https://github.com/apache/commons-geometry/pull/26]

 

  was:
We should add the following method to {{Vector2D}}:
{code:java}
public double signedArea(Vector2D v) { /* */ }
{code}
This method will return the signed area of the parallelogram formed by taking 
the current instance and the given vector as sides.

This method should replace the existing {{cross}} method in {{Vector2D}} since 
it performs a similar operation and the cross product is not defined in 2 
dimensions.


> Vector2D signedArea() Method
> 
>
> Key: GEOMETRY-42
> URL: https://issues.apache.org/jira/browse/GEOMETRY-42
> Project: Apache Commons Geometry
>  Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We should add the following method to {{Vector2D}}:
> {code:java}
> public double signedArea(Vector2D v) { /* */ }
> {code}
> This method will return the signed area of the parallelogram formed by taking 
> the current instance and the given vector as sides.
> This method should replace the existing {{cross}} method in {{Vector2D}} 
> since it performs a similar operation and the cross product is not defined in 
> 2 dimensions.
>  
> Pull request: [https://github.com/apache/commons-geometry/pull/26]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEOMETRY-42) Vector2D signedArea() Method

2019-02-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEOMETRY-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEOMETRY-42:
---
Labels: pull-request-available  (was: )

> Vector2D signedArea() Method
> 
>
> Key: GEOMETRY-42
> URL: https://issues.apache.org/jira/browse/GEOMETRY-42
> Project: Apache Commons Geometry
>  Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Major
>  Labels: pull-request-available
>
> We should add the following method to {{Vector2D}}:
> {code:java}
> public double signedArea(Vector2D v) { /* */ }
> {code}
> This method will return the signed area of the parallelogram formed by taking 
> the current instance and the given vector as sides.
> This method should replace the existing {{cross}} method in {{Vector2D}} 
> since it performs a similar operation and the cross product is not defined in 
> 2 dimensions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEOMETRY-40) Replace commons-rng with commons-geometry on developers guide

2019-02-09 Thread Matt Juntunen (JIRA)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764292#comment-16764292
 ] 

Matt Juntunen commented on GEOMETRY-40:
---

[~erans], where are these urls specified?

> Replace commons-rng with commons-geometry on developers guide
> -
>
> Key: GEOMETRY-40
> URL: https://issues.apache.org/jira/browse/GEOMETRY-40
> Project: Apache Commons Geometry
>  Issue Type: Task
>Reporter: Sven Rathgeber
>Priority: Major
>
> On the developer page:
> [https://commons.apache.org/proper/commons-geometry/developers.html]
> are several references to commons-rng.
>  * [http://gitbox.apache.org/repos/asf/commons-rng.git]
>  * [https://apach...@gitbox.apache.org/repos/asf/commons-rng.git]
>  * [ Geometry Wish List Wiki Page.|http://wiki.apache.org/commons/RngWishList]
>  * [ Commons Geometry Issue Tracking 
> Page|http://commons.apache.org/rng/issue-tracking.html]
> They should be replace with references to commons-geometry.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEOMETRY-44) Enable Coveralls Reporting

2019-02-09 Thread Matt Juntunen (JIRA)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764290#comment-16764290
 ] 

Matt Juntunen commented on GEOMETRY-44:
---

Done: INFRA-17828

> Enable Coveralls Reporting
> --
>
> Key: GEOMETRY-44
> URL: https://issues.apache.org/jira/browse/GEOMETRY-44
> Project: Apache Commons Geometry
>  Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Minor
>
> We should enable the coveralls code coverage reporting in Github, like 
> commons-numbers has. I compared commons-geometry's configuration to that of 
> commons-numbers and didn't see any differences. Perhaps this is an infra 
> issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (COLLECTIONS-551) Move Iterable related methods from CollectionUtils to IterableUtils

2019-02-09 Thread Gary Gregory (JIRA)


 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated COLLECTIONS-551:
-
Fix Version/s: (was: 4.3)
   4.3.1

> Move Iterable related methods from CollectionUtils to IterableUtils
> ---
>
> Key: COLLECTIONS-551
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-551
> Project: Commons Collections
>  Issue Type: Improvement
>Affects Versions: 4.0
>Reporter: Thomas Neidhart
>Priority: Major
> Fix For: 5.0, 4.3.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (COLLECTIONS-710) NullPointerExceptions in CompositeCollection, CompositeSet, and CompositeMap

2019-02-09 Thread Gary Gregory (JIRA)


 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved COLLECTIONS-710.
--
   Resolution: Fixed
Fix Version/s: 4.3.1

[~sychelsea],

Thank you for your report.

Fixes are in git master. Please verify and close. If there are still problems, 
please provide a PR on GitHub.

Gary

> NullPointerExceptions in CompositeCollection, CompositeSet, and CompositeMap
> 
>
> Key: COLLECTIONS-710
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-710
> Project: Commons Collections
>  Issue Type: Bug
>  Components: Collection, Map, Set
>Affects Versions: 4.2
> Environment: Windows 10
> Eclipse IDE for Java Developers     Version: 2018-09 (4.9.0)
>Reporter: Yu Shi
>Priority: Major
>  Labels: nullpointerexception
> Fix For: 4.3.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If we first add a null element into CompositeCollection by 
> CompositeCollection.addComposited(nullElement), projects will crash and throw 
> java.lang.NullPointerException when we call CompositeCollection.size().
> For example, we have following code:
> ArrayList nullList = null;
> CompositeCollection cc = new CompositeCollection(list);
> cc.addComposited(nullList);
> System.out.println(cc.size());
>  
> We will get:
> {{Exception in thread "main" java.lang.NullPointerException}}
> at 
> org.apache.commons.collections4.collection.CompositeCollection.size(CompositeCollection.java:103)
>  
> Because in CompositeCollection.size(), it iterate all items in the 
> Collection, call item.size() and sum up their size. If the item point to 
> null, the program will crash.
>  
> This bug also exists in other methods of CompositeCollection. Moreover, 
> CompositeSet and CompositeMap have the same bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (COLLECTIONS-542) AbstractHashedMap should not extend AbstractMap anymore

2019-02-09 Thread Gary Gregory (JIRA)


 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated COLLECTIONS-542:
-
Fix Version/s: (was: 4.3)
   4.3.1

> AbstractHashedMap should not extend AbstractMap anymore
> ---
>
> Key: COLLECTIONS-542
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-542
> Project: Commons Collections
>  Issue Type: Task
>Affects Versions: 4.0
>Reporter: Thomas Neidhart
>Priority: Minor
> Fix For: 5.0, 4.3.1
>
>
> As described in the javadoc of AbstractHashedMap, the inheritance of 
> AbstractMap should have been removed in the 4.0 release.
> This has been forgotten. Removal of the inheritance does not seem to be 
> possible for the 4.x branch, so we should at least correct the javadoc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (COLLECTIONS-710) NullPointerExceptions in CompositeCollection, CompositeSet, and CompositeMap

2019-02-09 Thread Gary Gregory (JIRA)


 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated COLLECTIONS-710:
-
Summary: NullPointerExceptions in CompositeCollection, CompositeSet, and 
CompositeMap  (was: Calling CompositeCollection.size() will cash if  the list 
contains null element.)

> NullPointerExceptions in CompositeCollection, CompositeSet, and CompositeMap
> 
>
> Key: COLLECTIONS-710
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-710
> Project: Commons Collections
>  Issue Type: Bug
>  Components: Collection, Map, Set
>Affects Versions: 4.2
> Environment: Windows 10
> Eclipse IDE for Java Developers     Version: 2018-09 (4.9.0)
>Reporter: Yu Shi
>Priority: Major
>  Labels: nullpointerexception
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If we first add a null element into CompositeCollection by 
> CompositeCollection.addComposited(nullElement), projects will crash and throw 
> java.lang.NullPointerException when we call CompositeCollection.size().
> For example, we have following code:
> ArrayList nullList = null;
> CompositeCollection cc = new CompositeCollection(list);
> cc.addComposited(nullList);
> System.out.println(cc.size());
>  
> We will get:
> {{Exception in thread "main" java.lang.NullPointerException}}
> at 
> org.apache.commons.collections4.collection.CompositeCollection.size(CompositeCollection.java:103)
>  
> Because in CompositeCollection.size(), it iterate all items in the 
> Collection, call item.size() and sum up their size. If the item point to 
> null, the program will crash.
>  
> This bug also exists in other methods of CompositeCollection. Moreover, 
> CompositeSet and CompositeMap have the same bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEOMETRY-44) Enable Coveralls Reporting

2019-02-09 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764253#comment-16764253
 ] 

Gilles commented on GEOMETRY-44:


Good point.  File a request there. ;)

> Enable Coveralls Reporting
> --
>
> Key: GEOMETRY-44
> URL: https://issues.apache.org/jira/browse/GEOMETRY-44
> Project: Apache Commons Geometry
>  Issue Type: Task
>Reporter: Matt Juntunen
>Priority: Minor
>
> We should enable the coveralls code coverage reporting in Github, like 
> commons-numbers has. I compared commons-geometry's configuration to that of 
> commons-numbers and didn't see any differences. Perhaps this is an infra 
> issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (COLLECTIONS-710) Calling CompositeCollection.size() will cash if the list contains null element.

2019-02-09 Thread Yu Shi (JIRA)


 [ 
https://issues.apache.org/jira/browse/COLLECTIONS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yu Shi updated COLLECTIONS-710:
---
Priority: Major  (was: Minor)

> Calling CompositeCollection.size() will cash if  the list contains null 
> element.
> 
>
> Key: COLLECTIONS-710
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-710
> Project: Commons Collections
>  Issue Type: Bug
>  Components: Collection, Map, Set
>Affects Versions: 4.2
> Environment: Windows 10
> Eclipse IDE for Java Developers     Version: 2018-09 (4.9.0)
>Reporter: Yu Shi
>Priority: Major
>  Labels: nullpointerexception
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If we first add a null element into CompositeCollection by 
> CompositeCollection.addComposited(nullElement), projects will crash and throw 
> java.lang.NullPointerException when we call CompositeCollection.size().
> For example, we have following code:
> ArrayList nullList = null;
> CompositeCollection cc = new CompositeCollection(list);
> cc.addComposited(nullList);
> System.out.println(cc.size());
>  
> We will get:
> {{Exception in thread "main" java.lang.NullPointerException}}
> at 
> org.apache.commons.collections4.collection.CompositeCollection.size(CompositeCollection.java:103)
>  
> Because in CompositeCollection.size(), it iterate all items in the 
> Collection, call item.size() and sum up their size. If the item point to 
> null, the program will crash.
>  
> This bug also exists in other methods of CompositeCollection. Moreover, 
> CompositeSet and CompositeMap have the same bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (DBCP-536) More than 5k+ instances of PgConnection created

2019-02-09 Thread Gary Gregory (JIRA)


[ 
https://issues.apache.org/jira/browse/DBCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764210#comment-16764210
 ] 

Gary Gregory commented on DBCP-536:
---

What happens when you test with version 2.5.0?

> More than 5k+ instances of PgConnection created
> ---
>
> Key: DBCP-536
> URL: https://issues.apache.org/jira/browse/DBCP-536
> Project: Commons DBCP
>  Issue Type: Bug
>Affects Versions: 2.0.1
>Reporter: Rahil S
>Priority: Major
> Attachments: Screenshot 2019-02-09 at 3.39.35 PM.jpg, Screenshot 
> 2019-02-09 at 3.41.20 PM.jpg
>
>
> Hi,
>  
> We are facing memory issues with DBCP2 in production. We are using the 2.0.1 
> version of dbcp2. By analyzing heap dump we noticed that 5k+ instances of 
> PgConnection were created. I have attached the screenshot of the same.
> We have set setMaxTotal(pool size) to 40 and initializing two BasicDatasource 
> Objects for two different data source.
>  
> Regards,
> Rahil



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (DBCP-536) More than 5k+ instances of PgConnection created

2019-02-09 Thread Gary Gregory (JIRA)


[ 
https://issues.apache.org/jira/browse/DBCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764210#comment-16764210
 ] 

Gary Gregory edited comment on DBCP-536 at 2/9/19 7:34 PM:
---

Do you close all pool objects?

What happens when you test with version 2.5.0?


was (Author: garydgregory):
What happens when you test with version 2.5.0?

> More than 5k+ instances of PgConnection created
> ---
>
> Key: DBCP-536
> URL: https://issues.apache.org/jira/browse/DBCP-536
> Project: Commons DBCP
>  Issue Type: Bug
>Affects Versions: 2.0.1
>Reporter: Rahil S
>Priority: Major
> Attachments: Screenshot 2019-02-09 at 3.39.35 PM.jpg, Screenshot 
> 2019-02-09 at 3.41.20 PM.jpg
>
>
> Hi,
>  
> We are facing memory issues with DBCP2 in production. We are using the 2.0.1 
> version of dbcp2. By analyzing heap dump we noticed that 5k+ instances of 
> PgConnection were created. I have attached the screenshot of the same.
> We have set setMaxTotal(pool size) to 40 and initializing two BasicDatasource 
> Objects for two different data source.
>  
> Regards,
> Rahil



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-90) DoublePrecisionContext

2019-02-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-90?focusedWorklogId=196558&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196558
 ]

ASF GitHub Bot logged work on NUMBERS-90:
-

Author: ASF GitHub Bot
Created on: 09/Feb/19 14:25
Start Date: 09/Feb/19 14:25
Worklog Time Spent: 10m 
  Work Description: darkma773r commented on pull request #28: NUMBERS-90: 
adding DoublePrecisionContext and FloatPrecisionContext
URL: https://github.com/apache/commons-numbers/pull/28
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 196558)
Time Spent: 40m  (was: 0.5h)

> DoublePrecisionContext
> --
>
> Key: NUMBERS-90
> URL: https://issues.apache.org/jira/browse/NUMBERS-90
> Project: Commons Numbers
>  Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Blocker
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should add a new class to commons-numbers-core that encapsulates 
> configurable strategies for comparing doubles. This is required for 
> GEOMETRY-11. Here is what I'm picturing:
> {code:java}
> // abstract class for the general concept of comparisons
> public abstract class DoublePrecisionContext implements Comparator {
> public abstract boolean equals(double a, double b);
> public int compare(double a, double b) { /* ... */ }
> public int compare(Double a, Double b) { /* ... */ }
> }
> // ...
> // concrete class implementing a specific strategy
> public class EpsilonUlpDoublePrecisionContext extends DoublePrecisionContext {
> public EpsilonUlpDoublePrecisionContext(double eps, double maxUlps) { /* 
> ... */ }
> @Override
> public boolean equals(double a, double b) { /* ... */ }
> } {code}
> Pull request: https://github.com/apache/commons-numbers/pull/28



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-90) DoublePrecisionContext

2019-02-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-90?focusedWorklogId=196559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196559
 ]

ASF GitHub Bot logged work on NUMBERS-90:
-

Author: ASF GitHub Bot
Created on: 09/Feb/19 14:25
Start Date: 09/Feb/19 14:25
Worklog Time Spent: 10m 
  Work Description: darkma773r commented on issue #28: NUMBERS-90: adding 
DoublePrecisionContext and FloatPrecisionContext
URL: https://github.com/apache/commons-numbers/pull/28#issuecomment-462048752
 
 
   I'm closing this PR since this functionality was placed directly in 
commons-geometry, at least until the API and use cases can be explored more. 
See GEOMETRY-11.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 196559)

> DoublePrecisionContext
> --
>
> Key: NUMBERS-90
> URL: https://issues.apache.org/jira/browse/NUMBERS-90
> Project: Commons Numbers
>  Issue Type: New Feature
>Reporter: Matt Juntunen
>Priority: Blocker
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should add a new class to commons-numbers-core that encapsulates 
> configurable strategies for comparing doubles. This is required for 
> GEOMETRY-11. Here is what I'm picturing:
> {code:java}
> // abstract class for the general concept of comparisons
> public abstract class DoublePrecisionContext implements Comparator {
> public abstract boolean equals(double a, double b);
> public int compare(double a, double b) { /* ... */ }
> public int compare(Double a, Double b) { /* ... */ }
> }
> // ...
> // concrete class implementing a specific strategy
> public class EpsilonUlpDoublePrecisionContext extends DoublePrecisionContext {
> public EpsilonUlpDoublePrecisionContext(double eps, double maxUlps) { /* 
> ... */ }
> @Override
> public boolean equals(double a, double b) { /* ... */ }
> } {code}
> Pull request: https://github.com/apache/commons-numbers/pull/28



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEOMETRY-43) Check unit test - line intersecting cube (line lies on a plane)

2019-02-09 Thread Matt Juntunen (JIRA)


[ 
https://issues.apache.org/jira/browse/GEOMETRY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764153#comment-16764153
 ] 

Matt Juntunen commented on GEOMETRY-43:
---

I added a pull request with a fix for this: 
[https://github.com/apache/commons-geometry/pull/25]

I included your unit test, which now passes, along with a couple of others.

> Check unit test - line intersecting cube (line lies on a plane)
> ---
>
> Key: GEOMETRY-43
> URL: https://issues.apache.org/jira/browse/GEOMETRY-43
> Project: Apache Commons Geometry
>  Issue Type: Task
>  Components: Euclidean 3D
>Reporter: Sven Rathgeber
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Intersecting a cube with a Line (which lies on a plane) results in one 
> intersection only.
>  
> Please check the pull request:
> https://github.com/apache/commons-geometry/pull/23
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEOMETRY-44) Enable Coveralls Reporting

2019-02-09 Thread Matt Juntunen (JIRA)
Matt Juntunen created GEOMETRY-44:
-

 Summary: Enable Coveralls Reporting
 Key: GEOMETRY-44
 URL: https://issues.apache.org/jira/browse/GEOMETRY-44
 Project: Apache Commons Geometry
  Issue Type: Task
Reporter: Matt Juntunen


We should enable the coveralls code coverage reporting in Github, like 
commons-numbers has. I compared commons-geometry's configuration to that of 
commons-numbers and didn't see any differences. Perhaps this is an infra issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] PascalSchumacher commented on issue #404: Assertion cleanup

2019-02-09 Thread GitBox
PascalSchumacher commented on issue #404: Assertion cleanup
URL: https://github.com/apache/commons-lang/pull/404#issuecomment-462037558
 
 
   Thanks! 👍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit closed pull request #404: Assertion cleanup

2019-02-09 Thread GitBox
asfgit closed pull request #404: Assertion cleanup
URL: https://github.com/apache/commons-lang/pull/404
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (DBCP-536) More than 5k+ instances of PgConnection created

2019-02-09 Thread Rahil S (JIRA)
Rahil S created DBCP-536:


 Summary: More than 5k+ instances of PgConnection created
 Key: DBCP-536
 URL: https://issues.apache.org/jira/browse/DBCP-536
 Project: Commons DBCP
  Issue Type: Bug
Affects Versions: 2.0.1
Reporter: Rahil S
 Attachments: Screenshot 2019-02-09 at 3.39.35 PM.jpg, Screenshot 
2019-02-09 at 3.41.20 PM.jpg

Hi,

 

We are facing memory issues with DBCP2 in production. We are using the 2.0.1 
version of dbcp2. By analyzing heap dump we noticed that 5k+ instances of 
PgConnection were created. I have attached the screenshot of the same.

We have set setMaxTotal(pool size) to 40 and initializing two BasicDatasource 
Objects for two different data source.

 

Regards,

Rahil



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)