[jira] [Commented] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-30 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875969#comment-16875969
 ] 

Gilles commented on NUMBERS-119:


bq. I found one missed Javadoc update

Thanks for the review.

bq. is a patch preferable for such trivial changes?

Either is fine. 

> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Fix For: 1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact 
> that, when the biased exponent of a {{double}} value is {{0}} and the 
> mantissa is not {{0}} (i.e. when the value represents a subnormal number), 
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other 
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value 
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it 
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which 
> is not very memory-efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875968#comment-16875968
 ] 

Gilles commented on NUMBERS-123:


Done.


> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-123?focusedWorklogId=270002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270002
 ]

ASF GitHub Bot logged work on NUMBERS-123:
--

Author: ASF GitHub Bot
Created on: 01/Jul/19 06:41
Start Date: 01/Jul/19 06:41
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #60: NUMBERS-123: 
Javadoc
URL: https://github.com/apache/commons-numbers/pull/60
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 270002)
Time Spent: 0.5h  (was: 20m)

> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [commons-numbers] asfgit merged pull request #60: NUMBERS-123: Javadoc

2019-06-30 Thread GitBox
asfgit merged pull request #60: NUMBERS-123: Javadoc
URL: https://github.com/apache/commons-numbers/pull/60
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (NUMBERS-125) BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary

2019-06-30 Thread Heinrich Bohne (JIRA)
Heinrich Bohne created NUMBERS-125:
--

 Summary: BigFraction.reduce() and Fraction.getReducedFraction(int, 
int) are unnecessary
 Key: NUMBERS-125
 URL: https://issues.apache.org/jira/browse/NUMBERS-125
 Project: Commons Numbers
  Issue Type: Improvement
  Components: fraction
Affects Versions: 1.0
Reporter: Heinrich Bohne


The instance method {{BigFraction.reduce()}} is unnecessary, because the only 
constructor in this class already reduces the fraction to lowest terms.

Likewise, the static factory method {{Fraction.getReducedFraction(int, int)}} 
is unnecessary, because it is functionally completely equivalent to the factory 
method {{Fraction.of(int, int)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-123?focusedWorklogId=269920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269920
 ]

ASF GitHub Bot logged work on NUMBERS-123:
--

Author: ASF GitHub Bot
Created on: 01/Jul/19 00:07
Start Date: 01/Jul/19 00:07
Worklog Time Spent: 10m 
  Work Description: coveralls commented on issue #60: NUMBERS-123: Javadoc
URL: https://github.com/apache/commons-numbers/pull/60#issuecomment-507078673
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/24291326/badge)](https://coveralls.io/builds/24291326)
   
   Coverage remained the same at 94.155% when pulling 
**39c83ad03e4cfb4c8d4cf5e855e14eb1c6a62667 on Schamschi:NUMBERS-123** into 
**a796401f4a695738ed72512dd2a3920c71d7bb23 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 269920)
Time Spent: 20m  (was: 10m)

> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [commons-numbers] coveralls commented on issue #60: NUMBERS-123: Javadoc

2019-06-30 Thread GitBox
coveralls commented on issue #60: NUMBERS-123: Javadoc
URL: https://github.com/apache/commons-numbers/pull/60#issuecomment-507078673
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/24291326/badge)](https://coveralls.io/builds/24291326)
   
   Coverage remained the same at 94.155% when pulling 
**39c83ad03e4cfb4c8d4cf5e855e14eb1c6a62667 on Schamschi:NUMBERS-123** into 
**a796401f4a695738ed72512dd2a3920c71d7bb23 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread Heinrich Bohne (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heinrich Bohne updated NUMBERS-123:
---
Attachment: NUMBERS-123__Javadoc.patch

> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread Heinrich Bohne (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875890#comment-16875890
 ] 

Heinrich Bohne commented on NUMBERS-123:


The Javadoc still needs to be updated in two places, here's a patch. 
[^NUMBERS-123__Javadoc.patch] 

> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
> Attachments: NUMBERS-123__Javadoc.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-123?focusedWorklogId=269919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269919
 ]

ASF GitHub Bot logged work on NUMBERS-123:
--

Author: ASF GitHub Bot
Created on: 01/Jul/19 00:02
Start Date: 01/Jul/19 00:02
Worklog Time Spent: 10m 
  Work Description: Schamschi commented on pull request #60: NUMBERS-123: 
Javadoc
URL: https://github.com/apache/commons-numbers/pull/60
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 269919)
Time Spent: 10m
Remaining Estimate: 0h

> "BigFraction(double)" is unnecessary
> 
>
> Key: NUMBERS-123
> URL: https://issues.apache.org/jira/browse/NUMBERS-123
> Project: Commons Numbers
>  Issue Type: Improvement
>  Components: fraction
>Reporter: Gilles
>Assignee: Gilles
>Priority: Trivial
> Fix For: 1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Constructor {{BigFraction(double value)}} is only called from the 
> {{from(double value)}} method.
>  Actually, this constructor is misleading as it is indeed primarily a 
> conversion from which appropriate {{numerator}} and {{denominator}} fields 
> are computed; those could be set by
>  the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.
> Moreover, the private field {{ZERO}} goes through this conversion code 
> whereas it could constructed "directly", e.g. using {{of(0)}}. Similarly for 
> field {{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [commons-numbers] Schamschi opened a new pull request #60: NUMBERS-123: Javadoc

2019-06-30 Thread GitBox
Schamschi opened a new pull request #60: NUMBERS-123: Javadoc
URL: https://github.com/apache/commons-numbers/pull/60
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-30 Thread Heinrich Bohne (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875888#comment-16875888
 ] 

Heinrich Bohne commented on NUMBERS-119:


Excellent, thanks! Regarding NUMBERS-123 and 124: I found one missed Javadoc 
update, for which I'll create a pull request. Or is a patch preferable for such 
trivial changes? I'll create a patch too, if I manage to upload it in 
NUMBERS-123.

> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Fix For: 1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact 
> that, when the biased exponent of a {{double}} value is {{0}} and the 
> mantissa is not {{0}} (i.e. when the value represents a subnormal number), 
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other 
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value 
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it 
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which 
> is not very memory-efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-30 Thread Heinrich Bohne (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heinrich Bohne resolved NUMBERS-119.

   Resolution: Fixed
Fix Version/s: 1.0

> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
> Fix For: 1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact 
> that, when the biased exponent of a {{double}} value is {{0}} and the 
> mantissa is not {{0}} (i.e. when the value represents a subnormal number), 
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other 
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value 
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it 
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which 
> is not very memory-efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-30 Thread Gilles (JIRA)


[ 
https://issues.apache.org/jira/browse/NUMBERS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875875#comment-16875875
 ] 

Gilles commented on NUMBERS-119:


Done.
 Please review the additional changes I've made, also as part of NUMBERS-123 
and NUMBERS-124.

> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact 
> that, when the biased exponent of a {{double}} value is {{0}} and the 
> mantissa is not {{0}} (i.e. when the value represents a subnormal number), 
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other 
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value 
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it 
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which 
> is not very memory-efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Work logged] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-30 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/NUMBERS-119?focusedWorklogId=269911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269911
 ]

ASF GitHub Bot logged work on NUMBERS-119:
--

Author: ASF GitHub Bot
Created on: 30/Jun/19 21:55
Start Date: 30/Jun/19 21:55
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #56: NUMBERS-119: 
Correct bug in BigFraction(double) constructor
URL: https://github.com/apache/commons-numbers/pull/56
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 269911)
Time Spent: 1h 20m  (was: 1h 10m)

> BigFraction(double) constructor does not treat subnormal numbers correctly
> --
>
> Key: NUMBERS-119
> URL: https://issues.apache.org/jira/browse/NUMBERS-119
> Project: Commons Numbers
>  Issue Type: Bug
>  Components: fraction
>Affects Versions: 1.0
>Reporter: Heinrich Bohne
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The constructor {{BigFraction(double)}} does not take into account the fact 
> that, when the biased exponent of a {{double}} value is {{0}} and the 
> mantissa is not {{0}} (i.e. when the value represents a subnormal number), 
> the actual exponent in effect is not {{-1023}} but {{-1022}} (or, in other 
> words, the effective exponent bias is not {{1023}} but {{1022}}).
> The value of the created {{BigFraction}} is therefore not equal to the value 
> of the passed {{double}} argument.
> Also, since the constructor does not handle the case of zero separately, it 
> creates a fraction with a numerator of 0 and a denominator of 2^1075^, which 
> is not very memory-efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [commons-numbers] asfgit closed pull request #56: NUMBERS-119: Correct bug in BigFraction(double) constructor

2019-06-30 Thread GitBox
asfgit closed pull request #56: NUMBERS-119: Correct bug in BigFraction(double) 
constructor
URL: https://github.com/apache/commons-numbers/pull/56
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (NUMBERS-124) "BigFraction(double,double,int,int)" is unnecessary

2019-06-30 Thread Gilles (JIRA)
Gilles created NUMBERS-124:
--

 Summary: "BigFraction(double,double,int,int)" is unnecessary
 Key: NUMBERS-124
 URL: https://issues.apache.org/jira/browse/NUMBERS-124
 Project: Commons Numbers
  Issue Type: Improvement
Reporter: Gilles
Assignee: Gilles
 Fix For: 1.0


Code in that constructor should be moved to a conversion method:
{code}
private static BigFraction from(double v, double eps, int mexDenom, int maxIter)
{code}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NUMBERS-123) "BigFraction(double)" is unnecessary

2019-06-30 Thread Gilles (JIRA)
Gilles created NUMBERS-123:
--

 Summary: "BigFraction(double)" is unnecessary
 Key: NUMBERS-123
 URL: https://issues.apache.org/jira/browse/NUMBERS-123
 Project: Commons Numbers
  Issue Type: Improvement
  Components: fraction
Reporter: Gilles
Assignee: Gilles
 Fix For: 1.0


Constructor {{BigFraction(double value)}} is only called from the {{from(double 
value)}} method.
 Actually, this constructor is misleading as it is indeed primarily a 
conversion from which appropriate {{numerator}} and {{denominator}} fields are 
computed; those could be set by
 the "direct" constructor {{BigFraction(BigInteger num, BigInteger den)}}.

Moreover, the private field {{ZERO}} goes through this conversion code whereas 
it could constructed "directly", e.g. using {{of(0)}}. Similarly for field 
{{ONE}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [commons-text] asfgit closed pull request #116: Spotbugs 3 1 12

2019-06-30 Thread GitBox
asfgit closed pull request #116: Spotbugs 3 1 12
URL: https://github.com/apache/commons-text/pull/116
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [commons-text] coveralls commented on issue #116: Spotbugs 3 1 12

2019-06-30 Thread GitBox
coveralls commented on issue #116: Spotbugs 3 1 12
URL: https://github.com/apache/commons-text/pull/116#issuecomment-507024035
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/24286765/badge)](https://coveralls.io/builds/24286765)
   
   Coverage remained the same at 97.918% when pulling 
**68a2eaf7136f19a9f7b9781a2ba873883d33ccf9 on 
PascalSchumacher:spotbugs_3_1_12** into 
**b7666a298eb87d5060b88391327f037b92c123c9 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [commons-text] PascalSchumacher opened a new pull request #116: Spotbugs 3 1 12

2019-06-30 Thread GitBox
PascalSchumacher opened a new pull request #116: Spotbugs 3 1 12
URL: https://github.com/apache/commons-text/pull/116
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services