[jira] [Commented] (GEOMETRY-59) unexpected output from PolyhedronsSet::checkPoint
[ https://issues.apache.org/jira/browse/GEOMETRY-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890714#comment-16890714 ] Dirk Bonekämper commented on GEOMETRY-59: - [~mattjuntunen]. Sounds good. Go for it. > unexpected output from PolyhedronsSet::checkPoint > - > > Key: GEOMETRY-59 > URL: https://issues.apache.org/jira/browse/GEOMETRY-59 > Project: Apache Commons Geometry > Issue Type: Bug > Components: Euclidean 3D >Reporter: Dirk Bonekämper >Priority: Major > Labels: pull-request-available > Attachments: InsideProblemTest.java > > Time Spent: 10m > Remaining Estimate: 0h > > In my project I'm working with 3D Regions modeled as prisms. The base > polygons are mostly concave. I got wrong results and boiled it down to the > attached unit test. It creates a prism with a concave base. A point that is > above the prism gets classified as INSIDE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CSV-249) ArrayIndexOutOfBoundsException when trying to read record written by CSVPrinter using CSVParser with same format
[
https://issues.apache.org/jira/browse/CSV-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890693#comment-16890693
]
Jelmer Kuperus commented on CSV-249:
Seems to be a duplicate of an issue from 2016 !!!
Apache spark ships with both .escapa character and quote character set, so is
effectively broken this way
> ArrayIndexOutOfBoundsException when trying to read record written by
> CSVPrinter using CSVParser with same format
>
>
> Key: CSV-249
> URL: https://issues.apache.org/jira/browse/CSV-249
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.5, 1.6, 1.7
>Reporter: Jelmer Kuperus
>Priority: Major
>
> The following code will fail with the exception
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1
> out of bounds for length 1
> {noformat}
> import org.apache.commons.csv.*;
> import java.io.StringReader;
> import java.io.StringWriter;
> import java.util.List;
> public class Poc {
> public static void main(String[] args) throws Exception {
> CSVFormat csvFormat = CSVFormat.DEFAULT
> .withEscape('\\');
> StringWriter stringWriter = new StringWriter();
> CSVPrinter printer = new CSVPrinter(stringWriter, csvFormat);
> printer.printRecord("foo \\", "bar");
> StringReader stringReader = new StringReader(stringWriter.toString());
> CSVParser parser = new CSVParser(stringReader, csvFormat);
> List records = parser.getRecords();
> records.forEach(record -> {
> System.out.println(record.get(0));
> System.out.println(record.get(1));
> });
> }
> }{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (GEOMETRY-59) unexpected output from PolyhedronsSet::checkPoint
[
https://issues.apache.org/jira/browse/GEOMETRY-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890596#comment-16890596
]
Matt Juntunen commented on GEOMETRY-59:
---
[~bonastos], I took a look at your PR and I feel like your approach is
definitely superior. It's simpler, more intuitive, and has a solid mathematical
basis. However, my implementation has the benefits of being more widely
applicable (since it's a public, static method of Plane), being able to handle
collinear points, and validating that all input points lie on the computed
plane. So, I'm thinking we take my new {{Plane.fromPoints}} overload and
replace the plane orientation algorithm with yours. I think we could make that
work in a single pass through the point collection. Thoughts?
> unexpected output from PolyhedronsSet::checkPoint
> -
>
> Key: GEOMETRY-59
> URL: https://issues.apache.org/jira/browse/GEOMETRY-59
> Project: Apache Commons Geometry
> Issue Type: Bug
> Components: Euclidean 3D
>Reporter: Dirk Bonekämper
>Priority: Major
> Labels: pull-request-available
> Attachments: InsideProblemTest.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In my project I'm working with 3D Regions modeled as prisms. The base
> polygons are mostly concave. I got wrong results and boiled it down to the
> attached unit test. It creates a prism with a concave base. A point that is
> above the prism gets classified as INSIDE.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-crypto] vanzin commented on a change in pull request #94: Crypto 137 windows compile
vanzin commented on a change in pull request #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94#discussion_r306087489
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -134,7 +134,7 @@ void *do_version_dlsym(JNIEnv *env, void *handle) {
/* Microsoft C Compiler does not support the C99 inline keyword */
#ifndef __cplusplus
-#define inline __inline;
+//#define inline __inline;
Review comment:
What is the problem here? If this is broken then perhaps the whole thing
should be deleted, instead of this line commented out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin commented on a change in pull request #94: Crypto 137 windows compile
vanzin commented on a change in pull request #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94#discussion_r306087240
##
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##
@@ -41,27 +41,48 @@
#ifdef UNIX
static unsigned long (*dlsym_OpenSSL_version_num) (void);
static const char * (*dlsym_OpenSSL_version) (int);
-static void *openssl;
#endif
#ifdef WINDOWS
-typedef unsigned long (__cdecl *__dlsym_OpenSSL) (void);
-static __dlsym_OpenSSL dlsym_OpenSSL;
+typedef unsigned long (__cdecl *__dlsym_OpenSSL_version_num) (void);
typedef char * (__cdecl *__dlsym_OpenSSL_version) (int);
-static __dlsym_OpenSSL dlsym_OpenSSL;
+static __dlsym_OpenSSL_version_num dlsym_OpenSSL_version_num;
static __dlsym_OpenSSL_version dlsym_OpenSSL_version;
-HMODULE openssl;
#endif
+#ifdef UNIX
+static void get_methods(JNIEnv *env, void *openssl)
+#endif
+#ifdef WINDOWS
+static void get_methods(JNIEnv *env, HMODULE openssl)
+#endif
+{
+ LOAD_OPENSSL_VERSION_FUNCTION(dlsym_OpenSSL_version_num, env, openssl);
+#ifdef UNIX
+ if (dlsym_OpenSSL_version_num() > VERSION_1_1_X) {
+ LOAD_DYNAMIC_SYMBOL(dlsym_OpenSSL_version, env, openssl,
"OpenSSL_version");
Review comment:
2 vs. 4 space indent, here and in other places in this file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin commented on a change in pull request #94: Crypto 137 windows compile
vanzin commented on a change in pull request #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94#discussion_r306087537
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -187,6 +187,24 @@ static FARPROC WINAPI do_dlsym(JNIEnv *env, HMODULE
handle, LPCSTR symbol) {
}
return func_ptr;
}
+
+static FARPROC WINAPI do_version_dlsym(JNIEnv *env, HMODULE handle) {
+ FARPROC func_ptr = NULL;
+ if (!env || !handle) {
+THROW(env, "java/lang/InternalError", NULL);
+ return NULL;
Review comment:
indentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-crypto] vanzin commented on a change in pull request #94: Crypto 137 windows compile
vanzin commented on a change in pull request #94: Crypto 137 windows compile URL: https://github.com/apache/commons-crypto/pull/94#discussion_r306087369 ## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c ## @@ -183,12 +188,18 @@ JNIEXPORT void JNICALL Java_org_apache_commons_crypto_cipher_OpenSslNative_initI env, openssl, "EVP_CIPHER_CTX_new"); LOAD_DYNAMIC_SYMBOL(__dlsym_EVP_CIPHER_CTX_free, dlsym_EVP_CIPHER_CTX_free, \ env, openssl, "EVP_CIPHER_CTX_free"); - LOAD_DYNAMIC_SYMBOL(__dlsym_EVP_CIPHER_CTX_reset, \ - dlsym_EVP_CIPHER_CTX_reset, env, - openssl, "EVP_CIPHER_CTX_reset"); - LOAD_DYNAMIC_SYMBOL(__dlsym_EVP_CIPHER_CTX_set_padding, \ - dlsym_EVP_CIPHER_CTX_set_padding, env, \ - openssl, "EVP_CIPHER_CTX_set_padding"); + LOAD_DYNAMIC_SYMBOL(__dlsym_EVP_CIPHER_CTX_set_padding, dlsym_EVP_CIPHER_CTX_set_padding, \ + env, openssl, "EVP_CIPHER_CTX_set_padding"); + LOAD_DYNAMIC_SYMBOL(__dlsym_EVP_CIPHER_CTX_ctrl, dlsym_EVP_CIPHER_CTX_ctrl, \ + env, openssl, "EVP_CIPHER_CTX_ctrl"); Review comment: alignment is inconsistent with previous calls (also happens below in several calls) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-crypto] vanzin commented on a change in pull request #94: Crypto 137 windows compile
vanzin commented on a change in pull request #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94#discussion_r306087562
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -187,6 +187,24 @@ static FARPROC WINAPI do_dlsym(JNIEnv *env, HMODULE
handle, LPCSTR symbol) {
}
return func_ptr;
}
+
+static FARPROC WINAPI do_version_dlsym(JNIEnv *env, HMODULE handle) {
+ FARPROC func_ptr = NULL;
+ if (!env || !handle) {
+THROW(env, "java/lang/InternalError", NULL);
+ return NULL;
+ }
+ func_ptr = GetProcAddress(handle, "OpenSSL_version_num");
+ if (func_ptr == NULL) {
+func_ptr = GetProcAddress(handle, "SSLeay");
+ }
+ return func_ptr;
+}
+/* A macro to dlsym the appropriate OpenSSL version number function. */
Review comment:
Add empty line before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-statistics] BBenNguyenn opened a new pull request #23: GSoC Milestone 1: OLS Regression Complete
BBenNguyenn opened a new pull request #23: GSoC Milestone 1: OLS Regression Complete URL: https://github.com/apache/commons-statistics/pull/23 **OLS functionality complete:** - converted all math4.linear dependencies to EJML (more complicated and time consuming than expected) -> should be easier now for GLS and logistic since experience was gained while porting OLS - ensured full unit test coverage by porting all old ols tests and adding some new ones - created preliminary RegressionResults interface which essentially holds calculated results of a regression (to be accessed multiple times but calculated once) -> Note: preliminary usage with testSwissFertilityInterfaceFormat() in OLSRegressionTest, more to be added **Known Code Smell:** math4.stat depedency Dependency usage: StatUtil, SumOfSquares, Variance, SecondMoment **Explanation:** This dependency is temporary until Statistics Descriptive completes array as input methods for above class functionalities which is said to be coming soon. I have considered helping Virendra with it to prevent all old dependencies completely for this milestone but I don't think I should interfere while I haven't completed my component since I would have to learn how to use streams properly as well, and it does sound like Virendra will be done soon anyways. Once Virendra is done, the switch will be swift, since only about 3 methods total use those functionalities. **Known Code Smell:** Data loading is perhaps not ideal **Explanation:** The current RegressionDataLoader stores the input data within a RegressionRawData object and passes an interface with a getter. This should be improved by using one of the suggested strategies in the ML. Will get to this this week or maybe after port of GLS **Next Objectives:** - Improve data loading strategy -> as suggested, a proper Factory pattern model - Finalize RegressionResults interface for OLS and other regressions to output -> Summary statistics printout method? - Port GLS (expected to not take as long as OLS) - Start LogisticRegression implementation design **PLEASE NOTE:** - I've created a UML "UML_current.png" in the README directory if anyone thinks a visual would be helpful. - Full commit history (before squashing) is in STATISTICS-8_Regression_Module branch. Thank you for your review, -Ben Nguyen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (POOL-361) setTestOnCreate does not test on create
[
https://issues.apache.org/jira/browse/POOL-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory resolved POOL-361.
---
Resolution: Fixed
[~pakman],
The fix is in git master. Please verify and close.
Gary
> setTestOnCreate does not test on create
> ---
>
> Key: POOL-361
> URL: https://issues.apache.org/jira/browse/POOL-361
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 2.6.1
>Reporter: Pablo
>Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When setting testOnCreate to true, I would expect for the validation to take
> place when an object is created, but apparently it does not.
> It only seems to be tested on borrow and when idle.
> This has a negative impact, because when new objects get created, since they
> are not tested they appear in the pool as idle.
> I'm trying to determine if the pool's health, but even though the pool
> reports idle objects they are botched instances.
> Also related to this issue, objects aren't actually created upfront. They
> seem to be created on first borrow or when timeBetweenEvictionRunMillis
> elapses.
> Environment (unimportant I think): 1.8.0_191, Ubuntu 18.04
> Test case:
>
> {code:java}
> public static void main(String[] args) throws Exception {
> PooledObjectFactory factory = new
> BasePooledObjectFactory() {
> public String create() throws Exception {
> String s = "Hello";
> System.out.println("Creating " + s);
> return s;
> }
> public void destroyObject(PooledObject p) throws
> Exception {
> System.out.println("Destroying " + p.getObject());
> }
> public boolean validateObject(PooledObject p) {
> System.out.println("Validating " + p.getObject());
> return super.validateObject(p);
> }
> public PooledObject wrap(String obj) {
> return new Wrapper(obj);
> }
> };
> GenericObjectPoolConfig socketPoolConfig = new
> GenericObjectPoolConfig();
> socketPoolConfig.setTestOnCreate(true);
> socketPoolConfig.setTestWhileIdle(false);
> GenericObjectPool objectPool = new
> GenericObjectPool(factory, socketPoolConfig);
> System.out.println("Pool created");
> String f1 = objectPool.borrowObject();
> System.out.println("Borrowed" + f1);
> objectPool.returnObject(f1);
> objectPool.close();
> System.out.println("Done");
> }{code}
>
>
> Expected result:
> {{ Pool created}}
> {{ Creating Hello}}
> {{ *Validating Hello*}}
> {{ Allocating Hello}}
> {{ BorrowedHello}}
> {{ DeallocatingHello}}
> {{ Destroying Hello}}
> {{ Done}}
>
> Actual result:
> {{ Pool created}}
> {{ Creating Hello}}
> {{ Allocating Hello}}
> {{ *Validating Hello*}}
> {{ BorrowedHello}}
> {{ DeallocatingHello}}
> {{ Destroying Hello}}
> {{ Done}}
>
> Or am I misunderstanding something?
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (POOL-361) setTestOnCreate does not test on create
[
https://issues.apache.org/jira/browse/POOL-361?focusedWorklogId=280642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280642
]
ASF GitHub Bot logged work on POOL-361:
---
Author: ASF GitHub Bot
Created on: 22/Jul/19 21:27
Start Date: 22/Jul/19 21:27
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #23: Move
validation for newly created objects into create(). Fixes POOL-361.
URL: https://github.com/apache/commons-pool/pull/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 280642)
Time Spent: 40m (was: 0.5h)
> setTestOnCreate does not test on create
> ---
>
> Key: POOL-361
> URL: https://issues.apache.org/jira/browse/POOL-361
> Project: Commons Pool
> Issue Type: Bug
>Affects Versions: 2.6.1
>Reporter: Pablo
>Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When setting testOnCreate to true, I would expect for the validation to take
> place when an object is created, but apparently it does not.
> It only seems to be tested on borrow and when idle.
> This has a negative impact, because when new objects get created, since they
> are not tested they appear in the pool as idle.
> I'm trying to determine if the pool's health, but even though the pool
> reports idle objects they are botched instances.
> Also related to this issue, objects aren't actually created upfront. They
> seem to be created on first borrow or when timeBetweenEvictionRunMillis
> elapses.
> Environment (unimportant I think): 1.8.0_191, Ubuntu 18.04
> Test case:
>
> {code:java}
> public static void main(String[] args) throws Exception {
> PooledObjectFactory factory = new
> BasePooledObjectFactory() {
> public String create() throws Exception {
> String s = "Hello";
> System.out.println("Creating " + s);
> return s;
> }
> public void destroyObject(PooledObject p) throws
> Exception {
> System.out.println("Destroying " + p.getObject());
> }
> public boolean validateObject(PooledObject p) {
> System.out.println("Validating " + p.getObject());
> return super.validateObject(p);
> }
> public PooledObject wrap(String obj) {
> return new Wrapper(obj);
> }
> };
> GenericObjectPoolConfig socketPoolConfig = new
> GenericObjectPoolConfig();
> socketPoolConfig.setTestOnCreate(true);
> socketPoolConfig.setTestWhileIdle(false);
> GenericObjectPool objectPool = new
> GenericObjectPool(factory, socketPoolConfig);
> System.out.println("Pool created");
> String f1 = objectPool.borrowObject();
> System.out.println("Borrowed" + f1);
> objectPool.returnObject(f1);
> objectPool.close();
> System.out.println("Done");
> }{code}
>
>
> Expected result:
> {{ Pool created}}
> {{ Creating Hello}}
> {{ *Validating Hello*}}
> {{ Allocating Hello}}
> {{ BorrowedHello}}
> {{ DeallocatingHello}}
> {{ Destroying Hello}}
> {{ Done}}
>
> Actual result:
> {{ Pool created}}
> {{ Creating Hello}}
> {{ Allocating Hello}}
> {{ *Validating Hello*}}
> {{ BorrowedHello}}
> {{ DeallocatingHello}}
> {{ Destroying Hello}}
> {{ Done}}
>
> Or am I misunderstanding something?
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-pool] garydgregory merged pull request #23: Move validation for newly created objects into create(). Fixes POOL-361.
garydgregory merged pull request #23: Move validation for newly created objects into create(). Fixes POOL-361. URL: https://github.com/apache/commons-pool/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] garydgregory merged pull request #21: Adding power support
garydgregory merged pull request #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-statistics] BBenNguyenn closed pull request #22: GSoC Milestone 1: OLS functionality complete
BBenNguyenn closed pull request #22: GSoC Milestone 1: OLS functionality complete URL: https://github.com/apache/commons-statistics/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] coveralls commented on issue #58: RNG-110: Factory methods for Discrete and Continuous distribution samplers
coveralls commented on issue #58: RNG-110: Factory methods for Discrete and Continuous distribution samplers URL: https://github.com/apache/commons-rng/pull/58#issuecomment-513946344 [](https://coveralls.io/builds/24727099) Coverage decreased (-0.001%) to 99.283% when pulling **4505b00448aac063cc3f8e2788236237969d50f8 on aherbert:improvement-RNG-110** into **802b4fa4f921ef10387a7ed5b519b20bdbd1db95 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] aherbert opened a new pull request #58: RNG-110: Factory methods for Discrete and Continuous distribution samplers
aherbert opened a new pull request #58: RNG-110: Factory methods for Discrete and Continuous distribution samplers URL: https://github.com/apache/commons-rng/pull/58 Adds the SharedStateContinuousSampler and SharedStartDiscreteSampler interfaces. Implement the interface for all samplers. Add factory methods using `of` for all samplers. Removes the public constructors for unreleased samplers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] kinow commented on issue #21: Adding power support
kinow commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513936889 >should also be OK with dropping it in the future if it makes the build too time consuming or confusing. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (CSV-249) ArrayIndexOutOfBoundsException when trying to read record written by CSVPrinter using CSVParser with same format
[
https://issues.apache.org/jira/browse/CSV-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jelmer Kuperus updated CSV-249:
---
Summary: ArrayIndexOutOfBoundsException when trying to read record written
by CSVPrinter using CSVParser with same format (was:
ArrayIndexOutOfBoundsException when trying to read record using CSVParser
written by CSVPrinter with same format)
> ArrayIndexOutOfBoundsException when trying to read record written by
> CSVPrinter using CSVParser with same format
>
>
> Key: CSV-249
> URL: https://issues.apache.org/jira/browse/CSV-249
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.5, 1.6, 1.7
>Reporter: Jelmer Kuperus
>Priority: Major
>
> The following code will fail with the exception
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1
> out of bounds for length 1
> {noformat}
> import org.apache.commons.csv.*;
> import java.io.StringReader;
> import java.io.StringWriter;
> import java.util.List;
> public class Poc {
> public static void main(String[] args) throws Exception {
> CSVFormat csvFormat = CSVFormat.DEFAULT
> .withEscape('\\');
> StringWriter stringWriter = new StringWriter();
> CSVPrinter printer = new CSVPrinter(stringWriter, csvFormat);
> printer.printRecord("foo \\", "bar");
> StringReader stringReader = new StringReader(stringWriter.toString());
> CSVParser parser = new CSVParser(stringReader, csvFormat);
> List records = parser.getRecords();
> records.forEach(record -> {
> System.out.println(record.get(0));
> System.out.println(record.get(1));
> });
> }
> }{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (CSV-249) ArrayIndexOutOfBoundsException when trying to read record using CSVParser written by CSVPrinter with same format
Jelmer Kuperus created CSV-249:
--
Summary: ArrayIndexOutOfBoundsException when trying to read record
using CSVParser written by CSVPrinter with same format
Key: CSV-249
URL: https://issues.apache.org/jira/browse/CSV-249
Project: Commons CSV
Issue Type: Bug
Components: Parser
Affects Versions: 1.7, 1.6, 1.5
Reporter: Jelmer Kuperus
The following code will fail with the exception
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1
out of bounds for length 1
{noformat}
import org.apache.commons.csv.*;
import java.io.StringReader;
import java.io.StringWriter;
import java.util.List;
public class Poc {
public static void main(String[] args) throws Exception {
CSVFormat csvFormat = CSVFormat.DEFAULT
.withEscape('\\');
StringWriter stringWriter = new StringWriter();
CSVPrinter printer = new CSVPrinter(stringWriter, csvFormat);
printer.printRecord("foo \\", "bar");
StringReader stringReader = new StringReader(stringWriter.toString());
CSVParser parser = new CSVParser(stringReader, csvFormat);
List records = parser.getRecords();
records.forEach(record -> {
System.out.println(record.get(0));
System.out.println(record.get(1));
});
}
}{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-statistics] BBenNguyenn opened a new pull request #22: GSoC Milestone 1: OLS functionality complete
BBenNguyenn opened a new pull request #22: GSoC Milestone 1: OLS functionality complete URL: https://github.com/apache/commons-statistics/pull/22 **OLS functionality complete:** - converted all math4.linear dependencies to EJML (more complicated and time consuming than expected) -> should be easier now for GLS and logistic since experience was gained while porting OLS - ensured full unit test coverage by porting all old ols tests and adding some new ones - created preliminary RegressionResults interface which essentially holds calculated results of a regression (to be accessed multiple times but calculated once) -> Note: preliminary usage with testSwissFertilityInterfaceFormat() in OLSRegressionTest, more to be added **Known code smell:** math4.stat depedency Dependency usage: StatUtil, SumOfSquares, Variance, SecondMoment **Explanation:** This dependency is temporary until Statistics Descriptive completes array as input methods for above class functionalities which is said to be coming soon. I have considered helping Virendra with it to prevent all old dependencies completely for this milestone but I don't think I should interfere whilst not having completed my component since I would have to learn how to use streams properly as well, and it does sound like Virendra will be done soon anyways. Once Virendra is done, the switch will be swift, since only about 3 methods total use those functionalities. **Known code smell:** Data loading is perhaps not ideal **Explanation:** The current RegressionDataLoader stores the input data within a RegressionRawData object and passes an interface with a getter. This will be improved by using one of the suggested strategies in the ML. Will get to this this week or maybe after port of GLS **Next Objectives:** - Improve data loading strategy -> as suggested, a proper Factory pattern model - Finalize RegressionResults interface for OLS and other regressions to output -> Summary statistics printout method? - Port GLS (expected to not take as long as OLS) - Start LogisticRegression implementation design **PS:** - I've created a UML "UML_current.png" in the README directory if anyone thinks a visual would be helpful. Thank you for your review, -Ben Nguyen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DAEMON-404) Crash: Openjdk not detected from registry
[
https://issues.apache.org/jira/browse/DAEMON-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Lemke updated DAEMON-404:
-
Environment: Windows Server 2016 / 1607
> Crash: Openjdk not detected from registry
> -
>
> Key: DAEMON-404
> URL: https://issues.apache.org/jira/browse/DAEMON-404
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0, 1.2.0
> Environment: Windows Server 2016 / 1607
>Reporter: Michael Lemke
>Priority: Major
>
> I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
> the service crashes with an access violation. With procrun 1.1.0 the service
> doesn't find the dll at all.
> Openjdk is from
> [https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
> and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
> updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
> besides OpenJdk.
> If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
> 2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
> OpenJdk jvm.dll the service starts just fine.
> The situation is the same with the OpenJdk build from AdoptOpenJDK. The keys
> created under {{HKLM\JavaSoft}} are slightly different, though.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-rng] asfgit merged pull request #57: Update travis build
asfgit merged pull request #57: Update travis build URL: https://github.com/apache/commons-rng/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DAEMON-404) Crash: Openjdk not detected from registry
[
https://issues.apache.org/jira/browse/DAEMON-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Lemke updated DAEMON-404:
-
Description:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
besides OpenJdk.
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
The situation is the same with the OpenJdk build from AdoptOpenJDK. The keys
created under {{HKLM\JavaSoft}} are slightly different, though.
was:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
besides OpenJdk.
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
> Crash: Openjdk not detected from registry
> -
>
> Key: DAEMON-404
> URL: https://issues.apache.org/jira/browse/DAEMON-404
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Michael Lemke
>Priority: Major
>
> I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
> the service crashes with an access violation. With procrun 1.1.0 the service
> doesn't find the dll at all.
> Openjdk is from
> [https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
> and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
> updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
> besides OpenJdk.
> If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
> 2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
> OpenJdk jvm.dll the service starts just fine.
> The situation is the same with the OpenJdk build from AdoptOpenJDK. The keys
> created under {{HKLM\JavaSoft}} are slightly different, though.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-rng] coveralls commented on issue #57: Update travis build
coveralls commented on issue #57: Update travis build URL: https://github.com/apache/commons-rng/pull/57#issuecomment-513865035 [](https://coveralls.io/builds/24721436) Coverage decreased (-0.009%) to 99.284% when pulling **802b4fa4f921ef10387a7ed5b519b20bdbd1db95 on aherbert:update-travis-build** into **d85eb21467f3088076dca41752bad4a1d6ae03dc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] aherbert opened a new pull request #57: Update travis build
aherbert opened a new pull request #57: Update travis build URL: https://github.com/apache/commons-rng/pull/57 This is a test PR to see if an updated coverage/travis configuration is OK. The update is to run the default Maven goal. This adds apache-rat:check and javadoc:javadoc goals to those currently tested. It removes the customisation of the jacoco coverage rules so that the commons parent is used. This makes the checks stricter but coverage is high so this is fine. Previously checks were performed in the after_success phase which is allowed to fail. Thus if checks failed then this would be lost and checks had no effect on reporting bad PRs. This updates to run the default maven goal with all checks. If successful then coverage reports will be submitted. A profile has been added to disable checks in the JDK 7 build as this uses plugins that require JDK 8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DAEMON-404) Crash: Openjdk not detected from registry
[
https://issues.apache.org/jira/browse/DAEMON-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Lemke updated DAEMON-404:
-
Description:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
besides OpenJdk.
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
was:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
updates {{PATH}}. No {{JAVA_HOME}} set.
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
> Crash: Openjdk not detected from registry
> -
>
> Key: DAEMON-404
> URL: https://issues.apache.org/jira/browse/DAEMON-404
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Michael Lemke
>Priority: Major
>
> I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
> the service crashes with an access violation. With procrun 1.1.0 the service
> doesn't find the dll at all.
> Openjdk is from
> [https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
> and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
> updates {{PATH}}. No {{JAVA_HOME}} set. There are no other Java installations
> besides OpenJdk.
> If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
> 2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
> OpenJdk jvm.dll the service starts just fine.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-statistics] BBenNguyenn closed pull request #21: Milestone-1 with squashed commits, please see description for more details
BBenNguyenn closed pull request #21: Milestone-1 with squashed commits, please see description for more details URL: https://github.com/apache/commons-statistics/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (DAEMON-404) Crash: Openjdk not detected from registry
[
https://issues.apache.org/jira/browse/DAEMON-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Lemke updated DAEMON-404:
-
Description:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
updates {{PATH}}. No {{JAVA_HOME}} set.
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
was:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}}
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
> Crash: Openjdk not detected from registry
> -
>
> Key: DAEMON-404
> URL: https://issues.apache.org/jira/browse/DAEMON-404
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Michael Lemke
>Priority: Major
>
> I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
> the service crashes with an access violation. With procrun 1.1.0 the service
> doesn't find the dll at all.
> Openjdk is from
> [https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
> and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}} and
> updates {{PATH}}. No {{JAVA_HOME}} set.
> If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
> 2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
> OpenJdk jvm.dll the service starts just fine.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (DAEMON-404) Crash: Openjdk not detected from registry
[
https://issues.apache.org/jira/browse/DAEMON-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Lemke updated DAEMON-404:
-
Description:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
the service crashes with an access violation. With procrun 1.1.0 the service
doesn't find the dll at all.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}}
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
was:
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun the
service crashes with an access violation.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}}
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
> Crash: Openjdk not detected from registry
> -
>
> Key: DAEMON-404
> URL: https://issues.apache.org/jira/browse/DAEMON-404
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Michael Lemke
>Priority: Major
>
> I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun 1.2.0
> the service crashes with an access violation. With procrun 1.1.0 the service
> doesn't find the dll at all.
> Openjdk is from
> [https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
> and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}}
> If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
> 2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
> OpenJdk jvm.dll the service starts just fine.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (DAEMON-404) Crash: Openjdk not detected from registry
Michael Lemke created DAEMON-404:
Summary: Crash: Openjdk not detected from registry
Key: DAEMON-404
URL: https://issues.apache.org/jira/browse/DAEMON-404
Project: Commons Daemon
Issue Type: Bug
Components: Procrun
Affects Versions: 1.2.0, 1.1.0
Reporter: Michael Lemke
I have openjdk 12 installed and {{Jvm=auto}} set. When I start procrun the
service crashes with an access violation.
Openjdk is from
[https://github.com/ojdkbuild/ojdkbuild/releases/download/12.0.1-1/java-12-openjdk-12.0.1.12-1.windows.ojdkbuild.x86_64.msi]
and installed such that it only sets the keys under {{HKLM\JavaSoft\JDK}}
If I change {{HKLM\SOFTWARE\WOW6432Node\Apache Software Foundation\Procrun
2.0\servicename\Parameters\Java}} from {{auto}} to the actual path of the
OpenJdk jvm.dll the service starts just fine.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-rng] coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators.
coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#issuecomment-513577053 [](https://coveralls.io/builds/24717725) Coverage increased (+0.2%) to 99.308% when pulling **b8dcbeda927faef769eb6d35eeaaa03050607b77 on AbhishekSinghDhadwal:feature-RNG-84** into **e2904e8ba1d21a6fc6c0b3635cad902bc78a7741 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (GEOMETRY-59) unexpected output from PolyhedronsSet::checkPoint
[ https://issues.apache.org/jira/browse/GEOMETRY-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890163#comment-16890163 ] Gilles commented on GEOMETRY-59: Hi [~bonastos]. Thanks for your help in this investigation. Just a nit-pick remark: Please follow the project's code convention in your PRs. It will make merging more expedite once you and [~mattjuntunen] agree on the fix. > unexpected output from PolyhedronsSet::checkPoint > - > > Key: GEOMETRY-59 > URL: https://issues.apache.org/jira/browse/GEOMETRY-59 > Project: Apache Commons Geometry > Issue Type: Bug > Components: Euclidean 3D >Reporter: Dirk Bonekämper >Priority: Major > Labels: pull-request-available > Attachments: InsideProblemTest.java > > Time Spent: 10m > Remaining Estimate: 0h > > In my project I'm working with 3D Regions modeled as prisms. The base > polygons are mostly concave. I got wrong results and boiled it down to the > attached unit test. It creates a prism with a concave base. A point that is > above the prism gets classified as INSIDE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [commons-rng] coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators.
coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#issuecomment-513577053 [](https://coveralls.io/builds/24716498) Coverage increased (+0.2%) to 99.308% when pulling **078df05f0556209e0380698d61b5aeb7adc08db5 on AbhishekSinghDhadwal:feature-RNG-84** into **e2904e8ba1d21a6fc6c0b3635cad902bc78a7741 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] garydgregory commented on issue #21: Adding power support
garydgregory commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513764742 Based on 'you don't know if it is broken until you test it', I am OK with adding this now but we should also be OK with dropping it in the future if it makes the build too time consuming or confusing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] kinow commented on issue #21: Adding power support
kinow commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513751254 Not sure if native code is the only reason for this kind of testing, but that's a good point. I remember seeing issues with different vendors (e.g. IBM) that ended up being fixed in the code, but I don't believe it involved native calls. Though, I remember even more issues with timezone, and we test only 1 timezone in Travis (even in lang that does/or did some date calculation). So if others prefer to keep the scope on 1 JVM only, all good for me :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] kinow edited a comment on issue #21: Adding power support
kinow edited a comment on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513751254 Not sure if native code is the only reason for this kind of testing, but that's a good point. I remember seeing issues with different vendors (e.g. IBM), but I don't believe it involved native calls. Though, I remember even more issues with timezone, and we test only 1 timezone in Travis (even in lang that does/or did some date calculation). So if others prefer to keep the scope on 1 JVM only, all good for me :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] aherbert commented on issue #21: Adding power support
aherbert commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513747887 I made a similar comment on another PR for PPC support. I see the point if the project is using non-Java code such as native JNI calls. If it is pure Java then this amounts to testing the JVM. This is a vendor challenge and not in the scope of commons. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] kinow commented on issue #21: Adding power support
kinow commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513746106 >Why do we need this? I assumed @ghatwala wants to ensure commons-pool has been tested on powerpc arch. If it increases the build time too much, perhaps we can limit to a single configuration (java LTS + powerpc), or if it becomes unstable we can mark as failures ignored, but just report to users whether that works or not? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] garydgregory commented on issue #21: Adding power support
garydgregory commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513745247 Why do we need this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] coveralls edited a comment on issue #21: Adding power support
coveralls edited a comment on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-503885206 [](https://coveralls.io/builds/24714030) Coverage increased (+0.03%) to 85.246% when pulling **7a609d2e9ed9c0794963cceb8c83d391e81aea3d on ghatwala:master** into **ef7364f803942529c7694372d4cf5d3179a08a18 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] coveralls edited a comment on issue #21: Adding power support
coveralls edited a comment on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-503885206 [](https://coveralls.io/builds/24713880) Coverage decreased (-0.03%) to 85.179% when pulling **7a609d2e9ed9c0794963cceb8c83d391e81aea3d on ghatwala:master** into **ef7364f803942529c7694372d4cf5d3179a08a18 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] ghatwala commented on issue #21: Adding power support
ghatwala commented on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-513737998 @kinow - have ensured power builds on openjdk8 env only as other jdk env's are not available on travis/power. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] coveralls edited a comment on issue #21: Adding power support
coveralls edited a comment on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-503885206 [](https://coveralls.io/builds/24713776) Coverage decreased (-0.1%) to 85.111% when pulling **7a609d2e9ed9c0794963cceb8c83d391e81aea3d on ghatwala:master** into **ef7364f803942529c7694372d4cf5d3179a08a18 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-pool] coveralls edited a comment on issue #21: Adding power support
coveralls edited a comment on issue #21: Adding power support URL: https://github.com/apache/commons-pool/pull/21#issuecomment-503885206 [](https://coveralls.io/builds/24713262) Coverage increased (+0.1%) to 85.314% when pulling **f813697a452a8ea046ac8cc5c755bfdaee29d48c on ghatwala:master** into **ef7364f803942529c7694372d4cf5d3179a08a18 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (DAEMON-403) umask log is wrong
[
https://issues.apache.org/jira/browse/DAEMON-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DAEMON-403.
Resolution: Fixed
Fix Version/s: 1.2.1
Thanks for reporting this. I have applied your proposed fix to master and it
will be in the next release.
> umask log is wrong
> --
>
> Key: DAEMON-403
> URL: https://issues.apache.org/jira/browse/DAEMON-403
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
>Affects Versions: 1.1.0, 1.2.0
>Reporter: Charles
>Priority: Minor
> Labels: usability
> Fix For: 1.2.1
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> The following log is wrong in jsvc-unix.c since the following bug fix has
> been fixed:
> fixed: https://issues.apache.org/jira/browse/DAEMON-318
> l. 1271 log_debug("Switching umask back to %03o from %03o", envmask,
> args->umask);
>
> Indeed the umask is never set back to the initial umask.
> The log may show something like this instead:
> l. 1271 log_debug("Switching umask from %03o to %03o", envmask, args->umask);
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#discussion_r305746352 ## File path: commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java ## @@ -48,7 +50,7 @@ import org.apache.commons.rng.core.source64.XoShiRo256StarStar; import org.apache.commons.rng.core.source64.XoShiRo512Plus; import org.apache.commons.rng.core.source64.XoShiRo512StarStar; - Review comment: Sir, could you elaborate on that change ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#discussion_r305746292 ## File path: commons-rng-core/src/main/java/org/apache/commons/rng/core/source32/PcgXshRr32.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.rng.core.source32; + +/** + * XSH-RR: An xorshift mixes some high-order bits down, Review comment: Done. Kindly check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305746408
##
File path:
commons-rng-core/src/test/java/org/apache/commons/rng/core/source32/PcgXshRr32Test.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.rng.core.source32;
+
+import org.apache.commons.rng.core.RandomAssert;
+import org.junit.Test;
+
+public class PcgXshRr32Test {
+@Test
+/*
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#discussion_r305746064 ## File path: commons-rng-core/src/main/java/org/apache/commons/rng/core/source32/PcgXshRs32.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.rng.core.source32; + +/** + * XSH RS -- high xorshift, followed by a random shift. + * State size is 64 bits and the period is 264. + * @see http://www.pcg-random.org/";> Review comment: Solved. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305745924
##
File path:
commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/PcgRxsMXs64.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rng.core.source64;
+
+import org.apache.commons.rng.core.util.NumberFactory;
+/**
+ * RXS M XS -- random xorshift, mcg multiply, fixed xorshift.
+ * State size is 64 bits and the period is 264.
+ * @see http://www.pcg-random.org/";>
+ * PCG, A Family of Better Random Number Generators
+ * @since 1.3
+ */
+public class PcgRxsMXs64 extends LongProvider {
+
+/** Size of the state array. */
+private static final int SEED_SIZE = 2;
+
+/** Displays the current state. */
+private long state;
+
+/** Used as a part of the LCG. */
+private long increment;
+
+/**
+ * Creates a new instance.
+ *
+ * @param seed Initial seed.
+ * If the length is larger than 2, only the first 2 elements will
+ * be used; if smaller, the remaining elements will be automatically set.
+ */
+public PcgRxsMXs64(long[] seed) {
+if (seed.length < SEED_SIZE) {
+final long[] tmp = new long[SEED_SIZE];
+fillState(tmp, seed);
+setSeedInternal(tmp);
+} else {
+setSeedInternal(seed);
+}
+}
+
+/**
+ * Modifies input parameters into current state.
+ * @param seed the new seed.
+ */
+private void setSeedInternal(long[] seed) {
+this.increment = (seed[1] << 1) | 1;
+this.state = bump(seed[0] + this.increment);
+}
+
+/**
+ * Provides the next state of the LCG.
+ * @param input - The previous state of the generator.
+ * @return Next state of the LCG.
+ */
+private long bump(long input) {
+return input * 6364136223846793005L + increment;
+}
+
+/** {@inheritDoc} */
+@Override
+public long next() {
+final long x = state;
+state = bump(state);
+final long word = ((x >>> ((x >>> 59) + 5)) ^ x) *
-5840758589994634535L;
+return (word >>> 43) ^ word;
+}
+
+/** {@inheritDoc} */
+@Override
+protected byte[] getStateInternal() {
+return composeStateInternal(NumberFactory.makeByteArray(
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305745830
##
File path:
commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/PcgRxsMXs64Test.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.rng.core.source64;
+
+import org.apache.commons.rng.core.RandomAssert;
+import org.junit.Test;
+
+public class PcgRxsMXs64Test {
+@Test
+/*
+ * Tested with respect to pcg_engines::setseq_rxs_m_xs_64_64 of the C++
implementation.
+ * See : http://www.pcg-random.org/download.html#cpp-implementation
+ */
+public void testReferenceCode() {
+final long[] expectedSequence = {
+0xc147f2291fa40ccfL, 0x8edbcbf8a5f49877L, 0x61e05a1d5213f0b4L,
0xc039f9369032e638L,
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305745069
##
File path:
commons-rng-core/src/main/java/org/apache/commons/rng/core/source32/AbstractPcg6432.java
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rng.core.source32;
+
+import org.apache.commons.rng.core.util.NumberFactory;
+/**
+ * This class aids in implementation of the PCG suite of generators, a family
of
+ * simple fast space-efficient statistically good algorithms for random number
generation.
+ * @see http://www.pcg-random.org/";>
+ * PCG, A Family of Better Random Number Generators
+ * @since 1.3
+ */
+abstract class AbstractPcg6432 extends IntProvider {
+/** Size of the state array. */
+private static final int SEED_SIZE = 2;
+
+/** Displays the current state. */
+private long state;
+
+/** Used as a part of the LCG. */
+private long increment;
+
+/**
+ * Creates a new instance.
+ *
+ * @param seed Initial seed.
+ * If the length is larger than 2, only the first 2 elements will
+ * be used; if smaller, the remaining elements will be automatically set.
+ */
+AbstractPcg6432(long[] seed) {
+if (seed.length < SEED_SIZE) {
+final long[] tmp = new long[SEED_SIZE];
+fillState(tmp, seed);
+setSeedInternal(tmp);
+} else {
+setSeedInternal(seed);
+}
+}
+
+/**
+ * Modifies input parameters into current state.
+ * @param seed the new seed.
+ */
+private void setSeedInternal(long[] seed) {
+this.increment = (seed[1] << 1) | 1;
+this.state = bump(seed[0] + this.increment);
+}
+
+/**
+ * Provides the next state of the LCG.
+ * @param input - The previous state of the generator.
+ * @return Next state of the LCG.
+ */
+private long bump(long input) {
+return input * 6364136223846793005L + increment;
+}
+
+/** {@inheritDoc} */
+@Override
+public int next() {
+final long x = state;
+state = bump(state);
+return transform(x);
+}
+
+/**
+ * The transformation function shall vary with respect to different
generators.
+ * @param x The input.
+ * @return The output of the generator.
+ */
+protected abstract int transform(long x);
+
+/** {@inheritDoc} */
+@Override
+protected byte[] getStateInternal() {
+return composeStateInternal(NumberFactory.makeByteArray(
+new long[] {state, increment >>> 1}),
+super.getStateInternal());
+}
+
+/** {@inheritDoc} */
+@Override
+protected void setStateInternal(byte[] s) {
+final byte[][] c = splitStateInternal(s, SEED_SIZE * 8);
+long[] tempseed;
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305744916
##
File path:
commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
##
@@ -109,6 +114,7 @@
add(LIST64, new XoShiRo256StarStar(new long[] {g.nextLong(),
g.nextLong(), g.nextLong(), g.nextLong()}));
add(LIST64, new XoShiRo512Plus(new long[] {g.nextLong(),
g.nextLong(), g.nextLong(), g.nextLong()}));
add(LIST64, new XoShiRo512StarStar(new long[] {g.nextLong(),
g.nextLong(), g.nextLong(), g.nextLong()}));
+add(LIST64, new PcgRxsMXs64(new long[] {g.nextLong(),
g.nextLong()}));
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305744974
##
File path:
commons-rng-core/src/main/java/org/apache/commons/rng/core/source32/PcgXshRs32.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rng.core.source32;
+
+/**
+ * XSH RS -- high xorshift, followed by a random shift.
+ * State size is 64 bits and the period is 264.
+ * @see http://www.pcg-random.org/";>
+ * PCG, A Family of Better Random Number Generators
+ * @since 1.3
+ */
+public class PcgXshRs32 extends AbstractPcg6432 {
+/**
+ * Creates an instance with the given {@code seed}.
+ * @param seed Initial seed.
+ */
+public PcgXshRs32(long[]seed) {
Review comment:
Solved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added members of the PCG suite of generators.
AbhishekSinghDhadwal commented on a change in pull request #56: RNG: 84 - Added
members of the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305744742
##
File path:
commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
##
@@ -94,6 +97,8 @@
add(LIST32, new XoRoShiRo64StarStar(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
add(LIST32, new XoShiRo128Plus(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
add(LIST32, new XoShiRo128StarStar(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
+add(LIST32, new PcgXshRr32(new long[] {g.nextLong(),
g.nextLong()}));
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-rng] coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators.
coveralls edited a comment on issue #56: RNG: 84 - Added members of the PCG suite of generators. URL: https://github.com/apache/commons-rng/pull/56#issuecomment-513577053 [](https://coveralls.io/builds/24712379) Coverage increased (+0.2%) to 99.313% when pulling **bd456347aacb1a462f67dca37f6751bc41604b6b on AbhishekSinghDhadwal:feature-RNG-84** into **e2904e8ba1d21a6fc6c0b3635cad902bc78a7741 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (GEOMETRY-59) unexpected output from PolyhedronsSet::checkPoint
[ https://issues.apache.org/jira/browse/GEOMETRY-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889968#comment-16889968 ] Dirk Bonekämper commented on GEOMETRY-59: - Hi [~mattjuntunen]! Both of our approaches rely on the fact that a facet is a simple polygon in a plane. In a plane, the polygon has a well defined orientation. We both try to ensure that plane representing the facet has the same orientation as the facet. You do it by first computing a normal to the plane. Then you compute the signed area of the polygon, where the sign represents the orientation. Then you flip the normal if necessary and construct boundary plane. I try to select a triplet of facet vertices that are guaranteed to have the same orientation as the facet, Then I construct the boundary plane using that triplet. How do theses approaches compare? Mine might take less computation. (Although you would really need to measure the difference ...) Your approach is (IMO) more obvious and thus easier to understand for someone looking at the code. Btw, I wonder if your algorithm could be simplified by summing the cross products of all adjacent edges. The resulting vector is perpendicular to the plane and has a magnitude of twice the signed area. ( [http://mathworld.wolfram.com/PolygonArea.html] ) > unexpected output from PolyhedronsSet::checkPoint > - > > Key: GEOMETRY-59 > URL: https://issues.apache.org/jira/browse/GEOMETRY-59 > Project: Apache Commons Geometry > Issue Type: Bug > Components: Euclidean 3D >Reporter: Dirk Bonekämper >Priority: Major > Labels: pull-request-available > Attachments: InsideProblemTest.java > > Time Spent: 10m > Remaining Estimate: 0h > > In my project I'm working with 3D Regions modeled as prisms. The base > polygons are mostly concave. I got wrong results and boiled it down to the > attached unit test. It creates a prism with a concave base. A point that is > above the prism gets classified as INSIDE. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
