[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=622857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622857
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 05:27
Start Date: 15/Jul/21 05:27
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637226
[](https://coveralls.io/builds/41387442)
Coverage decreased (-0.2%) to 76.575% when pulling
**d3ffa1e93188948d4b9f721318a382a7819475cf on kinow:IMAGING-159-1** into
**a87b545e1019b43bfbe31fa5df3a4f3095a8b438 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622857)
Time Spent: 4h 20m (was: 4h 10m)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] coveralls edited a comment on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
coveralls edited a comment on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637226 [](https://coveralls.io/builds/41387442) Coverage decreased (-0.2%) to 76.575% when pulling **d3ffa1e93188948d4b9f721318a382a7819475cf on kinow:IMAGING-159-1** into **a87b545e1019b43bfbe31fa5df3a4f3095a8b438 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=622856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622856
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 05:24
Start Date: 15/Jul/21 05:24
Worklog Time Spent: 10m
Work Description: kinow commented on a change in pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#discussion_r670141981
##
File path: src/main/java/org/apache/commons/imaging/Imaging.java
##
@@ -735,32 +737,35 @@ public static ImageInfo getImageInfo(final File file)
throws ImageReadException,
return getImageInfo(file, null);
}
-private static ImageInfo getImageInfo(final ByteSource byteSource, final
Map params)
-throws ImageReadException, IOException {
-return getImageParser(byteSource).getImageInfo(byteSource, params);
+// See getImageParser
+@SuppressWarnings("unchecked")
+private static ImageInfo getImageInfo(final ByteSource byteSource, final
ImagingParameters params) throws ImageReadException, IOException {
+return Imaging.getImageParser(byteSource).getImageInfo(byteSource,
params);
}
-private static ImageParser getImageParser(final ByteSource byteSource)
-throws ImageReadException, IOException {
+// TODO: We have no way of knowing whether the returned ImageParser will
accept the ImagingParameters,
+// even if we specified generic types for the static methods.
Review comment:
Not sure if there's a better way of changing this method...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622856)
Time Spent: 4h 10m (was: 4h)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] kinow commented on a change in pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
kinow commented on a change in pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#discussion_r670141981
##
File path: src/main/java/org/apache/commons/imaging/Imaging.java
##
@@ -735,32 +737,35 @@ public static ImageInfo getImageInfo(final File file)
throws ImageReadException,
return getImageInfo(file, null);
}
-private static ImageInfo getImageInfo(final ByteSource byteSource, final
Map params)
-throws ImageReadException, IOException {
-return getImageParser(byteSource).getImageInfo(byteSource, params);
+// See getImageParser
+@SuppressWarnings("unchecked")
+private static ImageInfo getImageInfo(final ByteSource byteSource, final
ImagingParameters params) throws ImageReadException, IOException {
+return Imaging.getImageParser(byteSource).getImageInfo(byteSource,
params);
}
-private static ImageParser getImageParser(final ByteSource byteSource)
-throws ImageReadException, IOException {
+// TODO: We have no way of knowing whether the returned ImageParser will
accept the ImagingParameters,
+// even if we specified generic types for the static methods.
Review comment:
Not sure if there's a better way of changing this method...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=622827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622827
]
ASF GitHub Bot logged work on CSV-284:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 01:46
Start Date: 15/Jul/21 01:46
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#issuecomment-880324653
[](https://coveralls.io/builds/41384366)
Coverage remained the same at 98.31% when pulling
**77896a74c4dace7deabfb056b01cc0f0f9bdc858 on belugabehr:CSV-284** into
**a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622827)
Time Spent: 40m (was: 0.5h)
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] coveralls commented on pull request #168: CSV-284: Formalize PerformanceTest
coveralls commented on pull request #168: URL: https://github.com/apache/commons-csv/pull/168#issuecomment-880324653 [](https://coveralls.io/builds/41384366) Coverage remained the same at 98.31% when pulling **77896a74c4dace7deabfb056b01cc0f0f9bdc858 on belugabehr:CSV-284** into **a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=622821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622821
]
ASF GitHub Bot logged work on CSV-284:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 01:27
Start Date: 15/Jul/21 01:27
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670058570
##
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean
traverseColumns) throws IO
return recordCount;
}
-private void println(final String s) {
-System.out.println(s);
-}
-
-private long readAll(final BufferedReader in) throws IOException {
Review comment:
You got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622821)
Time Spent: 0.5h (was: 20m)
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] belugabehr commented on a change in pull request #168: CSV-284: Formalize PerformanceTest
belugabehr commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670058570
##
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean
traverseColumns) throws IO
return recordCount;
}
-private void println(final String s) {
-System.out.println(s);
-}
-
-private long readAll(final BufferedReader in) throws IOException {
Review comment:
You got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=622816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622816
]
ASF GitHub Bot logged work on CSV-284:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 01:19
Start Date: 15/Jul/21 01:19
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670056091
##
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean
traverseColumns) throws IO
return recordCount;
}
-private void println(final String s) {
-System.out.println(s);
-}
-
-private long readAll(final BufferedReader in) throws IOException {
Review comment:
I disagree here, keep this as is so it can be commented out or changed
easily when testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622816)
Time Spent: 20m (was: 10m)
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] garydgregory commented on a change in pull request #168: CSV-284: Formalize PerformanceTest
garydgregory commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670056091
##
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean
traverseColumns) throws IO
return recordCount;
}
-private void println(final String s) {
-System.out.println(s);
-}
-
-private long readAll(final BufferedReader in) throws IOException {
Review comment:
I disagree here, keep this as is so it can be commented out or changed
easily when testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380927#comment-17380927
]
Gary D. Gregory commented on CSV-284:
-
Note that this class is NOT meant to be run as part of a normal build, it must
be only invoked when the benchmark profile is enabled, otherwise, the build
would be take too long to complete.
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-284) Formalize PerformanceTest
[
https://issues.apache.org/jira/browse/CSV-284?focusedWorklogId=622815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622815
]
ASF GitHub Bot logged work on CSV-284:
--
Author: ASF GitHub Bot
Created on: 15/Jul/21 01:16
Start Date: 15/Jul/21 01:16
Worklog Time Spent: 10m
Work Description: belugabehr opened a new pull request #168:
URL: https://github.com/apache/commons-csv/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622815)
Remaining Estimate: 0h
Time Spent: 10m
> Formalize PerformanceTest
> -
>
> Key: CSV-284
> URL: https://issues.apache.org/jira/browse/CSV-284
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
> documented and does not work without some hand-edits.
> Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] belugabehr opened a new pull request #168: CSV-284: Formalize PerformanceTest
belugabehr opened a new pull request #168: URL: https://github.com/apache/commons-csv/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CSV-284) Formalize PerformanceTest
David Mollitor created CSV-284:
--
Summary: Formalize PerformanceTest
Key: CSV-284
URL: https://issues.apache.org/jira/browse/CSV-284
Project: Commons CSV
Issue Type: Improvement
Reporter: David Mollitor
There is a class {{org.apache.commons.csv.perf.PerformanceTest}} which is not
documented and does not work without some hand-edits.
Re-enable this test, clean it up, and document it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-validator] homebeaver opened a new pull request #60: add SIRENE Validator: SIREN and SIRET
homebeaver opened a new pull request #60: URL: https://github.com/apache/commons-validator/pull/60 SIREN and SIRET codes are used by French organisations and are maintained by INSEE. The check digit uses the Luhn algorithm. The International Code Designator, ICD :for SIRENE is 0002. As SIREN is part of SIRET, SIRET Ids have two check digits. regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1657) DiffBuilder: Type constraint for method append(..., DiffResult) too strict
[
https://issues.apache.org/jira/browse/LANG-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380903#comment-17380903
]
Andrew Thomas commented on LANG-1657:
-
Can someone confirm if this needs to be worked on? If no one has taken it up, I
can open a PR based on the proposed solution.
> DiffBuilder: Type constraint for method append(..., DiffResult) too strict
> --
>
> Key: LANG-1657
> URL: https://issues.apache.org/jira/browse/LANG-1657
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.builder.*
>Affects Versions: 3.12.0
>Reporter: Matthias Welz
>Priority: Major
>
> The DiffBuilder has a method append which allows to append an existing
> DiffResult for a property. The example illustrates this the following way:
>
> {code:java}
> public class Person implements Diffable {
>String name;
>Address address; // implements Diffable
>...
>public DiffResult diff(Person obj) {
> return new DiffBuilder(this, obj, ToStringStyle.SHORT_PREFIX_STYLE)
>.append("name", this.name, obj.name)
>.append("address", this.address.diff(obj.address))
>.build();
>}
> }
> {code}
>
> However, the signature of the method was recently changed to:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> As a consequence, the example code won't compile anymore when using generics
> because the a _DiffBuilder_ will only accept _DiffResult_ but
> not _DiffResult_ for its append method.
> The signature should be:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> or:
> {code:java}
> public DiffBuilder append(final String fieldName, final DiffResult
> diffResult)
> {code}
> instead.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (LANG-1462) After version Commons-lang3.4 DateFormatUtils has a bug
[
https://issues.apache.org/jira/browse/LANG-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380901#comment-17380901
]
Andrew Thomas commented on LANG-1462:
-
I see that this has been open for some time. Is this a bug or a documentation
issue? Either way I can open a PR since the fix (if it's a bug) seems to be
documented above.
> After version Commons-lang3.4 DateFormatUtils has a bug
> ---
>
> Key: LANG-1462
> URL: https://issues.apache.org/jira/browse/LANG-1462
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.time.*
>Affects Versions: 3.5, 3.6, 3.7, 3.8, 3.9, 3.8.1
>Reporter: Lijun Liang
>Priority: Critical
>
> The code is as follows ：
> Calendar cale = Calendar.getInstance();
> System.out.println("Old time is " + DateFormatUtils.format(cale,
> "MMddHHmmss"));
> cale.setTimeZone(TimeZone.getTimeZone("JST"));
> System.out.println("New time is " + DateFormatUtils.format(cale,
> "MMddHHmmss"));
>
> The results of commons-lang3 3.4：
> Old time is 20190605144536
> New time is 20190605154536
>
> The results of the version after commons-lang3 3.4:
> Old time is 20190605144536
> New time is 20190605144536
>
> We found that the time zone setting was invalidated when it was formatted
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-rng] coveralls commented on pull request #94: RNG-137: Add StableSampler
coveralls commented on pull request #94: URL: https://github.com/apache/commons-rng/pull/94#issuecomment-880278627 [](https://coveralls.io/builds/41381738) Coverage increased (+0.03%) to 99.603% when pulling **28dea5b26b1d3d5b9f40c164d72ed1ea5ba373fe on aherbert:feature-RNG-137** into **897bbc93399105d1856d71400255fb40f910e864 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=622790=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622790
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 14/Jul/21 23:35
Start Date: 14/Jul/21 23:35
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#issuecomment-718114531
[](https://coveralls.io/builds/41381674)
Coverage increased (+0.01%) to 98.32% when pulling
**0ee99c08e17d9974195159208ebc99d9a97bfcd5 on king-tyler:CSV-265** into
**a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622790)
Time Spent: 1.5h (was: 1h 20m)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] coveralls edited a comment on pull request #120: [CSV-265] Update buffer position when reading line comment
coveralls edited a comment on pull request #120: URL: https://github.com/apache/commons-csv/pull/120#issuecomment-718114531 [](https://coveralls.io/builds/41381674) Coverage increased (+0.01%) to 98.32% when pulling **0ee99c08e17d9974195159208ebc99d9a97bfcd5 on king-tyler:CSV-265** into **a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CODEC-302) MurmurHash2.hash32 can return negative
Iris Scholer created CODEC-302: -- Summary: MurmurHash2.hash32 can return negative Key: CODEC-302 URL: https://issues.apache.org/jira/browse/CODEC-302 Project: Commons Codec Issue Type: Bug Affects Versions: 1.15 Reporter: Iris Scholer When running hash32, many values return a negative hash. Since the original implementation used unsigned values, this is unintended behavior and breaks compatibility with other implementations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (COMPRESS-582) Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
[
https://issues.apache.org/jira/browse/COMPRESS-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380873#comment-17380873
]
Gary D. Gregory edited comment on COMPRESS-582 at 7/14/21, 9:45 PM:
Feel free to provide a PR on GitHub ;) I see the current version of asm is 9.2
which I think we should target as opposed to whatever antique version we
inherited from the Harmony port.
was (Author: garydgregory):
Feel free to provide a PR on GitHub ;-) I see the current version of asm is 9.2
which I think we should target as opposed to whatever antique version we
inherited from the Harmon port.
> Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
> --
>
> Key: COMPRESS-582
> URL: https://issues.apache.org/jira/browse/COMPRESS-582
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.21
>Reporter: Alex Landau
>Priority: Major
>
> I just tried to upgrade an existing codebase to commons-compress 1.21 (from
> 1.20, which was working correctly) and encountered the following error in
> code trying to use the Pack200CompressorOutputStream:
> {code:java}
> java.lang.IncompatibleClassChangeError: class
> org.apache.commons.compress.harmony.pack200.Segment can not implement
> org.objectweb.asm.ClassVisitor, because it is not an interface
> (org.objectweb.asm.ClassVisitor is in unnamed module of loader 'app')
> {code}
> The Segment class {{implements}} rather than {{extends}} ClassVisitor. It
> looks like commons-compress is built against asm 3.2. Per
> [https://asm.ow2.io/versions.html], ClassVisitor was converted from an
> interface to an abstract class in asm 4.0, which was released in 2011, "in
> order to ensure backward binary compatibility in future ASM versions". To be
> clear, our project needs a more recent asm version on the classpath to
> support other libraries.
> I have a repro of the error here, in case it helps:
> [https://github.com/AlexLandau/commons-compress-asm-error]
> I want to add that I appreciate the effort you are making to support pack200
> in a way that will outlast the JDK's native support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=622744=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622744
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 14/Jul/21 21:39
Start Date: 14/Jul/21 21:39
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#issuecomment-718114531
[](https://coveralls.io/builds/41376277)
Coverage increased (+0.01%) to 98.32% when pulling
**87ac79fef0ba6cd33baad4bad83d05108efe222d on king-tyler:CSV-265** into
**a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622744)
Time Spent: 1h 20m (was: 1h 10m)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] coveralls edited a comment on pull request #120: [CSV-265] Update buffer position when reading line comment
coveralls edited a comment on pull request #120: URL: https://github.com/apache/commons-csv/pull/120#issuecomment-718114531 [](https://coveralls.io/builds/41376277) Coverage increased (+0.01%) to 98.32% when pulling **87ac79fef0ba6cd33baad4bad83d05108efe222d on king-tyler:CSV-265** into **a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-582) Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
[
https://issues.apache.org/jira/browse/COMPRESS-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380873#comment-17380873
]
Gary D. Gregory commented on COMPRESS-582:
--
Feel free to provide a PR on GitHub ;-) I see the current version of asm is 9.2
which I think we should target as opposed to whatever antique version we
inherited from the Harmon port.
> Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
> --
>
> Key: COMPRESS-582
> URL: https://issues.apache.org/jira/browse/COMPRESS-582
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.21
>Reporter: Alex Landau
>Priority: Major
>
> I just tried to upgrade an existing codebase to commons-compress 1.21 (from
> 1.20, which was working correctly) and encountered the following error in
> code trying to use the Pack200CompressorOutputStream:
> {code:java}
> java.lang.IncompatibleClassChangeError: class
> org.apache.commons.compress.harmony.pack200.Segment can not implement
> org.objectweb.asm.ClassVisitor, because it is not an interface
> (org.objectweb.asm.ClassVisitor is in unnamed module of loader 'app')
> {code}
> The Segment class {{implements}} rather than {{extends}} ClassVisitor. It
> looks like commons-compress is built against asm 3.2. Per
> [https://asm.ow2.io/versions.html], ClassVisitor was converted from an
> interface to an abstract class in asm 4.0, which was released in 2011, "in
> order to ensure backward binary compatibility in future ASM versions". To be
> clear, our project needs a more recent asm version on the classpath to
> support other libraries.
> I have a repro of the error here, in case it helps:
> [https://github.com/AlexLandau/commons-compress-asm-error]
> I want to add that I appreciate the effort you are making to support pack200
> in a way that will outlast the JDK's native support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-582) Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
Alex Landau created COMPRESS-582:
Summary: Pack200CompressorOutputStream fails at runtime in 1.21 if
ASM 4.0+ is used
Key: COMPRESS-582
URL: https://issues.apache.org/jira/browse/COMPRESS-582
Project: Commons Compress
Issue Type: Bug
Affects Versions: 1.21
Reporter: Alex Landau
I just tried to upgrade an existing codebase to commons-compress 1.21 (from
1.20, which was working correctly) and encountered the following error in code
trying to use the Pack200CompressorOutputStream:
{code:java}
java.lang.IncompatibleClassChangeError: class
org.apache.commons.compress.harmony.pack200.Segment can not implement
org.objectweb.asm.ClassVisitor, because it is not an interface
(org.objectweb.asm.ClassVisitor is in unnamed module of loader 'app')
{code}
The Segment class {{implements}} rather than {{extends}} ClassVisitor. It looks
like commons-compress is built against asm 3.2. Per
[https://asm.ow2.io/versions.html], ClassVisitor was converted from an
interface to an abstract class in asm 4.0, which was released in 2011, "in
order to ensure backward binary compatibility in future ASM versions". To be
clear, our project needs a more recent asm version on the classpath to support
other libraries.
I have a repro of the error here, in case it helps:
[https://github.com/AlexLandau/commons-compress-asm-error]
I want to add that I appreciate the effort you are making to support pack200 in
a way that will outlast the JDK's native support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-rng] aherbert closed pull request #93: RNG-151: Modified ziggurat samplers for exponential and Gaussian
aherbert closed pull request #93: URL: https://github.com/apache/commons-rng/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rng] aherbert commented on pull request #93: RNG-151: Modified ziggurat samplers for exponential and Gaussian
aherbert commented on pull request #93: URL: https://github.com/apache/commons-rng/pull/93#issuecomment-880204385 Added to master in commit 6525ccf566ca2f4d13858b9f0fc4583762e9ad68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rng] aherbert opened a new pull request #94: RNG-137: Add StableSampler
aherbert opened a new pull request #94: URL: https://github.com/apache/commons-rng/pull/94 Re-implemented the StableRandomGenerator from Commons Math random package. Uses a translation of the Fortran RSTAB program from Chambers et al (1976). Add a JMH benchmark to demonstrate speed of the RSTAB routine verses a alternative implementation that is discontinuous as alpha approaches 1. The sampler checks the distribution support and corrects invalid samples. Uses a fast tan(x) / x function approximation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=622727=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622727
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 14/Jul/21 20:46
Start Date: 14/Jul/21 20:46
Worklog Time Spent: 10m
Work Description: king-tyler commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r669941767
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+CSVFormat csvFormat =
CSVFormat.DEFAULT.withCommentMarker('#').withFirstRecordAsHeader();
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622727)
Time Spent: 1h 10m (was: 1h)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] king-tyler commented on a change in pull request #120: [CSV-265] Update buffer position when reading line comment
king-tyler commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r669941767
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+CSVFormat csvFormat =
CSVFormat.DEFAULT.withCommentMarker('#').withFirstRecordAsHeader();
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380847#comment-17380847
]
Alex Herbert commented on STATISTICS-31:
The changes look good so far.
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-bcel] markro49 opened a new pull request #97: improve readability of StackMap toString() output
markro49 opened a new pull request #97: URL: https://github.com/apache/commons-bcel/pull/97 include running byte code offset; output one StackMap per line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380823#comment-17380823
]
Benjamin W Trent commented on STATISTICS-31:
Yes, that is what I am suggesting.
I have already began poking around here:
[https://github.com/benwtrent/commons-statistics/pull/1/files]
I am going to add more tests that exploit the `1-cdf` issue and tweak the
overrides to be more accurate.
Obviously, this is a draft and a WIP. Once ready, I will open a PR against the
repo's trunk.
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380794#comment-17380794
]
Alex Herbert edited comment on STATISTICS-31 at 7/14/21, 6:31 PM:
--
Support can be added to the ContinuousDistribution interface using a default
method:
{code:java}
/**
* For a random variable {@code X} whose values are distributed according
* to this distribution, this method returns {@code P(X >= x)}.
* In other words, this method represents the complementary cumulative
distribution
* function for this distribution, also known as the survival function or
* reliability function.
*
* @param x Point at which the complementary CDF is evaluated.
* @return the probability that a random variable with this
* distribution takes a value more than or equal to {@code x}.
*/
default double survivalProbability(double x) {
return 1 - cumulativeProbability(x);
}
{code}
A similar method can be added to DiscreteDistribution interface too.
Distributions where a more accurate result can be obtained as the CDF -> 1 can
override the method. These would exploit the availability of far more double
values for the result as it approaches 0, rather than the default
implementation which is limited to a minimum of 2^-53 (i.e. 1.0 -
nextDown(1.0)).
Is this what you are suggesting?
was (Author: alexherbert):
Support can be added to the ContinuousDistribution interface using a default
method:
{code:java}
/**
* For a random variable {@code X} whose values are distributed according
* to this distribution, this method returns {@code P(X >= x)}.
* In other words, this method represents the complementary cumulative
distribution
* function for this distribution, also known as the survival function or
* reliability function.
*
* @param x Point at which the CDF is evaluated.
* @return the probability that a random variable with this
* distribution takes a value more than or equal to {@code x}.
*/
default double survivalProbability(double x) {
return 1 - cumulativeProbability(x);
}
{code}
A similar method can be added to DiscreteDistribution interface too.
Distributions where a more accurate result can be obtained as the CDF -> 1 can
override the method. These would exploit the availability of far more double
values for the result as it approaches 0, rather than the default
implementation which is limited to a minimum of 2^-53 (i.e. 1.0 -
nextDown(1.0)).
Is this what you are suggesting?
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380794#comment-17380794
]
Alex Herbert commented on STATISTICS-31:
Support can be added to the ContinuousDistribution interface using a default
method:
{code:java}
/**
* For a random variable {@code X} whose values are distributed according
* to this distribution, this method returns {@code P(X >= x)}.
* In other words, this method represents the complementary cumulative
distribution
* function for this distribution, also known as the survival function or
* reliability function.
*
* @param x Point at which the CDF is evaluated.
* @return the probability that a random variable with this
* distribution takes a value more than or equal to {@code x}.
*/
default double survivalProbability(double x) {
return 1 - cumulativeProbability(x);
}
{code}
A similar method can be added to DiscreteDistribution interface too.
Distributions where a more accurate result can be obtained as the CDF -> 1 can
override the method. These would exploit the availability of far more double
values for the result as it approaches 0, rather than the default
implementation which is limited to a minimum of 2^-53 (i.e. 1.0 -
nextDown(1.0)).
Is this what you are suggesting?
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=622627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622627
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 14/Jul/21 17:56
Start Date: 14/Jul/21 17:56
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r669833242
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+CSVFormat csvFormat =
CSVFormat.DEFAULT.withCommentMarker('#').withFirstRecordAsHeader();
Review comment:
@king-tyler
May you please use the builder instead of the deprecated methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622627)
Time Spent: 1h (was: 50m)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] garydgregory commented on a change in pull request #120: [CSV-265] Update buffer position when reading line comment
garydgregory commented on a change in pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#discussion_r669833242
##
File path: src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.csv.issues;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.io.IOException;
+import java.io.StringReader;
+import java.util.Iterator;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.commons.csv.CSVParser;
+import org.apache.commons.csv.CSVRecord;
+import org.junit.jupiter.api.Test;
+
+public class JiraCsv265Test {
+
+@Test
+public void testJiraCsv265Test() throws IOException {
+String csv = "# Comment1\n"
+ + "Header1,Header2\n"
+ + "# Comment2\n"
+ + "Value1,Value2\n"
+ + "# Comment3\n"
+ + "Value3,Value4\n"
+ + "# Comment4\n";
+CSVFormat csvFormat =
CSVFormat.DEFAULT.withCommentMarker('#').withFirstRecordAsHeader();
Review comment:
@king-tyler
May you please use the builder instead of the deprecated methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380769#comment-17380769
]
Benjamin W Trent commented on STATISTICS-31:
I am happy to work on this myself.
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-265) CSV comments break CSVRecord#getCharacterPosition
[
https://issues.apache.org/jira/browse/CSV-265?focusedWorklogId=622607=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622607
]
ASF GitHub Bot logged work on CSV-265:
--
Author: ASF GitHub Bot
Created on: 14/Jul/21 17:14
Start Date: 14/Jul/21 17:14
Worklog Time Spent: 10m
Work Description: king-tyler commented on pull request #120:
URL: https://github.com/apache/commons-csv/pull/120#issuecomment-880066930
@garydgregory
I rebased on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 622607)
Time Spent: 50m (was: 40m)
> CSV comments break CSVRecord#getCharacterPosition
> -
>
> Key: CSV-265
> URL: https://issues.apache.org/jira/browse/CSV-265
> Project: Commons CSV
> Issue Type: Bug
> Components: Parser
>Affects Versions: 1.8
>Reporter: Tyler King
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The CSVRecord#getCharacterPosition method returns an incorrect value after
> the CSVParser has encountered a comment in the CSV file.
> Example:
>
> {code:java}
> String csv = "# Comment\n"
>+ "Headers,Header2\n"
>+ "Value1,Value2\n";
> CSVFormat format =
> CSVFormat.EXCEL.withCommentMarker('#').withFirstRecordAsHeader();
> CSVParser parser = new CSVParser(new StringReader(csv), format);
> long expectedPosition = csv.indexOf("Value1");
> long actualPosition = parser.iterator().next().getCharacterPosition();
> assertEquals(expectedPosition, actualPosition);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] king-tyler commented on pull request #120: [CSV-265] Update buffer position when reading line comment
king-tyler commented on pull request #120: URL: https://github.com/apache/commons-csv/pull/120#issuecomment-880066930 @garydgregory I rebased on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory merged pull request #49: Bump spotbugs from 4.2.3 to 4.3.0
garydgregory merged pull request #49: URL: https://github.com/apache/commons-parent/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] garydgregory merged pull request #39: Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0
garydgregory merged pull request #39: URL: https://github.com/apache/commons-build-plugin/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] dependabot[bot] commented on pull request #161: Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0
dependabot[bot] commented on pull request #161: URL: https://github.com/apache/commons-csv/pull/161#issuecomment-880054664 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory closed pull request #161: Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0
garydgregory closed pull request #161: URL: https://github.com/apache/commons-csv/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #161: Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0
garydgregory commented on pull request #161: URL: https://github.com/apache/commons-csv/pull/161#issuecomment-880054640 Done separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-278) Reuse Buffers in Lexer for Delimiter Detection
[ https://issues.apache.org/jira/browse/CSV-278?focusedWorklogId=622573=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622573 ] ASF GitHub Bot logged work on CSV-278: -- Author: ASF GitHub Bot Created on: 14/Jul/21 16:40 Start Date: 14/Jul/21 16:40 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #162: URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880044633 Maybe tonight or this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 622573) Time Spent: 2.5h (was: 2h 20m) > Reuse Buffers in Lexer for Delimiter Detection > -- > > Key: CSV-278 > URL: https://issues.apache.org/jira/browse/CSV-278 > Project: Commons CSV > Issue Type: Sub-task >Reporter: David Mollitor >Priority: Minor > Time Spent: 2.5h > Remaining Estimate: 0h > > When a character is read, and it could be the first character of the > delimiter, a look-ahead is performed on the stream to determine if this will > be the delimiter. This look ahead initiates a new buffer to read into for > each call. This can cause overhead and much more turn in the heap. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
garydgregory commented on pull request #162: URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880044633 Maybe tonight or this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CSV-278) Reuse Buffers in Lexer for Delimiter Detection
[ https://issues.apache.org/jira/browse/CSV-278?focusedWorklogId=622560=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622560 ] ASF GitHub Bot logged work on CSV-278: -- Author: ASF GitHub Bot Created on: 14/Jul/21 15:53 Start Date: 14/Jul/21 15:53 Worklog Time Spent: 10m Work Description: belugabehr commented on pull request #162: URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880010202 @garydgregory Have you had a chance to check out the JMH stuff? Thanks! https://issues.apache.org/jira/browse/CSV-278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 622560) Time Spent: 2h 20m (was: 2h 10m) > Reuse Buffers in Lexer for Delimiter Detection > -- > > Key: CSV-278 > URL: https://issues.apache.org/jira/browse/CSV-278 > Project: Commons CSV > Issue Type: Sub-task >Reporter: David Mollitor >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > When a character is read, and it could be the first character of the > delimiter, a look-ahead is performed on the stream to determine if this will > be the delimiter. This look ahead initiates a new buffer to read into for > each call. This can cause overhead and much more turn in the heap. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-csv] belugabehr commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
belugabehr commented on pull request #162: URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880010202 @garydgregory Have you had a chance to check out the JMH stuff? Thanks! https://issues.apache.org/jira/browse/CSV-278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (STATISTICS-31) Add survival probability function to continuous distributions
[
https://issues.apache.org/jira/browse/STATISTICS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin W Trent updated STATISTICS-31:
---
Description:
It is useful to know the [survival
function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given a
continuous distribution.
While this can be approximated with
{noformat}
1 - cdf(x){noformat}
, there is an opportunity for greater accuracy in certain distributions.
A good example of this is the gamma distribution. The survival function for
that distribution would probably look similar to:
```java
@Override
public double survivalProbability(double x) {
if (x <= SUPPORT_LO)
{ return 1; }
else if (x >= SUPPORT_HI)
{ return 0; }
return RegularizedGamma.Q.value(shape, x / scale);
}
```
was:
It is useful to know the [survival
function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given a
continuous distribution.
While this can be approximated with `1 - cdf(x)`, there is an opportunity for
greater accuracy in certain distributions.
A good example of this is the gamma distribution. The survival function for
that distribution would probably look similar to:
```java
@Override
public double survivalProbability(double x) {
if (x <= SUPPORT_LO) {
return 1;
} else if (x >= SUPPORT_HI) {
return 0;
}
return RegularizedGamma.Q.value(shape, x / scale);
}
```
> Add survival probability function to continuous distributions
> -
>
> Key: STATISTICS-31
> URL: https://issues.apache.org/jira/browse/STATISTICS-31
> Project: Apache Commons Statistics
> Issue Type: New Feature
>Reporter: Benjamin W Trent
>Priority: Major
>
> It is useful to know the [survival
> function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given
> a continuous distribution.
> While this can be approximated with
> {noformat}
> 1 - cdf(x){noformat}
> , there is an opportunity for greater accuracy in certain distributions.
>
> A good example of this is the gamma distribution. The survival function for
> that distribution would probably look similar to:
>
> ```java
> @Override
> public double survivalProbability(double x) {
> if (x <= SUPPORT_LO)
> { return 1; }
> else if (x >= SUPPORT_HI)
> { return 0; }
> return RegularizedGamma.Q.value(shape, x / scale);
> }
> ```
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (STATISTICS-31) Add survival probability function to continuous distributions
Benjamin W Trent created STATISTICS-31:
--
Summary: Add survival probability function to continuous
distributions
Key: STATISTICS-31
URL: https://issues.apache.org/jira/browse/STATISTICS-31
Project: Apache Commons Statistics
Issue Type: New Feature
Reporter: Benjamin W Trent
It is useful to know the [survival
function|[https://en.wikipedia.org/wiki/Survival_function]] of a number given a
continuous distribution.
While this can be approximated with `1 - cdf(x)`, there is an opportunity for
greater accuracy in certain distributions.
A good example of this is the gamma distribution. The survival function for
that distribution would probably look similar to:
```java
@Override
public double survivalProbability(double x) {
if (x <= SUPPORT_LO) {
return 1;
} else if (x >= SUPPORT_HI) {
return 0;
}
return RegularizedGamma.Q.value(shape, x / scale);
}
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380592#comment-17380592 ] AVIJIT BASAK commented on MATH-1563: I have started to document the changes in UML model. The existing model has been reversed engineered from the source code. I have proposed few alterations to the existing model as well as few additions. The alterations are colored as yellow and additions as blue and removals as red. The models are separated logically in three diagrams as attached below. I have attached the diagrams here to maintain a proper reference. I have used umlet (https://www.umlet.com/ ) for drawing the diagrams. We can start the review and design discussion based on these. [^GA-Overview.uxf] [^GA-Model.uxf] [^GA-OperatorModel.uxf] > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-OperatorModel.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-imaging] dependabot[bot] commented on pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
dependabot[bot] commented on pull request #156: URL: https://github.com/apache/commons-imaging/pull/156#issuecomment-879874226 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow closed pull request #156: Bump spotbugs from 4.2.3 to 4.3.0
kinow closed pull request #156: URL: https://github.com/apache/commons-imaging/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-OperatorModel.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-OperatorModel.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-Model.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-OperatorModel.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AVIJIT BASAK updated MATH-1563: --- Attachment: GA-Overview.uxf > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-OperatorModel.uxf, GA-Overview.uxf > > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf;. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-release-plugin] dependabot[bot] commented on pull request #63: Bump commons-io from 2.10.0 to 2.11.0
dependabot[bot] commented on pull request #63: URL: https://github.com/apache/commons-release-plugin/pull/63#issuecomment-879687144 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] kinow closed pull request #63: Bump commons-io from 2.10.0 to 2.11.0
kinow closed pull request #63: URL: https://github.com/apache/commons-release-plugin/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-release-plugin] dependabot[bot] opened a new pull request #63: Bump commons-io from 2.10.0 to 2.11.0
dependabot[bot] opened a new pull request #63: URL: https://github.com/apache/commons-release-plugin/pull/63 Bumps commons-io from 2.10.0 to 2.11.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] opened a new pull request #74: Bump commons-io from 2.10.0 to 2.11.0
dependabot[bot] opened a new pull request #74: URL: https://github.com/apache/commons-jcs/pull/74 Bumps commons-io from 2.10.0 to 2.11.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
