[GitHub] [commons-lang] coveralls commented on pull request #786: Lang-1657: Diff Result Type Constraint
coveralls commented on pull request #786: URL: https://github.com/apache/commons-lang/pull/786#issuecomment-894606002 [](https://coveralls.io/builds/41976450) Coverage increased (+0.006%) to 95.001% when pulling **c1033f58d846b5a62e633f4e3ea65b634f864429 on greatmastermario:LANG-1657-DiffResult-Type-Constraint** into **7c658527094083b2037d362916adf8eb2493ea65 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] greatmastermario opened a new pull request #786: Lang-1657: Diff Result Type Constraint
greatmastermario opened a new pull request #786: URL: https://github.com/apache/commons-lang/pull/786 - Updated type parameter for DiffBuilder.append(String, DiffResult) to accept DiffResults of any type in case nested field is not the same type as the containing class - Added test case for nested Diffable types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=635535=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635535 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 07/Aug/21 01:56 Start Date: 07/Aug/21 01:56 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-89455 [](https://coveralls.io/builds/41975704) Coverage remained the same at 94.995% when pulling **499fcac59d2ef24751d401039ff952e3ccef7b29 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **7c658527094083b2037d362916adf8eb2493ea65 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635535) Time Spent: 20m (was: 10m) > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 20m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
coveralls commented on pull request #785: URL: https://github.com/apache/commons-lang/pull/785#issuecomment-89455 [](https://coveralls.io/builds/41975704) Coverage remained the same at 94.995% when pulling **499fcac59d2ef24751d401039ff952e3ccef7b29 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **7c658527094083b2037d362916adf8eb2493ea65 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395043#comment-17395043 ] Andrew Thomas commented on LANG-1663: - I have created a PR for this issue here: [LANG-1663|https://github.com/apache/commons-lang/pull/785] > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1663) Wrong exception in various NumberUtils method documentations
[ https://issues.apache.org/jira/browse/LANG-1663?focusedWorklogId=635534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635534 ] ASF GitHub Bot logged work on LANG-1663: Author: ASF GitHub Bot Created on: 07/Aug/21 01:48 Start Date: 07/Aug/21 01:48 Worklog Time Spent: 10m Work Description: greatmastermario opened a new pull request #785: URL: https://github.com/apache/commons-lang/pull/785 Updated documentation in NumberUtils to correctly state that a NullPointerException is thrown when the array is null, not an IllegalArgumentException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635534) Remaining Estimate: 0h Time Spent: 10m > Wrong exception in various NumberUtils method documentations > > > Key: LANG-1663 > URL: https://issues.apache.org/jira/browse/LANG-1663 > Project: Commons Lang > Issue Type: Bug > Components: lang.math.* >Affects Versions: 3.12.0 >Reporter: Tobias Helms >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > The documentation of various methods in _NumberUtils_ says an > _IllegalArgumentException_ is thrown in case of a _null_ argument , e.g., see > [https://github.com/apache/commons-lang/blob/197d50434748bfb2db935266cfe740fc01a607ee/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1194] > > However, these methods throw a _NullPointerException_ in this case. The > following methods are affected: > * long min(final long... array) > * int min(final int... array) > * short min(final short... array) > * byte min(final byte... array) > * static double min(final double... array) > * float min(final float... array) > * long max(final long... array) > * int max(final int... array) > * short max(final short... array) > * byte max(final byte... array) > * double max(final double... array) > * float max(final float... array) > * void validateArray(final Object array) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] greatmastermario opened a new pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
greatmastermario opened a new pull request #785: URL: https://github.com/apache/commons-lang/pull/785 Updated documentation in NumberUtils to correctly state that a NullPointerException is thrown when the array is null, not an IllegalArgumentException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls edited a comment on pull request #82: CODEC-298 - Use Standard Charset object
coveralls edited a comment on pull request #82: URL: https://github.com/apache/commons-codec/pull/82#issuecomment-827317703 [](https://coveralls.io/builds/41973598) Coverage remained the same at 94.682% when pulling **ceed2d3bdb5ca9b50f19eb441a53dac5b8dcda87 on arturobernalg:feature/CODEC-298** into **8ee878ba7f887b74fc70415e05cb30acd21e1617 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory commented on pull request #51: Bump apache from 23 to 24
garydgregory commented on pull request #51: URL: https://github.com/apache/commons-parent/pull/51#issuecomment-894545279 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1573) Redundant local variable
[
https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=635490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635490
]
ASF GitHub Bot logged work on MATH-1573:
Author: ASF GitHub Bot
Created on: 06/Aug/21 21:20
Start Date: 06/Aug/21 21:20
Worklog Time Spent: 10m
Work Description: arturobernalg commented on a change in pull request
#194:
URL: https://github.com/apache/commons-math/pull/194#discussion_r684509601
##
File path:
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
##
@@ -1600,9 +1600,8 @@ public static double pow(final double x, final double y) {
z = z * lnb + 1.0;
z *= lnb;
-final double result = exp(lna, z, null);
//result = result + result * z;
-return result;
+return exp(lna, z, null);
Review comment:
HI @aherbert
Sound logical. I made rollback of this change.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 635490)
Time Spent: 2h 20m (was: 2h 10m)
> Redundant local variable
>
>
> Key: MATH-1573
> URL: https://issues.apache.org/jira/browse/MATH-1573
> Project: Commons Math
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Remove redundant local variable
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] arturobernalg commented on a change in pull request #194: MATH-1573 - Redundant local variable
arturobernalg commented on a change in pull request #194:
URL: https://github.com/apache/commons-math/pull/194#discussion_r684509601
##
File path:
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
##
@@ -1600,9 +1600,8 @@ public static double pow(final double x, final double y) {
z = z * lnb + 1.0;
z *= lnb;
-final double result = exp(lna, z, null);
//result = result + result * z;
-return result;
+return exp(lna, z, null);
Review comment:
HI @aherbert
Sound logical. I made rollback of this change.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-codec] arturobernalg commented on pull request #82: CODEC-298 - Use Standard Charset object
arturobernalg commented on pull request #82: URL: https://github.com/apache/commons-codec/pull/82#issuecomment-894522199 > @arturobernalg > May you please rebase on master? HI @garydgregory Done TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1573) Redundant local variable
[
https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=635486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635486
]
ASF GitHub Bot logged work on MATH-1573:
Author: ASF GitHub Bot
Created on: 06/Aug/21 21:03
Start Date: 06/Aug/21 21:03
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #194:
URL: https://github.com/apache/commons-math/pull/194#discussion_r684502997
##
File path:
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
##
@@ -1600,9 +1600,8 @@ public static double pow(final double x, final double y) {
z = z * lnb + 1.0;
z *= lnb;
-final double result = exp(lna, z, null);
//result = result + result * z;
-return result;
+return exp(lna, z, null);
Review comment:
I am wondering about the cryptic commented out code here. It would be
run after the result has been computed with `exp`. So if you simply return the
result of `exp` then the comment is before the `exp` and out of context. I
would leave this unchanged until the reason for commenting out the final
computation is clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 635486)
Time Spent: 2h 10m (was: 2h)
> Redundant local variable
>
>
> Key: MATH-1573
> URL: https://issues.apache.org/jira/browse/MATH-1573
> Project: Commons Math
> Issue Type: Sub-task
>Reporter: Arturo Bernal
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Remove redundant local variable
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-math] aherbert commented on a change in pull request #194: MATH-1573 - Redundant local variable
aherbert commented on a change in pull request #194:
URL: https://github.com/apache/commons-math/pull/194#discussion_r684502997
##
File path:
commons-math-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
##
@@ -1600,9 +1600,8 @@ public static double pow(final double x, final double y) {
z = z * lnb + 1.0;
z *= lnb;
-final double result = exp(lna, z, null);
//result = result + result * z;
-return result;
+return exp(lna, z, null);
Review comment:
I am wondering about the cryptic commented out code here. It would be
run after the result has been computed with `exp`. So if you simply return the
result of `exp` then the comment is before the `exp` and out of context. I
would leave this unchanged until the reason for commenting out the final
computation is clarified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (MATH-1572) Simplify Conditions
[ https://issues.apache.org/jira/browse/MATH-1572?focusedWorklogId=635485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635485 ] ASF GitHub Bot logged work on MATH-1572: Author: ASF GitHub Bot Created on: 06/Aug/21 21:00 Start Date: 06/Aug/21 21:00 Worklog Time Spent: 10m Work Description: aherbert commented on pull request #193: URL: https://github.com/apache/commons-math/pull/193#issuecomment-894515570 This is all fine. Can you update the commit message to prefix with MATH-1572. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 635485) Time Spent: 1h (was: 50m) > Simplify Conditions > --- > > Key: MATH-1572 > URL: https://issues.apache.org/jira/browse/MATH-1572 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > * Simplifiable boolean expression > * Simplifiable conditional expression > * Redundant 'if' statement -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] aherbert commented on pull request #193: MATH-1572: Simplify conditional expressions
aherbert commented on pull request #193: URL: https://github.com/apache/commons-math/pull/193#issuecomment-894515570 This is all fine. Can you update the commit message to prefix with MATH-1572. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory merged pull request #54: Bump checkstyle from 8.44 to 8.45
garydgregory merged pull request #54: URL: https://github.com/apache/commons-parent/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory merged pull request #53: Bump commons.pmd-impl.version from 6.36.0 to 6.37.0
garydgregory merged pull request #53: URL: https://github.com/apache/commons-parent/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory merged pull request #50: Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0
garydgregory merged pull request #50: URL: https://github.com/apache/commons-parent/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-parent] garydgregory merged pull request #52: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0
garydgregory merged pull request #52: URL: https://github.com/apache/commons-parent/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-582) Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
[
https://issues.apache.org/jira/browse/COMPRESS-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394987#comment-17394987
]
Gary D. Gregory commented on COMPRESS-582:
--
[~AlexLandau]
Patches welcome :)
> Pack200CompressorOutputStream fails at runtime in 1.21 if ASM 4.0+ is used
> --
>
> Key: COMPRESS-582
> URL: https://issues.apache.org/jira/browse/COMPRESS-582
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.21
>Reporter: Alex Landau
>Priority: Major
>
> I just tried to upgrade an existing codebase to commons-compress 1.21 (from
> 1.20, which was working correctly) and encountered the following error in
> code trying to use the Pack200CompressorOutputStream:
> {code:java}
> java.lang.IncompatibleClassChangeError: class
> org.apache.commons.compress.harmony.pack200.Segment can not implement
> org.objectweb.asm.ClassVisitor, because it is not an interface
> (org.objectweb.asm.ClassVisitor is in unnamed module of loader 'app')
> {code}
> The Segment class {{implements}} rather than {{extends}} ClassVisitor. It
> looks like commons-compress is built against asm 3.2. Per
> [https://asm.ow2.io/versions.html], ClassVisitor was converted from an
> interface to an abstract class in asm 4.0, which was released in 2011, "in
> order to ensure backward binary compatibility in future ASM versions". To be
> clear, our project needs a more recent asm version on the classpath to
> support other libraries.
> I have a repro of the error here, in case it helps:
> [https://github.com/AlexLandau/commons-compress-asm-error]
> I want to add that I appreciate the effort you are making to support pack200
> in a way that will outlast the JDK's native support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RNG-159) ZigguratSampler.NormalizedGaussian has incorrect Gaussian output
[ https://issues.apache.org/jira/browse/RNG-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394946#comment-17394946 ] Alex Herbert commented on RNG-159: -- Further investigation using the reference C implementation shows that the problem exists in the source implementation. It can be avoided by not using the fast rejection method when sampling the convex overhangs of the ziggurat. This may invalidate the performance gains of the method. The issue has been reported to the maintainer of the reference implementation. > ZigguratSampler.NormalizedGaussian has incorrect Gaussian output > > > Key: RNG-159 > URL: https://issues.apache.org/jira/browse/RNG-159 > Project: Commons RNG > Issue Type: Bug > Components: sampling >Affects Versions: 1.4 >Reporter: Alex Herbert >Priority: Blocker > Fix For: 1.4 > > Attachments: pdf.gauss.modified.ziggurat.txt.png, > pdf.gauss.ziggurat.txt.png > > > The new ZigguratSampler.NormalizedGaussian does not produce suitable output > from the examples sampling application: > !pdf.gauss.modified.ziggurat.txt.png! > Compare with the current ZigguratNormalizedGaussianSampler: > !pdf.gauss.ziggurat.txt.png! > This is is repeatable with several different RNG implementations. > This issue was not detected with the current test suite in the sampling > module which uses the deciles of the distribution. The deciles may be too > coarse grained to detect a problem around the distribution mean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] garydgregory merged pull request #215: Bump zstd-jni from 1.5.0-2 to 1.5.0-4
garydgregory merged pull request #215: URL: https://github.com/apache/commons-compress/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CODEC-298) Use Standard Charset object
[ https://issues.apache.org/jira/browse/CODEC-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394911#comment-17394911 ] Gary D. Gregory commented on CODEC-298: --- No need for a Jira ticket for this kind of change IMO. > Use Standard Charset object > --- > > Key: CODEC-298 > URL: https://issues.apache.org/jira/browse/CODEC-298 > Project: Commons Codec > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] garydgregory commented on pull request #82: CODEC-298 - Use Standard Charset object
garydgregory commented on pull request #82: URL: https://github.com/apache/commons-codec/pull/82#issuecomment-894396554 @arturobernalg May you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CODEC-297) Minor improvements
[ https://issues.apache.org/jira/browse/CODEC-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394908#comment-17394908 ] Gary D. Gregory commented on CODEC-297: --- No need for a Jira ticket for this kind of change IMO. > Minor improvements > -- > > Key: CODEC-297 > URL: https://issues.apache.org/jira/browse/CODEC-297 > Project: Commons Codec > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (CODEC-299) Improve control flow
[ https://issues.apache.org/jira/browse/CODEC-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-299. --- Fix Version/s: 1.16 Resolution: Fixed > Improve control flow > > > Key: CODEC-299 > URL: https://issues.apache.org/jira/browse/CODEC-299 > Project: Commons Codec > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Fix For: 1.16 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CODEC-299) Improve control flow
[ https://issues.apache.org/jira/browse/CODEC-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394909#comment-17394909 ] Gary D. Gregory commented on CODEC-299: --- No need for a Jira ticket for this kind of change IMO. > Improve control flow > > > Key: CODEC-299 > URL: https://issues.apache.org/jira/browse/CODEC-299 > Project: Commons Codec > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] garydgregory merged pull request #83: CODEC-299 - Improve control flow
garydgregory merged pull request #83: URL: https://github.com/apache/commons-codec/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (CODEC-300) Simplify assertion
[ https://issues.apache.org/jira/browse/CODEC-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-300. --- Fix Version/s: 1.16 Resolution: Fixed > Simplify assertion > -- > > Key: CODEC-300 > URL: https://issues.apache.org/jira/browse/CODEC-300 > Project: Commons Codec > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > Fix For: 1.16 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CODEC-300) Simplify assertion
[ https://issues.apache.org/jira/browse/CODEC-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394907#comment-17394907 ] Gary D. Gregory commented on CODEC-300: --- No need for a Jira ticket for this kind of change IMO. > Simplify assertion > -- > > Key: CODEC-300 > URL: https://issues.apache.org/jira/browse/CODEC-300 > Project: Commons Codec > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] garydgregory merged pull request #84: CODEC-300 - Simplify assertion
garydgregory merged pull request #84: URL: https://github.com/apache/commons-codec/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMMONSSITE-150) Maven Central link/badge for "Commons Numbers" v1.0
Gilles Sadowski created COMMONSSITE-150: --- Summary: Maven Central link/badge for "Commons Numbers" v1.0 Key: COMMONSSITE-150 URL: https://issues.apache.org/jira/browse/COMMONSSITE-150 Project: Apache Commons All Issue Type: Task Components: Site Reporter: Gilles Sadowski See [post on the "dev" ML|https://markmail.org/message/njrhacbh3begxclj]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] garydgregory merged pull request #77: Bump commons-lang3 from 3.8 to 3.12.0
garydgregory merged pull request #77: URL: https://github.com/apache/commons-codec/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-807) LocalFile migration to NIO is not done correctly
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394809#comment-17394809
]
Gary D. Gregory commented on VFS-807:
-
[~klv_m72]
My mistake. Fixed in git master.
TY!
> LocalFile migration to NIO is not done correctly
>
>
> Key: VFS-807
> URL: https://issues.apache.org/jira/browse/VFS-807
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: L
>Priority: Blocker
> Fix For: 2.9.1
>
> Attachments: TestJdkWriteFile.java, vfs-807.diff
>
>
> According to release notes
> ([https://archive.apache.org/dist/commons/vfs/RELEASE-NOTES.txt),] version
> 2.9.0 includes the following change:
> Replace construction of FileInputStream and FileOutputStream objects with
> Files NIO APIs. #164. Thanks to Arturo Bernal.
> Strangely, it was not completed: LocalFlie.java has the following now, even
> in master:
> {code:java}
> /**
> * Creates an input stream to read the content from.
> */
> @Override
> protected InputStream doGetInputStream(final int bufferSize) throws
> Exception {
> return new FileInputStream(file);
> }
> {code}
>
> But what is worse, doGetOutputStream is *completely* broken:
> {code:java}
> /**
> * Creates an output stream to write the file content to.
> */
> @Override
> protected OutputStream doGetOutputStream(final boolean bAppend) throws
> Exception {
> return Files.newOutputStream(file.toPath(), bAppend ?
> StandardOpenOption.APPEND : StandardOpenOption.CREATE);
> } {code}
>
> This can be demonstrated with a small java program, see attachment. The
> program just tries to write to a local file (into the same directory), using
> different ways to do it:
> # Java IO, how it was done before VFS 2.9.0
> # Java NIO the way VFS 2.9.0 does it
> # Java NIO the way it must be done
> What is important, the program also verifies the result.
> VFS 2.9.0 fails in 2 cases:
> # When the file does not exist and append must be performed:
> java.nio.file.NoSuchFileException is thrown in this case.
> # When the file exists and no append must be performed: the file is not
> truncated, so whatever is written overwrites the beginning of the file,
> keeping the rest.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] garydgregory merged pull request #212: Bump memoryfilesystem from 2.1.0 to 2.2.0
garydgregory merged pull request #212: URL: https://github.com/apache/commons-compress/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #208: Bump org.apache.felix.framework from 7.0.0 to 7.0.1
garydgregory merged pull request #208: URL: https://github.com/apache/commons-compress/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #215: Bump zstd-jni from 1.5.0-2 to 1.5.0-4
dependabot[bot] opened a new pull request #215: URL: https://github.com/apache/commons-compress/pull/215 Bumps [zstd-jni](https://github.com/luben/zstd-jni) from 1.5.0-2 to 1.5.0-4. Commits https://github.com/luben/zstd-jni/commit/aca870e394becffbabb29ca90001523658327e19;>aca870e Optimize the Android build for size https://github.com/luben/zstd-jni/commit/583199ab60bd149d670f52373b82c5b69b333bbe;>583199a Skiping lengths gt MAX_INT can overflow the buffer size calculation https://github.com/luben/zstd-jni/commit/0ed490a131504edd1ff451b52f60344df0e5f68e;>0ed490a Use sbt-jni from sonatype https://github.com/luben/zstd-jni/commit/3ebcebc1eb1178638de5267e07b244e0a72df1d1;>3ebcebc Update the build instructions See full diff in https://github.com/luben/zstd-jni/compare/v1.5.0-2...v1.5.0-4;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #209: Bump mockito-core from 3.11.1 to 3.11.2
garydgregory merged pull request #209: URL: https://github.com/apache/commons-compress/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (VFS-807) LocalFile migration to NIO is not done correctly
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394698#comment-17394698
]
L commented on VFS-807:
---
[~ggregory]
I am using Windows 10 and jdk 8 as well.
The thing is: you did not correctly pushed my test changes, namely,
ProviderWriteAppendTests.java:
Mine code:
{code:java}
try (OutputStream os = file.getContent().getOutputStream(true)) {
os.write(content1.getBytes(StandardCharsets.UTF_8));
}
{code}
Code in master:
{code:java}
try (FileContent fileContent = file.getContent(); OutputStream os =
fileContent.getOutputStream()) {
os.write(content1.getBytes(StandardCharsets.UTF_8));
}
{code}
Your code does not perform "append". It must be
fileContent.getOutputStream(*true*)
> LocalFile migration to NIO is not done correctly
>
>
> Key: VFS-807
> URL: https://issues.apache.org/jira/browse/VFS-807
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: L
>Priority: Blocker
> Fix For: 2.9.1
>
> Attachments: TestJdkWriteFile.java, vfs-807.diff
>
>
> According to release notes
> ([https://archive.apache.org/dist/commons/vfs/RELEASE-NOTES.txt),] version
> 2.9.0 includes the following change:
> Replace construction of FileInputStream and FileOutputStream objects with
> Files NIO APIs. #164. Thanks to Arturo Bernal.
> Strangely, it was not completed: LocalFlie.java has the following now, even
> in master:
> {code:java}
> /**
> * Creates an input stream to read the content from.
> */
> @Override
> protected InputStream doGetInputStream(final int bufferSize) throws
> Exception {
> return new FileInputStream(file);
> }
> {code}
>
> But what is worse, doGetOutputStream is *completely* broken:
> {code:java}
> /**
> * Creates an output stream to write the file content to.
> */
> @Override
> protected OutputStream doGetOutputStream(final boolean bAppend) throws
> Exception {
> return Files.newOutputStream(file.toPath(), bAppend ?
> StandardOpenOption.APPEND : StandardOpenOption.CREATE);
> } {code}
>
> This can be demonstrated with a small java program, see attachment. The
> program just tries to write to a local file (into the same directory), using
> different ways to do it:
> # Java IO, how it was done before VFS 2.9.0
> # Java NIO the way VFS 2.9.0 does it
> # Java NIO the way it must be done
> What is important, the program also verifies the result.
> VFS 2.9.0 fails in 2 cases:
> # When the file does not exist and append must be performed:
> java.nio.file.NoSuchFileException is thrown in this case.
> # When the file exists and no append must be performed: the file is not
> truncated, so whatever is written overwrites the beginning of the file,
> keeping the rest.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-807) LocalFile migration to NIO is not done correctly
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394676#comment-17394676
]
Gary D. Gregory commented on VFS-807:
-
Also note that the change to use Files NIO to create the input stream is not in.
> LocalFile migration to NIO is not done correctly
>
>
> Key: VFS-807
> URL: https://issues.apache.org/jira/browse/VFS-807
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: L
>Priority: Blocker
> Fix For: 2.9.1
>
> Attachments: TestJdkWriteFile.java, vfs-807.diff
>
>
> According to release notes
> ([https://archive.apache.org/dist/commons/vfs/RELEASE-NOTES.txt),] version
> 2.9.0 includes the following change:
> Replace construction of FileInputStream and FileOutputStream objects with
> Files NIO APIs. #164. Thanks to Arturo Bernal.
> Strangely, it was not completed: LocalFlie.java has the following now, even
> in master:
> {code:java}
> /**
> * Creates an input stream to read the content from.
> */
> @Override
> protected InputStream doGetInputStream(final int bufferSize) throws
> Exception {
> return new FileInputStream(file);
> }
> {code}
>
> But what is worse, doGetOutputStream is *completely* broken:
> {code:java}
> /**
> * Creates an output stream to write the file content to.
> */
> @Override
> protected OutputStream doGetOutputStream(final boolean bAppend) throws
> Exception {
> return Files.newOutputStream(file.toPath(), bAppend ?
> StandardOpenOption.APPEND : StandardOpenOption.CREATE);
> } {code}
>
> This can be demonstrated with a small java program, see attachment. The
> program just tries to write to a local file (into the same directory), using
> different ways to do it:
> # Java IO, how it was done before VFS 2.9.0
> # Java NIO the way VFS 2.9.0 does it
> # Java NIO the way it must be done
> What is important, the program also verifies the result.
> VFS 2.9.0 fails in 2 cases:
> # When the file does not exist and append must be performed:
> java.nio.file.NoSuchFileException is thrown in this case.
> # When the file exists and no append must be performed: the file is not
> truncated, so whatever is written overwrites the beginning of the file,
> keeping the rest.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VFS-807) LocalFile migration to NIO is not done correctly
[
https://issues.apache.org/jira/browse/VFS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394675#comment-17394675
]
Gary D. Gregory commented on VFS-807:
-
That was a typo on my end, sorry, the tests passed without the change to main.
What OS/JRE are you on?
> LocalFile migration to NIO is not done correctly
>
>
> Key: VFS-807
> URL: https://issues.apache.org/jira/browse/VFS-807
> Project: Commons VFS
> Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: L
>Priority: Blocker
> Fix For: 2.9.1
>
> Attachments: TestJdkWriteFile.java, vfs-807.diff
>
>
> According to release notes
> ([https://archive.apache.org/dist/commons/vfs/RELEASE-NOTES.txt),] version
> 2.9.0 includes the following change:
> Replace construction of FileInputStream and FileOutputStream objects with
> Files NIO APIs. #164. Thanks to Arturo Bernal.
> Strangely, it was not completed: LocalFlie.java has the following now, even
> in master:
> {code:java}
> /**
> * Creates an input stream to read the content from.
> */
> @Override
> protected InputStream doGetInputStream(final int bufferSize) throws
> Exception {
> return new FileInputStream(file);
> }
> {code}
>
> But what is worse, doGetOutputStream is *completely* broken:
> {code:java}
> /**
> * Creates an output stream to write the file content to.
> */
> @Override
> protected OutputStream doGetOutputStream(final boolean bAppend) throws
> Exception {
> return Files.newOutputStream(file.toPath(), bAppend ?
> StandardOpenOption.APPEND : StandardOpenOption.CREATE);
> } {code}
>
> This can be demonstrated with a small java program, see attachment. The
> program just tries to write to a local file (into the same directory), using
> different ways to do it:
> # Java IO, how it was done before VFS 2.9.0
> # Java NIO the way VFS 2.9.0 does it
> # Java NIO the way it must be done
> What is important, the program also verifies the result.
> VFS 2.9.0 fails in 2 cases:
> # When the file does not exist and append must be performed:
> java.nio.file.NoSuchFileException is thrown in this case.
> # When the file exists and no append must be performed: the file is not
> truncated, so whatever is written overwrites the beginning of the file,
> keeping the rest.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (MATH-1573) Redundant local variable
[ https://issues.apache.org/jira/browse/MATH-1573?focusedWorklogId=634974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634974 ] ASF GitHub Bot logged work on MATH-1573: Author: ASF GitHub Bot Created on: 06/Aug/21 07:17 Start Date: 06/Aug/21 07:17 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #194: URL: https://github.com/apache/commons-math/pull/194#issuecomment-894057681 [](https://coveralls.io/builds/41953548) Coverage increased (+0.0007%) to 90.473% when pulling **8de9db8679f0efae600ce10cd99de741086c0693 on arturobernalg:feature/MATH-1573** into **771a21815b4329302fc174ef2ad80b46ed8247f0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634974) Time Spent: 2h (was: 1h 50m) > Redundant local variable > > > Key: MATH-1573 > URL: https://issues.apache.org/jira/browse/MATH-1573 > Project: Commons Math > Issue Type: Sub-task >Reporter: Arturo Bernal >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Remove redundant local variable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] coveralls commented on pull request #194: MATH-1573 - Redundant local variable
coveralls commented on pull request #194: URL: https://github.com/apache/commons-math/pull/194#issuecomment-894057681 [](https://coveralls.io/builds/41953548) Coverage increased (+0.0007%) to 90.473% when pulling **8de9db8679f0efae600ce10cd99de741086c0693 on arturobernalg:feature/MATH-1573** into **771a21815b4329302fc174ef2ad80b46ed8247f0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
