[GitHub] [commons-io] arturobernalg commented on pull request #253: Minor changes
arturobernalg commented on pull request #253: URL: https://github.com/apache/commons-io/pull/253#issuecomment-912917308 > Let's leave these internal API sigatures alone for now. Hi @garydgregory understood TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MATH-1589) Remove spurious "throws" clauses
[ https://issues.apache.org/jira/browse/MATH-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated MATH-1589: -- Fix Version/s: (was: 4.0) 4.X > Remove spurious "throws" clauses > > > Key: MATH-1589 > URL: https://issues.apache.org/jira/browse/MATH-1589 > Project: Commons Math > Issue Type: Task >Reporter: Gilles Sadowski >Priority: Trivial > Fix For: 4.X > > > Many methods uselessly declare unchecked exceptions in a "throws" clause. > The visual noise should be removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1576) Reinstate "checkstyle"
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated MATH-1576: -- Fix Version/s: (was: 4.0) 4.X > Reinstate "checkstyle" > -- > > Key: MATH-1576 > URL: https://issues.apache.org/jira/browse/MATH-1576 > Project: Commons Math > Issue Type: Sub-task >Reporter: Gilles Sadowski >Priority: Critical > Labels: checkstyle > Fix For: 4.X > > > Modularization configuration was copied from Commons Numbers that used a > newer Checkstyle with a different syntax. The checks trigger more than 31000 > errors in Commons Math; so all checks have been disabled. :( > The syntax of the configuration that worked before modularization should be > adapted to the new syntax... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1275) EventHandler and StepHandler interfaces do not provide derivatives
[ https://issues.apache.org/jira/browse/MATH-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated MATH-1275: -- Fix Version/s: (was: 4.0) 4.X > EventHandler and StepHandler interfaces do not provide derivatives > -- > > Key: MATH-1275 > URL: https://issues.apache.org/jira/browse/MATH-1275 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.5 >Reporter: Luc Maisonobe >Priority: Major > Fix For: 4.X > > > The EventHandler and StepHandler interfaces allow passing the current state > vector to user code, but not its derivatives. This is a pity because the > integrator does know these derivatives as they are the basis from which > everything else is computed. The data is lying around, just not passed to > user. > This is a design issue and as it affects user interfaces, it cannot be fixed > before 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1392) OLS/GLS Regression sufficient data test is overly aggressive when there is no intercept term
[ https://issues.apache.org/jira/browse/MATH-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated MATH-1392: -- Fix Version/s: (was: 4.0) 4.X > OLS/GLS Regression sufficient data test is overly aggressive when there is no > intercept term > > > Key: MATH-1392 > URL: https://issues.apache.org/jira/browse/MATH-1392 > Project: Commons Math > Issue Type: Bug >Affects Versions: 3.6, 3.6.1 >Reporter: Phil Steitz >Priority: Major > Fix For: 4.X > > > See https://github.com/Hipparchus-Math/hipparchus/issues/13 > for full description and patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MATH-1378) KMeansPlusPlusClusterer optimize seeding procedure, by computing sum of squared distances outside the loop.
[
https://issues.apache.org/jira/browse/MATH-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated MATH-1378:
--
Fix Version/s: (was: 4.0)
4.X
> KMeansPlusPlusClusterer optimize seeding procedure, by computing sum of
> squared distances outside the loop.
> ---
>
> Key: MATH-1378
> URL: https://issues.apache.org/jira/browse/MATH-1378
> Project: Commons Math
> Issue Type: Improvement
>Reporter: Artem Barger
>Priority: Major
> Fix For: 4.X
>
> Attachments: MATH-1378.patch
>
>
> Currently in KMeansPlusPlusClusterer class, function which implements
> initial clusters seeding *chooseInitialCenters*, has following computation
> executed inside the while loop cycle:
> {code}
> while (resultSet.size() < k) {
> // Sum up the squared distances for the points in pointList not
> // already taken.
> double distSqSum = 0.0;
> for (int i = 0; i < numPoints; i++) {
> if (!taken[i]) {
> distSqSum += minDistSquared[i];
> }
> }
> // Rest skipped for simplicity
> {code}
> While computation of this sum could be produced once outside the loop and
> latter adjusted according to the values of minimum distances to the centers
> set. E.g.:
> {code}
> // Sum up the squared distances for the points in pointList not
> // already taken.
> double distSqSum = 0.0;
> // There is no need to compute sum of squared distances within the
> "while" loop
> // we can compute initial value ones and maintain deltas in the loop.
> for (int i = 0; i < numPoints; i++) {
> if (!taken[i]) {
> distSqSum += minDistSquared[i];
> }
> }
> while (resultSet.size() < k) {
> // Add one new data point as a center. Each point x is chosen with
> // probability proportional to D(x)2
> final double r = random.nextDouble() * distSqSum;
> // The index of the next point to be added to the resultSet.
> int nextPointIndex = -1;
> // Sum through the squared min distances again, stopping when
> // sum >= r.
> double sum = 0.0;
> for (int i = 0; i < numPoints; i++) {
> if (!taken[i]) {
> sum += minDistSquared[i];
> if (sum >= r) {
> nextPointIndex = i;
> break;
> }
> }
> }
> // If it's not set to >= 0, the point wasn't found in the previous
> // for loop, probably because distances are extremely small.
> Just pick
> // the last available point.
> if (nextPointIndex == -1) {
> for (int i = numPoints - 1; i >= 0; i--) {
> if (!taken[i]) {
> nextPointIndex = i;
> break;
> }
> }
> }
> // We found one.
> if (nextPointIndex >= 0) {
> final T p = pointList.get(nextPointIndex);
> resultSet.add(new CentroidCluster (p));
> // Mark it as taken.
> taken[nextPointIndex] = true;
> if (resultSet.size() < k) {
> // Now update elements of minDistSquared. We only have
> to compute
> // the distance to the new center to do this.
> for (int j = 0; j < numPoints; j++) {
> // Only have to worry about the points still not
> taken.
> if (!taken[j]) {
> double d = distance(p, pointList.get(j));
> // Subtracting the old value.
> distSqSum -= minDistSquared[j];
> // Update minimum distance.
> minDistSquared[j] = FastMath.min(d*d,
> minDistSquared[j]);
> // Adjust the overall sum of squared distances.
> distSqSum += minDistSquared[j];
> }
> }
> }
> } else {
> // None found --
> // Break from the while loop to prevent
> // an infinite loop.
> break;
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MATH-1535) MathInternalError in KolmogorovSmirnovTest in case of many ties
[
https://issues.apache.org/jira/browse/MATH-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated MATH-1535:
--
Fix Version/s: (was: 4.0)
4.X
> MathInternalError in KolmogorovSmirnovTest in case of many ties
> ---
>
> Key: MATH-1535
> URL: https://issues.apache.org/jira/browse/MATH-1535
> Project: Commons Math
> Issue Type: Bug
>Affects Versions: 3.6.1
> Environment: commons-math 3.6.1, oracle jdk11 for windows
>Reporter: Steffen Herbold
>Priority: Major
> Fix For: 4.X
>
>
> I encounter a math internal error with some very ugly data that has lots of
> ties. The code below triggers the exception. I could try to build in a
> detection in my code that identifies this strange case where the generated
> data has many ties, to avoid this. But I guess the MathInternalError in
> commons-math should still be avoided.
>
> {code:java}
> // works
> double[] sample1 = new double[] {0.8767630865438496, 0.9998809418147052,
> 0.999715463531, 0.985849345421};
> double[] sample2 = new double[] {1.0, 1.0, 1.0, 1.0};
> ksTest.kolmogorovSmirnovTest(sample1, sample2);
> // fails with illegal state
> double[] sample3 = new double[] {0.8767630865438496, 0.9998809418147052,
> 0.999715463531, 0.985849345421, 0.973584315883326,
> 0.999875782982, 0.994, 0.99908233, 1.0,
> 0.999890925574, 0.998345734327, 0.999350772448,
> 0.426, 0.147040688201, 0.9922, 1.0, 1.0,
> 0.9919050954798272, 0.8649014770687263, 0.9990869497973084,
> 0.9993222540990464, 0.9998189, 0.9365,
> 0.9790934801762917, 0.578695006303, 0.9998,
> 0.9996166, 0.5546, 0.99908036, 0.999744,
> 0.99880265, 0.9079334221214075, 0.9794398308007372,
> 0.044231134367, 0.9813, 0.957841707683,
> 0.9277678892094009, 0.48269893843, 0.999886132888,
> 0.998909699096, 0.099536620326, 0.62217623,
> 0.9138936987350447, 0.99779976, 0.9998822, 0.79247207911,
> 0.9926904388316407, 1.0, 0.8814, 1.0, 0.9892505696426215,
> 0.996514123723, 0.9429, 0.95399116,
> 0.9948221, 0.7358264887843119, 0.94098534, 1.0,
> 0.986456748472, 1.0, 0.99921501, 0.9996,
> 0.9944, 0.9473070068606853, 0.9993714060209042,
> 0.999409098718, 0.999592791519, 0.9805};
> double[] sample4 = new double[] {1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,
> 1.0};
> ksTest.kolmogorovSmirnovTest(sample3, sample4);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-727) FilenameUtils.directoryContains() and FileUtils.directoryContains() return wrong result when parent and child have the same path prefix
[
https://issues.apache.org/jira/browse/IO-727?focusedWorklogId=646481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646481
]
ASF GitHub Bot logged work on IO-727:
-
Author: ASF GitHub Bot
Created on: 03/Sep/21 21:16
Start Date: 03/Sep/21 21:16
Worklog Time Spent: 10m
Work Description: garydgregory closed pull request #217:
URL: https://github.com/apache/commons-io/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646481)
Time Spent: 1h 10m (was: 1h)
> FilenameUtils.directoryContains() and FileUtils.directoryContains() return
> wrong result when parent and child have the same path prefix
> ---
>
> Key: IO-727
> URL: https://issues.apache.org/jira/browse/IO-727
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Reporter: Trung Pham
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> FilenameUtils.directoryContains() and FileUtils.directoryContains() will
> return `true` with the following input.
> {code:java}
> canonicalParent: /path/foo
> canonicalChild: /path/foobar
> {code}
> There were several issues on this but the problem still remains.
> IO-423 didn't do anything.
> IO-466 test case added in
> [676c03|https://github.com/apache/commons-io/commit/67325cf97946f053da51dd358a9ffca0a9676c03]
> just happened to passed because the input file didn't exist.
> Github PR: https://github.com/apache/commons-io/pull/217
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] garydgregory closed pull request #217: IO-727: FilenameUtils directoryContains() should handle files with the same prefix
garydgregory closed pull request #217: URL: https://github.com/apache/commons-io/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-727) FilenameUtils.directoryContains() and FileUtils.directoryContains() return wrong result when parent and child have the same path prefix
[
https://issues.apache.org/jira/browse/IO-727?focusedWorklogId=646444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646444
]
ASF GitHub Bot logged work on IO-727:
-
Author: ASF GitHub Bot
Created on: 03/Sep/21 19:32
Start Date: 03/Sep/21 19:32
Worklog Time Spent: 10m
Work Description: trungPa commented on a change in pull request #217:
URL: https://github.com/apache/commons-io/pull/217#discussion_r702121836
##
File path:
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
##
@@ -134,9 +134,16 @@ public void testSameFile() throws IOException {
}
@Test
-public void testIO466() throws IOException {
Review comment:
The fix has been applied in d42b9286eb7a534f1b2b6243858ff7ef6fcac14c so
isn't it time to close this pr?
anyway, I've rebased and restored the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646444)
Time Spent: 1h (was: 50m)
> FilenameUtils.directoryContains() and FileUtils.directoryContains() return
> wrong result when parent and child have the same path prefix
> ---
>
> Key: IO-727
> URL: https://issues.apache.org/jira/browse/IO-727
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Reporter: Trung Pham
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> FilenameUtils.directoryContains() and FileUtils.directoryContains() will
> return `true` with the following input.
> {code:java}
> canonicalParent: /path/foo
> canonicalChild: /path/foobar
> {code}
> There were several issues on this but the problem still remains.
> IO-423 didn't do anything.
> IO-466 test case added in
> [676c03|https://github.com/apache/commons-io/commit/67325cf97946f053da51dd358a9ffca0a9676c03]
> just happened to passed because the input file didn't exist.
> Github PR: https://github.com/apache/commons-io/pull/217
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] trungPa commented on a change in pull request #217: IO-727: FilenameUtils directoryContains() should handle files with the same prefix
trungPa commented on a change in pull request #217:
URL: https://github.com/apache/commons-io/pull/217#discussion_r702121836
##
File path:
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
##
@@ -134,9 +134,16 @@ public void testSameFile() throws IOException {
}
@Test
-public void testIO466() throws IOException {
Review comment:
The fix has been applied in d42b9286eb7a534f1b2b6243858ff7ef6fcac14c so
isn't it time to close this pr?
anyway, I've rebased and restored the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on a change in pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo commented on a change in pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#discussion_r701554900
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##
@@ -1355,15 +1372,6 @@ public void testJoin_Objectarray() {
assertEquals("foo2", StringUtils.join(MIXED_TYPE_LIST));
}
-@Disabled
Review comment:
This is exactly the test that exposes this bug: ```testLang1593```.
Please find the same assertion here ```testJoin_ArrayOfInt``` in
```StringUtilsTest```
``` assertEquals("1,2", StringUtils.join(INT_PRIM_LIST, SEPARATOR));```
When it comes to coverage, it looks like ```join``` methods have 100%
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (BCEL-359) ClassGenException in Pass3aVerifier
James Kukucka created BCEL-359:
--
Summary: ClassGenException in Pass3aVerifier
Key: BCEL-359
URL: https://issues.apache.org/jira/browse/BCEL-359
Project: Commons BCEL
Issue Type: Bug
Components: Verifier
Affects Versions: 6.5.0
Environment:
{code:java}
public class ParserTest {
public void testWithInputStream(InputStream inputStream) throws IOException
{
JavaClass clazz;
try {
clazz = new ClassParser(inputStream, "Hello.class").parse();
} catch (ClassFormatException e) {
// ClassFormatException thrown by the parser is just invalid input
Assume.assumeNoException(e);
return;
}
// Any non-IOException thrown here should be marked a failure
// (including ClassFormatException)
verifyJavaClass(clazz);
}
private void verifyJavaClass( JavaClass javaClass) throws IOException {
try {
Repository.addClass(javaClass);
Verifier verifier =
StatelessVerifierFactory.getVerifier(javaClass.getClassName());
VerificationResult result;
result = verifier.doPass1();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
result = verifier.doPass2();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
for (int i = 0; i < javaClass.getMethods().length; i++) {
result = verifier.doPass3a(i);
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
}
} finally {
Repository.clearCache();
}
}
public static void main(String[] args) throws IOException {
ParserTest pt = new ParserTest();
FileInputStream fis = new FileInputStream(new
File("/home/jamesk/bcel_bugs/classgen.input"));
pt.testWithInputStream(fis);
}
}
{code}
Reporter: James Kukucka
Attachments: classgen.input
Found while conducting fuzzing research. ClassGenException within
Pass3aVerifier.
{code:java}
Exception in thread "main" org.apache.bcel.generic.ClassGenException:
org.apache.bcel.generic.ArrayType [[Ljava/util/List; does not represent an
ObjectType
at
org.apache.bcel.generic.FieldOrMethod.getLoadClassType(FieldOrMethod.java:138)
at
org.apache.bcel.verifier.statics.Pass3aVerifier$InstOperandConstraintVisitor.visitLoadClass(Pass3aVerifier.java:521)
at org.apache.bcel.generic.INVOKESPECIAL.accept(INVOKESPECIAL.java:85)
at
org.apache.bcel.generic.InstructionHandle.accept(InstructionHandle.java:293)
at
org.apache.bcel.verifier.statics.Pass3aVerifier.pass3StaticInstructionOperandsChecks(Pass3aVerifier.java:443)
at
org.apache.bcel.verifier.statics.Pass3aVerifier.do_verify(Pass3aVerifier.java:208)
at org.apache.bcel.verifier.PassVerifier.verify(PassVerifier.java:70)
at org.apache.bcel.verifier.Verifier.doPass3a(Verifier.java:88)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-727) FilenameUtils.directoryContains() and FileUtils.directoryContains() return wrong result when parent and child have the same path prefix
[
https://issues.apache.org/jira/browse/IO-727?focusedWorklogId=646362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646362
]
ASF GitHub Bot logged work on IO-727:
-
Author: ASF GitHub Bot
Created on: 03/Sep/21 16:09
Start Date: 03/Sep/21 16:09
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #217:
URL: https://github.com/apache/commons-io/pull/217#discussion_r702015507
##
File path:
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
##
@@ -134,9 +134,16 @@ public void testSameFile() throws IOException {
}
@Test
-public void testIO466() throws IOException {
Review comment:
Please don't remove an existing test, it makes reviewing harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646362)
Time Spent: 50m (was: 40m)
> FilenameUtils.directoryContains() and FileUtils.directoryContains() return
> wrong result when parent and child have the same path prefix
> ---
>
> Key: IO-727
> URL: https://issues.apache.org/jira/browse/IO-727
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Reporter: Trung Pham
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> FilenameUtils.directoryContains() and FileUtils.directoryContains() will
> return `true` with the following input.
> {code:java}
> canonicalParent: /path/foo
> canonicalChild: /path/foobar
> {code}
> There were several issues on this but the problem still remains.
> IO-423 didn't do anything.
> IO-466 test case added in
> [676c03|https://github.com/apache/commons-io/commit/67325cf97946f053da51dd358a9ffca0a9676c03]
> just happened to passed because the input file didn't exist.
> Github PR: https://github.com/apache/commons-io/pull/217
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #217: IO-727: fix directoryContains() handling files with the same prefix
garydgregory commented on a change in pull request #217:
URL: https://github.com/apache/commons-io/pull/217#discussion_r702015507
##
File path:
src/test/java/org/apache/commons/io/FileUtilsDirectoryContainsTestCase.java
##
@@ -134,9 +134,16 @@ public void testSameFile() throws IOException {
}
@Test
-public void testIO466() throws IOException {
Review comment:
Please don't remove an existing test, it makes reviewing harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] garydgregory edited a comment on pull request #253: Minor changes:
garydgregory edited a comment on pull request #253: URL: https://github.com/apache/commons-io/pull/253#issuecomment-911673494 Let's leave these internal API sigatures alone for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #269: Fix usage of assertNotNull
garydgregory merged pull request #269: URL: https://github.com/apache/commons-io/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (BCEL-358) IllegalArgumentException when loading abstract classes
James Kukucka created BCEL-358:
--
Summary: IllegalArgumentException when loading abstract classes
Key: BCEL-358
URL: https://issues.apache.org/jira/browse/BCEL-358
Project: Commons BCEL
Issue Type: Bug
Components: Verifier
Affects Versions: 6.5.0
Environment: {code:java}
public class ParserTest {
public void testWithInputStream(InputStream inputStream) throws IOException
{
JavaClass clazz;
try {
clazz = new ClassParser(inputStream, "Hello.class").parse();
} catch (ClassFormatException e) {
// ClassFormatException thrown by the parser is just invalid input
Assume.assumeNoException(e);
return;
}
// Any non-IOException thrown here should be marked a failure
// (including ClassFormatException)
verifyJavaClass(clazz);
}
private void verifyJavaClass( JavaClass javaClass) throws IOException {
try {
Repository.addClass(javaClass);
Verifier verifier =
StatelessVerifierFactory.getVerifier(javaClass.getClassName());
VerificationResult result;
result = verifier.doPass1();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
result = verifier.doPass2();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
for (int i = 0; i < javaClass.getMethods().length; i++) {
result = verifier.doPass3a(i);
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
}
} finally {
Repository.clearCache();
}
}
public static void main(String[] args) throws IOException {
ParserTest pt = new ParserTest();
FileInputStream fis = new FileInputStream(new
File("/home/jamesk/bcel_bugs/illegalarg.input"));
pt.testWithInputStream(fis);
}
}
{code}
Reporter: James Kukucka
Attachments: illegalarg.input
Found during fuzzing research. IllegalArgumentException due to empty class name
passed when loading interfaces.
Stack Trace:
{code:java}
Exception in thread "main" java.lang.IllegalArgumentException: Invalid class
name
at
org.apache.bcel.util.AbstractClassPathRepository.loadClass(AbstractClassPathRepository.java:67)
at
org.apache.bcel.util.MemorySensitiveClassPathRepository.loadClass(MemorySensitiveClassPathRepository.java:33)
at org.apache.bcel.classfile.JavaClass.getInterfaces(JavaClass.java:847)
at
org.apache.bcel.verifier.statics.Pass3aVerifier$InstOperandConstraintVisitor.getMethodRecursive(Pass3aVerifier.java:1181)
at
org.apache.bcel.verifier.statics.Pass3aVerifier$InstOperandConstraintVisitor.visitINVOKESTATIC(Pass3aVerifier.java:1279)
at org.apache.bcel.generic.INVOKESTATIC.accept(INVOKESTATIC.java:86)
at
org.apache.bcel.generic.InstructionHandle.accept(InstructionHandle.java:293)
at
org.apache.bcel.verifier.statics.Pass3aVerifier.pass3StaticInstructionOperandsChecks(Pass3aVerifier.java:443)
at
org.apache.bcel.verifier.statics.Pass3aVerifier.do_verify(Pass3aVerifier.java:208)
at org.apache.bcel.verifier.PassVerifier.verify(PassVerifier.java:70)
at org.apache.bcel.verifier.Verifier.doPass3a(Verifier.java:88)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (BCEL-357) StringIndexOutOfBoundsException when Verifying Java Method Name in Pass2Verifier
James Kukucka created BCEL-357:
--
Summary: StringIndexOutOfBoundsException when Verifying Java
Method Name in Pass2Verifier
Key: BCEL-357
URL: https://issues.apache.org/jira/browse/BCEL-357
Project: Commons BCEL
Issue Type: Bug
Components: Verifier
Affects Versions: 6.5.0
Environment: {code:java}
public class ParserTest {
public void testWithInputStream(InputStream inputStream) throws IOException
{
JavaClass clazz;
try {
clazz = new ClassParser(inputStream, "Hello.class").parse();
} catch (ClassFormatException e) {
// ClassFormatException thrown by the parser is just invalid input
Assume.assumeNoException(e);
return;
}
// Any non-IOException thrown here should be marked a failure
// (including ClassFormatException)
verifyJavaClass(clazz);
}
private void verifyJavaClass( JavaClass javaClass) throws IOException {
try {
Repository.addClass(javaClass);
Verifier verifier =
StatelessVerifierFactory.getVerifier(javaClass.getClassName());
VerificationResult result;
result = verifier.doPass1();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
result = verifier.doPass2();
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
for (int i = 0; i < javaClass.getMethods().length; i++) {
result = verifier.doPass3a(i);
assumeThat(result.getMessage(), result.getStatus(),
is(VerificationResult.VERIFIED_OK));
}
} finally {
Repository.clearCache();
}
}
public static void main(String[] args) throws IOException {
ParserTest pt = new ParserTest();
FileInputStream fis = new FileInputStream(new
File("/home/jamesk/bcel_bugs/str_index.input"));
pt.testWithInputStream(fis);
}
}
{code}
Reporter: James Kukucka
Attachments: str_index.input
StringIndexOutOfBoundsException found during fuzzing research. Attaching file
that triggred the Exception.
Stack trace:
{code:java}
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String
index out of range: 0
at java.lang.String.charAt(String.java:658)
at
org.apache.bcel.verifier.statics.Pass2Verifier.validJavaLangMethodName(Pass2Verifier.java:1458)
at
org.apache.bcel.verifier.statics.Pass2Verifier.validMethodName(Pass2Verifier.java:1432)
at
org.apache.bcel.verifier.statics.Pass2Verifier.validClassMethodName(Pass2Verifier.java:1448)
at
org.apache.bcel.verifier.statics.Pass2Verifier.access$900(Pass2Verifier.java:85)
at
org.apache.bcel.verifier.statics.Pass2Verifier$FAMRAV_Visitor.visitConstantMethodref(Pass2Verifier.java:1350)
at
org.apache.bcel.classfile.ConstantMethodref.accept(ConstantMethodref.java:68)
at
org.apache.bcel.classfile.DescendingVisitor.visitConstantMethodref(DescendingVisitor.java:347)
at
org.apache.bcel.classfile.ConstantMethodref.accept(ConstantMethodref.java:68)
at
org.apache.bcel.classfile.DescendingVisitor.visitConstantPool(DescendingVisitor.java:268)
at org.apache.bcel.classfile.ConstantPool.accept(ConstantPool.java:87)
at
org.apache.bcel.classfile.DescendingVisitor.visitJavaClass(DescendingVisitor.java:104)
at org.apache.bcel.classfile.JavaClass.accept(JavaClass.java:213)
at
org.apache.bcel.classfile.DescendingVisitor.visit(DescendingVisitor.java:84)
at
org.apache.bcel.verifier.statics.Pass2Verifier.field_and_method_refs_are_valid(Pass2Verifier.java:1290)
at
org.apache.bcel.verifier.statics.Pass2Verifier.do_verify(Pass2Verifier.java:161)
at org.apache.bcel.verifier.PassVerifier.verify(PassVerifier.java:70)
at org.apache.bcel.verifier.Verifier.doPass2(Verifier.java:75)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (IMAGING-312) Alpha-channel setting not interpreted from ExtraSamples tag
[ https://issues.apache.org/jira/browse/IMAGING-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Lucas updated IMAGING-312: --- Description: Commons Imaging sometimes misinterprets TIFF files that have 4-byte RGB samples but do not define alpha. In some cases, these images are treated as semi-transparent when they should be opaque. Commons Imaging is not unique in this regard... Windows Photo Viewer does the same thing. The TIFF specification allows RGB images to be encoded with 4-bytes per pixel. It would be natural to assume (as Commons Imaging does) that the 4th byte is the alpha channel and that it would have values of 0xff in the case where pixels were opaque. However, the interpretation of the 4th byte depends on information in the TIFF "ExtraSamples" tag. It turns out that there are images in-the-wild that use 4 bytes, but populate the 4th byte with junk values. For example, there are a number of older aerial photographs from the US Geological Survey (USGS) that do this. These images give an ExtraSamples tag with a value of zero. But the TIFF specification calls for images to be treated as having alpha channels only if the ExtraSamples field carries a value of either 1 or 2. When ExtraSamples has a value of 0, the 4th byte is to be ignored. So while the USGS TIFF files are in compliance with the TIFF specification, they use an unintuitive behavior. Because the Commons Imaging library assumes that the 4th byte would be specified with valid-alpha values, it does not render the images correctly. There are many examples of this phenomenon on the USGS Earth Explorer website. One specific example: * High Resolution Orthoimagery * Dataset: 201203_connecticut_state_lot1_ct_0x3000m_utm_cnir * Entity: 2818289_18TYL425825 * File: 18tyl425825.tif *Proposed Fix* I propose to do the following: * Extend the TiffImageParser logic for detecting alpha to assume hasAlpha is true if and only if the ExtraSamples tag is supplied and contains values 1 or 2. * Provide a hasAlpha accessor for the ImageBuilder class (is should really have one anyway) * Enhance the DataReaderStrips and DataReaderTiles classes to check hasAlpha when processing RGB images that have 4 samples per pixel samples. *Concerns* At this time, I am not sure what to do if an RGB TIFF image uses 4-samples per pixel but the ExtraSamples tag is not provided. At this time, I have not seen an example of this, but my collection of sample TIFF files is rather narrow and I would not rule it out. was: Commons Imaging sometimes misinterprets TIFF files that have 4-byte RGB samples but do not define alpha. In some cases, these images are treated as semi-transparent when they should be opaque. Commons Imaging is not unique in this regard... Windows Photo Viewer does the same thing. The TIFF specification allows RGB images to be encoded with 4-bytes per pixel. It would be natural to assume (as Commons Imaging does) that the 4th byte is the alpha channel and that it would have values of 0xff in the case where pixels were opaque. However, the interpretation of the 4th byte depends on information in the TIFF "ExtraSamples" tag. It turns out that there are images in-the-wild that use 4 bytes, but populate the 4th byte with junk values. For example, there are a number of older aerial photographs from the US Geological Survey (USGS) that do this. These images give an ExtraSamples tag with a value of zero. But the TIFF specification calls for images to be treated as having alpha channels only if the ExtraSamples field carries a value of either 1 or 2. When ExtraSamples has a value of 0, the 4th byte is to be ignored. There are many examples of this phenomenon on the USGS Earth Explorer website. One specific example: * High Resolution Orthoimagery * Dataset: 201203_connecticut_state_lot1_ct_0x3000m_utm_cnir * Entity: 2818289_18TYL425825 * File: 18tyl425825.tif *Proposed Fix* I propose to do the following: * Extend the TiffImageParser logic for detecting alpha to assume hasAlpha is true if and only if the ExtraSamples tag is supplied and contains values 1 or 2. * Provide a hasAlpha accessor for the ImageBuilder class (is should really have one anyway) * Enhance the DataReaderStrips and DataReaderTiles classes to check hasAlpha when processing RGB images that have 4 samples per pixel samples. *Concerns* At this time, I am not sure what to do if an RGB TIFF image uses 4-samples per pixel but the ExtraSamples tag is not provided. At this time, I have not seen an example of this, but my collection of sample TIFF files is rather narrow and I would not rule it out. > Alpha-channel setting not interpreted from ExtraSamples tag > --- > > Key: IMAGING-312 > URL: https://issues.apache.org/jira/browse/IMAGING-312 >
[jira] [Created] (IMAGING-312) Alpha-channel setting not interpreted from ExtraSamples tag
Gary Lucas created IMAGING-312: -- Summary: Alpha-channel setting not interpreted from ExtraSamples tag Key: IMAGING-312 URL: https://issues.apache.org/jira/browse/IMAGING-312 Project: Commons Imaging Issue Type: Bug Components: Format: TIFF Affects Versions: 1.0-alpha2 Environment: Reporter: Gary Lucas Commons Imaging sometimes misinterprets TIFF files that have 4-byte RGB samples but do not define alpha. In some cases, these images are treated as semi-transparent when they should be opaque. Commons Imaging is not unique in this regard... Windows Photo Viewer does the same thing. The TIFF specification allows RGB images to be encoded with 4-bytes per pixel. It would be natural to assume (as Commons Imaging does) that the 4th byte is the alpha channel and that it would have values of 0xff in the case where pixels were opaque. However, the interpretation of the 4th byte depends on information in the TIFF "ExtraSamples" tag. It turns out that there are images in-the-wild that use 4 bytes, but populate the 4th byte with junk values. For example, there are a number of older aerial photographs from the US Geological Survey (USGS) that do this. These images give an ExtraSamples tag with a value of zero. But the TIFF specification calls for images to be treated as having alpha channels only if the ExtraSamples field carries a value of either 1 or 2. When ExtraSamples has a value of 0, the 4th byte is to be ignored. There are many examples of this phenomenon on the USGS Earth Explorer website. One specific example: * High Resolution Orthoimagery * Dataset: 201203_connecticut_state_lot1_ct_0x3000m_utm_cnir * Entity: 2818289_18TYL425825 * File: 18tyl425825.tif *Proposed Fix* I propose to do the following: * Extend the TiffImageParser logic for detecting alpha to assume hasAlpha is true if and only if the ExtraSamples tag is supplied and contains values 1 or 2. * Provide a hasAlpha accessor for the ImageBuilder class (is should really have one anyway) * Enhance the DataReaderStrips and DataReaderTiles classes to check hasAlpha when processing RGB images that have 4 samples per pixel samples. *Concerns* At this time, I am not sure what to do if an RGB TIFF image uses 4-samples per pixel but the ExtraSamples tag is not provided. At this time, I have not seen an example of this, but my collection of sample TIFF files is rather narrow and I would not rule it out. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646346
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 14:52
Start Date: 03/Sep/21 14:52
Worklog Time Spent: 10m
Work Description: san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912598323
@garydgregory
Am not able to create PR now due to access issue
here is the test
```
org.apache.commons.csv.CSVParserTest#testParseWithDoublePipeDelimiter
@Test
public void testParseWithDoublePipeDelimiter() throws Exception {
final Reader in = new StringReader("a||b||c||df");
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(in,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
assertEquals("a,b,c,d,,f", stringBuilder.toString());
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646346)
Time Spent: 3.5h (was: 3h 20m)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646345
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 14:52
Start Date: 03/Sep/21 14:52
Worklog Time Spent: 10m
Work Description: san4you88 commented on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912598323
Am not able to create PR now due to access issue
here is the test
```
org.apache.commons.csv.CSVParserTest#testParseWithDoublePipeDelimiter
@Test
public void testParseWithDoublePipeDelimiter() throws Exception {
final Reader in = new StringReader("a||b||c||df");
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(in,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
assertEquals("a,b,c,d,,f", stringBuilder.toString());
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646345)
Time Spent: 3h 20m (was: 3h 10m)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] san4you88 edited a comment on pull request #76: [CSV-206] Add support for String delimiters
san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912598323
@garydgregory
Am not able to create PR now due to access issue
here is the test
```
org.apache.commons.csv.CSVParserTest#testParseWithDoublePipeDelimiter
@Test
public void testParseWithDoublePipeDelimiter() throws Exception {
final Reader in = new StringReader("a||b||c||df");
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(in,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
assertEquals("a,b,c,d,,f", stringBuilder.toString());
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-csv] san4you88 commented on pull request #76: [CSV-206] Add support for String delimiters
san4you88 commented on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912598323
Am not able to create PR now due to access issue
here is the test
```
org.apache.commons.csv.CSVParserTest#testParseWithDoublePipeDelimiter
@Test
public void testParseWithDoublePipeDelimiter() throws Exception {
final Reader in = new StringReader("a||b||c||df");
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(in,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
assertEquals("a,b,c,d,,f", stringBuilder.toString());
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #269: fix wrong usage of assertNotNull
coveralls commented on pull request #269: URL: https://github.com/apache/commons-io/pull/269#issuecomment-912580483 [](https://coveralls.io/builds/42641932) Coverage increased (+0.1%) to 89.251% when pulling **820cfd9af08897d64329051f8c86378a9367c88e on dfa1:fix-745** into **072fa707f7cd41a70bcec644e1b393e3955dcc75 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-745) wrong assertNotNull
[
https://issues.apache.org/jira/browse/IO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409523#comment-17409523
]
Gary D. Gregory commented on IO-745:
My opinion here, others may disagree: Please don't create Jira tickets for
trivial and non-functional changes, it's just more noise for me to deal with,
more steps to round trip changes.
> wrong assertNotNull
>
>
> Key: IO-745
> URL: https://issues.apache.org/jira/browse/IO-745
> Project: Commons IO
> Issue Type: Test
>Affects Versions: 2.11.0
>Reporter: Davide Angelocola
>Priority: Minor
> Attachments: 0001-fix-wrong-usage-of-assertNotNull.patch
>
>
> Greetings from long time user of this library :)
> Intellij spotted this small error in *LineIteratorTestCase*:
> {code:java}
> assertNotNull("Line expected", iterator.next());
> assertTrue(iterator.hasNext(), "More expected"); {code}
> *assertNotNull* is using "Line expected" as actual parameter.
> The right order is given in the next *assertTrue* method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IO-745) wrong assertNotNull
[
https://issues.apache.org/jira/browse/IO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409522#comment-17409522
]
Davide Angelocola commented on IO-745:
--
created PR in github: [https://github.com/apache/commons-io/pull/269]
> wrong assertNotNull
>
>
> Key: IO-745
> URL: https://issues.apache.org/jira/browse/IO-745
> Project: Commons IO
> Issue Type: Test
>Affects Versions: 2.11.0
>Reporter: Davide Angelocola
>Priority: Minor
> Attachments: 0001-fix-wrong-usage-of-assertNotNull.patch
>
>
> Greetings from long time user of this library :)
> Intellij spotted this small error in *LineIteratorTestCase*:
> {code:java}
> assertNotNull("Line expected", iterator.next());
> assertTrue(iterator.hasNext(), "More expected"); {code}
> *assertNotNull* is using "Line expected" as actual parameter.
> The right order is given in the next *assertTrue* method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] dfa1 commented on pull request #269: fix wrong usage of assertNotNull
dfa1 commented on pull request #269: URL: https://github.com/apache/commons-io/pull/269#issuecomment-912567940 @garydgregory can you please review this as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dfa1 opened a new pull request #269: fix wrong usage of assertNotNull
dfa1 opened a new pull request #269:
URL: https://github.com/apache/commons-io/pull/269
Signature of assertNoNull() is taking "actual" as first parameter:
public static void assertNotNull(Object actual, String message) {
AssertNotNull.assertNotNull(actual, message);
}
Signed-off-by: Davide Angelocola
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #207: Minors improvements:
garydgregory commented on pull request #207: URL: https://github.com/apache/commons-vfs/pull/207#issuecomment-912567248 > > Don't change the internal APIs for now please. > > HI @garydgregory > What you mean? > TY Don't change method signatures, sorry I was not more precise in my comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-746) removing redundant casts and conversions
[ https://issues.apache.org/jira/browse/IO-746?focusedWorklogId=646316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646316 ] ASF GitHub Bot logged work on IO-746: - Author: ASF GitHub Bot Created on: 03/Sep/21 14:04 Start Date: 03/Sep/21 14:04 Worklog Time Spent: 10m Work Description: dfa1 commented on pull request #267: URL: https://github.com/apache/commons-io/pull/267#issuecomment-912564798 thank you guys :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646316) Time Spent: 50m (was: 40m) > removing redundant casts and conversions > > > Key: IO-746 > URL: https://issues.apache.org/jira/browse/IO-746 > Project: Commons IO > Issue Type: Improvement >Reporter: Davide Angelocola >Priority: Minor > Fix For: 2.12.0 > > Attachments: 0001-dropping-unnecessary-casts-and-conversions.patch > > Time Spent: 50m > Remaining Estimate: 0h > > See attached patch: > [^0001-dropping-unnecessary-casts-and-conversions.patch] > Spotted by IntelliJ IDEA. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] dfa1 commented on pull request #267: IO-746: Drop unnecessary casts and conversions
dfa1 commented on pull request #267: URL: https://github.com/apache/commons-io/pull/267#issuecomment-912564798 thank you guys :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] arturobernalg commented on pull request #207: Minors improvements:
arturobernalg commented on pull request #207: URL: https://github.com/apache/commons-vfs/pull/207#issuecomment-912564231 > Don't change the internal APIs for now please. HI @garydgregory What you mean? TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (IO-746) removing redundant casts and conversions
[ https://issues.apache.org/jira/browse/IO-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-746. Fix Version/s: 2.12.0 Resolution: Fixed > removing redundant casts and conversions > > > Key: IO-746 > URL: https://issues.apache.org/jira/browse/IO-746 > Project: Commons IO > Issue Type: Improvement >Reporter: Davide Angelocola >Priority: Minor > Fix For: 2.12.0 > > Attachments: 0001-dropping-unnecessary-casts-and-conversions.patch > > Time Spent: 40m > Remaining Estimate: 0h > > See attached patch: > [^0001-dropping-unnecessary-casts-and-conversions.patch] > Spotted by IntelliJ IDEA. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-746) removing redundant casts and conversions
[ https://issues.apache.org/jira/browse/IO-746?focusedWorklogId=646306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646306 ] ASF GitHub Bot logged work on IO-746: - Author: ASF GitHub Bot Created on: 03/Sep/21 13:44 Start Date: 03/Sep/21 13:44 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #267: URL: https://github.com/apache/commons-io/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646306) Time Spent: 40m (was: 0.5h) > removing redundant casts and conversions > > > Key: IO-746 > URL: https://issues.apache.org/jira/browse/IO-746 > Project: Commons IO > Issue Type: Improvement >Reporter: Davide Angelocola >Priority: Minor > Attachments: 0001-dropping-unnecessary-casts-and-conversions.patch > > Time Spent: 40m > Remaining Estimate: 0h > > See attached patch: > [^0001-dropping-unnecessary-casts-and-conversions.patch] > Spotted by IntelliJ IDEA. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory merged pull request #267: IO-746: Drop unnecessary casts and conversions
garydgregory merged pull request #267: URL: https://github.com/apache/commons-io/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #173: Bump commons.pmd-impl.version from 6.36.0 to 6.37.0
garydgregory merged pull request #173: URL: https://github.com/apache/commons-csv/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #175: Bump jmh-generator-annprocess from 1.32 to 1.33
garydgregory merged pull request #175: URL: https://github.com/apache/commons-csv/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #176: Bump jmh-core from 1.32 to 1.33
garydgregory merged pull request #176: URL: https://github.com/apache/commons-csv/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #179: Bump junit-jupiter from 5.8.0-M1 to 5.8.0-RC1
garydgregory merged pull request #179: URL: https://github.com/apache/commons-csv/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #180: Bump checkstyle from 8.44 to 9.0
garydgregory merged pull request #180: URL: https://github.com/apache/commons-csv/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CSV-288) String delimiter (||) is not working as expected.
Santhsoh created CSV-288:
Summary: String delimiter (||) is not working as expected.
Key: CSV-288
URL: https://issues.apache.org/jira/browse/CSV-288
Project: Commons CSV
Issue Type: Bug
Reporter: Santhsoh
Steps to reproduce :
1. Parse CSV file with || as delimiter and having empty columns
2. Print the CSVRecord resulting from CSVParser
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
public static void main(String[] args) throws Exception\{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
With the snippet provided above, actual value is not same as expected value
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory commented on pull request #207: Minors improvements:
garydgregory commented on pull request #207: URL: https://github.com/apache/commons-vfs/pull/207#issuecomment-912539238 Don't change the internal APIs for now please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #211: Bump checkstyle from 8.44 to 9.0
garydgregory merged pull request #211: URL: https://github.com/apache/commons-vfs/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] coveralls edited a comment on pull request #66: Improve Travis CI build Performance
coveralls edited a comment on pull request #66: URL: https://github.com/apache/commons-cli/pull/66#issuecomment-899518234 [](https://coveralls.io/builds/42639427) Coverage remained the same at 96.358% when pulling **bebbd46eaa1afef7c3ba91e8c213f1386e5ebc3e on YunLemon:Modify_Travis_1** into **1ff0db054a675c306d7a9e4277fc9d09f5b249d4 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DBCP-580) Not compatible with org.dbunit.IDatabaseTester
[
https://issues.apache.org/jira/browse/DBCP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409481#comment-17409481
]
Gary D. Gregory commented on DBCP-580:
--
Note that the package name has changed between version 1 and 2 so a drop in
replacement will not work.
> Not compatible with org.dbunit.IDatabaseTester
> ---
>
> Key: DBCP-580
> URL: https://issues.apache.org/jira/browse/DBCP-580
> Project: Commons DBCP
> Issue Type: Bug
>Affects Versions: 2.7.0, 2.9.0
> Environment:
> com.github.springtestdbunit
> spring-test-dbunit
> 1.3.0
> test
>
>
> org.dbunit
> dbunit
> 2.7.2
> test
>
>Reporter: Arelowo
>Priority: Major
>
> We tried to upgrade to the latest version from 1.4 but it seems to be causing
> an issue with our db unit test.
>
> We get the following printed over and over again when the onSetup() method is
> invoked
> {code:java}
> at java.lang.StringBuilder.append(StringBuilder.java:131)at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584){code}
>
> We tested different versions and it seems 2.1.1 does not have this bug.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DBCP-580) Not compatible with org.dbunit.IDatabaseTester
[
https://issues.apache.org/jira/browse/DBCP-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409480#comment-17409480
]
Gary D. Gregory commented on DBCP-580:
--
This looks like the middle of a stack trace. May you please post or attach a
complete one?
> Not compatible with org.dbunit.IDatabaseTester
> ---
>
> Key: DBCP-580
> URL: https://issues.apache.org/jira/browse/DBCP-580
> Project: Commons DBCP
> Issue Type: Bug
>Affects Versions: 2.7.0, 2.9.0
> Environment:
> com.github.springtestdbunit
> spring-test-dbunit
> 1.3.0
> test
>
>
> org.dbunit
> dbunit
> 2.7.2
> test
>
>Reporter: Arelowo
>Priority: Major
>
> We tried to upgrade to the latest version from 1.4 but it seems to be causing
> an issue with our db unit test.
>
> We get the following printed over and over again when the onSetup() method is
> invoked
> {code:java}
> at java.lang.StringBuilder.append(StringBuilder.java:131)at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584)
> at java.lang.String.valueOf(String.java:2994) at
> java.lang.StringBuilder.append(StringBuilder.java:131) at
> org.apache.commons.pool2.impl.GenericKeyedObjectPool.toStringAppendFields(GenericKeyedObjectPool.java:1593)
> at org.apache.commons.pool2.BaseObject.toString(BaseObject.java:31) at
> org.apache.commons.dbcp2.PoolingConnection.toString(PoolingConnection.java:584){code}
>
> We tested different versions and it seems 2.1.1 does not have this bug.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-fileupload] garydgregory commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
garydgregory commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912503658 > The change here is for 2.x, which will be released some time in the future. > Isn't it time to upgrade to a newer version of Java ? > People could use 1.x for JDK 8. The next Java version jump should be to 11 since it is the next LTS version after 8. When to do that I don't know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=646282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646282 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:34 Start Date: 03/Sep/21 12:34 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912503658 > The change here is for 2.x, which will be released some time in the future. > Isn't it time to upgrade to a newer version of Java ? > People could use 1.x for JDK 8. The next Java version jump should be to 11 since it is the next LTS version after 8. When to do that I don't know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646282) Time Spent: 3h 20m (was: 3h 10m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 2.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (COMPRESS-590) Fatal Exception: java.lang.NoSuchMethodError
[
https://issues.apache.org/jira/browse/COMPRESS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved COMPRESS-590.
--
Resolution: Workaround
> Fatal Exception: java.lang.NoSuchMethodError
>
>
> Key: COMPRESS-590
> URL: https://issues.apache.org/jira/browse/COMPRESS-590
> Project: Commons Compress
> Issue Type: Bug
> Components: Build
>Affects Versions: 1.21
>Reporter: Philip Jan Baruis
>Priority: Major
>
> Environment: Android Studio
> JDK Version: 1.8
> Apache Commons Compress Version: 1.21
> Android Versions affected: Android 6 (Marshmallow) / API 23 , Android 7.1
> (Nougat) / API 25
> Here's what i got on the stacktrace.
> {code:java}
> Fatal Exception: java.lang.NoSuchMethodError: No virtual method
> toPath()Ljava/nio/file/Path; in class Ljava/io/File; or its super classes
> (declaration of 'java.io.File' appears in /system/framework/core-libart.jar)
> at
> org.apache.commons.compress.archivers.tar.TarArchiveEntry.(TarArchiveEntry.java:421){code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (COMPRESS-590) Fatal Exception: java.lang.NoSuchMethodError
[
https://issues.apache.org/jira/browse/COMPRESS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409477#comment-17409477
]
Gary D. Gregory edited comment on COMPRESS-590 at 9/3/21, 12:30 PM:
The bottom line here is that Java on Android is not the complete Java that you
find everywhere else :(
The API you refer to is available in
https://developer.android.com/reference/java/io/File#toPath() so you need to up
your Android API version to 26.
was (Author: garydgregory):
The bottom line here is that Java on Android is not the complete Java that you
find everywhere else :(
But, the API you refer to is listed here
https://developer.android.com/reference/java/io/File so maybe you just need to
up your Android API version.
> Fatal Exception: java.lang.NoSuchMethodError
>
>
> Key: COMPRESS-590
> URL: https://issues.apache.org/jira/browse/COMPRESS-590
> Project: Commons Compress
> Issue Type: Bug
> Components: Build
>Affects Versions: 1.21
>Reporter: Philip Jan Baruis
>Priority: Major
>
> Environment: Android Studio
> JDK Version: 1.8
> Apache Commons Compress Version: 1.21
> Android Versions affected: Android 6 (Marshmallow) / API 23 , Android 7.1
> (Nougat) / API 25
> Here's what i got on the stacktrace.
> {code:java}
> Fatal Exception: java.lang.NoSuchMethodError: No virtual method
> toPath()Ljava/nio/file/Path; in class Ljava/io/File; or its super classes
> (declaration of 'java.io.File' appears in /system/framework/core-libart.jar)
> at
> org.apache.commons.compress.archivers.tar.TarArchiveEntry.(TarArchiveEntry.java:421){code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (COMPRESS-590) Fatal Exception: java.lang.NoSuchMethodError
[
https://issues.apache.org/jira/browse/COMPRESS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409477#comment-17409477
]
Gary D. Gregory edited comment on COMPRESS-590 at 9/3/21, 12:28 PM:
The bottom line here is that Java on Android is not the complete Java that you
find everywhere else :(
But, the API you refer to is listed here
https://developer.android.com/reference/java/io/File so maybe you just need to
up your Android API version.
was (Author: garydgregory):
The bottom line here is that Java on Android is not the complete Java that you
find everywhere else :-(
> Fatal Exception: java.lang.NoSuchMethodError
>
>
> Key: COMPRESS-590
> URL: https://issues.apache.org/jira/browse/COMPRESS-590
> Project: Commons Compress
> Issue Type: Bug
> Components: Build
>Affects Versions: 1.21
>Reporter: Philip Jan Baruis
>Priority: Major
>
> Environment: Android Studio
> JDK Version: 1.8
> Apache Commons Compress Version: 1.21
> Android Versions affected: Android 6 (Marshmallow) / API 23 , Android 7.1
> (Nougat) / API 25
> Here's what i got on the stacktrace.
> {code:java}
> Fatal Exception: java.lang.NoSuchMethodError: No virtual method
> toPath()Ljava/nio/file/Path; in class Ljava/io/File; or its super classes
> (declaration of 'java.io.File' appears in /system/framework/core-libart.jar)
> at
> org.apache.commons.compress.archivers.tar.TarArchiveEntry.(TarArchiveEntry.java:421){code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (COMPRESS-590) Fatal Exception: java.lang.NoSuchMethodError
[
https://issues.apache.org/jira/browse/COMPRESS-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409477#comment-17409477
]
Gary D. Gregory commented on COMPRESS-590:
--
The bottom line here is that Java on Android is not the complete Java that you
find everywhere else :-(
> Fatal Exception: java.lang.NoSuchMethodError
>
>
> Key: COMPRESS-590
> URL: https://issues.apache.org/jira/browse/COMPRESS-590
> Project: Commons Compress
> Issue Type: Bug
> Components: Build
>Affects Versions: 1.21
>Reporter: Philip Jan Baruis
>Priority: Major
>
> Environment: Android Studio
> JDK Version: 1.8
> Apache Commons Compress Version: 1.21
> Android Versions affected: Android 6 (Marshmallow) / API 23 , Android 7.1
> (Nougat) / API 25
> Here's what i got on the stacktrace.
> {code:java}
> Fatal Exception: java.lang.NoSuchMethodError: No virtual method
> toPath()Ljava/nio/file/Path; in class Ljava/io/File; or its super classes
> (declaration of 'java.io.File' appears in /system/framework/core-libart.jar)
> at
> org.apache.commons.compress.archivers.tar.TarArchiveEntry.(TarArchiveEntry.java:421){code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[ https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646279 ] ASF GitHub Bot logged work on CSV-206: -- Author: ASF GitHub Bot Created on: 03/Sep/21 12:17 Start Date: 03/Sep/21 12:17 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #76: URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912493878 @san4you88 Thank you for your report. May you please create a PR with a failing unit test? This would allow us to see exactly how your use case is not handled. If you have a fix, feel free to include it ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646279) Time Spent: 3h 10m (was: 3h) > Add support for String delimiters #76 > - > > Key: CSV-206 > URL: https://issues.apache.org/jira/browse/CSV-206 > Project: Commons CSV > Issue Type: Improvement >Reporter: jefferyyuan >Priority: Major > Labels: commons, commons-csv, csv, csvparser > Fix For: 1.9.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > It's not uncommon that we use multiple-characters delimiter to separate > columns in CVS: such as: [|] > Sometimes, we have no choice as third-party defines the csv format like that. > It would be great if apache commons.csv supports this function. > I did some google search: seems there is no java library that supports use > multiple-characters as the column separator. > But the C# CsvHelper does > https://github.com/JoshClose/CsvHelper -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-csv] garydgregory commented on pull request #76: [CSV-206] Add support for String delimiters
garydgregory commented on pull request #76: URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912493878 @san4you88 Thank you for your report. May you please create a PR with a failing unit test? This would allow us to see exactly how your use case is not handled. If you have a fix, feel free to include it ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=646278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646278 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:16 Start Date: 03/Sep/21 12:16 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912493463 The change here is for 2.x, which will be released some time in the future. Isn't it time to upgrade to a newer version of Java ? People could use 1.x for JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646278) Time Spent: 3h 10m (was: 3h) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 2.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] martin-g commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
martin-g commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912493463 The change here is for 2.x, which will be released some time in the future. Isn't it time to upgrade to a newer version of Java ? People could use 1.x for JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=646274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646274 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:10 Start Date: 03/Sep/21 12:10 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912489794 FWIY, for the release I work on that require Java 8, I ALWAYS release using Java 8. The release process is tricky enough as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646274) Time Spent: 2h 50m (was: 2h 40m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 2.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?focusedWorklogId=646275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646275 ] ASF GitHub Bot logged work on FILEUPLOAD-340: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:10 Start Date: 03/Sep/21 12:10 Worklog Time Spent: 10m Work Description: garydgregory edited a comment on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912489794 FWIY, for the releases I work on that require Java 8, I ALWAYS release using Java 8. The release process is tricky enough as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646275) Time Spent: 3h (was: 2h 50m) > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 2.0 > > Time Spent: 3h > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-fileupload] garydgregory edited a comment on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
garydgregory edited a comment on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912489794 FWIY, for the releases I work on that require Java 8, I ALWAYS release using Java 8. The release process is tricky enough as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] garydgregory commented on pull request #107: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
garydgregory commented on pull request #107: URL: https://github.com/apache/commons-fileupload/pull/107#issuecomment-912489794 FWIY, for the release I work on that require Java 8, I ALWAYS release using Java 8. The release process is tricky enough as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMPRESS-590) Fatal Exception: java.lang.NoSuchMethodError
Philip Jan Baruis created COMPRESS-590:
--
Summary: Fatal Exception: java.lang.NoSuchMethodError
Key: COMPRESS-590
URL: https://issues.apache.org/jira/browse/COMPRESS-590
Project: Commons Compress
Issue Type: Bug
Components: Build
Affects Versions: 1.21
Reporter: Philip Jan Baruis
Environment: Android Studio
JDK Version: 1.8
Apache Commons Compress Version: 1.21
Android Versions affected: Android 6 (Marshmallow) / API 23 , Android 7.1
(Nougat) / API 25
Here's what i got on the stacktrace.
{code:java}
Fatal Exception: java.lang.NoSuchMethodError: No virtual method
toPath()Ljava/nio/file/Path; in class Ljava/io/File; or its super classes
(declaration of 'java.io.File' appears in /system/framework/core-libart.jar)
at
org.apache.commons.compress.archivers.tar.TarArchiveEntry.(TarArchiveEntry.java:421){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646272 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:06 Start Date: 03/Sep/21 12:06 Worklog Time Spent: 10m Work Description: martin-g commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701837403 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: What are the issues with NIO Buffer classes if you build with Java 9 and --release=8 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646272) Time Spent: 1h (was: 50m) > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] martin-g commented on a change in pull request #268: IO-747 Make commons-io a proper JPMS module
martin-g commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701837403 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: What are the issues with NIO Buffer classes if you build with Java 9 and --release=8 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646271 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 12:01 Start Date: 03/Sep/21 12:01 Worklog Time Spent: 10m Work Description: garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. I think we have other Commons components that are OSGi and JPMS modules, so you might want to look around. Why is there not a module-info.java somewhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646271) Time Spent: 50m (was: 40m) > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #268: IO-747 Make commons-io a proper JPMS module
garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. I think we have other Commons components that are OSGi and JPMS modules, so you might want to look around. Why is there not a module-info.java somewhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646269 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 11:59 Start Date: 03/Sep/21 11:59 Worklog Time Spent: 10m Work Description: garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. I think we have other Commons components that are OSGi and JPMS modules, so you might want to look around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646269) Time Spent: 40m (was: 0.5h) > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #268: IO-747 Make commons-io a proper JPMS module
garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. I think we have other Commons components that are OSGi and JPMS modules, so you might want to look around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646268 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 11:57 Start Date: 03/Sep/21 11:57 Worklog Time Spent: 10m Work Description: garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646268) Time Spent: 0.5h (was: 20m) > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #268: IO-747 Make commons-io a proper JPMS module
garydgregory commented on a change in pull request #268: URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678 ## File path: pom.xml ## @@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much more. + + release + + Review comment: That's not good. I build releases with Java 8 since we want to bind to the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646242 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 09:58 Start Date: 03/Sep/21 09:58 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-912416268 [](https://coveralls.io/builds/42636009) Coverage decreased (-0.1%) to 89.122% when pulling **cc02a8c2cc68ec6461146c8c1b550aa32923e34a on martin-g:io-747-make-commons-io-proper-jpms-module** into **70f3ce0b23de3180cb7e821e6792f086616e951a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646242) Time Spent: 20m (was: 10m) > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls commented on pull request #268: IO-747 Make commons-io a proper JPMS module
coveralls commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-912416268 [](https://coveralls.io/builds/42636009) Coverage decreased (-0.1%) to 89.122% when pulling **cc02a8c2cc68ec6461146c8c1b550aa32923e34a on martin-g:io-747-make-commons-io-proper-jpms-module** into **70f3ce0b23de3180cb7e821e6792f086616e951a on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1593) Common behaviour for StringUtils join APIs when called with char or String delimiter
[
https://issues.apache.org/jira/browse/LANG-1593?focusedWorklogId=646234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646234
]
ASF GitHub Bot logged work on LANG-1593:
Author: ASF GitHub Bot
Created on: 03/Sep/21 09:44
Start Date: 03/Sep/21 09:44
Worklog Time Spent: 10m
Work Description: HubertWo edited a comment on pull request #784:
URL: https://github.com/apache/commons-lang/pull/784#issuecomment-912228158
@garydgregory looks like I've addressed all the questions.
Could you please review again?
Hope it will be LGTM this time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646234)
Time Spent: 7h 20m (was: 7h 10m)
> Common behaviour for StringUtils join APIs when called with char or String
> delimiter
>
>
> Key: LANG-1593
> URL: https://issues.apache.org/jira/browse/LANG-1593
> Project: Commons Lang
> Issue Type: Improvement
>Affects Versions: 3.4, 3.11
>Reporter: Kiruahxh
>Priority: Minor
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> For now, join(int[], char) is working well.
> However, the same join method called with a string delimiter behaves
> differently : it returns a single memory address which is not the desired
> behavior.
> I think that, for coherence, calling StringUtils with a char or String
> delimiter should return the exact same value.
> Ex :
> {code:java}
> CLASSPATH="./commons-lang3-3.11.jar" jshell
> | Welcome to JShell -- Version 11.0.8
> jshell> import org.apache.commons.lang3.StringUtils
> jshell> int[] arr = {1, 2, 3, 4, 5, 6, 7};
> jshell> String result = StringUtils.join(arr, '-');
> result ==> "1-2-3-4-5-6-7"
> jshell> String result = StringUtils.join(arr, "-");
> result ==> "[I@69663380-"
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] HubertWo edited a comment on pull request #784: [LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter
HubertWo edited a comment on pull request #784: URL: https://github.com/apache/commons-lang/pull/784#issuecomment-912228158 @garydgregory looks like I've addressed all the questions. Could you please review again? Hope it will be LGTM this time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] san4you88 edited a comment on pull request #76: [CSV-206] Add support for String delimiters
san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||d";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d
// Actual : a,b|c,d
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646222
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 08:43
Start Date: 03/Sep/21 08:43
Worklog Time Spent: 10m
Work Description: san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||d";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d
// Actual : a,b|c,d
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646222)
Time Spent: 2h 40m (was: 2.5h)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409380#comment-17409380
]
Santhsoh edited comment on CSV-206 at 9/3/21, 8:49 AM:
---
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
{code:java}
org.apache.commons
commons-csv 1.9.0
{code}
{code:java}
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
{code}
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
was (Author: san4you88):
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
{code:java}
org.apache.commons
commons-csv 1.9.0
{code}
{code:java}
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
{code}
{{}}The actual value is different from expected, looks like the string
delimiter doesn't work as expected when there is an empty column.
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409380#comment-17409380
]
Santhsoh edited comment on CSV-206 at 9/3/21, 8:48 AM:
---
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
{code:java}
org.apache.commons
commons-csv 1.9.0
{code}
{code:java}
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
{code}
{{}}The actual value is different from expected, looks like the string
delimiter doesn't work as expected when there is an empty column.
was (Author: san4you88):
Hi All,
I was testing the functionality to use string delimiter and found the following
issue.
{{}}
{code:java}
org.apache.commons
commons-csv 1.9.0
{code}
{{}}
{code:java}
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
{code}
{{}}The actual value is different from expected, looks like the string
delimiter doesn't work as expected when there is an empty column.
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409380#comment-17409380
]
Santhsoh commented on CSV-206:
--
Hi All,
I was testing the functionality to use string delimiter and found the following
issue.
{{}}
{code:java}
org.apache.commons
commons-csv 1.9.0
{code}
{{}}
{code:java}
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new StringInputStream(row),
StandardCharsets.UTF_8, CSVFormat.Builder.create().setDelimiter("||").build()))
{
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
{code}
{{}}The actual value is different from expected, looks like the string
delimiter doesn't work as expected when there is an empty column.
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646225
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 08:45
Start Date: 03/Sep/21 08:45
Worklog Time Spent: 10m
Work Description: san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
org.apache.commons
commons-csv
1.9.0
```
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646225)
Time Spent: 3h (was: 2h 50m)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] san4you88 edited a comment on pull request #76: [CSV-206] Add support for String delimiters
san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
org.apache.commons
commons-csv
1.9.0
```
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646223
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 08:44
Start Date: 03/Sep/21 08:44
Worklog Time Spent: 10m
Work Description: san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646223)
Time Spent: 2h 50m (was: 2h 40m)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] san4you88 edited a comment on pull request #76: [CSV-206] Add support for String delimiters
san4you88 edited a comment on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row = "a||b||c||df||g";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected : a,b,c,d,,f,g
// Actual : a,b|c,d,|f,g
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646221 ] ASF GitHub Bot logged work on IO-747: - Author: ASF GitHub Bot Created on: 03/Sep/21 08:38 Start Date: 03/Sep/21 08:38 Worklog Time Spent: 10m Work Description: martin-g commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-912366432 This PR is similar to https://github.com/apache/commons-fileupload/pull/107 If commons team likes the approach I could work on a PR that moves the logic to commons-parent and is reused for all commons-** projects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646221) Remaining Estimate: 0h Time Spent: 10m > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] martin-g commented on pull request #268: IO-747 Make commons-io a proper JPMS module
martin-g commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-912366432 This PR is similar to https://github.com/apache/commons-fileupload/pull/107 If commons team likes the approach I could work on a PR that moves the logic to commons-parent and is reused for all commons-** projects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IO-747) Make commons-io a proper JPMS module
[ https://issues.apache.org/jira/browse/IO-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409371#comment-17409371 ] Martin Tzvetanov Grigorov commented on IO-747: -- I work on a PR! > Make commons-io a proper JPMS module > > > Key: IO-747 > URL: https://issues.apache.org/jira/browse/IO-747 > Project: Commons IO > Issue Type: Task >Affects Versions: 2.12.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > It would be nice if commons-io provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (CSV-206) Add support for String delimiters #76
[
https://issues.apache.org/jira/browse/CSV-206?focusedWorklogId=646219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646219
]
ASF GitHub Bot logged work on CSV-206:
--
Author: ASF GitHub Bot
Created on: 03/Sep/21 08:28
Start Date: 03/Sep/21 08:28
Worklog Time Spent: 10m
Work Description: san4you88 commented on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row =
"Santhosh-3||Updated-Santhosh-3||Venkatesh-3||Updated-Venkatesh-3||NameUpdate-3||Mobile||111-222-335Home||HHH-113||111-222-335";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected :
Santhosh-3,Updated-Santhosh-3,Venkatesh-3,Updated-Venkatesh-3,NameUpdate-3,Mobile,111-222-335,Home,HHH-113,111-222-335
// Actual :
Santhosh-3,Updated-Santhosh-3,Venkatesh-3,Updated-Venkatesh-3,NameUpdate-3,Mobile,111-222-335,|Home,HHH-113,111-222-335
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 646219)
Time Spent: 2.5h (was: 2h 20m)
> Add support for String delimiters #76
> -
>
> Key: CSV-206
> URL: https://issues.apache.org/jira/browse/CSV-206
> Project: Commons CSV
> Issue Type: Improvement
>Reporter: jefferyyuan
>Priority: Major
> Labels: commons, commons-csv, csv, csvparser
> Fix For: 1.9.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> It's not uncommon that we use multiple-characters delimiter to separate
> columns in CVS: such as: [|]
> Sometimes, we have no choice as third-party defines the csv format like that.
> It would be great if apache commons.csv supports this function.
> I did some google search: seems there is no java library that supports use
> multiple-characters as the column separator.
> But the C# CsvHelper does
> https://github.com/JoshClose/CsvHelper
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-csv] san4you88 commented on pull request #76: [CSV-206] Add support for String delimiters
san4you88 commented on pull request #76:
URL: https://github.com/apache/commons-csv/pull/76#issuecomment-912359970
Hi All,
I was testing the functionality to use string delimiter and found the
following issue.
```
public static void main(String[] args) throws Exception{
String row =
"Santhosh-3||Updated-Santhosh-3||Venkatesh-3||Updated-Venkatesh-3||NameUpdate-3||Mobile||111-222-335Home||HHH-113||111-222-335";
StringBuilder stringBuilder = new StringBuilder();
try (CSVPrinter csvPrinter = new CSVPrinter(stringBuilder,
CSVFormat.EXCEL);
CSVParser csvParser = CSVParser.parse(new
StringInputStream(row), StandardCharsets.UTF_8,
CSVFormat.Builder.create().setDelimiter("||").build())) {
for (CSVRecord csvRecord : csvParser) {
for (int i = 0; i < csvRecord.size(); i++) {
csvPrinter.print(csvRecord.get(i));
}
System.out.println(stringBuilder.toString());
//Expected :
Santhosh-3,Updated-Santhosh-3,Venkatesh-3,Updated-Venkatesh-3,NameUpdate-3,Mobile,111-222-335,Home,HHH-113,111-222-335
// Actual :
Santhosh-3,Updated-Santhosh-3,Venkatesh-3,Updated-Venkatesh-3,NameUpdate-3,Mobile,111-222-335,|Home,HHH-113,111-222-335
}
}
}
```
The actual value is different from expected, looks like the string delimiter
doesn't work as expected when there is an empty column.
Can some1 please confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (IO-747) Make commons-io a proper JPMS module
Martin Tzvetanov Grigorov created IO-747: Summary: Make commons-io a proper JPMS module Key: IO-747 URL: https://issues.apache.org/jira/browse/IO-747 Project: Commons IO Issue Type: Task Affects Versions: 2.12.0 Reporter: Martin Tzvetanov Grigorov It would be nice if commons-io provides module-info.class for Java 9+ JPMS. At the moment the project uses JDK 1.8 for the builds. To add module-info.java it would have to use JDK 9+ (probably 11) with -release=8. An easy way to introduce module-info.java is by using [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FILEUPLOAD-340) Make commons-fileupload a proper JPMS module
[ https://issues.apache.org/jira/browse/FILEUPLOAD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Tzvetanov Grigorov resolved FILEUPLOAD-340. -- Fix Version/s: 2.0 Resolution: Fixed > Make commons-fileupload a proper JPMS module > > > Key: FILEUPLOAD-340 > URL: https://issues.apache.org/jira/browse/FILEUPLOAD-340 > Project: Commons FileUpload > Issue Type: Improvement >Affects Versions: 2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 2.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It would be nice if 2.0 provides module-info.class for Java 9+ JPMS. > > At the moment the project uses JDK 1.8 for the builds. > To add module-info.java it would have to use JDK 9+ (probably 11) with > -release=1.8. > An easy way to introduce module-info.java is by using > [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar] -- This message was sent by Atlassian Jira (v8.3.4#803005)
