[jira] [Work logged] (LANG-1674) Range construction with abstract/derived classes
[
https://issues.apache.org/jira/browse/LANG-1674?focusedWorklogId=664441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664441
]
ASF GitHub Bot logged work on LANG-1674:
Author: ASF GitHub Bot
Created on: 13/Oct/21 02:09
Start Date: 13/Oct/21 02:09
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831
I'll review sometime this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664441)
Time Spent: 1h 10m (was: 1h)
> Range construction with abstract/derived classes
>
>
> Key: LANG-1674
> URL: https://issues.apache.org/jira/browse/LANG-1674
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Baljit Singh
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The constructors for {{org.apache.commons.lang3.Range}} don't play nicely
> with abstract/derived classes. Example:
> {quote}
> abstract class AbstractComparable implements Comparable {
> @Override public int compareTo(AbstractComparable o) {}
> }
> class DerivedA extends AbstractComparable {}
> class DerivedB extends AbstractComparable {}
> // compiles, and reasonable since AbstractComparable is the common parent
> static final Range RANGE_MIXED = Range.between(new
> DerivedA(), new DerivedB());
> // compiles, but unreasonable to force usage of parent class
> static final Range RANGE_SAME_CLASS = Range.between(new
> DerivedA(), new DerivedA());
> // compiler error
> static final Range RANGE_A = Range.between(new DerivedA(), new
> DerivedA());
> // compiler error
> static final Range RANGE_B = Range.is(new DerivedB());
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #810: LANG-1674: Make Range constructors more generic
garydgregory commented on pull request #810: URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941845831 I'll review sometime this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1674) Range construction with abstract/derived classes
[
https://issues.apache.org/jira/browse/LANG-1674?focusedWorklogId=664404=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664404
]
ASF GitHub Bot logged work on LANG-1674:
Author: ASF GitHub Bot
Created on: 12/Oct/21 23:25
Start Date: 12/Oct/21 23:25
Worklog Time Spent: 10m
Work Description: singhbaljit commented on pull request #810:
URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941740481
@garydgregory ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664404)
Time Spent: 1h (was: 50m)
> Range construction with abstract/derived classes
>
>
> Key: LANG-1674
> URL: https://issues.apache.org/jira/browse/LANG-1674
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: Baljit Singh
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The constructors for {{org.apache.commons.lang3.Range}} don't play nicely
> with abstract/derived classes. Example:
> {quote}
> abstract class AbstractComparable implements Comparable {
> @Override public int compareTo(AbstractComparable o) {}
> }
> class DerivedA extends AbstractComparable {}
> class DerivedB extends AbstractComparable {}
> // compiles, and reasonable since AbstractComparable is the common parent
> static final Range RANGE_MIXED = Range.between(new
> DerivedA(), new DerivedB());
> // compiles, but unreasonable to force usage of parent class
> static final Range RANGE_SAME_CLASS = Range.between(new
> DerivedA(), new DerivedA());
> // compiler error
> static final Range RANGE_A = Range.between(new DerivedA(), new
> DerivedA());
> // compiler error
> static final Range RANGE_B = Range.is(new DerivedB());
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] singhbaljit commented on pull request #810: LANG-1674: Make Range constructors more generic
singhbaljit commented on pull request #810: URL: https://github.com/apache/commons-lang/pull/810#issuecomment-941740481 @garydgregory ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427947#comment-17427947
]
Gilles Sadowski commented on NUMBERS-167:
-
bq. fails JApiCmp
Then, how about defining a separate API for "univariate" functions?
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] kinow merged pull request #174: Bump spotbugs from 4.4.1 to 4.4.2
kinow merged pull request #174: URL: https://github.com/apache/commons-imaging/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #120: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #120: URL: https://github.com/apache/commons-fileupload/pull/120#issuecomment-941470091 [](https://coveralls.io/builds/43452645) Coverage remained the same at 77.585% when pulling **9ffb032168e58b1086150a41db20544bf4626fb1 on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **19a702b155008dd146a0c5848754f544242cea9f on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)
[
https://issues.apache.org/jira/browse/IO-714?focusedWorklogId=664270=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664270
]
ASF GitHub Bot logged work on IO-714:
-
Author: ASF GitHub Bot
Created on: 12/Oct/21 19:35
Start Date: 12/Oct/21 19:35
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #283:
URL: https://github.com/apache/commons-io/pull/283#issuecomment-941360554
I'll review again later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664270)
Time Spent: 40m (was: 0.5h)
> ReaderInputStream does not call CharsetEncoder.flush(...)
> -
>
> Key: IO-714
> URL: https://issues.apache.org/jira/browse/IO-714
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: Marcono1234
>Priority: Major
> Attachments:
> 0001-Fixed-ReaderInputStream-not-calling-CharsetEncoder.f.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As defined by the {{CharsetEncoder}}
> [documentation|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/charset/CharsetEncoder.html]
> the _encoding operation_ consists of:
> # (reset)
> # encode
> # flush
> However, {{org.apache.commons.io.input.ReaderInputStream}} does not call
> {{flush}}. This leads to incorrect results for charsets whose {{flush}}
> method appends additional bytes.
> Example:
> {code}
> // Charset whose CharsetEncoder.flush(...) puts bytes
> Charset charset = Charset.forName("Cp930");
> // \u0391: Causes CharsetEncoder.flush(...) to put additional bytes
> String s = "\u0391";
> byte[] expected = s.getBytes(charset);
> byte[] actual;
> try (InputStream in = new ReaderInputStream(new StringReader(s), charset)) {
> actual = IOUtils.toByteArray(in);
> }
> if (!Arrays.equals(expected, actual)) {
> throw new AssertionError("\n Expected: " + Arrays.toString(expected) +
> "\n Actual: " + Arrays.toString(actual));
> }
> {code}
> Also make sure to check the result of {{flush()}} because {{OVERFLOW}} as
> result is possible. In theory {{isError() == true}} might be possible as
> well, but I don't think any of charset implementations currently return that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on pull request #283: [IO-714] Fixed ReaderInputStream not calling CharsetEncoder.flush issue
garydgregory commented on pull request #283: URL: https://github.com/apache/commons-io/pull/283#issuecomment-941360554 I'll review again later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls commented on pull request #174: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #174: URL: https://github.com/apache/commons-imaging/pull/174#issuecomment-941286599 [](https://coveralls.io/builds/43450140) Coverage remained the same at 77.003% when pulling **b7be1ac1121097e1ad6aa353171cd6f4e659810f on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **b76efb67b075f53b33af28026fea15e2916f771c on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)
[
https://issues.apache.org/jira/browse/IO-714?focusedWorklogId=664220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664220
]
ASF GitHub Bot logged work on IO-714:
-
Author: ASF GitHub Bot
Created on: 12/Oct/21 18:34
Start Date: 12/Oct/21 18:34
Worklog Time Spent: 10m
Work Description: kevinwang1975 commented on pull request #283:
URL: https://github.com/apache/commons-io/pull/283#issuecomment-941276341
Hi @garydgregory , all checks are green now. Please let me know what I do
next? Do I need to request for reviewers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 664220)
Time Spent: 0.5h (was: 20m)
> ReaderInputStream does not call CharsetEncoder.flush(...)
> -
>
> Key: IO-714
> URL: https://issues.apache.org/jira/browse/IO-714
> Project: Commons IO
> Issue Type: Bug
> Components: Streams/Writers
>Affects Versions: 2.8.0
>Reporter: Marcono1234
>Priority: Major
> Attachments:
> 0001-Fixed-ReaderInputStream-not-calling-CharsetEncoder.f.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As defined by the {{CharsetEncoder}}
> [documentation|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/charset/CharsetEncoder.html]
> the _encoding operation_ consists of:
> # (reset)
> # encode
> # flush
> However, {{org.apache.commons.io.input.ReaderInputStream}} does not call
> {{flush}}. This leads to incorrect results for charsets whose {{flush}}
> method appends additional bytes.
> Example:
> {code}
> // Charset whose CharsetEncoder.flush(...) puts bytes
> Charset charset = Charset.forName("Cp930");
> // \u0391: Causes CharsetEncoder.flush(...) to put additional bytes
> String s = "\u0391";
> byte[] expected = s.getBytes(charset);
> byte[] actual;
> try (InputStream in = new ReaderInputStream(new StringReader(s), charset)) {
> actual = IOUtils.toByteArray(in);
> }
> if (!Arrays.equals(expected, actual)) {
> throw new AssertionError("\n Expected: " + Arrays.toString(expected) +
> "\n Actual: " + Arrays.toString(actual));
> }
> {code}
> Also make sure to check the result of {{flush()}} because {{OVERFLOW}} as
> result is possible. In theory {{isError() == true}} might be possible as
> well, but I don't think any of charset implementations currently return that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] kevinwang1975 commented on pull request #283: [IO-714] Fixed ReaderInputStream not calling CharsetEncoder.flush issue
kevinwang1975 commented on pull request #283: URL: https://github.com/apache/commons-io/pull/283#issuecomment-941276341 Hi @garydgregory , all checks are green now. Please let me know what I do next? Do I need to request for reviewers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] jochenw merged pull request #225: Use Boolean constants instead of Boolean.valueOf
jochenw merged pull request #225: URL: https://github.com/apache/commons-compress/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #120: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] opened a new pull request #120: URL: https://github.com/apache/commons-fileupload/pull/120 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 Changelog Sourced from https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md;>spotbugs's changelog.
[GitHub] [commons-imaging] dependabot[bot] opened a new pull request #174: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] opened a new pull request #174: URL: https://github.com/apache/commons-imaging/pull/174 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 Changelog Sourced from https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md;>spotbugs's changelog. 4.4.2
[GitHub] [commons-compress] stefanbirkner opened a new pull request #225: Use Boolean constants instead of Boolean.valueOf
stefanbirkner opened a new pull request #225: URL: https://github.com/apache/commons-compress/pull/225 Boolean.TRUE and Boolean.FALSE are shorter and easier to read. It also fixes a PMD violation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IMAGING-127) API to get a single image should allow choosing which image
[ https://issues.apache.org/jira/browse/IMAGING-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427769#comment-17427769 ] Gary Lucas commented on IMAGING-127: I'm don't know what the level of interest is for this issue. But I do know of an example application in the "test" hierarchy that shows one way to extract images and metadata. It uses low-level calls and is a bit specialized for general application work. It might help get you started on your own implementation. Directory: commons-imaging-master\src\test\java\org\apache\commons\imaging\examples\tiff File ReadTagsAndImages.java > API to get a single image should allow choosing which image > --- > > Key: IMAGING-127 > URL: https://issues.apache.org/jira/browse/IMAGING-127 > Project: Commons Imaging > Issue Type: Improvement >Reporter: Trejkaz >Priority: Major > Fix For: Patch Needed > > Attachments: 2472527552.gif, Wakarusa2015-0001.mpo, june 1 part I.tif > > > getBufferedImage() only returns the first image. There should be a way to > retrieve any image by index (and by extension, an API to get the image count.) > getBufferedImages() cannot be used for large multi-page TIFF files, because > creating that many BufferedImage objects causes an OutOfMemoryError. > (For that matter, a method to get a scaled down copy would be useful as well, > as some formats can optimise that not to retrieve all the data, but also it > means you can reduce the memory usage for absolutely massive images.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427747#comment-17427747
]
Alex Herbert edited comment on NUMBERS-167 at 10/12/21, 3:01 PM:
-
I do not think BC allows a switch to enums as the methods change from static to
instance.
{code:java}
public enum RegularizedGamma {
P {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
},
Q {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
};
private static final double DEFAULT_EPSILON = 1e-15;
public abstract double value(double a, double x);
public abstract double value(double a,
double x,
double epsilon,
int maxIterations);
}
{code}
This fails JApiCmp:
{noformat}
mvn package japicmp
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on
project commons-numbers-gamma:
There is at least one incompatibility:
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double,double,int):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_NOW_ABSTRACT,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_TYPE_CHANGED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double,double,int):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$P:SUPERCLASS_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$P:CLASS_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double,double,int):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q:SUPERCLASS_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q:CLASS_REMOVED -> [Help 1]
{noformat}
was (Author: alexherbert):
I do not think BC allows a switch to enums as the methods change from static to
instance.
{code:java}
public enum RegularizedGamma {
P {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
},
Q {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
};
private static final double DEFAULT_EPSILON = 1e-15;
public abstract double value(double a, double x);
public abstract double value(double a,
double x,
double epsilon,
int maxIterations);
}
{code}
This fails JApiCmp:
{noformat}
mvn package japicmp
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on
project commons-numbers-gamma: There is at least one incompatibility:
[jira] [Comment Edited] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427747#comment-17427747
]
Alex Herbert edited comment on NUMBERS-167 at 10/12/21, 3:01 PM:
-
I do not think BC allows a switch to enums as the methods change from static to
instance.
{code:java}
public enum RegularizedGamma {
P {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
},
Q {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
};
private static final double DEFAULT_EPSILON = 1e-15;
public abstract double value(double a, double x);
public abstract double value(double a,
double x,
double epsilon,
int maxIterations);
}
{code}
This fails JApiCmp:
{noformat}
mvn package japicmp
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on
project commons-numbers-gamma:
There is at least one incompatibility:
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double,double,int):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_NOW_ABSTRACT,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_TYPE_CHANGED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double,double,int):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$P:SUPERCLASS_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$P:CLASS_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double,double,int):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q:SUPERCLASS_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$Q:CLASS_REMOVED -> [Help 1]
{noformat}
was (Author: alexherbert):
I do not think BC allows a switch to enums as the methods change from static to
instance.
{code:java}
public enum RegularizedGamma {
P {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
},
Q {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
};
private static final double DEFAULT_EPSILON = 1e-15;
public abstract double value(double a, double x);
public abstract double value(double a,
double x,
double epsilon,
int maxIterations);
}
{code}
This fails JApiCmp:
{noformat}
mvn package japicmp
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on
project commons-numbers-gamma:
There is at least one incompatibility:
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double,double,int):METHOD_ABSTRACT_ADDED_TO_CLASS,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_NOW_ABSTRACT,
org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_TYPE_CHANGED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double):METHOD_REMOVED,
org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double,double,int):METHOD_REMOVED,
[jira] [Commented] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427747#comment-17427747
]
Alex Herbert commented on NUMBERS-167:
--
I do not think BC allows a switch to enums as the methods change from static to
instance.
{code:java}
public enum RegularizedGamma {
P {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
},
Q {
@Override
public double value(double a,
double x) {
return value(a, x, DEFAULT_EPSILON, Integer.MAX_VALUE);
}
@Override
public double value(double a,
double x,
double epsilon,
int maxIterations) {
throw new IllegalStateException();
}
};
private static final double DEFAULT_EPSILON = 1e-15;
public abstract double value(double a, double x);
public abstract double value(double a,
double x,
double epsilon,
int maxIterations);
}
{code}
This fails JApiCmp:
{noformat}
mvn package japicmp
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on
project commons-numbers-gamma: There is at least one incompatibility:
org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double):METHOD_ABSTRACT_ADDED_TO_CLASS,org.apache.commons.numbers.gamma.RegularizedGamma.value(double,double,double,int):METHOD_ABSTRACT_ADDED_TO_CLASS,org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_NOW_ABSTRACT,org.apache.commons.numbers.gamma.RegularizedGamma:CLASS_TYPE_CHANGED,org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double):METHOD_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$P.value(double,double,double,int):METHOD_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$P:SUPERCLASS_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$P:CLASS_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double):METHOD_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$Q.value(double,double,double,int):METHOD_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$Q:SUPERCLASS_REMOVED,org.apache.commons.numbers.gamma.RegularizedGamma$Q:CLASS_REMOVED
-> [Help 1]
{noformat}
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427679#comment-17427679
]
Gilles Sadowski commented on NUMBERS-167:
-
bq. {{ComplementaryFunctions}} interface [...] should be elevated to the
package level.
>From a programming POV certainly, but I'm not sure about the proper naming...
Another (unrelated) issue: I think that we should really have
{code}
public enum RegularizedGamma {
P(...),
Q(...);
// Methods for generating "ComplementaryFunctions" instances.
}
{code}
instead of the current
{code}
public class RegularizedGamma {
public enum RG {
P(...),
Q(...);
// ...
}
public static class P { ... }
public static class Q { ... }
}
{code}
Do you know whether the change could be done while retaining BC?
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-pool] coveralls commented on pull request #106: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #106: URL: https://github.com/apache/commons-pool/pull/106#issuecomment-940995740 [](https://coveralls.io/builds/43440759) Coverage increased (+0.1%) to 85.149% when pulling **252c364b41629aca127378bd2d0c3aae45ec10d1 on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **fcd99d9d5f9e414ef7cc77a0fd1e064b60b8fd09 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (COMPRESS-589) 1.21 throws a 'java.io.IOException: Truncated TAR archive' exception while 1.20 not
[
https://issues.apache.org/jira/browse/COMPRESS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427653#comment-17427653
]
Gilles Sadowski commented on COMPRESS-589:
--
It's certainly not expected, but still doesn't identify the root cause: bug in
"Compress" or unanticipated Android behaviour. Unfortunately I cannot test on
Android.
> 1.21 throws a 'java.io.IOException: Truncated TAR archive' exception while
> 1.20 not
> ---
>
> Key: COMPRESS-589
> URL: https://issues.apache.org/jira/browse/COMPRESS-589
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.21
>Reporter: chen
>Priority: Major
>
> the bug happens when I use the TarArchiveInputStream to read bytes from the
> current tar archive entry.
> first of all, we ran into this issue on an *{color:#ff}Android
> device{color}*
> the trace shows as below
> {code:java}
> 08-27 14:39:18.657 10633 10963 W System.err: java.io.IOException: Truncated
> TAR archive
> 08-27 14:39:18.657 10633 10963 W System.err: java.io.IOException: Truncated
> TAR archive
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getActuallySkipped(TarArchiveInputStream.java:478)
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.skipRecordPadding(TarArchiveInputStream.java:455)
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:367)
> {code}
> but when i downgrade to 1.20, the exception will not show again, so I think
> it is a bug in the new version
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-pool] dependabot[bot] opened a new pull request #106: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] opened a new pull request #106: URL: https://github.com/apache/commons-pool/pull/106 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 Changelog Sourced from https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md;>spotbugs's changelog. 4.4.2 -
[GitHub] [commons-bsf] dependabot[bot] closed pull request #22: Bump spotbugs from 4.2.0 to 4.4.1
dependabot[bot] closed pull request #22: URL: https://github.com/apache/commons-bsf/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] commented on pull request #22: Bump spotbugs from 4.2.0 to 4.4.1
dependabot[bot] commented on pull request #22: URL: https://github.com/apache/commons-bsf/pull/22#issuecomment-940937776 Superseded by #24. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bsf] dependabot[bot] opened a new pull request #24: Bump spotbugs from 4.2.0 to 4.4.2
dependabot[bot] opened a new pull request #24: URL: https://github.com/apache/commons-bsf/pull/24 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.0 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 SpotBugs 4.4.1 CHANGELOG
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request #216: Bump spotbugs from 4.3.0 to 4.4.2
dependabot[bot] opened a new pull request #216: URL: https://github.com/apache/commons-vfs/pull/216 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.3.0 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 SpotBugs 4.4.1 CHANGELOG
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #214: Bump spotbugs from 4.3.0 to 4.4.1
dependabot[bot] commented on pull request #214: URL: https://github.com/apache/commons-vfs/pull/214#issuecomment-940915636 Superseded by #216. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] closed pull request #214: Bump spotbugs from 4.3.0 to 4.4.1
dependabot[bot] closed pull request #214: URL: https://github.com/apache/commons-vfs/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] coveralls edited a comment on pull request #173: ISSUE-311 support multivariable rasters
coveralls edited a comment on pull request #173: URL: https://github.com/apache/commons-imaging/pull/173#issuecomment-938618702 [](https://coveralls.io/builds/43437527) Coverage increased (+0.02%) to 77.021% when pulling **a9b9c81f74a311e244af582667cee6480e1aacb8 on gwlucastrig:Imaging311** into **b76efb67b075f53b33af28026fea15e2916f771c on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] dependabot[bot] commented on pull request #56: Bump spotbugs from 4.2.0 to 4.4.1
dependabot[bot] commented on pull request #56: URL: https://github.com/apache/commons-logging/pull/56#issuecomment-940891027 Superseded by #58. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-logging] dependabot[bot] opened a new pull request #58: Bump spotbugs from 4.2.0 to 4.4.2
dependabot[bot] opened a new pull request #58: URL: https://github.com/apache/commons-logging/pull/58 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.0 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 SpotBugs 4.4.1 CHANGELOG
[GitHub] [commons-logging] dependabot[bot] closed pull request #56: Bump spotbugs from 4.2.0 to 4.4.1
dependabot[bot] closed pull request #56: URL: https://github.com/apache/commons-logging/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on a change in pull request #281: Io 753/copy output stream to input stream
garydgregory commented on a change in pull request #281:
URL: https://github.com/apache/commons-io/pull/281#discussion_r726992168
##
File path: src/main/java/org/apache/commons/io/IOUtils.java
##
@@ -979,6 +981,39 @@ public static int copy(final InputStream inputStream,
final OutputStream outputS
return (int) count;
}
+/**
+ * Copies bytes from a {@link java.io.ByteArrayOutputStream} to a {@code
QueueInputStream}.
+ *
+ * Unlike using JDK {@link PipedInputStream} and {@link PipedOutputStream}
for this, this solution works safely in a single thread
+ * environment.
Review comment:
The p HTML tag is still not closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663927=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663927
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 07:47
Start Date: 12/Oct/21 07:47
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092
[](https://coveralls.io/builds/43432747)
Coverage increased (+0.07%) to 96.023% when pulling
**93d13ca0955e95341ef38aeec46c72f2c4b212da on stoty:CLI-254** into
**6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663927)
Time Spent: 2h 40m (was: 2.5h)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] coveralls edited a comment on pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
coveralls edited a comment on pull request #58: URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092 [](https://coveralls.io/builds/43432747) Coverage increased (+0.07%) to 96.023% when pulling **93d13ca0955e95341ef38aeec46c72f2c4b212da on stoty:CLI-254** into **6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] coveralls commented on pull request #70: Bump spotbugs from 4.4.1 to 4.4.2
coveralls commented on pull request #70: URL: https://github.com/apache/commons-cli/pull/70#issuecomment-940743142 [](https://coveralls.io/builds/43432437) Coverage remained the same at 95.953% when pulling **ad86638e738abaa5246e8266e7e131c829043ab7 on dependabot/maven/com.github.spotbugs-spotbugs-4.4.2** into **6c94af34d792772a3f736be314093c5f01533cd0 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] dependabot[bot] opened a new pull request #70: Bump spotbugs from 4.4.1 to 4.4.2
dependabot[bot] opened a new pull request #70: URL: https://github.com/apache/commons-cli/pull/70 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 Changelog Sourced from https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md;>spotbugs's changelog. 4.4.2 -
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663910=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663910
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 07:07
Start Date: 12/Oct/21 07:07
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092
[](https://coveralls.io/builds/43431893)
Coverage increased (+0.07%) to 96.023% when pulling
**8380a93bb0ab331f2b57254b94ee77293beff063 on stoty:CLI-254** into
**6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663910)
Time Spent: 2.5h (was: 2h 20m)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] coveralls edited a comment on pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
coveralls edited a comment on pull request #58: URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092 [](https://coveralls.io/builds/43431893) Coverage increased (+0.07%) to 96.023% when pulling **8380a93bb0ab331f2b57254b94ee77293beff063 on stoty:CLI-254** into **6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663902=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663902
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:45
Start Date: 12/Oct/21 06:45
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092
[](https://coveralls.io/builds/43431523)
Coverage decreased (-0.1%) to 95.857% when pulling
**8be0ef03ad55a5c953d496f77ce9242bc77fcbb6 on stoty:CLI-254** into
**6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663902)
Time Spent: 2h 20m (was: 2h 10m)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] coveralls edited a comment on pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
coveralls edited a comment on pull request #58: URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092 [](https://coveralls.io/builds/43431523) Coverage decreased (-0.1%) to 95.857% when pulling **8be0ef03ad55a5c953d496f77ce9242bc77fcbb6 on stoty:CLI-254** into **6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663900=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663900
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:43
Start Date: 12/Oct/21 06:43
Worklog Time Spent: 10m
Work Description: stoty commented on pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#issuecomment-940711973
While working on this, I discovered that quote handlings needs to be a
tri-valued parameter.
I've changed the parameter into a Boolean, with null representing the old
inconsistent behaviour.
This way backwards compatibility is kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663900)
Time Spent: 2h 10m (was: 2h)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] stoty commented on pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
stoty commented on pull request #58: URL: https://github.com/apache/commons-cli/pull/58#issuecomment-940711973 While working on this, I discovered that quote handlings needs to be a tri-valued parameter. I've changed the parameter into a Boolean, with null representing the old inconsistent behaviour. This way backwards compatibility is kept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663898=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663898
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:36
Start Date: 12/Oct/21 06:36
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092
[](https://coveralls.io/builds/43431404)
Coverage decreased (-0.1%) to 95.857% when pulling
**2bdfd1c5cd64d60024fc9a54de59dd6cd415e144 on stoty:CLI-254** into
**6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663898)
Time Spent: 2h (was: 1h 50m)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663897=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663897
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:36
Start Date: 12/Oct/21 06:36
Worklog Time Spent: 10m
Work Description: stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726802436
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
+
+/** Flag indicating if partial matching of long options is supported.
*/
+private boolean allowPartialMatching = true;
+
+/** Flag indicating if balanced leading and trailing double quotes
should be stripped from option arguments. */
+private boolean stripLeadingAndTrailingQuotes = true;
+
+/**
+ * Constructs a new Builder for a
DefaultParser instance.
+ *
+ * Both allowPartialMatching and stripLeadingAndTrailingQuotes are
true by default,
+ * mimicking the argument-less constructor.
+ */
+private Builder()
+{
+}
+
+/**
+ * Sets if partial matching of long options is supported.
+ *
+ * By "partial matching" we mean that given the following code:
+ *
+ *
+ * {
+ * code
+ * final Options options = new Options();
+ * options.addOption(new Option("d", "debug", false, "Turn on
debug."));
+ * options.addOption(new Option("e", "extract", false, "Turn on
extract."));
+ * options.addOption(new Option("o", "option", true, "Turn on
option with argument."));
+ * }
+ *
+ *
+ * with "partial matching" turned on, {@code -de} only matches the
{@code "debug"} option. However, with
+ * "partial matching" disabled, {@code -de} would enable both {@code
debug} as well as {@code extract}
+ *
+ * @param allowPartialMatching whether to allow partial matching of
long options
+ * @return this builder, to allow method chaining
+ */
+public Builder setAllowPartialMatching(final boolean
allowPartialMatching)
+{
+this.allowPartialMatching = allowPartialMatching;
+return this;
+}
+
+/**
+ * Sets if balanced leading and trailing double quotes should be
stripped from option arguments.
+ *
+ * with "stripping of balanced leading and trailing double quotes from
option arguments" turned
+ * on, the outermost balanced double quotes of option arguments values
will be removed.
+ * ie.
+ * for -o '"x"' getValue() will return x,
instead of "x"
+ *
+ * @param stripLeadingAndTrailingQuotes whether balanced leading and
trailing double quotes should be stripped from option arguments.
+ * @return this builder, to allow method chaining
+ */
+public Builder setStripLeadingAndTrailingQuotes(final boolean
stripLeadingAndTrailingQuotes)
+{
+this.stripLeadingAndTrailingQuotes = stripLeadingAndTrailingQuotes;
+return this;
+}
+
+/**
+ * Constructs an DefaultParser with the values declared by this {@link
Builder}.
Review comment:
Rewritten.
##
File path: src/test/java/org/apache/commons/cli/ParserTestCase.java
##
@@ -970,4 +971,72 @@ public void testWithRequiredOption() throws Exception {
[GitHub] [commons-cli] coveralls edited a comment on pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
coveralls edited a comment on pull request #58: URL: https://github.com/apache/commons-cli/pull/58#issuecomment-770027092 [](https://coveralls.io/builds/43431404) Coverage decreased (-0.1%) to 95.857% when pulling **2bdfd1c5cd64d60024fc9a54de59dd6cd415e144 on stoty:CLI-254** into **6c94af34d792772a3f736be314093c5f01533cd0 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-cli] stoty commented on a change in pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726802436
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
+
+/** Flag indicating if partial matching of long options is supported.
*/
+private boolean allowPartialMatching = true;
+
+/** Flag indicating if balanced leading and trailing double quotes
should be stripped from option arguments. */
+private boolean stripLeadingAndTrailingQuotes = true;
+
+/**
+ * Constructs a new Builder for a
DefaultParser instance.
+ *
+ * Both allowPartialMatching and stripLeadingAndTrailingQuotes are
true by default,
+ * mimicking the argument-less constructor.
+ */
+private Builder()
+{
+}
+
+/**
+ * Sets if partial matching of long options is supported.
+ *
+ * By "partial matching" we mean that given the following code:
+ *
+ *
+ * {
+ * code
+ * final Options options = new Options();
+ * options.addOption(new Option("d", "debug", false, "Turn on
debug."));
+ * options.addOption(new Option("e", "extract", false, "Turn on
extract."));
+ * options.addOption(new Option("o", "option", true, "Turn on
option with argument."));
+ * }
+ *
+ *
+ * with "partial matching" turned on, {@code -de} only matches the
{@code "debug"} option. However, with
+ * "partial matching" disabled, {@code -de} would enable both {@code
debug} as well as {@code extract}
+ *
+ * @param allowPartialMatching whether to allow partial matching of
long options
+ * @return this builder, to allow method chaining
+ */
+public Builder setAllowPartialMatching(final boolean
allowPartialMatching)
+{
+this.allowPartialMatching = allowPartialMatching;
+return this;
+}
+
+/**
+ * Sets if balanced leading and trailing double quotes should be
stripped from option arguments.
+ *
+ * with "stripping of balanced leading and trailing double quotes from
option arguments" turned
+ * on, the outermost balanced double quotes of option arguments values
will be removed.
+ * ie.
+ * for -o '"x"' getValue() will return x,
instead of "x"
+ *
+ * @param stripLeadingAndTrailingQuotes whether balanced leading and
trailing double quotes should be stripped from option arguments.
+ * @return this builder, to allow method chaining
+ */
+public Builder setStripLeadingAndTrailingQuotes(final boolean
stripLeadingAndTrailingQuotes)
+{
+this.stripLeadingAndTrailingQuotes = stripLeadingAndTrailingQuotes;
+return this;
+}
+
+/**
+ * Constructs an DefaultParser with the values declared by this {@link
Builder}.
Review comment:
Rewritten.
##
File path: src/test/java/org/apache/commons/cli/ParserTestCase.java
##
@@ -970,4 +971,72 @@ public void testWithRequiredOption() throws Exception {
assertEquals("Confirm arg of -b", "file", cl.getOptionValue("b"));
assertTrue("Confirm NO of extra args", cl.getArgList().isEmpty());
}
+
+
+@Test
+public void testLongOptionWithEqualsQuoteHandling() throws Exception
+{
+assumeTrue(parser instanceof DefaultParser);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663896=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663896
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:35
Start Date: 12/Oct/21 06:35
Worklog Time Spent: 10m
Work Description: stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726802118
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
Review comment:
Done.
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
+
+/** Flag indicating if partial matching of long options is supported.
*/
+private boolean allowPartialMatching = true;
+
+/** Flag indicating if balanced leading and trailing double quotes
should be stripped from option arguments. */
+private boolean stripLeadingAndTrailingQuotes = true;
+
+/**
+ * Constructs a new Builder for a
DefaultParser instance.
+ *
+ * Both allowPartialMatching and stripLeadingAndTrailingQuotes are
true by default,
+ * mimicking the argument-less constructor.
+ */
+private Builder()
+{
+}
+
+/**
+ * Sets if partial matching of long options is supported.
+ *
+ * By "partial matching" we mean that given the following code:
+ *
+ *
+ * {
+ * code
+ * final Options options = new Options();
+ * options.addOption(new Option("d", "debug", false, "Turn on
debug."));
+ * options.addOption(new Option("e", "extract", false, "Turn on
extract."));
+ * options.addOption(new Option("o", "option", true, "Turn on
option with argument."));
+ * }
+ *
+ *
+ * with "partial matching" turned on, {@code -de} only matches the
{@code "debug"} option. However, with
+ * "partial matching" disabled, {@code -de} would enable both {@code
debug} as well as {@code extract}
+ *
+ * @param allowPartialMatching whether to allow partial matching of
long options
+ * @return this builder, to
[GitHub] [commons-cli] stoty commented on a change in pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726802118
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
Review comment:
Done.
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
+ *
+ * DefaultParser parser = Option.builder()
+ * .setAllowPartialMatching(false)
+ * .setStripLeadingAndTrailingQuotes(false)
+ * .build();
+ *
+ *
+ * @since 1.5
+ */
+public static final class Builder
+{
+
+/** Flag indicating if partial matching of long options is supported.
*/
+private boolean allowPartialMatching = true;
+
+/** Flag indicating if balanced leading and trailing double quotes
should be stripped from option arguments. */
+private boolean stripLeadingAndTrailingQuotes = true;
+
+/**
+ * Constructs a new Builder for a
DefaultParser instance.
+ *
+ * Both allowPartialMatching and stripLeadingAndTrailingQuotes are
true by default,
+ * mimicking the argument-less constructor.
+ */
+private Builder()
+{
+}
+
+/**
+ * Sets if partial matching of long options is supported.
+ *
+ * By "partial matching" we mean that given the following code:
+ *
+ *
+ * {
+ * code
+ * final Options options = new Options();
+ * options.addOption(new Option("d", "debug", false, "Turn on
debug."));
+ * options.addOption(new Option("e", "extract", false, "Turn on
extract."));
+ * options.addOption(new Option("o", "option", true, "Turn on
option with argument."));
+ * }
+ *
+ *
+ * with "partial matching" turned on, {@code -de} only matches the
{@code "debug"} option. However, with
+ * "partial matching" disabled, {@code -de} would enable both {@code
debug} as well as {@code extract}
+ *
+ * @param allowPartialMatching whether to allow partial matching of
long options
+ * @return this builder, to allow method chaining
+ */
Review comment:
Done
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663895=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663895
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:34
Start Date: 12/Oct/21 06:34
Worklog Time Spent: 10m
Work Description: stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726801691
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
Review comment:
I've just removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663895)
Time Spent: 1.5h (was: 1h 20m)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (CLI-254) "test" gets parsed as test, quotes die :-(
[
https://issues.apache.org/jira/browse/CLI-254?focusedWorklogId=663894=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663894
]
ASF GitHub Bot logged work on CLI-254:
--
Author: ASF GitHub Bot
Created on: 12/Oct/21 06:34
Start Date: 12/Oct/21 06:34
Worklog Time Spent: 10m
Work Description: stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726801420
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -101,6 +105,20 @@ public DefaultParser() {
*/
public DefaultParser(final boolean allowPartialMatching) {
this.allowPartialMatching = allowPartialMatching;
+this.stripLeadingAndTrailingQuotes = true;
+}
+
+/**
+ * Create a new DefaultParser instance with the specified partial matching
and quote
Review comment:
Done
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
Review comment:
Private is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 663894)
Time Spent: 1h 20m (was: 1h 10m)
> "test" gets parsed as test, quotes die :-(
> --
>
> Key: CLI-254
> URL: https://issues.apache.org/jira/browse/CLI-254
> Project: Commons CLI
> Issue Type: Bug
>Affects Versions: 1.3
>Reporter: Alexander Petrossian (PAF)
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code}
> def cli = new CliBuilder()
> cli.with {
> f longOpt:'json-filter','jq expression', args: 1
> }
> def vals = ['test', 't"es"t',
> "'test", "test'", "'test'",
> '"test', 'test"', '"test"']
> vals.each {
> def opt = cli.parse(['-f', it])
> assert opt.f == it
> }
> {code}
> It fails on last entry: "test".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-cli] stoty commented on a change in pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726801691
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
+protected String conditionallyStripLeadingAndTrailingQuotes(final String
token) {
+if (stripLeadingAndTrailingQuotes) {
+return Util.stripLeadingAndTrailingQuotes(token);
+} else {
+return token;
+}
+}
+
+/**
+ * Returns a {@link Builder} to create an {@link DefaultParser} using
descriptive
+ * methods.
+ *
+ * @return a new {@link Builder} instance
+ * @since 1.5
+ */
+public static Builder builder()
+{
+return new Builder();
+}
+
+/**
+ * A nested builder class to create DefaultParser instances
+ * using descriptive methods.
+ *
+ * Example usage:
Review comment:
I've just removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-cli] stoty commented on a change in pull request #58: CLI-254: "test" gets parsed as test, quotes die :-(
stoty commented on a change in pull request #58:
URL: https://github.com/apache/commons-cli/pull/58#discussion_r726801420
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -101,6 +105,20 @@ public DefaultParser() {
*/
public DefaultParser(final boolean allowPartialMatching) {
this.allowPartialMatching = allowPartialMatching;
+this.stripLeadingAndTrailingQuotes = true;
+}
+
+/**
+ * Create a new DefaultParser instance with the specified partial matching
and quote
Review comment:
Done
##
File path: src/main/java/org/apache/commons/cli/DefaultParser.java
##
@@ -625,4 +643,119 @@ private void updateRequiredOptions(final Option option)
throws AlreadySelectedEx
group.setSelected(option);
}
}
+
+/**
+ * Strip balanced leading and trailing quotes if the
stripLeadingAndTrailingQuotes is set
+ *
+ * @param token a string
+ * @return token with the quotes stripped (if set)
+ */
Review comment:
Private is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (COMPRESS-589) 1.21 throws a 'java.io.IOException: Truncated TAR archive' exception while 1.20 not
[
https://issues.apache.org/jira/browse/COMPRESS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427465#comment-17427465
]
chen commented on COMPRESS-589:
---
[~erans]
On Android devices, if the tar package size is greater than 2G,
inputStream.available() in the skipRecordPadding() method will return 0
On Windows, it will return 2147483647 (Integer.MAX_VALUE)
whether it cause the issue?
> 1.21 throws a 'java.io.IOException: Truncated TAR archive' exception while
> 1.20 not
> ---
>
> Key: COMPRESS-589
> URL: https://issues.apache.org/jira/browse/COMPRESS-589
> Project: Commons Compress
> Issue Type: Bug
>Affects Versions: 1.21
>Reporter: chen
>Priority: Major
>
> the bug happens when I use the TarArchiveInputStream to read bytes from the
> current tar archive entry.
> first of all, we ran into this issue on an *{color:#ff}Android
> device{color}*
> the trace shows as below
> {code:java}
> 08-27 14:39:18.657 10633 10963 W System.err: java.io.IOException: Truncated
> TAR archive
> 08-27 14:39:18.657 10633 10963 W System.err: java.io.IOException: Truncated
> TAR archive
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getActuallySkipped(TarArchiveInputStream.java:478)
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.skipRecordPadding(TarArchiveInputStream.java:455)
> 08-27 14:39:18.657 10633 10963 W System.err: at
> org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:367)
> {code}
> but when i downgrade to 1.20, the exception will not show again, so I think
> it is a bug in the new version
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #41: Bump spotbugs from 4.3.0 to 4.4.1
dependabot[bot] commented on pull request #41: URL: https://github.com/apache/commons-build-plugin/pull/41#issuecomment-940692828 Superseded by #43. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #41: Bump spotbugs from 4.3.0 to 4.4.1
dependabot[bot] closed pull request #41: URL: https://github.com/apache/commons-build-plugin/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #43: Bump spotbugs from 4.3.0 to 4.4.2
dependabot[bot] opened a new pull request #43: URL: https://github.com/apache/commons-build-plugin/pull/43 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.3.0 to 4.4.2. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases;>spotbugs's releases. SpotBugs 4.4.2 CHANGELOG Changed Add bug code to report in fancy-hist.xsl (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1688;>#1688) https://github.com/friscoMad;>@friscoMad Bump Saxon-HE from 10.5 to 10.6 (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1715;>#1715) Fixed Fixed immutable java.lang.Class as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1695;>#1695) https://github.com/rovarga;>@rovarga Agree verb with plural subject in the description of SW_SWING_METHODS_INVOKED_IN_SWING_THREAD (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Wrong description of the SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1664;>#1664) https://github.com/pzygielo;>@pzygielo Fixed java.util.Locale as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Fixed reference to java.awt.Cursor which caused it to be flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1702;>#1702) https://github.com/candrews;>@candrews Treat types with @com.google.errorprone.annotations.Immutable as immutable (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1705;>#1705) https://github.com/rovarga;>@rovarga Fix annotation check for jdk.internal.ValueBased (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1706;>#1706) https://github.com/rovarga;>@rovarga DMI_RANDOM_USED_ONLY_ONCE false positive (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1539;>#1539) https://github.com/KengoTODA;>@KengoTODA NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR false negative (https://github-redirect.dependabot.com/spotbugs/spotbugs/issues/1642;>#1642) https://github.com/andipabst;>@andipabst Immutable java.util.regex.Pattern as being flagged as EI (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1738;>#1695) https://github.com/candrews;>@candrews Resource leak in the JrtfsCodeBase (https://github-redirect.dependabot.com/spotbugs/spotbugs/pull/1732;>#1732) https://github.com/lujiefsi;>@lujiefsi CHECKSUM file checksum (sha256) spotbugs-4.4.2-javadoc.jar ebd9595105d8ffa5b04de8cc0ec103d3bad9db0098127fa6a13628b352739cac spotbugs-4.4.2-sources.jar a1a27e7c0bf35d53069cfb6ffe6e6c024ab00dc1c236507bebacae9a7be6ecf4 spotbugs-4.4.2.tgz 459c3b245718338c010c4e2444a5c40900e8455b1127280a7e2515e60212dea1 spotbugs-4.4.2.zip 3972c65e1d32d584e94dd45269f83a70566e8db98c0335bab1f5caf465ca98f5 spotbugs-annotations-4.4.2-javadoc.jar c75937d9ed96191dc2adad18c47c8561b53837e2546aadf207ec41d66bd7ba11 spotbugs-annotations-4.4.2-sources.jar b338136e3e82d585348cde58a8fe3a678e16f51a35c31c1463e05fefef557aad spotbugs-annotations.jar baccf1cae5a8569903707c5429f949934c64feb50e6dba79e33f4dab195c482d spotbugs-ant-4.4.2-javadoc.jar b38d143ed62b41738e15607592fa63df9ce32aff31eb98dca34e567857e3b46d spotbugs-ant-4.4.2-sources.jar c74dec42c0ed0dd1ae02a7410d8e0f0dbbee23e8e7da4a21910863677fcdbc8e spotbugs-ant.jar b6e73b68e441c001dc42754c73b811625915ae9a759e1ed719df095b41f2979a spotbugs.jar b6ad77661a4db83192d866e91c755fb70fc7b06332bb1efd88278461c8cb08b5 test-harness-4.4.2-javadoc.jar 6ccf92a3812913916fb93316b30ee7c460fa9e5790c285815ef4e4df30a7e999 test-harness-4.4.2-sources.jar 2c1f5ef929453f3b682c7eb7c1e22db3082b5f74c5a5be439be5dc31dd7a31aa test-harness-4.4.2.jar 45ca0e944ee5704318d79f67815cde7ca5f7fb22814e325d00e2d25d9b552659 test-harness-core-4.4.2-javadoc.jar 458fbe233430631dccb143da2d24b357d60d6a82caf3c0275f331b917446e39e test-harness-core-4.4.2-sources.jar f320f5eb4069e9686b760b2a6a0760989753225f9e9ce1226e3258ec64795d8a test-harness-core-4.4.2.jar fd1a0c06a5eaff50ed0953d42fb7d69a41031c6a6630ad5e47c38a9f0eaca285 test-harness-jupiter-4.4.2-javadoc.jar e398a17ebd760f48628a774ec40a07390db3442306bc8867ce7ed4be9361cef3 test-harness-jupiter-4.4.2-sources.jar 210353a57016e26b1a654d936a15f039613fa1ac532d485c1b1d03902f6c6315 test-harness-jupiter-4.4.2.jar 18095fec31b85981ecaafdef86ca9ae1e9588e1b9bc6d209f82829cf9d0c13f4 SpotBugs 4.4.1 CHANGELOG
