[GitHub] [commons-io] data443-cboyd commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
data443-cboyd commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958689368 Hi @garydgregory , the pull request has been updated. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-756) Update FileWriterWithEncoding to extend ProxyWriter
[ https://issues.apache.org/jira/browse/IO-756?focusedWorklogId=674405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674405 ] ASF GitHub Bot logged work on IO-756: - Author: ASF GitHub Bot Created on: 03/Nov/21 06:35 Start Date: 03/Nov/21 06:35 Worklog Time Spent: 10m Work Description: wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 674405) Time Spent: 20m (was: 10m) > Update FileWriterWithEncoding to extend ProxyWriter > --- > > Key: IO-756 > URL: https://issues.apache.org/jira/browse/IO-756 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Affects Versions: 2.11.0 >Reporter: Woden Cafe >Priority: Minor > Labels: Commons, io > Fix For: 2.12.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This change is to make org.apache.commons.io.output.FileWriterWithEncoding > extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's > delegate Writer rather than storing the delegate Writer reference within > FileWriterWithEncoding explicitly. > This simplifies FileWriterWithEncoding as it no longer needs to override any > methods from its super class, and no longer needs to store and maintain a > reference to a delegate Writer explicitly - this is provided by the super > class already. > [~kinow] Here is the ticket for the Pull Request. > https://github.com/apache/commons-io/pull/296 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] wodencafe commented on a change in pull request #296: IO-756: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741647754 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: Good point, we should just let the super class handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (CLI-310) Purge release version 20040117.000000 from Maven Central
[
https://issues.apache.org/jira/browse/CLI-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437755#comment-17437755
]
Markus Spann commented on CLI-310:
--
[~b.eckenfels], were you able to get in touch with OSSRH?
> Purge release version 20040117.00 from Maven Central
>
>
> Key: CLI-310
> URL: https://issues.apache.org/jira/browse/CLI-310
> Project: Commons CLI
> Issue Type: Task
>Reporter: Markus Spann
>Priority: Minor
>
> How did commons-cli "release version" 20040117.00 make it into Maven
> Central?
> It's been there for as long as I can remember.
> It would not bother any of us if this version did not always show up as the
> most recent/latest/bleeding edge release. Even though it's ancient and noone
> would want to use it of course.
> This effect is due to this version not following the commons-cli version
> scheme and due to the way Maven sorts version strings.
> A small use case to illustrate:
>
> {code:java}
> mvn versions:display-dependency-updates
> {code}
>
> {code:java}
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO] commons-cli:commons-cli ... 1.4 -> 20040117.00
> {code}
> I understand that purging release artifacts from Central may not be simple.
> Yet it would be so much appreciated if someone with the corresponding
> know-how and access could take care of it. Thanks a million!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-build-plugin] dependabot[bot] commented on pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45#issuecomment-958674352 Superseded by #48. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] opened a new pull request #48: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #48: URL: https://github.com/apache/commons-build-plugin/pull/48 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-build-plugin] dependabot[bot] closed pull request #45: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #45: URL: https://github.com/apache/commons-build-plugin/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-756) Update FileWriterWithEncoding to extend ProxyWriter
[ https://issues.apache.org/jira/browse/IO-756?focusedWorklogId=674395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674395 ] ASF GitHub Bot logged work on IO-756: - Author: ASF GitHub Bot Created on: 03/Nov/21 05:46 Start Date: 03/Nov/21 05:46 Worklog Time Spent: 10m Work Description: wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958670115 @kinow No problem, here is the associated JIRA ticket: https://issues.apache.org/jira/browse/IO-756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 674395) Remaining Estimate: 0h Time Spent: 10m > Update FileWriterWithEncoding to extend ProxyWriter > --- > > Key: IO-756 > URL: https://issues.apache.org/jira/browse/IO-756 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Affects Versions: 2.11.0 >Reporter: Woden Cafe >Priority: Minor > Labels: Commons, io > Fix For: 2.12.0 > > Time Spent: 10m > Remaining Estimate: 0h > > This change is to make org.apache.commons.io.output.FileWriterWithEncoding > extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's > delegate Writer rather than storing the delegate Writer reference within > FileWriterWithEncoding explicitly. > This simplifies FileWriterWithEncoding as it no longer needs to override any > methods from its super class, and no longer needs to store and maintain a > reference to a delegate Writer explicitly - this is provided by the super > class already. > [~kinow] Here is the ticket for the Pull Request. > https://github.com/apache/commons-io/pull/296 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] wodencafe commented on pull request #296: IO-756: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958670115 @kinow No problem, here is the associated JIRA ticket: https://issues.apache.org/jira/browse/IO-756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IO-756) Update FileWriterWithEncoding to extend ProxyWriter
Woden Cafe created IO-756: - Summary: Update FileWriterWithEncoding to extend ProxyWriter Key: IO-756 URL: https://issues.apache.org/jira/browse/IO-756 Project: Commons IO Issue Type: Improvement Components: Streams/Writers Affects Versions: 2.11.0 Reporter: Woden Cafe Fix For: 2.12.0 This change is to make org.apache.commons.io.output.FileWriterWithEncoding extend org.apache.commons.io.output.ProxyWriter, to use the ProxyWriter's delegate Writer rather than storing the delegate Writer reference within FileWriterWithEncoding explicitly. This simplifies FileWriterWithEncoding as it no longer needs to override any methods from its super class, and no longer needs to store and maintain a reference to a delegate Writer explicitly - this is provided by the super class already. [~kinow] Here is the ticket for the Pull Request. https://github.com/apache/commons-io/pull/296 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-ognl] lukaszlenart merged pull request #52: Bump actions/checkout from 2.3.5 to 2.4.0
lukaszlenart merged pull request #52: URL: https://github.com/apache/commons-ognl/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] closed pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #20: URL: https://github.com/apache/commons-chain/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] commented on pull request #20: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #20: URL: https://github.com/apache/commons-chain/pull/20#issuecomment-958658936 Superseded by #21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-chain] dependabot[bot] opened a new pull request #21: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #21: URL: https://github.com/apache/commons-chain/pull/21 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] commented on pull request #142: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] commented on pull request #142: URL: https://github.com/apache/commons-dbcp/pull/142#issuecomment-958649485 Superseded by #144. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] closed pull request #142: Bump checkstyle from 9.0 to 9.0.1
dependabot[bot] closed pull request #142: URL: https://github.com/apache/commons-dbcp/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #144: Bump checkstyle from 9.0 to 9.1
dependabot[bot] opened a new pull request #144: URL: https://github.com/apache/commons-dbcp/pull/144 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.0 to 9.1. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-9.1 https://checkstyle.org/releasenotes.html#Release_9.1";>https://checkstyle.org/releasenotes.html#Release_9.1 checkstyle-9.0.1 https://checkstyle.org/releasenotes.html#Release_9.0.1";>https://checkstyle.org/releasenotes.html#Release_9.0.1 Commits https://github.com/checkstyle/checkstyle/commit/cfd1c333a866bd32912a1947e86ac0fceaf3ad65";>cfd1c33 [maven-release-plugin] prepare release checkstyle-9.1 https://github.com/checkstyle/checkstyle/commit/1d669a715b6f2afe3d550ba22c7d04510bc89564";>1d669a7 config: update to 9.1-SNAPSHOT https://github.com/checkstyle/checkstyle/commit/1fff33f3dbd12785c2054935557e79adff3a197d";>1fff33f doc: release notes 9.1 https://github.com/checkstyle/checkstyle/commit/8c1f59ac5a47229bf08cec31ecd3d7f6e18cf656";>8c1f59a config: bump reflection version to 0.10.2 https://github.com/checkstyle/checkstyle/commit/aea3174b452ea02adedd7781f036901f071d88c9";>aea3174 dependency: bump archunit-junit5 from 0.21.0 to 0.22.0 https://github.com/checkstyle/checkstyle/commit/0fe36b504fc80c3d3f0ffdb642f113987ef30b63";>0fe36b5 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9419";>#9419: created example of AST for TokenTypes.DOUBLE_COLON https://github.com/checkstyle/checkstyle/commit/fdea6be4a3da1e0315670df90b20e53b0fef0127";>fdea6be doc: fix broken scm manager install link https://github.com/checkstyle/checkstyle/commit/2e840c627f0fddb4c66e80debeb9398f844d271c";>2e840c6 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10866";>#10866: Fix false positive for switch expressions with operator in Miss... https://github.com/checkstyle/checkstyle/commit/073289a4ad02d468bf814b689e7ec1b04cc669ef";>073289a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10855";>#10855: fix unused imports check for array references https://github.com/checkstyle/checkstyle/commit/825af33e45611897b464af0718633ab803514514";>825af33 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10872";>#10872: Make violations diff readable Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.0...checkstyle-9.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] closed pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #21: URL: https://github.com/apache/commons-digester/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] commented on pull request #21: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #21: URL: https://github.com/apache/commons-digester/pull/21#issuecomment-958640404 Superseded by #22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #22: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #22: URL: https://github.com/apache/commons-digester/pull/22 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #227: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #227: URL: https://github.com/apache/commons-compress/pull/227 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #143: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #143: URL: https://github.com/apache/commons-dbcp/pull/143 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] kinow merged pull request #263: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #263: URL: https://github.com/apache/commons-collections/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=674354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674354 ] ASF GitHub Bot logged work on IMAGING-159: -- Author: ASF GitHub Bot Created on: 03/Nov/21 03:08 Start Date: 03/Nov/21 03:08 Worklog Time Spent: 10m Work Description: kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 674354) Time Spent: 11.5h (was: 11h 20m) > There should be a Parameters class > -- > > Key: IMAGING-159 > URL: https://issues.apache.org/jira/browse/IMAGING-159 > Project: Commons Imaging > Issue Type: Improvement > Components: imaging.* >Affects Versions: 1.0-alpha2 >Reporter: Benedikt Ritter >Assignee: Bruno P. Kinoshita >Priority: Major > Labels: github >
[GitHub] [commons-imaging] kinow commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958618064 >> If the JpegImageParser requires a parameter different than the TiffImageParser, I assume we would have to create a new JpegImagingParameter. In that case, wouldn't we have to keep the old constructor for backward compatibility until a new major release? > >I'm not totally sure what you mean here. Can you give an example? Sorry, I wasn't very clear. At the moment we have `JpegImageParser parser = new JpegImageParser();`. Internally, the `JpegImageParser` is using a `TiffImagingParameters`. But if we need to add a parameter that is used only by the `JpegImageParser`, I think we would want to have a `JpegImagingParameters`. In which case I am not sure if we would be able to maintain backward compatibility by replacing the `TiffImagingParameters` in the `JpegImageParser`. >since it makes it it kind of hard to tell what parameters to use when creating images of a certain type. :point_up: this is my main concern. Avoid users having to guess what's the parameter that they want to use when parsing a Jpeg, Tiff, Gif, etc. Preferably something that their IDE's can assist with, using auto-complete for example. >One idea for making this readily available in the API would be to add convenience factory methods in Imaging for creating instances of each parameters type. Ex: Possibly another design to consider/experiment :-) >Side note: Is there a reason the JpegImageParser uses TiffImageParameters? The two formats are not related, correct? Perhaps we could have a common base class for them? We can probably avoid that. I agree it doesn't make much sense for the parameters to have a relationship like that. Currently, [`JpegImageParser`](https://github.com/apache/commons-imaging/blob/0ccabc3416cecf25cdec90a522f0912baf19bc58/src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java#L751) has some code in common with the `TiffImageParser` for parsing EXIF metadata. I don't recall 100%, but I believe that's why I implemented everything in the `TiffImagingParameters` and, realizing the Jpeg parameters were the same, made the parent-child class relantionship. >Is the idea that it is confusing on what properties are copied over? Not at all, that part is clear and looks OK. It's with users being able to use the wrong parameter class by accident, and realizing only in runtime iff a runtime exception is thrown (or in the worst case, no exception is thrown and the program behaves in a wrong way; debugging an issue like that can be annoying I think). >I attempted to retain the null parameter functionality. In the normalizeParameters method, if a null parameter is passed, a default instance is created and returned, allowing downstream code to bypass null checks. mvn clean install passes with my current setup. Is there a unit test I missed? Ah, my bad! Your solution works with the method I was looking at. I wrote this one before looking at the method that creates the default parameters :+1: I need to find some time to “get in the zone” and try a few things. But it would be, mainly, to prevent users being able to use the wrong parameter types by accident, and making it so that we can add/remove parameters (deprecating what was removed) in the 1.x release series without worrying about backward compatibility. If we are able to modify your PR again to accommodate these two requirements, I think we would have the perfect solution :-) Thanks a lot! Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls commented on pull request #125: Bump actions/checkout from 2.3.4 to 2.4.0
coveralls commented on pull request #125: URL: https://github.com/apache/commons-fileupload/pull/125#issuecomment-958617571 [](https://coveralls.io/builds/43970729) Coverage remained the same at 77.585% when pulling **c1b2c15139128cee63f20c2f833ffcd1143235cf on dependabot/github_actions/actions/checkout-2.4.0** into **55f485d8436578a3f0b89a753043311e93b3849a on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow edited a comment on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow edited a comment on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958613424 @wodencafe we would also need a JIRA for this, could you create one? I think we will be able to make `FilterWriterWithEncoding` extend `ProxyWriter`. But in case we find a roadblock somewhere and we are not able to make `FileWriterWithEncoding` extend `ProxyWriter`, we should be able to at least improve the existing comment in the code explaining better why that's not possible (just in case it's indeed not possible :+1: ) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958613424 @wodencafe we would also need a JIRA for this, could you create one? I think we will be able to make `FilterWriterWithEncoding` extend `ProxyWriter`. But in case we find a roadblock somewhere and we are not able to make `FileWriterWithEncoding` extend `ProxyWriter`, we should be able to at least improve the existing comment in the code explaining better why that's not possible (just in case it's indeed no possible :+1: ) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow commented on a change in pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on a change in pull request #296: URL: https://github.com/apache/commons-io/pull/296#discussion_r741586353 ## File path: src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java ## @@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final String charsetName, f */ Review comment: @wodencafe do we need to override the methods below? Could we just use the parent methods directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958611431 Hello again @kinow , just wanted to let you know that the changes have been made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-958602720 Hi @kinow , thanks for reviewing the code. Actually I think that bottom approach is simpler, I'll give it a try, and update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IMAGING-159) There should be a Parameters class
[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=674306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674306
]
ASF GitHub Bot logged work on IMAGING-159:
--
Author: ASF GitHub Bot
Created on: 03/Nov/21 02:03
Start Date: 03/Nov/21 02:03
Worklog Time Spent: 10m
Work Description: darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
@kinow
> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we have to keep the old constructor for backward
compatibility until a new major release?
I'm not totally sure what you mean here. Can you give an example?
On a related note, in my merge request, I removed all of the parameter
classes that did not actually have any of their own properties (such as
JpegImageParameters). I'm not sure if this is a great idea, though, since it
makes it it kind of hard to tell what parameters to use when creating images of
a certain type. If might be better to add them back just for the convenience of
not having to look in the documentation to find what parameters class to use.
For example, if you are creating a JPEG, you automatically know that you need a
JpegImageParameters; BMP implies BmpImageParameters, etc.
One idea for making this readily available in the API would be to add
convenience factory methods in Imaging for creating instances of each
parameters type. Ex:
```
public static BmpImageParameters bmpParameters() { return new
BmpImageParameters(); }
public static TiffImageParameters tiffParameters() { return new
TiffImageParameters(); }
```
This way, users would be able to find the parameters class they want by
looking at a single class. The methods would return the specific
ImageParameters subclass so users could immediately access all of the available
properties.
Side note: Is there a reason the JpegImageParser uses TiffImageParameters?
The two formats are not related, correct? Perhaps we could have a common base
class for them?
> I think it would be best if cases like this were not allowed
PcxImagingParameters parser = new PcxImagingParameters(new
TiffImagingParameters()); // no error in compile or runtime
Is the idea that it is confusing on what properties are copied over? My
thought is that the copy constructor copies over as many fields as it can and
ignores the rest. For example, say you are writing an image out in multiple
formats. You could create a very specific parameter instance and then use the
copy constructors to copy relevant fields for the other formats.
```
TiffImageParameters tiffParams = new TiffImageParameters();
// populate params...
// create images
Imaging.writeImage(src, fileA, ImageFormats.TIFF, tiffParams);
Imaging.writeImage(src, fileB, ImageFormats.BMP, new
BmpImageParameters(tiffParams));
Imaging.writeImage(src, fileC, ImageFormats.PNG, new
PngImageParameters(tiffParams));
```
> I think you removed the option to allow null parameters in the
Imaging#writeImage method (and other methods). I thought about doing that too,
that would remove one generic suppress I think, but there are unit tests and
examples. The API has allowed it since Sanselan, so not too sure about
enforcing parameters to be non-null now.
I attempted to retain the null parameter functionality. In the
`normalizeParameters` method, if a null parameter is passed, a default instance
is created and returned, allowing downstream code to bypass null checks. `mvn
clean install` passes with my current setup. Is there a unit test I missed?
> I liked the error in this one new PngImageParser().writeImage(null, null,
new TiffImagingParameters());, which gives java.lang.IllegalArgumentException:
Invalid imaging parameters: expected type...
Thanks! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 674306)
Time Spent: 11h 20m (was: 11h 10m)
> There should be a Parameters class
> --
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
>Affects Versions: 1.0-alpha2
>Reporter: Benedikt Ritter
>Assignee: Bruno P. Kinoshita
>Priority: Major
>
[GitHub] [commons-imaging] darkma773r commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)
darkma773r commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-958597172
@kinow
> If the JpegImageParser requires a parameter different than the
TiffImageParser, I assume we would have to create a new JpegImagingParameter.
In that case, wouldn't we have to keep the old constructor for backward
compatibility until a new major release?
I'm not totally sure what you mean here. Can you give an example?
On a related note, in my merge request, I removed all of the parameter
classes that did not actually have any of their own properties (such as
JpegImageParameters). I'm not sure if this is a great idea, though, since it
makes it it kind of hard to tell what parameters to use when creating images of
a certain type. If might be better to add them back just for the convenience of
not having to look in the documentation to find what parameters class to use.
For example, if you are creating a JPEG, you automatically know that you need a
JpegImageParameters; BMP implies BmpImageParameters, etc.
One idea for making this readily available in the API would be to add
convenience factory methods in Imaging for creating instances of each
parameters type. Ex:
```
public static BmpImageParameters bmpParameters() { return new
BmpImageParameters(); }
public static TiffImageParameters tiffParameters() { return new
TiffImageParameters(); }
```
This way, users would be able to find the parameters class they want by
looking at a single class. The methods would return the specific
ImageParameters subclass so users could immediately access all of the available
properties.
Side note: Is there a reason the JpegImageParser uses TiffImageParameters?
The two formats are not related, correct? Perhaps we could have a common base
class for them?
> I think it would be best if cases like this were not allowed
PcxImagingParameters parser = new PcxImagingParameters(new
TiffImagingParameters()); // no error in compile or runtime
Is the idea that it is confusing on what properties are copied over? My
thought is that the copy constructor copies over as many fields as it can and
ignores the rest. For example, say you are writing an image out in multiple
formats. You could create a very specific parameter instance and then use the
copy constructors to copy relevant fields for the other formats.
```
TiffImageParameters tiffParams = new TiffImageParameters();
// populate params...
// create images
Imaging.writeImage(src, fileA, ImageFormats.TIFF, tiffParams);
Imaging.writeImage(src, fileB, ImageFormats.BMP, new
BmpImageParameters(tiffParams));
Imaging.writeImage(src, fileC, ImageFormats.PNG, new
PngImageParameters(tiffParams));
```
> I think you removed the option to allow null parameters in the
Imaging#writeImage method (and other methods). I thought about doing that too,
that would remove one generic suppress I think, but there are unit tests and
examples. The API has allowed it since Sanselan, so not too sure about
enforcing parameters to be non-null now.
I attempted to retain the null parameter functionality. In the
`normalizeParameters` method, if a null parameter is passed, a default instance
is created and returned, allowing downstream code to bypass null checks. `mvn
clean install` passes with my current setup. Is there a unit test I missed?
> I liked the error in this one new PngImageParser().writeImage(null, null,
new TiffImagingParameters());, which gives java.lang.IllegalArgumentException:
Invalid imaging parameters: expected type...
Thanks! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] opened a new pull request #91: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #91: URL: https://github.com/apache/commons-net/pull/91 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437694#comment-17437694
]
Gilles Sadowski commented on NUMBERS-167:
-
With the new patch on PR 106, an example usage would be
{code}
RegularizedGamma.ComplementaryFunctions f = RegularizedGamma.P.withArgumentA(a);
{code}
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated NUMBERS-167:
Attachment: (was: pr_106.patch)
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NUMBERS-167) RegularizedGamma.P with precomputed LogGamma value
[
https://issues.apache.org/jira/browse/NUMBERS-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated NUMBERS-167:
Attachment: pr_106.patch
> RegularizedGamma.P with precomputed LogGamma value
> --
>
> Key: NUMBERS-167
> URL: https://issues.apache.org/jira/browse/NUMBERS-167
> Project: Commons Numbers
> Issue Type: Wish
> Components: gamma
>Reporter: Gilles Sadowski
>Priority: Minor
> Fix For: 1.1
>
> Attachments: pr_106.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We have
> {code:java}
> double v = RegularizedGamma.P.value(a, x);
> {code}
> where method {{value}} internally calls {{LogGamma.value(a)}}.
> There is a use-case for
> {code:java}
> double logGammaA = LogGamma.value(a);
> double v = RegularizedGamma.P.value(a, x, logGammaA);
> {code}
> for when the user varies {{x}} but not {{a}}.
> Method name TBD: Another overload of {{value}} may be confusing (?).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-io] kinow merged pull request #298: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #298: URL: https://github.com/apache/commons-io/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] closed pull request #29: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #29: URL: https://github.com/apache/commons-scxml/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] opened a new pull request #30: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #30: URL: https://github.com/apache/commons-scxml/pull/30 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-scxml] dependabot[bot] commented on pull request #29: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #29: URL: https://github.com/apache/commons-scxml/pull/29#issuecomment-958508599 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request #298: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #298: URL: https://github.com/apache/commons-io/pull/298 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on pull request #296:
URL: https://github.com/apache/commons-io/pull/296#issuecomment-958427374
@wodencafe I was curious, and tried the following too before jumping to
other PRs:
```diff
diff --git
a/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
b/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
index 3d7cfb27..7fbeee23 100644
--- a/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
+++ b/src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
@@ -46,10 +46,7 @@
*
* @since 1.4
*/
-public class FileWriterWithEncoding extends Writer {
-// Cannot extend ProxyWriter, as requires writer to be
-// known when super() is called
-
+public class FileWriterWithEncoding extends ProxyWriter {
/**
* Initializes the wrapped file writer. Ensure that a cleanup occurs if
the writer creation fails.
*
@@ -85,9 +82,6 @@ private static Writer initWriter(final File file, final
Object encoding, final b
}
}
-/** The writer to decorate. */
-private final Writer out;
-
/**
* Constructs a FileWriterWithEncoding with a file encoding.
*
@@ -110,7 +104,7 @@ public FileWriterWithEncoding(final File file, final
Charset charset) throws IOE
* @throws IOException in case of an I/O error.
*/
public FileWriterWithEncoding(final File file, final Charset encoding,
final boolean append) throws IOException {
-this.out = initWriter(file, encoding, append);
+super(initWriter(file, encoding, append));
}
/**
@@ -135,7 +129,7 @@ public FileWriterWithEncoding(final File file, final
CharsetEncoder charsetEncod
* @throws IOException in case of an I/O error.
*/
public FileWriterWithEncoding(final File file, final CharsetEncoder
charsetEncoder, final boolean append) throws IOException {
-this.out = initWriter(file, charsetEncoder, append);
+super(initWriter(file, charsetEncoder, append));
}
/**
@@ -160,7 +154,7 @@ public FileWriterWithEncoding(final File file, final
String charsetName) throws
* @throws IOException in case of an I/O error.
*/
public FileWriterWithEncoding(final File file, final String
charsetName, final boolean append) throws IOException {
-this.out = initWriter(file, charsetName, append);
+super(initWriter(file, charsetName, append));
}
/**
```
I think it achieves something similar to what you are suggesting here, but
without the extra internal class? I haven't tested it, and haven't worked on IO
lately, so other committers would have to take a look at it too. But WDYT?
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] kinow commented on a change in pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r741530222
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -46,9 +46,53 @@
*
* @since 1.4
*/
-public class FileWriterWithEncoding extends Writer {
-// Cannot extend ProxyWriter, as requires writer to be
-// known when super() is called
+public class FileWriterWithEncoding extends ProxyWriter {
+
+private static final Writer NULL_WRITER = new Writer() {
Review comment:
Just saw your comment about the `Writer.nullWriter()`, I guess that's
where you got the name from :+1: no need to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-io] kinow commented on a change in pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
kinow commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r741526857
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -46,9 +46,53 @@
*
* @since 1.4
*/
-public class FileWriterWithEncoding extends Writer {
-// Cannot extend ProxyWriter, as requires writer to be
-// known when super() is called
+public class FileWriterWithEncoding extends ProxyWriter {
+
+private static final Writer NULL_WRITER = new Writer() {
Review comment:
Not sure if it's handling `null`s, or being used when some value is
`null`. But maybe `NOOP_WRITER` would be a better name?
##
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##
@@ -160,7 +209,11 @@ public FileWriterWithEncoding(final File file, final
String charsetName) throws
* @throws IOException in case of an I/O error.
*/
public FileWriterWithEncoding(final File file, final String charsetName,
final boolean append) throws IOException {
-this.out = initWriter(file, charsetName, append);
+super(NULL_WRITER);
+
+super.out = initWriter(file, charsetName, append);
Review comment:
Ah, I think now I understand this pull request.
@wodencafe I think we pass the `NULL_WRITER` to the parent `ProxyWriter` as
a way to give it a valid object. But in reality, that `NULL_WRITER` is then
replaced here when we call `super.out = `.
While I guess that would work, but not sure if modifying setting `super.out`
twice (once after the `super(NULL_WRITER)`, then here :point_up: ) would be the
best approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] opened a new pull request #101: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #101: URL: https://github.com/apache/commons-beanutils/pull/101 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] dependabot[bot] commented on pull request #65: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #65: URL: https://github.com/apache/commons-validator/pull/65#issuecomment-958353851 Superseded by #66. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] commented on pull request #100: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #100: URL: https://github.com/apache/commons-beanutils/pull/100#issuecomment-958353908 Superseded by #101. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-beanutils] dependabot[bot] closed pull request #100: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #100: URL: https://github.com/apache/commons-beanutils/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] dependabot[bot] opened a new pull request #66: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #66: URL: https://github.com/apache/commons-validator/pull/66 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-validator] dependabot[bot] closed pull request #65: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #65: URL: https://github.com/apache/commons-validator/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #279: Bump actions/checkout from 2.3.5 to 2.4.0
kinow merged pull request #279: URL: https://github.com/apache/commons-text/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #280: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #280: URL: https://github.com/apache/commons-text/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] kinow merged pull request #824: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #824: URL: https://github.com/apache/commons-lang/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
wodencafe commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-958183537 @garydgregory This is a fair point, I will update the PR later tonight with an approach of correcting the JavaDoc based on the existing behavior, rather than the other way around (changing the behavior to match the existing JavaDoc). Thank you for the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding itself. We can probably also get rid of the write methods in FileWriterWithEncoding, and just let them delegate to the superclass ProxyWriter. This will reduce the amount of code significantly, but also the JavaDoc for those methods will be inherited from ProxyWriter. Also starting with Java 11, there is the static Writer.nullWriter(), which can be used instead of the anonymous class instance NULL_WRITER (whenever Apache Commons IO upgrades minimum version to Java 11). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] closed pull request #70: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #70: URL: https://github.com/apache/commons-rdf/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #194: Bump checkstyle from 9.0.1 to 9.1
garydgregory merged pull request #194: URL: https://github.com/apache/commons-csv/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] commented on pull request #70: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #70: URL: https://github.com/apache/commons-rdf/pull/70#issuecomment-958093838 Superseded by #71. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] closed pull request #107: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #107: URL: https://github.com/apache/commons-bcel/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe edited a comment on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe edited a comment on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class instance for writing (OutputStreamWriter) is stored in ProxyWriter rather than inside FileWriterWithEncoding itself. We can probably also get rid of the write methods in FileWriterWithEncoding, and just let them delegate to the superclass ProxyWriter. This will reduce the amount of code significantly, but also the JavaDoc for those methods will be inherited from ProxyWriter. Also, with regard to the anonymous class instance of Writer, NULL_WRITER: starting with Java 11, there is the static method Writer.nullWriter(), which can be used instead of the anonymous class instance NULL_WRITER (whenever Apache Commons IO upgrades minimum version to Java 11). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #121: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #121: URL: https://github.com/apache/commons-fileupload/pull/121#issuecomment-957996316 Superseded by #125. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] commented on pull request #107: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #107: URL: https://github.com/apache/commons-bcel/pull/107#issuecomment-958080616 Superseded by #108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-552) FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with '~' (tilde)
[
https://issues.apache.org/jira/browse/IO-552?focusedWorklogId=674093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674093
]
ASF GitHub Bot logged work on IO-552:
-
Author: ASF GitHub Bot
Created on: 02/Nov/21 21:39
Start Date: 02/Nov/21 21:39
Worklog Time Spent: 10m
Work Description: wodencafe opened a new pull request #297:
URL: https://github.com/apache/commons-io/pull/297
This pull request is meant to address
https://issues.apache.org/jira/projects/IO/issues/IO-552 by treating tilde ~ as
a valid character for file and directory names.
https://issues.apache.org/jira/projects/IO/issues/IO-552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 674093)
Time Spent: 0.5h (was: 20m)
> FilenameUtils.concat fails if second argument (fullFilenameToAdd) starts with
> '~' (tilde)
> -
>
> Key: IO-552
> URL: https://issues.apache.org/jira/browse/IO-552
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
>Affects Versions: 2.2, 2.5
> Environment: Windows 7 64bit, JavaVM 1.8 32bit
>Reporter: Jochen Tümmers
>Priority: Critical
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{FilenameUtils.concat("c:/temp", "~abc.txt") returns "~abc.txt/" instead of
> "c:/temp/~abc.txt".}}
> As a result, the file would be created in the user's home directory instead
> of c:/temp.
> (Note: I Had to replace all instances of double backslashes that would
> normally appear in the java code with forward slashes as the editor cannot
> handle backslashes properly.)
> commons io 2.2. and 2.5 behave the same. 2.3 and 2.4 not tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-jexl] henrib merged pull request #65: Bump actions/checkout from 2.3.4 to 2.3.5
henrib merged pull request #65: URL: https://github.com/apache/commons-jexl/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
garydgregory commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957249912 How is this simpler when there is _more_ code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #56: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #56: URL: https://github.com/apache/commons-email/pull/56#issuecomment-958124261 Superseded by #58. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
wodencafe commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-957637714 Hi @garydgregory , if this is true then the JavaDoc should be updated instead to not suggest that a java.lang.NullPointerException is thrown when charset is null for certain method calls. Right now the class is not following the contract as specified by the JavaDoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] coveralls commented on pull request #263: Bump checkstyle from 9.0.1 to 9.1
coveralls commented on pull request #263: URL: https://github.com/apache/commons-collections/pull/263#issuecomment-957743531 [](https://coveralls.io/builds/43951439) Coverage increased (+0.03%) to 90.137% when pulling **be0881242aa9ddf417caa46f2ed02a6e12be6bb8 on dependabot/maven/com.puppycrawl.tools-checkstyle-9.1** into **8a992cd90b4f8d16e4d960c8b59ae645007652c5 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #295: Make FileWriterWithEncoding more precisely match its JavaDoc contract
garydgregory commented on pull request #295: URL: https://github.com/apache/commons-io/pull/295#issuecomment-957253070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] closed pull request #121: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #121: URL: https://github.com/apache/commons-fileupload/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #56: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #56: URL: https://github.com/apache/commons-email/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib merged pull request #63: Bump maven-pmd-plugin from 3.14.0 to 3.15.0
henrib merged pull request #63: URL: https://github.com/apache/commons-jexl/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #192: Bump spotbugs-maven-plugin from 4.3.0 to 4.4.2.2
garydgregory merged pull request #192: URL: https://github.com/apache/commons-csv/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #824: Bump checkstyle from 9.0.1 to 9.1
coveralls commented on pull request #824: URL: https://github.com/apache/commons-lang/pull/824#issuecomment-958138266 [](https://coveralls.io/builds/43962945) Coverage remained the same at 94.948% when pulling **d6e063efa601e0a338cc73063184f8fcad157b7e on dependabot/maven/com.puppycrawl.tools-checkstyle-9.1** into **1b962a4a7ada617b3e443816bc69a07ddfd0066d on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] kinow merged pull request #111: Bump checkstyle from 9.0.1 to 9.1
kinow merged pull request #111: URL: https://github.com/apache/commons-pool/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] kinow merged pull request #193: Bump commons.pmd-impl.version from 6.39.0 to 6.40.0
kinow merged pull request #193: URL: https://github.com/apache/commons-csv/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #97: Bump checkstyle from 8.45.1 to 9.1
coveralls commented on pull request #97: URL: https://github.com/apache/commons-codec/pull/97#issuecomment-956563817 [](https://coveralls.io/builds/43927980) Coverage remained the same at 94.682% when pulling **57b764ffb010059ed280dee8f593a77de437d19d on dependabot/maven/com.puppycrawl.tools-checkstyle-9.1** into **45649c83b47c80a5078c294757db796746f00752 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] kinow merged pull request #97: Bump checkstyle from 8.45.1 to 9.1
kinow merged pull request #97: URL: https://github.com/apache/commons-codec/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #280: Bump checkstyle from 9.0.1 to 9.1
dependabot[bot] opened a new pull request #280: URL: https://github.com/apache/commons-text/pull/280 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.0.1 to 9.1. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>checkstyle's releases. checkstyle-9.1 https://checkstyle.org/releasenotes.html#Release_9.1";>https://checkstyle.org/releasenotes.html#Release_9.1 Commits https://github.com/checkstyle/checkstyle/commit/cfd1c333a866bd32912a1947e86ac0fceaf3ad65";>cfd1c33 [maven-release-plugin] prepare release checkstyle-9.1 https://github.com/checkstyle/checkstyle/commit/1d669a715b6f2afe3d550ba22c7d04510bc89564";>1d669a7 config: update to 9.1-SNAPSHOT https://github.com/checkstyle/checkstyle/commit/1fff33f3dbd12785c2054935557e79adff3a197d";>1fff33f doc: release notes 9.1 https://github.com/checkstyle/checkstyle/commit/8c1f59ac5a47229bf08cec31ecd3d7f6e18cf656";>8c1f59a config: bump reflection version to 0.10.2 https://github.com/checkstyle/checkstyle/commit/aea3174b452ea02adedd7781f036901f071d88c9";>aea3174 dependency: bump archunit-junit5 from 0.21.0 to 0.22.0 https://github.com/checkstyle/checkstyle/commit/0fe36b504fc80c3d3f0ffdb642f113987ef30b63";>0fe36b5 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/9419";>#9419: created example of AST for TokenTypes.DOUBLE_COLON https://github.com/checkstyle/checkstyle/commit/fdea6be4a3da1e0315670df90b20e53b0fef0127";>fdea6be doc: fix broken scm manager install link https://github.com/checkstyle/checkstyle/commit/2e840c627f0fddb4c66e80debeb9398f844d271c";>2e840c6 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10866";>#10866: Fix false positive for switch expressions with operator in Miss... https://github.com/checkstyle/checkstyle/commit/073289a4ad02d468bf814b689e7ec1b04cc669ef";>073289a Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10855";>#10855: fix unused imports check for array references https://github.com/checkstyle/checkstyle/commit/825af33e45611897b464af0718633ab803514514";>825af33 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10872";>#10872: Make violations diff readable Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.0.1...checkstyle-9.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #824: Bump checkstyle from 9.0.1 to 9.1
coveralls commented on pull request #824: URL: https://github.com/apache/commons-lang/pull/824#issuecomment-958138266 [](https://coveralls.io/builds/43962945) Coverage remained the same at 94.948% when pulling **d6e063efa601e0a338cc73063184f8fcad157b7e on dependabot/maven/com.puppycrawl.tools-checkstyle-9.1** into **1b962a4a7ada617b3e443816bc69a07ddfd0066d on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] closed pull request #56: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #56: URL: https://github.com/apache/commons-email/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #279: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #279: URL: https://github.com/apache/commons-text/pull/279 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] commented on pull request #56: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #56: URL: https://github.com/apache/commons-email/pull/56#issuecomment-958124261 Superseded by #58. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request #58: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #58: URL: https://github.com/apache/commons-email/pull/58 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] commented on pull request #70: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #70: URL: https://github.com/apache/commons-rdf/pull/70#issuecomment-958093838 Superseded by #71. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] opened a new pull request #71: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #71: URL: https://github.com/apache/commons-rdf/pull/71 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rdf] dependabot[bot] closed pull request #70: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #70: URL: https://github.com/apache/commons-rdf/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-ognl] dependabot[bot] opened a new pull request #52: Bump actions/checkout from 2.3.5 to 2.4.0
dependabot[bot] opened a new pull request #52: URL: https://github.com/apache/commons-ognl/pull/52 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) See full diff in https://github.com/actions/checkout/compare/v2.3.5...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] opened a new pull request #108: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #108: URL: https://github.com/apache/commons-bcel/pull/108 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] commented on pull request #107: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #107: URL: https://github.com/apache/commons-bcel/pull/107#issuecomment-958080616 Superseded by #108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] dependabot[bot] closed pull request #107: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #107: URL: https://github.com/apache/commons-bcel/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] commented on pull request #121: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] commented on pull request #121: URL: https://github.com/apache/commons-fileupload/pull/121#issuecomment-957996316 Superseded by #125. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] closed pull request #121: Bump actions/checkout from 2.3.4 to 2.3.5
dependabot[bot] closed pull request #121: URL: https://github.com/apache/commons-fileupload/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #125: Bump actions/checkout from 2.3.4 to 2.4.0
dependabot[bot] opened a new pull request #125: URL: https://github.com/apache/commons-fileupload/pull/125 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.4.0. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies Commits https://github.com/actions/checkout/commit/ec3a7ce113134d7a93b817d10a8272cb61118579";>ec3a7ce set insteadOf url for org-id (https://github-redirect.dependabot.com/actions/checkout/issues/621";>#621) https://github.com/actions/checkout/commit/fd47087372161c6f2a7b96d2ef87e944d89023ed";>fd47087 codeql should analyze lib not dist (https://github-redirect.dependabot.com/actions/checkout/issues/620";>#620) https://github.com/actions/checkout/commit/3d677ac575eac4b370e52131024fa99ee754def1";>3d677ac script to generate license info (https://github-redirect.dependabot.com/actions/checkout/issues/614";>#614) https://github.com/actions/checkout/commit/826ba42d6c06e4d78b1b33478af7b54277e60b52";>826ba42 npm audit fix (https://github-redirect.dependabot.com/actions/checkout/issues/612";>#612) https://github.com/actions/checkout/commit/eb8a193c1dbf4bbb2053320cef52bacc1a485839";>eb8a193 update dev dependencies and react to new linting rules (https://github-redirect.dependabot.com/actions/checkout/issues/611";>#611) https://github.com/actions/checkout/commit/c49af7ca1f339b07a5baac8c8bfc49a5248f31d3";>c49af7c Create codeql-analysis.yml (https://github-redirect.dependabot.com/actions/checkout/issues/602";>#602) https://github.com/actions/checkout/commit/1e204e9a9253d643386038d443f96446fa156a97";>1e204e9 update licensed check (https://github-redirect.dependabot.com/actions/checkout/issues/606";>#606) https://github.com/actions/checkout/commit/0299a0d2b67d48224ce047d03c69693b37fe77fe";>0299a0d update dist (https://github-redirect.dependabot.com/actions/checkout/issues/605";>#605) https://github.com/actions/checkout/commit/be0f44845645e415725af198163a96fea9e54334";>be0f448 Bump ws from 5.2.2 to 5.2.3 (https://github-redirect.dependabot.com/actions/checkout/issues/604";>#604) https://github.com/actions/checkout/commit/56c00a7b1f53d3094df328ad4c2cd2b2d385c569";>56c00a7 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/checkout/issues/588";>#588) Additional commits viewable in https://github.com/actions/checkout/compare/v2.3.4...v2.4.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] wodencafe commented on pull request #296: Update FileWriterWithEncoding to extend ProxyWriter
wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989 @garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding itself. We can probably also get rid of the write methods in FileWriterWithEncoding, and just let them delegate to the superclass ProxyWriter. This will reduce the amount of code significantly, but also the JavaDoc for those methods will be inherited from ProxyWriter. Also starting with Java 11, there is the static Writer.nullWriter(), which can be used instead of the anonymous class instance NULL_WRITER (whenever Apache Commons IO upgrades minimum version to Java 11). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #194: Bump checkstyle from 9.0.1 to 9.1
garydgregory merged pull request #194: URL: https://github.com/apache/commons-csv/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] kinow merged pull request #97: Bump checkstyle from 8.45.1 to 9.1
kinow merged pull request #97: URL: https://github.com/apache/commons-codec/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (IMAGING-316) Support the BigTIFF file format
[ https://issues.apache.org/jira/browse/IMAGING-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437523#comment-17437523 ] Michael Osipov commented on IMAGING-316: Thank you, it was quite enlightening! > Support the BigTIFF file format > --- > > Key: IMAGING-316 > URL: https://issues.apache.org/jira/browse/IMAGING-316 > Project: Commons Imaging > Issue Type: New Feature >Affects Versions: 1.x >Reporter: Gary Lucas >Priority: Major > > Traditional TIFF files address file position in bytes using 32-bit integers. > This approach automatically limits the maximum size of a TIFF file to 4 GB. > The BigTIFF specification (formalized in 2011) uses 64-bit integers to > address file positions, and thus supports much larger files. I propose that > a future release of Commons Imaging would benefit from supporting BigTIFF. > The level of effort for this implementation may be large. > In terms of creating JUnit tests to support this effort, note that just > because a file uses the BigTIFF specification doesn't mean that the file has > to be super large. It should be possible to create BigTIFF test files that > are only a few kilobytes. Thus supporting BigTIFF does not necessarily mean > that massive files will need to be included in the Commons Imaging > distribution. > Finally, it is reasonable to ask if anyone would actually need images that > were so large that they couldn't fit within 4 GB. The short answer is that > some folks in the Geographic Information Systems (GIS) community do work with > images (or data sets) that large and, also, that some systems produce images > in BigTIFF format even when ordinary TIFF would suffice. > > P.S. It might be work investigating whether the existing Imaging library > actually supports the full 32-bit address space of a conventional TIFF. > Regrettably, Java doesn't support unsigned integer types. And it is > possible that a file address with the high bit set might be incorrectly > interpreted as a negative number. So I will be taking a look at the code to > make sure all file addresses are properly masked when they are handed over to > Java. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-collections] coveralls commented on pull request #263: Bump checkstyle from 9.0.1 to 9.1
coveralls commented on pull request #263: URL: https://github.com/apache/commons-collections/pull/263#issuecomment-957743531 [](https://coveralls.io/builds/43951439) Coverage increased (+0.03%) to 90.137% when pulling **be0881242aa9ddf417caa46f2ed02a6e12be6bb8 on dependabot/maven/com.puppycrawl.tools-checkstyle-9.1** into **8a992cd90b4f8d16e4d960c8b59ae645007652c5 on master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
