[GitHub] [commons-io] garydgregory merged pull request #328: Bump junit-pioneer from 1.5.0 to 1.6.1
garydgregory merged pull request #328: URL: https://github.com/apache/commons-io/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #250: Bump zstd-jni from 1.5.2-1 to 1.5.2-2
dependabot[bot] opened a new pull request #250: URL: https://github.com/apache/commons-compress/pull/250 Bumps [zstd-jni](https://github.com/luben/zstd-jni) from 1.5.2-1 to 1.5.2-2. Commits https://github.com/luben/zstd-jni/commit/3d5ab915167f2dfe244d2d2192b66a9feac7c543";>3d5ab91 Fix the symbols export on the cross-compiled libraries also https://github.com/luben/zstd-jni/commit/8a4993f57119e2b682d1f0b8db263027983208c6";>8a4993f Use different approach for MacOS to not export all symbols https://github.com/luben/zstd-jni/commit/15352a3941e8bec2dd1f374768478c02eaf69d6f";>15352a3 Don't pass version-script to clang linker, it's not supported https://github.com/luben/zstd-jni/commit/9916cbd611cd882b5d4958d4acf0518c01363487";>9916cbd Don't export the zstd symbols, just our own ones https://github.com/luben/zstd-jni/commit/277cb2779e2e1922d6de0cf4e1e7519d2647acef";>277cb27 fix spelling https://github.com/luben/zstd-jni/commit/ff3a141d78abc71741734b0d0524bf47096b29f8";>ff3a141 Fallback to scp if rsync in not installed on the build machines https://github.com/luben/zstd-jni/commit/ba99eec9ac9a5c3eb16200ae67c235a91b16b570";>ba99eec Up the version https://github.com/luben/zstd-jni/commit/4c4d9cd382b6e515a7d0d6cd37c1ebb087f5ab73";>4c4d9cd Support LoongArch64 https://github.com/luben/zstd-jni/commit/97550e35610cd36e2ad510e20e503c0f997c1a3a";>97550e3 Remove frameHeaderSize(Min|Max) See full diff in https://github.com/luben/zstd-jni/compare/v1.5.2-1...v1.5.2-2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #172: Bump maven-pmd-plugin from 3.15.0 to 3.16.0
dependabot[bot] opened a new pull request #172: URL: https://github.com/apache/commons-dbcp/pull/172 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.15.0 to 3.16.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases";>maven-pmd-plugin's releases. 3.16.0 🐛 Bug Fixes https://issues.apache.org/jira/browse/MPMD-325";>[MPMD-325] Could not find class due to IncompatibleClassChangeError warning https://issues.apache.org/jira/browse/MPMD-324";>[MPMD-324] Ruleset URLs have hyphen replaced with forwardslash https://issues.apache.org/jira/browse/MPMD-323";>[MPMD-323] ResourceManager should use project base dir instead of pom location 🔧 Build https://issues.apache.org/jira/browse/MPMD-328";>[MPMD-328] Shared GitHub Actions 🚀 New features and improvements https://issues.apache.org/jira/browse/MPMD-327";>[MPMD-327] Upgrade to PMD 6.42.0 📦 Dependency updates https://issues.apache.org/jira/browse/MPMD-326";>[MPMD-326] Set Maven 3.1.1 as minimum version Commits https://github.com/apache/maven-pmd-plugin/commit/b8a794e37e4cb3bb986ce044f3ef8df0dd392ed1";>b8a794e [maven-release-plugin] prepare release maven-pmd-plugin-3.16.0 https://github.com/apache/maven-pmd-plugin/commit/6fc39ec2428a9fd68319da39f89d2191ac3ad25b";>6fc39ec [MPMD-323] ResourceManager should use project base dir instead of pom https://github.com/apache/maven-pmd-plugin/commit/4eae72c6c6f394c0c65fc4994eead9d06a6544f2";>4eae72c [MPMD-324] Ruleset URLs have hyphen replaced with forwardslash https://github.com/apache/maven-pmd-plugin/commit/64e35f73c27107c192b33b856f549fa66953b305";>64e35f7 Make maven core provided scope https://github.com/apache/maven-pmd-plugin/commit/1dd8d0007fcf5d48571b9483bd3865a57d8e5383";>1dd8d00 [MPMD-327] Upgrade to PMD 6.42.0 https://github.com/apache/maven-pmd-plugin/commit/fae45251df926bb2e91ac14914b374c5f0ed28ed";>fae4525 [MPMD-327] Upgrade to PMD 6.41.0 https://github.com/apache/maven-pmd-plugin/commit/80e8aabe537063ddb64887c4dc18ca6c91be19e8";>80e8aab (doc) Update README.md https://github.com/apache/maven-pmd-plugin/commit/3fffd9cc7c0bea9ddd8489c9a7b4fee264d2d2c0";>3fffd9c [MPMD-328] Shared Github Actions (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/48";>#48) https://github.com/apache/maven-pmd-plugin/commit/2175d5e3936d0f4718da6f890a442cfc60cd617e";>2175d5e [MPMD-327] Upgrade to PMD 6.40.0 https://github.com/apache/maven-pmd-plugin/commit/b8ac1fbc41b2b7e69bb6d8c0a336119e8fdd2d26";>b8ac1fb [MPMD-327] Upgrade to PMD 6.39.0 Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.15.0...maven-pmd-plugin-3.16.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this servi
[GitHub] [commons-compress] dependabot[bot] opened a new pull request #249: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] opened a new pull request #249: URL: https://github.com/apache/commons-compress/pull/249 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.3.2. Commits https://github.com/apache/maven-javadoc-plugin/commit/50a41f78278c1d5957cb03e89223fcbc640f1b68";>50a41f7 [maven-release-plugin] prepare release maven-javadoc-plugin-3.3.2 https://github.com/apache/maven-javadoc-plugin/commit/5af4519ce17308f35d4cfb553d0af8168cac35f4";>5af4519 [MJAVADOC-705] Upgrade Maven Reporting API to 3.1.0 https://github.com/apache/maven-javadoc-plugin/commit/ee4132f9d0f6f412784e108305524cf3b3a3009a";>ee4132f [MJAVADOC-704] Javadoc plugin does not respect jdkToolchain https://github.com/apache/maven-javadoc-plugin/commit/651b98e6951ee2e3d8fefa1bcb3629f1dae763be";>651b98e Bump doxia-site-renderer from 1.10 to 1.11.1 https://github.com/apache/maven-javadoc-plugin/commit/db20fddd4eb443711948645613c03a4ccc516dab";>db20fdd Bump plexus-archiver from 4.2.5 to 4.2.6 https://github.com/apache/maven-javadoc-plugin/commit/b51c5d801c1e329b1e59e7b66142c8fd9c0ba6af";>b51c5d8 [MJAVADOC-694] Avoid empty warn message from getResolvePathResult https://github.com/apache/maven-javadoc-plugin/commit/6b1515ed43826417cf4cbad88be1107e92cba3f5";>6b1515e Bump httpcore from 4.4.14 to 4.4.15 https://github.com/apache/maven-javadoc-plugin/commit/a4aa7dcdc22eda19a08cc3c3e231631d422f1725";>a4aa7dc (doc) fix javadoc issues https://github.com/apache/maven-javadoc-plugin/commit/3309cc2ea03237576f3d702cffe1d628c3ea0d12";>3309cc2 Bump maven-project-info-reports-plugin to 3.1.2 https://github.com/apache/maven-javadoc-plugin/commit/51a2c3f803a0124c2591e46925210da705042f19";>51a2c3f Bump maven-javadoc-plugin to 3.3.1 Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.1...maven-javadoc-plugin-3.3.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (GEOMETRY-145) GSoC 2022
Matt Juntunen created GEOMETRY-145:
--
Summary: GSoC 2022
Key: GEOMETRY-145
URL: https://issues.apache.org/jira/browse/GEOMETRY-145
Project: Apache Commons Geometry
Issue Type: Wish
Reporter: Matt Juntunen
Placeholder for tasks that could be undertaken in this year's
[GSoC|https://summerofcode.withgoogle.com/].
Ideas:
- Examine and potentially redesign the API and algorithms in the
{{commons-geometry-enclosing}} module. The goal here is to make consistent use
of the newer geometry API and ensure that the algorithms are sound.
- Design and implement a parser/writer for the [PLY file
format|http://paulbourke.net/dataformats/ply/] in the
{{commons-geometry-io-euclidean}} module.
- Design an API for advanced 3D mesh data structures (e.g. halfedge meshes) and
operations (e.g. surface subdivision, smoothing, etc). This may end up being
another module, e.g. {{commons-geometry-mesh}}.
- Create a series of user guides and/or tutorials demonstrating best-practice
use of the library.
- other ideas ... ?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-io] dependabot[bot] opened a new pull request #328: Bump junit-pioneer from 1.5.0 to 1.6.1
dependabot[bot] opened a new pull request #328: URL: https://github.com/apache/commons-io/pull/328 Bumps [junit-pioneer](https://github.com/junit-pioneer/junit-pioneer) from 1.5.0 to 1.6.1. Release notes Sourced from https://github.com/junit-pioneer/junit-pioneer/releases";>junit-pioneer's releases. v1.6.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 1.6.1 2022-02-21 - https://github.com/junit-pioneer/junit-pioneer/compare/v1.6.0...v1.6.1";>3 commit(s) by Daniel Kraus, Nicolai Parlog Fix module descriptor [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/597";>#597)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/597";>junit-pioneer/junit-pioneer#597) Missing opens directive in module descriptor [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/539";>#539)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/539";>junit-pioneer/junit-pioneer#539) Investigate parameter targeting of CartesianProductTest arguments source annotations [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/415";>#415)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/415";>junit-pioneer/junit-pioneer#415) v1.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 1.6.0 2022-02-19 - https://github.com/junit-pioneer/junit-pioneer/compare/v1.5.0...v1.6.0";>19 commit(s) by Daniel Kraus, Gabriel Diegel, Marcono1234, Matthias Bünger, Mihály Verhás, Nicolai Parlog, Scott Leberknight, Simon Schrottner Document handling of optional dependencies [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/593";>#593)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/593";>junit-pioneer/junit-pioneer#593) Adding Code of Conduct (https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/590";>#590) [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/592";>#592)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/592";>junit-pioneer/junit-pioneer#592) Add a Code of Conduct [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/590";>#590)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/590";>junit-pioneer/junit-pioneer#590) Update Javadoc and visibility of classes [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/580";>#580)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/580";>junit-pioneer/junit-pioneer#580) Review all Javadoc of the project [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/576";>#576)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/576";>junit-pioneer/junit-pioneer#576) Use current JUnit Jupiter version in build matrix [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/572";>#572)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/572";>junit-pioneer/junit-pioneer#572) Improve exception message when modifying environment variables fails [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/571";>#571)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/571";>junit-pioneer/junit-pioneer#571) NoSuchMethodError: org.junit.platform.commons.util.AnnotationUtils.findAnnotation(Ljava/lang/Class;Ljava/lang/Class;Z)Ljava/util/Optional; [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/569";>#569)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/569";>junit-pioneer/junit-pioneer#569) Fix broken links in param package-info.java [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/568";>#568)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/568";>junit-pioneer/junit-pioneer#568) Improve Javadoc creation [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/566";>#566)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/566";>junit-pioneer/junit-pioneer#566) Update to Log4J2 2.17.0 (https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/562";>#562 / https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/563";>#563) [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/563";>#563)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/pull/563";>junit-pioneer/junit-pioneer#563) Update to Log4J 2.17.0+ due to CVE [(https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/562";>#562)](https://github-redirect.dependabot.com/junit-pioneer/junit-pioneer/issues/562";>junit-pioneer/junit-pioneer#562) Cleanup jupit
[jira] [Work logged] (COLLECTIONS-803) CaseInsensitiveMap prevent duplicate key conversion on put
[
https://issues.apache.org/jira/browse/COLLECTIONS-803?focusedWorklogId=732671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732671
]
ASF GitHub Bot logged work on COLLECTIONS-803:
--
Author: ASF GitHub Bot
Created on: 24/Feb/22 20:52
Start Date: 24/Feb/22 20:52
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050253135
> Hello @kinow, I saw that you are able to merge in this repository in
another recent PR. Would you also like to review my suggested changes in this
PR, please?
Sorry, busy with other pull requests & issues :disappointed_relieved: :bow:
code looks good from a brief look, but would need more time to really
understand the change and confirm it's a good improvement :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732671)
Time Spent: 1.5h (was: 1h 20m)
> CaseInsensitiveMap prevent duplicate key conversion on put
> --
>
> Key: COLLECTIONS-803
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-803
> Project: Commons Collections
> Issue Type: Improvement
> Components: Map
>Affects Versions: 4.4
>Reporter: Simulant
>Priority: Minor
> Labels: performance
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When adding a new item into a {{CaseInsensitiveMap}} the {{convertKey(key)}}
> method is called twice, once in the {{put(key, value)}} method and second in
> the {{createEntry(next, hashCode, key, value)}} method. The result could be
> re-used resulting in a better performance.
> Depending on the {{toString()}} implementation of the key and the resulting
> length of the key before the lower case conversion the operation can get
> expensive and should not be called twice, as the {{CaseInsensitiveMap}}
> overwrites the {{convertKey(key)}} method and makes it more expensive and
> depending on the input unlike in the implementation of the
> {{AbstractHashedMap}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] kinow commented on pull request #276: COLLECTIONS-803: prevent duplicate call to convertKey on put for CaseInsensitiveMap
kinow commented on pull request #276: URL: https://github.com/apache/commons-collections/pull/276#issuecomment-1050253135 > Hello @kinow, I saw that you are able to merge in this repository in another recent PR. Would you also like to review my suggested changes in this PR, please? Sorry, busy with other pull requests & issues :disappointed_relieved: :bow: code looks good from a brief look, but would need more time to really understand the change and confirm it's a good improvement :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-803) CaseInsensitiveMap prevent duplicate key conversion on put
[
https://issues.apache.org/jira/browse/COLLECTIONS-803?focusedWorklogId=732639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732639
]
ASF GitHub Bot logged work on COLLECTIONS-803:
--
Author: ASF GitHub Bot
Created on: 24/Feb/22 19:55
Start Date: 24/Feb/22 19:55
Worklog Time Spent: 10m
Work Description: Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050209446
Hello @kinow,
I saw that you are able to merge in this repository in another recent PR.
Would you also like to review my suggested changes in this PR, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732639)
Time Spent: 1h 20m (was: 1h 10m)
> CaseInsensitiveMap prevent duplicate key conversion on put
> --
>
> Key: COLLECTIONS-803
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-803
> Project: Commons Collections
> Issue Type: Improvement
> Components: Map
>Affects Versions: 4.4
>Reporter: Simulant
>Priority: Minor
> Labels: performance
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When adding a new item into a {{CaseInsensitiveMap}} the {{convertKey(key)}}
> method is called twice, once in the {{put(key, value)}} method and second in
> the {{createEntry(next, hashCode, key, value)}} method. The result could be
> re-used resulting in a better performance.
> Depending on the {{toString()}} implementation of the key and the resulting
> length of the key before the lower case conversion the operation can get
> expensive and should not be called twice, as the {{CaseInsensitiveMap}}
> overwrites the {{convertKey(key)}} method and makes it more expensive and
> depending on the input unlike in the implementation of the
> {{AbstractHashedMap}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] Simulant87 commented on pull request #276: COLLECTIONS-803: prevent duplicate call to convertKey on put for CaseInsensitiveMap
Simulant87 commented on pull request #276: URL: https://github.com/apache/commons-collections/pull/276#issuecomment-1050209446 Hello @kinow, I saw that you are able to merge in this repository in another recent PR. Would you also like to review my suggested changes in this PR, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-803) CaseInsensitiveMap prevent duplicate key conversion on put
[
https://issues.apache.org/jira/browse/COLLECTIONS-803?focusedWorklogId=732633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732633
]
ASF GitHub Bot logged work on COLLECTIONS-803:
--
Author: ASF GitHub Bot
Created on: 24/Feb/22 19:51
Start Date: 24/Feb/22 19:51
Worklog Time Spent: 10m
Work Description: Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050206636
@freya022 thank you for your suggestion. This sounds like another high
performance improvement.
However it also sounds like the behaviour might slightly change in some edge
cases. Something I expect the maintainers want to avoid and could cause a
longer discussion. Therefore I would like to keep your suggestion separated
from my changes. As my implementation does not cahnge the behaviour of the key
conversion, it should be simpler to review and approve. I encourage your to
create a ticket in
[Jira](https://issues.apache.org/jira/projects/COLLECTIONS/issues) and create a
separate pull request for that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732633)
Time Spent: 1h 10m (was: 1h)
> CaseInsensitiveMap prevent duplicate key conversion on put
> --
>
> Key: COLLECTIONS-803
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-803
> Project: Commons Collections
> Issue Type: Improvement
> Components: Map
>Affects Versions: 4.4
>Reporter: Simulant
>Priority: Minor
> Labels: performance
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When adding a new item into a {{CaseInsensitiveMap}} the {{convertKey(key)}}
> method is called twice, once in the {{put(key, value)}} method and second in
> the {{createEntry(next, hashCode, key, value)}} method. The result could be
> re-used resulting in a better performance.
> Depending on the {{toString()}} implementation of the key and the resulting
> length of the key before the lower case conversion the operation can get
> expensive and should not be called twice, as the {{CaseInsensitiveMap}}
> overwrites the {{convertKey(key)}} method and makes it more expensive and
> depending on the input unlike in the implementation of the
> {{AbstractHashedMap}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] Simulant87 commented on pull request #276: COLLECTIONS-803: prevent duplicate call to convertKey on put for CaseInsensitiveMap
Simulant87 commented on pull request #276: URL: https://github.com/apache/commons-collections/pull/276#issuecomment-1050206636 @freya022 thank you for your suggestion. This sounds like another high performance improvement. However it also sounds like the behaviour might slightly change in some edge cases. Something I expect the maintainers want to avoid and could cause a longer discussion. Therefore I would like to keep your suggestion separated from my changes. As my implementation does not cahnge the behaviour of the key conversion, it should be simpler to review and approve. I encourage your to create a ticket in [Jira](https://issues.apache.org/jira/projects/COLLECTIONS/issues) and create a separate pull request for that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-803) CaseInsensitiveMap prevent duplicate key conversion on put
[
https://issues.apache.org/jira/browse/COLLECTIONS-803?focusedWorklogId=732552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732552
]
ASF GitHub Bot logged work on COLLECTIONS-803:
--
Author: ASF GitHub Bot
Created on: 24/Feb/22 18:07
Start Date: 24/Feb/22 18:07
Worklog Time Spent: 10m
Work Description: freya022 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050121979
I may also suggest changing the `convertKey` method to use
`key.toString().toLowerCase(Locale.ROOT)` to convert the non-null key, instead
of the char loop.
Benefits include better performance (measured a 2 times increase on my pc),
and this is more fitted for the use case, as per the [Character#toLowerCase
documentation](https://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#toLowerCase(char)):
```
In general, String.toLowerCase() should be used to map characters to
lowercase.
String case mapping methods have several benefits over Character case
mapping methods.
String case mapping methods can perform locale-sensitive mappings,
context-sensitive mappings, and 1:M character mappings, whereas the Character
case mapping methods cannot
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 732552)
Time Spent: 1h (was: 50m)
> CaseInsensitiveMap prevent duplicate key conversion on put
> --
>
> Key: COLLECTIONS-803
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-803
> Project: Commons Collections
> Issue Type: Improvement
> Components: Map
>Affects Versions: 4.4
>Reporter: Simulant
>Priority: Minor
> Labels: performance
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When adding a new item into a {{CaseInsensitiveMap}} the {{convertKey(key)}}
> method is called twice, once in the {{put(key, value)}} method and second in
> the {{createEntry(next, hashCode, key, value)}} method. The result could be
> re-used resulting in a better performance.
> Depending on the {{toString()}} implementation of the key and the resulting
> length of the key before the lower case conversion the operation can get
> expensive and should not be called twice, as the {{CaseInsensitiveMap}}
> overwrites the {{convertKey(key)}} method and makes it more expensive and
> depending on the input unlike in the implementation of the
> {{AbstractHashedMap}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [commons-collections] freya022 commented on pull request #276: COLLECTIONS-803: prevent duplicate call to convertKey on put for CaseInsensitiveMap
freya022 commented on pull request #276: URL: https://github.com/apache/commons-collections/pull/276#issuecomment-1050121979 I may also suggest changing the `convertKey` method to use `key.toString().toLowerCase(Locale.ROOT)` to convert the non-null key, instead of the char loop. Benefits include better performance (measured a 2 times increase on my pc), and this is more fitted for the use case, as per the [Character#toLowerCase documentation](https://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#toLowerCase(char)): ``` In general, String.toLowerCase() should be used to map characters to lowercase. String case mapping methods have several benefits over Character case mapping methods. String case mapping methods can perform locale-sensitive mappings, context-sensitive mappings, and 1:M character mappings, whereas the Character case mapping methods cannot ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1563) Implementation of Adaptive Probability Generation Strategy for Genetic Algorithm
[ https://issues.apache.org/jira/browse/MATH-1563?focusedWorklogId=732357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732357 ] ASF GitHub Bot logged work on MATH-1563: Author: ASF GitHub Bot Created on: 24/Feb/22 14:42 Start Date: 24/Feb/22 14:42 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #205: URL: https://github.com/apache/commons-math/pull/205#issuecomment-1030758298 [](https://coveralls.io/builds/46849198) Coverage decreased (-0.2%) to 90.125% when pulling **18b5558b7dec8d5edb75486a619d31ec87c1e823 on avijit-basak:feature/MATH-1563-RB-1** into **0d6c6e60f4f840f0798d5d98579c3b9c9ffac830 on apache:feature__MATH-1563__genetic_algorithm**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 732357) Time Spent: 1h 10m (was: 1h) > Implementation of Adaptive Probability Generation Strategy for Genetic > Algorithm > > > Key: MATH-1563 > URL: https://issues.apache.org/jira/browse/MATH-1563 > Project: Commons Math > Issue Type: Improvement >Reporter: AVIJIT BASAK >Priority: Major > Attachments: GA-Model.uxf, GA-Model.uxf, GA-OperatorModel.uxf, > GA-OperatorModel.uxf, GA-Overview.uxf, GA-Overview.uxf, chromosome > hierarchy.png > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In Genetic Algorithm probability of crossover and mutation operation can be > generated in an adaptive manner. Some experiment was done related to this and > published in this article > "https://www.ijcaonline.org/archives/volume175/number10/basak-2020-ijca-920572.pdf";. > Currently Apache's API works on constant probability strategy. I would like > to propose incorporation of rank based adaptive probability generation > strategy as described in the mentioned article. This will improve the > performance and robustness of the algorithm and would make this more suitable > for use in higher dimensional problems like machine learning or deep learning. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [commons-math] coveralls edited a comment on pull request #205: MATH-1563: Minor bug fixes.
coveralls edited a comment on pull request #205: URL: https://github.com/apache/commons-math/pull/205#issuecomment-1030758298 [](https://coveralls.io/builds/46849198) Coverage decreased (-0.2%) to 90.125% when pulling **18b5558b7dec8d5edb75486a619d31ec87c1e823 on avijit-basak:feature/MATH-1563-RB-1** into **0d6c6e60f4f840f0798d5d98579c3b9c9ffac830 on apache:feature__MATH-1563__genetic_algorithm**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] jfclere commented on a change in pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION
jfclere commented on a change in pull request #32:
URL: https://github.com/apache/commons-daemon/pull/32#discussion_r813835930
##
File path: src/native/windows/src/handles.c
##
@@ -496,13 +496,15 @@ apxCloseHandle(APXHANDLE hObject)
if (IS_INVALID_HANDLE(hObject) || hObject->dwType ==
APXHANDLE_TYPE_INVALID)
return FALSE;
-/* Call the user callback first */
-(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
-/* Now go through the callback chain */
-TAILQ_FOREACH(lpCall, &hObject->lCallbacks, queue) {
+if (!TAILQ_EMPTY(&hObject->lCallbacks)) {
+/* Call the user callback first */
+(*hObject->fnCallback)(hObject, WM_CLOSE, 0, 0);
Review comment:
Only adding the if is probably OK. Something like:
if (lpCall->fnCallback)
(*lpCall->fnCallback)(hObject, WM_CLOSE, 0, 0);
There are a bunch of place where we test the callback before calling it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #857: Add method defaultIfEmpty with lazy default string computation
garydgregory commented on pull request #857: URL: https://github.com/apache/commons-lang/pull/857#issuecomment-1049731577 > Looks like a useful extension. I think this would be acceptable trivial as a submission, but just in case do you know if you are covered by individual or corporate contributors Agreement? This PR duplicates existing functionality. See my other comments in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #857: Add method defaultIfEmpty with lazy default string computation
garydgregory commented on a change in pull request #857:
URL: https://github.com/apache/commons-lang/pull/857#discussion_r813763342
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -1523,6 +1523,26 @@ public static int countMatches(final CharSequence str,
final CharSequence sub) {
return isBlank(str) ? defaultStr : str;
}
+/**
+ * Returns either the passed in CharSequence, or if the CharSequence is
+ * whitespace, empty ("") or {@code null}, the value produced by {@code
supplier}.
+ *
+ * Consider to utilize this method instead of {@link
#defaultIfBlank(CharSequence, CharSequence)}
+ * in case of lazy computation of default string make sense
+ *
+ * Whitespace is defined by {@link Character#isWhitespace(char)}.
+ *
+ * @param source - CharSequence to check, may be null
+ * @param supplier represents the supplier, that should return instance
+ * of type {@literal T} in case source string is empty
+ * @param represents the specific kind of CharSequence
+ * @return the passed source instance of CharSequence in case it is not
blank,
+ * otherwise the value returned by {@link Supplier}
+ */
+public static T defaultIfEmpty(final T source,
final Supplier supplier) {
+return isBlank(source) ? supplier.get() : source;
Review comment:
This duplicates:
- `StringUtils.getIfBlank(T, Supplier)`
- `StringUtils.getIfEmpty(T, Supplier)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #857: Add method defaultIfEmpty with lazy default string computation
garydgregory commented on a change in pull request #857:
URL: https://github.com/apache/commons-lang/pull/857#discussion_r813760188
##
File path: src/main/java/org/apache/commons/lang3/ObjectUtils.java
##
@@ -1152,6 +1152,20 @@ public static boolean isNotEmpty(final Object object) {
return result;
}
+/**
+ * Get passed {@code object} in case it is not null, otherwise return the
value produced by supplier
+ *
+ * Consider to utilize this method if lazy computation of default value
makes sense in your case
+ *
+ * @param object to get if not null else to apply passed {@link Supplier}
+ * @param supplier {@link Supplier} to utilize in case provided {@code
object} is null
+ * @param the type of the object
+ * @return passed {@code object} in case it is not null, otherwise return
the value produced by supplier
+ */
+public static T defaultIfNull(T object, Supplier supplier) {
+return object == null ? supplier.get() : object;
Review comment:
This duplicates `ObjectUtils.getIfNull(T, Supplier)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
