[jira] [Commented] (JEXL-366) Fail to evaluate string and number comparison
[
https://issues.apache.org/jira/browse/JEXL-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529782#comment-17529782
]
Hussachai Puripunpinyo commented on JEXL-366:
-
Got it :) . That's the reason why I use toBigDecimal which has the following
logic that uses a configured math context.
{code:java}
return roundBigDecimal(new BigDecimal(string, getMathContext()));{code}
I'd say the logic I want to add is kinda equivalent to the existing one.
For example: '1.0' == 1b
This expression will be evaluated by the first check because the right operand
is BigDecimal
{code:java}
if (left instanceof BigDecimal || right instanceof BigDecimal) {
final BigDecimal l = toBigDecimal(left);
final BigDecimal r = toBigDecimal(right);
return l.compareTo(r);
} {code}
As you can see, the right operand satisfies to the right check which means this
'1.0' == 1b will be computed the same way as the logic I introduced.
The difference in my case is that the int will be widen to BigDecimal and the
following code will be used to convert the numerable to BigDecimal.
It actually doesn't really do anything because numerable won't have any decimal
value. I think that's the reason why the code for Character doesn't even care
to apply the configured math context.
{code:java}
if (val instanceof Number) {
return roundBigDecimal(new BigDecimal(val.toString(), getMathContext()));
}
or
if (val instanceof Character) {
final int i = ((Character) val);
return new BigDecimal(i);
}{code}
Anyway, the caveat here is that the string "1.1" can be equal to 1 when the
math context is configured like
{code:java}
new MathContext(1, RoundingMode.FLOOR) {code}
But, this will fail the existing code as well.
The existing logic will say that this is true '1.1' == 1b if the math
context is configured as above.
So, I'd say the logic I want to add pretty conforms to the existing behavior
except that it won't fail when you do '1.0' == 1.
> Fail to evaluate string and number comparison
> -
>
> Key: JEXL-366
> URL: https://issues.apache.org/jira/browse/JEXL-366
> Project: Commons JEXL
> Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Hussachai Puripunpinyo
>Priority: Major
>
> The comparison logic doesn't cover the case when one operand is a string and
> another operand is a numerable type (int, short, long,..).
> The expected result for '1.0' == 1 should be true but it fails because the
> string comparison check is after the numerable type check. JEXL tries to
> parse '1.0' using toLong function and it fails with this error message `For
> input string: "1.0"`
> Moving a string comparison up before other number type checks will not cover
> some corner cases such as
> '1.00' == 1.0 // String comparison will yield false but it obviously doesn't
> make sense.
> The proposed change is to add the following code to handle the corner case
> when one operand is string and another operand is numerable. To cover this
> corner case, we can apply toBigDecimal to both *lhs* and *rhs* since it
> should cover any arbitrary number in a string form, and it handles other
> number types well.
> {code:java}
> if (isNumberable(left) || isNumberable(right)) {
> if (left instanceof String || right instanceof String) {
> final BigDecimal l = toBigDecimal(left);
> final BigDecimal r = toBigDecimal(right);
> return l.compareTo(r);
> } else {
> // this code block remains the same
> }
> return 0;
> } {code}
> JEXL syntax is very similar to ECMA script except a few small set that are
> not the same. So, I think following the ECMA spec for this comparison check
> makes sense.
> The following code is JavaScript and it can be used in the JEXL test to make
> sure that the behavior of comparison are the same.
> Note that '1.0' == 1 yields true
> {code:java}
> function assert(condition, source) {
> if (!condition) {
> throw `Assertion failed for ${source}`;
> }
> }
> // Basic compare
> let exprs = [
> "1 == 1", true,
> "1 != 1", false,
> "1 != 2", true,
> "1 > 2", false,
> "1 >= 2", false,
> "1 < 2", true,
> "1 <= 2", true,
> // Int <-> Float Coercion
> "1.0 == 1", true,
> "1 == 1.0", true,
> "1.1 != 1", true,
> "1.1 < 2", true,
> // numbers and strings
> "'1' == 1", true,
> "'' == 0", true, // empty string is coerced to zero (ECMA compliance)
> "1.0 >= '1'", true,
> "1.0 > '1'", false
> ];for (e = 0; e < exprs.length; e += 2) {
> let stext = exprs[e];
> let expected = exprs[e + 1];
> assert(eval(stext) == expected, stext);
>
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-compress] dependabot[bot] opened a new pull request, #288: Bump maven-javadoc-plugin from 3.3.2 to 3.4.0
dependabot[bot] opened a new pull request, #288: URL: https://github.com/apache/commons-compress/pull/288 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.2 to 3.4.0. Commits https://github.com/apache/maven-javadoc-plugin/commit/40cc602f84dbb0689020b55b24970cdd7147722c;>40cc602 [maven-release-plugin] prepare release maven-javadoc-plugin-3.4.0 https://github.com/apache/maven-javadoc-plugin/commit/0c6b32fb5ec9c31b4e38d9f32616ff51102623da;>0c6b32f [MJAVADOC-714] Upgrade to Maven 3.2.5 https://github.com/apache/maven-javadoc-plugin/commit/506cb74e6abc4b108121b0c586a15b75dd5ccc39;>506cb74 [MJAVADOC-696] Invalid anchors in Javadoc and plugin mojo https://github.com/apache/maven-javadoc-plugin/commit/47d03d3a08cc58a93fa384f4661d79c350842b82;>47d03d3 [MJAVADOC-712] Remove remains of org.codehaus.doxia.sink.Sink https://github.com/apache/maven-javadoc-plugin/commit/5fae3b656e131fa233982eebf0944b5253fc845e;>5fae3b6 [MJAVADOC-711] Upgrade plugins in ITs https://github.com/apache/maven-javadoc-plugin/commit/03ca84372ab689c91dd0d5b63cc2ee12ee3c466b;>03ca843 Bump maven-archiver from 3.5.1 to 3.5.2 https://github.com/apache/maven-javadoc-plugin/commit/5dcfa6e70795d0b5cf5414a848e7e0aeb5541413;>5dcfa6e Bump plexus-archiver from 4.2.6 to 4.2.7 https://github.com/apache/maven-javadoc-plugin/commit/ca00601609903a0e88a067b2aa3d49e88191937a;>ca00601 Bump junit in /src/it/projects/MJAVADOC-498_modulepath https://github.com/apache/maven-javadoc-plugin/commit/2583554135dc04db58a435ebcbd2cd19f0d2563a;>2583554 Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2 https://github.com/apache/maven-javadoc-plugin/commit/9dd7bddb3db6d0d230092d7fbbd4188a98a3a75e;>9dd7bdd use shared gh action/release-drafter (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/128;>#128) Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.2...maven-javadoc-plugin-3.4.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request, #188: Bump mockito-core from 4.4.0 to 4.5.1
dependabot[bot] opened a new pull request, #188: URL: https://github.com/apache/commons-dbcp/pull/188 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.4.0 to 4.5.1. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1;>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624;>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624;>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2622;>#2622)](https://github-redirect.dependabot.com/mockito/mockito/pull/2622;>mockito/mockito#2622) Missing net.bytebuddy.utility.GraalImageCode exception If you encounter any issues with missing ByteBuddy classes, make sure you are using ByteBuddy 1.12 or higher. v4.5.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.5.0 2022-04-19 - https://github.com/mockito/mockito/compare/v4.4.0...v4.5.0;>15 commit(s) by Andrei Silviu Dragnea, Rafael Winterhalter, Rick Ossendrijver, dependabot[bot] Bump versions.errorprone from 2.13.0 to 2.13.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2621;>#2621)](https://github-redirect.dependabot.com/mockito/mockito/pull/2621;>mockito/mockito#2621) Bump versions.errorprone from 2.12.1 to 2.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2619;>#2619)](https://github-redirect.dependabot.com/mockito/mockito/pull/2619;>mockito/mockito#2619) Groovy inline [(https://github-redirect.dependabot.com/mockito/mockito/issues/2618;>#2618)](https://github-redirect.dependabot.com/mockito/mockito/pull/2618;>mockito/mockito#2618) Bump actions/setup-java from 2 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2615;>#2615)](https://github-redirect.dependabot.com/mockito/mockito/pull/2615;>mockito/mockito#2615) Bump versions.bytebuddy from 1.12.8 to 1.12.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2614;>#2614)](https://github-redirect.dependabot.com/mockito/mockito/pull/2614;>mockito/mockito#2614) Support subclass mocks on Graal VM. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2613;>#2613)](https://github-redirect.dependabot.com/mockito/mockito/pull/2613;>mockito/mockito#2613) Bump com.diffplug.spotless from 6.4.1 to 6.4.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2611;>#2611)](https://github-redirect.dependabot.com/mockito/mockito/pull/2611;>mockito/mockito#2611) Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt [(https://github-redirect.dependabot.com/mockito/mockito/issues/2609;>#2609)](https://github-redirect.dependabot.com/mockito/mockito/pull/2609;>mockito/mockito#2609) Bump versions.errorprone from 2.10.0 to 2.12.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2608;>#2608)](https://github-redirect.dependabot.com/mockito/mockito/pull/2608;>mockito/mockito#2608) Bump kotlinVersion from 1.6.10 to 1.6.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2607;>#2607)](https://github-redirect.dependabot.com/mockito/mockito/pull/2607;>mockito/mockito#2607) Bump com.diffplug.spotless from 6.4.0 to 6.4.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2606;>#2606)](https://github-redirect.dependabot.com/mockito/mockito/pull/2606;>mockito/mockito#2606) Bump com.diffplug.spotless from 6.3.0 to 6.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2605;>#2605)](https://github-redirect.dependabot.com/mockito/mockito/pull/2605;>mockito/mockito#2605) Bump org.eclipse.osgi from 3.17.100 to 3.17.200 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2597;>#2597)](https://github-redirect.dependabot.com/mockito/mockito/pull/2597;>mockito/mockito#2597) Deprecate ListUtil and Fields classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2593;>#2593)](https://github-redirect.dependabot.com/mockito/mockito/pull/2593;>mockito/mockito#2593) mockito-errorprone seems not compatible with ErrorProne 2.11.0
[GitHub] [commons-digester] dependabot[bot] closed pull request #23: Bump maven-javadoc-plugin from 2.8 to 3.3.2
dependabot[bot] closed pull request #23: Bump maven-javadoc-plugin from 2.8 to 3.3.2 URL: https://github.com/apache/commons-digester/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] commented on pull request #23: Bump maven-javadoc-plugin from 2.8 to 3.3.2
dependabot[bot] commented on PR #23: URL: https://github.com/apache/commons-digester/pull/23#issuecomment-1112873870 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request, #30: Bump maven-javadoc-plugin from 2.8 to 3.4.0
dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/commons-digester/pull/30 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 2.8 to 3.4.0. Release notes Sourced from https://github.com/apache/maven-javadoc-plugin/releases;>maven-javadoc-plugin's releases. 3.3.2 What's Changed [MJAVADOC-530] - Clean up additionalparam documentation by https://github.com/marschall;>@marschall in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/6;>apache/maven-javadoc-plugin#6 [MJAVADOC-538] Filter out 'Picked up' by https://github.com/risdenk;>@risdenk in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/11;>apache/maven-javadoc-plugin#11 [MJAVADOC-546] Allow to generate report in Spanish locale by https://github.com/belingueres;>@belingueres in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/12;>apache/maven-javadoc-plugin#12 [MJAVADOC-537] Explicitly the batchMode to true by https://github.com/joshiste;>@joshiste in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/7;>apache/maven-javadoc-plugin#7 fix mailing list url in README by https://github.com/rgdoliveira;>@rgdoliveira in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/13;>apache/maven-javadoc-plugin#13 [MJAVADOC-544] - Changed behaviour of Javadoc for temporary files encoding (options, argfile, ...) by https://github.com/michael-st;>@michael-st in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/10;>apache/maven-javadoc-plugin#10 [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals. by https://github.com/busbey;>@busbey in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/2;>apache/maven-javadoc-plugin#2 Avoid converting separator characters into newline. by https://github.com/cowwoc;>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/19;>apache/maven-javadoc-plugin#19 [MJAVADOC-577] Fixed typos in User Guide. by https://github.com/glqdlt;>@glqdlt in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/20;>apache/maven-javadoc-plugin#20 Fix typo in additionalDependencies documentation by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/23;>apache/maven-javadoc-plugin#23 Add missing @since tags to sourceFile[Includes|Excludes] by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/24;>apache/maven-javadoc-plugin#24 Added example of --add-modules to aggregate FAQ. by https://github.com/cowwoc;>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/18;>apache/maven-javadoc-plugin#18 Remove space typo in markdown by https://github.com/nrbw;>@nrbw in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/29;>apache/maven-javadoc-plugin#29 [MJAVADOC-620] Do not ignore JARs w/o module info when building classpath by https://github.com/fwienber;>@fwienber in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/35;>apache/maven-javadoc-plugin#35 [MJAVADOC-626] Add a stale javadoc detection mechanism by https://github.com/gnodet;>@gnodet in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/33;>apache/maven-javadoc-plugin#33 [MJAVADOC-613] exclude skipped modules from javadoc aggregate by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/36;>apache/maven-javadoc-plugin#36 [MJAVADOC-636] exclude some modules from aggregated javadoc by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/37;>apache/maven-javadoc-plugin#37 [MJAVADOC-639] include requires static from external dependencies for all modules by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/38;>apache/maven-javadoc-plugin#38 [MJAVADOC-638] upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/39;>apache/maven-javadoc-plugin#39 MJAVADOC-610 by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/40;>apache/maven-javadoc-plugin#40 [MJAVADOC-644] Properly close DirectoryStream by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/41;>apache/maven-javadoc-plugin#41 update qdox by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/42;>apache/maven-javadoc-plugin#42 update doxia by
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request, #187: Bump jboss-logging from 3.4.3.Final to 3.5.0.Final
dependabot[bot] opened a new pull request, #187: URL: https://github.com/apache/commons-dbcp/pull/187 Bumps [jboss-logging](https://github.com/jboss-logging/jboss-logging) from 3.4.3.Final to 3.5.0.Final. Release notes Sourced from https://github.com/jboss-logging/jboss-logging/releases;>jboss-logging's releases. 3.5.0.Final Release Notes Commits https://github.com/jboss-logging/jboss-logging/commit/b9581c2ea23b25662d8e4f94486b17e40c8c6024;>b9581c2 Prepare for 3.5.0.Final release. https://github.com/jboss-logging/jboss-logging/commit/4fd1c52a4f498c239e97e255fd8ad0f6dd3d4a70;>4fd1c52 Use the release8/release for the JavaDoc plugin. This gets around some od... https://github.com/jboss-logging/jboss-logging/commit/e4252276ae05d369f4a5939810ea4c644ea7ad87;>e425227 Merge pull request https://github-redirect.dependabot.com/jboss-logging/jboss-logging/issues/49;>#49 from jamezp/JBLOGGING-162 https://github.com/jboss-logging/jboss-logging/commit/f46c900bbf6c3ddd01e25d2ca4bcd15c3c6958bf;>f46c900 [JBLOGGING-162] Require Java 11 as a minimum. https://github.com/jboss-logging/jboss-logging/commit/0f317231ce09e5dfea5afe5f1db76f40b1c18d0b;>0f31723 Merge pull request https://github-redirect.dependabot.com/jboss-logging/jboss-logging/issues/48;>#48 from jamezp/readme https://github.com/jboss-logging/jboss-logging/commit/b2563c897da29a146f83ac049edc17dddcc7248d;>b2563c8 Add a simple README. https://github.com/jboss-logging/jboss-logging/commit/af296fa748ef98cd16036bbe49ff296091965529;>af296fa Merge pull request https://github-redirect.dependabot.com/jboss-logging/jboss-logging/issues/47;>#47 from jamezp/JBLOGGING-133 https://github.com/jboss-logging/jboss-logging/commit/ae560ec1e7058b7ded8486fbd554201cdf5d717b;>ae560ec [JBLOGGING-133] Make the known providers public, so they can be registered vi... https://github.com/jboss-logging/jboss-logging/commit/ea3065f7424ad1d30d24dd93146aee1895bcd678;>ea3065f Merge pull request https://github-redirect.dependabot.com/jboss-logging/jboss-logging/issues/46;>#46 from jamezp/JBLOGGING-97-new https://github.com/jboss-logging/jboss-logging/commit/ee5cc19857fe41fb06636ca341fcafc0c4d12926;>ee5cc19 [JBLOGGING-97] Use the JBoss Log Managers object based MDC. Additional commits viewable in https://github.com/jboss-logging/jboss-logging/compare/3.4.3.Final...3.5.0.Final;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] kinow merged pull request #287: Bump github/codeql-action from 1 to 2
kinow merged PR #287: URL: https://github.com/apache/commons-compress/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112866491 Updated this PR with a test which fails if you comment out the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] opened a new pull request, #29: Bump github/codeql-action from 1 to 2
dependabot[bot] opened a new pull request, #29: URL: https://github.com/apache/commons-digester/pull/29 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's changelog. 2.1.9 - 27 Apr 2022 Add working-directory input to the autobuild action. https://github-redirect.dependabot.com/github/codeql-action/pull/1024;>#1024 The analyze and upload-sarif actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the wait-for-processing action input to false. https://github-redirect.dependabot.com/github/codeql-action/pull/1007;>#1007 Update default CodeQL bundle version to 2.9.0. Fix a bug where https://github-redirect.dependabot.com/github/codeql-action/issues/1041;>status reporting fails on Windows. https://github-redirect.dependabot.com/github/codeql-action/pull/1042;>#1042 2.1.8 - 08 Apr 2022 Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014 Fix error where the init action would fail due to a GitHub API request that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025 2.1.7 - 05 Apr 2022 A bug where additional queries specified in the workflow file would sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018 2.1.6 - 30 Mar 2022 [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000 Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990 Fix a bug where an invalid commit_oid was being sent to code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956 Commits https://github.com/github/codeql-action/commit/3962f1bd85916dd70cf44f7dd36946a72763eef4;>3962f1b Bump glob from 7.1.7 to 8.0.1 https://github.com/github/codeql-action/commit/9daf1de73ca769b18a8abc0ddfdfff845708cb1c;>9daf1de Update references to release branches https://github.com/github/codeql-action/commit/bce749b10f3bd8b6b463c7753915deeac5158bba;>bce749b Improve consistency of variable references in Bash https://github.com/github/codeql-action/commit/fce4a01cd713caf52887d7ef8fd4e262d9e4aaa3;>fce4a01 Update the major version tag within the release process https://github.com/github/codeql-action/commit/bac9320f4fb6ba590f3722eb9b477576e59d42bd;>bac9320 Update description of Tag release and merge back workflow https://github.com/github/codeql-action/commit/b3bf557359f79e6aa98c484e8a9ad6a782fe3a8a;>b3bf557 Merge branch 'main' into henrymercer/handle-merge-conflicts-in-releases https://github.com/github/codeql-action/commit/f6312f1322bd54138163c559cc89e298d4b5e543;>f6312f1 Commit any conflicts during v1 backport to simplify release process See full diff in https://github.com/github/codeql-action/compare/v1...v2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request, #186: Bump github/codeql-action from 1 to 2
dependabot[bot] opened a new pull request, #186: URL: https://github.com/apache/commons-dbcp/pull/186 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's changelog. 2.1.9 - 27 Apr 2022 Add working-directory input to the autobuild action. https://github-redirect.dependabot.com/github/codeql-action/pull/1024;>#1024 The analyze and upload-sarif actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the wait-for-processing action input to false. https://github-redirect.dependabot.com/github/codeql-action/pull/1007;>#1007 Update default CodeQL bundle version to 2.9.0. Fix a bug where https://github-redirect.dependabot.com/github/codeql-action/issues/1041;>status reporting fails on Windows. https://github-redirect.dependabot.com/github/codeql-action/pull/1042;>#1042 2.1.8 - 08 Apr 2022 Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014 Fix error where the init action would fail due to a GitHub API request that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025 2.1.7 - 05 Apr 2022 A bug where additional queries specified in the workflow file would sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018 2.1.6 - 30 Mar 2022 [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000 Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990 Fix a bug where an invalid commit_oid was being sent to code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956 Commits https://github.com/github/codeql-action/commit/3962f1bd85916dd70cf44f7dd36946a72763eef4;>3962f1b Bump glob from 7.1.7 to 8.0.1 https://github.com/github/codeql-action/commit/9daf1de73ca769b18a8abc0ddfdfff845708cb1c;>9daf1de Update references to release branches https://github.com/github/codeql-action/commit/bce749b10f3bd8b6b463c7753915deeac5158bba;>bce749b Improve consistency of variable references in Bash https://github.com/github/codeql-action/commit/fce4a01cd713caf52887d7ef8fd4e262d9e4aaa3;>fce4a01 Update the major version tag within the release process https://github.com/github/codeql-action/commit/bac9320f4fb6ba590f3722eb9b477576e59d42bd;>bac9320 Update description of Tag release and merge back workflow https://github.com/github/codeql-action/commit/b3bf557359f79e6aa98c484e8a9ad6a782fe3a8a;>b3bf557 Merge branch 'main' into henrymercer/handle-merge-conflicts-in-releases https://github.com/github/codeql-action/commit/f6312f1322bd54138163c559cc89e298d4b5e543;>f6312f1 Commit any conflicts during v1 backport to simplify release process See full diff in https://github.com/github/codeql-action/compare/v1...v2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [commons-compress] dependabot[bot] opened a new pull request, #287: Bump github/codeql-action from 1 to 2
dependabot[bot] opened a new pull request, #287: URL: https://github.com/apache/commons-compress/pull/287 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's changelog. 2.1.9 - 27 Apr 2022 Add working-directory input to the autobuild action. https://github-redirect.dependabot.com/github/codeql-action/pull/1024;>#1024 The analyze and upload-sarif actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the wait-for-processing action input to false. https://github-redirect.dependabot.com/github/codeql-action/pull/1007;>#1007 Update default CodeQL bundle version to 2.9.0. Fix a bug where https://github-redirect.dependabot.com/github/codeql-action/issues/1041;>status reporting fails on Windows. https://github-redirect.dependabot.com/github/codeql-action/pull/1042;>#1042 2.1.8 - 08 Apr 2022 Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014 Fix error where the init action would fail due to a GitHub API request that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025 2.1.7 - 05 Apr 2022 A bug where additional queries specified in the workflow file would sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018 2.1.6 - 30 Mar 2022 [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000 Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990 Fix a bug where an invalid commit_oid was being sent to code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956 Commits https://github.com/github/codeql-action/commit/3962f1bd85916dd70cf44f7dd36946a72763eef4;>3962f1b Bump glob from 7.1.7 to 8.0.1 https://github.com/github/codeql-action/commit/9daf1de73ca769b18a8abc0ddfdfff845708cb1c;>9daf1de Update references to release branches https://github.com/github/codeql-action/commit/bce749b10f3bd8b6b463c7753915deeac5158bba;>bce749b Improve consistency of variable references in Bash https://github.com/github/codeql-action/commit/fce4a01cd713caf52887d7ef8fd4e262d9e4aaa3;>fce4a01 Update the major version tag within the release process https://github.com/github/codeql-action/commit/bac9320f4fb6ba590f3722eb9b477576e59d42bd;>bac9320 Update description of Tag release and merge back workflow https://github.com/github/codeql-action/commit/b3bf557359f79e6aa98c484e8a9ad6a782fe3a8a;>b3bf557 Merge branch 'main' into henrymercer/handle-merge-conflicts-in-releases https://github.com/github/codeql-action/commit/f6312f1322bd54138163c559cc89e298d4b5e543;>f6312f1 Commit any conflicts during v1 backport to simplify release process See full diff in https://github.com/github/codeql-action/compare/v1...v2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [commons-io] kinow commented on pull request #354: Bump maven-antrun-plugin from 3.0.0 to 3.1.0
kinow commented on PR #354: URL: https://github.com/apache/commons-io/pull/354#issuecomment-1112860193 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] kinow merged pull request #353: Bump github/codeql-action from 1 to 2
kinow merged PR #353: URL: https://github.com/apache/commons-io/pull/353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-crypto] aremily closed pull request #106: Standardizing Release Build Process with Docker
aremily closed pull request #106: Standardizing Release Build Process with Docker URL: https://github.com/apache/commons-crypto/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] opened a new pull request, #107: Bump commons-parent from 52 to 53
dependabot[bot] opened a new pull request, #107: URL: https://github.com/apache/commons-net/pull/107 Bumps commons-parent from 52 to 53. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-net] dependabot[bot] opened a new pull request, #106: Bump github/codeql-action from 1 to 2
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/commons-net/pull/106 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's changelog. 2.1.9 - 27 Apr 2022 Add working-directory input to the autobuild action. https://github-redirect.dependabot.com/github/codeql-action/pull/1024;>#1024 The analyze and upload-sarif actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the wait-for-processing action input to false. https://github-redirect.dependabot.com/github/codeql-action/pull/1007;>#1007 Update default CodeQL bundle version to 2.9.0. Fix a bug where https://github-redirect.dependabot.com/github/codeql-action/issues/1041;>status reporting fails on Windows. https://github-redirect.dependabot.com/github/codeql-action/pull/1042;>#1042 2.1.8 - 08 Apr 2022 Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014 Fix error where the init action would fail due to a GitHub API request that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025 2.1.7 - 05 Apr 2022 A bug where additional queries specified in the workflow file would sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018 2.1.6 - 30 Mar 2022 [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000 Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990 Fix a bug where an invalid commit_oid was being sent to code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956 Commits https://github.com/github/codeql-action/commit/3962f1bd85916dd70cf44f7dd36946a72763eef4;>3962f1b Bump glob from 7.1.7 to 8.0.1 https://github.com/github/codeql-action/commit/9daf1de73ca769b18a8abc0ddfdfff845708cb1c;>9daf1de Update references to release branches https://github.com/github/codeql-action/commit/bce749b10f3bd8b6b463c7753915deeac5158bba;>bce749b Improve consistency of variable references in Bash https://github.com/github/codeql-action/commit/fce4a01cd713caf52887d7ef8fd4e262d9e4aaa3;>fce4a01 Update the major version tag within the release process https://github.com/github/codeql-action/commit/bac9320f4fb6ba590f3722eb9b477576e59d42bd;>bac9320 Update description of Tag release and merge back workflow https://github.com/github/codeql-action/commit/b3bf557359f79e6aa98c484e8a9ad6a782fe3a8a;>b3bf557 Merge branch 'main' into henrymercer/handle-merge-conflicts-in-releases https://github.com/github/codeql-action/commit/f6312f1322bd54138163c559cc89e298d4b5e543;>f6312f1 Commit any conflicts during v1 backport to simplify release process See full diff in https://github.com/github/codeql-action/compare/v1...v2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [commons-io] dependabot[bot] opened a new pull request, #354: Bump maven-antrun-plugin from 3.0.0 to 3.1.0
dependabot[bot] opened a new pull request, #354: URL: https://github.com/apache/commons-io/pull/354 Bumps [maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin) from 3.0.0 to 3.1.0. Commits https://github.com/apache/maven-antrun-plugin/commit/feceee80f82e1f52a8233a19015c1ed0e4cef2ef;>feceee8 [maven-release-plugin] prepare release maven-antrun-plugin-3.1.0 https://github.com/apache/maven-antrun-plugin/commit/4e899c4314aa9e1d8ee0e6b17844c849359c42ce;>4e899c4 [MANTRUN-236] Upgrade Maven Plugin Plugin to 3.6.4 https://github.com/apache/maven-antrun-plugin/commit/61c21bd0e95cb2e4433492f00eb473d5b39fb27d;>61c21bd Update CI URL https://github.com/apache/maven-antrun-plugin/commit/b44673765e5cb4990e779d9115226510403273a7;>b446737 Bump checkstyle from 9.2.1 to 9.3 https://github.com/apache/maven-antrun-plugin/commit/43cb90edb00dfd305574820b32d368a4ae25008d;>43cb90e [MANTRUN-232] Require Maven 3.2.5 - set proper maven scopes https://github.com/apache/maven-antrun-plugin/commit/2274253cdaed396d1de6964e1c6f93ebc7502141;>2274253 Shared GitHub Actions v2 https://github.com/apache/maven-antrun-plugin/commit/7911362e0ac86b5a1120bc8f6ef451c342ec;>7911362 Bump checkstyle from 9.0.1 to 9.2.1 https://github.com/apache/maven-antrun-plugin/commit/5bb03c35533255f04d98267c5662d3b2272835c2;>5bb03c3 (doc) Update plugins before release https://github.com/apache/maven-antrun-plugin/commit/e773180d4e7d1b661efe6fa7882fcd24c11e84bc;>e773180 Bump maven-site-plugin from 3.9.1 to 3.10.0 https://github.com/apache/maven-antrun-plugin/commit/68fc8330e278b92829168e66065b5fa32086df93;>68fc833 Bump xmlunit-matchers from 2.8.3 to 2.8.4 Additional commits viewable in https://github.com/apache/maven-antrun-plugin/compare/maven-antrun-plugin-3.0.0...maven-antrun-plugin-3.1.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] dependabot[bot] opened a new pull request, #353: Bump github/codeql-action from 1 to 2
dependabot[bot] opened a new pull request, #353: URL: https://github.com/apache/commons-io/pull/353 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md;>github/codeql-action's changelog. 2.1.9 - 27 Apr 2022 Add working-directory input to the autobuild action. https://github-redirect.dependabot.com/github/codeql-action/pull/1024;>#1024 The analyze and upload-sarif actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the wait-for-processing action input to false. https://github-redirect.dependabot.com/github/codeql-action/pull/1007;>#1007 Update default CodeQL bundle version to 2.9.0. Fix a bug where https://github-redirect.dependabot.com/github/codeql-action/issues/1041;>status reporting fails on Windows. https://github-redirect.dependabot.com/github/codeql-action/pull/1042;>#1042 2.1.8 - 08 Apr 2022 Update default CodeQL bundle version to 2.8.5. https://github-redirect.dependabot.com/github/codeql-action/pull/1014;>#1014 Fix error where the init action would fail due to a GitHub API request that was taking too long to complete https://github-redirect.dependabot.com/github/codeql-action/pull/1025;>#1025 2.1.7 - 05 Apr 2022 A bug where additional queries specified in the workflow file would sometimes not be respected has been fixed. https://github-redirect.dependabot.com/github/codeql-action/pull/1018;>#1018 2.1.6 - 30 Mar 2022 [v2+ only] The CodeQL Action now runs on Node.js v16. https://github-redirect.dependabot.com/github/codeql-action/pull/1000;>#1000 Update default CodeQL bundle version to 2.8.4. https://github-redirect.dependabot.com/github/codeql-action/pull/990;>#990 Fix a bug where an invalid commit_oid was being sent to code scanning when a custom checkout path was being used. https://github-redirect.dependabot.com/github/codeql-action/pull/956;>#956 Commits https://github.com/github/codeql-action/commit/3962f1bd85916dd70cf44f7dd36946a72763eef4;>3962f1b Bump glob from 7.1.7 to 8.0.1 https://github.com/github/codeql-action/commit/9daf1de73ca769b18a8abc0ddfdfff845708cb1c;>9daf1de Update references to release branches https://github.com/github/codeql-action/commit/bce749b10f3bd8b6b463c7753915deeac5158bba;>bce749b Improve consistency of variable references in Bash https://github.com/github/codeql-action/commit/fce4a01cd713caf52887d7ef8fd4e262d9e4aaa3;>fce4a01 Update the major version tag within the release process https://github.com/github/codeql-action/commit/bac9320f4fb6ba590f3722eb9b477576e59d42bd;>bac9320 Update description of Tag release and merge back workflow https://github.com/github/codeql-action/commit/b3bf557359f79e6aa98c484e8a9ad6a782fe3a8a;>b3bf557 Merge branch 'main' into henrymercer/handle-merge-conflicts-in-releases https://github.com/github/codeql-action/commit/f6312f1322bd54138163c559cc89e298d4b5e543;>f6312f1 Commit any conflicts during v1 backport to simplify release process See full diff in https://github.com/github/codeql-action/compare/v1...v2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or
[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112686082 I don't think I understand the question. Are you asking me to write a test and add it to the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JEXL-367) Deprecate -> and support =>
[ https://issues.apache.org/jira/browse/JEXL-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-367: --- Assignee: Henri Biestro > Deprecate -> and support => > --- > > Key: JEXL-367 > URL: https://issues.apache.org/jira/browse/JEXL-367 > Project: Commons JEXL > Issue Type: Wish >Reporter: Hussachai Puripunpinyo >Assignee: Henri Biestro >Priority: Major > > The JEXL code surprisingly looks a lot like Javascript. I think this change > is a good transition for folks to update the code, and it's pretty fine if > they can tolerate using the deprecate syntax and don't mind seeing a warning > log pop up every time. > I'd like to propose supporting => and deprecate ->. > The reasons are > - JavaScript becomes very popular and many people are familiar with it. > - JEXL is more like for a quick short script. In many scenarios, the target > audiences are not a programer. They often mistake a language as a JavaScript > (from my experience). > - JEXL syntax already looks a lot like JavaScript > -- var for variable declaration (Java added in Java 10, but JavaScript > supports this from the beginning) > -- The function keyword > -- Implicit type coercion > -- Ternary operator > The proposed change. > * Support => in addition to -> > * Deprecate -> and show a warning log when it's used. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (JEXL-367) Deprecate -> and support =>
[ https://issues.apache.org/jira/browse/JEXL-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-367: --- Affects Version/s: 3.2.1 > Deprecate -> and support => > --- > > Key: JEXL-367 > URL: https://issues.apache.org/jira/browse/JEXL-367 > Project: Commons JEXL > Issue Type: Wish >Affects Versions: 3.2.1 >Reporter: Hussachai Puripunpinyo >Assignee: Henri Biestro >Priority: Major > > The JEXL code surprisingly looks a lot like Javascript. I think this change > is a good transition for folks to update the code, and it's pretty fine if > they can tolerate using the deprecate syntax and don't mind seeing a warning > log pop up every time. > I'd like to propose supporting => and deprecate ->. > The reasons are > - JavaScript becomes very popular and many people are familiar with it. > - JEXL is more like for a quick short script. In many scenarios, the target > audiences are not a programer. They often mistake a language as a JavaScript > (from my experience). > - JEXL syntax already looks a lot like JavaScript > -- var for variable declaration (Java added in Java 10, but JavaScript > supports this from the beginning) > -- The function keyword > -- Implicit type coercion > -- Ternary operator > The proposed change. > * Support => in addition to -> > * Deprecate -> and show a warning log when it's used. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (JEXL-367) Deprecate -> and support =>
[ https://issues.apache.org/jira/browse/JEXL-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529610#comment-17529610 ] Henri Biestro commented on JEXL-367: As a mitigation, we could certainly accommodate the 'fat-arrow' vs 'arrow' as a feature; the parser can accommodate both syntaxes easily and the feature controller accommodate the check. > Deprecate -> and support => > --- > > Key: JEXL-367 > URL: https://issues.apache.org/jira/browse/JEXL-367 > Project: Commons JEXL > Issue Type: Wish >Reporter: Hussachai Puripunpinyo >Priority: Major > > The JEXL code surprisingly looks a lot like Javascript. I think this change > is a good transition for folks to update the code, and it's pretty fine if > they can tolerate using the deprecate syntax and don't mind seeing a warning > log pop up every time. > I'd like to propose supporting => and deprecate ->. > The reasons are > - JavaScript becomes very popular and many people are familiar with it. > - JEXL is more like for a quick short script. In many scenarios, the target > audiences are not a programer. They often mistake a language as a JavaScript > (from my experience). > - JEXL syntax already looks a lot like JavaScript > -- var for variable declaration (Java added in Java 10, but JavaScript > supports this from the beginning) > -- The function keyword > -- Implicit type coercion > -- Ternary operator > The proposed change. > * Support => in addition to -> > * Deprecate -> and show a warning log when it's used. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (JEXL-366) Fail to evaluate string and number comparison
[
https://issues.apache.org/jira/browse/JEXL-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529604#comment-17529604
]
Henri Biestro commented on JEXL-366:
It was not 'intended' as a declared up-front specified behaviour, no. :-)
An improvement that involves BigDecimal is something I'll consider carefully...
> Fail to evaluate string and number comparison
> -
>
> Key: JEXL-366
> URL: https://issues.apache.org/jira/browse/JEXL-366
> Project: Commons JEXL
> Issue Type: Improvement
>Affects Versions: 3.2.1
>Reporter: Hussachai Puripunpinyo
>Priority: Major
>
> The comparison logic doesn't cover the case when one operand is a string and
> another operand is a numerable type (int, short, long,..).
> The expected result for '1.0' == 1 should be true but it fails because the
> string comparison check is after the numerable type check. JEXL tries to
> parse '1.0' using toLong function and it fails with this error message `For
> input string: "1.0"`
> Moving a string comparison up before other number type checks will not cover
> some corner cases such as
> '1.00' == 1.0 // String comparison will yield false but it obviously doesn't
> make sense.
> The proposed change is to add the following code to handle the corner case
> when one operand is string and another operand is numerable. To cover this
> corner case, we can apply toBigDecimal to both *lhs* and *rhs* since it
> should cover any arbitrary number in a string form, and it handles other
> number types well.
> {code:java}
> if (isNumberable(left) || isNumberable(right)) {
> if (left instanceof String || right instanceof String) {
> final BigDecimal l = toBigDecimal(left);
> final BigDecimal r = toBigDecimal(right);
> return l.compareTo(r);
> } else {
> // this code block remains the same
> }
> return 0;
> } {code}
> JEXL syntax is very similar to ECMA script except a few small set that are
> not the same. So, I think following the ECMA spec for this comparison check
> makes sense.
> The following code is JavaScript and it can be used in the JEXL test to make
> sure that the behavior of comparison are the same.
> Note that '1.0' == 1 yields true
> {code:java}
> function assert(condition, source) {
> if (!condition) {
> throw `Assertion failed for ${source}`;
> }
> }
> // Basic compare
> let exprs = [
> "1 == 1", true,
> "1 != 1", false,
> "1 != 2", true,
> "1 > 2", false,
> "1 >= 2", false,
> "1 < 2", true,
> "1 <= 2", true,
> // Int <-> Float Coercion
> "1.0 == 1", true,
> "1 == 1.0", true,
> "1.1 != 1", true,
> "1.1 < 2", true,
> // numbers and strings
> "'1' == 1", true,
> "'' == 0", true, // empty string is coerced to zero (ECMA compliance)
> "1.0 >= '1'", true,
> "1.0 > '1'", false
> ];for (e = 0; e < exprs.length; e += 2) {
> let stext = exprs[e];
> let expected = exprs[e + 1];
> assert(eval(stext) == expected, stext);
>
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=763728=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763728
]
ASF GitHub Bot logged work on COLLECTIONS-811:
--
Author: ASF GitHub Bot
Created on: 28/Apr/22 17:19
Start Date: 28/Apr/22 17:19
Worklog Time Spent: 10m
Work Description: ben-manes commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r861137680
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
The collection tests are JUnit3-based, and JUnit 4/5 have runners for
supporting their older versions. Since those versions are not backwards
compatible otherwise, it's a framework limitation. I think it is unlikely for
Guava to revise the tests as it works well enough, even if old code.
FYI there are more test cases you could add (List, Set, etc) and I only did
a quick check for Maps. (I also
[borrowed](https://github.com/ben-manes/caffeine/tree/master/caffeine/src/test/java/com/github/benmanes/caffeine)
your tests for my implementation as another sanity check)
Issue Time Tracking
---
Worklog Id: (was: 763728)
Time Spent: 1h 10m (was: 1h)
> Consider integration Guava testlib tests
>
>
> Key: COLLECTIONS-811
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
> Project: Commons Collections
> Issue Type: Test
>Affects Versions: 4.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.5
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In COLLECTIONS-802 an issue reported was found with the help of Google Guava
> testlib tests.
> Maybe we could either have something similar (i.e. build ourselves?), use
> Google Guava's testlib, or find another similar solution. From what I
> understood, it uses a factory function to create an implementation of a
> collection interface (e.g. Map) and then runs a series of functional tests
> over the created object, failing tests if a contract is broken (e.g.
> iterating a map doesn't leave the next-object as null, as it was the case of
> the 802 issue).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-collections] ben-manes commented on a diff in pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections
ben-manes commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r861137680
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
The collection tests are JUnit3-based, and JUnit 4/5 have runners for
supporting their older versions. Since those versions are not backwards
compatible otherwise, it's a framework limitation. I think it is unlikely for
Guava to revise the tests as it works well enough, even if old code.
FYI there are more test cases you could add (List, Set, etc) and I only did
a quick check for Maps. (I also
[borrowed](https://github.com/ben-manes/caffeine/tree/master/caffeine/src/test/java/com/github/benmanes/caffeine)
your tests for my implementation as another sanity check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (BEANUTILS-554) update to use commons-collections4
[ https://issues.apache.org/jira/browse/BEANUTILS-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529474#comment-17529474 ] Gary D. Gregory commented on BEANUTILS-554: --- Feels free to provide a PR on GitHub. > update to use commons-collections4 > -- > > Key: BEANUTILS-554 > URL: https://issues.apache.org/jira/browse/BEANUTILS-554 > Project: Commons BeanUtils > Issue Type: Improvement >Affects Versions: 1.9.3 >Reporter: Steve Lopez >Priority: Minor > > Most recent version (1.9.4) depends on commons-collections 3.2.2, which is > outdated and replaced by commons-collections 4.4 > Request is to update to remove dependency on outdated major version of > commons-collections. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (BEANUTILS-554) update to use commons-collections4
Steve Lopez created BEANUTILS-554: - Summary: update to use commons-collections4 Key: BEANUTILS-554 URL: https://issues.apache.org/jira/browse/BEANUTILS-554 Project: Commons BeanUtils Issue Type: Improvement Affects Versions: 1.9.3 Reporter: Steve Lopez Most recent version (1.9.4) depends on commons-collections 3.2.2, which is outdated and replaced by commons-collections 4.4 Request is to update to remove dependency on outdated major version of commons-collections. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=763487=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763487
]
ASF GitHub Bot logged work on COLLECTIONS-811:
--
Author: ASF GitHub Bot
Created on: 28/Apr/22 12:56
Start Date: 28/Apr/22 12:56
Worklog Time Spent: 10m
Work Description: kinow commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r860855659
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
I thought about that too, but I don't know how to translate the test suite
created programmatically to JUnit 5 :disappointed_relieved: ping @ben-manes
Issue Time Tracking
---
Worklog Id: (was: 763487)
Time Spent: 1h (was: 50m)
> Consider integration Guava testlib tests
>
>
> Key: COLLECTIONS-811
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
> Project: Commons Collections
> Issue Type: Test
>Affects Versions: 4.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.5
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In COLLECTIONS-802 an issue reported was found with the help of Google Guava
> testlib tests.
> Maybe we could either have something similar (i.e. build ourselves?), use
> Google Guava's testlib, or find another similar solution. From what I
> understood, it uses a factory function to create an implementation of a
> collection interface (e.g. Map) and then runs a series of functional tests
> over the created object, failing tests if a contract is broken (e.g.
> iterating a map doesn't leave the next-object as null, as it was the case of
> the 802 issue).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-collections] kinow commented on a diff in pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections
kinow commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r860855659
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
I thought about that too, but I don't know how to translate the test suite
created programmatically to JUnit 5 :disappointed_relieved: ping @ben-manes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DAEMON-441) When installing a Windows service using Commons Daemon 1.3.0 the errorlevel is -1073741819
[
https://issues.apache.org/jira/browse/DAEMON-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529394#comment-17529394
]
Brian Andle commented on DAEMON-441:
Thanks [~markt] for the explanation, and that makes sense to me.
As for the "" I don't see any harm in showing the actual path since
it's documented on what that would be on the wiki.
Normally I would not suggest including paths at all at the default logging
level as that can expose sensitive information. However, this is being run from
a command line or batch file and so any console level logging would already be
showing the pathing such as the path passed into the command.
> When installing a Windows service using Commons Daemon 1.3.0 the errorlevel
> is -1073741819
> --
>
> Key: DAEMON-441
> URL: https://issues.apache.org/jira/browse/DAEMON-441
> Project: Commons Daemon
> Issue Type: Bug
>Affects Versions: 1.3.0
> Environment: Windows 2016 Datacenter
>Reporter: Brian Andle
>Priority: Major
> Attachments: Command_Prompt.png
>
>
> When attempting to use prunsrv.exe on Windows 2016 to create a service a
> Windows Event error is logged and the errorlevel is returned as -1073741819
> Running the following command:
> {code:java}
> prunsrv.exe //IS/MyService --Startup=auto --Description=My Service
> --DisplayName=My Service {code}
> Results in the following Windows Event Log entry
>
> {code:java}
> Faulting application name: prunsrv.exe, version: 1.3.0.0, time stamp:
> 0x622b3ac0
> Faulting module name: prunsrv.exe, version: 1.3.0.0, time stamp: 0x622b3ac0
> Exception code: 0xc005
> Fault offset: 0x6e70
> Faulting process id: 0x1d88
> Faulting application start time: 0x01d845f90eb4351a
> Faulting application path: C:\myfolder\prunsrv.exe
> Faulting module path: C:\myfolder\prunsrv.exe
> Report Id: 409b7098-42bd-4036-aa61-b19eecdb1bd7
> Faulting package full name:
> Faulting package-relative application ID: {code}
> Doing an echo %errorlevel% shows -1073741819 instead of the expected 0
> Version 1.2.4.0 works correctly on both Windows 10 and 2016
> *NOTE:* The service does appear to actually install on 2016, however most
> deploy scripts will expect an error level of 0 and will fail if a non 0 value
> it returned.
> h3. Workaround
> Define a *--LogPath* value and do not use the default
> %SystemRoot%\System32\LogFiles\Apache path
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=763423=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763423
]
ASF GitHub Bot logged work on COLLECTIONS-811:
--
Author: ASF GitHub Bot
Created on: 28/Apr/22 10:58
Start Date: 28/Apr/22 10:58
Worklog Time Spent: 10m
Work Description: garydgregory commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r860754312
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
Can this be done in the JUnit 4 or 5 style?
Issue Time Tracking
---
Worklog Id: (was: 763423)
Time Spent: 50m (was: 40m)
> Consider integration Guava testlib tests
>
>
> Key: COLLECTIONS-811
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
> Project: Commons Collections
> Issue Type: Test
>Affects Versions: 4.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.5
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In COLLECTIONS-802 an issue reported was found with the help of Google Guava
> testlib tests.
> Maybe we could either have something similar (i.e. build ourselves?), use
> Google Guava's testlib, or find another similar solution. From what I
> understood, it uses a factory function to create an implementation of a
> collection interface (e.g. Map) and then runs a series of functional tests
> over the created object, failing tests if a contract is broken (e.g.
> iterating a map doesn't leave the next-object as null, as it was the case of
> the 802 issue).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-collections] garydgregory commented on a diff in pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections
garydgregory commented on code in PR #301:
URL:
https://github.com/apache/commons-collections/pull/301#discussion_r860754312
##
src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.collections4;
+
+import java.util.Map;
+import java.util.function.Supplier;
+
+import org.apache.commons.collections4.map.HashedMap;
+import org.apache.commons.collections4.map.LRUMap;
+import org.apache.commons.collections4.map.LinkedMap;
+import org.apache.commons.collections4.map.ReferenceMap;
+
+import com.google.common.collect.testing.MapTestSuiteBuilder;
+import com.google.common.collect.testing.TestStringMapGenerator;
+import com.google.common.collect.testing.features.CollectionFeature;
+import com.google.common.collect.testing.features.CollectionSize;
+import com.google.common.collect.testing.features.MapFeature;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * This test uses Google's Guava Testlib testing libraries to validate the
+ * contract of collection classes in Commons Collections. This was introduced
+ * after COLLECTIONS-802, where the issue reported was found with Testlib,
+ * with thanks to Ben Manes.
+ *
+ * @since 4.5.0
+ * @see https://github.com/google/guava/tree/master/guava-testlib;>https://github.com/google/guava/tree/master/guava-testlib
+ * @see https://issues.apache.org/jira/browse/COLLECTIONS-802;>https://issues.apache.org/jira/browse/COLLECTIONS-802
+ */
+public final class GuavaTestlibTest extends TestCase {
+
+public static Test suite() {
Review Comment:
Can this be done in the JUnit 4 or 5 style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DAEMON-441) When installing a Windows service using Commons Daemon 1.3.0 the errorlevel is -1073741819
[
https://issues.apache.org/jira/browse/DAEMON-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529366#comment-17529366
]
Gary D. Gregory commented on DAEMON-441:
Showing "" is really unhelpful IMO because it purposely hides where I
can go look for information. I feel it is best to always show the full
(absolute) path, whether that's the default value or not is additional
information that can be interesting.
> When installing a Windows service using Commons Daemon 1.3.0 the errorlevel
> is -1073741819
> --
>
> Key: DAEMON-441
> URL: https://issues.apache.org/jira/browse/DAEMON-441
> Project: Commons Daemon
> Issue Type: Bug
>Affects Versions: 1.3.0
> Environment: Windows 2016 Datacenter
>Reporter: Brian Andle
>Priority: Major
> Attachments: Command_Prompt.png
>
>
> When attempting to use prunsrv.exe on Windows 2016 to create a service a
> Windows Event error is logged and the errorlevel is returned as -1073741819
> Running the following command:
> {code:java}
> prunsrv.exe //IS/MyService --Startup=auto --Description=My Service
> --DisplayName=My Service {code}
> Results in the following Windows Event Log entry
>
> {code:java}
> Faulting application name: prunsrv.exe, version: 1.3.0.0, time stamp:
> 0x622b3ac0
> Faulting module name: prunsrv.exe, version: 1.3.0.0, time stamp: 0x622b3ac0
> Exception code: 0xc005
> Fault offset: 0x6e70
> Faulting process id: 0x1d88
> Faulting application start time: 0x01d845f90eb4351a
> Faulting application path: C:\myfolder\prunsrv.exe
> Faulting module path: C:\myfolder\prunsrv.exe
> Report Id: 409b7098-42bd-4036-aa61-b19eecdb1bd7
> Faulting package full name:
> Faulting package-relative application ID: {code}
> Doing an echo %errorlevel% shows -1073741819 instead of the expected 0
> Version 1.2.4.0 works correctly on both Windows 10 and 2016
> *NOTE:* The service does appear to actually install on 2016, however most
> deploy scripts will expect an error level of 0 and will fail if a non 0 value
> it returned.
> h3. Workaround
> Define a *--LogPath* value and do not use the default
> %SystemRoot%\System32\LogFiles\Apache path
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests
[ https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=763421=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763421 ] ASF GitHub Bot logged work on COLLECTIONS-811: -- Author: ASF GitHub Bot Created on: 28/Apr/22 10:44 Start Date: 28/Apr/22 10:44 Worklog Time Spent: 10m Work Description: kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112055774 And didn't notice a difference in build time. Executed a few times locally as well, and can confirm it doesn't bring any brittleness to our tests. Looks like a good addition to our test code. Thanks for showing us this @ben-manes ! Issue Time Tracking --- Worklog Id: (was: 763421) Time Spent: 40m (was: 0.5h) > Consider integration Guava testlib tests > > > Key: COLLECTIONS-811 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-811 > Project: Commons Collections > Issue Type: Test >Affects Versions: 4.4 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 4.5 > > Time Spent: 40m > Remaining Estimate: 0h > > In COLLECTIONS-802 an issue reported was found with the help of Google Guava > testlib tests. > Maybe we could either have something similar (i.e. build ourselves?), use > Google Guava's testlib, or find another similar solution. From what I > understood, it uses a factory function to create an implementation of a > collection interface (e.g. Map) and then runs a series of functional tests > over the created object, failing tests if a contract is broken (e.g. > iterating a map doesn't leave the next-object as null, as it was the case of > the 802 issue). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (COLLECTIONS-811) Consider integration Guava testlib tests
[ https://issues.apache.org/jira/browse/COLLECTIONS-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529363#comment-17529363 ] Bruno P. Kinoshita commented on COLLECTIONS-811: Work done in [https://github.com/apache/commons-collections/pull/301,] ready for review :D > Consider integration Guava testlib tests > > > Key: COLLECTIONS-811 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-811 > Project: Commons Collections > Issue Type: Test >Affects Versions: 4.4 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 4.5 > > Time Spent: 40m > Remaining Estimate: 0h > > In COLLECTIONS-802 an issue reported was found with the help of Google Guava > testlib tests. > Maybe we could either have something similar (i.e. build ourselves?), use > Google Guava's testlib, or find another similar solution. From what I > understood, it uses a factory function to create an implementation of a > collection interface (e.g. Map) and then runs a series of functional tests > over the created object, failing tests if a contract is broken (e.g. > iterating a map doesn't leave the next-object as null, as it was the case of > the 802 issue). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [commons-collections] kinow commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections
kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112055774 And didn't notice a difference in build time. Executed a few times locally as well, and can confirm it doesn't bring any brittleness to our tests. Looks like a good addition to our test code. Thanks for showing us this @ben-manes ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COLLECTIONS-811) Consider integration Guava testlib tests
[ https://issues.apache.org/jira/browse/COLLECTIONS-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated COLLECTIONS-811: --- Affects Version/s: 4.4 > Consider integration Guava testlib tests > > > Key: COLLECTIONS-811 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-811 > Project: Commons Collections > Issue Type: Test >Affects Versions: 4.4 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > In COLLECTIONS-802 an issue reported was found with the help of Google Guava > testlib tests. > Maybe we could either have something similar (i.e. build ourselves?), use > Google Guava's testlib, or find another similar solution. From what I > understood, it uses a factory function to create an implementation of a > collection interface (e.g. Map) and then runs a series of functional tests > over the created object, failing tests if a contract is broken (e.g. > iterating a map doesn't leave the next-object as null, as it was the case of > the 802 issue). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (COLLECTIONS-811) Consider integration Guava testlib tests
[ https://issues.apache.org/jira/browse/COLLECTIONS-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated COLLECTIONS-811: --- Fix Version/s: 4.5 > Consider integration Guava testlib tests > > > Key: COLLECTIONS-811 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-811 > Project: Commons Collections > Issue Type: Test >Affects Versions: 4.4 >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Fix For: 4.5 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In COLLECTIONS-802 an issue reported was found with the help of Google Guava > testlib tests. > Maybe we could either have something similar (i.e. build ourselves?), use > Google Guava's testlib, or find another similar solution. From what I > understood, it uses a factory function to create an implementation of a > collection interface (e.g. Map) and then runs a series of functional tests > over the created object, failing tests if a contract is broken (e.g. > iterating a map doesn't leave the next-object as null, as it was the case of > the 802 issue). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests
[ https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=763420=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763420 ] ASF GitHub Bot logged work on COLLECTIONS-811: -- Author: ASF GitHub Bot Created on: 28/Apr/22 10:42 Start Date: 28/Apr/22 10:42 Worklog Time Spent: 10m Work Description: kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112054324 Rebased. Confirmed the license is compatible (AL as well). Waiting for CI, and will update `changes.xml` in the meantime. Then it should be ready for review :+1: Issue Time Tracking --- Worklog Id: (was: 763420) Time Spent: 0.5h (was: 20m) > Consider integration Guava testlib tests > > > Key: COLLECTIONS-811 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-811 > Project: Commons Collections > Issue Type: Test >Reporter: Bruno P. Kinoshita >Assignee: Bruno P. Kinoshita >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > In COLLECTIONS-802 an issue reported was found with the help of Google Guava > testlib tests. > Maybe we could either have something similar (i.e. build ourselves?), use > Google Guava's testlib, or find another similar solution. From what I > understood, it uses a factory function to create an implementation of a > collection interface (e.g. Map) and then runs a series of functional tests > over the created object, failing tests if a contract is broken (e.g. > iterating a map doesn't leave the next-object as null, as it was the case of > the 802 issue). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [commons-collections] kinow commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections
kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112054324 Rebased. Confirmed the license is compatible (AL as well). Waiting for CI, and will update `changes.xml` in the meantime. Then it should be ready for review :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COLLECTIONS-802) ReferenceMap iterator remove violates contract
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated COLLECTIONS-802:
---
Assignee: Bruno P. Kinoshita
> ReferenceMap iterator remove violates contract
> --
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.4
>Reporter: Ben Manes
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Attachments: ApacheMapTest-1.java, ApacheMapTest.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (COLLECTIONS-802) ReferenceMap iterator remove violates contract
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved COLLECTIONS-802.
Fix Version/s: 4.5
Resolution: Fixed
> ReferenceMap iterator remove violates contract
> --
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.4
>Reporter: Ben Manes
>Assignee: Bruno P. Kinoshita
>Priority: Minor
> Fix For: 4.5
>
> Attachments: ApacheMapTest-1.java, ApacheMapTest.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (DAEMON-441) When installing a Windows service using Commons Daemon 1.3.0 the errorlevel is -1073741819
[
https://issues.apache.org/jira/browse/DAEMON-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529360#comment-17529360
]
Mark Thomas commented on DAEMON-441:
Thanks for those tests. That is what I expected to see which is good.
1.3.0 made some changes to stdout and stderr redirection. This was a fix for
DAEMON-437. The issue was that the output files could be used both by a running
service and by the separate process that starts / stops / updates the running
service. Multiple processes trying to write to the same file is generally a
cause of problems. The solution chosen was to only redirect stdout and stderr
for a running service. Hence why you see log messages on the console rather
than a redirected file being created.
There was some discussion of alternative approaches in DAEMON-437.
I'm still thinking about reporting the actual log path rather than
when no explicit path is set. I'd be interested in your views on that.
> When installing a Windows service using Commons Daemon 1.3.0 the errorlevel
> is -1073741819
> --
>
> Key: DAEMON-441
> URL: https://issues.apache.org/jira/browse/DAEMON-441
> Project: Commons Daemon
> Issue Type: Bug
>Affects Versions: 1.3.0
> Environment: Windows 2016 Datacenter
>Reporter: Brian Andle
>Priority: Major
> Attachments: Command_Prompt.png
>
>
> When attempting to use prunsrv.exe on Windows 2016 to create a service a
> Windows Event error is logged and the errorlevel is returned as -1073741819
> Running the following command:
> {code:java}
> prunsrv.exe //IS/MyService --Startup=auto --Description=My Service
> --DisplayName=My Service {code}
> Results in the following Windows Event Log entry
>
> {code:java}
> Faulting application name: prunsrv.exe, version: 1.3.0.0, time stamp:
> 0x622b3ac0
> Faulting module name: prunsrv.exe, version: 1.3.0.0, time stamp: 0x622b3ac0
> Exception code: 0xc005
> Fault offset: 0x6e70
> Faulting process id: 0x1d88
> Faulting application start time: 0x01d845f90eb4351a
> Faulting application path: C:\myfolder\prunsrv.exe
> Faulting module path: C:\myfolder\prunsrv.exe
> Report Id: 409b7098-42bd-4036-aa61-b19eecdb1bd7
> Faulting package full name:
> Faulting package-relative application ID: {code}
> Doing an echo %errorlevel% shows -1073741819 instead of the expected 0
> Version 1.2.4.0 works correctly on both Windows 10 and 2016
> *NOTE:* The service does appear to actually install on 2016, however most
> deploy scripts will expect an error level of 0 and will fail if a non 0 value
> it returned.
> h3. Workaround
> Define a *--LogPath* value and do not use the default
> %SystemRoot%\System32\LogFiles\Apache path
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (COLLECTIONS-802) ReferenceMap iterator remove violates contract
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=763417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763417
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF GitHub Bot
Created on: 28/Apr/22 10:38
Start Date: 28/Apr/22 10:38
Worklog Time Spent: 10m
Work Description: kinow closed pull request #300: [COLLECTIONS-802] Fix
remove failed by removing set null to currentKe…
URL: https://github.com/apache/commons-collections/pull/300
Issue Time Tracking
---
Worklog Id: (was: 763417)
Time Spent: 1h 50m (was: 1h 40m)
> ReferenceMap iterator remove violates contract
> --
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.4
>Reporter: Ben Manes
>Priority: Minor
> Attachments: ApacheMapTest-1.java, ApacheMapTest.java
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-collections] kinow closed pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…
kinow closed pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe… URL: https://github.com/apache/commons-collections/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-802) ReferenceMap iterator remove violates contract
[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=763415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763415
]
ASF GitHub Bot logged work on COLLECTIONS-802:
--
Author: ASF GitHub Bot
Created on: 28/Apr/22 10:34
Start Date: 28/Apr/22 10:34
Worklog Time Spent: 10m
Work Description: kinow commented on code in PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#discussion_r860735919
##
src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java:
##
@@ -794,23 +794,21 @@ protected void nullValue() {
public boolean hasNext() {
checkMod();
while (nextNull()) {
-ReferenceEntry e = entry;
+ReferenceEntry e = next;
int i = index;
while (e == null && i > 0) {
i--;
e = (ReferenceEntry) parent.data[i];
}
-entry = e;
+next = e;
index = i;
if (e == null) {
-currentKey = null;
-currentValue = null;
Review Comment:
Fix is here :point_up: , the rest is renaming variables.
Issue Time Tracking
---
Worklog Id: (was: 763415)
Time Spent: 1h 40m (was: 1.5h)
> ReferenceMap iterator remove violates contract
> --
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
>Affects Versions: 4.4
>Reporter: Ben Manes
>Priority: Minor
> Attachments: ApacheMapTest-1.java, ApacheMapTest.java
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [commons-collections] kinow commented on a diff in pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…
kinow commented on code in PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#discussion_r860735919
##
src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java:
##
@@ -794,23 +794,21 @@ protected void nullValue() {
public boolean hasNext() {
checkMod();
while (nextNull()) {
-ReferenceEntry e = entry;
+ReferenceEntry e = next;
int i = index;
while (e == null && i > 0) {
i--;
e = (ReferenceEntry) parent.data[i];
}
-entry = e;
+next = e;
index = i;
if (e == null) {
-currentKey = null;
-currentValue = null;
Review Comment:
Fix is here :point_up: , the rest is renaming variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-bcel] garydgregory commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`
garydgregory commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1112033456 Hello @timboudreau , Thank you for the PR. Is the instance of test really needed? It would be best to have test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
