[jira] [Commented] (COLLECTIONS-814) CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
[
https://issues.apache.org/jira/browse/COLLECTIONS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609060#comment-17609060
]
Angus C commented on COLLECTIONS-814:
-
https://github.com/apache/commons-collections/pull/340
> CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if
> the first parameter is empty
> -
>
> Key: COLLECTIONS-814
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-814
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 4.4
>Reporter: Elia Bertolina
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CollectionUtils.removeAll(Collection collection, Collection remove)
> does not throw a NullPointerException(NPE) when the “remove” parameters is
> null, but only if the “collection” parameter is empty.
> In the documentation it is stated that an NPE will be thrown if any of the
> parameters is null.
> However, in this test case:
>
> {code:java}
> public class CollectionUtils_failure_Test {
> public void test() throws Throwable {
> LinkedList linkedList = new
> LinkedList();
> try {
> Collection collection =
> CollectionUtils.removeAll(
> (Collection)linkedList,
> (Collection) null);
> org.junit.Assert.fail();
> } catch (java.lang.NullPointerException e) {
> //Exception caught and test successful
> }
> }
> } {code}
>
> This is a special case (first parameter needs to be empty and the second
> needs to be null) but this behavior is missing in the documentation. While
> this behavior is somehow correct (removing a null Object from an empty
> Collection we should obtain an empty Collection) I think throwing an NPE
> would be more in line with the documentation provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-geometry] aherbert commented on pull request #199: Remove unnecessary validations. It's not null when it reaches it.
aherbert commented on PR #199: URL: https://github.com/apache/commons-geometry/pull/199#issuecomment-1257070754 This looks correct to me. Perhaps wait to check if @darkma773r can see an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] aherbert commented on pull request #956: Improve JavaDocs
aherbert commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257068878 FYI: This javadoc warning: ``` [WARNING] Javadoc Warnings [WARNING] warning: URL https://docs.oracle.com/javase/8/docs/api/element-list was redirected to https://docs.oracle.com/en/java/javase/19/ -- Update the command-line options to suppress this warning. ``` Is due to the `` added to the `maven-javadoc-plugin` in commons-parent for JDK classes. This seems to not be required when building on recent JDK LTS versions (tested on 8, 11, and 17). Only JDK 17 puts out this warning as it attempts to look up an element-list and not a package-list for the javadoc at the provided URL. Note: To test locally you simply run maven with the default goal: `mvn`. Most of the commons GH actions builds are configured to use the default goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] aherbert commented on a diff in pull request #38: Fix minor typo
aherbert commented on code in PR #38:
URL: https://github.com/apache/commons-statistics/pull/38#discussion_r979316838
##
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java:
##
@@ -65,7 +65,7 @@
* The parameters are parsed from String values to the appropriate parameter
object. Currently
* this supports Double and Integer; numbers can be unboxed and used to create
the distribution.
*
- * Illegal arguments for the distribution are tested from
parametersprovided by
+ * Illegal arguments for the distribution are tested from
parameters-provided by
Review Comment:
No hyphen required here
##
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TruncatedNormalDistributionTest.java:
##
@@ -200,7 +200,7 @@ void testVariance() {
/**
* Test cases for computation of the moments. This hits edge cases
including truncations
* too extreme to have a probability range for the distribution.
- * The test ensures that the moments are computable for parameterisations
+ * The test ensures that the moments are computable for parameters-provided
Review Comment:
Parameterisations is the intended term. It is a British alternative spelling
of [parametrization](https://en.wiktionary.org/wiki/parametrization). It is
intended to describe the result of parameters, i.e. 'computable for the result
of parameters (the distribution under test) where the bounds fall within'. Feel
free to update it to the US english which is more standard for commons
components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-statistics] arturobernalg closed pull request #37: Remove redundant variable.
arturobernalg closed pull request #37: Remove redundant variable. URL: https://github.com/apache/commons-statistics/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] aherbert commented on pull request #37: Remove redundant variable.
aherbert commented on PR #37: URL: https://github.com/apache/commons-statistics/pull/37#issuecomment-1257065200 The code is meant to be self-documenting. A Nakagami distribution is parameterised by mu and omega; the gamma distribution by shape and scale. You can sample from a Nakagami using a Gamma. Removing the variable does not enhance the code and will not change efficiency. Any caller who requires a sampler will be spending negligible time constructing a sampler and all the time using it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (COMMONSSITE-161) I was using 'BeamRunJavaPipelineOperator' to run a java jar to ingest data from google cloud storage
[ https://issues.apache.org/jira/browse/COMMONSSITE-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed COMMONSSITE-161. --- Resolution: Invalid > I was using 'BeamRunJavaPipelineOperator' to run a java jar to ingest data > from google cloud storage > > > Key: COMMONSSITE-161 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-161 > Project: Apache Commons All > Issue Type: Bug >Reporter: Raj Prakash Kante >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (COMMONSSITE-162) Xcom not returned while using 'BeamRunJavaPipelineOperator'.
[ https://issues.apache.org/jira/browse/COMMONSSITE-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed COMMONSSITE-162. --- Resolution: Invalid > Xcom not returned while using 'BeamRunJavaPipelineOperator'. > > > Key: COMMONSSITE-162 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-162 > Project: Apache Commons All > Issue Type: Bug >Reporter: Raj Prakash Kante >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (COLLECTIONS-814) CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
[
https://issues.apache.org/jira/browse/COLLECTIONS-814?focusedWorklogId=811871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811871
]
ASF GitHub Bot logged work on COLLECTIONS-814:
--
Author: ASF GitHub Bot
Created on: 24/Sep/22 20:41
Start Date: 24/Sep/22 20:41
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #340:
URL:
https://github.com/apache/commons-collections/pull/340#issuecomment-1257062009
#
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Report
> Merging
[#340](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
(a3490d3) into
[master](https://codecov.io/gh/apache/commons-collections/commit/474713f727f49707a4ac77ed737d0205d22152ee?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
(474713f) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #340 +/- ##
+ Coverage 85.93% 85.98% +0.05%
- Complexity 4669 4671 +2
Files 289 289
Lines 1344513447 +2
Branches 1977 1977
+ Hits 1155411563 +9
+ Misses 1327 1323 -4
+ Partials564 561 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ava/org/apache/commons/collections4/ListUtils.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0xpc3RVdGlscy5qYXZh)
| `87.30% <100.00%> (+0.20%)` | :arrow_up: |
|
[...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh)
| `91.48% <0.00%> (+2.59%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Issue Time Tracking
---
Worklog Id: (was: 811871)
Time Spent: 20m (was: 10m)
> CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if
> the first parameter is empty
> -
>
> Key: COLLECTIONS-814
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-814
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 4.4
>Reporter: Elia Bertolina
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The CollectionUtils.removeAll(Collection collection, Collection remove)
> does not throw a NullPointerException(NPE) when the “remove” parameters is
> null, but only if the “collection” parameter is empty.
> In the documentation it is stated that an NPE will be thrown if any of the
> parameters is null.
> However, in this test case:
>
> {code:java}
> public class CollectionUtils_failure_Test {
> public void test() throws Throwable {
> LinkedList linkedList = new
> LinkedList();
> try {
> Collection collection =
> CollectionUtils.removeAll(
> (Collection)linkedList,
> (Collection) null);
> org.junit.Assert.fail();
> } catch (java.lang.NullPointerException e) {
> //Exception caught and test successful
> }
> }
> } {code}
>
> This is a special case (first parameter needs to be empty and the second
> needs to be null) but this behavior is missing in the documentation. While
> this behavior is somehow correct (removing a null Object from an empty
> Collection we should obtain an empty
[GitHub] [commons-collections] codecov-commenter commented on pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
codecov-commenter commented on PR #340: URL: https://github.com/apache/commons-collections/pull/340#issuecomment-1257062009 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#340](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a3490d3) into [master](https://codecov.io/gh/apache/commons-collections/commit/474713f727f49707a4ac77ed737d0205d22152ee?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (474713f) will **increase** coverage by `0.05%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #340 +/- ## + Coverage 85.93% 85.98% +0.05% - Complexity 4669 4671 +2 Files 289 289 Lines 1344513447 +2 Branches 1977 1977 + Hits 1155411563 +9 + Misses 1327 1323 -4 + Partials564 561 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ava/org/apache/commons/collections4/ListUtils.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0xpc3RVdGlscy5qYXZh) | `87.30% <100.00%> (+0.20%)` | :arrow_up: | | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `91.48% <0.00%> (+2.59%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COLLECTIONS-814) CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
[
https://issues.apache.org/jira/browse/COLLECTIONS-814?focusedWorklogId=811870=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811870
]
ASF GitHub Bot logged work on COLLECTIONS-814:
--
Author: ASF GitHub Bot
Created on: 24/Sep/22 20:35
Start Date: 24/Sep/22 20:35
Worklog Time Spent: 10m
Work Description: angusdev opened a new pull request, #340:
URL: https://github.com/apache/commons-collections/pull/340
[COLLECTIONS-814](https://issues.apache.org/jira/browse/COLLECTIONS-814)
CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if
the first parameter is empty
Add null check in ListUtil.removeAll()
Issue Time Tracking
---
Worklog Id: (was: 811870)
Remaining Estimate: 0h
Time Spent: 10m
> CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if
> the first parameter is empty
> -
>
> Key: COLLECTIONS-814
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-814
> Project: Commons Collections
> Issue Type: Bug
>Affects Versions: 4.4
>Reporter: Elia Bertolina
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CollectionUtils.removeAll(Collection collection, Collection remove)
> does not throw a NullPointerException(NPE) when the “remove” parameters is
> null, but only if the “collection” parameter is empty.
> In the documentation it is stated that an NPE will be thrown if any of the
> parameters is null.
> However, in this test case:
>
> {code:java}
> public class CollectionUtils_failure_Test {
> public void test() throws Throwable {
> LinkedList linkedList = new
> LinkedList();
> try {
> Collection collection =
> CollectionUtils.removeAll(
> (Collection)linkedList,
> (Collection) null);
> org.junit.Assert.fail();
> } catch (java.lang.NullPointerException e) {
> //Exception caught and test successful
> }
> }
> } {code}
>
> This is a special case (first parameter needs to be empty and the second
> needs to be null) but this behavior is missing in the documentation. While
> this behavior is somehow correct (removing a null Object from an empty
> Collection we should obtain an empty Collection) I think throwing an NPE
> would be more in line with the documentation provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-collections] angusdev opened a new pull request, #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
angusdev opened a new pull request, #340: URL: https://github.com/apache/commons-collections/pull/340 [COLLECTIONS-814](https://issues.apache.org/jira/browse/COLLECTIONS-814) CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty Add null check in ListUtil.removeAll() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #956: Improve JavaDocs
garydgregory commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257057493 I'm not sure what Jenkins has to do with this. In any case, you can see the failure here: https://github.com/apache/commons-lang/actions/runs/3119069043/jobs/5058792919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] codecov-commenter commented on pull request #38: Fix minor typo
codecov-commenter commented on PR #38: URL: https://github.com/apache/commons-statistics/pull/38#issuecomment-1257054378 # [Codecov](https://codecov.io/gh/apache/commons-statistics/pull/38?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#38](https://codecov.io/gh/apache/commons-statistics/pull/38?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (19d5583) into [master](https://codecov.io/gh/apache/commons-statistics/commit/0afdf878365fc4c11478368e02148b30fca308ce?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0afdf87) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #38 +/- ## === Coverage 100.00% 100.00% Complexity 853 853 === Files 3434 Lines 1599 1599 Branches 256 256 === Hits1599 1599 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-statistics/pull/38?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ons/statistics/distribution/ExtendedPrecision.java](https://codecov.io/gh/apache/commons-statistics/pull/38/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1zdGF0aXN0aWNzLWRpc3RyaWJ1dGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9zdGF0aXN0aWNzL2Rpc3RyaWJ1dGlvbi9FeHRlbmRlZFByZWNpc2lvbi5qYXZh) | `100.00% <ø> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] codecov-commenter commented on pull request #199: Remove unnecessary validations. It's not null when it reaches it.
codecov-commenter commented on PR #199: URL: https://github.com/apache/commons-geometry/pull/199#issuecomment-1257053396 # [Codecov](https://codecov.io/gh/apache/commons-geometry/pull/199?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@c9de6da`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## master #199 +/- ## = Coverage ? 98.74% Complexity? 3747 = Files ? 195 Lines ?10462 Branches ? 1544 = Hits ?10331 Misses? 13 Partials ? 118 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] codecov-commenter commented on pull request #37: Remove redundant variable.
codecov-commenter commented on PR #37: URL: https://github.com/apache/commons-statistics/pull/37#issuecomment-1257051610 # [Codecov](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#37](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8ff9326) into [master](https://codecov.io/gh/apache/commons-statistics/commit/0afdf878365fc4c11478368e02148b30fca308ce?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0afdf87) will **not change** coverage. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #37 +/- ## === Coverage 100.00% 100.00% Complexity 853 853 === Files 3434 Lines 1599 1598-1 Branches 256 256 === - Hits1599 1598-1 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-statistics/pull/37?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../statistics/distribution/NakagamiDistribution.java](https://codecov.io/gh/apache/commons-statistics/pull/37/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1zdGF0aXN0aWNzLWRpc3RyaWJ1dGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9zdGF0aXN0aWNzL2Rpc3RyaWJ1dGlvbi9OYWthZ2FtaURpc3RyaWJ1dGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-statistics] arturobernalg opened a new pull request, #37: Remove redundant variable.
arturobernalg opened a new pull request, #37: URL: https://github.com/apache/commons-statistics/pull/37 Do we really need this var? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #956: Improve JavaDocs
arturobernalg commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257046060 HI @garydgregory > You really need to build the project locally before you create the PR, see the Javadoc errors. > > Aside from that, I'm starting to think that this is really making the code harder to read and that it would be better handled by a Doclet. I lose track of what apache jenkings does. I do not have access `[INFO] Configuration changed, re-generating javadoc. [WARNING] Javadoc Warnings [WARNING] warning: URL https://docs.oracle.com/javase/8/docs/api/element-list was redirected to https://docs.oracle.com/en/java/javase/19/ -- Update the command-line options to suppress this warning. [WARNING] 1 warning [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:28 min [INFO] Finished at: 2022-09-24T21:01:26+02:00 [INFO] abernal@Arturo-MacBook-Pro ~/IdeaProyect/commons-lang feature/better_javadoc ` > You really need to build the project locally before you create the PR, see the Javadoc errors. None. > > Aside from that, I'm starting to think that this is really making the code harder to read and that it would be better handled by a Doclet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #956: Improve JavaDocs
arturobernalg commented on code in PR #956:
URL: https://github.com/apache/commons-lang/pull/956#discussion_r979290913
##
src/main/java/org/apache/commons/lang3/CharSetUtils.java:
##
@@ -45,8 +45,8 @@ public class CharSetUtils {
*
*
* @see CharSet#getInstance(String...) for set-syntax.
- * @param str String to look for characters in, may be null
- * @param set String[] set of characters to identify, may be null
+ * @param str String to look for characters in, may be {@code null}
Review Comment:
No Reason at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #956: Improve JavaDocs
garydgregory commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257033216 You really need to build the project locally before you create the PR, see the Javadoc errors. Aside from that, I'm starting to think that this is really making the code harder to read and that it would be better handled by a Doclet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #309: Bump checkstyle from 9.3 to 10.3.3
dependabot[bot] commented on PR #309: URL: https://github.com/apache/commons-vfs/pull/309#issuecomment-1257032425 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #309: Bump checkstyle from 9.3 to 10.3.3
garydgregory closed pull request #309: Bump checkstyle from 9.3 to 10.3.3 URL: https://github.com/apache/commons-vfs/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #309: Bump checkstyle from 9.3 to 10.3.3
garydgregory commented on PR #309: URL: https://github.com/apache/commons-vfs/pull/309#issuecomment-1257032411 Req Java 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #309: Bump checkstyle from 9.3 to 10.3.3
dependabot[bot] opened a new pull request, #309: URL: https://github.com/apache/commons-vfs/pull/309 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.3.3. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-10.3.3 https://checkstyle.org/releasenotes.html#Release_10.3.3;>https://checkstyle.org/releasenotes.html#Release_10.3.3 checkstyle-10.3.2 https://checkstyle.org/releasenotes.html#Release_10.3.2;>https://checkstyle.org/releasenotes.html#Release_10.3.2 Bug fixes: https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11736;>#11736 - MissingJavadocType: Support qualified annotation names https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11655;>#11655 - Update google_checks.xml to have the SuppressionCommentFilter and SuppressWarningsHolder modules in the config by default (and by extension, SuppressWarningsFilter) ... (truncated) Commits https://github.com/checkstyle/checkstyle/commit/a8c7ab6fbc1f6177c3ea9fc98938ab54ab52f0c3;>a8c7ab6 [maven-release-plugin] prepare release checkstyle-10.3.3 https://github.com/checkstyle/checkstyle/commit/d954a23ae172f5f6b06d1b3aae3a18a033a2dda5;>d954a23 doc: releasenotes 10.3.3 https://github.com/checkstyle/checkstyle/commit/8f4aba870496d46ca1eb2fe1282ce0867fce77c5;>8f4aba8 minor: add word to known words https://github.com/checkstyle/checkstyle/commit/ed024637a29699d9f5ebcaf20b996e6ec5377a8a;>ed02463 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12114;>#12114: rename all release action to have 'R:' prefix in name https://github.com/checkstyle/checkstyle/commit/02babf8a0ab715caebddf299b373bac31f2a9969;>02babf8 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12082;>#12082: Github action Publish release notes Twitter https://github.com/checkstyle/checkstyle/commit/b519b15b531877a6613a80d203dd6ab4bd838d05;>b519b15 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12082;>#12082: Github action Publish release notes outside https://github.com/checkstyle/checkstyle/commit/ca997926c69f41d7aebc76e991ff557e334d31c7;>ca99792 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12077;>#12077: Github action to update sources with release notes https://github.com/checkstyle/checkstyle/commit/0192fcd3406e809e261db24256d7dc8c02d241ec;>0192fcd Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12080;>#12080: Github action Update Github https://github.com/checkstyle/checkstyle/commit/527bae79cd8dd6eef03c03dab14f7ca6dffab8bc;>527bae7 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/12078;>#12078: Github action Release prepare https://github.com/checkstyle/checkstyle/commit/c0b12ee3ccdc14b3e51cf2bda3efaafd535508c0;>c0b12ee minor: Add trailing comments on separate line in StarterRuleSet-AllRulesByCat... Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.3.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or
[GitHub] [commons-vfs] garydgregory merged pull request #308: Bump mockito-core from 4.7.0 to 4.8.0
garydgregory merged PR #308: URL: https://github.com/apache/commons-vfs/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #308: Bump mockito-core from 4.7.0 to 4.8.0
dependabot[bot] opened a new pull request, #308: URL: https://github.com/apache/commons-vfs/pull/308 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.7.0 to 4.8.0. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.8.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.8.0 2022-09-07 - https://github.com/mockito/mockito/compare/v4.7.0...v4.8.0;>10 commit(s) by Alex, James Baker, Johannes Spangenberg, Kurt Alfred Kluever, Rafael Winterhalter, Thibault Helsmoortel, dependabot[bot] GitHub Workflows security hardening [(https://github-redirect.dependabot.com/mockito/mockito/issues/2744;>#2744)](https://github-redirect.dependabot.com/mockito/mockito/pull/2744;>mockito/mockito#2744) Assign GlobalConfiguration initializer to unused variable [(https://github-redirect.dependabot.com/mockito/mockito/issues/2742;>#2742)](https://github-redirect.dependabot.com/mockito/mockito/pull/2742;>mockito/mockito#2742) Bump com.diffplug.spotless from 6.9.1 to 6.10.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2738;>#2738)](https://github-redirect.dependabot.com/mockito/mockito/pull/2738;>mockito/mockito#2738) Drop varargs collector before invoking a user method. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2736;>#2736)](https://github-redirect.dependabot.com/mockito/mockito/pull/2736;>mockito/mockito#2736) Bump versions.bytebuddy from 1.12.13 to 1.12.14 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2734;>#2734)](https://github-redirect.dependabot.com/mockito/mockito/pull/2734;>mockito/mockito#2734) Remove useless thrown exception from constructor [(https://github-redirect.dependabot.com/mockito/mockito/issues/2732;>#2732)](https://github-redirect.dependabot.com/mockito/mockito/pull/2732;>mockito/mockito#2732) TypeSafeMatching no longer iterates over class methods inefficiently [(https://github-redirect.dependabot.com/mockito/mockito/issues/2729;>#2729)](https://github-redirect.dependabot.com/mockito/mockito/pull/2729;>mockito/mockito#2729) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2720;>#2720: Use StackWalker on Java 9+ to create Locations [(https://github-redirect.dependabot.com/mockito/mockito/issues/2723;>#2723)](https://github-redirect.dependabot.com/mockito/mockito/pull/2723;>mockito/mockito#2723) LocationImpl adds performance overheads due to instantiating a stack trace [(https://github-redirect.dependabot.com/mockito/mockito/issues/2720;>#2720)](https://github-redirect.dependabot.com/mockito/mockito/issues/2720;>mockito/mockito#2720) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626;>#2626 : Introduce MockSettings.mockMaker [(https://github-redirect.dependabot.com/mockito/mockito/issues/2701;>#2701)](https://github-redirect.dependabot.com/mockito/mockito/pull/2701;>mockito/mockito#2701) Introduce option to disable inline-mock-maker for a specific instance [(https://github-redirect.dependabot.com/mockito/mockito/issues/2626;>#2626)](https://github-redirect.dependabot.com/mockito/mockito/issues/2626;>mockito/mockito#2626) Commits https://github.com/mockito/mockito/commit/3e910ea990e61b29ec76d8b47a6d1b1607d9da3f;>3e910ea Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2626;>#2626 : Introduce MockSettings.mockMaker (https://github-redirect.dependabot.com/mockito/mockito/issues/2701;>#2701) https://github.com/mockito/mockito/commit/0753d48161bc6376108f38146c01c80274a712e3;>0753d48 Explicitly add permissions to GitHub actions (https://github-redirect.dependabot.com/mockito/mockito/issues/2744;>#2744) https://github.com/mockito/mockito/commit/530558ae3c721cb310f3410a66ff4061414cf836;>530558a Assign GlobalConfiguration initializer to unused variable (https://github-redirect.dependabot.com/mockito/mockito/issues/2742;>#2742) https://github.com/mockito/mockito/commit/4b8042e24e4d2009eb46c5319673fd9755c86e45;>4b8042e Bump com.diffplug.spotless from 6.9.1 to 6.10.0 (https://github-redirect.dependabot.com/mockito/mockito/issues/2738;>#2738) https://github.com/mockito/mockito/commit/9b93df72c9aad120057ff82d25d0fd5dc3af2317;>9b93df7 Merge pull request https://github-redirect.dependabot.com/mockito/mockito/issues/2736;>#2736 from mockito/static-varargs-call https://github.com/mockito/mockito/commit/160e3daf446e508eb17c6fc21a0932246848206b;>160e3da Drop varargs collector before invoking a user method. https://github.com/mockito/mockito/commit/e123c2cdf7e4688bae7e4ecc145eb960626894db;>e123c2c Bump versions.bytebuddy from 1.12.13 to 1.12.14 (https://github-redirect.dependabot.com/mockito/mockito/issues/2734;>#2734) https://github.com/mockito/mockito/commit/2ded10ec704f2c93648d976031c2520a5a9b84aa;>2ded10e Remove useless thrown exception from constructor
[GitHub] [commons-vfs] garydgregory merged pull request #306: Bump junit-bom from 5.9.0 to 5.9.1
garydgregory merged PR #306: URL: https://github.com/apache/commons-vfs/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #307: Bump slf4j.version from 1.7.36 to 2.0.2
dependabot[bot] opened a new pull request, #307: URL: https://github.com/apache/commons-vfs/pull/307 Bumps `slf4j.version` from 1.7.36 to 2.0.2. Updates `slf4j-api` from 1.7.36 to 2.0.2 Commits https://github.com/qos-ch/slf4j/commit/0645c18cafbad8dfcebf2d57926cba496c8ab055;>0645c18 prepare release 2.0.2 https://github.com/qos-ch/slf4j/commit/894b1890a077a966f8be147e9fac2ad92a610e69;>894b189 fix SLF4J-563 https://github.com/qos-ch/slf4j/commit/7c1d86e21e7260093bbef5647cd554e09d64f68b;>7c1d86e start work on 2.0.2-SNAPSHOT https://github.com/qos-ch/slf4j/commit/9752442b6e6db0749915dc40e80437dc97cd772d;>9752442 prepare release 2.0.1 https://github.com/qos-ch/slf4j/commit/c0f7f16bfb2cdbcf38df6039219ee3f57c99117e;>c0f7f16 minor javadoc change https://github.com/qos-ch/slf4j/commit/1148b9852997376ab865cfc5e448fee0675cabbd;>1148b98 Merge branch 'master' of github.com:qos-ch/slf4j https://github.com/qos-ch/slf4j/commit/593f89f85af8d181f0727315224f37fe0aa5fdcb;>593f89f fix SLF4J SLF4J-560 https://github.com/qos-ch/slf4j/commit/03deea9f77c354ccd59c578808cff689299ba5eb;>03deea9 Merge pull request https://github-redirect.dependabot.com/qos-ch/slf4j/issues/302;>#302 from coheigea/coheigea/reload4j_1.2.22 https://github.com/qos-ch/slf4j/commit/c9d5cc1257be51d837bf8e3f10f94eb18d1390bb;>c9d5cc1 Update reload4j to 1.2.22 https://github.com/qos-ch/slf4j/commit/bae56f544b0c30cedb265729f3c6cce72fa79f10;>bae56f5 Merge pull request https://github-redirect.dependabot.com/qos-ch/slf4j/issues/294;>#294 from marcwrobel/fix-typos Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.2;>compare view Updates `jcl-over-slf4j` from 1.7.36 to 2.0.2 Commits https://github.com/qos-ch/slf4j/commit/0645c18cafbad8dfcebf2d57926cba496c8ab055;>0645c18 prepare release 2.0.2 https://github.com/qos-ch/slf4j/commit/894b1890a077a966f8be147e9fac2ad92a610e69;>894b189 fix SLF4J-563 https://github.com/qos-ch/slf4j/commit/7c1d86e21e7260093bbef5647cd554e09d64f68b;>7c1d86e start work on 2.0.2-SNAPSHOT https://github.com/qos-ch/slf4j/commit/9752442b6e6db0749915dc40e80437dc97cd772d;>9752442 prepare release 2.0.1 https://github.com/qos-ch/slf4j/commit/c0f7f16bfb2cdbcf38df6039219ee3f57c99117e;>c0f7f16 minor javadoc change https://github.com/qos-ch/slf4j/commit/1148b9852997376ab865cfc5e448fee0675cabbd;>1148b98 Merge branch 'master' of github.com:qos-ch/slf4j https://github.com/qos-ch/slf4j/commit/593f89f85af8d181f0727315224f37fe0aa5fdcb;>593f89f fix SLF4J SLF4J-560 https://github.com/qos-ch/slf4j/commit/03deea9f77c354ccd59c578808cff689299ba5eb;>03deea9 Merge pull request https://github-redirect.dependabot.com/qos-ch/slf4j/issues/302;>#302 from coheigea/coheigea/reload4j_1.2.22 https://github.com/qos-ch/slf4j/commit/c9d5cc1257be51d837bf8e3f10f94eb18d1390bb;>c9d5cc1 Update reload4j to 1.2.22 https://github.com/qos-ch/slf4j/commit/bae56f544b0c30cedb265729f3c6cce72fa79f10;>bae56f5 Merge pull request https://github-redirect.dependabot.com/qos-ch/slf4j/issues/294;>#294 from marcwrobel/fix-typos Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.2;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To
[GitHub] [commons-vfs] garydgregory merged pull request #305: Bump log4j2.version from 2.18.0 to 2.19.0
garydgregory merged PR #305: URL: https://github.com/apache/commons-vfs/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #956: Improve JavaDocs
garydgregory commented on code in PR #956:
URL: https://github.com/apache/commons-lang/pull/956#discussion_r979279531
##
src/main/java/org/apache/commons/lang3/CharSetUtils.java:
##
@@ -45,8 +45,8 @@ public class CharSetUtils {
*
*
* @see CharSet#getInstance(String...) for set-syntax.
- * @param str String to look for characters in, may be null
- * @param set String[] set of characters to identify, may be null
+ * @param str String to look for characters in, may be {@code null}
Review Comment:
Is there a reason why "String" is sometimes linked and sometimes not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #956: Improve JavaDocs
codecov-commenter commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257016163 # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/956?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#956](https://codecov.io/gh/apache/commons-lang/pull/956?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5b3342d) into [master](https://codecov.io/gh/apache/commons-lang/commit/9a52b9c7cd4bf6599510d259ee62b2effcb30bf2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9a52b9c) will **decrease** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #956 +/- ## - Coverage 91.99% 91.99% -0.01% + Complexity 7432 7431 -1 Files 189 189 Lines 1566815668 Branches 2913 2913 - Hits 1441414413 -1 Misses 677 677 - Partials577 578 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/956?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...main/java/org/apache/commons/lang3/ArrayUtils.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQXJyYXlVdGlscy5qYXZh) | `95.71% <ø> (ø)` | | | [...c/main/java/org/apache/commons/lang3/BitField.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQml0RmllbGQuamF2YQ==) | `100.00% <ø> (ø)` | | | [...in/java/org/apache/commons/lang3/BooleanUtils.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQm9vbGVhblV0aWxzLmphdmE=) | `94.94% <ø> (ø)` | | | [.../main/java/org/apache/commons/lang3/CharRange.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclJhbmdlLmphdmE=) | `95.94% <ø> (ø)` | | | [...va/org/apache/commons/lang3/CharSequenceUtils.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclNlcXVlbmNlVXRpbHMuamF2YQ==) | `91.12% <ø> (ø)` | | | [...rc/main/java/org/apache/commons/lang3/CharSet.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclNldC5qYXZh) | `96.36% <ø> (ø)` | | | [...in/java/org/apache/commons/lang3/CharSetUtils.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclNldFV0aWxzLmphdmE=) | `98.21% <ø> (ø)` | | | [.../main/java/org/apache/commons/lang3/CharUtils.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclV0aWxzLmphdmE=) | `100.00% <ø> (ø)` | | | [...c/main/java/org/apache/commons/lang3/Charsets.java](https://codecov.io/gh/apache/commons-lang/pull/956/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhcnNldHMuamF2YQ==) | `75.00% <ø> (ø)` | | |
[GitHub] [commons-lang] arturobernalg commented on pull request #956: Improve JavaDocs
arturobernalg commented on PR #956: URL: https://github.com/apache/commons-lang/pull/956#issuecomment-1257015709 BTW sorry the size of the PR. But IMO it was necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] arturobernalg opened a new pull request, #956: Improve JavaDocs
arturobernalg opened a new pull request, #956: URL: https://github.com/apache/commons-lang/pull/956 Jus add a bunch of javadoc improvement in order to make it more readable when the user search information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609021#comment-17609021
]
Gary D. Gregory commented on DBCP-586:
--
This would not be a security issue. Also, note that
{{BasicDataSource.getConnectionPool()}} is already available from any subclass.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #306: Bump junit-bom from 5.9.0 to 5.9.1
dependabot[bot] opened a new pull request, #306: URL: https://github.com/apache/commons-vfs/pull/306 Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.9.0 to 5.9.1. Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-bom's releases. JUnit 5.9.1 = Platform 1.9.1 + Jupiter 5.9.1 + Vintage 5.9.1 See http://junit.org/junit5/docs/5.9.1/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/732a5400f80c8f446daa8b43eaa4b41b3da929be;>732a540 Release 5.9.1 https://github.com/junit-team/junit5/commit/88bf48d54534b90f74b64b7060f3d09205c9ff9a;>88bf48d Prepare release notes for 5.9.1 https://github.com/junit-team/junit5/commit/d75e34d20f3b9c297b6c38a679888a676f0b92a3;>d75e34d Update scope for 5.9.1 https://github.com/junit-team/junit5/commit/9823f7329a97b4ca6d0922b1c62b6526d615f761;>9823f73 Link to all 5.9 milestone pages https://github.com/junit-team/junit5/commit/76719bb085c1e395824af8d941ed40b9ac359d1d;>76719bb Increase timeout for GraalVM test https://github.com/junit-team/junit5/commit/2a809848e56c7d26b3dbd964a1d99e37ca61acc6;>2a80984 Install GraalVM for main CI build on Linux https://github.com/junit-team/junit5/commit/79f47f51aa8880c78ceeb04e8c837b28d73a2b94;>79f47f5 Refactor OpenTestReportGeneratingListener to work in native images https://github.com/junit-team/junit5/commit/7229385d5edc7f2b78363f8bd0026a86c53bc44e;>7229385 Add failing integration test for execution on GraalVM native image https://github.com/junit-team/junit5/commit/343170f314221ac8d91fea52617234058abfc39a;>343170f Fix running tests in documentation from IntelliJ IDEA https://github.com/junit-team/junit5/commit/352d06b3b27d5f1921dda1876c2dedb6f4f6b70f;>352d06b Attempt to stabilize test on Windows Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.9.0...r5.9.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #305: Bump log4j2.version from 2.18.0 to 2.19.0
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/commons-vfs/pull/305 Bumps `log4j2.version` from 2.18.0 to 2.19.0. Updates `log4j-slf4j-impl` from 2.18.0 to 2.19.0 Updates `log4j-core` from 2.18.0 to 2.19.0 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #304: Bump maven-pmd-plugin from 3.18.0 to 3.19.0
garydgregory merged PR #304: URL: https://github.com/apache/commons-vfs/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #295: Bump slf4j.version from 1.7.36 to 2.0.0
dependabot[bot] commented on PR #295: URL: https://github.com/apache/commons-vfs/pull/295#issuecomment-1256999640 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #295: Bump slf4j.version from 1.7.36 to 2.0.0
garydgregory closed pull request #295: Bump slf4j.version from 1.7.36 to 2.0.0 URL: https://github.com/apache/commons-vfs/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #295: Bump slf4j.version from 1.7.36 to 2.0.0
garydgregory commented on PR #295: URL: https://github.com/apache/commons-vfs/pull/295#issuecomment-1256999635 Close: Do this later and let Dependabot test other deps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #304: Bump maven-pmd-plugin from 3.18.0 to 3.19.0
dependabot[bot] opened a new pull request, #304: URL: https://github.com/apache/commons-vfs/pull/304 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.18.0 to 3.19.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases;>maven-pmd-plugin's releases. 3.19.0 Bug Fixes https://issues.apache.org/jira/browse/MPMD-353;>[MPMD-353] - API incompatibility with jansi after upgrading m-shared-… (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/91;>#91) https://github.com/adangel;>@adangel Dependency updates Bump animal-sniffer-maven-plugin from 1.21 to 1.22 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/88;>#88) https://github.com/dependabot;>@dependabot Bump wiremock from 1.49 to 2.27.2 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/57;>#57) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MPMD-354;>[MPMD-354] - Upgrade to PMD 6.49.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/92;>#92) https://github.com/adangel;>@adangel Bump release-drafter/release-drafter from 5.20.0 to 5.20.1 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/86;>#86) https://github.com/dependabot;>@dependabot Commits https://github.com/apache/maven-pmd-plugin/commit/7033e9d80f30ac57699aa913b0adb0aa31c381a2;>7033e9d [maven-release-plugin] prepare release maven-pmd-plugin-3.19.0 https://github.com/apache/maven-pmd-plugin/commit/0781fc8182c24f313d94aa078e53a7e4289200bb;>0781fc8 (doc) Update release notes [skip ci] https://github.com/apache/maven-pmd-plugin/commit/d9be919d0ec44b8c9c6f40acf76a888a99a35489;>d9be919 (doc) Update releasenotes.md https://github.com/apache/maven-pmd-plugin/commit/e8b49f4a4b9b62e8addd2bdd6bf85fc7b6957161;>e8b49f4 Bump animal-sniffer-maven-plugin from 1.21 to 1.22 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/88;>#88) https://github.com/apache/maven-pmd-plugin/commit/68b7ed94fe6580ce647501226eeddf6fd23a9c99;>68b7ed9 Bump wiremock from 1.49 to 2.27.2 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/57;>#57) https://github.com/apache/maven-pmd-plugin/commit/ebd3579da3099ab558e4414029ae2149eebc4178;>ebd3579 [MPMD-354] - Upgrade to PMD 6.49.0 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/92;>#92) https://github.com/apache/maven-pmd-plugin/commit/7b4c330399faa65b8800b6a3dfd9d60a661178b8;>7b4c330 [MPMD-353] - API incompatibility with jansi after upgrading m-shared-utils (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/91;>#91) https://github.com/apache/maven-pmd-plugin/commit/1d7a2fbff87b5f4b85a134d3c5ed9fed7bf3ad38;>1d7a2fb Set next dev version to 3.19.0-SNAPSHOT https://github.com/apache/maven-pmd-plugin/commit/584ac6dadab23e1c08399d9a6a89b5b0de7b3726;>584ac6d Bump release-drafter/release-drafter from 5.20.0 to 5.20.1 (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/86;>#86) https://github.com/apache/maven-pmd-plugin/commit/b55fb9a215ce37f47729e4aec92c813a3d597bf2;>b55fb9a (doc) Update releasenotes.md Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.18.0...maven-pmd-plugin-3.19.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #303: Bump spotbugs from 4.7.1 to 4.7.2
dependabot[bot] commented on PR #303: URL: https://github.com/apache/commons-vfs/pull/303#issuecomment-1256999543 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory closed pull request #303: Bump spotbugs from 4.7.1 to 4.7.2
garydgregory closed pull request #303: Bump spotbugs from 4.7.1 to 4.7.2 URL: https://github.com/apache/commons-vfs/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #303: Bump spotbugs from 4.7.1 to 4.7.2
garydgregory commented on PR #303: URL: https://github.com/apache/commons-vfs/pull/303#issuecomment-1256999518 Closing: Already done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609015#comment-17609015
]
Thomas Freller commented on DBCP-586:
-
Yes this would be great
But do you relay want to grant access to the ConnecitonPool or would it be
better to implement
{code:java}
public String getStatsString(){
return this.getConnecitonPool().getStatsString();
// or
// return this.getConnectionPool().toString();
}{code}
I address this because I want to keep the security of the Lib as high as
possible and don't want do open any issues. If getConnecitonPool() as public is
no problem, then I'm fine with this solution.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (POOL-409) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/POOL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609014#comment-17609014
]
Thomas Freller commented on POOL-409:
-
I've done a bit of testing and built a own class in my package called
BasicDataSourceEnh. This Class inherit BasicDataSource and looks like the
following Code
{code:java}
public class BasicDataSourceEnh extends BasicDataSource{
public BasicDataSourceEnh(){
super();
}
public String getInfo(){
return super.getConnectionPool().toString();
}
}{code}
So I'm able to use the Hint you gave to me. The Output is very interesting and
cause even a Exception so something is going wrong in pool2
Here is the output.
{code:java}
17:28:29.552 [main] INFO myClass.Worker - Current DBPool Stats Active
(current/max): 0/5 Idle (min/current/max): 0/0/0
< Output of getInfo() >
GenericObjectPool [maxTotal=5, blockWhenExhausted=true,
maxWaitDuration=PT-0.001S, lifo=true, fairness=false, testOnCreate=false,
testOnBorrow=true, testOnReturn=false, testWhileIdle=false,
durationBetweenEvictionRuns=PT10S, numTestsPerEvictionRun=3,
minEvictableIdleTimeDuration=PT30S, softMinEvictableIdleTimeDuration=PT-0.001S,
evictionPolicy=org.apache.commons.pool2.impl.DefaultEvictionPolicy@6d026701,
closeLock=java.lang.Object@78aa1f72, closed=false,
evictionLock=java.lang.Object@1f75a668,
evictor=org.apache.commons.pool2.impl.BaseGenericObjectPool$Evictor@35399441,
evictionIterator=null, factoryClassLoader=java.lang.ref.WeakReference@4b7dc788,
oname=null, creationStackTrace=java.lang.Exception
at
org.apache.commons.pool2.impl.BaseGenericObjectPool.(BaseGenericObjectPool.java:407)
at
org.apache.commons.pool2.impl.GenericObjectPool.(GenericObjectPool.java:147)
at
org.apache.commons.dbcp2.BasicDataSource.createObjectPool(BasicDataSource.java:611)
at
org.apache.commons.dbcp2.BasicDataSource.createConnectionPool(BasicDataSource.java:480)
at
org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:543)
at
org.apache.commons.dbcp2.BasicDataSource.setLogWriter(BasicDataSource.java:2055)
at db_pool.MySQLConPool.(MySQLConPool.java:55)
at ssl_worker.SSL_Worker.main(Worker.java:177)
, borrowedCount=38, returnedCount=38, createdCount=38, destroyedCount=38,
destroyedByEvictorCount=0, destroyedByBorrowValidationCount=0,
activeTimes=StatsStore [[24, 9, 10, 12, 9, 10, 9, 10, 10, 11, 11, 10, 12, 14,
15, 20, 11, 1003, 0, 26, 7, 15, 15, 11, 21, 11, 11, 11, 11, 12, 13, 10, 11, 13,
12, 13, 1004, 1]], size=100, index=38], idleTimes=StatsStore [[4, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0]], size=100, index=38], waitTimes=StatsStore [[8, 5, 3, 8,
2, 3, 4, 3, 5, 3, 2, 2, 2, 1, 8, 2, 4, 3, 3, 3, 10, 4, 3, 5, 7, 2, 3, 2, 4, 2,
1, 3, 3, 2, 2, 5, 2, 3]], size=100, index=38], maxBorrowWaitDuration=PT0.01S,
swallowedExceptionListener=org.apache.commons.dbcp2.SwallowedExceptionLogger@6304101a,
factoryType=null, maxIdle=0, minIdle=0,
factory=org.apache.commons.dbcp2.PoolableConniectionFactory@5170bcf4,
allObjects={}, createCount=0, idleObjects=[], abandonedConfig=null]{code}
As you can see there are a few problems:
* org.apache.commons.pool2.impl.DefaultEvictionPolicy@6d026701 => consider
to implement toString() => not Critical to me (only hint)
* org.apache.commons.pool2.impl.BaseGenericObjectPool$Evictor@35399441
=>consider to implement toString() => not Critical to me (only hint)
* java.lang.ref.WeakReference@4b7dc788 =>Problem of Java not yours => not
Critical to me#
* (!){color:#de350b} *Im worry about the Stack Trace* {color:#172b4d}is this
something critical or a problem of the Class loader or is there a Exception
printed? This is confusing to me.{color}{color}
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: POOL-409
> URL: https://issues.apache.org/jira/browse/POOL-409
> Project: Commons Pool
> Issue Type: Improvement
>Affects Versions: 2.11.1
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
>
[jira] [Comment Edited] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609011#comment-17609011
]
Gary D. Gregory edited comment on DBCP-586 at 9/24/22 3:19 PM:
---
Hm, ok, then BasicDataSource.getConnectionPool() could be made public from
protected, then you can say BasicDataSource.getConnectionPool().toString().
was (Author: garydgregory):
Hm, ok, then BasicDataSource.getConnectionPool() could be made public from
protected.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609011#comment-17609011
]
Gary D. Gregory commented on DBCP-586:
--
Hm, ok, then BasicDataSource.getConnectionPool() could be made public.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609011#comment-17609011
]
Gary D. Gregory edited comment on DBCP-586 at 9/24/22 3:18 PM:
---
Hm, ok, then BasicDataSource.getConnectionPool() could be made public from
protected.
was (Author: garydgregory):
Hm, ok, then BasicDataSource.getConnectionPool() could be made public.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609010#comment-17609010
]
Thomas Freller commented on DBCP-586:
-
As far as I've seen currently
BasicDataSource.getConnectionPool() is protected and so not callable outside of
the org.apache.commons.dbcp2 package.
Please check if this would be a good solution if this method would be public
because then this object could be modified.
For me a getter to getStatsString() would be enough.
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (DBCP-586) BasicDataSource should support GenericObjectPool->getStatsString()
[
https://issues.apache.org/jira/browse/DBCP-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Freller reopened DBCP-586:
-
> BasicDataSource should support GenericObjectPool->getStatsString()
> --
>
> Key: DBCP-586
> URL: https://issues.apache.org/jira/browse/DBCP-586
> Project: Commons DBCP
> Issue Type: Improvement
>Affects Versions: 2.9.0
>Reporter: Thomas Freller
>Priority: Major
> Labels: improvement
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hello,
> I'm developing a Application that is running on a default JRE without an
> Webserver/JMX.
> For optimizing Database connections it would be very useful if i could access
>
> BasicDataSource->GenericObjectPool->{*}getStatsString(){*}
>
> I don't see any reason why this Method is protected and not public in
> GenericObjectPool.
> Then BasicDataSource shoud provide a method getStatsString() or the values
> that represent the statistic data.
>
> If there is any other easy way to access this data within my Java Code I'll
> implement this if you could give me an example how to get this working
> easily. I don't want do configure any jmx stuff.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (LANG-1692) Cast FieldUtils.readField result to the recipient type
[
https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=811812=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811812
]
ASF GitHub Bot logged work on LANG-1692:
Author: ASF GitHub Bot
Created on: 24/Sep/22 08:20
Start Date: 24/Sep/22 08:20
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979196665
##
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##
@@ -110,8 +110,9 @@ private void appendFields(final Class clazz) {
for (final Field field : FieldUtils.getAllFields(clazz)) {
if (accept(field)) {
try {
-diffBuilder.append(field.getName(), readField(field, left,
true),
-readField(field, right, true));
+Object leftObject = readField(field, left, true);
Review Comment:
```
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/Users/chenzili/Brittani/commons-lang/src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:[113,32]
reference to append is ambiguous
both method append(java.lang.String,short[],short[]) in
org.apache.commons.lang3.builder.DiffBuilder and method
append(java.lang.String,java.lang.Object[],java.lang.Object[]) in
org.apache.commons.lang3.builder.DiffBuilder match
```
Issue Time Tracking
---
Worklog Id: (was: 811812)
Time Spent: 2h 40m (was: 2.5h)
> Cast FieldUtils.readField result to the recipient type
> --
>
> Key: LANG-1692
> URL: https://issues.apache.org/jira/browse/LANG-1692
> Project: Commons Lang
> Issue Type: Task
> Components: lang.reflect.*
>Reporter: Zili Chen
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] tisonkun commented on a diff in pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type
tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979196665
##
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##
@@ -110,8 +110,9 @@ private void appendFields(final Class clazz) {
for (final Field field : FieldUtils.getAllFields(clazz)) {
if (accept(field)) {
try {
-diffBuilder.append(field.getName(), readField(field, left,
true),
-readField(field, right, true));
+Object leftObject = readField(field, left, true);
Review Comment:
```
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/Users/chenzili/Brittani/commons-lang/src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:[113,32]
reference to append is ambiguous
both method append(java.lang.String,short[],short[]) in
org.apache.commons.lang3.builder.DiffBuilder and method
append(java.lang.String,java.lang.Object[],java.lang.Object[]) in
org.apache.commons.lang3.builder.DiffBuilder match
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1692) Cast FieldUtils.readField result to the recipient type
[
https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=811811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811811
]
ASF GitHub Bot logged work on LANG-1692:
Author: ASF GitHub Bot
Created on: 24/Sep/22 08:16
Start Date: 24/Sep/22 08:16
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979195492
##
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##
@@ -110,8 +110,9 @@ private void appendFields(final Class clazz) {
for (final Field field : FieldUtils.getAllFields(clazz)) {
if (accept(field)) {
try {
-diffBuilder.append(field.getName(), readField(field, left,
true),
-readField(field, right, true));
+Object leftObject = readField(field, left, true);
Review Comment:
https://user-images.githubusercontent.com/18818196/192087964-342f0e2d-57ab-4d45-8ade-51aa183c1482.png;>
Issue Time Tracking
---
Worklog Id: (was: 811811)
Time Spent: 2.5h (was: 2h 20m)
> Cast FieldUtils.readField result to the recipient type
> --
>
> Key: LANG-1692
> URL: https://issues.apache.org/jira/browse/LANG-1692
> Project: Commons Lang
> Issue Type: Task
> Components: lang.reflect.*
>Reporter: Zili Chen
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] tisonkun commented on a diff in pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type
tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979195492
##
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##
@@ -110,8 +110,9 @@ private void appendFields(final Class clazz) {
for (final Field field : FieldUtils.getAllFields(clazz)) {
if (accept(field)) {
try {
-diffBuilder.append(field.getName(), readField(field, left,
true),
-readField(field, right, true));
+Object leftObject = readField(field, left, true);
Review Comment:
https://user-images.githubusercontent.com/18818196/192087964-342f0e2d-57ab-4d45-8ade-51aa183c1482.png;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1692) Cast FieldUtils.readField result to the recipient type
[ https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=811810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811810 ] ASF GitHub Bot logged work on LANG-1692: Author: ASF GitHub Bot Created on: 24/Sep/22 08:14 Start Date: 24/Sep/22 08:14 Worklog Time Spent: 10m Work Description: tisonkun commented on PR #951: URL: https://github.com/apache/commons-lang/pull/951#issuecomment-1256904897 Tests added. Issue Time Tracking --- Worklog Id: (was: 811810) Time Spent: 2h 20m (was: 2h 10m) > Cast FieldUtils.readField result to the recipient type > -- > > Key: LANG-1692 > URL: https://issues.apache.org/jira/browse/LANG-1692 > Project: Commons Lang > Issue Type: Task > Components: lang.reflect.* >Reporter: Zili Chen >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-lang] tisonkun commented on pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type
tisonkun commented on PR #951: URL: https://github.com/apache/commons-lang/pull/951#issuecomment-1256904897 Tests added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1692) Cast FieldUtils.readField result to the recipient type
[
https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=811809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811809
]
ASF GitHub Bot logged work on LANG-1692:
Author: ASF GitHub Bot
Created on: 24/Sep/22 08:00
Start Date: 24/Sep/22 08:00
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979191525
##
src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java:
##
@@ -254,23 +254,23 @@ public static List
getFieldsListWithAnnotation(final Class cls, final
/**
* Reads an accessible {@code static} {@link Field}.
*
- * @param field
Review Comment:
Oops. I think I should add the `@param ` line so adjusting neighbor lines
should be OK. Said you're updating the comments, and adjusting a bit the layout
should not be a big deal. I don't touch unrelated comments.
Issue Time Tracking
---
Worklog Id: (was: 811809)
Time Spent: 2h 10m (was: 2h)
> Cast FieldUtils.readField result to the recipient type
> --
>
> Key: LANG-1692
> URL: https://issues.apache.org/jira/browse/LANG-1692
> Project: Commons Lang
> Issue Type: Task
> Components: lang.reflect.*
>Reporter: Zili Chen
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] tisonkun commented on a diff in pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type
tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979191525
##
src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java:
##
@@ -254,23 +254,23 @@ public static List
getFieldsListWithAnnotation(final Class cls, final
/**
* Reads an accessible {@code static} {@link Field}.
*
- * @param field
Review Comment:
Oops. I think I should add the `@param ` line so adjusting neighbor lines
should be OK. Said you're updating the comments, and adjusting a bit the layout
should not be a big deal. I don't touch unrelated comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1692) Cast FieldUtils.readField result to the recipient type
[
https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=811807=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811807
]
ASF GitHub Bot logged work on LANG-1692:
Author: ASF GitHub Bot
Created on: 24/Sep/22 07:58
Start Date: 24/Sep/22 07:58
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979191073
##
src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java:
##
@@ -254,23 +254,23 @@ public static List
getFieldsListWithAnnotation(final Class cls, final
/**
* Reads an accessible {@code static} {@link Field}.
*
- * @param field
Review Comment:
Reverting...
Issue Time Tracking
---
Worklog Id: (was: 811807)
Time Spent: 2h (was: 1h 50m)
> Cast FieldUtils.readField result to the recipient type
> --
>
> Key: LANG-1692
> URL: https://issues.apache.org/jira/browse/LANG-1692
> Project: Commons Lang
> Issue Type: Task
> Components: lang.reflect.*
>Reporter: Zili Chen
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [commons-lang] tisonkun commented on a diff in pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type
tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r979191073
##
src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java:
##
@@ -254,23 +254,23 @@ public static List
getFieldsListWithAnnotation(final Class cls, final
/**
* Reads an accessible {@code static} {@link Field}.
*
- * @param field
Review Comment:
Reverting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
