[GitHub] [commons-configuration] BranislavBeno commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-11-06 Thread GitBox


BranislavBeno commented on PR #229:
URL: 
https://github.com/apache/commons-configuration/pull/229#issuecomment-1305180959

   > I might update the constructor after a merge to be private and use a 
builder to avoid the proliferation of constructors...
   
   Thank you for PR accepting.
   Builder usage makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #84: Bump jackson-core from 2.13.4 to 2.14.0

2022-11-06 Thread GitBox


dependabot[bot] opened a new pull request, #84:
URL: https://github.com/apache/commons-scxml/pull/84

   Bumps [jackson-core](https://github.com/FasterXML/jackson-core) from 2.13.4 
to 2.14.0.
   
   Commits
   
   https://github.com/FasterXML/jackson-core/commit/97ca01b5341ec71f6845066285e9775c2eb99dec;>97ca01b
 [maven-release-plugin] prepare release jackson-core-2.14.0
   https://github.com/FasterXML/jackson-core/commit/ea15e3172d6da6431a74750646ce870a37eef4b5;>ea15e31
 Prepare for 2.14.0
   https://github.com/FasterXML/jackson-core/commit/0d48020b844617789439e03b822d30917b030e80;>0d48020
 Fix https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/834;>#834
 (rare buffer condition for number-parsing, found by oss-fuzz project)
   https://github.com/FasterXML/jackson-core/commit/2e2cff051cc333a15878f5cf91131203e01f64fa;>2e2cff0
 back to snapshot deps
   https://github.com/FasterXML/jackson-core/commit/37c7c4fbf709c0099f8bc351eeb3d9b7ac16f22b;>37c7c4f
 [maven-release-plugin] prepare for next development iteration
   https://github.com/FasterXML/jackson-core/commit/597e82359ad730245e2d45250ef5e8aaea28adbc;>597e823
 [maven-release-plugin] prepare release jackson-core-2.14.0-rc3
   https://github.com/FasterXML/jackson-core/commit/f9930696baeb23987a1b4b1166c35786a636fb64;>f993069
 ...
   https://github.com/FasterXML/jackson-core/commit/5c1e5593c3d65edfd2059d611baae90a38428a47;>5c1e559
 Prepare for 2.14.0-rc3
   https://github.com/FasterXML/jackson-core/commit/5a6215a8f400caab97f6cc29e1c11f05aa7c8d11;>5a6215a
 Tiny upgrade to Github/CI
   https://github.com/FasterXML/jackson-core/commit/a1e1b8af573f84c191daa677bdde6d7d054c0636;>a1e1b8a
 Bump actions/upload-artifact from 1 to 3 (https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/831;>#831)
   Additional commits viewable in https://github.com/FasterXML/jackson-core/compare/jackson-core-2.13.4...jackson-core-2.14.0;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jackson.core:jackson-core=maven=2.13.4=2.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-scxml] dependabot[bot] closed pull request #77: Bump jackson-databind from 2.13.4 to 2.13.4.2

2022-11-06 Thread GitBox


dependabot[bot] closed pull request #77: Bump jackson-databind from 2.13.4 to 
2.13.4.2
URL: https://github.com/apache/commons-scxml/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-scxml] dependabot[bot] commented on pull request #77: Bump jackson-databind from 2.13.4 to 2.13.4.2

2022-11-06 Thread GitBox


dependabot[bot] commented on PR #77:
URL: https://github.com/apache/commons-scxml/pull/77#issuecomment-1304933341

   Superseded by #83.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-scxml] dependabot[bot] opened a new pull request, #83: Bump jackson-databind from 2.13.4 to 2.14.0

2022-11-06 Thread GitBox


dependabot[bot] opened a new pull request, #83:
URL: https://github.com/apache/commons-scxml/pull/83

   Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.13.4 
to 2.14.0.
   
   Commits
   
   See full diff in https://github.com/FasterXML/jackson/commits;>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jackson.core:jackson-databind=maven=2.13.4=2.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-geometry] darkma773r merged pull request #200: Adding maven.compiler.release property

2022-11-06 Thread GitBox


darkma773r merged PR #200:
URL: https://github.com/apache/commons-geometry/pull/200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-configuration] garydgregory merged pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-11-06 Thread GitBox


garydgregory merged PR #229:
URL: https://github.com/apache/commons-configuration/pull/229


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-configuration] garydgregory commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-11-06 Thread GitBox


garydgregory commented on PR #229:
URL: 
https://github.com/apache/commons-configuration/pull/229#issuecomment-1304882704

   I think I might update the ctor after a merge to be private and use a 
builder to avoid the proliferation of contructors...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-vfs] garydgregory merged pull request #331: Bump spotbugs-maven-plugin from 4.7.2.0 to 4.7.2.2

2022-11-06 Thread GitBox


garydgregory merged PR #331:
URL: https://github.com/apache/commons-vfs/pull/331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-configuration] garydgregory commented on pull request #37: Configuration-766: BigDecimal(double) should not be used.

2022-11-06 Thread GitBox


garydgregory commented on PR #37:
URL: 
https://github.com/apache/commons-configuration/pull/37#issuecomment-1304877018

   @HarisAdzemovic ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-parent] garydgregory merged pull request #170: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.2.2

2022-11-06 Thread GitBox


garydgregory merged PR #170:
URL: https://github.com/apache/commons-parent/pull/170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-parent] dependabot[bot] opened a new pull request, #170: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.2.2

2022-11-06 Thread GitBox


dependabot[bot] opened a new pull request, #170:
URL: https://github.com/apache/commons-parent/pull/170

   Bumps 
[spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 
4.7.2.1 to 4.7.2.2.
   
   Release notes
   Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's
 releases.
   
   Spotbugs Maven Plugin 4.7.2.2
   
   Groovy bumped to 4.0.6
   Make sarifOutputDirectory and sarifOutputFilename configurable per https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/506;>#506
 and https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/507;>#507
   
   
   
   
   Commits
   
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/f8450ddacc7328075693c6e56d3cdb2844767d1c;>f8450dd
 [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.2.2
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/24a8bb294680413a781efdbf73735b763830860c;>24a8bb2
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/508;>#508
 from jwgmeligmeyling/issues/506-507
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/e148e19538bccf78a215e95f520274a7a249839b;>e148e19
 Make sarifOutputDirectory and sarifOutputFilename configurable
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/f01a7f6b99da3d2e6dcdbddd20f0b4e4dfac73fa;>f01a7f6
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/504;>#504
 from spotbugs/renovate/versionspluginversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/717ab1ec1f3aec7a5131a4c561942756b456c09a;>717ab1e
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/503;>#503
 from spotbugs/renovate/plexusutilsversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/a01ef40e5a6ffd2deff1f125b717396b671f1536;>a01ef40
 Update dependency org.codehaus.mojo:versions-maven-plugin to v2.13.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/2819833db11eb8fc93515582caa8c2a25b9f983e;>2819833
 Update dependency org.codehaus.plexus:plexus-utils to v3.5.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/c6fa68e005212eae0ead0648592616cae16a4ac0;>c6fa68e
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/502;>#502
 from spotbugs/renovate/gmavenpluginversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/a5a68a70fe4f53edc673e35e7148b2b953d1407d;>a5a68a7
 Update dependency org.codehaus.gmavenplus:gmavenplus-plugin to v2.1.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/d168f14506c6ed7ccad7742a744a2f2c96f02469;>d168f14
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/500;>#500
 from spotbugs/renovate/spotbugsversion
   Additional commits viewable in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.7.2.1...spotbugs-maven-plugin-4.7.2.2;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spotbugs:spotbugs-maven-plugin=maven=4.7.2.1=4.7.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to 

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #331: Bump spotbugs-maven-plugin from 4.7.2.0 to 4.7.2.2

2022-11-06 Thread GitBox


dependabot[bot] opened a new pull request, #331:
URL: https://github.com/apache/commons-vfs/pull/331

   Bumps 
[spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 
4.7.2.0 to 4.7.2.2.
   
   Release notes
   Sourced from https://github.com/spotbugs/spotbugs-maven-plugin/releases;>spotbugs-maven-plugin's
 releases.
   
   Spotbugs Maven Plugin 4.7.2.2
   
   Groovy bumped to 4.0.6
   Make sarifOutputDirectory and sarifOutputFilename configurable per https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/506;>#506
 and https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/507;>#507
   
   Spotbugs Maven Plugin 4.7.2.1
   
   Bumps groovy to 4.0.5
   Bumps asm to 9.4
   
   Build Related
   
   For reproducible builds, timestamp is now more accurate to the 
release.
   
   
   
   
   Commits
   
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/f8450ddacc7328075693c6e56d3cdb2844767d1c;>f8450dd
 [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.2.2
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/24a8bb294680413a781efdbf73735b763830860c;>24a8bb2
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/508;>#508
 from jwgmeligmeyling/issues/506-507
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/e148e19538bccf78a215e95f520274a7a249839b;>e148e19
 Make sarifOutputDirectory and sarifOutputFilename configurable
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/f01a7f6b99da3d2e6dcdbddd20f0b4e4dfac73fa;>f01a7f6
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/504;>#504
 from spotbugs/renovate/versionspluginversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/717ab1ec1f3aec7a5131a4c561942756b456c09a;>717ab1e
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/503;>#503
 from spotbugs/renovate/plexusutilsversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/a01ef40e5a6ffd2deff1f125b717396b671f1536;>a01ef40
 Update dependency org.codehaus.mojo:versions-maven-plugin to v2.13.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/2819833db11eb8fc93515582caa8c2a25b9f983e;>2819833
 Update dependency org.codehaus.plexus:plexus-utils to v3.5.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/c6fa68e005212eae0ead0648592616cae16a4ac0;>c6fa68e
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/502;>#502
 from spotbugs/renovate/gmavenpluginversion
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/a5a68a70fe4f53edc673e35e7148b2b953d1407d;>a5a68a7
 Update dependency org.codehaus.gmavenplus:gmavenplus-plugin to v2.1.0
   https://github.com/spotbugs/spotbugs-maven-plugin/commit/d168f14506c6ed7ccad7742a744a2f2c96f02469;>d168f14
 Merge pull request https://github-redirect.dependabot.com/spotbugs/spotbugs-maven-plugin/issues/500;>#500
 from spotbugs/renovate/spotbugsversion
   Additional commits viewable in https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.7.2.0...spotbugs-maven-plugin-4.7.2.2;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spotbugs:spotbugs-maven-plugin=maven=4.7.2.0=4.7.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot 

[GitHub] [commons-vfs] dependabot[bot] commented on pull request #330: Bump checkstyle from 9.3 to 10.4

2022-11-06 Thread GitBox


dependabot[bot] commented on PR #330:
URL: https://github.com/apache/commons-vfs/pull/330#issuecomment-1304873178

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-vfs] garydgregory closed pull request #330: Bump checkstyle from 9.3 to 10.4

2022-11-06 Thread GitBox


garydgregory closed pull request #330: Bump checkstyle from 9.3 to 10.4
URL: https://github.com/apache/commons-vfs/pull/330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-vfs] garydgregory commented on pull request #330: Bump checkstyle from 9.3 to 10.4

2022-11-06 Thread GitBox


garydgregory commented on PR #330:
URL: https://github.com/apache/commons-vfs/pull/330#issuecomment-1304873173

   Close: Requires Java 11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-bcel] garydgregory merged pull request #165: code coverage and assertions

2022-11-06 Thread GitBox


garydgregory merged PR #165:
URL: https://github.com/apache/commons-bcel/pull/165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-validator] apervushin closed pull request #99: CreditCardValidator. Added MIR cards support

2022-11-06 Thread GitBox


apervushin closed pull request #99: CreditCardValidator. Added MIR cards support
URL: https://github.com/apache/commons-validator/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] lexasub closed pull request #322: do refactoring

2022-11-06 Thread GitBox


lexasub closed pull request #322: do refactoring
URL: https://github.com/apache/commons-collections/pull/322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #165: code coverage and assertions

2022-11-06 Thread GitBox


nbauma109 commented on code in PR #165:
URL: https://github.com/apache/commons-bcel/pull/165#discussion_r1014861471


##
src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.apache.bcel.classfile.Code;
+import org.apache.bcel.classfile.JavaClass;
+import org.apache.bcel.classfile.Method;
+import org.apache.bcel.util.SyntheticRepository;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+import java.awt.Color;
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.Map;
+
+class EmptyVisitorTestCase {
+
+/*
+ * https://docs.oracle.com/javase/specs/jvms/se17/html/jvms-6.html#jvms-6.2
+ */
+private static final String RESERVED_OPCODE = "Reserved opcode";
+
+@ParameterizedTest
+@ValueSource(classes = { BigInteger.class, BigDecimal.class, Color.class, 
Map.class })

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #165: code coverage and assertions

2022-11-06 Thread GitBox


nbauma109 commented on code in PR #165:
URL: https://github.com/apache/commons-bcel/pull/165#discussion_r1014861436


##
src/test/java/org/apache/bcel/classfile/ConstantPoolModuleToStringTestCase.java:
##
@@ -353,19 +400,50 @@ public void visitUnknown(final Unknown obj) {
 "src/test/resources/jpms/java18/commons-io/module-info.class",
 "src/test/resources/jpms/java19-ea/commons-io/module-info.class"})
 // @formatter:on
-public void test(final String first) throws Exception {
+void test(final String first) throws Exception {
 try (final InputStream inputStream = 
Files.newInputStream(Paths.get(first))) {
-final ClassParser classParser = new ClassParser(inputStream, 
"module-info.class");
-final JavaClass javaClass = classParser.parse();
-final ConstantPool constantPool = javaClass.getConstantPool();
-final ToStringVisitor visitor = new ToStringVisitor(constantPool);
-final DescendingVisitor descendingVisitor = new 
DescendingVisitor(javaClass, visitor);
-try {
-javaClass.accept(descendingVisitor);
-} catch (Exception | Error e) {
-fail(visitor.toString(), e);
+test(inputStream);
+}
+}
+
+@Test
+void test() throws Exception {
+final Enumeration moduleURLs = 
getClass().getClassLoader().getResources("module-info.class");
+while (moduleURLs.hasMoreElements()) {
+final URL url = moduleURLs.nextElement();
+try (InputStream inputStream = url.openStream()) {
+test(inputStream);
 }
 }
 }
 
+@ParameterizedTest
+@ValueSource(strings = {
+// @formatter:off
+"org.apache.commons.lang3.function.TriFunction",

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] Claudenw opened a new pull request, #358: Reworked calculations and updated javadoc.

2022-11-06 Thread GitBox


Claudenw opened a new pull request, #358:
URL: https://github.com/apache/commons-collections/pull/358

   Fix for COLLECTIONS-817
   
   Added documentation concerning n(), intersection, and union calculations in 
Shape class.
   
   Modified BloomFilter.estimatedIntersection() to account for infinite values 
in calculations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (JEXL-383) Inconsistent behavior after overriding toBoolean method in JexlArithmetic

2022-11-06 Thread Xu Pengcheng (Jira)


[ 
https://issues.apache.org/jira/browse/JEXL-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629497#comment-17629497
 ] 

Xu Pengcheng commented on JEXL-383:
---

Thanks!

Looks like  isStrict(JexlOperator operator) api of JexlArithmetic is not in 
3.2.1, what is the next release time?

> Inconsistent behavior after overriding toBoolean method in JexlArithmetic
> -
>
> Key: JEXL-383
> URL: https://issues.apache.org/jira/browse/JEXL-383
> Project: Commons JEXL
>  Issue Type: Bug
>Affects Versions: 3.2.1
>Reporter: Xu Pengcheng
>Assignee: Henri Biestro
>Priority: Major
> Fix For: 3.3
>
>
> I tried to overriding "toBoolean" method of JexlArithmetic for 'strict' mode.
> {code:java}
> @Override
> public boolean toBoolean(final Object val) {
>   if (val == null) {
> return false;
>   } else {
> return super.toBoolean(val);
>   }
> } {code}
>  while executing code:
> parameters:
> {code:java}
> a: null
> {code}
> but while executing scripts, the behavior is inconsistent
> {code:java}
> if (a) return 1 else return 2;  // returns 2
> if (!a) return 1 else return 2; // expects return 1 but throws exception: 
> variable 'a' is null{code}
>  
> what should I do to fix it? thanks!
> -Pengcheng
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [commons-collections] garydgregory commented on pull request #322: do refactoring

2022-11-06 Thread GitBox


garydgregory commented on PR #322:
URL: 
https://github.com/apache/commons-collections/pull/322#issuecomment-1304820002

   Hi @lexasub 
   The Bloom filter package is being actively developed ATM, so this PR is 
clashing with on-going work. Sorry about that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] garydgregory merged pull request #323: Fix minor typos

2022-11-06 Thread GitBox


garydgregory merged PR #323:
URL: https://github.com/apache/commons-collections/pull/323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (COMPRESS-630) Documentation of Commons Compress 1.22 is missing on the web site

2022-11-06 Thread Gary D. Gregory (Jira)


 [ 
https://issues.apache.org/jira/browse/COMPRESS-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary D. Gregory resolved COMPRESS-630.
--
Fix Version/s: 1.22
   Resolution: Fixed

Please see [https://commons.apache.org/proper/commons-compress/jira-report.html]

 

> Documentation of Commons Compress 1.22 is missing on the web site
> -
>
> Key: COMPRESS-630
> URL: https://issues.apache.org/jira/browse/COMPRESS-630
> Project: Commons Compress
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 1.22
>Reporter: Christoph Ludwig
>Priority: Minor
> Fix For: 1.22
>
>
> Hi,
> on Oct 31, 
> [org.apache.commons:commons-compress:1.22|https://mvnrepository.com/artifact/org.apache.commons/commons-compress/1.22]
>  was pushed to Maven Central. In consequence, tools like RenovateBot started 
> creating merge requests for upgrades to the new version.
> However, the new version is not mentioned on the [project's 
> website|https://commons.apache.org/proper/commons-compress/] yet. Therefore, 
> it's not clear what changed in 1.22 and whether the artifacts on Maven 
> Central do in fact belong to a legitimate release.
> Can you please add the changelog etc. to the web page? Thanks!
> Cheers,
> Christoph



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [commons-collections] garydgregory commented on pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


garydgregory commented on PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#issuecomment-1304803054

   Hm, `HasherCollection` is not a `Collection`, instead it is a `List` 
wrapper, so I suggest it be renamed `HasherList` and that it implements 
`Iterable`. WDYT? It seems to heavy to implement `List` itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] garydgregory commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


garydgregory commented on code in PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#discussion_r1014829652


##
src/test/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasherTest.java:
##
@@ -52,6 +53,11 @@ protected int getHasherSize(Hasher hasher) {
 return 1;
 }
 
+@Override
+public void testIsEmpty() {
+assertFalse( createHasher().isEmpty() );

Review Comment:
   No extra spaces around parens.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-net] garydgregory closed pull request #117: Better readability of SubnetInfo.toString()

2022-11-06 Thread GitBox


garydgregory closed pull request #117: Better readability of 
SubnetInfo.toString()
URL: https://github.com/apache/commons-net/pull/117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #117: Better readability of SubnetInfo.toString()

2022-11-06 Thread GitBox


garydgregory commented on PR #117:
URL: https://github.com/apache/commons-net/pull/117#issuecomment-1304791705

   Done differently in git master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] kinow commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


kinow commented on code in PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#discussion_r1014811662


##
src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java:
##
@@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {
 this(Arrays.asList(hashers));
 }
 
+@Override
+public boolean isEmpty() {
+for (Hasher h : hashers) {
+if (!h.isEmpty()) {
+return false;
+}
+}
+return true;

Review Comment:
   Out of the loop, so can't comment on the addition of that method, but the 
rest of the code looks Ok :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] kinow commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


kinow commented on code in PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#discussion_r1014810859


##
src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java:
##
@@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {
 this(Arrays.asList(hashers));
 }
 
+@Override
+public boolean isEmpty() {
+for (Hasher h : hashers) {
+if (!h.isEmpty()) {
+return false;
+}
+}
+return true;

Review Comment:
   Bit rusty in Java & streams, but I **think** this is equivalent to:
   
   ```java
   return hashers.stream().noneMatch(Hasher::isEmpty);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] kinow commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


kinow commented on code in PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#discussion_r1014810859


##
src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java:
##
@@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {
 this(Arrays.asList(hashers));
 }
 
+@Override
+public boolean isEmpty() {
+for (Hasher h : hashers) {
+if (!h.isEmpty()) {
+return false;
+}
+}
+return true;

Review Comment:
   Bit rusty with Java & streams, but I **think** this is equivalent to:
   
   ```java
   return hashers.stream().noneMatch(Hasher::isEmpty);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] kinow commented on a diff in pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


kinow commented on code in PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#discussion_r1014810732


##
src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java:
##
@@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {
 this(Arrays.asList(hashers));
 }
 
+@Override
+public boolean isEmpty() {
+for (Hasher h : hashers) {
+if (!h.isEmpty()) {
+return false;
+}
+}
+return true;
+}

Review Comment:
   Bit rusty with Java & streams, but I **think** this is equivalent to:
   
   ```java
   return hashers.stream().noneMatch(Hasher::isEmpty);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] aherbert merged pull request #349: Collections 384 [bloomfilter] fix typos

2022-11-06 Thread GitBox


aherbert merged PR #349:
URL: https://github.com/apache/commons-collections/pull/349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] codecov-commenter commented on pull request #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


codecov-commenter commented on PR #357:
URL: 
https://github.com/apache/commons-collections/pull/357#issuecomment-1304765508

   # 
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/357?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#357](https://codecov.io/gh/apache/commons-collections/pull/357?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (9eeb3dd) into 
[master](https://codecov.io/gh/apache/commons-collections/commit/3071aea62de6caa0416e873b3930d08f3c703cc7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (3071aea) will **increase** coverage by `0.05%`.
   > The diff coverage is `83.33%`.
   
   ```diff
   @@ Coverage Diff  @@
   ## master #357  +/-   ##
   
   + Coverage 81.21%   81.27%   +0.05% 
   - Complexity 4599 4604   +5 
   
 Files   289  289  
 Lines 1344513451   +6 
 Branches   1973 1974   +1 
   
   + Hits  1092010932  +12 
   + Misses 1924 1921   -3 
   + Partials601  598   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/commons-collections/pull/357?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...collections4/bloomfilter/EnhancedDoubleHasher.java](https://codecov.io/gh/apache/commons-collections/pull/357/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0VuaGFuY2VkRG91YmxlSGFzaGVyLmphdmE=)
 | `98.24% <0.00%> (-1.76%)` | :arrow_down: |
   | 
[...pache/commons/collections4/bloomfilter/Hasher.java](https://codecov.io/gh/apache/commons-collections/pull/357/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0hhc2hlci5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...ons/collections4/bloomfilter/HasherCollection.java](https://codecov.io/gh/apache/commons-collections/pull/357/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0hhc2hlckNvbGxlY3Rpb24uamF2YQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/357/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh)
 | `80.74% <0.00%> (+2.59%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [commons-collections] Claudenw opened a new pull request, #357: Added Hasher.isEmpty() and appropriate tests

2022-11-06 Thread GitBox


Claudenw opened a new pull request, #357:
URL: https://github.com/apache/commons-collections/pull/357

   Adds isEmpty() method to Hasher and implements appropriate tests.
   
   Fixes COLLECTIONS-830


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (COLLECTIONS-819) BloomFilter: Remove methods only used in testing from IndexProducer

2022-11-06 Thread Claude Warren (Jira)


[ 
https://issues.apache.org/jira/browse/COLLECTIONS-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629439#comment-17629439
 ] 

Claude Warren commented on COLLECTIONS-819:
---

[~aherbert] , I think this can be closed as "won't fix" or "works as designed". 
 Or do you still think it should be deleted?

> BloomFilter: Remove methods only used in testing from IndexProducer
> ---
>
> Key: COLLECTIONS-819
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-819
> Project: Commons Collections
>  Issue Type: Improvement
>  Components: Collection
>Affects Versions: 4.5
>Reporter: Claude Warren
>Priority: Minor
>  Labels: bloom-filter
>
> [https://github.com/Claudenw/commons-collections/blob/9f2945cc98747893456b73f42ab53f46a866ac37/src/main/java/org/apache/commons/collections4/bloomfilter/IndexProducer.java#L50-L68]
>  
> h3. 
> !https://avatars.githubusercontent.com/u/886334?s=48=4|width=24,height=24! 
> *[aherbert|https://github.com/aherbert]* [on 27 
> Feb|https://github.com/apache/commons-collections/pull/258#discussion_r813449970]
> This method is only used in testing. What is the use case? Note that 
> BloomFilter interface cannot merge an IndexProducer. This functionality is 
> only provided by the constructors for SimpleBloomFilter and 
> SparseBloomFitler. The method is trivially implemented if a user did want to 
> populate a Bloom filter with certain indices. But I do not see why they would 
> unless deserialising its stored representation. Given that we are not 
> supporting any such constructors for the ArrayCountingBloomFilter (creating 
> and populating at the same time) this seems like a partial support in the 
> library. Either the serialisation and deserialisation is better supported, or 
> we drop these methods from the public API for now.
>  
>  
> [https://github.com/Claudenw/commons-collections/blob/9f2945cc98747893456b73f42ab53f46a866ac37/src/main/java/org/apache/commons/collections4/bloomfilter/IndexProducer.java#L104-L119]
>  
> h3. 
> !https://avatars.githubusercontent.com/u/886334?s=48=4|width=24,height=24! 
> *[aherbert|https://github.com/aherbert]* [on 27 
> Feb|https://github.com/apache/commons-collections/pull/258#discussion_r813449970]
> This method is only used in testing. It is not required for any other 
> functionality in the API. What is the use case? If this is for serialisation 
> then the method is trivially performed anyway and the decision should be made 
> to use this or the bitmap long[] representation depending on the saturation 
> of the filter. It would be simpler to drop this method.
> h3.  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [commons-collections] codecov-commenter commented on pull request #349: Collections 384 [bloomfilter] fix typos

2022-11-06 Thread GitBox


codecov-commenter commented on PR #349:
URL: 
https://github.com/apache/commons-collections/pull/349#issuecomment-1304754170

   # 
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/349?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#349](https://codecov.io/gh/apache/commons-collections/pull/349?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (4cc66a1) into 
[master](https://codecov.io/gh/apache/commons-collections/commit/3071aea62de6caa0416e873b3930d08f3c703cc7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (3071aea) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ## master #349   +/-   ##
   =
 Coverage 81.21%   81.21%   
 Complexity 4599 4599   
   =
 Files   289  289   
 Lines 1344513445   
 Branches   1973 1973   
   =
 Hits  1092010920   
 Misses 1924 1924   
 Partials601  601   
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/commons-collections/pull/349?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...pache/commons/collections4/bloomfilter/BitMap.java](https://codecov.io/gh/apache/commons-collections/pull/349/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0JpdE1hcC5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...ollections4/bloomfilter/CountingLongPredicate.java](https://codecov.io/gh/apache/commons-collections/pull/349/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0NvdW50aW5nTG9uZ1ByZWRpY2F0ZS5qYXZh)
 | `100.00% <ø> (ø)` | |
   | 
[...apache/commons/collections4/bloomfilter/Shape.java](https://codecov.io/gh/apache/commons-collections/pull/349/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL1NoYXBlLmphdmE=)
 | `100.00% <ø> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org