[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1316097489 Wmm, I don't think so. This PR affects nothing related to iterating data in the class file, nor writing bytecode to class files... BCEL 6.6.1 has no other big changes, but they tried with BCEL 6.6.2-SNAPSHOT, then it could be necessary to investigate [rel/commons-bcel-6.6.1...master](https://github.com/apache/commons-bcel/compare/rel/commons-bcel-6.6.1...master)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] aherbert commented on a diff in pull request #358: Collections-817: Reworked calculations and updated javadoc for estimateN(), estimateIntersection() and estimateUnion()
aherbert commented on code in PR #358:
URL:
https://github.com/apache/commons-collections/pull/358#discussion_r1023145652
##
src/main/java/org/apache/commons/collections4/bloomfilter/SimpleBloomFilter.java:
##
@@ -114,10 +114,6 @@ public boolean merge(final BitMapProducer bitMapProducer) {
// idx[0] will be limit+1 so decrement it
idx[0]--;
final int idxLimit = BitMap.getLongIndex(shape.getNumberOfBits());
-if (idxLimit < idx[0]) {
Review Comment:
I assume you are removing this as it is unreachable code, i.e. any idxLimit
< idx[0] would generate an index out of bounds exception in `bitMap[idx[0]++]`.
##
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBitMapProducerTest.java:
##
@@ -103,6 +103,18 @@ public final void testForEachBitMapPair() {
Arrays.fill(count, 0);
createProducer().forEachBitMapPair(createEmptyProducer(), lbp);
assertEquals(count[2], count[1]);
+
+// test where both producer does not process all records and function
Review Comment:
IIUC the producer `shortProducer` will process all records (since it always
returns true). Do you mean:
```
// test where the created producer does not process all records because the
predicate function
// returns false before the processing is completed.
```
##
src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java:
##
@@ -302,7 +302,7 @@ default int estimateIntersection(final BloomFilter other) {
if (Double.isInfinite(eUnion)) {
throw new IllegalArgumentException("The estimated N for the
union of the filters is infinite");
}
-// all estimated values are small values greater than 0 but less
that number of bits
+// maximum estimate value using integer valuess is: 46144189292
Review Comment:
I do not think this comment change helps. I think the original comment is
valid, i.e. since all values are positive and in the range of an integer then
this will not overflow a long.
##
src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterTest.java:
##
@@ -67,6 +68,110 @@ public void testHasherBasedMergeWithDifferingSparseness() {
.forEachBitMapPair(bf1, (x, y) -> x == y));
}
+@Test
+public void testEstimateNWithBrokenCardinality() {
+// build a filter
+BloomFilter filter1 = TestingHashers.populateEntireFilter(new
BrokenCardinality(getTestShape()));
+assertThrows(IllegalArgumentException.class, ()->filter1.estimateN());
+}
+
+@Test
+public void testLargeBitmapAsArray() {
+Shape s = Shape.fromKM(1, Integer.MAX_VALUE);
+// create a very large filter with Integer.MAX_VALUE-1 bit set.
+BloomFilter bf1 = new SimpleBloomFilter(s);
+bf1.merge(new BitMapProducer() {
+@Override
+public boolean forEachBitMap(LongPredicate predicate) {
+int limit = Integer.MAX_VALUE-1;
+while (limit>64) {
+predicate.test(0xL);
+limit -= 64;
+}
+long last = 0L;
+for (int i=0; i x == y));
}
+@Test
+public void testEstimateNWithBrokenCardinality() {
+// build a filter
+BloomFilter filter1 = TestingHashers.populateEntireFilter(new
BrokenCardinality(getTestShape()));
+assertThrows(IllegalArgumentException.class, ()->filter1.estimateN());
+}
+
+@Test
+public void testLargeBitmapAsArray() {
+Shape s = Shape.fromKM(1, Integer.MAX_VALUE);
+// create a very large filter with Integer.MAX_VALUE-1 bit set.
+BloomFilter bf1 = new SimpleBloomFilter(s);
+bf1.merge(new BitMapProducer() {
+@Override
+public boolean forEachBitMap(LongPredicate predicate) {
+int limit = Integer.MAX_VALUE-1;
+while (limit>64) {
+predicate.test(0xL);
+limit -= 64;
+}
+long last = 0L;
+for (int i=0; i x == y));
}
+@Test
+public void testEstimateNWithBrokenCardinality() {
+// build a filter
+BloomFilter filter1 = TestingHashers.populateEntireFilter(new
BrokenCardinality(getTestShape()));
+assertThrows(IllegalArgumentException.class, ()->filter1.estimateN());
+}
+
+@Test
+public void testLargeBitmapAsArray() {
+Shape s = Shape.fromKM(1, Integer.MAX_VALUE);
+// create a very large filter with Integer.MAX_VALUE-1 bit set.
+BloomFilter bf1 = new SimpleBloomFilter(s);
+bf1.merge(new BitMapProducer() {
+@Override
+public boolean forEachBitMap(LongPredicate predicate) {
+int limit = Integer.MAX_VALUE-1;
+
[GitHub] [commons-bcel] garydgregory commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0
garydgregory commented on PR #157:
URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1315765265
Hello @KengoTODA
Would you be able to give an opinion on whether this PR is related to a
regression we are seeing in Xalan?
The (long) thread:
https://lists.apache.org/thread/dojn56v56chkytwffshm343rnj31x3kh
More specifically, we see errors like:
```
[xalantest] ERROR StylesheetTestlet{trax} boolean39.xsl threw:
java.lang.VerifyError: (class: boolean39, method: template$dot$0 signature:
(Lorg/apache/xalan/xsltc/DOM;Lorg/apache/xml/dtm/DTMAxisIterator;Lorg/apache/xml/serializer/SerializationHandler;I)V)
Expecting to find double on stack
[xalantest] StylesheetTestlet boolean82.xsl
[xalantest] java.lang.VerifyError: (class: boolean82, method: template$dot$0
signature:
(Lorg/apache/xalan/xsltc/DOM;Lorg/apache/xml/dtm/DTMAxisIterator;Lorg/apache/xml/serializer/SerializationHandler;I)V)
Expecting to find double on stack
[xalantest] java.lang.VerifyError: (class: boolean82, method: template$dot$0
signature:
(Lorg/apache/xalan/xsltc/DOM;Lorg/apache/xml/dtm/DTMAxisIterator;Lorg/apache/xml/serializer/SerializationHandler;I)V)
Expecting to find double on stack
[xalantest] at java.lang.Class.getDeclaredConstructors0(Native Method)
[xalantest] at
java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
[xalantest] at java.lang.Class.getConstructor0(Class.java:3075)
[xalantest] at java.lang.Class.newInstance(Class.java:412)
[xalantest] at
org.apache.xalan.xsltc.trax.TemplatesImpl.getTransletInstance(TemplatesImpl.java:340)
[xalantest] at
org.apache.xalan.xsltc.trax.TemplatesImpl.newTransformer(TemplatesImpl.java:369)
[xalantest] at
org.apache.xalan.xsltc.trax.TransformerFactoryImpl.newTransformer(TransformerFactoryImpl.java:619)
[xalantest] at
org.apache.qetest.xslwrapper.TraxSystemIdWrapper.transform(TraxSystemIdWrapper.java:168)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestlet.testDatalet(StylesheetTestlet.java:229)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestlet.execute(StylesheetTestlet.java:108)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestletDriver.processFileList(StylesheetTestletDriver.java:441)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestletDriver.processInputDir(StylesheetTestletDriver.java:397)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestletDriver.runTestCases(StylesheetTestletDriver.java:285)
[xalantest] at org.apache.qetest.TestImpl.runTest(TestImpl.java:205)
[xalantest] at
org.apache.qetest.FileBasedTest.doMain(FileBasedTest.java:833)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestletDriver.main(StylesheetTestletDriver.java:951)
[xalantest] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
[xalantest] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[xalantest] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[xalantest] at java.lang.reflect.Method.invoke(Method.java:498)
[xalantest] at org.apache.qetest.QetestUtils.main(QetestUtils.java:434)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-collections] aherbert merged pull request #360: Fix flaky test in CollectionUtilsTest.Java
aherbert merged PR #360: URL: https://github.com/apache/commons-collections/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826246 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF GitHub Bot Created on: 15/Nov/22 17:58 Start Date: 15/Nov/22 17:58 Worklog Time Spent: 10m Work Description: thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315675852 Ahh, thanks for the call out about scope changing. Would you please update the PR without the checkstyle version change? Issue Time Tracking --- Worklog Id: (was: 826246) Time Spent: 2h 10m (was: 2h) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826247 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF GitHub Bot Created on: 15/Nov/22 17:58 Start Date: 15/Nov/22 17:58 Worklog Time Spent: 10m Work Description: XenoAmess opened a new pull request, #68: URL: https://github.com/apache/commons-dbutils/pull/68 https://issues.apache.org/jira/browse/COMMONSSITE-145 Issue Time Tracking --- Worklog Id: (was: 826247) Time Spent: 2h 20m (was: 2h 10m) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-dbutils] XenoAmess opened a new pull request, #68: [COMMONSSITE-145]upgrade checkstyle
XenoAmess opened a new pull request, #68: URL: https://github.com/apache/commons-dbutils/pull/68 https://issues.apache.org/jira/browse/COMMONSSITE-145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] thecarlhall commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle
thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315675852 Ahh, thanks for the call out about scope changing. Would you please update the PR without the checkstyle version change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service
[
https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634439#comment-17634439
]
Gary D. Gregory commented on DAEMON-449:
Hi All,
What would be a better log event message to avoid this type of confusion in the
future?
> Prunsrv fails to stop Open Liberty Windows service
> --
>
> Key: DAEMON-449
> URL: https://issues.apache.org/jira/browse/DAEMON-449
> Project: Commons Daemon
> Issue Type: Bug
> Components: prunsrv
>Affects Versions: 1.2.2
> Environment: I don't think the Windows version matters, but I am
> using:
> Microsoft Windows [Version 10.0.19044.2006]
>Reporter: Jim Blye
>Priority: Major
> Attachments: commons-daemon.2022-09-28.log,
> commons-daemon.2022-09-28_afterKillingServer.log, server.bat
>
>
> When Prunsrv is used to register Open Liberty
> ([https://openliberty.io|https://openliberty.io/]) as a Windows Service,
> stopping the service hangs randomly.
> *To recreate the problem:*
> 1) Download open liberty ~300MB
>
> [https://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/release/22.0.0.10/openliberty-22.0.0.10.zip]
> Alternatively, you could use just the liberty kernel ~10MB
>
> [https://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/release/22.0.0.10/openliberty-kernel-22.0.0.10.zip]
> 2) md C:\temp\openliberty
> unzip openliberty-22.0.0.10.zip into C:\temp\openliberty
> 3) cd C:\temp\openliberty\wlp\bin
> 4) Run these two commands to make sure the server runs and to initialize
> the environment:
> server start
> server stop
> 5) Register liberty as a service (parameter is case sensitive). The
> following command is used to invoke prunsrv to register the service using the
> default name of defaultServer
> server registerWinService
> 6) Open the windows "services" app (services.msc). Start and stop the
> service until the stop hangs. It usually doesn't take more than a couple of
> tries.
>
> *Details*
> The *server.bat* script registers the service like this:
> "C:\temp\openliberty\wlp\bin\tools\win\prunsrv.exe" //IS//defaultServer
> --Startup=manual --DisplayName="defaultServer" --Description="Open Liberty"
> ++DependsOn=Tcpip
> --LogPath="C:\temp\openliberty\wlp\usr\servers\defaultServer\logs"
> --StdOutput=auto --StdError=auto --StartMode=exe
> --StartPath="C:\temp\openliberty\wlp"
> --StartImage="C:\temp\openliberty\wlp\bin\server.bat"
> ++StartParams=start#defaultServer --StopMode=exe
> --StopPath="C:\temp\openliberty\wlp" --StopImage="C:\temp\wlp\bin\server.bat"
> ++StopParams=stop#defaultServer --ServiceUser=LocalSystem
> After registering the service you can look at its properties. You will see:
> Path to executable:
> C:\temp\openliberty\wlp\bin\tools\win\prunsrv.exe //RS//defaultServer
> When I (and many of our customers) try to stop the service, it hangs. At
> that point, the server, named defaultServer is still up and running. I can
> send commands to the server. For instance, I can execute a "server dump"
> command. This sends the "dump" command to the server, and the server writes
> information to a file. I can also stop the server by executing "server
> stop". This sends the "stop" command to the server which causes the server
> to stop. When the server stops, the hanging Windows service stops as well.
> I have attached a *server.bat* which adds --LogLevel Debug to the prunsrv
> commands and also *commons-daemon.2022-09-28.log* which demonstrates the
> problem. It shows registering, starting, and stopping the service. Finally,
> I uploaded {*}commons-daemon.2022-09-28_afterKillingServer.log{*}, which is a
> continuation of the other log file which shows the result of issuing the
> server stop command to stop the server.
> Thanks for looking at this.
> Jim Blye
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826181 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF GitHub Bot Created on: 15/Nov/22 15:46 Start Date: 15/Nov/22 15:46 Worklog Time Spent: 10m Work Description: XenoAmess commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315501022 @thecarlhall it WAS the latest version 1.5 years ago. This is a 1.5 years unhandled pr, so as that jira ticket. Glad it be solved in other pr though. And there is never such goode bot to upgrade it as checkstyle's author always have not any backward compatibility, chaning this name this time and that attribute that time, more like a poet or something than a programmer. like this time he change scope to accessModifiers. Issue Time Tracking --- Worklog Id: (was: 826181) Time Spent: 2h (was: 1h 50m) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-dbutils] XenoAmess commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle
XenoAmess commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315501022 @thecarlhall it WAS the latest version 1.5 years ago. This is a 1.5 years unhandled pr, so as that jira ticket. Glad it be solved in other pr though. And there is never such goode bot to upgrade it as checkstyle's author always have not any backward compatibility, chaning this name this time and that attribute that time, more like a poet or something than a programmer. like this time he change scope to accessModifiers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service
[
https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634413#comment-17634413
]
Mark Thomas commented on DAEMON-449:
I think you are mis-reading the logs.
The line
[2022-11-14 15:04:19] [debug] ( prunsrv.c:1603) [ 6136] Waiting for worker to
finish...
shows that the service has started and the service wrapper is now waiting for
the service to end before that thread will continue.
I suspect what is happening is that server.bat is returning before the service
has fully started. Try adding some debug logging to show when server.bat exits.
> Prunsrv fails to stop Open Liberty Windows service
> --
>
> Key: DAEMON-449
> URL: https://issues.apache.org/jira/browse/DAEMON-449
> Project: Commons Daemon
> Issue Type: Bug
> Components: prunsrv
>Affects Versions: 1.2.2
> Environment: I don't think the Windows version matters, but I am
> using:
> Microsoft Windows [Version 10.0.19044.2006]
>Reporter: Jim Blye
>Priority: Major
> Attachments: commons-daemon.2022-09-28.log,
> commons-daemon.2022-09-28_afterKillingServer.log, server.bat
>
>
> When Prunsrv is used to register Open Liberty
> ([https://openliberty.io|https://openliberty.io/]) as a Windows Service,
> stopping the service hangs randomly.
> *To recreate the problem:*
> 1) Download open liberty ~300MB
>
> [https://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/release/22.0.0.10/openliberty-22.0.0.10.zip]
> Alternatively, you could use just the liberty kernel ~10MB
>
> [https://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/release/22.0.0.10/openliberty-kernel-22.0.0.10.zip]
> 2) md C:\temp\openliberty
> unzip openliberty-22.0.0.10.zip into C:\temp\openliberty
> 3) cd C:\temp\openliberty\wlp\bin
> 4) Run these two commands to make sure the server runs and to initialize
> the environment:
> server start
> server stop
> 5) Register liberty as a service (parameter is case sensitive). The
> following command is used to invoke prunsrv to register the service using the
> default name of defaultServer
> server registerWinService
> 6) Open the windows "services" app (services.msc). Start and stop the
> service until the stop hangs. It usually doesn't take more than a couple of
> tries.
>
> *Details*
> The *server.bat* script registers the service like this:
> "C:\temp\openliberty\wlp\bin\tools\win\prunsrv.exe" //IS//defaultServer
> --Startup=manual --DisplayName="defaultServer" --Description="Open Liberty"
> ++DependsOn=Tcpip
> --LogPath="C:\temp\openliberty\wlp\usr\servers\defaultServer\logs"
> --StdOutput=auto --StdError=auto --StartMode=exe
> --StartPath="C:\temp\openliberty\wlp"
> --StartImage="C:\temp\openliberty\wlp\bin\server.bat"
> ++StartParams=start#defaultServer --StopMode=exe
> --StopPath="C:\temp\openliberty\wlp" --StopImage="C:\temp\wlp\bin\server.bat"
> ++StopParams=stop#defaultServer --ServiceUser=LocalSystem
> After registering the service you can look at its properties. You will see:
> Path to executable:
> C:\temp\openliberty\wlp\bin\tools\win\prunsrv.exe //RS//defaultServer
> When I (and many of our customers) try to stop the service, it hangs. At
> that point, the server, named defaultServer is still up and running. I can
> send commands to the server. For instance, I can execute a "server dump"
> command. This sends the "dump" command to the server, and the server writes
> information to a file. I can also stop the server by executing "server
> stop". This sends the "stop" command to the server which causes the server
> to stop. When the server stops, the hanging Windows service stops as well.
> I have attached a *server.bat* which adds --LogLevel Debug to the prunsrv
> commands and also *commons-daemon.2022-09-28.log* which demonstrates the
> problem. It shows registering, starting, and stopping the service. Finally,
> I uploaded {*}commons-daemon.2022-09-28_afterKillingServer.log{*}, which is a
> continuation of the other log file which shows the result of issuing the
> server stop command to stop the server.
> Thanks for looking at this.
> Jim Blye
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service
[
https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634389#comment-17634389
]
Jim Blye edited comment on DAEMON-449 at 11/15/22 2:43 PM:
---
[~markt] , the root cause actually seems to be happening on *start* rather than
{*}stop{*}. When the service is started, it invokes server.bat. The
server.bat script starts a jvm (the liberty server) and then starts another jvm
which waits for the status of the server to indicate that the server is all the
way up. The problem seems to be that prunsrv does not wait for the server.bat
script to finish. In the Windows "services" panel, the service start seems to
be completed, though the server.bat file is still running waiting for the
liberty server to come up. If I try to stop the service too early, the stop
fails as described above.
I discovered this by adding some logging to server.bat. Before and after the
starting of the jvms, I added logging statements. Then I recreate the problem
by starting the server and then immediately stopping the server as soon as the
Windows "services" panel will let me. What I find in the log file is that the
server is starting and then I see that is stopping. I don't see the message
that it finished starting.
Is there a way to make prunsrv wait for server.bat to complete?
{code:java}
[2022-11-14 15:04:18] [debug] ( prunsrv.c:1763) [11932] Apache Commons Daemon
procrun log initialized.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1767) [11932] Apache Commons Daemon
procrun (1.2.2.0 32-bit) started.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1677) [11932] Running Service
'defaultServer'...
[2022-11-14 15:04:18] [debug] ( prunsrv.c:1448) [ 6136] Inside ServiceMain...
[2022-11-14 15:04:18] [debug] ( prunsrv.c:910 ) [ 6136] reportServiceStatusE:
dwCurrentState = 2, dwWin32ExitCode = 0, dwWaitHint = 3000,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1203) [ 6136] Starting service...
[2022-11-14 15:04:18] [debug] (rprocess.c:519 ) [ 6136] Apache Commons Daemon
apxProcessExecute()
[2022-11-14 15:04:18] [debug] (rprocess.c:258 ) [ 6136] Apache Commons Daemon
procrun __apxProcCreateChildPipes()
[2022-11-14 15:04:18] [debug] (rprocess.c:535 ) [ 6136] Apache Commons Daemon
AplZeroMemory()
[2022-11-14 15:04:18] [debug] (rprocess.c:550 ) [ 6136] Apache Commons Daemon
GetEnvironmentStringsW()
[2022-11-14 15:04:18] [debug] (rprocess.c:572 ) [ 6136] Apache Commons Daemon
CreateProcessW()
[2022-11-14 15:04:18] [debug] (rprocess.c:594 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:18] [debug] (rprocess.c:597 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:18] [debug] (rprocess.c:600 ) [ 6136] Apache Commons Daemon
ResumeThread()
[2022-11-14 15:04:19] [debug] (rprocess.c:602 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:19] [debug] (rprocess.c:608 ) [ 6136] Apache Commons Daemon
apxProcessExecute() returning TRUE
[2022-11-14 15:04:19] [info] ( prunsrv.c:1359) [ 6136] Service started in 249
milliseconds.
[2022-11-14 15:04:19] [debug] ( prunsrv.c:910 ) [ 6136] reportServiceStatusE:
dwCurrentState = 4, dwWin32ExitCode = 0, dwWaitHint = 0,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:19] [debug] ( prunsrv.c:1603) [ 6136] Waiting for worker to
finish...
[2022-11-14 15:04:22] [debug] ( prunsrv.c:910 ) [11932] reportServiceStatusE:
dwCurrentState = 3, dwWin32ExitCode = 0, dwWaitHint = 3000,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:22] [info] ( prunsrv.c:1010) [ 7488] Stopping service...
[2022-11-14 15:04:22] [debug] (rprocess.c:519 ) [ 7488] Apache Commons Daemon
apxProcessExecute()
[2022-11-14 15:04:22] [debug] (rprocess.c:258 ) [ 7488] Apache Commons Daemon
procrun __apxProcCreateChildPipes()
[2022-11-14 15:04:22] [debug] (rprocess.c:535 ) [ 7488] Apache Commons Daemon
AplZeroMemory()
[2022-11-14 15:04:22] [debug] (rprocess.c:550 ) [ 7488] Apache Commons Daemon
GetEnvironmentStringsW()
[2022-11-14 15:04:22] [debug] (rprocess.c:572 ) [ 7488] Apache Commons Daemon
CreateProcessW()
[2022-11-14 15:04:22] [debug] (rprocess.c:594 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:597 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:600 ) [ 7488] Apache Commons Daemon
ResumeThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:602 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:608 ) [ 7488] Apache Commons Daemon
apxProcessExecute() returning TRUE
[2022-11-14 15:04:22] [debug] ( prunsrv.c:1131) [ 7488] Waiting for stop worker
to finish...
[2022-11-14 15:04:24] [debug] (rprocess.c:122 ) [ 4872] Child process exit code
21
[2022-11-14 15:04:24] [debug] ( prunsrv.c:1133) [ 7488] Stop worker finished.
[2022-11-14 15:04:24] [debug] ( prunsrv.c:910 ) [ 7488]
[jira] [Commented] (DAEMON-449) Prunsrv fails to stop Open Liberty Windows service
[
https://issues.apache.org/jira/browse/DAEMON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634389#comment-17634389
]
Jim Blye commented on DAEMON-449:
-
[~markt] , the root cause actually seems to be happening on *start* rather than
{*}stop{*}. When the service is started, it invokes server.bat. The
server.bat script starts a jvm (the liberty server) and then starts another jvm
which waits for the status of the server to indicate that the server is all the
way up. The problem seems to be that prunsrv does not wait for the server.bat
script to finish. In the Windows "services" panel, the service start seems to
be completed, though the server.bat file is still running waiting for the
liberty server to come up. If I try to stop the service too early, the stop
fails as described above.
I discovered this by adding some logging to server.bat. Before and after the
starting of the jvms, I added logging statements. Then I recreate the problem
by starting the server and then immediately stopping the server as soon as the
Windows "services" panel will let me. What I find in the log file is that the
server is starting and then I see that is stopping. I don't see the message
that it finished starting.
Is there a way to make prunsrv wait for server.bat to complete?
{code:java}
[2022-11-14 15:04:18] [debug] ( prunsrv.c:1763) [11932] Apache Commons Daemon
procrun log initialized.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1767) [11932] Apache Commons Daemon
procrun (1.2.2.0 32-bit) started.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1677) [11932] Running Service
'defaultServer'...
[2022-11-14 15:04:18] [debug] ( prunsrv.c:1448) [ 6136] Inside ServiceMain...
[2022-11-14 15:04:18] [debug] ( prunsrv.c:910 ) [ 6136] reportServiceStatusE:
dwCurrentState = 2, dwWin32ExitCode = 0, dwWaitHint = 3000,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:18] [info] ( prunsrv.c:1203) [ 6136] Starting service...
[2022-11-14 15:04:18] [debug] (rprocess.c:519 ) [ 6136] Apache Commons Daemon
apxProcessExecute()
[2022-11-14 15:04:18] [debug] (rprocess.c:258 ) [ 6136] Apache Commons Daemon
procrun __apxProcCreateChildPipes()
[2022-11-14 15:04:18] [debug] (rprocess.c:535 ) [ 6136] Apache Commons Daemon
AplZeroMemory()
[2022-11-14 15:04:18] [debug] (rprocess.c:550 ) [ 6136] Apache Commons Daemon
GetEnvironmentStringsW()
[2022-11-14 15:04:18] [debug] (rprocess.c:572 ) [ 6136] Apache Commons Daemon
CreateProcessW()
[2022-11-14 15:04:18] [debug] (rprocess.c:594 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:18] [debug] (rprocess.c:597 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:18] [debug] (rprocess.c:600 ) [ 6136] Apache Commons Daemon
ResumeThread()
[2022-11-14 15:04:19] [debug] (rprocess.c:602 ) [ 6136] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:19] [debug] (rprocess.c:608 ) [ 6136] Apache Commons Daemon
apxProcessExecute() returning TRUE
[2022-11-14 15:04:19] [info] ( prunsrv.c:1359) [ 6136] Service started in 249
milliseconds.
[2022-11-14 15:04:19] [debug] ( prunsrv.c:910 ) [ 6136] reportServiceStatusE:
dwCurrentState = 4, dwWin32ExitCode = 0, dwWaitHint = 0,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:19] [debug] ( prunsrv.c:1603) [ 6136] Waiting for worker to
finish...
[2022-11-14 15:04:22] [debug] ( prunsrv.c:910 ) [11932] reportServiceStatusE:
dwCurrentState = 3, dwWin32ExitCode = 0, dwWaitHint = 3000,
dwServiceSpecificExitCode = 0.
[2022-11-14 15:04:22] [info] ( prunsrv.c:1010) [ 7488] Stopping service...
[2022-11-14 15:04:22] [debug] (rprocess.c:519 ) [ 7488] Apache Commons Daemon
apxProcessExecute()
[2022-11-14 15:04:22] [debug] (rprocess.c:258 ) [ 7488] Apache Commons Daemon
procrun __apxProcCreateChildPipes()
[2022-11-14 15:04:22] [debug] (rprocess.c:535 ) [ 7488] Apache Commons Daemon
AplZeroMemory()
[2022-11-14 15:04:22] [debug] (rprocess.c:550 ) [ 7488] Apache Commons Daemon
GetEnvironmentStringsW()
[2022-11-14 15:04:22] [debug] (rprocess.c:572 ) [ 7488] Apache Commons Daemon
CreateProcessW()
[2022-11-14 15:04:22] [debug] (rprocess.c:594 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:597 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:600 ) [ 7488] Apache Commons Daemon
ResumeThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:602 ) [ 7488] Apache Commons Daemon
CreateThread()
[2022-11-14 15:04:22] [debug] (rprocess.c:608 ) [ 7488] Apache Commons Daemon
apxProcessExecute() returning TRUE
[2022-11-14 15:04:22] [debug] ( prunsrv.c:1131) [ 7488] Waiting for stop worker
to finish...
[2022-11-14 15:04:24] [debug] (rprocess.c:122 ) [ 4872] Child process exit code
21
[2022-11-14 15:04:24] [debug] ( prunsrv.c:1133) [ 7488] Stop worker finished.
[2022-11-14 15:04:24] [debug] ( prunsrv.c:910 ) [ 7488] reportServiceStatusE:
dwCurrentState = 3, dwWin32ExitCode = 0,
[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826142 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF GitHub Bot Created on: 15/Nov/22 13:52 Start Date: 15/Nov/22 13:52 Worklog Time Spent: 10m Work Description: thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315338939 Closing as dependency upgrades for things like checkstyle are handled by a bot, and this particular version is woefully out of date this point. Issue Time Tracking --- Worklog Id: (was: 826142) Time Spent: 1h 40m (was: 1.5h) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (COMMONSSITE-145) upgrade checkstyle in several commons repos
[ https://issues.apache.org/jira/browse/COMMONSSITE-145?focusedWorklogId=826143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826143 ] ASF GitHub Bot logged work on COMMONSSITE-145: -- Author: ASF GitHub Bot Created on: 15/Nov/22 13:52 Start Date: 15/Nov/22 13:52 Worklog Time Spent: 10m Work Description: thecarlhall closed pull request #68: [COMMONSSITE-145]upgrade checkstyle URL: https://github.com/apache/commons-dbutils/pull/68 Issue Time Tracking --- Worklog Id: (was: 826143) Time Spent: 1h 50m (was: 1h 40m) > upgrade checkstyle in several commons repos > --- > > Key: COMMONSSITE-145 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-145 > Project: Apache Commons All > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42 changes its > grammar, which means some of our repos need a manual change to upgrade to > [checkstyle|https://github.com/checkstyle/checkstyle] 8.42. > including: > https://github.com/apache/commons-lang/pull/752 > https://github.com/apache/commons-configuration/pull/118 > https://github.com/apache/commons-dbutils/pull/68 > https://github.com/apache/commons-geometry/pull/160 > https://github.com/apache/commons-collections/pull/235 > https://github.com/apache/commons-vfs/pull/181 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [commons-dbutils] thecarlhall closed pull request #68: [COMMONSSITE-145]upgrade checkstyle
thecarlhall closed pull request #68: [COMMONSSITE-145]upgrade checkstyle URL: https://github.com/apache/commons-dbutils/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] thecarlhall commented on pull request #68: [COMMONSSITE-145]upgrade checkstyle
thecarlhall commented on PR #68: URL: https://github.com/apache/commons-dbutils/pull/68#issuecomment-1315338939 Closing as dependency upgrades for things like checkstyle are handled by a bot, and this particular version is woefully out of date this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] thecarlhall closed pull request #63: Minor Improvements:
thecarlhall closed pull request #63: Minor Improvements: URL: https://github.com/apache/commons-dbutils/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] thecarlhall commented on pull request #63: Minor Improvements:
thecarlhall commented on PR #63: URL: https://github.com/apache/commons-dbutils/pull/63#issuecomment-1315338071 Closing as these changes don't make a material difference or improve the code in a functional way. Many of the variables changes are explicitly setting the default value. Collapsing lines down decreases readability and debug-ability. The change from StringBuffer to StringBuilder could be interesting and will be considered outside of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] garydgregory commented on pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0
garydgregory commented on PR #386: URL: https://github.com/apache/commons-text/pull/386#issuecomment-1315183243 Notify infra? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jexl] henrib merged pull request #141: Bump spotbugs-maven-plugin from 4.7.2.1 to 4.7.3.0
henrib merged PR #141: URL: https://github.com/apache/commons-jexl/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0
kinow commented on PR #386: URL: https://github.com/apache/commons-text/pull/386#issuecomment-1314976589 This is spam. Alas only users with access to settings can report/ban users spamming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0
kinow closed pull request #386: Dependabot/maven/com.GitHub.spotbugs spotbugs maven plugin 4.5.0.0 URL: https://github.com/apache/commons-text/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
