Re: [PR] Support for Java 16 Record feature [commons-bcel]
PabloNicolasDiaz commented on PR #290: URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2033457159 Hi and sorry @garydgregory :(, I have run `mvn` but didn't see the error in this class. I've fixed it in my last commit Thanks for your time and sorry again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] create the listener and helper once to speed up test TestDatabaseConfiguration [commons-configuration]
TestBoost opened a new pull request, #397: URL: https://github.com/apache/commons-configuration/pull/397 Sorry but I don't have a jira account yet and I just submit this pull request firstly through Github now. There are 37 test methods in the test class `TestDatabaseConfiguration`. They rely on `DatabaseConfigurationTestHelper helper` to setup some database configuration. The major test bodies are checking the keys and values in the configuration. However, not all tests are affecting each other and we can simply initialize the helper once and reinitialize it when needed. In this pull request, we reinitialize 5 tests in the test class `TestDatabaseConfiguration` to make sure all tests pass in any orders and they do not affect each other's results. The test runtime can jump from `1.8297 s` to `1.0738 s` after applying the changes when run on our machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] only initialize digestUtilsTest when necessary to speed up test MessageDigestAlgorithmsTest [commons-codec]
TestBoost opened a new pull request, #262: URL: https://github.com/apache/commons-codec/pull/262 For the test methods in the test class MessageDigestAlgorithmsTest, not all test methods modify the contents of shared fields. We can just initialize `digestUtilsTest` once before all the test methods to speed up this test. However, the parameterized tests for test method `testNonBlockingDigestRandomAccessFile` always change the the file-pointer offset of the `RandomAccessFile` field in `digestUtilsTest` class. There are two ways to fix this problem: one is to reinitialize `digestUtilsTest` before the test method `testNonBlockingDigestRandomAccessFile` like we propose in this pull request; another is to add `randomAccessFile.seek(0);` at the end of test method `testNonBlockingDigestRandomAccessFile`. The test runtime can jump from `5.509 s` to `5.046 s` after applying the changes when run on our machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IO-853) BoundedInputStream.reset() not updating count
Mike Drob created IO-853: Summary: BoundedInputStream.reset() not updating count Key: IO-853 URL: https://issues.apache.org/jira/browse/IO-853 Project: Commons IO Issue Type: Bug Components: Streams/Writers Affects Versions: 2.16.0 Reporter: Mike Drob In [https://github.com/apache/commons-io/commit/99702ec5ce4c25a909299c4f4a8be616d8ce04dc] BoundedInputStream was modified to use a CountingInputStream, and reset() no longer set the count to the mark, because count was retrieved from the other stream. Then in [https://github.com/apache/commons-io/commit/812d8a4b53d9758b4f081d9b98a70ea9ef131a0e] the count field was added back in but reset() was not fixed to update the value of count when called. This causes a regression, found when attempting to upgrade commons-compress. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Support for Java 16 Record feature [commons-bcel]
garydgregory commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1548606847
##
src/main/java/org/apache/bcel/classfile/Visitor.java:
##
@@ -237,4 +249,15 @@ default void visitStackMapType(final StackMapType obj) {
void visitSynthetic(Synthetic obj);
void visitUnknown(Unknown obj);
+
+/**
+ * Visits a {@link RecordComponentInfo} object.
+ *
+ * @param obj record component to visit
Review Comment:
@PabloNicolasDiaz
You still have not fixed the above, the build fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Some ArrayUtils method descriptions are not accurate [commons-lang]
garydgregory commented on PR #1065: URL: https://github.com/apache/commons-lang/pull/1065#issuecomment-2033092795 Closing on consensus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Some ArrayUtils method descriptions are not accurate [commons-lang]
garydgregory closed pull request #1065: Some ArrayUtils method descriptions are not accurate URL: https://github.com/apache/commons-lang/pull/1065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (COLLECTIONS-551) Move Iterable related methods from CollectionUtils to IterableUtils
[ https://issues.apache.org/jira/browse/COLLECTIONS-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COLLECTIONS-551: Fix Version/s: 4.5.0 (was: 4.5.0-M1) > Move Iterable related methods from CollectionUtils to IterableUtils > --- > > Key: COLLECTIONS-551 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-551 > Project: Commons Collections > Issue Type: Improvement >Affects Versions: 4.0 >Reporter: Thomas Neidhart >Priority: Major > Fix For: 5.0, 4.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (COLLECTIONS-542) AbstractHashedMap should not extend AbstractMap anymore
[ https://issues.apache.org/jira/browse/COLLECTIONS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated COLLECTIONS-542: Fix Version/s: 4.5.0 (was: 4.5.0-M1) > AbstractHashedMap should not extend AbstractMap anymore > --- > > Key: COLLECTIONS-542 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-542 > Project: Commons Collections > Issue Type: Task >Affects Versions: 4.0 >Reporter: Thomas Neidhart >Priority: Minor > Fix For: 5.0, 4.5.0 > > > As described in the javadoc of AbstractHashedMap, the inheritance of > AbstractMap should have been removed in the 4.0 release. > This has been forgotten. Removal of the inheritance does not seem to be > possible for the 4.x branch, so we should at least correct the javadoc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-imaging]
garydgregory merged PR #382: URL: https://github.com/apache/commons-imaging/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Code smells removal [commons-math]
patel-kshitij closed pull request #237: Code smells removal URL: https://github.com/apache/commons-math/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DAEMON-460) High CPU usage in prunsrv.exe since Daemon 1.3.3
[ https://issues.apache.org/jira/browse/DAEMON-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833172#comment-17833172 ] Daniel commented on DAEMON-460: --- Hi, we noticed the same problem with v1.3.4 and downgraded to v1.3.2. One CPU core is fully used by prunsrv.exe. > High CPU usage in prunsrv.exe since Daemon 1.3.3 > > > Key: DAEMON-460 > URL: https://issues.apache.org/jira/browse/DAEMON-460 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.3.3 >Reporter: Japie vd Linde >Priority: Major > Attachments: EspRun-Service-Log.2023-06-05.log, > image-2023-05-31-09-31-21-485.png, image-2023-06-05-13-38-38-435.png > > > When using the --StopTimeout=30 parameter on service using prunsrv the CPU > usage is reported as very high on Windows. Rolling back to older prunsrv > seems to resolve the problem. > !image-2023-05-31-09-31-21-485.png! > What could be the possible causes for this problem? -- This message was sent by Atlassian Jira (v8.20.10#820010)
