garydgregory commented on code in PR #26:
URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999300705
##
src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.jxpath.ri;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * A filter to be used by JXPath, to evaluate the xpath string values to
impose any restrictions.
+ * This class implements specific filter interfaces, and implements methods in
those.
+ * For instance, it JXPathClassFilter interface, which is used to check if any
restricted java classes are passed via xpath
+ * JXPath uses this filter instance when an extension function instance is
created.
+ *
+ * @author bhmohanr-techie
Review Comment:
We don't use author tags. Credit it given in the changes.xml file after a PR
is merged (to avoid conflicts with other PRs).
##
src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.jxpath.ri;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * A filter to be used by JXPath, to evaluate the xpath string values to
impose any restrictions.
+ * This class implements specific filter interfaces, and implements methods in
those.
+ * For instance, it JXPathClassFilter interface, which is used to check if any
restricted java classes are passed via xpath
+ * JXPath uses this filter instance when an extension function instance is
created.
+ *
+ * @author bhmohanr-techie
+ * @version $Revision$ $Date$
+ */
+public class JXPathFilter implements JXPathClassFilter {
+private Set allowedClassesList = null;
+
+public JXPathFilter() {
+init();
+}
+
+public void init() {
+String restrictedClasses = System.getProperty("jxpath.class.allow");
Review Comment:
Use `final` where you can.
##
src/main/java/org/apache/commons/jxpath/ri/JXPathFilter.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.jxpath.ri;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * A filter to be used by JXPath, to evaluate the xpath string values to
impose any restrictions.
+ * This class implements specific filter interfaces, and implements methods in
those.
+ * For instance, it JXPathClassFilter interface, which is used to check if any
restricted java classes are passed via xpath
+ * JXPath uses this filter instance when an extension function
