[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460865#comment-16460865 ] Gilles commented on MATH-1459: -- bq. I have done this with a pull request, but would like feedback. Please provide the link to the PR. Thanks. > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461582#comment-16461582 ] adrian commented on MATH-1459: -- [~erans] [https://github.com/apache/commons-math/pull/84] thanks! > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462240#comment-16462240
]
Gilles commented on MATH-1459:
--
I've already fixed the tolerance typo (1e14 vs 1e-14); thanks.
Please run
{noformat}
$ mvn site
{noformat}
It will generate various reports in the {{target/site}} directory so that you
can verify that your submission does not trigger "CheckStyle" warnings. All
methods and fields must be documented.
I also think that the unit test class is problematic as it will run many tests
(from the base class) that are not impacted by the overridden "builder".
As for the feature itself, I wonder whether the differentiator should be a
parameter (of some factory method); that way, the user would be responsible for
the possible caveats that currently only appear as warnings in the doc.
> Create a way to calculate the Jacobian Matrix using a Differentiator
>
>
> Key: MATH-1459
> URL: https://issues.apache.org/jira/browse/MATH-1459
> Project: Commons Math
> Issue Type: Improvement
>Affects Versions: 4.X
>Reporter: adrian
>Priority: Minor
> Fix For: 4.X
>
>
> Create a way to automatically calculate a Jacobian Matrix using a
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit: https://github.com/apache/commons-math/pull/84
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463107#comment-16463107 ] adrian commented on MATH-1459: -- [~erans] I think I've fixed most of the things you suggest. * The checkstyle changes are fixed. * Passing in the differentiator is fixed. * As for the unit tests, I think I've fixed some of what you discuss over at the pull request, but I can address it further if you'd like. > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463924#comment-16463924
]
Gilles commented on MATH-1459:
--
Thanks for the changes; the functionality looks more flexible now.
As noted previously, I find it quite confusing that the unit test inherits from
the {{LevenbergMarquardtOptimizerTest}} class: I would rather expect an
independent class that "builds" two LS problems, one with the analytical
Jacobian and the other with the new feature, and performs some comparisons
(accuracy, performance) between them (the point being for a user to see what is
implied by his choice of {{MultivariateJacobianFunction}} implementation).
For this purpose, the optimizer is an "implementation detail" and more
implementations/optimizers could be added to the test class.
If for that purpose, you need the "BevingtonProblem" class, do not hesitate to
extract it from {{LevenbergMarquardtOptimizerTest}} and make it independent (as
was done for other classes like {{CircleProblem}} etc.).
> Create a way to calculate the Jacobian Matrix using a Differentiator
>
>
> Key: MATH-1459
> URL: https://issues.apache.org/jira/browse/MATH-1459
> Project: Commons Math
> Issue Type: Improvement
>Affects Versions: 4.X
>Reporter: adrian
>Priority: Minor
> Fix For: 4.X
>
>
> Create a way to automatically calculate a Jacobian Matrix using a
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit: https://github.com/apache/commons-math/pull/84
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463982#comment-16463982 ] adrian commented on MATH-1459: -- [~erans], that makes sense. I've moved the BevingtonProblem class out (haven't committed yet). How Independent do you mean? Will the unit test extend AbstractLeastSquaresOptimizerAbstractTest? Or will it extend nothing? I can do either one, and I'm not sure which one is better. Thanks! > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465752#comment-16465752
]
Gilles commented on MATH-1459:
--
bq. Will the unit test extend AbstractLeastSquaresOptimizerAbstractTest? Or
will it extend nothing?
As per my previous comment, it should not extend
{{AbstractLeastSquaresOptimizerAbstractTest}} since that class is meant to test
an optimizer, while the functionality here concerns is an _input_ to the
optimizer.
> Create a way to calculate the Jacobian Matrix using a Differentiator
>
>
> Key: MATH-1459
> URL: https://issues.apache.org/jira/browse/MATH-1459
> Project: Commons Math
> Issue Type: Improvement
>Affects Versions: 4.X
>Reporter: adrian
>Priority: Minor
> Fix For: 4.X
>
>
> Create a way to automatically calculate a Jacobian Matrix using a
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit: https://github.com/apache/commons-math/pull/84
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476437#comment-16476437 ] adrian commented on MATH-1459: -- [~erans] I made the change you suggested regarding the unit test. Let me know if this is closer to what you suggested last week. I assume I should also remove the java 8 lambda in favor of the anonymous class. Is that correct? > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477537#comment-16477537 ] Gilles commented on MATH-1459: -- bq. I assume I should also remove the java 8 lambda Not necessarily since the target platform is now Java 8 for "Commons Math". > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[
https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477539#comment-16477539
]
Gilles commented on MATH-1459:
--
Commit 6dc6cf5b2fba50eb602283101de4910787ad5579 ("master" branch).
> Create a way to calculate the Jacobian Matrix using a Differentiator
>
>
> Key: MATH-1459
> URL: https://issues.apache.org/jira/browse/MATH-1459
> Project: Commons Math
> Issue Type: Improvement
>Affects Versions: 4.X
>Reporter: adrian
>Priority: Minor
> Fix For: 4.X
>
>
> Create a way to automatically calculate a Jacobian Matrix using a
> Differentiator.
> I have done this with a pull request, but would like feedback.
> edit: https://github.com/apache/commons-math/pull/84
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573591#comment-16573591 ] adrian commented on MATH-1459: -- Hey [~erans] I also made a cleanup pull request (deleting a file that was unused and made a pretty minor improvement to the code) here: https://github.com/apache/commons-math/pull/86 Thanks! > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576333#comment-16576333 ] adrian commented on MATH-1459: -- I can fix the "@inheritDoc" problem I created, but when I run "mvn test site" or "mvn javadoc:javadoc" I don't see this error. Should I just push a commit with this fix? > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MATH-1459) Create a way to calculate the Jacobian Matrix using a Differentiator
[ https://issues.apache.org/jira/browse/MATH-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576349#comment-16576349 ] Gilles commented on MATH-1459: -- bq. cleanup pull resquest Thanks, done. If all seems OK, please "resolve" this issue. Also, if you'd like to see an official release some time, some help would be welcome for polishing the new ["Commons Numbers"|http://commons.apache.org/proper/commons-numbers/] component upon which the development version of CM now depends. bq. "@inheritDoc" problem I think it should be fixed. No idea why "javadoc" did not complain. > Create a way to calculate the Jacobian Matrix using a Differentiator > > > Key: MATH-1459 > URL: https://issues.apache.org/jira/browse/MATH-1459 > Project: Commons Math > Issue Type: Improvement >Affects Versions: 4.X >Reporter: adrian >Priority: Minor > Fix For: 4.X > > > Create a way to automatically calculate a Jacobian Matrix using a > Differentiator. > I have done this with a pull request, but would like feedback. > edit: https://github.com/apache/commons-math/pull/84 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
