[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074758#comment-16074758
]
ASF GitHub Bot commented on NUMBERS-38:
---
Github user ameyjadiye closed the pull request at:
https://github.com/apache/commons-numbers/pull/5
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074754#comment-16074754
]
Amey Jadiye commented on NUMBERS-38:
Sounds good! Thanks [~erans]
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039506#comment-16039506
]
Amey Jadiye commented on NUMBERS-38:
Hello [~erans],
I have submitted code for your review, now latest test case only going to test
values generated by {{LanczosApproximation.java}} against code given
[Here|https://rosettacode.org/wiki/Gamma_function#Java] which was scope of this
jira and we can merge and close it.
My intent is modifying code with no breaks anywhere, I've reviewed the code in
{{GammaDistribution}} we might need to change it if we go with my approach,
and anyway we are segregating Math and Numbers so we are in that flow to change
it little more.
Lets see what others are thinking, for now we can close this ticket as it have
completed its purpose.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039473#comment-16039473
]
ASF GitHub Bot commented on NUMBERS-38:
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-numbers/pull/5
[](https://coveralls.io/builds/11855086)
Coverage remained the same at 83.124% when pulling
**0701cbfe7492510dc4ffe9d083b89b403f236b42 on ameyjadiye:master** into
**c2bfc4fbf8fe325eaf254c37128948b7644e5687 on apache:master**.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037637#comment-16037637
]
Gilles commented on NUMBERS-38:
---
Thanks a lot for the clear description.
{quote}
Gamma gammaFun = new Gamma(); gammaFun.value( x );
...
{quote}
>From an OO programming POV, your idea is appealing; however I'm afraid that
>from a usage POV, it would be a problem in the sense that it seems that one
>would have to use different instances to order to achieve the same precision
>for different input domains.
At least, that's how I understood the different branches in the current code.
In short, IMO we should provide an implementation that is a good compromise
between accuracy (knowing that we deal with double precision) and speed
(assuming modern CPUs).
On a practical level, I first thought that {{LanczosApproximation}} (as
currently defined) was only an internal part of the {{Gamma}} computation, and
I had made it package-private. But, as I mentioned in the previous comment,
the functionality is called from the {{GammaDistribution}} class in "Commons
Math"; if you change the value that is computed, that code won't work anymore
(perhaps it can be recoded in terms of the new value, but that must be assessed
if we don't want to duplicate code).
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037408#comment-16037408
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans]
bq. It is still not clear to me what is the benefit of moving those lines ...
Let me try to put this way .. Gamma is nothing but advanced factorial function
with advantages like we can have factorial of whole numbers as well as
factional. Now [Gamma function| https://en.wikipedia.org/wiki/Gamma_function]
which is having general formula {{Gamma( x ) = integral( t^(x-1) e^(-t), t = 0
.. infinity)}} and Lanczos approximation / Stirling's approximation /Spouge's
Approximation *is a* gamma function so they should be extend Gamma.
Exact algorithm and formulas here :
- [Lanczo's Approximation|https://en.wikipedia.org/wiki/Lanczos_approximation]
- [Stirling's
Approximation|https://en.wikipedia.org/wiki/Stirling%27s_approximation]
- [Spouge's
Approximation|https://en.wikipedia.org/wiki/Spouge%27s_approximation]
Why to refactor code is because basic gamma computes not so accurate values so
someone who need quick computation without precision can choose it, while
someone who need precision overs cost of performance _(Lanczos approximation is
accurate so its slow)_ can choose which algorithm they want which is not
possible right now.
I'm proposing something like:
{quote}
Gamma gammaFun = new Gamma(); gammaFun.value( x );
Gamma gammaFun = new LanczosGamma(); gammaFun.value( x );
Gamma gammaFun = new StirlingsGamma(); gammaFun.value( x );
Gamma gammaFun = new SpougesGamma(); gammaFun.value( x );
{quote}
as the class name suggestion {{LanczosApproximation}} it should execute full
_Lanczos Algoritham_ but we are just computing coefficients in that class which
is incorrect, so just refactoring is needed which wont break any dependency of
this class anywhere.
All that said, will do 2 things now.
# I will propose this to commons-dev mailing list and lets see what others are
thinking about this ?
# I will change the PR code and will make test cases just to test what
coefficients are we generating with against 2 codes I found on internet._(which
is you are suggesting)_
So if proposal fails we will have test cases anyway for existing code *or* if
proposal passes will create other JIRA and modify test cases according to
different algorithms.
let me know your thoughts?
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036412#comment-16036412
]
Gilles commented on NUMBERS-38:
---
It is still not clear to me what is the benefit of moving those lines from
{{Gamma}} to {{LanczosApproximation}}. In particular, can you point exactly
where the "lanczos approximation" reference algorithm is defined?
Also, please check what would happen to {{GammaDistribution}} (in package
{{o.a.c.math4.distribution}} of Commons Math). Thanks.
bq. reference functions given are as whole, I can generate by breaking that
code but that's incorrect.
I can understand the reluctance.
Note that if other unit tests (e.g. those for {{Gamma}}) indirectly cover this
class, we could resolve this issue as "Not a problem" (perhaps just adding a
note in {{LanczosApproximationTest}}).
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036289#comment-16036289
]
Amey Jadiye commented on NUMBERS-38:
bq. I'm now confused as to what the problem is.
Sorry for confusion, there is no bug in output as whole class but I strongly
feel there is incorrect design _(which I called bug)_.
bq. The refactoring was based on the simple premise that each building block is
defined in its own class.
I think that's what not present in code, leading me to generated incorrect
output verses expected according to class. (*misnomer*)
bq. If the output of Gamma is buggy, please file a JIRA report and then create
a corresponding unit test.
No need to raise as bug, but yes different JIRA should be there for
refactoring it correctly.
bq. Why couldn't you generate a list of reference output values, from any of
the codes you've found.
reference functions given are as whole, I can generate by breaking that code
but that's incorrect.
Please review attached patch, you will be more clear on my views.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036266#comment-16036266
]
Gilles commented on NUMBERS-38:
---
bq. I think all that you copied from commons math is correct just need better
refactoring of code
I'm now confused as to what the problem is.
Either we talk of *bugs* or we talk about design. The refactoring was based on
the simple premise that each building block (aka a function that has a name and
is the implementation of a reference algorithm) is defined in its own class.
If the output of Gamma is buggy, please file a JIRA report and then create a
corresponding unit test.
bq. I Gamma we are generating values with basic logic if n <= 20 else we
calculate it with LanczosApproximation, all we can do is to put full logic in
LanczosApproximation.java and just call it, at this point Test-cases on
LanczosApproximation doesn't make sense.
I don't follow. Why couldn't you generate a list of reference output values,
from any of the codes you've found, that checks the correctness of
{{LanczosApproximation}} separately from the classes that make use of that
output?
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036264#comment-16036264
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans],
I think all that you copied from commons math is correct just need better
refactoring of code, as of now partial logic is present in {{Gamma.java}} and
{{LanczosApproximation.java}} and they both generate correct output, that said
I just went through all repository of commons-number and found that code is
being called from {{Gamma.java}} _(which I see is very abstract term/class)_
for *Gamma functions* and Lanczos Approximation as well as Stirling
Approximation _(not present in repo, we can code this and will be and
addition)_ are extension to Gamma so their full logic should be in their own
class.
I Gamma we are generating values with basic logic if {{n <= 20}} else we
calculate it with LanczosApproximation, all we can do is to put full logic in
{{LanczosApproximation.java}} and just call it, at this point Test-cases on
LanczosApproximation doesn't make sense.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036261#comment-16036261
]
Gilles commented on NUMBERS-38:
---
Hi Amey,
Great that you could dig deeper into the review.
With all the information you have gathered, could you set up (separate) unit
tests that highlight every problem?
As you suggest, the first one would be to verify the correlation between gamma
and factorial.
Another thing to check in priority is whether I made some mistake when
copying/refactoring the code coming from "Commons Math".
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036254#comment-16036254
]
Amey Jadiye commented on NUMBERS-38:
Hi [~erans]
My initial thoughts was the formula given in code itself is the marker to test
and is perfectly written (as present in apache's project), your comment forced
me to verify everything from roots which ended up me reading lots of papers and
watching youtube on Gamma functions and approximations _(including great
interview of [Cornelius Lanczos|https://www.youtube.com/watch?v=avSHHi9QCjA])_
and finally I found our Code is Buggy generating wrong values for inputs :(
There are the some references I cross verified the test input/outputs _(both
produce same result and our code produce something else)_
- [https://rosettacode.org/wiki/Gamma_function#Java]
- [https://en.wikipedia.org/wiki/Lanczos_approximation] (_this is python but
generates same outputs_)
I saw coefficient are take from (which are standard anyway), no matter which
set you take results are approx same.
- [https://mrob.com/pub/ries/lanczos-gamma.html]
For more cross verification there is online gamma calculator which also gives
same result.
- [http://www.efunda.com/math/gamma/findgamma.cfm]
All that I said, our code need to be fixed and it should generate
{{gamma(z)=(n-1)!}} (n minus one factorial) values.
let me know your thoughts.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036053#comment-16036053
]
Gilles commented on NUMBERS-38:
---
Amey,
Thanks for taking this on.
However, the main interest here is not so much about coverage (that code is
called by other classes in the package) as it is to ensure that this particular
function produces the right values within some known tolerance.
Please correct me if I'm wrong, but it seems that your patch uses values
computed by the same code it is supposed to check.
We should resort to that only when there is no better alternative, which is
usually to compare with the results of another ("reference") library.
For example, you could execute a slightly modified version of the code found
[here|https://en.wikipedia.org/wiki/Lanczos_approximation] to get
independently computed values.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036042#comment-16036042
]
ASF GitHub Bot commented on NUMBERS-38:
---
Github user coveralls commented on the issue:
https://github.com/apache/commons-numbers/pull/5
[](https://coveralls.io/builds/11817098)
Coverage remained the same at 83.124% when pulling
**9b0367e153c51804d5022051b6722e1419f1b016 on ameyjadiye:master** into
**c2bfc4fbf8fe325eaf254c37128948b7644e5687 on apache:master**.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036041#comment-16036041
]
Amey Jadiye commented on NUMBERS-38:
PR is raised, please have a look
https://github.com/apache/commons-numbers/pull/5
Thanks,
Amey
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036040#comment-16036040
]
ASF GitHub Bot commented on NUMBERS-38:
---
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-numbers/pull/5
[NUMBERS-38]: Added Junit test cases for LanczosApproximation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye/commons-numbers master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-numbers/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
commit 9b0367e153c51804d5022051b6722e1419f1b016
Author: Amey Jadiye
Date: 2017-06-03T18:42:19Z
[NUMBERS-38]: Added Junit test cases for LanczosApproximation
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036031#comment-16036031
]
Amey Jadiye commented on NUMBERS-38:
Ah, got it. will put some coverage around that, Thanks.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036028#comment-16036028
]
Gilles commented on NUMBERS-38:
---
There are no tests for the [value(double
x)|https://github.com/apache/commons-numbers/blob/d79edb264f71db3e88779efe2681fa8c48310c3c/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LanczosApproximation.java]
method.
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035990#comment-16035990
]
Amey Jadiye commented on NUMBERS-38:
Hi,
I can see one test class here, do we expect more test cases here ?
https://github.com/apache/commons-numbers/blob/d79edb264f71db3e88779efe2681fa8c48310c3c/commons-numbers-gamma/src/test/java/org/apache/commons/numbers/gamma/LanczosApproximationTest.java
> No unit tests for "LanczosApproximation" class
> --
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
>Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
