[jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
[ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig updated COMPRESS-300: Attachment: COMPRESS-300-alternative.patch imaging-compress-lzw-adjusted.patch This is an updated by patch of mine and an adjustment of [~damjan]'s patch to imaging. Thanks a lot Damjan. Your patch has shown that you didn't need more than what [~s...@apache.org]'s patch would have allowed you to - so I've cut back on my changes. The patch to imaging applies cleanly and builds against the patched compress with all unit tests passing. The main difference between my updated patch and Sebb's original are a few names and extracting a few constants. Unless anybody yells I plan to apply the patch to Commons during the coming week and call for a release shortly thereafter. LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private Key: COMPRESS-300 URL: https://issues.apache.org/jira/browse/COMPRESS-300 Project: Commons Compress Issue Type: Bug Reporter: Sebb Attachments: COMPRESS-300-alternative.patch, COMPRESS-300.patch, imaging-compress-lzw-adjusted.patch, imaging-compress-lzw.patch As per the discussion on the dev list, the class LZWInputStream has some non-private mutable fields. These should be accessed via getters/setters only (data encapsulation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
[ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig updated COMPRESS-300: Attachment: (was: COMPRESS-300-alternative.patch) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private Key: COMPRESS-300 URL: https://issues.apache.org/jira/browse/COMPRESS-300 Project: Commons Compress Issue Type: Bug Reporter: Sebb Attachments: COMPRESS-300.patch, imaging-compress-lzw.patch As per the discussion on the dev list, the class LZWInputStream has some non-private mutable fields. These should be accessed via getters/setters only (data encapsulation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
[ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damjan Jovanovic updated COMPRESS-300: -- Attachment: imaging-compress-lzw.patch Uncommitted patch I made to commons imaging (older version, might not apply now). You can see what bits of compress are used. It might be possible to simplify the patch further. LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private Key: COMPRESS-300 URL: https://issues.apache.org/jira/browse/COMPRESS-300 Project: Commons Compress Issue Type: Bug Reporter: Sebb Attachments: COMPRESS-300-alternative.patch, COMPRESS-300.patch, imaging-compress-lzw.patch As per the discussion on the dev list, the class LZWInputStream has some non-private mutable fields. These should be accessed via getters/setters only (data encapsulation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
[ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig updated COMPRESS-300: Attachment: COMPRESS-300-alternative.patch I've expanded sebb's patch a bit to also provide access to the remaining fields that are currently not used by existing subclasses inside COMPRESS. I've also tweaked a few things introduced by sebb, but these are really mostly cosmetic and I'm not attached to those tweaks. It would be good if we could resolve this quickly as dealing with LZWInputStream is really holding up the 1.10 release. LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private Key: COMPRESS-300 URL: https://issues.apache.org/jira/browse/COMPRESS-300 Project: Commons Compress Issue Type: Bug Reporter: Sebb Attachments: COMPRESS-300-alternative.patch, COMPRESS-300.patch As per the discussion on the dev list, the class LZWInputStream has some non-private mutable fields. These should be accessed via getters/setters only (data encapsulation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (COMPRESS-300) LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private
[ https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated COMPRESS-300: -- Attachment: COMPRESS-300.patch Patch that makes fields private, adding getters/setters as appropriate. Note that the getters/setters are adjusted according to the actual usage of the original protected fields. For example previousCode is only ever set to -1 externally, so it does not need a full setter. Not all the protected fields were originally accessed outside the containing class. LZWInputStream has mutable protected fields; these should be accessed via getter/setter and made private Key: COMPRESS-300 URL: https://issues.apache.org/jira/browse/COMPRESS-300 Project: Commons Compress Issue Type: Bug Reporter: Sebb Attachments: COMPRESS-300.patch As per the discussion on the dev list, the class LZWInputStream has some non-private mutable fields. These should be accessed via getters/setters only (data encapsulation). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
