[jira] [Created] (CB-6349) Return mime type in FileTransfer download
Joachim Piketz created CB-6349: -- Summary: Return mime type in FileTransfer download Key: CB-6349 URL: https://issues.apache.org/jira/browse/CB-6349 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: 3.3.0 Environment: Android Reporter: Joachim Piketz Return the mime type if the file is transferred using Url Connection. Changes in FileTransfer.java ... JSONObject fileEntry = FileUtils.getEntry(file); // added start if (connection != null) fileEntry.put("type", connection.getContentType()); // added end result = new PluginResult(PluginResult.Status.OK, fileEntry); ... Changes in JS Function FileTransfer.prototype.download ... entry.type = result.type; // added entry.isDirectory = result.isDirectory; ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6350) Return cellular connection type even if wifi is reachable on 64-bit iOS
Yann Lugrin created CB-6350: --- Summary: Return cellular connection type even if wifi is reachable on 64-bit iOS Key: CB-6350 URL: https://issues.apache.org/jira/browse/CB-6350 Project: Apache Cordova Issue Type: Bug Components: iOS, Plugin Network Information Reporter: Yann Lugrin When we get connection type on 64-bit iOS, return value is set to cellular event if wifi is reachable. On 64-bit iOS, "BOOL" is now the same as "bool", and the return type of networkStatusForFlags method cannot use this type anymore. Using "NetworkStatus" type resolve this issue. source on 64-bit iOS BOOL change: http://blog.bignerdranch.com/564-bools-sharp-corners/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6350) Return cellular connection type even if wifi is reachable on 64-bit iOS
[ https://issues.apache.org/jira/browse/CB-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947755#comment-13947755 ] ASF GitHub Bot commented on CB-6350: GitHub user yannlugrin opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/8 [CB-6350] Return cellular connection type even if wifi is reachable on 64-bit iOS Pull request related to: https://issues.apache.org/jira/browse/CB-6350 This path resolve issue by using NetworkStatus type instead of BOOL, because BOOL is now actually bool on 64-Bit iOS and cannot be used in this case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yannlugrin/cordova-plugin-network-information fix_wifi_detection_on_ios7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit 76a405827e8603c92f58a670539e04ca9d4d1a35 Author: Yann Lugrin Date: 2014-03-26T09:59:25Z Fix networkStatusForFlags return value type to work with 64-bit iOS > Return cellular connection type even if wifi is reachable on 64-bit iOS > --- > > Key: CB-6350 > URL: https://issues.apache.org/jira/browse/CB-6350 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Network Information >Reporter: Yann Lugrin > > When we get connection type on 64-bit iOS, return value is set to cellular > event if wifi is reachable. > On 64-bit iOS, "BOOL" is now the same as "bool", and the return type of > networkStatusForFlags method cannot use this type anymore. Using > "NetworkStatus" type resolve this issue. > source on 64-bit iOS BOOL change: > http://blog.bignerdranch.com/564-bools-sharp-corners/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6350) Return cellular connection type even if wifi is reachable on 64-bit iOS
[ https://issues.apache.org/jira/browse/CB-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947756#comment-13947756 ] Yann Lugrin commented on CB-6350: - Related pull request : https://github.com/apache/cordova-plugin-network-information/pull/8 > Return cellular connection type even if wifi is reachable on 64-bit iOS > --- > > Key: CB-6350 > URL: https://issues.apache.org/jira/browse/CB-6350 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Network Information >Reporter: Yann Lugrin > > When we get connection type on 64-bit iOS, return value is set to cellular > event if wifi is reachable. > On 64-bit iOS, "BOOL" is now the same as "bool", and the return type of > networkStatusForFlags method cannot use this type anymore. Using > "NetworkStatus" type resolve this issue. > source on 64-bit iOS BOOL change: > http://blog.bignerdranch.com/564-bools-sharp-corners/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Issue Comment Deleted] (CB-6350) Return cellular connection type even if wifi is reachable on 64-bit iOS
[ https://issues.apache.org/jira/browse/CB-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yann Lugrin updated CB-6350: Comment: was deleted (was: Related pull request : https://github.com/apache/cordova-plugin-network-information/pull/8) > Return cellular connection type even if wifi is reachable on 64-bit iOS > --- > > Key: CB-6350 > URL: https://issues.apache.org/jira/browse/CB-6350 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Network Information >Reporter: Yann Lugrin > > When we get connection type on 64-bit iOS, return value is set to cellular > event if wifi is reachable. > On 64-bit iOS, "BOOL" is now the same as "bool", and the return type of > networkStatusForFlags method cannot use this type anymore. Using > "NetworkStatus" type resolve this issue. > source on 64-bit iOS BOOL change: > http://blog.bignerdranch.com/564-bools-sharp-corners/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6117) cdvfile file url is not working with html5 image src
[ https://issues.apache.org/jira/browse/CB-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947778#comment-13947778 ] Chris Emerson commented on CB-6117: --- Will leaning on this .toNativeURL() break on newer Android/iOS File plugin usage? I was really liking the simple "cdfvile://" pathing approach but if Android 2.x only works with this toNativeURL() method I guess we have no choie. > cdvfile file url is not working with html5 image src > > > Key: CB-6117 > URL: https://issues.apache.org/jira/browse/CB-6117 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File, Plugin File Transfer >Affects Versions: 3.4.0 > Environment: Appears to be Android < 4.0.0 >Reporter: rita >Assignee: Ian Clelland >Priority: Critical > > Hi > I had used the fileTranser APi to download the image from a given path. > The image was downloaded at the path > cdvfile://localhost/persistent/SPB/ics-android.png. > But I am unable to access this image as url for tag in html.Same code > was working till 2.9.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5972) update firefox os docs pages
[ https://issues.apache.org/jira/browse/CB-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947883#comment-13947883 ] Piotr Zalewa commented on CB-5972: -- [~jlongster] can we close this issue? > update firefox os docs pages > > > Key: CB-5972 > URL: https://issues.apache.org/jira/browse/CB-5972 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: James Long > > Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files > It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5834) remove Firefox OS from CLI doc
[ https://issues.apache.org/jira/browse/CB-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947885#comment-13947885 ] Piotr Zalewa commented on CB-5834: -- [~sierra] can we please close it? Platform guide is there on the website > remove Firefox OS from CLI doc > -- > > Key: CB-5834 > URL: https://issues.apache.org/jira/browse/CB-5834 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Mike Sierra >Assignee: Mike Sierra >Priority: Minor > > The CLI doc mentions Firefox OS, including in examples, but there's no > platform guide yet to indicate support. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-5834) remove Firefox OS from CLI doc
[ https://issues.apache.org/jira/browse/CB-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Sierra resolved CB-5834. - Resolution: Fixed FF doc is now available > remove Firefox OS from CLI doc > -- > > Key: CB-5834 > URL: https://issues.apache.org/jira/browse/CB-5834 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Mike Sierra >Assignee: Mike Sierra >Priority: Minor > > The CLI doc mentions Firefox OS, including in examples, but there's no > platform guide yet to indicate support. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5834) remove Firefox OS from CLI doc
[ https://issues.apache.org/jira/browse/CB-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947894#comment-13947894 ] ASF GitHub Bot commented on CB-5834: Github user mike-sierra closed the pull request at: https://github.com/apache/cordova-docs/pull/168 > remove Firefox OS from CLI doc > -- > > Key: CB-5834 > URL: https://issues.apache.org/jira/browse/CB-5834 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Mike Sierra >Assignee: Mike Sierra >Priority: Minor > > The CLI doc mentions Firefox OS, including in examples, but there's no > platform guide yet to indicate support. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-89) Support Firefox Mobile (Fennec) as debug target
[ https://issues.apache.org/jira/browse/CB-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947899#comment-13947899 ] Piotr Zalewa commented on CB-89: I think we can close this - fennec is able to use marketplace for app installation > Support Firefox Mobile (Fennec) as debug target > --- > > Key: CB-89 > URL: https://issues.apache.org/jira/browse/CB-89 > Project: Apache Cordova > Issue Type: New Feature > Components: weinre >Reporter: Patrick Mueller >Assignee: Patrick Mueller > > from https://github.com/phonegap/weinre/issues/22 > *brion (Brion Vibber) opened this issue July 28, 2011* > Since the debugging shim in the web page runs in native JavaScript, it ought > to be possible in theory to use weinre with non-WebKit debugging targets as > long as the JS can get the info it needs. This could be quite handy for > testing a mobile web app on several browsers including Firefox for Android & > Meego. > I did a quick test with Firefox 5.0.1 on the desktop to see how much works > with weinre (my copy of Android firefox is currently not working for > unrelated reasons, but it's built from the same codebase as desktop firefox > and should behave about the same). > inspector... sorta works: > * HTML tree looks ok > * ... but no highlight of selected item > * ... no computed style/styles/metrics info > * ... properties are mislabeled (but this seems to be same problem using > Chrome and in the OSCON demo, so may be a regression in the inspector or > weinre itself) > * ... no event listeners info (but also doesn't work in Chrome 12) > basic console works: > * evaluate alert('hey') > * evaluate 25 + 32, get 57 > * evaluate $('p').css('color', 'red') on a jQuery-using page; it works, and > shows a list of HTMLParagraphElements as expected > resources: > * 'databases' is blank (ff has no websql support so that's probably fine!) > * 'local storage' and 'session storage' on the localhost does show entries... > but they're the setItem, clear, and removeItem methods. :) > timeline: > * appears to work similarly to target in Chrome > Even with the limited inspector, I would probably find this useful already. :D -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947903#comment-13947903 ] Piotr Zalewa commented on CB-5033: -- [~jlongster] could you please update on that? > Write tests for firefoxos in cordova-cli > > > Key: CB-5033 > URL: https://issues.apache.org/jira/browse/CB-5033 > Project: Apache Cordova > Issue Type: Task > Components: FirefoxOS >Reporter: James Long > > I'm going to add firefox os to the spec/metadata folder in cordova-cli so > that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6346) [BlackBerry10] Commit node_modules
[ https://issues.apache.org/jira/browse/CB-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947905#comment-13947905 ] ASF GitHub Bot commented on CB-6346: GitHub user bryanhiggins opened a pull request: https://github.com/apache/cordova-blackberry/pull/152 CB-6346 - Add node_modules to source control You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-blackberry addNodeModules Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #152 commit 1139813cd8b7ee4b1a103ada5577cab79b2c39e6 Author: Bryan Higgins Date: 2014-03-26T13:30:58Z CB-6346 - Add node_modules to source control > [BlackBerry10] Commit node_modules > -- > > Key: CB-6346 > URL: https://issues.apache.org/jira/browse/CB-6346 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.4.0 >Reporter: Bryan Higgins >Assignee: Bryan Higgins > Fix For: 3.5.0 > > > We should commit node_modules for cordova-blackberry rather than running npm > install within the init script. cordova-android has already moved to this > model. > https://www.npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947906#comment-13947906 ] ASF GitHub Bot commented on CB-4966: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/17 CB-4966 Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically This still creates dialogs inside main DOM You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-dialogs add-css-to-DOM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 8016d774cbe19709c2d68024d2a74e85b7f6d372 Author: Piotr Zalewa Date: 2014-03-26T13:20:19Z Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6351) setMetadata fails silently
Robin Zeggelaar created CB-6351: --- Summary: setMetadata fails silently Key: CB-6351 URL: https://issues.apache.org/jira/browse/CB-6351 Project: Apache Cordova Issue Type: Bug Components: Plugin File Affects Versions: 3.4.0 Reporter: Robin Zeggelaar In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not seem to have this issue. On the javascript side the following call is made (Entry.js): exec(successCallback, errorCallback, "File", "setMetadata", [this.fullPath, metadataObject]); This fails silently on the native end. My callbacks are not invoked. I fixed this by changing this.fullPath to this.toURL(), conform the changes to the File plugin. After this change the callbacks did get invoked properly. Could you take a look at this and fix it in a future release? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-5972) update firefox os docs pages
[ https://issues.apache.org/jira/browse/CB-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Long closed CB-5972. -- Resolution: Fixed > update firefox os docs pages > > > Key: CB-5972 > URL: https://issues.apache.org/jira/browse/CB-5972 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: James Long > > Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files > It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5972) update firefox os docs pages
[ https://issues.apache.org/jira/browse/CB-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947986#comment-13947986 ] James Long commented on CB-5972: Yep, it's live: http://cordova.apache.org/docs/en/3.4.0/guide_platforms_firefoxos_index.md.html#Firefox%20OS%20Platform%20Guide > update firefox os docs pages > > > Key: CB-5972 > URL: https://issues.apache.org/jira/browse/CB-5972 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: James Long > > Please merge this PR: https://github.com/apache/cordova-docs/pull/183/files > It adds a page for Firefox OS in the docs. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5033) Write tests for firefoxos in cordova-cli
[ https://issues.apache.org/jira/browse/CB-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947988#comment-13947988 ] James Long commented on CB-5033: I never really got anywhere. The tests were too confusing and it was more important to get tests for each plugin. I never figured out why a lot of the tests were failing out of the box. > Write tests for firefoxos in cordova-cli > > > Key: CB-5033 > URL: https://issues.apache.org/jira/browse/CB-5033 > Project: Apache Cordova > Issue Type: Task > Components: FirefoxOS >Reporter: James Long > > I'm going to add firefox os to the spec/metadata folder in cordova-cli so > that we can test it. Might have some questions as I go through it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6351) setMetadata fails silently
[ https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland reassigned CB-6351: Assignee: Ian Clelland > setMetadata fails silently > -- > > Key: CB-6351 > URL: https://issues.apache.org/jira/browse/CB-6351 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 >Reporter: Robin Zeggelaar >Assignee: Ian Clelland > Labels: setMetadata > > In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not > seem to have this issue. > On the javascript side the following call is made (Entry.js): > exec(successCallback, errorCallback, "File", "setMetadata", [this.fullPath, > metadataObject]); > This fails silently on the native end. My callbacks are not invoked. I fixed > this by changing this.fullPath to this.toURL(), conform the changes to the > File plugin. After this change the callbacks did get invoked properly. > Could you take a look at this and fix it in a future release? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948045#comment-13948045 ] ASF GitHub Bot commented on CB-6337: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10983854 --- Diff: src/metadata/tizen_parser.js --- @@ -0,0 +1,131 @@ +var Q = require( "q" ), + shelljs = require( "shelljs" ), + util = require( "../util" ), + elementTree = require( "elementtree" ), + exec = require( "child_process" ).exec, + path = require( "path" ); + +function genPackageId() { + var idx, + returnValue = ""; + characters = [ + "0", "1", "2", "3", "4", "5", "6", "7", "8", "9", + "a", "b", "c", "d", "e", "f", "g", "h", "i", "j", + "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", + "u", "v", "w", "x", "y", "z" ]; + + for ( idx = 0 ; idx < 10 ; idx++ ) { + returnValue += ( characters[ Math.round( Math.random() * 35 ) ] ); + } + + return returnValue; +} + +module.exports = function tizen_parser( project ) { + this.path = project; +} + +// Returns a promise +module.exports.check_requirements = function( project_root ) { + var deferred = Q.defer(); + + exec( "web-build", {}, function( error, stdout, stderr ) { + if ( error ) { + deferred.reject( new Error( "Requirements check failed. Command 'web-build' not found." ) ); --- End diff -- Please see CB-6337 and use CordovaError instead of Error (don't forget to add the require for it) > Print nice error when cordova-cli hits various expected things > -- > > Key: CB-6337 > URL: https://issues.apache.org/jira/browse/CB-6337 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > CB-5782 introduced a way to silence stack traces for expected failures, but > it missed some spots. > This is a first pass against things in CLI itself -- it doesn't cover errors > coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5175) Fix core plugins that incorrectly run on main thread
[ https://issues.apache.org/jira/browse/CB-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948052#comment-13948052 ] ASF GitHub Bot commented on CB-5175: Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 This looks like it should be part of the work for [CB-5175](https://issues.apache.org/jira/browse/CB-5175). Thanks for the patch, Jorge -- have you signed the [Apache ICLA](http://www.apache.org/licenses/#clas)? > Fix core plugins that incorrectly run on main thread > > > Key: CB-5175 > URL: https://issues.apache.org/jira/browse/CB-5175 > Project: Apache Cordova > Issue Type: Bug > Components: Docs, Plugin Device Orientation, Plugin File, Plugin > Media >Reporter: Mike Billau >Assignee: Mike Billau >Priority: Minor > > After CB-4133 we are able to detect and log when a plugin incorrectly does > work on the UI thread instead of a worker thread. We should go back and > verify that all of our plugins follow this practice - eat your own dogfood > type of thing. > We know there are problems with: > Android: file, compass > iOS: media > Docs: Need to verify plugin author guide is still valid -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (CB-89) Support Firefox Mobile (Fennec) as debug target
[ https://issues.apache.org/jira/browse/CB-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Mueller closed CB-89. - > Support Firefox Mobile (Fennec) as debug target > --- > > Key: CB-89 > URL: https://issues.apache.org/jira/browse/CB-89 > Project: Apache Cordova > Issue Type: New Feature > Components: weinre >Reporter: Patrick Mueller >Assignee: Patrick Mueller > > from https://github.com/phonegap/weinre/issues/22 > *brion (Brion Vibber) opened this issue July 28, 2011* > Since the debugging shim in the web page runs in native JavaScript, it ought > to be possible in theory to use weinre with non-WebKit debugging targets as > long as the JS can get the info it needs. This could be quite handy for > testing a mobile web app on several browsers including Firefox for Android & > Meego. > I did a quick test with Firefox 5.0.1 on the desktop to see how much works > with weinre (my copy of Android firefox is currently not working for > unrelated reasons, but it's built from the same codebase as desktop firefox > and should behave about the same). > inspector... sorta works: > * HTML tree looks ok > * ... but no highlight of selected item > * ... no computed style/styles/metrics info > * ... properties are mislabeled (but this seems to be same problem using > Chrome and in the OSCON demo, so may be a regression in the inspector or > weinre itself) > * ... no event listeners info (but also doesn't work in Chrome 12) > basic console works: > * evaluate alert('hey') > * evaluate 25 + 32, get 57 > * evaluate $('p').css('color', 'red') on a jQuery-using page; it works, and > shows a list of HTMLParagraphElements as expected > resources: > * 'databases' is blank (ff has no websql support so that's probably fine!) > * 'local storage' and 'session storage' on the localhost does show entries... > but they're the setItem, clear, and removeItem methods. :) > timeline: > * appears to work similarly to target in Chrome > Even with the limited inspector, I would probably find this useful already. :D -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-89) Support Firefox Mobile (Fennec) as debug target
[ https://issues.apache.org/jira/browse/CB-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Mueller resolved CB-89. --- Resolution: Done closing as no longer relevant, due to better tooling elsewhere > Support Firefox Mobile (Fennec) as debug target > --- > > Key: CB-89 > URL: https://issues.apache.org/jira/browse/CB-89 > Project: Apache Cordova > Issue Type: New Feature > Components: weinre >Reporter: Patrick Mueller >Assignee: Patrick Mueller > > from https://github.com/phonegap/weinre/issues/22 > *brion (Brion Vibber) opened this issue July 28, 2011* > Since the debugging shim in the web page runs in native JavaScript, it ought > to be possible in theory to use weinre with non-WebKit debugging targets as > long as the JS can get the info it needs. This could be quite handy for > testing a mobile web app on several browsers including Firefox for Android & > Meego. > I did a quick test with Firefox 5.0.1 on the desktop to see how much works > with weinre (my copy of Android firefox is currently not working for > unrelated reasons, but it's built from the same codebase as desktop firefox > and should behave about the same). > inspector... sorta works: > * HTML tree looks ok > * ... but no highlight of selected item > * ... no computed style/styles/metrics info > * ... properties are mislabeled (but this seems to be same problem using > Chrome and in the OSCON demo, so may be a regression in the inspector or > weinre itself) > * ... no event listeners info (but also doesn't work in Chrome 12) > basic console works: > * evaluate alert('hey') > * evaluate 25 + 32, get 57 > * evaluate $('p').css('color', 'red') on a jQuery-using page; it works, and > shows a list of HTMLParagraphElements as expected > resources: > * 'databases' is blank (ff has no websql support so that's probably fine!) > * 'local storage' and 'session storage' on the localhost does show entries... > but they're the setItem, clear, and removeItem methods. :) > timeline: > * appears to work similarly to target in Chrome > Even with the limited inspector, I would probably find this useful already. :D -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6351) setMetadata fails silently
[ https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948163#comment-13948163 ] Ian Clelland commented on CB-6351: -- Have you recently updated your Cordova project? The current version of Entry.js in the File plugin uses this line: {code} exec(successCallback, errorCallback, "File", "setMetadata", [this.filesystem.__format__(this.fullPath), metadataObject]); {code} which is functionally equivalent to using {{.toURL()}}. It seems like you might be using new native code with old JavaScript. This has come up a couple of times with people upgrading their projects / plugins. I suspect it is a plugin upgrade bug. > setMetadata fails silently > -- > > Key: CB-6351 > URL: https://issues.apache.org/jira/browse/CB-6351 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 3.4.0 >Reporter: Robin Zeggelaar >Assignee: Ian Clelland > Labels: setMetadata > > In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not > seem to have this issue. > On the javascript side the following call is made (Entry.js): > exec(successCallback, errorCallback, "File", "setMetadata", [this.fullPath, > metadataObject]); > This fails silently on the native end. My callbacks are not invoked. I fixed > this by changing this.fullPath to this.toURL(), conform the changes to the > File plugin. After this change the callbacks did get invoked properly. > Could you take a look at this and fix it in a future release? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948173#comment-13948173 ] ASF GitHub Bot commented on CB-6337: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/150 Fix errors from CB-6337 CB-6338 I can't actually find our CI to confirm that it likes everything, but `npm test` only shows the errors that aren't mine. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-cli cb_6337 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 commit 4f4dc29af98d8080507c0d6fe0015cec780fd701 Author: Josh Soref Date: 2014-03-26T15:57:27Z CB-6337 Print nice error when cordova-cli hits various expected things Add missing CordovaError requires Reduce specificity of jasmine toThrow() expectations commit da34130e063da5d4e4c5ab96cb75d1e47e3a7581 Author: Josh Soref Date: 2014-03-26T15:58:30Z CB-6338 Improve error for missing template Fix create test to properly lie about lib/dir > Print nice error when cordova-cli hits various expected things > -- > > Key: CB-6337 > URL: https://issues.apache.org/jira/browse/CB-6337 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > CB-5782 introduced a way to silence stack traces for expected failures, but > it missed some spots. > This is a first pass against things in CLI itself -- it doesn't cover errors > coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6347) Camera->"Copy Image" failed !
[ https://issues.apache.org/jira/browse/CB-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland reassigned CB-6347: Assignee: Ian Clelland > Camera->"Copy Image" failed ! > - > > Key: CB-6347 > URL: https://issues.apache.org/jira/browse/CB-6347 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, mobile-spec, Plugin Camera, Plugin File >Affects Versions: 3.4.0 > Environment: org.apache.cordova.camera version: 0.2.9-dev >Reporter: glmnbeyond >Assignee: Ian Clelland > > Steps to reproduce it: > 1) Using createmobilespec.sh to create mobilespec project > 2) Load mobile-spec tests > 3) Navigate to "Camera" and "getPicture()" > 4) Click "Copy Image" > Results: > Copy image succeeded, but no results got outputted! > Expected: > FileEntry.copyTo success! > If I try catch the function log, there is an exception says "TypeError: > JSON.stringify cannot serialize cyclic structures" -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6352) FileSystem objects are not JSON-serializable
Ian Clelland created CB-6352: Summary: FileSystem objects are not JSON-serializable Key: CB-6352 URL: https://issues.apache.org/jira/browse/CB-6352 Project: Apache Cordova Issue Type: Bug Components: Plugin File Reporter: Ian Clelland Assignee: Ian Clelland Attempting to render a FileSystem object (or a FileEntry, or DirectoryEntry, or any other object with a FileSystem contained it) results in the error: {code} TypeError: JSON.stringify cannot serialize cyclic structures. {code} (This is new behaviour with File 1.0.0) This happens because of a cycle in the FileSystem object structure: FileSystem contains a 'root' property, which is a DirectoryEntry. The DirectoryEntry contains a 'filesystem' property, which is the original FileSystem. I think that we can solve this with a {{.toJSON()}} method on the FileSystem object. This is supported (tested) on iOS and Android, and appears to be present in all versions of WebKit back to 2009. I don't believe that the presence of this method should have any side effects on webviews (if there are any) which do not support it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6347) Camera->"Copy Image" failed !
[ https://issues.apache.org/jira/browse/CB-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948208#comment-13948208 ] Ian Clelland commented on CB-6347: -- I think this is because there actually *is* a cycle in the filesystem object (which is being rendered to JSON by the "logCallback" part of the test) I've come across this before in other situations; it's reasonable to expect people to want to serialize FileEntry (and related) objects. I've created CB-6352 to track the JSON issue. > Camera->"Copy Image" failed ! > - > > Key: CB-6347 > URL: https://issues.apache.org/jira/browse/CB-6347 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, mobile-spec, Plugin Camera, Plugin File >Affects Versions: 3.4.0 > Environment: org.apache.cordova.camera version: 0.2.9-dev >Reporter: glmnbeyond >Assignee: Ian Clelland > > Steps to reproduce it: > 1) Using createmobilespec.sh to create mobilespec project > 2) Load mobile-spec tests > 3) Navigate to "Camera" and "getPicture()" > 4) Click "Copy Image" > Results: > Copy image succeeded, but no results got outputted! > Expected: > FileEntry.copyTo success! > If I try catch the function log, there is an exception says "TypeError: > JSON.stringify cannot serialize cyclic structures" -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6352) FileSystem objects are not JSON-serializable
[ https://issues.apache.org/jira/browse/CB-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948235#comment-13948235 ] ASF subversion and git services commented on CB-6352: - Commit 1eab4dbc648453f6a6ecbaaa0bd705690019e9cd in cordova-plugin-file's branch refs/heads/dev from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=1eab4db ] CB-6352: Allow FileSystem objects to be serialized to JSON > FileSystem objects are not JSON-serializable > > > Key: CB-6352 > URL: https://issues.apache.org/jira/browse/CB-6352 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Reporter: Ian Clelland >Assignee: Ian Clelland > > Attempting to render a FileSystem object (or a FileEntry, or DirectoryEntry, > or any other object with a FileSystem contained it) results in the error: > {code} > TypeError: JSON.stringify cannot serialize cyclic structures. > {code} > (This is new behaviour with File 1.0.0) > This happens because of a cycle in the FileSystem object structure: > FileSystem contains a 'root' property, which is a DirectoryEntry. The > DirectoryEntry contains a 'filesystem' property, which is the original > FileSystem. > I think that we can solve this with a {{.toJSON()}} method on the FileSystem > object. This is supported (tested) on iOS and Android, and appears to be > present in all versions of WebKit back to 2009. I don't believe that the > presence of this method should have any side effects on webviews (if there > are any) which do not support it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6265) CLI guide omits Windows workstations using CLI for Android projects
[ https://issues.apache.org/jira/browse/CB-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948279#comment-13948279 ] Marcel Kinard commented on CB-6265: --- [~mwbrooks]: what markdown executable are you using, v1.0.1 from daringfireball.net, or a derivative? > CLI guide omits Windows workstations using CLI for Android projects > --- > > Key: CB-6265 > URL: https://issues.apache.org/jira/browse/CB-6265 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Affects Versions: 3.2.0 >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > Fix For: 3.5.0 > > > In > http://cordova.apache.org/docs/en/3.4.0/guide_cli_index.md.html#The%20Command-Line%20Interface > it has the following line for Android: > Android (Mac, Linux) > Windows is obviously missing. Appears to be a defect in the docs going back > to 3.2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6329) [cordova-cli] improve 'cordova info' command to work asynchronous
[ https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948306#comment-13948306 ] ASF GitHub Bot commented on CB-6329: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-cli/pull/151 CB-6329 improve 'cordova info' command info.js file has been modified to work mainly asynchronous. Added info-utils, which contains several useful functions required by info.js -It doesn't require a template to set an output. -getNode, getCordova, doPlatforms works asynchronous, works with callbacks and deals with errors. -it writes a report (info.txt) in rootProject. This changes are required for futures improvements. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-cli CB-6329 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit aaf54666f4c9a99d910620d42baf5599d85dd7df Author: Martin Gonzalez Date: 2014-03-26T18:48:08Z CB-6329 improve 'cordova info' command info.js file has been modified to work mainly asynchronous. Added info-utils, which contains several useful functions required by info.js -It doesn't require a template to set an output. -getNode, getCordova, doPlatforms works asynchronous, works with callbacks and deals with errors. -it writes a report (info.txt) in rootProject. This changes are required for futures improvements. > [cordova-cli] improve 'cordova info' command to work asynchronous > - > > Key: CB-6329 > URL: https://issues.apache.org/jira/browse/CB-6329 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Affects Versions: 3.4.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: blackberry, cordova-cli, environment, info, wp8 > Fix For: 3.5.0 > > > The 'cordova info' command it works in total sync, it takes some time to pull > and push all data from the environment, so in order to use callbacks more > friendly, I'd like to modify the flow structure of the file and improve it to > use get callback outputs, write summary or log file without templates. > I also, I'd like to add a secondary file that holds all specific functions > related with 'get information about the dev environment'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6265) CLI guide omits Windows workstations using CLI for Android projects
[ https://issues.apache.org/jira/browse/CB-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948322#comment-13948322 ] Michael Brooks commented on CB-6265: [~cmarcelk] I'm using v1.0.1 from daringfireball.net: {code} $ markdown -v This is Markdown, version 1.0.1. Copyright 2004 John Gruber http://daringfireball.net/projects/markdown/ {code} However, it appears that I've installed it via brew: {code} $ brew info markdown markdown: stable 1.0.1 http://daringfireball.net/projects/markdown/ {code} You can install it on OS X with: {code} $ sudo brew install markdown {code} > CLI guide omits Windows workstations using CLI for Android projects > --- > > Key: CB-6265 > URL: https://issues.apache.org/jira/browse/CB-6265 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Affects Versions: 3.2.0 >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > Fix For: 3.5.0 > > > In > http://cordova.apache.org/docs/en/3.4.0/guide_cli_index.md.html#The%20Command-Line%20Interface > it has the following line for Android: > Android (Mac, Linux) > Windows is obviously missing. Appears to be a defect in the docs going back > to 3.2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948324#comment-13948324 ] ASF GitHub Bot commented on CB-5082: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-cli/pull/152 CB-5082 [CLI] BB10 add support in doPlatform() https://issues.apache.org/jira/browse/CB-5082 Support for blackberry10, when 'cordova info' command is used to retrieve information about the dev environment. It provides: -BB10 NDK version. -It gets information about every devices or emulator, used to deploy a cordova application using the 'cordova run/build' command. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-cli CB-5082 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #152 commit 501b8242c90eeeff7ad320aa90559ff4438956cb Author: Martin Gonzalez Date: 2014-03-26T19:00:09Z CB-5082 [CLI] BB10 add support in doPlatform() Support for blackberry10, when 'cordova info' command is used to retrieve information about the dev environment. It provides: -BB10 NDK version. -It gets information about every devices or emulator, used to deploy a cordova application using the 'cordova run/build' command. > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6333) getPicture won't return photo after first shot, but the second shot will return first shot.
[ https://issues.apache.org/jira/browse/CB-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948329#comment-13948329 ] Marcel Kinard commented on CB-6333: --- [~bowserj], was this fixed via a different Jira issue? The reason I ask is that I don't see a commit listed here, and the last commit to dev of cordova-plugin-camera was 13 days ago. I'd like to peek at your fix, as it sounds similar to CB-6047. Can you point me to your commit? Thanks! > getPicture won't return photo after first shot, but the second shot will > return first shot. > --- > > Key: CB-6333 > URL: https://issues.apache.org/jira/browse/CB-6333 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Camera >Affects Versions: 3.4.0 > Environment: osx 10.9.1 >Reporter: Zhang Hong >Assignee: Joe Bowser > > i've found that we have similar issues on other versions. > 3.4.0-0.1.3 still has this issue. > reproduce > 1. create new blank project > 2. add platform android > 3. fetch device plugin > 4. fetch camera plugin > 5. write some js code follow document > 6. build it for android > tested on s4 4.2.2 and genymotion with built-in camera 4.4.2 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6333) getPicture won't return photo after first shot, but the second shot will return first shot.
[ https://issues.apache.org/jira/browse/CB-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948340#comment-13948340 ] Joe Bowser commented on CB-6333: I didn't actually fix anything. I literally checked out the dev branch of the plugin to see if this was still an issue on the dev branch, since it's fixed, I marked it as fixed. > getPicture won't return photo after first shot, but the second shot will > return first shot. > --- > > Key: CB-6333 > URL: https://issues.apache.org/jira/browse/CB-6333 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Plugin Camera >Affects Versions: 3.4.0 > Environment: osx 10.9.1 >Reporter: Zhang Hong >Assignee: Joe Bowser > > i've found that we have similar issues on other versions. > 3.4.0-0.1.3 still has this issue. > reproduce > 1. create new blank project > 2. add platform android > 3. fetch device plugin > 4. fetch camera plugin > 5. write some js code follow document > 6. build it for android > tested on s4 4.2.2 and genymotion with built-in camera 4.4.2 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948341#comment-13948341 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993531 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ +var cordova_util = require('./util'), +child_process = require('child_process'), +path = require('path'), +fs= require('fs'), +_self; + +_self = { + +getNodeInfo: function( callback ){ + callback(_self.execFunc('node', '--version', function(call){callback(call);})); + }, + +getCordovaInfo: function( callback ){ + callback(_self.execFunc('cordova', '--version', function(call){callback(call);})); + }, + +getPlatformInfo: function(platform, projectRoot, callback ){ + var command="", args=""; + switch( platform ){ + case "ios": + _self.execFunc('xcodebuild', '-version', function(call){callback('iOS Platform:\r\r' +call);}); + break; + case "android": + _self.execFunc('android', 'list target', function(call){callback('Android Platform:\r\r' +call);}); + break; + case "blackberry10": + var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 'cordova'), + bbBuildPath= path.join(projectRoot, 'platforms', platform, 'build'), + bbresults=""; + //get CORDOVA_BBTOOLS environment variable. + _self.get_pathEnv( ['blackberry-nativepackager', 'blackberry-deploy'], function (path){ + if(path){ + //set CORDOVA_BBTOOLS environment variable. + _self.setEnv_Var('CORDOVA_BBTOOLS', path); + // Get BB10 SDK Version + _self.getSDKinfo(bbUtilsPath, function(result){ + if(result){bbresults+="Blackberry 10 NDK version: "+result+"\r"; + // Get BB10 deployed and stored devices + _self.deployedDevices(bbUtilsPath, 'device', false, function(result){ + if(result){bbresults+="\rBlackberry 10 deployed devices:\r"+result+"\r"; + // Get BB10 deployed and stored emulators + _self.deployedDevices(bbUtilsPath, 'emulator', false, function (result){ + if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r"; + callback('Blackberry10 Platform:\r\r' +bbresults); + }}); + }}); + }}); + + } + else{callback("Blackberry 10 NDK path not found");} --- End diff -- Please don't misspell the brand. > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Go
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948344#comment-13948344 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993657 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ +var cordova_util = require('./util'), +child_process = require('child_process'), +path = require('path'), +fs= require('fs'), +_self; + +_self = { + +getNodeInfo: function( callback ){ + callback(_self.execFunc('node', '--version', function(call){callback(call);})); + }, + +getCordovaInfo: function( callback ){ + callback(_self.execFunc('cordova', '--version', function(call){callback(call);})); + }, + +getPlatformInfo: function(platform, projectRoot, callback ){ + var command="", args=""; + switch( platform ){ + case "ios": + _self.execFunc('xcodebuild', '-version', function(call){callback('iOS Platform:\r\r' +call);}); + break; + case "android": + _self.execFunc('android', 'list target', function(call){callback('Android Platform:\r\r' +call);}); + break; + case "blackberry10": + var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 'cordova'), + bbBuildPath= path.join(projectRoot, 'platforms', platform, 'build'), + bbresults=""; + //get CORDOVA_BBTOOLS environment variable. + _self.get_pathEnv( ['blackberry-nativepackager', 'blackberry-deploy'], function (path){ + if(path){ + //set CORDOVA_BBTOOLS environment variable. + _self.setEnv_Var('CORDOVA_BBTOOLS', path); + // Get BB10 SDK Version + _self.getSDKinfo(bbUtilsPath, function(result){ + if(result){bbresults+="Blackberry 10 NDK version: "+result+"\r"; + // Get BB10 deployed and stored devices + _self.deployedDevices(bbUtilsPath, 'device', false, function(result){ + if(result){bbresults+="\rBlackberry 10 deployed devices:\r"+result+"\r"; + // Get BB10 deployed and stored emulators + _self.deployedDevices(bbUtilsPath, 'emulator', false, function (result){ + if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r"; + callback('Blackberry10 Platform:\r\r' +bbresults); + }}); + }}); + }}); + + } + else{callback("Blackberry 10 NDK path not found");} + }); + break; + } + }, + +execFunc: function(command, args, callback){ + child_process.exec(command + ' ' +args, + function (error, stdout, stderr) { + callback(stdout); + if (error !== null) { + callback('Error performing
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948343#comment-13948343 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993586 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ +var cordova_util = require('./util'), +child_process = require('child_process'), +path = require('path'), +fs= require('fs'), +_self; + +_self = { + +getNodeInfo: function( callback ){ + callback(_self.execFunc('node', '--version', function(call){callback(call);})); + }, + +getCordovaInfo: function( callback ){ + callback(_self.execFunc('cordova', '--version', function(call){callback(call);})); + }, + +getPlatformInfo: function(platform, projectRoot, callback ){ + var command="", args=""; + switch( platform ){ + case "ios": + _self.execFunc('xcodebuild', '-version', function(call){callback('iOS Platform:\r\r' +call);}); + break; + case "android": + _self.execFunc('android', 'list target', function(call){callback('Android Platform:\r\r' +call);}); + break; + case "blackberry10": + var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 'cordova'), + bbBuildPath= path.join(projectRoot, 'platforms', platform, 'build'), + bbresults=""; + //get CORDOVA_BBTOOLS environment variable. + _self.get_pathEnv( ['blackberry-nativepackager', 'blackberry-deploy'], function (path){ + if(path){ + //set CORDOVA_BBTOOLS environment variable. + _self.setEnv_Var('CORDOVA_BBTOOLS', path); + // Get BB10 SDK Version + _self.getSDKinfo(bbUtilsPath, function(result){ + if(result){bbresults+="Blackberry 10 NDK version: "+result+"\r"; + // Get BB10 deployed and stored devices + _self.deployedDevices(bbUtilsPath, 'device', false, function(result){ + if(result){bbresults+="\rBlackberry 10 deployed devices:\r"+result+"\r"; + // Get BB10 deployed and stored emulators + _self.deployedDevices(bbUtilsPath, 'emulator', false, function (result){ + if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r"; + callback('Blackberry10 Platform:\r\r' +bbresults); + }}); + }}); + }}); + + } + else{callback("Blackberry 10 NDK path not found");} + }); + break; + } + }, + +execFunc: function(command, args, callback){ + child_process.exec(command + ' ' +args, + function (error, stdout, stderr) { + callback(stdout); + if (error !== null) { + callback('Error performing
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948346#comment-13948346 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993698 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ +var cordova_util = require('./util'), +child_process = require('child_process'), +path = require('path'), +fs= require('fs'), +_self; + +_self = { + +getNodeInfo: function( callback ){ + callback(_self.execFunc('node', '--version', function(call){callback(call);})); + }, + +getCordovaInfo: function( callback ){ + callback(_self.execFunc('cordova', '--version', function(call){callback(call);})); + }, + +getPlatformInfo: function(platform, projectRoot, callback ){ + var command="", args=""; + switch( platform ){ + case "ios": + _self.execFunc('xcodebuild', '-version', function(call){callback('iOS Platform:\r\r' +call);}); + break; + case "android": + _self.execFunc('android', 'list target', function(call){callback('Android Platform:\r\r' +call);}); + break; + case "blackberry10": + var bbUtilsPath = path.join(projectRoot, 'platforms', platform, 'cordova'), + bbBuildPath= path.join(projectRoot, 'platforms', platform, 'build'), + bbresults=""; + //get CORDOVA_BBTOOLS environment variable. + _self.get_pathEnv( ['blackberry-nativepackager', 'blackberry-deploy'], function (path){ + if(path){ + //set CORDOVA_BBTOOLS environment variable. + _self.setEnv_Var('CORDOVA_BBTOOLS', path); + // Get BB10 SDK Version + _self.getSDKinfo(bbUtilsPath, function(result){ + if(result){bbresults+="Blackberry 10 NDK version: "+result+"\r"; + // Get BB10 deployed and stored devices + _self.deployedDevices(bbUtilsPath, 'device', false, function(result){ + if(result){bbresults+="\rBlackberry 10 deployed devices:\r"+result+"\r"; + // Get BB10 deployed and stored emulators + _self.deployedDevices(bbUtilsPath, 'emulator', false, function (result){ + if(result){bbresults+="\rBlackberry deployed emulator:\r"+result+"\r"; + callback('Blackberry10 Platform:\r\r' +bbresults); + }}); + }}); + }}); + + } + else{callback("Blackberry 10 NDK path not found");} + }); + break; + } + }, + +execFunc: function(command, args, callback){ + child_process.exec(command + ' ' +args, + function (error, stdout, stderr) { + callback(stdout); + if (error !== null) { + callback('Error performing
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948345#comment-13948345 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993672 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** --- End diff -- No one likes tabs > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948356#comment-13948356 ] ASF GitHub Bot commented on CB-5082: Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38729077 Well, I'm using windows as my main development environment, sorry about the misspell, I have fixed that up. I've added the line at the end as well. The set env function it sets, if is not already set by the init command at the blackberry library, I'm setting the cordova_ BBTools var, because is used by target-utils.js, located in the blackberry library, it's the very same variable that is set in this file: https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/init.bat#L83 > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948364#comment-13948364 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38730048 Right, I'm not saying you shouldn't set environment variables before calling children. It's about how you call them and for whom. You shouldn't be using process.env for this purpose, see http://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options for how one passes special env values. > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6327) Facebook Connect plugin blocked by callbackId restricted characters
[ https://issues.apache.org/jira/browse/CB-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948397#comment-13948397 ] ASF subversion and git services commented on CB-6327: - Commit 286d7bf15fbe626b17d2f501fce497753353743b in cordova-ios's branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=286d7bf ] CB-6327: Allow '.' in plugin feature names (and therefore callback ids) > Facebook Connect plugin blocked by callbackId restricted characters > --- > > Key: CB-6327 > URL: https://issues.apache.org/jira/browse/CB-6327 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Ian Clelland >Assignee: Ian Clelland >Priority: Blocker > > The FB Connect plugin uses a period character ('.', U+002E) in it's feature > name. (Specifically, it uses the reverse-DNS name > "org.apache.cordova.facebook.Connect") > This produces a callbackId in the bridge which is blocked, as of commit > 7da5f2d. > reverse-dns-style naming seems like a legitimate use of the feature name, so > I'm inclined to add the period to the list of allowed characters. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6353) Fix up mobile styling for home page
Steve Gill created CB-6353: -- Summary: Fix up mobile styling for home page Key: CB-6353 URL: https://issues.apache.org/jira/browse/CB-6353 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Steve Gill Assignee: Steve Gill header + lists -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948405#comment-13948405 ] Steve Gill commented on CB-6279: Windows phone 8, phone 7 aren't filtering properly > Add filter by platform > -- > > Key: CB-6279 > URL: https://issues.apache.org/jira/browse/CB-6279 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6327) Facebook Connect plugin blocked by callbackId restricted characters
[ https://issues.apache.org/jira/browse/CB-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Clelland resolved CB-6327. -- Resolution: Fixed > Facebook Connect plugin blocked by callbackId restricted characters > --- > > Key: CB-6327 > URL: https://issues.apache.org/jira/browse/CB-6327 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 >Reporter: Ian Clelland >Assignee: Ian Clelland >Priority: Blocker > > The FB Connect plugin uses a period character ('.', U+002E) in it's feature > name. (Specifically, it uses the reverse-DNS name > "org.apache.cordova.facebook.Connect") > This produces a callbackId in the bridge which is blocked, as of commit > 7da5f2d. > reverse-dns-style naming seems like a legitimate use of the feature name, so > I'm inclined to add the period to the list of allowed characters. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6285) Performance optimization review
[ https://issues.apache.org/jira/browse/CB-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948421#comment-13948421 ] Steve Gill commented on CB-6285: I'm going to look at how the old search view works and bring some of that over to the new view. > Performance optimization review > --- > > Key: CB-6285 > URL: https://issues.apache.org/jira/browse/CB-6285 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web > Environment: The site needs a look over for ways to improve > performance. Some of the views could be using more appropriate limits for > document retrieval. Some new views can be written, etc. Need to identify and > fix. >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6285) Performance optimization review
[ https://issues.apache.org/jira/browse/CB-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-6285: -- Assignee: Steve Gill (was: Josh Bavari) > Performance optimization review > --- > > Key: CB-6285 > URL: https://issues.apache.org/jira/browse/CB-6285 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web > Environment: The site needs a look over for ways to improve > performance. Some of the views could be using more appropriate limits for > document retrieval. Some new views can be written, etc. Need to identify and > fix. >Reporter: Steve Gill >Assignee: Steve Gill > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6354) Merge viewall and search
Steve Gill created CB-6354: -- Summary: Merge viewall and search Key: CB-6354 URL: https://issues.apache.org/jira/browse/CB-6354 Project: Apache Cordova Issue Type: Sub-task Reporter: Steve Gill change search url to be search/searchterm instead of search?search=searchterm add filter to viewAll Make them use same couchdb view -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6355) Review Downloads
Steve Gill created CB-6355: -- Summary: Review Downloads Key: CB-6355 URL: https://issues.apache.org/jira/browse/CB-6355 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Steve Gill Assignee: Steve Gill Downloads stopped working properly locally. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6286) Paging
[ https://issues.apache.org/jira/browse/CB-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill updated CB-6286: --- Summary: Paging (was: Set results limit on search results and view all) > Paging > -- > > Key: CB-6286 > URL: https://issues.apache.org/jira/browse/CB-6286 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web > Environment: Need to add "view next 25 results" to the end of the > viewAll page. This way we aren't retrieving all of the plugins before > displaying. >Reporter: Steve Gill > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6284) Add tests
[ https://issues.apache.org/jira/browse/CB-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-6284: -- Assignee: Steve Gill > Add tests > - > > Key: CB-6284 > URL: https://issues.apache.org/jira/browse/CB-6284 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > The site needs testing! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6286) Paging
[ https://issues.apache.org/jira/browse/CB-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-6286: -- Assignee: Josh Bavari > Paging > -- > > Key: CB-6286 > URL: https://issues.apache.org/jira/browse/CB-6286 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web > Environment: Need to add "view next 25 results" to the end of the > viewAll page. This way we aren't retrieving all of the plugins before > displaying. >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6281) Expose more information on plugin details + style
[ https://issues.apache.org/jira/browse/CB-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948436#comment-13948436 ] Steve Gill commented on CB-6281: * Need to style version dropdown * Pretty up the install command > Expose more information on plugin details + style > - > > Key: CB-6281 > URL: https://issues.apache.org/jira/browse/CB-6281 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-6282: -- Assignee: Steve Gill > Add documentation publishing plugins + installing removing plugins > -- > > Key: CB-6282 > URL: https://issues.apache.org/jira/browse/CB-6282 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > The home page has two spots for links to documentation. Need to create these > pages and write the content for them. > Some of the content for publishing plugins already exists in the plugman > readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6286) Paging
[ https://issues.apache.org/jira/browse/CB-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948444#comment-13948444 ] Steve Gill commented on CB-6286: http://guide.couchdb.org/editions/1/en/recipes.html#fast > Paging > -- > > Key: CB-6286 > URL: https://issues.apache.org/jira/browse/CB-6286 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web > Environment: Need to add "view next 25 results" to the end of the > viewAll page. This way we aren't retrieving all of the plugins before > displaying. >Reporter: Steve Gill >Assignee: Josh Bavari > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6356) grunt server should push to couchdb on first run
Steve Gill created CB-6356: -- Summary: grunt server should push to couchdb on first run Key: CB-6356 URL: https://issues.apache.org/jira/browse/CB-6356 Project: Apache Cordova Issue Type: Sub-task Components: Registry Web Reporter: Steve Gill Assignee: Steve Gill grunt server only watches currently. It needs to do a couchapp push on first run before it gets to watching state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948485#comment-13948485 ] ASF GitHub Bot commented on CB-5082: Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38741745 Ok, got it, no problem. I can add logic to determine if the variable is already in place, and also something that when the function or the blackberry operations are completed, I can get ride of the value from the system, or I can make a backup of the path variable and after blackberry operation are completed, I'm going to set it back to place. Also, I'm going to check how child_process.spawn works to see if I can use it. Like I said, this process it only sets the variable for the current terminal, it won't mess with other process or it doesn't set the value in a permanently way, But I understand clearly your point. > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6355) Review Downloads
[ https://issues.apache.org/jira/browse/CB-6355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948492#comment-13948492 ] ASF subversion and git services commented on CB-6355: - Commit a2f4387dc7ab80b94048c38f55ac053aff5166ee in cordova-registry-web's branch refs/heads/refactor from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-registry-web.git;h=a2f4387 ] CB-6355: Fixed download list on homepage > Review Downloads > > > Key: CB-6355 > URL: https://issues.apache.org/jira/browse/CB-6355 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > Downloads stopped working properly locally. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6355) Review Downloads
[ https://issues.apache.org/jira/browse/CB-6355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-6355. Resolution: Fixed > Review Downloads > > > Key: CB-6355 > URL: https://issues.apache.org/jira/browse/CB-6355 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > Downloads stopped working properly locally. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948539#comment-13948539 ] Steve Gill commented on CB-6282: For now, I have linked to existing docs on the subjects. I think in the long run, we either improve those existing docs, or we create our own based off of that information. I don't like the fact that we change domains and only way back is to use the back button. I would rather they stayed on the same domain. At the same time, I don't know if it makes sense to remove that info from the cordova docs site. We shall discuss more later. > Add documentation publishing plugins + installing removing plugins > -- > > Key: CB-6282 > URL: https://issues.apache.org/jira/browse/CB-6282 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > The home page has two spots for links to documentation. Need to create these > pages and write the content for them. > Some of the content for publishing plugins already exists in the plugman > readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-6282. Resolution: Fixed > Add documentation publishing plugins + installing removing plugins > -- > > Key: CB-6282 > URL: https://issues.apache.org/jira/browse/CB-6282 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > The home page has two spots for links to documentation. Need to create these > pages and write the content for them. > Some of the content for publishing plugins already exists in the plugman > readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6282) Add documentation publishing plugins + installing removing plugins
[ https://issues.apache.org/jira/browse/CB-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948544#comment-13948544 ] ASF subversion and git services commented on CB-6282: - Commit c5ea3bd6bcffa3261bea0deb5b783830caba69d8 in cordova-registry-web's branch refs/heads/refactor from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-registry-web.git;h=c5ea3bd ] CB-6282: added documentation links to homepage > Add documentation publishing plugins + installing removing plugins > -- > > Key: CB-6282 > URL: https://issues.apache.org/jira/browse/CB-6282 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry, Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > The home page has two spots for links to documentation. Need to create these > pages and write the content for them. > Some of the content for publishing plugins already exists in the plugman > readme. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5082) add BB10 support in doPlatform()
[ https://issues.apache.org/jira/browse/CB-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948554#comment-13948554 ] ASF GitHub Bot commented on CB-5082: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38747218 While cordova-cli is usually run as `bin/cordova`, it's possible to use cordova as a library, which means that your env changes last longer. > add BB10 support in doPlatform() > > > Key: CB-5082 > URL: https://issues.apache.org/jira/browse/CB-5082 > Project: Apache Cordova > Issue Type: Sub-task > Components: CLI >Reporter: Marcel Kinard >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6353) Fix up mobile styling for home page
[ https://issues.apache.org/jira/browse/CB-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948709#comment-13948709 ] ASF subversion and git services commented on CB-6353: - Commit 5b5a9103feef92f0d890b5eaffc5585660d185ac in cordova-registry-web's branch refs/heads/refactor from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-registry-web.git;h=5b5a910 ] CB-6353: fixed up mobile styling > Fix up mobile styling for home page > --- > > Key: CB-6353 > URL: https://issues.apache.org/jira/browse/CB-6353 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > header + lists -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6353) Fix up mobile styling for home page
[ https://issues.apache.org/jira/browse/CB-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-6353. Resolution: Fixed > Fix up mobile styling for home page > --- > > Key: CB-6353 > URL: https://issues.apache.org/jira/browse/CB-6353 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > header + lists -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-6356) grunt server should push to couchdb on first run
[ https://issues.apache.org/jira/browse/CB-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill resolved CB-6356. Resolution: Fixed > grunt server should push to couchdb on first run > > > Key: CB-6356 > URL: https://issues.apache.org/jira/browse/CB-6356 > Project: Apache Cordova > Issue Type: Sub-task > Components: Registry Web >Reporter: Steve Gill >Assignee: Steve Gill > > grunt server only watches currently. It needs to do a couchapp push on first > run before it gets to watching state. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-6357) platform check should install each platform to determine if they're functional and their version number
Josh Soref created CB-6357: -- Summary: platform check should install each platform to determine if they're functional and their version number Key: CB-6357 URL: https://issues.apache.org/jira/browse/CB-6357 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently `cordova platform check` has a few behaviors which are not necessarily ideal: 1. It relies on the platforms.js file to have valid versions which match what is actually in the cached ~/.cordova/lib space. 2. If a platform is installed for which there's a newer version which won't install (e.g. you're on Windows and you have iOS installed), it could tell you that there's an upgrade available, however, you won't be able to install it. We'd like to fix these limitations by having platform check actually run the version script against a live project. This should mean that there will not be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948764#comment-13948764 ] ASF GitHub Bot commented on CB-6357: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/153 CB-6357 platform check - install each platform to determine working + version number The other changesets (Refactor, exports, silence output, sort output, fix indentation) are split because it's a lot easier to understand things individually. The evolution here is partially w/ an eye to eventually have these functions be usable by other entities too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-cli cb_6357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #153 commit b5d8ce7915e3875d427acb1583cb46fd046f238e Author: Josh Soref Date: 2014-03-24T21:29:57Z CB-6357 platform: Refactor into distinct functions commit bca4b6fef31364cbb4d8977a52881316a30321b9 Author: Josh Soref Date: 2014-03-24T21:30:46Z CB-6357 platform: provide exports for functions commit 5911893d8f29e0d8341583c075b8152d359e428b Author: Josh Soref Date: 2014-03-27T01:49:03Z CB-6357 call_into_create: support no output commit a67a478ec7dcff6c93bcf1c42d30e3d6653cd00b Author: Josh Soref Date: 2014-03-26T14:43:21Z CB-6357 platform check - install each platform to determine working + version number commit 66cb9612a98df47d82ce6bc123be3ce4fca855a3 Author: Josh Soref Date: 2014-03-27T01:55:14Z CB-6357 platform check: sort output commit 6000ba91151a2ef1bc465b97f6e8fda20e660b45 Author: Josh Soref Date: 2014-03-27T01:56:44Z CB-6357 platform: fix indentation > platform check should install each platform to determine if they're > functional and their version number > --- > > Key: CB-6357 > URL: https://issues.apache.org/jira/browse/CB-6357 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Currently `cordova platform check` has a few behaviors which are not > necessarily ideal: > 1. It relies on the platforms.js file to have valid versions which match what > is actually in the cached ~/.cordova/lib space. > 2. If a platform is installed for which there's a newer version which won't > install (e.g. you're on Windows and you have iOS installed), it could tell > you that there's an upgrade available, however, you won't be able to install > it. > We'd like to fix these limitations by having platform check actually run the > version script against a live project. This should mean that there will not > be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948767#comment-13948767 ] ASF GitHub Bot commented on CB-6357: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38762210 Sigh, and now i need to deal w/ `npm test` > platform check should install each platform to determine if they're > functional and their version number > --- > > Key: CB-6357 > URL: https://issues.apache.org/jira/browse/CB-6357 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Currently `cordova platform check` has a few behaviors which are not > necessarily ideal: > 1. It relies on the platforms.js file to have valid versions which match what > is actually in the cached ~/.cordova/lib space. > 2. If a platform is installed for which there's a newer version which won't > install (e.g. you're on Windows and you have iOS installed), it could tell > you that there's an upgrade available, however, you won't be able to install > it. > We'd like to fix these limitations by having platform check actually run the > version script against a live project. This should mean that there will not > be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6346) [BlackBerry10] Commit node_modules
[ https://issues.apache.org/jira/browse/CB-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948772#comment-13948772 ] ASF GitHub Bot commented on CB-6346: Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/152#issuecomment-38762335 r+ > [BlackBerry10] Commit node_modules > -- > > Key: CB-6346 > URL: https://issues.apache.org/jira/browse/CB-6346 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry >Affects Versions: 3.4.0 >Reporter: Bryan Higgins >Assignee: Bryan Higgins > Fix For: 3.5.0 > > > We should commit node_modules for cordova-blackberry rather than running npm > install within the init script. cordova-android has already moved to this > model. > https://www.npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948857#comment-13948857 ] ASF GitHub Bot commented on CB-6337: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38767219 `npm test` is happy, would someone please merge this? > Print nice error when cordova-cli hits various expected things > -- > > Key: CB-6337 > URL: https://issues.apache.org/jira/browse/CB-6337 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.4.0 >Reporter: Josh Soref >Assignee: Josh Soref > > CB-5782 introduced a way to silence stack traces for expected failures, but > it missed some spots. > This is a first pass against things in CLI itself -- it doesn't cover errors > coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6357) platform check should install each platform to determine if they're functional and their version number
[ https://issues.apache.org/jira/browse/CB-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948860#comment-13948860 ] ASF GitHub Bot commented on CB-6357: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38767269 ok, with #150 applied, this set of changes applies cleanly and doesn't introduce any new `npm test` failures. > platform check should install each platform to determine if they're > functional and their version number > --- > > Key: CB-6357 > URL: https://issues.apache.org/jira/browse/CB-6357 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 3.5.0 >Reporter: Josh Soref >Assignee: Josh Soref > > Currently `cordova platform check` has a few behaviors which are not > necessarily ideal: > 1. It relies on the platforms.js file to have valid versions which match what > is actually in the cached ~/.cordova/lib space. > 2. If a platform is installed for which there's a newer version which won't > install (e.g. you're on Windows and you have iOS installed), it could tell > you that there's an upgrade available, however, you won't be able to install > it. > We'd like to fix these limitations by having platform check actually run the > version script against a live project. This should mean that there will not > be any false positives: what you see is what you really could get. -- This message was sent by Atlassian JIRA (v6.2#6252)