[jira] [Commented] (CB-4556) Add a ./cordova/clean project-level script
[ https://issues.apache.org/jira/browse/CB-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064618#comment-14064618 ] ASF GitHub Bot commented on CB-4556: Github user rodms10 commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/18#issuecomment-49261707 Thanks! I'll test tomorrow, need to setup a windows machine. > Add a ./cordova/clean project-level script > -- > > Key: CB-4556 > URL: https://issues.apache.org/jira/browse/CB-4556 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: Steve Gill > > This script should delete any build artifacts that are create from running an > app compilation. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6898) [Android] Black screen issue when app start up
[ https://issues.apache.org/jira/browse/CB-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064491#comment-14064491 ] Guangzhen commented on CB-6898: --- [~agrieve] Actually, I'm using Crosswalk-Cordova which is as chrome webview. With my patch, there is no white flash when startup. The first rendered frame will be faster, In my test app, there is a html loading screen, and the onPageFinished event will be later than first visible screen. > [Android] Black screen issue when app start up > -- > > Key: CB-6898 > URL: https://issues.apache.org/jira/browse/CB-6898 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Guangzhen > > When the app doing a heavy work when start up, there will be a black screen > displayed firstly and then the actual page will be shown. > I have investigated in the cordova-android implementation and found the root > cause: > When app start up, the appView will be invisible, and then changed to visible > after receive onPageFinish event. It will cause black screen issue before it > changed to visible. > This behavior is for 'LoadingDialog' feature. > But when there is no 'LoadingDialog' specified in the config fie, I think we > do not need to set the appView invisible. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7156) Make the pluggable webview API as good as possible
[ https://issues.apache.org/jira/browse/CB-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-7156: --- Issue Type: Sub-task (was: Improvement) Parent: CB-6246 > Make the pluggable webview API as good as possible > -- > > Key: CB-7156 > URL: https://issues.apache.org/jira/browse/CB-7156 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Andrew Grieve > > Some specific goals here: > - Eliminate CordovaWebView APIs that are engine-specific (e.g. WebViewClient) > - Eliminate CordovaWebView APIs that are convenience methods (no need for > every implementation to implement the same convenience methods) > - Eliminate copy & pasted code between pluggable webviews > This issue should be left open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7156) Make the pluggable webview API as good as possible
[ https://issues.apache.org/jira/browse/CB-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064351#comment-14064351 ] Joe Bowser commented on CB-7156: This is an overly broad JIRA issue, and should be a sub-task of Pluggable WebViews. > Make the pluggable webview API as good as possible > -- > > Key: CB-7156 > URL: https://issues.apache.org/jira/browse/CB-7156 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve > > Some specific goals here: > - Eliminate CordovaWebView APIs that are engine-specific (e.g. WebViewClient) > - Eliminate CordovaWebView APIs that are convenience methods (no need for > every implementation to implement the same convenience methods) > - Eliminate copy & pasted code between pluggable webviews > This issue should be left open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4556) Add a ./cordova/clean project-level script
[ https://issues.apache.org/jira/browse/CB-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064115#comment-14064115 ] ASF GitHub Bot commented on CB-4556: GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-firefoxos/pull/18 [CB-4556] Add a ./cordova/clean project-level script https://issues.apache.org/jira/browse/CB-4556 @rodms10 could you check this file? You can merge this pull request into a Git repository by running: $ git pull https://github.com/marti1125/cordova-firefoxos master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-firefoxos/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit ed4076c5d11169bbbd7c4e40778837a2cff47b86 Author: Willy Aguirre Date: 2014-07-16T20:22:07Z add clean.bat commit b0d8e635f4f43d39599d27f78ce1fcd10ddb0baf Author: Willy Aguirre Date: 2014-07-16T21:00:15Z update clean.bat > Add a ./cordova/clean project-level script > -- > > Key: CB-4556 > URL: https://issues.apache.org/jira/browse/CB-4556 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS >Reporter: Steve Gill > > This script should delete any build artifacts that are create from running an > app compilation. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6976) Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
[ https://issues.apache.org/jira/browse/CB-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063946#comment-14063946 ] ASF GitHub Bot commented on CB-6976: Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-cli/pull/183 > Add support for Windows Universal apps (Windows 8.1 and WP 8.1) > --- > > Key: CB-6976 > URL: https://issues.apache.org/jira/browse/CB-6976 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Creating this as a new JIRA feature since this is different from previously > proposed adding support for Windows 8.1 only. > This feature proposes transforming 'windows8' to 'windows' platform which is > based on Windows Universal apps and which allows building apps for Windows 8, > Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. > Original info from dev mail thread: > With Windows 8.1 and Windows Phone 8.1 platforms released, it would be great > to get Cordova support building apps for those platforms too. A lot of people > on this list have also been talking about how to adapt existing apps to the > new 8.1 platforms. Here is an initial proposal and prototype of how it may > look. > TL;DR; - Rename windows8 platform to be called windows. This platform can > build apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 > (wp8) stays as a platform. > Link to the document - > https://onedrive.live.com/redir?resid=DEA20E6DC28C96DD!2781&authkey=!APz1za6lnJhsaaQ&ithint=file%2c.docx > For more details, see "Support for Windows Universal apps (Windows 8.1 and > Windows Phone 8.1)" dev email thread > TODO: add Windows 8.1 and WP8.1 components. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6976) Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
[ https://issues.apache.org/jira/browse/CB-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063945#comment-14063945 ] ASF GitHub Bot commented on CB-6976: Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/183#issuecomment-49213003 Not actual anymore, closing... > Add support for Windows Universal apps (Windows 8.1 and WP 8.1) > --- > > Key: CB-6976 > URL: https://issues.apache.org/jira/browse/CB-6976 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Creating this as a new JIRA feature since this is different from previously > proposed adding support for Windows 8.1 only. > This feature proposes transforming 'windows8' to 'windows' platform which is > based on Windows Universal apps and which allows building apps for Windows 8, > Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. > Original info from dev mail thread: > With Windows 8.1 and Windows Phone 8.1 platforms released, it would be great > to get Cordova support building apps for those platforms too. A lot of people > on this list have also been talking about how to adapt existing apps to the > new 8.1 platforms. Here is an initial proposal and prototype of how it may > look. > TL;DR; - Rename windows8 platform to be called windows. This platform can > build apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 > (wp8) stays as a platform. > Link to the document - > https://onedrive.live.com/redir?resid=DEA20E6DC28C96DD!2781&authkey=!APz1za6lnJhsaaQ&ithint=file%2c.docx > For more details, see "Support for Windows Universal apps (Windows 8.1 and > Windows Phone 8.1)" dev email thread > TODO: add Windows 8.1 and WP8.1 components. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6308) WP8. Add Splash Screen img support via config.xml preference
[ https://issues.apache.org/jira/browse/CB-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063948#comment-14063948 ] ASF GitHub Bot commented on CB-6308: Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-cli/pull/145 > WP8. Add Splash Screen img support via config.xml preference > > > Key: CB-6308 > URL: https://issues.apache.org/jira/browse/CB-6308 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, WP8 >Reporter: Sergey Grebnov >Assignee: Jesse MacFadyen > > Right now there is no way to specify new splash screen image for WP8 via > config.xml. Propose to implement this as Android does - via special > preference > > http://cordova.apache.org/docs/en/3.4.0/config_ref_images.md.html#Icons%20and%20Splash%20Screens_splash_screens_for_the_android_platform -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7156) Make the pluggable webview API as good as possible
[ https://issues.apache.org/jira/browse/CB-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063937#comment-14063937 ] Andrew Grieve commented on CB-7156: --- Some already-made changes: https://github.com/apache/cordova-android/commit/663a71255ff0e3a7a3d31bda4cd72fa7b4de1283 * Move handling of Fullscreen preference to CordovaActivity from AndroidWebView https://github.com/apache/cordova-android/commit/efcedabee098d28e7c3e87dc3a7414b4a235a5fc * Moved copy & pasted ExposedJsApi into shared CordovaBridge class * Delete Cordova*Client classes since they are webview-specific * Moved CordovaChromeClient.getValueCallback() -> CordovaWebView.onFilePickerResult() * Delete View-specific methods from CordovaInterface (callers should use .getView() to get at the view) * Reduces the number of loadUrl() overloads * Delete addJavascript() (but leaves sendJavascript) * Delete getPlugin() and postMessage() convenience methods (call them on PluginManager directly) * Delete isPaused() - Used only by tests and is just a stored boolean of onPause onResume * Delete getUrl(), but then added back in https://github.com/apache/cordova-android/commit/9b9c59766f2313db63f90e58afb13808e9280c59 Other APIs that might be unnecessary: * void showWebPage(String errorUrl, boolean b, boolean c, HashMap params); * boolean isCustomViewShowing(); * void showCustomView(View view, CustomViewCallback callback); * void hideCustomView(); * void setNetworkAvailable(boolean online); (this one makes sense for the online bridge, but doesn't really make sense to expose to plugins) There is also a good amount of copy & pasted code between AndroidWebView and Crosswalk Webview: * Splashscreen code * page load timeout > Make the pluggable webview API as good as possible > -- > > Key: CB-7156 > URL: https://issues.apache.org/jira/browse/CB-7156 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve > > Some specific goals here: > - Eliminate CordovaWebView APIs that are engine-specific (e.g. WebViewClient) > - Eliminate CordovaWebView APIs that are convenience methods (no need for > every implementation to implement the same convenience methods) > - Eliminate copy & pasted code between pluggable webviews > This issue should be left open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6976) Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
[ https://issues.apache.org/jira/browse/CB-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063935#comment-14063935 ] ASF GitHub Bot commented on CB-6976: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/183#issuecomment-49211973 Is this still relevant? Was this just reverted in the 3.5.0 branch? > Add support for Windows Universal apps (Windows 8.1 and WP 8.1) > --- > > Key: CB-6976 > URL: https://issues.apache.org/jira/browse/CB-6976 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Creating this as a new JIRA feature since this is different from previously > proposed adding support for Windows 8.1 only. > This feature proposes transforming 'windows8' to 'windows' platform which is > based on Windows Universal apps and which allows building apps for Windows 8, > Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. > Original info from dev mail thread: > With Windows 8.1 and Windows Phone 8.1 platforms released, it would be great > to get Cordova support building apps for those platforms too. A lot of people > on this list have also been talking about how to adapt existing apps to the > new 8.1 platforms. Here is an initial proposal and prototype of how it may > look. > TL;DR; - Rename windows8 platform to be called windows. This platform can > build apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 > (wp8) stays as a platform. > Link to the document - > https://onedrive.live.com/redir?resid=DEA20E6DC28C96DD!2781&authkey=!APz1za6lnJhsaaQ&ithint=file%2c.docx > For more details, see "Support for Windows Universal apps (Windows 8.1 and > Windows Phone 8.1)" dev email thread > TODO: add Windows 8.1 and WP8.1 components. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7157) Delete LocationChange Bridge mode
[ https://issues.apache.org/jira/browse/CB-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7157. --- Resolution: Fixed Deleted with commits: https://github.com/apache/cordova-android/commit/f577af08864c4503fad5afc7d9ca7b9611ba27ce https://github.com/apache/cordova-android/commit/caeb86843ddca712b5bf1dfbdac9005edce98100 Fixed in 3.6.0-dev > Delete LocationChange Bridge mode > - > > Key: CB-7157 > URL: https://issues.apache.org/jira/browse/CB-7157 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > It has never been enabled due to security concerns, does not perform well, > and complicates the code for pluggable webviews. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7157) Delete LocationChange Bridge mode
Andrew Grieve created CB-7157: - Summary: Delete LocationChange Bridge mode Key: CB-7157 URL: https://issues.apache.org/jira/browse/CB-7157 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor It has never been enabled due to security concerns, does not perform well, and complicates the code for pluggable webviews. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7156) Make the pluggable webview API as good as possible
Andrew Grieve created CB-7156: - Summary: Make the pluggable webview API as good as possible Key: CB-7156 URL: https://issues.apache.org/jira/browse/CB-7156 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Some specific goals here: - Eliminate CordovaWebView APIs that are engine-specific (e.g. WebViewClient) - Eliminate CordovaWebView APIs that are convenience methods (no need for every implementation to implement the same convenience methods) - Eliminate copy & pasted code between pluggable webviews This issue should be left open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063871#comment-14063871 ] Ian Clelland commented on CB-7147: -- I posted another comment to [XWALK-1931|https://crosswalk-project.org/jira/browse/XWALK-1931] about this issue; hopefully it can be corrected there. In the meantime, the manifest permission workaround appears to work. > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7155) Reduce the visibility of symbols in Android 4.0.x
[ https://issues.apache.org/jira/browse/CB-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve updated CB-7155: -- Description: With a major version bump, it makes sense to use this opportunity to make some public methods/fields non-public that should never have been public in the first place. https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9 * PluginManager.clearPluginObjects(), * PluginManager.startupPlugins() https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d * Makes PluginEntry fields final https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6 * PluginEntry.createPlugin() moved into PluginManager https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2 * Convenience methods in CordovaActivity * Removing convenience methods might break the compile for those that have made customizations to their Activity.java class, but the changes are trivial to fix for those capable of editing their own Activity.java file. Although some commits have been made already to this goal, going to leave issue open until 4.0.x stabilizes. was: With a major version bump, it makes sense to use this opportunity to make some public methods/fields non-public that should never have been public in the first place. https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9 * PluginManager.clearPluginObjects(), * PluginManager.startupPlugins() https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d * Makes PluginEntry fields final https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6 * PluginEntry.createPlugin() moved into PluginManager https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2 * Convenience methods in CordovaActivity Although some commits have been made already to this goal, going to leave issue open until 4.0.x stabilizes. > Reduce the visibility of symbols in Android 4.0.x > - > > Key: CB-7155 > URL: https://issues.apache.org/jira/browse/CB-7155 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > With a major version bump, it makes sense to use this opportunity to make > some public methods/fields non-public that should never have been public in > the first place. > https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9 > * PluginManager.clearPluginObjects(), > * PluginManager.startupPlugins() > https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d > * Makes PluginEntry fields final > https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6 > * PluginEntry.createPlugin() moved into PluginManager > https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2 > * Convenience methods in CordovaActivity > * Removing convenience methods might break the compile for those that have > made customizations to their Activity.java class, but the changes are trivial > to fix for those capable of editing their own Activity.java file. > Although some commits have been made already to this goal, going to leave > issue open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7155) Reduce the visibility of symbols in Android 4.0.x
Andrew Grieve created CB-7155: - Summary: Reduce the visibility of symbols in Android 4.0.x Key: CB-7155 URL: https://issues.apache.org/jira/browse/CB-7155 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor With a major version bump, it makes sense to use this opportunity to make some public methods/fields non-public that should never have been public in the first place. https://github.com/apache/cordova-android/commit/a99c8219bd90f913df9083652972c5037a8426d9 * PluginManager.clearPluginObjects(), * PluginManager.startupPlugins() https://github.com/apache/cordova-android/commit/6f301576ebbf2a631c7f36af3cc97d482a2d0d3d * Makes PluginEntry fields final https://github.com/apache/cordova-android/commit/145b50a320edfa8b5397849fc20a6295f8823ff6 * PluginEntry.createPlugin() moved into PluginManager https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2 * Convenience methods in CordovaActivity Although some commits have been made already to this goal, going to leave issue open until 4.0.x stabilizes. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7132) Single default icon overridden by Cordova icon on Android
[ https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063861#comment-14063861 ] ASF GitHub Bot commented on CB-7132: Github user VVelda commented on the pull request: https://github.com/apache/cordova-lib/pull/58#issuecomment-49206968 Changes deletes also icons and splashscreen in new blank project, which is bad. That should not to be done, until is icon or splashreen set in config.xml. > Single default icon overridden by Cordova icon on Android > -- > > Key: CB-7132 > URL: https://issues.apache.org/jira/browse/CB-7132 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 3.5.0 >Reporter: Bryan Higgins >Assignee: Axel Nennker > > Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the > "single default icon" [1] not being displayed on device. > In 3.5.0-0.2.4 the icon was copied into drawable-* > In 3.5.0-0.2.6 the icon is copied to drawable/ > The template [2] already contains default icons for drawable-*, thus the > single default icon is never used. > [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html > [2] > https://github.com/apache/cordova-android/tree/master/bin/templates/project/res -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[
https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063842#comment-14063842
]
Ian Clelland commented on CB-7147:
--
As a workaround, if I add
{code}
{code}
to my {{AndroidManifest.xml}}, then {{getExternalCacheDir()}} stops returning
null, and the Crosswalk view instantiates correctly. Once I do that, then I can
see the WebView in Chrome DevTools.
> USB Debugging no longer works on Crosswalk pre-KitKat
> -
>
> Key: CB-7147
> URL: https://issues.apache.org/jira/browse/CB-7147
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
>Reporter: Joe Bowser
>Assignee: Ian Clelland
> Fix For: 4.0.0
>
>
> I just tried the latest API, and for some reason I can't use Chrome Debugging
> with Third Party WebViews. This basically makes the upcoming demo pointless,
> since I can't demonstrate this working on Jellybean or ICS devices. :(
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7154) Android: Delete deprecated APIs in 4.0.x
[ https://issues.apache.org/jira/browse/CB-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063847#comment-14063847 ] Andrew Grieve commented on CB-7154: --- Also: https://github.com/apache/cordova-android/commit/dbb196a17e7e9e1672f7fffab02ce1c1ae90e9ec * Deletes long-deprecated logic > Android: Delete deprecated APIs in 4.0.x > > > Key: CB-7154 > URL: https://issues.apache.org/jira/browse/CB-7154 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Since we are making a major version bump, it makes sense to delete > long-deprecated symbols from the code. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7154) Android: Delete deprecated APIs in 4.0.x
[ https://issues.apache.org/jira/browse/CB-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7154. --- Resolution: Fixed The following commits delete deprecated things (all made on 4.0.x branch): https://github.com/apache/cordova-android/commit/200e9f1a8eb1bfebd4f990094b3a7b52a8de8766 * DirectoryManager, DroidGap, ExifHelper https://github.com/apache/cordova-android/commit/eca05e6bad881fcd2ba928f76a28e0bb96d0e4b2 * Some symbols within CordovaActivity https://github.com/apache/cordova-android/commit/25a7b6629632f7b0b0270a733b9551eaf64d429a * Deprecated no-ops in PluginManager > Android: Delete deprecated APIs in 4.0.x > > > Key: CB-7154 > URL: https://issues.apache.org/jira/browse/CB-7154 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Since we are making a major version bump, it makes sense to delete > long-deprecated symbols from the code. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7154) Android: Delete deprecated APIs in 4.0.x
[ https://issues.apache.org/jira/browse/CB-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve updated CB-7154: -- Description: Since we are making a major version bump, it makes sense to delete long-deprecated symbols from the code. > Android: Delete deprecated APIs in 4.0.x > > > Key: CB-7154 > URL: https://issues.apache.org/jira/browse/CB-7154 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Since we are making a major version bump, it makes sense to delete > long-deprecated symbols from the code. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[
https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063808#comment-14063808
]
Ian Clelland edited comment on CB-7147 at 7/16/14 6:10 PM:
---
I think that we're hitting https://crosswalk-project.org/jira/browse/XWALK-1931
on pre-KK devices. I've seen this now in a Galaxy S3 running 4.1.1, as well as
a Nexus 7 running 4.3.
In both devices, {{Environment.getExternalStorageState()}} is returning
"{{mounted}}", but {{context.getApplicationContext().getExternalCacheDir()}}
returns {{null}}, and so the XWalkView fails to instantiate.
I'll see if a later version of XWalkView.java still has this issue; if so, I'll
update, and otherwise, I'll open a bug on Crosswalk.
was (Author: iclelland):
I think that we're hitting https://crosswalk-project.org/jira/browse/XWALK-1931
on pre-KK devices. I've seen this now in a Galaxy S3 running 4.1.1, as well as
a Nexus 7 running 4.3.
In both devices, {{Environment.getExternalStorageState()}} is returning
"{{mounted}}", but {{context.getApplicationContect().getExternalCacheDir()}}
returns {{null}}, and so the XWalkView fails to instantiate.
I'll see if a later version of XWalkView.java still has this issue; if so, I'll
update, and otherwise, I'll open a bug on Crosswalk.
> USB Debugging no longer works on Crosswalk pre-KitKat
> -
>
> Key: CB-7147
> URL: https://issues.apache.org/jira/browse/CB-7147
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
>Reporter: Joe Bowser
>Assignee: Ian Clelland
> Fix For: 4.0.0
>
>
> I just tried the latest API, and for some reason I can't use Chrome Debugging
> with Third Party WebViews. This basically makes the upcoming demo pointless,
> since I can't demonstrate this working on Jellybean or ICS devices. :(
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7154) Android: Delete deprecated APIs in 4.0.x
Andrew Grieve created CB-7154: - Summary: Android: Delete deprecated APIs in 4.0.x Key: CB-7154 URL: https://issues.apache.org/jira/browse/CB-7154 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7153) CordovaWebView() crashes if constructed with a Context that does not implement CordovaInterface
[ https://issues.apache.org/jira/browse/CB-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7153. --- Resolution: Fixed Fixed with: https://github.com/apache/cordova-android/commit/705991e5b037743e632934b3c6ee98976e18d3f8 Which moves to two-phase initialization, and also injects the view clients, CordovaPreferences, and whitelist. Fixed in 3.6.0-dev > CordovaWebView() crashes if constructed with a Context that does not > implement CordovaInterface > --- > > Key: CB-7153 > URL: https://issues.apache.org/jira/browse/CB-7153 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > It is a bit restrictive to enforce that the Context used to construct > CordovaWebView must also be the thing that implements CordovaInterface. > However, it's important to maintain a Constructor that takes a Context as its > only parameter so that the View can be inflated within XML layouts. > To solve this, and to make it possible to initialize the class with other > dependencies that it has, we should move to using two-phase initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7153) CordovaWebView() crashes if constructed with a Context that does not implement CordovaInterface
Andrew Grieve created CB-7153: - Summary: CordovaWebView() crashes if constructed with a Context that does not implement CordovaInterface Key: CB-7153 URL: https://issues.apache.org/jira/browse/CB-7153 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor It is a bit restrictive to enforce that the Context used to construct CordovaWebView must also be the thing that implements CordovaInterface. However, it's important to maintain a Constructor that takes a Context as its only parameter so that the View can be inflated within XML layouts. To solve this, and to make it possible to initialize the class with other dependencies that it has, we should move to using two-phase initialization. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[
https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063808#comment-14063808
]
Ian Clelland commented on CB-7147:
--
I think that we're hitting https://crosswalk-project.org/jira/browse/XWALK-1931
on pre-KK devices. I've seen this now in a Galaxy S3 running 4.1.1, as well as
a Nexus 7 running 4.3.
In both devices, {{Environment.getExternalStorageState()}} is returning
"{{mounted}}", but {{context.getApplicationContect().getExternalCacheDir()}}
returns {{null}}, and so the XWalkView fails to instantiate.
I'll see if a later version of XWalkView.java still has this issue; if so, I'll
update, and otherwise, I'll open a bug on Crosswalk.
> USB Debugging no longer works on Crosswalk pre-KitKat
> -
>
> Key: CB-7147
> URL: https://issues.apache.org/jira/browse/CB-7147
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
>Reporter: Joe Bowser
>Assignee: Ian Clelland
> Fix For: 4.0.0
>
>
> I just tried the latest API, and for some reason I can't use Chrome Debugging
> with Third Party WebViews. This basically makes the upcoming demo pointless,
> since I can't demonstrate this working on Jellybean or ICS devices. :(
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7152) Allow for multiple WebViews to have different configurations
Andrew Grieve created CB-7152: - Summary: Allow for multiple WebViews to have different configurations Key: CB-7152 URL: https://issues.apache.org/jira/browse/CB-7152 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor Changes already made. Relevant commits: * https://github.com/apache/cordova-android/commit/3bab41f138d57a7a92ab01586dd8f58bc91dddfd * https://github.com/apache/cordova-android/commit/af77977fda281e912b9e8805d1d89a44e5ba1f52 * https://github.com/apache/cordova-android/commit/965e4e9b19a25cd14edab6705804893e81a3b292 * https://github.com/apache/cordova-android/commit/705991e5b037743e632934b3c6ee98976e18d3f8 * https://github.com/apache/cordova-android/commit/d31ee20ba568aed498896a4165e27d87b509f946 * https://github.com/apache/cordova-android/commit/04ccb06e3f6297f3956d847507423c66006eae08 * https://github.com/apache/cordova-android/commit/1c5b5e2ce644a4313624f540dad9abf4665cb870 Root of the problem here is that there were several settings for CordovaWebView that are set either via intent extras, or via the singleton Config class. With these changes, all settings are able to be set programmatically as well as read from config.xml. Retrieving is still possible through the intent extras, but plugins should now prefer to use the CordovaPreferences class instead (so that per-webview customizations are respected). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7152) Allow for multiple WebViews to have different configurations
[ https://issues.apache.org/jira/browse/CB-7152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7152. --- Resolution: Fixed Fixed in 3.6.0-dev > Allow for multiple WebViews to have different configurations > > > Key: CB-7152 > URL: https://issues.apache.org/jira/browse/CB-7152 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > Changes already made. Relevant commits: > * > https://github.com/apache/cordova-android/commit/3bab41f138d57a7a92ab01586dd8f58bc91dddfd > * > https://github.com/apache/cordova-android/commit/af77977fda281e912b9e8805d1d89a44e5ba1f52 > * > https://github.com/apache/cordova-android/commit/965e4e9b19a25cd14edab6705804893e81a3b292 > * > https://github.com/apache/cordova-android/commit/705991e5b037743e632934b3c6ee98976e18d3f8 > * > https://github.com/apache/cordova-android/commit/d31ee20ba568aed498896a4165e27d87b509f946 > * > https://github.com/apache/cordova-android/commit/04ccb06e3f6297f3956d847507423c66006eae08 > * > https://github.com/apache/cordova-android/commit/1c5b5e2ce644a4313624f540dad9abf4665cb870 > Root of the problem here is that there were several settings for > CordovaWebView that are set either via intent extras, or via the singleton > Config class. > With these changes, all settings are able to be set programmatically as well > as read from config.xml. Retrieving is still possible through > the intent extras, but plugins should now prefer to use the > CordovaPreferences class instead (so that per-webview customizations are > respected). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063766#comment-14063766 ] Joe Bowser commented on CB-7147: I just checked. I'm getting an InvocationTargetException on the Samsung Galaxy Note running 4.1.2. It is going back to the old Android WebView. > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7151) Create Reference Implementation
Joe Bowser created CB-7151: -- Summary: Create Reference Implementation Key: CB-7151 URL: https://issues.apache.org/jira/browse/CB-7151 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 4.0.0 Reporter: Joe Bowser Currently the only implementation of CordovaWebView for the third-party webview is Crosswalk. While there's a default WebView, there's no test plugin for those who want to add their own WebViews. We need a webview that implements the existing Android SDK webview as a plugin for reference. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063736#comment-14063736 ] Ian Clelland commented on CB-7147: -- My immediate suspicion would be that the XWalkCordovaWebView instantiation is failing, and Cordova is falling back to the system webview. Are you seeing the expected navigator.userAgent string if you alert() it? > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063698#comment-14063698 ] Joe Bowser commented on CB-7147: Not showing up under chrome://inspect/. It used to show up in the past release. > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063698#comment-14063698 ] Joe Bowser edited comment on CB-7147 at 7/16/14 4:40 PM: - Not showing up under chrome://inspect/. It used to show up in the previous version. was (Author: bowserj): Not showing up under chrome://inspect/. It used to show up in the past release. > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7150) Error when using ajax on local file with Windows Phone
Chris Couper created CB-7150:
Summary: Error when using ajax on local file with Windows Phone
Key: CB-7150
URL: https://issues.apache.org/jira/browse/CB-7150
Project: Apache Cordova
Issue Type: Bug
Components: WP8
Affects Versions: 3.3.0
Environment: Windows phone 8.1, jqm 1.4.3, jquery v1.10.2. Built using
current version of Phonegap Build
Reporter: Chris Couper
Assignee: Jesse MacFadyen
I have created a jquery mobile (1.4.3) app using phonegap build. It uses ajax
get to load a local html file into a variable that I then inject into the body
of the document. This happens by user selection long after device ready.
This works well with Android and iOS but comes up with an error on Windows
Phone 8
On my config.xml I have allowed for CORS
Also in the startup of the app I have:
$(document).bind("mobileinit", function(){
$.extend( $.mobile , {
ajaxEnabled: false
});
$.support.cors = true;
$.mobile.allowCrossDomainPages = true;
});
There is no error code returned, just the status of error. And the
jqXHR.responseText is empty. The URL looks fine.
$.ajax({
type: 'get',
url: url,
dataType:"html",
beforeSend: function(jqXHR, settings) {
jqXHR.url = settings.url;
}
})
.done( function(data) {
$("#phone_frame .ui-content").html(data);
$(':mobile-pagecontainer').enhanceWithin();
$(':mobile-pagecontainer').pagecontainer('change', '#phone_frame', {
transition: 'slide',
changeHash: true,
showLoadMsg: true
});
}) // done
.fail(function(jqXHR, status, err){
$.mobile.loading('hide');
alert("Status:"+status+", error code:"+err);
});
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7149) CordovaActivity.makeWebView should not just print stack traces
Joe Bowser created CB-7149: -- Summary: CordovaActivity.makeWebView should not just print stack traces Key: CB-7149 URL: https://issues.apache.org/jira/browse/CB-7149 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 4.0.0 Reporter: Joe Bowser This should provide logcat errors that are more meaningful and less verbose. Stack traces look like catastrophic failures, and I don't want a stream of bug reports based on someone mispelling something. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
[ https://issues.apache.org/jira/browse/CB-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063663#comment-14063663 ] Andrew Grieve commented on CB-7147: --- What are the symptoms of it not working? Not showing up under chrome://inspect? Dev Tools giving you a white screen? If it's the latter, then make sure you're using Chrome Canary to inspect. > USB Debugging no longer works on Crosswalk pre-KitKat > - > > Key: CB-7147 > URL: https://issues.apache.org/jira/browse/CB-7147 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland > Fix For: 4.0.0 > > > I just tried the latest API, and for some reason I can't use Chrome Debugging > with Third Party WebViews. This basically makes the upcoming demo pointless, > since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7148) Port contacts to plugin-test-framework
Staci Cooper created CB-7148: Summary: Port contacts to plugin-test-framework Key: CB-7148 URL: https://issues.apache.org/jira/browse/CB-7148 Project: Apache Cordova Issue Type: Test Components: Plugin Contacts, Plugin TestFramework Reporter: Staci Cooper Assignee: Staci Cooper Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7147) USB Debugging no longer works on Crosswalk pre-KitKat
Joe Bowser created CB-7147: -- Summary: USB Debugging no longer works on Crosswalk pre-KitKat Key: CB-7147 URL: https://issues.apache.org/jira/browse/CB-7147 Project: Apache Cordova Issue Type: Sub-task Components: Android Reporter: Joe Bowser Assignee: Ian Clelland Fix For: 4.0.0 I just tried the latest API, and for some reason I can't use Chrome Debugging with Third Party WebViews. This basically makes the upcoming demo pointless, since I can't demonstrate this working on Jellybean or ICS devices. :( -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7146) Port geolocation tests to plugin-test-framework
Staci Cooper created CB-7146: Summary: Port geolocation tests to plugin-test-framework Key: CB-7146 URL: https://issues.apache.org/jira/browse/CB-7146 Project: Apache Cordova Issue Type: Test Components: Plugin Geolocation, Plugin TestFramework Reporter: Staci Cooper Assignee: Staci Cooper Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6898) [Android] Black screen issue when app start up
[ https://issues.apache.org/jira/browse/CB-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063585#comment-14063585 ] Andrew Grieve commented on CB-6898: --- You can set the background color via a I believe. Guangzhen - when you applied your patch for your app, did it make things better or worse? E.g. did you get a flash of white, or were you able to render your start screen fast enough that there was no white flash? > [Android] Black screen issue when app start up > -- > > Key: CB-6898 > URL: https://issues.apache.org/jira/browse/CB-6898 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Guangzhen > > When the app doing a heavy work when start up, there will be a black screen > displayed firstly and then the actual page will be shown. > I have investigated in the cordova-android implementation and found the root > cause: > When app start up, the appView will be invisible, and then changed to visible > after receive onPageFinish event. It will cause black screen issue before it > changed to visible. > This behavior is for 'LoadingDialog' feature. > But when there is no 'LoadingDialog' specified in the config fie, I think we > do not need to set the appView invisible. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7145) Port device-orientation tests to plugin-test-framework
Staci Cooper created CB-7145: Summary: Port device-orientation tests to plugin-test-framework Key: CB-7145 URL: https://issues.apache.org/jira/browse/CB-7145 Project: Apache Cordova Issue Type: Test Components: Plugin Device Orientation, Plugin TestFramework Reporter: Staci Cooper Assignee: Staci Cooper Priority: Minor -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5093) CLI builds version number inconsitently between iOS and Android
[ https://issues.apache.org/jira/browse/CB-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063564#comment-14063564 ] Erin Parrill commented on CB-5093: -- I just double checked the documentation and I'm still not seeing these attributes documented yet. I too was having to manually change my AndroidManifest.xml and plist files because these attributes were getting set with the default values that I didn't want because I didn't know what attributes I needed to be adding and setting in the config.xml until I found this. > CLI builds version number inconsitently between iOS and Android > --- > > Key: CB-5093 > URL: https://issues.apache.org/jira/browse/CB-5093 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI, iOS >Affects Versions: 3.1.0 >Reporter: Adam George >Assignee: Mark Koudritsky > > I'm hoping this issue isn't just my ignorance, but I'm finding the app > version number generation via the CLI to be inconsistent and odd. > iOS and Android both support a version number (which is what is displayed in > the app stores), as well as another string, which most people use as a build > number. > E.g. for iOS: > Myapp-Info.plist: > Bundle versions string, short: 1.0.0 (this is what will show in the app > store) > Bundle version: 0.0.3(this is some other build number) > Android: > AndroidManifest.xml: > android:versionCode="1" android:versionName="0.0.3" > versionName is what shows in the stores, and versionCode is typically used > like a build number (as far as I can tell). > My point is, in the cordova.xml, I only have the ability to set one of these > version numbers. There is only a single "version" attribute. > But we need two attributes, so we can set both version strings via the CLI. > Secondly, how the "version" attribute is applied when building via the CLI is > inconsistent. On iOS it's updating the "build" number, and not even touching > the main version number that users will see in the store. > Whereas Android has what I would expect as the correct behaviour. > Anyway, please let me know if I've misunderstood anything. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6898) [Android] Black screen issue when app start up
[ https://issues.apache.org/jira/browse/CB-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063535#comment-14063535 ] Joe Bowser commented on CB-6898: [~agrieve] Yeah, because a blank white screen is so much better? Showing HTML rendering would actually make the experience worse, which is another reason that I don't want to see this patch added. > [Android] Black screen issue when app start up > -- > > Key: CB-6898 > URL: https://issues.apache.org/jira/browse/CB-6898 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Guangzhen > > When the app doing a heavy work when start up, there will be a black screen > displayed firstly and then the actual page will be shown. > I have investigated in the cordova-android implementation and found the root > cause: > When app start up, the appView will be invisible, and then changed to visible > after receive onPageFinish event. It will cause black screen issue before it > changed to visible. > This behavior is for 'LoadingDialog' feature. > But when there is no 'LoadingDialog' specified in the config fie, I think we > do not need to set the appView invisible. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6319) Egl errors on any touch event in android 4.4.2
[ https://issues.apache.org/jira/browse/CB-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063524#comment-14063524 ] Joe Bowser commented on CB-6319: Yeah, see above. Also, I have no idea if this is the emulator or a busted rom, which is why I closed it as incomplete. :) > Egl errors on any touch event in android 4.4.2 > -- > > Key: CB-6319 > URL: https://issues.apache.org/jira/browse/CB-6319 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Ubuntu 13.10, latest android sdk >Reporter: Ilia > > When I run my app in android 4.4.2 it doesn't react on swipe or drag event. > logcat shows these errors on any touch: > E/eglCodecCommon( 1075): glUtilsParamSize: unknow param 0x0b44 > E/eglCodecCommon( 1075): glUtilsParamSize: unknow param 0x0bd0 > E/eglCodecCommon( 1075): ERROR unknown type 0x0 (glSizeof,72) > E/eglCodecCommon( 1075): ERROR unknown type 0x0 (glSizeof,72) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6898) [Android] Black screen issue when app start up
[ https://issues.apache.org/jira/browse/CB-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063497#comment-14063497 ] Andrew Grieve commented on CB-6898: --- [~bowserj] Joe - I don't think we should be forcing apps to use a splashscreen on Android. They aren't mandatory like they are on iOS. Sounds like decent alternatives - such as showing a splash screen using HTML, or rendering "above the fold" will not work with the webview set to invisible. onPageFinished is a very coarse event, and it often comes much later than when the app has something rendered. > [Android] Black screen issue when app start up > -- > > Key: CB-6898 > URL: https://issues.apache.org/jira/browse/CB-6898 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Guangzhen > > When the app doing a heavy work when start up, there will be a black screen > displayed firstly and then the actual page will be shown. > I have investigated in the cordova-android implementation and found the root > cause: > When app start up, the appView will be invisible, and then changed to visible > after receive onPageFinish event. It will cause black screen issue before it > changed to visible. > This behavior is for 'LoadingDialog' feature. > But when there is no 'LoadingDialog' specified in the config fie, I think we > do not need to set the appView invisible. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-4602) getPreferredLanguage platform inconsistencies
[
https://issues.apache.org/jira/browse/CB-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grieve resolved CB-4602.
---
Resolution: Fixed
Lots of commits here, but the last remaining PR has been merged, so assuming
this is fixed.
Merged into 0.2.9-dev
> getPreferredLanguage platform inconsistencies
> -
>
> Key: CB-4602
> URL: https://issues.apache.org/jira/browse/CB-4602
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Globalization
>Affects Versions: 2.6.0, 3.0.0
> Environment: Android
>Reporter: Jon Whitlock
>Assignee: Mike Billau
>Priority: Minor
>
> In;
> https://github.com/apache/cordova-docs/blob/master/docs/en/edge/cordova/globalization/globalization.getPreferredLanguage.md
> "Returns the language identifier string to the successCallback with a
> properties object as a parameter. That object should have a value property
> with a String value."
> navigator.globalization.getPreferredLanguage(
>function (language) {alert('language: ' + language.value + '\n');},
>function () {alert('Error getting language\n');}
> );
> On Android the function doesn't seem to return an identifier as such, it
> returns *a string describing the language localised to that language*, e.g.
> "English" for English or "中文" for Japanese. Naturally this is less than ideal
> for subsequent string operations, furthermore on that page "Windows Phone 8
> Quirks - Returns the ISO 639-1 two-letter code for the current language"
> which is an identifier, and also what I would expect (or an ISO 639-2 code,
> as per http://www.loc.gov/standards/iso639-2/php/code_list.php)
> Android seems to support 639-2
> http://developer.android.com/reference/java/util/Locale.html#getISO3Language()
> I have no idea what it returns on other platforms, but to keep client code
> consistent I guess it would good if this could be normalised in the API.
> Have tested this on v3.0 and 2.6, is the same.
> As an aside, the locale is not really what I want here, as the user may be in
> the US but have Japanese as their preferred language.
> Thanks,
> jon
> (first go at using Jira, apols if I got something wrong!)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (CB-6626) Add new JavaScript event on statusbar tap
[ https://issues.apache.org/jira/browse/CB-6626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-6626. --- Resolution: Fixed Assignee: Andrew Grieve Merged into 0.1.7-dev of the statusbar plugin. Confirmed it works with a mobilespec manual test. > Add new JavaScript event on statusbar tap > - > > Key: CB-6626 > URL: https://issues.apache.org/jira/browse/CB-6626 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Statusbar > Environment: iOS >Reporter: Shazron Abdullah >Assignee: Andrew Grieve > > A fake scrollview is added to the CDVViewController's view (but it's in the > background). When the status bar is tapped, the scrollview will naturally be > notified to scroll to the top and a new javascript event is fired. > This also has a fix for the webview frame calculations in the function hide. > The calculation is ignored when the status bar is overlaid on top of the > webview. > Pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6319) Egl errors on any touch event in android 4.4.2
[ https://issues.apache.org/jira/browse/CB-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063492#comment-14063492 ] Jan Kucera commented on CB-6319: The issue seems to be related only to simulator with "Use host GPU" setting on. See: http://stackoverflow.com/questions/22348801/phonegap-eclipse-issue-eglcodeccommon-glutilsparamsize-unknow-param-errors https://code.google.com/p/android/issues/detail?id=40830 > Egl errors on any touch event in android 4.4.2 > -- > > Key: CB-6319 > URL: https://issues.apache.org/jira/browse/CB-6319 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.4.0 > Environment: Ubuntu 13.10, latest android sdk >Reporter: Ilia > > When I run my app in android 4.4.2 it doesn't react on swipe or drag event. > logcat shows these errors on any touch: > E/eglCodecCommon( 1075): glUtilsParamSize: unknow param 0x0b44 > E/eglCodecCommon( 1075): glUtilsParamSize: unknow param 0x0bd0 > E/eglCodecCommon( 1075): ERROR unknown type 0x0 (glSizeof,72) > E/eglCodecCommon( 1075): ERROR unknown type 0x0 (glSizeof,72) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-5049) Create defaults.xml that contains platform config.xml defaults for WP8
[ https://issues.apache.org/jira/browse/CB-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov resolved CB-5049. Resolution: Fixed > Create defaults.xml that contains platform config.xml defaults for WP8 > -- > > Key: CB-5049 > URL: https://issues.apache.org/jira/browse/CB-5049 > Project: Apache Cordova > Issue Type: Sub-task > Components: WP8 >Reporter: Jeffrey Heifetz >Assignee: Jesse MacFadyen > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7128) Add a back button to the UI of the plugin test framework
[ https://issues.apache.org/jira/browse/CB-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eddy Verbruggen resolved CB-7128. - Resolution: Fixed This has now been fixed by this checkin: https://github.com/apache/cordova-plugin-test-framework/commit/9e6f054888cfb92fbd892480ff3640962a2d337f#diff-129990972d55bc1f357943a4473db894 > Add a back button to the UI of the plugin test framework > > > Key: CB-7128 > URL: https://issues.apache.org/jira/browse/CB-7128 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin TestFramework >Affects Versions: 3.5.0 >Reporter: Eddy Verbruggen >Priority: Minor > > Hi guys, > I really like the cordova plugin test framework. The only pain I experienced > was trying to integrate it with my own app. It's a demo app to show off the > features of my plugin(s) and it seemed cool to add a link to > 'cdvtests/index.html' as mentioned at the very bottom of this page: > https://github.com/apache/cordova-plugin-test-framework > However, on iOS: how do you get back to your app? On WP8 and Android you can > press the hardware backbutton, but on iOS you need to kill and restart the > app. > IMHO a 'back to your app' or 'restart your app' button at the top of the page > would really help adoption and integration of this neat little framework. > Btw, this is not to be confused with the 'Reset App' button already on the > page as this reloads the cdvtests/index.html, not the root index.html. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6957) Battery tests need to be ported to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063453#comment-14063453 ] ASF GitHub Bot commented on CB-6957: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/13 CB-6957 Ported Battery-status manual & automated tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 Features: -No spies. -Tests failing faster, when a error callback or unexpected success callback is received, the test fails immediately. -Jasmine report with more information about the failed operation, which contains the operation and a description about it. -Short timeouts for listeners and event listeners. -Ported manual tests. Tested and validated over device. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-battery-status CB-6957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 8ff34324139ed68e64a927e21086beb424da4cb7 Author: Martin Gonzalez Date: 2014-07-16T13:11:10Z CB-6957 Ported Battery-status manual & automated Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 Features: -No spies. -Tests failing faster, when a error callback or unexpected success callback is received, the test fails immediately. -Jasmine report with more information about the failed operation, which contains the operation and a description about it. -Short timeouts for listeners and event listeners. -Ported manual tests. Tested and validated over device. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 > Battery tests need to be ported to plugin-test-framework > > > Key: CB-6957 > URL: https://issues.apache.org/jira/browse/CB-6957 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Battery Status >Reporter: Staci Cooper >Assignee: Martin Gonzalez > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6963) Port media tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063448#comment-14063448 ] ASF GitHub Bot commented on CB-6963: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/14 CB-6963 Ported Vibration automated & manual tests Ported tests from Mobilespec. Jasmine version: ported from v1.3 to v2.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-vibration CB-6963 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 53760ccbf19964d20e9a6693cb1f52050f2c5391 Author: Martin Gonzalez Date: 2014-07-15T20:33:20Z CB-6963, ported vibration automated & manual tests Ported tests from mobilespec. Jasmine version: ported from v1.3 to v2.0 commit d19f7539b2add88db649aa1f4fdbe5b032029f3f Author: Martin Gonzalez Date: 2014-07-15T22:41:54Z Adding comment > Port media tests to plugin-test-framework > - > > Key: CB-6963 > URL: https://issues.apache.org/jira/browse/CB-6963 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Media >Reporter: Staci Cooper >Assignee: Martin Gonzalez >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7144) Windows8 run fails if replace default certificate
[ https://issues.apache.org/jira/browse/CB-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov updated CB-7144: --- Assignee: Jesse MacFadyen (was: Sergey Grebnov) > Windows8 run fails if replace default certificate > - > > Key: CB-7144 > URL: https://issues.apache.org/jira/browse/CB-7144 > Project: Apache Cordova > Issue Type: Bug > Components: Windows 8 >Reporter: Sergey Grebnov >Assignee: Jesse MacFadyen > > This occurs in the following situations: > 1.User has replaced his original certificate (.pfx) with another one, or > changed his certificate inside Visual Studio. Cordova script incorrectly > handles this situation so runs .ps file with ‘–force’ parameter (since we > test for Developer license only). > 2.(unlikely) Publisher certificate was removed from local certificates’ > store (manually or automatically). > 3.(unlikely) Some error occurred during first launch of ‘cordova run > windows8’ on clean machine, so Developer license was acquired but no > publisher certificate was installed. > In all situations above 'cordova run windows8' will fail with the following > error > Before installing this app, you need to do the following: > - Install the signing certificate > You must provide administrator credentials to proceed. Please run this script > ithout the -Force parameter or from an elevated PowerShell window. > powershell -ExecutionPolicy RemoteSigned ". > .\\cordova\lib\WindowsStoreAppUtils > ps1; Start-Locally 'io.cordova.hellocordova'" > ActivateApplication: ! > Get-AppxPackageManifest : Cannot validate argument on parameter 'Package'. The > argument is null or empty. Provide an argument that is not null or empty, and > then try the command again. > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:108 char:41 > + $manifest = Get-appxpackagemanifest $package > + > + CategoryInfo : InvalidData: (:) [Get-AppxPackageManifest], Para >meterBindingValidationException > + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.Windo >ws.Appx.PackageManager.Commands.GetAppxPackageManifestCommand > Exception calling "ActivateApplication" with "4" argument(s): "Value does not > fall within the expected range." > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:115 char:5 > + > $appActivator.ActivateApplication($applicationUserModelId,$null,[StoreAppRun > ... > + > ~ > ~~~ > + CategoryInfo : NotSpecified: (:) [], MethodInvocationException > + FullyQualifiedErrorId : ArgumentException > Error: > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\run > bat: Command failed with exit code 2 > at ChildProcess.whenDone > (C:\Users\clantz\AppData\Roaming\npm\node_modules\ > ordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23) > at ChildProcess.EventEmitter.emit (events.js:98:17) > at maybeClose (child_process.js:735:16) > at Process.ChildProcess._handle.onexit (child_process.js:802:5) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7144) Windows8 run fails if replace default certificate
[ https://issues.apache.org/jira/browse/CB-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063444#comment-14063444 ] ASF GitHub Bot commented on CB-7144: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/37 CB-7144 Windows8 run fails if replace default certificate https://issues.apache.org/jira/browse/CB-7144 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-7144 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit dabf44423d1aecbc927578283a7c23f0c1ccaba5 Author: sgrebnov Date: 2014-07-16T12:56:28Z CB-7144 Windows8 run fails if replace default certificate > Windows8 run fails if replace default certificate > - > > Key: CB-7144 > URL: https://issues.apache.org/jira/browse/CB-7144 > Project: Apache Cordova > Issue Type: Bug > Components: Windows 8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > This occurs in the following situations: > 1.User has replaced his original certificate (.pfx) with another one, or > changed his certificate inside Visual Studio. Cordova script incorrectly > handles this situation so runs .ps file with ‘–force’ parameter (since we > test for Developer license only). > 2.(unlikely) Publisher certificate was removed from local certificates’ > store (manually or automatically). > 3.(unlikely) Some error occurred during first launch of ‘cordova run > windows8’ on clean machine, so Developer license was acquired but no > publisher certificate was installed. > In all situations above 'cordova run windows8' will fail with the following > error > Before installing this app, you need to do the following: > - Install the signing certificate > You must provide administrator credentials to proceed. Please run this script > ithout the -Force parameter or from an elevated PowerShell window. > powershell -ExecutionPolicy RemoteSigned ". > .\\cordova\lib\WindowsStoreAppUtils > ps1; Start-Locally 'io.cordova.hellocordova'" > ActivateApplication: ! > Get-AppxPackageManifest : Cannot validate argument on parameter 'Package'. The > argument is null or empty. Provide an argument that is not null or empty, and > then try the command again. > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:108 char:41 > + $manifest = Get-appxpackagemanifest $package > + > + CategoryInfo : InvalidData: (:) [Get-AppxPackageManifest], Para >meterBindingValidationException > + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.Windo >ws.Appx.PackageManager.Commands.GetAppxPackageManifestCommand > Exception calling "ActivateApplication" with "4" argument(s): "Value does not > fall within the expected range." > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:115 char:5 > + > $appActivator.ActivateApplication($applicationUserModelId,$null,[StoreAppRun > ... > + > ~ > ~~~ > + CategoryInfo : NotSpecified: (:) [], MethodInvocationException > + FullyQualifiedErrorId : ArgumentException > Error: > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\run > bat: Command failed with exit code 2 > at ChildProcess.whenDone > (C:\Users\clantz\AppData\Roaming\npm\node_modules\ > ordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23) > at ChildProcess.EventEmitter.emit (events.js:98:17) > at maybeClose (child_process.js:735:16) > at Process.ChildProcess._handle.onexit (child_process.js:802:5) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7094) Port manual file tests to plugin-test-framework
[ https://issues.apache.org/jira/browse/CB-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063443#comment-14063443 ] ASF GitHub Bot commented on CB-7094: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/62 CB-7094 Ported File manual tests Only contains file manual tests for android and iOS. Both tested and validated. All outputs and results to log content. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7094 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 21b568f3a25d5a10f231fbf5989ca07242da6e81 Author: Martin Gonzalez Date: 2014-07-16T12:52:40Z CB-7094 Ported File manual tests Only contains file manual tests for android and iOS. Both tested and validated. All outputs and results to log content. createActionButton it depends of this PR: https://github.com/apache/cordova-plugin-test-framework/pull/1 > Port manual file tests to plugin-test-framework > --- > > Key: CB-7094 > URL: https://issues.apache.org/jira/browse/CB-7094 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin File >Affects Versions: 3.5.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: plugin-file > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7144) Windows8 run fails if replace default certificate
[ https://issues.apache.org/jira/browse/CB-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063438#comment-14063438 ] Sergey Grebnov commented on CB-7144: Required fix (similar to CheckIfNeedDeveloperLicense logic): Update WindowsStoreAppUtils.ps1. We should add logic to check whether certificate installation is required (similar to CheckIfNeedDeveloperLicense ) and don't use '--force' in this case. > Windows8 run fails if replace default certificate > - > > Key: CB-7144 > URL: https://issues.apache.org/jira/browse/CB-7144 > Project: Apache Cordova > Issue Type: Bug > Components: Windows 8 >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > This occurs in the following situations: > 1.User has replaced his original certificate (.pfx) with another one, or > changed his certificate inside Visual Studio. Cordova script incorrectly > handles this situation so runs .ps file with ‘–force’ parameter (since we > test for Developer license only). > 2.(unlikely) Publisher certificate was removed from local certificates’ > store (manually or automatically). > 3.(unlikely) Some error occurred during first launch of ‘cordova run > windows8’ on clean machine, so Developer license was acquired but no > publisher certificate was installed. > In all situations above 'cordova run windows8' will fail with the following > error > Before installing this app, you need to do the following: > - Install the signing certificate > You must provide administrator credentials to proceed. Please run this script > ithout the -Force parameter or from an elevated PowerShell window. > powershell -ExecutionPolicy RemoteSigned ". > .\\cordova\lib\WindowsStoreAppUtils > ps1; Start-Locally 'io.cordova.hellocordova'" > ActivateApplication: ! > Get-AppxPackageManifest : Cannot validate argument on parameter 'Package'. The > argument is null or empty. Provide an argument that is not null or empty, and > then try the command again. > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:108 char:41 > + $manifest = Get-appxpackagemanifest $package > + > + CategoryInfo : InvalidData: (:) [Get-AppxPackageManifest], Para >meterBindingValidationException > + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.Windo >ws.Appx.PackageManager.Commands.GetAppxPackageManifestCommand > Exception calling "ActivateApplication" with "4" argument(s): "Value does not > fall within the expected range." > At > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win > dowsStoreAppUtils.ps1:115 char:5 > + > $appActivator.ActivateApplication($applicationUserModelId,$null,[StoreAppRun > ... > + > ~ > ~~~ > + CategoryInfo : NotSpecified: (:) [], MethodInvocationException > + FullyQualifiedErrorId : ArgumentException > Error: > C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\run > bat: Command failed with exit code 2 > at ChildProcess.whenDone > (C:\Users\clantz\AppData\Roaming\npm\node_modules\ > ordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23) > at ChildProcess.EventEmitter.emit (events.js:98:17) > at maybeClose (child_process.js:735:16) > at Process.ChildProcess._handle.onexit (child_process.js:802:5) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7144) Windows8 run fails if replace default certificate
Sergey Grebnov created CB-7144: -- Summary: Windows8 run fails if replace default certificate Key: CB-7144 URL: https://issues.apache.org/jira/browse/CB-7144 Project: Apache Cordova Issue Type: Bug Components: Windows 8 Reporter: Sergey Grebnov Assignee: Sergey Grebnov This occurs in the following situations: 1. User has replaced his original certificate (.pfx) with another one, or changed his certificate inside Visual Studio. Cordova script incorrectly handles this situation so runs .ps file with ‘–force’ parameter (since we test for Developer license only). 2. (unlikely) Publisher certificate was removed from local certificates’ store (manually or automatically). 3. (unlikely) Some error occurred during first launch of ‘cordova run windows8’ on clean machine, so Developer license was acquired but no publisher certificate was installed. In all situations above 'cordova run windows8' will fail with the following error Before installing this app, you need to do the following: - Install the signing certificate You must provide administrator credentials to proceed. Please run this script ithout the -Force parameter or from an elevated PowerShell window. powershell -ExecutionPolicy RemoteSigned ". .\\cordova\lib\WindowsStoreAppUtils ps1; Start-Locally 'io.cordova.hellocordova'" ActivateApplication: ! Get-AppxPackageManifest : Cannot validate argument on parameter 'Package'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again. At C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win dowsStoreAppUtils.ps1:108 char:41 + $manifest = Get-appxpackagemanifest $package + + CategoryInfo : InvalidData: (:) [Get-AppxPackageManifest], Para meterBindingValidationException + FullyQualifiedErrorId : ParameterArgumentValidationError,Microsoft.Windo ws.Appx.PackageManager.Commands.GetAppxPackageManifestCommand Exception calling "ActivateApplication" with "4" argument(s): "Value does not fall within the expected range." At C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\lib\Win dowsStoreAppUtils.ps1:115 char:5 + $appActivator.ActivateApplication($applicationUserModelId,$null,[StoreAppRun ... + ~ ~~~ + CategoryInfo : NotSpecified: (:) [], MethodInvocationException + FullyQualifiedErrorId : ArgumentException Error: C:\Users\clantz\Documents\cordova\win8run\platforms\windows8\cordova\run bat: Command failed with exit code 2 at ChildProcess.whenDone (C:\Users\clantz\AppData\Roaming\npm\node_modules\ ordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23) at ChildProcess.EventEmitter.emit (events.js:98:17) at maybeClose (child_process.js:735:16) at Process.ChildProcess._handle.onexit (child_process.js:802:5) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7003) navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions
[
https://issues.apache.org/jira/browse/CB-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov resolved CB-7003.
Resolution: Fixed
> navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3
> versions
>
>
> Key: CB-7003
> URL: https://issues.apache.org/jira/browse/CB-7003
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Contacts
>Affects Versions: 3.5.0
>Reporter: Meshkov Alex
>Assignee: Ian Clelland
>
> This issue touches pickContact method on Android devices. Simple call
> {code}
> navigator.contacts.pickContact(function (contact) {
> if (contact.id == -1) {
> return false;
> }
> alert(contact.name.formatted);
> });
> {code}
> return wrong _contact.name.formatted_ value. For instance if I select _Mom_
> contact I would get Maria's contact object.
> This bug affects Android versions 4.3 (Samsung Galaxy S3) and 4.4.3 (Nexus 4)
> I haven't tested on other devices.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7131) Contact picker returns photo url even if a contact doesn't have one. (Android 4.4.4, 4.3)
[
https://issues.apache.org/jira/browse/CB-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063432#comment-14063432
]
Sergey Grebnov commented on CB-7131:
I'll take a look and will report back.
> Contact picker returns photo url even if a contact doesn't have one. (Android
> 4.4.4, 4.3)
> -
>
> Key: CB-7131
> URL: https://issues.apache.org/jira/browse/CB-7131
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Contacts
>Affects Versions: 3.5.0
>Reporter: Meshkov Alex
>Assignee: Sergey Grebnov
>Priority: Minor
>
> When I pick contact that doesn't have any avatar with
> {code}navigator.contacts.pickContact{code} I get contact object with photo
> url which is broken. Contact without avatar should not contain any photo
> urls, but somehow it does...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (CB-7131) Contact picker returns photo url even if a contact doesn't have one. (Android 4.4.4, 4.3)
[
https://issues.apache.org/jira/browse/CB-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Grebnov reassigned CB-7131:
--
Assignee: Sergey Grebnov
> Contact picker returns photo url even if a contact doesn't have one. (Android
> 4.4.4, 4.3)
> -
>
> Key: CB-7131
> URL: https://issues.apache.org/jira/browse/CB-7131
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Contacts
>Affects Versions: 3.5.0
>Reporter: Meshkov Alex
>Assignee: Sergey Grebnov
>Priority: Minor
>
> When I pick contact that doesn't have any avatar with
> {code}navigator.contacts.pickContact{code} I get contact object with photo
> url which is broken. Contact without avatar should not contain any photo
> urls, but somehow it does...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7132) Single default icon overridden by Cordova icon on Android
[ https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063426#comment-14063426 ] ASF GitHub Bot commented on CB-7132: Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-lib/pull/58#issuecomment-49157473 removed the extra lines. Strange they where there. > Single default icon overridden by Cordova icon on Android > -- > > Key: CB-7132 > URL: https://issues.apache.org/jira/browse/CB-7132 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CLI >Affects Versions: 3.5.0 >Reporter: Bryan Higgins >Assignee: Axel Nennker > > Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the > "single default icon" [1] not being displayed on device. > In 3.5.0-0.2.4 the icon was copied into drawable-* > In 3.5.0-0.2.6 the icon is copied to drawable/ > The template [2] already contains default icons for drawable-*, thus the > single default icon is never used. > [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html > [2] > https://github.com/apache/cordova-android/tree/master/bin/templates/project/res -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7143) OSX platform cannot be installed as described
Tim Stewart created CB-7143: --- Summary: OSX platform cannot be installed as described Key: CB-7143 URL: https://issues.apache.org/jira/browse/CB-7143 Project: Apache Cordova Issue Type: Bug Components: OSX Affects Versions: 3.5.0 Environment: OSX 10.9.4 Reporter: Tim Stewart Following instructions as per: https://github.com/apache/cordova-osx "Add the Cordova OSX Platform the a CLI project" [sic] does not work. I checked out cordova from master, completed all the npm linking as described in the linked instructions and checked cordova version: 3.5.0-0.2.7-dev I then tried to follow this instruction: "patch the 2 projects with the patches provided in the patches directory to enable the osx platform". I expected to be able to download and git apply these patches in the git root for each of the two node modules - cordova-cli and cordova-plugman. However, they are not set up correctly for this, and produced errors: error: platforms.js: No such file or directory error: src/platform.js: No such file or directory Indeed, the path locations in each patch do not seem to be vaild for any given location within either module. I thus ended up finding all files named platform.js and platforms.js (there are many, spread throughout the cordova-lib module within both cordova-cli and cordova-plugman), eyeballing them to see which files matched the patch changes, and copy/pasting the changes manually. (8 files in total, as the 4 "patched" files appear under cordova-lib in each cordova module.) When running cordova platform add osx, I then got an error about an invaild location for the ios-parser. I found the incorrect line in the "patched" cordova/platform.js and changed it as follows: parser : './metadata/ios_parser', Following this I was able to add the osx platform and run the app. Needless to say, this is a frustrating developer experience. I don't know why the osx platform information code is not included in cordova by default - it would seem to be fairly well isolated from effects on any other platform - but if it is going to be "upgradable" in this fashion, then the git patches should at least work. If they were designed to work (and ever did work) with a specific version of the cordova modules, or in a different location other than the git root, then that should be stated, instead of instructing the hapless developer to clone cordova from master and providing no further clues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7142) Support for restoring plugin "preferences" in "restore" CLI command
Nikolai Kotchetkov created CB-7142:
--
Summary: Support for restoring plugin "preferences" in "restore"
CLI command
Key: CB-7142
URL: https://issues.apache.org/jira/browse/CB-7142
Project: Apache Cordova
Issue Type: Improvement
Components: CLI, Plugman
Affects Versions: 3.5.0
Reporter: Nikolai Kotchetkov
Thanks for great improvement having the plugin list in config.xml!
However it will be great if "preferences" passed to plugman as variables could
be saved there to.
Like:
{noformat}
https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git"; />
{noformat}
I've made a rather simple fix for that in [this
commit|https://github.com/motorro/cordova-lib/commit/4c5765404ed8714a5ea0f8d5e026d3280335405d]
The code also has a feature of setting and using a plugin URL to install.
Two more things required:
# To be able to specify preferences per plugin to avoid possible name conflict
- that involves installing plugins one-by-one rather than in batch as far as I
understand the 'plugin("add")'
# Add support to reinstalling plugins with respect to preferences on platform
add - did not dig the code yet.
It would be nice if someone comment on the issue - am I right or missing
something already done. Also I can fullfill the requirement myself and issue a
pull request if the feature seems handy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
