[jira] [Commented] (CB-7333) Windows: Default native project template should be overridable at project creation time
[ https://issues.apache.org/jira/browse/CB-7333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101980#comment-14101980 ] ASF GitHub Bot commented on CB-7333: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/40 CB-7333 Makes default platform template files overridable https://issues.apache.org/jira/browse/CB-7333 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-7333 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit db2c0edc522cf4796dcd0eaed8e9c4fa759e1a15 Author: Vladimir Kotikov Date: 2014-08-19T07:02:57Z CB-7333 Makes default platform template files overridable > Windows: Default native project template should be overridable at project > creation time > --- > > Key: CB-7333 > URL: https://issues.apache.org/jira/browse/CB-7333 > Project: Apache Cordova > Issue Type: Sub-task > Components: Windows 8 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4655) WP8: Default native project template should be overridable at project creation time
[ https://issues.apache.org/jira/browse/CB-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101981#comment-14101981 ] ASF GitHub Bot commented on CB-4655: GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-wp8/pull/49 CB-4655 Makes default platform template files overridable Better implementation for https://issues.apache.org/jira/browse/CB-4655 Updated due to @sgrebnov's [comment](https://issues.apache.org/jira/browse/CB-4650?focusedCommentId=14100327&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14100327) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-wp8 CB-4655 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit 79c2cae2d264649c8aca29eb25dcd1042855a019 Author: Vladimir Kotikov Date: 2014-08-19T06:50:50Z CB-4655 Makes default platform template files overridable > WP8: Default native project template should be overridable at project > creation time > --- > > Key: CB-4655 > URL: https://issues.apache.org/jira/browse/CB-4655 > Project: Apache Cordova > Issue Type: Sub-task > Components: WP8 >Reporter: Ian Clelland >Assignee: Jesse MacFadyen > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7129) Switch to nodejs for windows platform scripts
[ https://issues.apache.org/jira/browse/CB-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102102#comment-14102102 ] ASF subversion and git services commented on CB-7129: - Commit 9b324865992a7291da022e5f5037646ffe40c7c7 in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=9b32486 ] CB-7129 Fixes issue when project isn't built if msbuild v12.0 is not found. > Switch to nodejs for windows platform scripts > - > > Key: CB-7129 > URL: https://issues.apache.org/jira/browse/CB-7129 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows 8 >Affects Versions: 3.6.0 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Fix For: 3.6.0 > > > Current realization of platform/tooling scripts on Windows is using WSH > (Windows Scripting Host) as JS engine which works unpredictable with unicode > symbols (incorrect reading/writing of UTF-8 encoded files, incorect passing > of unicode paths as arguments to another scripts, etc.) > Switching to NodeJS can help to resolve many of unicode related issues in > cordova-windows projects. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7129) Switch to nodejs for windows platform scripts
[ https://issues.apache.org/jira/browse/CB-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102135#comment-14102135 ] ASF subversion and git services commented on CB-7129: - Commit 10eb7b4adadab20b0aa0fb84290da4638b1af986 in cordova-windows's branch refs/heads/master from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=10eb7b4 ] CB-7129 VS2012 solution now accepts "anycpu" target instead of "any cpu" > Switch to nodejs for windows platform scripts > - > > Key: CB-7129 > URL: https://issues.apache.org/jira/browse/CB-7129 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows 8 >Affects Versions: 3.6.0 >Reporter: Vladimir Kotikov >Assignee: Jesse MacFadyen > Fix For: 3.6.0 > > > Current realization of platform/tooling scripts on Windows is using WSH > (Windows Scripting Host) as JS engine which works unpredictable with unicode > symbols (incorrect reading/writing of UTF-8 encoded files, incorect passing > of unicode paths as arguments to another scripts, etc.) > Switching to NodeJS can help to resolve many of unicode related issues in > cordova-windows projects. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7334) Implement Workaround for Android Iddue 38282 (Android MTP support does not show recent files until the device is rebooted)
Marco Scholle created CB-7334:
-
Summary: Implement Workaround for Android Iddue 38282 (Android MTP
support does not show recent files until the device is rebooted)
Key: CB-7334
URL: https://issues.apache.org/jira/browse/CB-7334
Project: Apache Cordova
Issue Type: Improvement
Components: Plugin File
Affects Versions: 3.5.0
Environment: Any Android Version using MTP
Reporter: Marco Scholle
Link to Android Issue:
https://code.google.com/p/android/issues/detail?id=38282
This also applies to cordova, making it impossible to export a file using the
file api/plugin and afterwards copying it to a PC using MTP.
A wourkarounf mentioned in the issue is "to add the following code after every
file close (https://code.google.com/p/android/issues/detail?id=38282#c2):
MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath() },
null, null);
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7334) Implement Workaround for Android Iddue 38282 (Android MTP support does not show recent files until the device is rebooted)
[
https://issues.apache.org/jira/browse/CB-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marco Scholle updated CB-7334:
--
Description:
Link to Android Issue:
https://code.google.com/p/android/issues/detail?id=38282
This also applies to cordova, making it impossible to export a file using the
file api/plugin and afterwards copying it to a PC using MTP.
A workaround mentioned in the issue is "to add the following code after every
file close (https://code.google.com/p/android/issues/detail?id=38282#c2):
MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath() },
null, null);
was:
Link to Android Issue:
https://code.google.com/p/android/issues/detail?id=38282
This also applies to cordova, making it impossible to export a file using the
file api/plugin and afterwards copying it to a PC using MTP.
A wourkarounf mentioned in the issue is "to add the following code after every
file close (https://code.google.com/p/android/issues/detail?id=38282#c2):
MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath() },
null, null);
> Implement Workaround for Android Iddue 38282 (Android MTP support does not
> show recent files until the device is rebooted)
> --
>
> Key: CB-7334
> URL: https://issues.apache.org/jira/browse/CB-7334
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin File
>Affects Versions: 3.5.0
> Environment: Any Android Version using MTP
>Reporter: Marco Scholle
>
> Link to Android Issue:
> https://code.google.com/p/android/issues/detail?id=38282
> This also applies to cordova, making it impossible to export a file using the
> file api/plugin and afterwards copying it to a PC using MTP.
> A workaround mentioned in the issue is "to add the following code after every
> file close (https://code.google.com/p/android/issues/detail?id=38282#c2):
> MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath()
> }, null, null);
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-7334) Implement Workaround for Android Iddue 38282 (Android MTP support does not show recent files until the device is rebooted)
[
https://issues.apache.org/jira/browse/CB-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marco Scholle updated CB-7334:
--
Description:
Link to Android Issue:
https://code.google.com/p/android/issues/detail?id=38282
This also applies to cordova, making it impossible to export a file using the
file api/plugin and afterwards copying it to a PC using MTP.
A workaround mentioned in the issue is "to add the following code after every
file close" (https://code.google.com/p/android/issues/detail?id=38282#c2):
MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath() },
null, null);
was:
Link to Android Issue:
https://code.google.com/p/android/issues/detail?id=38282
This also applies to cordova, making it impossible to export a file using the
file api/plugin and afterwards copying it to a PC using MTP.
A workaround mentioned in the issue is "to add the following code after every
file close (https://code.google.com/p/android/issues/detail?id=38282#c2):
MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath() },
null, null);
> Implement Workaround for Android Iddue 38282 (Android MTP support does not
> show recent files until the device is rebooted)
> --
>
> Key: CB-7334
> URL: https://issues.apache.org/jira/browse/CB-7334
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin File
>Affects Versions: 3.5.0
> Environment: Any Android Version using MTP
>Reporter: Marco Scholle
>
> Link to Android Issue:
> https://code.google.com/p/android/issues/detail?id=38282
> This also applies to cordova, making it impossible to export a file using the
> file api/plugin and afterwards copying it to a PC using MTP.
> A workaround mentioned in the issue is "to add the following code after every
> file close" (https://code.google.com/p/android/issues/detail?id=38282#c2):
> MediaScannerConnection.scanFile(this, new String[] { file.getAbsolutePath()
> }, null, null);
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6724) manual tests should have docs indicating the expected result
[ https://issues.apache.org/jira/browse/CB-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102243#comment-14102243 ] ASF GitHub Bot commented on CB-6724: Github user eymorale closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/14 > manual tests should have docs indicating the expected result > > > Key: CB-6724 > URL: https://issues.apache.org/jira/browse/CB-6724 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Edna Morales >Priority: Minor > > The manual tests in mobile-spec have buttons that do things and test the > functions, but there is no indication and no documentation associated with > those tests that indicate what the expected result should be. So it becomes > difficult to compare the expected result with the actual result, unless you > are very familiar with the function and know in your head what the expected > result should be. It would be good if the expected result is documented, so > non-experts can run the manual tests and validate the results. > The manual tests for InAppBrowser do include some documentation of the > expected inline with the buttons, so that may be considered a prototype of > what is needed here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6724) manual tests should have docs indicating the expected result
[ https://issues.apache.org/jira/browse/CB-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102246#comment-14102246 ] Edna Morales commented on CB-6724: -- Thanks for merging these in Jesse > manual tests should have docs indicating the expected result > > > Key: CB-6724 > URL: https://issues.apache.org/jira/browse/CB-6724 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Edna Morales >Priority: Minor > > The manual tests in mobile-spec have buttons that do things and test the > functions, but there is no indication and no documentation associated with > those tests that indicate what the expected result should be. So it becomes > difficult to compare the expected result with the actual result, unless you > are very familiar with the function and know in your head what the expected > result should be. It would be good if the expected result is documented, so > non-experts can run the manual tests and validate the results. > The manual tests for InAppBrowser do include some documentation of the > expected inline with the buttons, so that may be considered a prototype of > what is needed here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102263#comment-14102263 ] ASF subversion and git services commented on CB-7249: - Commit 965b134c6616d40b1f16b915dda7b09236d4a9e5 in cordova-plugin-device-motion's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-motion.git;h=965b134 ] CB-7249cordova-plugin-device-motion documentation translation: cordova-plugin-device-motion > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102260#comment-14102260 ] ASF subversion and git services commented on CB-7249: - Commit c785a25fddd96eac2b7cf124b8452cf872a07570 in cordova-docs's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=c785a25 ] CB-7249cordova-docs documentation translation: cordova-docs > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102262#comment-14102262 ] ASF subversion and git services commented on CB-7249: - Commit 10bae15d4ae8d9bda8f1e34389199b1509bffa7c in cordova-plugin-contacts's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=10bae15 ] CB-7249cordova-plugin-contacts documentation translation: cordova-plugin-contacts > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102261#comment-14102261 ] ASF subversion and git services commented on CB-7249: - Commit 4e7319d650b3131c31afad15e1ccaab8e0a8b6cf in cordova-plugin-battery-status's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=4e7319d ] CB-7249cordova-plugin-battery-status documentation translation: cordova-plugin-battery-status > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6724) manual tests should have docs indicating the expected result
[ https://issues.apache.org/jira/browse/CB-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102266#comment-14102266 ] ASF subversion and git services commented on CB-6724: - Commit aed63c8ffe06dcf620bbf73e1e3bd6ba1f4b38f5 in cordova-plugin-network-information's branch refs/heads/master from [~eymorale] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=aed63c8 ] CB-6724 added documentation for manual tests github: close #17 > manual tests should have docs indicating the expected result > > > Key: CB-6724 > URL: https://issues.apache.org/jira/browse/CB-6724 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Edna Morales >Priority: Minor > > The manual tests in mobile-spec have buttons that do things and test the > functions, but there is no indication and no documentation associated with > those tests that indicate what the expected result should be. So it becomes > difficult to compare the expected result with the actual result, unless you > are very familiar with the function and know in your head what the expected > result should be. It would be good if the expected result is documented, so > non-experts can run the manual tests and validate the results. > The manual tests for InAppBrowser do include some documentation of the > expected inline with the buttons, so that may be considered a prototype of > what is needed here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102265#comment-14102265 ] ASF subversion and git services commented on CB-7249: - Commit 871719d38a27ce7b919c56f8ae532244c3b25404 in cordova-plugin-vibration's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=871719d ] CB-7249cordova-plugin-vibration documentation translation: cordova-plugin-vibration > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102264#comment-14102264 ] ASF subversion and git services commented on CB-7249: - Commit 0f63861e887b983d2434f8b984725553a7093a87 in cordova-plugin-splashscreen's branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=0f63861 ] CB-7249cordova-plugin-splashscreen documentation translation: cordova-plugin-splashscreen > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6724) manual tests should have docs indicating the expected result
[ https://issues.apache.org/jira/browse/CB-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102269#comment-14102269 ] ASF GitHub Bot commented on CB-6724: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/17 > manual tests should have docs indicating the expected result > > > Key: CB-6724 > URL: https://issues.apache.org/jira/browse/CB-6724 > Project: Apache Cordova > Issue Type: Improvement > Components: mobile-spec >Reporter: Marcel Kinard >Assignee: Edna Morales >Priority: Minor > > The manual tests in mobile-spec have buttons that do things and test the > functions, but there is no indication and no documentation associated with > those tests that indicate what the expected result should be. So it becomes > difficult to compare the expected result with the actual result, unless you > are very familiar with the function and know in your head what the expected > result should be. It would be good if the expected result is documented, so > non-experts can run the manual tests and validate the results. > The manual tests for InAppBrowser do include some documentation of the > expected inline with the buttons, so that may be considered a prototype of > what is needed here. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7320) ErrorUrl in config.xml no longer has any effect
[ https://issues.apache.org/jira/browse/CB-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7320. --- Resolution: Fixed Fix Version/s: 3.6.0 This looks to be already fixed on master from the CordovaPreferences refactor. > ErrorUrl in config.xml no longer has any effect > --- > > Key: CB-7320 > URL: https://issues.apache.org/jira/browse/CB-7320 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 3.5.0 >Reporter: Alan Kinzie >Assignee: Vivek Thakur > Fix For: 3.6.0 > > > On Android, as of Cordova 3.5, setting the ErrorUrl in the config.xml has no > effect. It appears that with Cordova 3.5, the way the errorUrl is stored was > changed (see > https://github.com/apache/cordova-android/commit/2ab81bc5aeb575fef3657cf48a671607e81ca37d). > In CordovaActivity.java, in the onReceivedError function it still tries to > get the errorUrl the old way (see line 718 vs line 917 in > CordovaActivity.java: > https://github.com/apache/cordova-android/blob/3.5.x/framework/src/org/apache/cordova/CordovaActivity.java). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7330) Cannot create android project without android SDK installed
[ https://issues.apache.org/jira/browse/CB-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102346#comment-14102346 ] ASF subversion and git services commented on CB-7330: - Commit 58cdfd86d0b6fabba3ce0e505a361225dca3b3c6 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=58cdfd8 ] CB-7330 Fix dangling function call in last commit (broke gradle builds) > Cannot create android project without android SDK installed > --- > > Key: CB-7330 > URL: https://issues.apache.org/jira/browse/CB-7330 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > More of a minor annoyance, but you should be able to run `cordova platform > add android` without the SDK installed. Requiring it to build or run makes > sense, but we shouldn't need it just to stamp out a project template. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7335) Add a default .gitignore for Android projects
Andrew Grieve created CB-7335: - Summary: Add a default .gitignore for Android projects Key: CB-7335 URL: https://issues.apache.org/jira/browse/CB-7335 Project: Apache Cordova Issue Type: Improvement Components: Android Reporter: Andrew Grieve Assignee: Andrew Grieve Priority: Minor With all the build artifacts now involved in an Android project (eclipse vs ant vs gradle), it's worth having a default .gitignore. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7335) Add a default .gitignore for Android projects
[ https://issues.apache.org/jira/browse/CB-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102355#comment-14102355 ] ASF subversion and git services commented on CB-7335: - Commit 71e72f215dd7472ac2be4aabd0154b41a24df6e5 in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=71e72f2 ] CB-7335 Add a .gitignore to android project template > Add a default .gitignore for Android projects > - > > Key: CB-7335 > URL: https://issues.apache.org/jira/browse/CB-7335 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > With all the build artifacts now involved in an Android project (eclipse vs > ant vs gradle), it's worth having a default .gitignore. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102360#comment-14102360 ] Daniel Gruno commented on CB-7249: -- testing, ignore me. > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7335) Add a default .gitignore for Android projects
[ https://issues.apache.org/jira/browse/CB-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102365#comment-14102365 ] ASF subversion and git services commented on CB-7335: - Commit 71e72f215dd7472ac2be4aabd0154b41a24df6e5 in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=71e72f2 ] CB-7335 Add a .gitignore to android project template > Add a default .gitignore for Android projects > - > > Key: CB-7335 > URL: https://issues.apache.org/jira/browse/CB-7335 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > With all the build artifacts now involved in an Android project (eclipse vs > ant vs gradle), it's worth having a default .gitignore. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3445) Move Cordova-Android Build Setup to Gradle
[ https://issues.apache.org/jira/browse/CB-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102361#comment-14102361 ] ASF subversion and git services commented on CB-3445: - Commit d56ea25816a72b21e7a15d88ae0dfcb62742a66d in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=d56ea25 ] CB-3445 Add gradle support clean command (plus some code cleanup) * Don't run ant clean for gradle ever * Don't set sdk.dir since ANDROID_HOME is not always set * Don't export builders > Move Cordova-Android Build Setup to Gradle > -- > > Key: CB-3445 > URL: https://issues.apache.org/jira/browse/CB-3445 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Joe Bowser >Assignee: Ian Clelland >Priority: Minor > > Currently we're using ant for our setup, and our setup can break every time > that the Android SDK updates and change its build.xml. However, the Android > Team has created Gradle to be more robust such that it doesn't have the same > problems as ant-based scripts. > This also has the advantage of using Android Studio for development instead > of Eclipse, and the ability for us to bundle resources, which is something we > haven't been able to do before. > Moving to Gradle has numerous advantages, but will break scripts, so this is > to be moved in the post-3.0 timeframe. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102362#comment-14102362 ] Josh Soref commented on CB-7249: [~ldeluca]: could you please fix the script to include a space after the jira issue in the commit message? > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7330) Cannot create android project without android SDK installed
[ https://issues.apache.org/jira/browse/CB-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102363#comment-14102363 ] ASF subversion and git services commented on CB-7330: - Commit dfa66b9dd44e52e96fc2c8b4d1c8661c8b0074bb in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=dfa66b9 ] CB-7330 Don't run "android update" during creation Instead, have the build script copy do the equivalent logic on each build. Advantages: - Scripts run much faster - No more duplicate CordovaLib entries in project.properties - Building is more independent from create/update script (more robust) > Cannot create android project without android SDK installed > --- > > Key: CB-7330 > URL: https://issues.apache.org/jira/browse/CB-7330 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > More of a minor annoyance, but you should be able to run `cordova platform > add android` without the SDK installed. Requiring it to build or run makes > sense, but we shouldn't need it just to stamp out a project template. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7330) Cannot create android project without android SDK installed
[ https://issues.apache.org/jira/browse/CB-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102364#comment-14102364 ] ASF subversion and git services commented on CB-7330: - Commit 58cdfd86d0b6fabba3ce0e505a361225dca3b3c6 in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=58cdfd8 ] CB-7330 Fix dangling function call in last commit (broke gradle builds) > Cannot create android project without android SDK installed > --- > > Key: CB-7330 > URL: https://issues.apache.org/jira/browse/CB-7330 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > More of a minor annoyance, but you should be able to run `cordova platform > add android` without the SDK installed. Requiring it to build or run makes > sense, but we shouldn't need it just to stamp out a project template. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102360#comment-14102360 ] Daniel Gruno edited comment on CB-7249 at 8/19/14 4:05 PM: --- testing, ignore me was (Author: humbedooh): testing, ignore me. > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7335) Add a default .gitignore for Android projects
[ https://issues.apache.org/jira/browse/CB-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve resolved CB-7335. --- Resolution: Fixed Fixed in 3.6.0-dev > Add a default .gitignore for Android projects > - > > Key: CB-7335 > URL: https://issues.apache.org/jira/browse/CB-7335 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Reporter: Andrew Grieve >Assignee: Andrew Grieve >Priority: Minor > > With all the build artifacts now involved in an Android project (eclipse vs > ant vs gradle), it's worth having a default .gitignore. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7336) cordova platform add blackberry10 is broken
Josh Soref created CB-7336:
--
Summary: cordova platform add blackberry10 is broken
Key: CB-7336
URL: https://issues.apache.org/jira/browse/CB-7336
Project: Apache Cordova
Issue Type: Bug
Components: BlackBerry, CLI
Affects Versions: 3.6.0
Reporter: Josh Soref
Priority: Blocker
{quote}
$ ~/Cordova/cordova-cli/bin/cordova platform add blackberry10
npm http GET https://registry.npmjs.org/cordova-blackberry10/3.5.0
npm http 404 https://registry.npmjs.org/cordova-blackberry10/3.5.0
Unable to fetch platform blackberry10: Error: 404 Not Found:
cordova-blackberry10
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7249) Translations for August
[ https://issues.apache.org/jira/browse/CB-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102417#comment-14102417 ] Lisa Seacat DeLuca commented on CB-7249: [~jsoref] fixed my local version of the script so the next time i run it there will be a space. > Translations for August > --- > > Key: CB-7249 > URL: https://issues.apache.org/jira/browse/CB-7249 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7263) Clarify support for remotely-loaded HTML content
[ https://issues.apache.org/jira/browse/CB-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102431#comment-14102431 ] ASF subversion and git services commented on CB-7263: - Commit 1618893 from [~cmarcelk] [ https://svn.apache.org/r1618893 ] CB-7263 publish update > Clarify support for remotely-loaded HTML content > > > Key: CB-7263 > URL: https://issues.apache.org/jira/browse/CB-7263 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > Fix For: 3.6.0 > > > See http://callback-dev.markmail.org/thread/ivvawqryziutqn7v -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7332) Module cordova/plugin//app does not exist when packaging plugins using browserify on Windows
[
https://issues.apache.org/jira/browse/CB-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102603#comment-14102603
]
ASF GitHub Bot commented on CB-7332:
Github user surajpindoria commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/77#discussion_r16433602
--- Diff: tasks/lib/require-tr.js ---
@@ -86,7 +88,15 @@ function _updateRequires(code) {
if(node instanceof UglifyJS.AST_Call) {
// check if function call is a require('module') call
if(node.expression.name === "require" && node.args.length === 1) {
+
+// Uglify is not able to recognize Windows style paths using '\'
instead of '/'
+// So replacing all of the '/' back to Windows '\'
+if (node.args[0].value !== undefined &&
node.args[0].value.indexOf('/android/app') !== -1 && process.platform ===
'win32') {
--- End diff --
I have added the check for the Windows platform now. I also removed the
check for 'c:' and changed it to check for '/android/app'. We need this here
because in the code above, we are actually replacing code in the source file,
so it needs to be changed back to appropriate Windows path.
@purplecabbage
> Module cordova/plugin//app does not exist when packaging plugins
> using browserify on Windows
> --
>
> Key: CB-7332
> URL: https://issues.apache.org/jira/browse/CB-7332
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7337) add Vagrant support for "rake build" in cordova-website
Marcel Kinard created CB-7337: - Summary: add Vagrant support for "rake build" in cordova-website Key: CB-7337 URL: https://issues.apache.org/jira/browse/CB-7337 Project: Apache Cordova Issue Type: Improvement Components: Website Reporter: Marcel Kinard Assignee: Marcel Kinard Priority: Minor Similar to how cordova-docs has Vagrant capability for instantiating the build environment, it would be nice to have the same thing for cordova-website and "rake build". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7337) add Vagrant support for "rake build" in cordova-website
[ https://issues.apache.org/jira/browse/CB-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102632#comment-14102632 ] ASF subversion and git services commented on CB-7337: - Commit 1618931 from [~cmarcelk] [ https://svn.apache.org/r1618931 ] CB-7337 Get a Vagrant VM working ...to make it easier to set up all the dependencies. Now you can do `rake build` and `rake serve` from the VM, and access both the generated files on the filesystem and the port 4000 http server from your bare-metal workstation. > add Vagrant support for "rake build" in cordova-website > --- > > Key: CB-7337 > URL: https://issues.apache.org/jira/browse/CB-7337 > Project: Apache Cordova > Issue Type: Improvement > Components: Website >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Similar to how cordova-docs has Vagrant capability for instantiating the > build environment, it would be nice to have the same thing for > cordova-website and "rake build". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-7337) add Vagrant support for "rake build" and "rake serve" in cordova-website
[ https://issues.apache.org/jira/browse/CB-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Kinard updated CB-7337: -- Summary: add Vagrant support for "rake build" and "rake serve" in cordova-website (was: add Vagrant support for "rake build" in cordova-website) > add Vagrant support for "rake build" and "rake serve" in cordova-website > > > Key: CB-7337 > URL: https://issues.apache.org/jira/browse/CB-7337 > Project: Apache Cordova > Issue Type: Improvement > Components: Website >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > > Similar to how cordova-docs has Vagrant capability for instantiating the > build environment, it would be nice to have the same thing for > cordova-website and "rake build". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (CB-7337) add Vagrant support for "rake build" and "rake serve" in cordova-website
[ https://issues.apache.org/jira/browse/CB-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Kinard resolved CB-7337. --- Resolution: Fixed Fix Version/s: 3.6.0 Thanks to Michal for setting the example in cordova-docs. > add Vagrant support for "rake build" and "rake serve" in cordova-website > > > Key: CB-7337 > URL: https://issues.apache.org/jira/browse/CB-7337 > Project: Apache Cordova > Issue Type: Improvement > Components: Website >Reporter: Marcel Kinard >Assignee: Marcel Kinard >Priority: Minor > Fix For: 3.6.0 > > > Similar to how cordova-docs has Vagrant capability for instantiating the > build environment, it would be nice to have the same thing for > cordova-website and "rake build". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7336) cordova platform add blackberry10 is broken
[
https://issues.apache.org/jira/browse/CB-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102700#comment-14102700
]
ASF GitHub Bot commented on CB-7336:
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/75
CB-7336 Fix cordova platform add blackberry10
Support arbitrary cordova npm package name
Run npm install for npm delivered platforms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry-webworks/cordova-lib cb_7336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
commit eec336e55dff934b4302be0ec7f2210d6c19dccd
Author: Josh Soref
Date: 2014-08-19T19:30:28Z
CB-7336 Fix cordova platform add blackberry10
Support arbitrary cordova npm package name
Run npm install for npm delivered platforms
> cordova platform add blackberry10 is broken
> ---
>
> Key: CB-7336
> URL: https://issues.apache.org/jira/browse/CB-7336
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CLI
>Affects Versions: 3.6.0
>Reporter: Josh Soref
>Priority: Blocker
>
> {quote}
> $ ~/Cordova/cordova-cli/bin/cordova platform add blackberry10
> npm http GET https://registry.npmjs.org/cordova-blackberry10/3.5.0
> npm http 404 https://registry.npmjs.org/cordova-blackberry10/3.5.0
> Unable to fetch platform blackberry10: Error: 404 Not Found:
> cordova-blackberry10
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-7339) Using browserify on Android plugins causes onDeviceReady to timeout
Suraj Pindoria created CB-7339: -- Summary: Using browserify on Android plugins causes onDeviceReady to timeout Key: CB-7339 URL: https://issues.apache.org/jira/browse/CB-7339 Project: Apache Cordova Issue Type: Bug Reporter: Suraj Pindoria Assignee: Suraj Pindoria -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7338) [WP8] XHRHelper doesn't resolve request, app crash throwing: 'first chance exception of type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll'
Martin Gonzalez created CB-7338: --- Summary: [WP8] XHRHelper doesn't resolve request, app crash throwing: 'first chance exception of type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll' Key: CB-7338 URL: https://issues.apache.org/jira/browse/CB-7338 Project: Apache Cordova Issue Type: Bug Components: WP8 Affects Versions: 3.5.0 Reporter: Martin Gonzalez Assignee: Martin Gonzalez Fix For: 3.6.0 The XHRHelper class for Windows Phone 8 it doesn't resolve some XHR requests, at some point of the process it when it tries to load the URI to get the resource it doesn't resolve it. In addition to that, when it doesn't resolve the path it starts to throw exceptions: 'A first chance exception of type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll', per each XHR request pointing out to lines where 'Browser.InvokeScript'. That exception should be handled to throw information about a resource that it was not found, instead of crash the application. Some of this XHR requests where handled by requireJS & text plugin -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7338) [WP8] XHRHelper doesn't resolve request, app crash throwing: 'first chance exception of type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll'
[ https://issues.apache.org/jira/browse/CB-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102831#comment-14102831 ] ASF GitHub Bot commented on CB-7338: GitHub user martincgg opened a pull request: https://github.com/apache/cordova-wp8/pull/50 [CB-7338]Remove unwanted slashes in URL, and handle Exceptions when a resource is not found The URL result of a XHR request, at times contains some unwanted extra slashes, like: 'x-wmapp0: /www or //www'. that URL starting with those slashes, is not well processed by the URI class, so it's required remove them when the 'basePath' is obtained. Added, regExp to the js script code to remove any > ':/, ://, :///' , any slash after 'x-wmapp0:', in that way the URI class it will be successfully resolved and provide the file requested. Removing unwanted slashes after x-wmapp0 from the basePath, URI cannot process x-wmapp0: /www or //www. Also added two try-catch statements, over the 'Browser.InvokeScript' statements, if those are not present it throws: 'A first chance exception of type 'System.OutOfMemoryException' occurred in Microsoft.Phone.Interop.ni.dll', stopping the application. The try-catch statement it would throw this trace when a requested resource is not available, found or not well resolved by the URI class: ERROR: Exception in HandleCommand: System.OutOfMemoryException: Insufficient memory to continue the execution of the program. at Microsoft.Phone.Controls.NativeMethods.ValidateHResult(Int32 hr) at Microsoft.Phone.Controls.WebBrowserInterop.InvokeScript(String scriptName, String[] args) at Microsoft.Phone.Controls.WebBrowser.InvokeScript(String scriptName, String[] args) at WPCordovaClassLib.CordovaLib.XHRHelper.HandleCommand(String commandStr) You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-wp8 CB-7338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit 8829719bbbca1e92670f4576f7baa5e6e4701b9a Author: Martin Gonzalez Date: 2014-08-19T18:15:43Z Remove unwanted slashes and handle Exceptions > [WP8] XHRHelper doesn't resolve request, app crash throwing: 'first chance > exception of type 'System.OutOfMemoryException' occurred in > Microsoft.Phone.Interop.ni.dll' > -- > > Key: CB-7338 > URL: https://issues.apache.org/jira/browse/CB-7338 > Project: Apache Cordova > Issue Type: Bug > Components: WP8 >Affects Versions: 3.5.0 >Reporter: Martin Gonzalez >Assignee: Martin Gonzalez > Labels: WP8, WP8.1, XHR, XHRHelper > Fix For: 3.6.0 > > > The XHRHelper class for Windows Phone 8 it doesn't resolve some XHR requests, > at some point of the process it when it tries to load the URI to get the > resource it doesn't resolve it. > In addition to that, when it doesn't resolve the path it starts to throw > exceptions: 'A first chance exception of type 'System.OutOfMemoryException' > occurred in Microsoft.Phone.Interop.ni.dll', per each XHR request pointing > out to lines where 'Browser.InvokeScript'. > That exception should be handled to throw information about a resource that > it was not found, instead of crash the application. > Some of this XHR requests where handled by requireJS & text plugin -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7336) cordova platform add blackberry10 is broken
[
https://issues.apache.org/jira/browse/CB-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102936#comment-14102936
]
ASF GitHub Bot commented on CB-7336:
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/75#issuecomment-52706725
Running npm install inside the platforms might result in some unexpected
things. For example in iOS, the node modules dir is bundles under bin/ rather
as a sibling of package.json (no idea why, and how/if they will interact).
Should we just bundle node_modules with the blackberry npm package?
Bundling node_modules with an npm package is not an uncommon practice. Also
check npm's bundledDependencies prop for package.json.
While we are here: is there a good reason for keeping the blackberry10 name
rather than blackberry? We could leave blackberry10 as an alias translated to
blackberry by the cli on an early stage (like win variants are now) for
backwards compatibility. Less complexity to deal with later.
> cordova platform add blackberry10 is broken
> ---
>
> Key: CB-7336
> URL: https://issues.apache.org/jira/browse/CB-7336
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry, CLI
>Affects Versions: 3.6.0
>Reporter: Josh Soref
>Priority: Blocker
>
> {quote}
> $ ~/Cordova/cordova-cli/bin/cordova platform add blackberry10
> npm http GET https://registry.npmjs.org/cordova-blackberry10/3.5.0
> npm http 404 https://registry.npmjs.org/cordova-blackberry10/3.5.0
> Unable to fetch platform blackberry10: Error: 404 Not Found:
> cordova-blackberry10
> {quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7278) Allow plugin modules to be .json files
[ https://issues.apache.org/jira/browse/CB-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103230#comment-14103230 ] ASF GitHub Bot commented on CB-7278: Github user joseph-onsip commented on the pull request: https://github.com/apache/cordova-lib/pull/71#issuecomment-52725036 Cheers Jesse! I'll be sure to submit a CLA if I contribute larger changes. > Allow plugin modules to be .json files > -- > > Key: CB-7278 > URL: https://issues.apache.org/jira/browse/CB-7278 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Affects Versions: 3.5.0 >Reporter: Joseph Frazier >Priority: Trivial > Labels: json, module, plugin, require > Original Estimate: 0h > Remaining Estimate: 0h > > [Node.js modules can be .json > files|https://github.com/joyent/node/commit/588d885e81dec667920383ac7246daceeb7f99fd], > in which case module.exports is simply the parsed object. Cordova modules > should also have this ability, so that modular plugins don't have to be > bundled before Cordova prepares them. > I've submitted a pull request for this on github: > https://github.com/apache/cordova-lib/pull/71 -- This message was sent by Atlassian JIRA (v6.2#6252)
