[jira] [Updated] (CB-8531) Windows XP and Windows native desktop apps support
[ https://issues.apache.org/jira/browse/CB-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimmy updated CB-8531: --- Priority: Major (was: Critical) > Windows XP and Windows native desktop apps support > -- > > Key: CB-8531 > URL: https://issues.apache.org/jira/browse/CB-8531 > Project: Apache Cordova > Issue Type: New Feature > Components: Windows > Environment: Native Windows Desktop apps >Reporter: Shimmy > Original Estimate: 1,008h > Remaining Estimate: 1,008h > > Hi, > Currently Apache Cordova compiles to Windows Store apps. > Please implement support for Windows Desktop native apps, to work on all > platforms, from XP and on. > There is [this|https://github.com/otcshare/cordova-win7] project going on > too, although not including XP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8531) Windows XP and Windows native desktop apps support
[ https://issues.apache.org/jira/browse/CB-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimmy updated CB-8531: --- Description: Hi, Currently Apache Cordova compiles to Windows Store apps. Please implement support for Windows Desktop native apps, to work on all platforms, from XP and on. There is [this|https://github.com/otcshare/cordova-win7] project going on too, although not including XP. was: Hi, Currently Apache Cordova compiles to Windows Store apps. Please implement support for Windows Desktop native apps, to work on all platforms, from XP and on. There is [this](https://github.com/otcshare/cordova-win7) project going on too. > Windows XP and Windows native desktop apps support > -- > > Key: CB-8531 > URL: https://issues.apache.org/jira/browse/CB-8531 > Project: Apache Cordova > Issue Type: New Feature > Components: Windows > Environment: Native Windows Desktop apps >Reporter: Shimmy >Priority: Critical > Original Estimate: 1,008h > Remaining Estimate: 1,008h > > Hi, > Currently Apache Cordova compiles to Windows Store apps. > Please implement support for Windows Desktop native apps, to work on all > platforms, from XP and on. > There is [this|https://github.com/otcshare/cordova-win7] project going on > too, although not including XP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8531) Windows XP and Windows native desktop apps support
[ https://issues.apache.org/jira/browse/CB-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimmy updated CB-8531: --- Description: Hi, Currently Apache Cordova compiles to Windows Store apps. Please implement support for Windows Desktop native apps, to work on all platforms, from XP and on. There is [this](https://github.com/otcshare/cordova-win7) project going on too. was: Hi, Currently Apache Cordova compiles to Windows Store apps. Please implement support for Windows Desktop native apps, to work on all platforms, from XP and on. > Windows XP and Windows native desktop apps support > -- > > Key: CB-8531 > URL: https://issues.apache.org/jira/browse/CB-8531 > Project: Apache Cordova > Issue Type: New Feature > Components: Windows > Environment: Native Windows Desktop apps >Reporter: Shimmy >Priority: Critical > Original Estimate: 1,008h > Remaining Estimate: 1,008h > > Hi, > Currently Apache Cordova compiles to Windows Store apps. > Please implement support for Windows Desktop native apps, to work on all > platforms, from XP and on. > There is [this](https://github.com/otcshare/cordova-win7) project going on > too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8531) Please target Windows XP as well
Shimmy created CB-8531: -- Summary: Please target Windows XP as well Key: CB-8531 URL: https://issues.apache.org/jira/browse/CB-8531 Project: Apache Cordova Issue Type: New Feature Components: Windows Environment: Native Windows Desktop apps Reporter: Shimmy Priority: Critical Hi, Currently Apache Cordova compiles to Windows Store apps. Please implement support for Windows Desktop native apps, to work on all platforms, from XP and on. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8531) Windows XP and Windows native desktop apps support
[ https://issues.apache.org/jira/browse/CB-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimmy updated CB-8531: --- Summary: Windows XP and Windows native desktop apps support (was: Please target Windows XP as well) > Windows XP and Windows native desktop apps support > -- > > Key: CB-8531 > URL: https://issues.apache.org/jira/browse/CB-8531 > Project: Apache Cordova > Issue Type: New Feature > Components: Windows > Environment: Native Windows Desktop apps >Reporter: Shimmy >Priority: Critical > Original Estimate: 1,008h > Remaining Estimate: 1,008h > > Hi, > Currently Apache Cordova compiles to Windows Store apps. > Please implement support for Windows Desktop native apps, to work on all > platforms, from XP and on. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334470#comment-14334470
]
ASF GitHub Bot commented on CB-8499:
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25230972
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions from
platforms installed on the filesystem...
+// ...Note that in this case, we won't be able to know what
source(folder, git-url) the platform came from, we'll just use versions
+return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = require(platformsJsonFile);
--- End diff --
NodeJS actually doing JSON parsing when JSON file is required. See
http://nodejs.org/api/modules.html#modules_file_modules and
http://nodejs.org/api/modules.html#modules_all_together
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8530) New Whitelisting Broken on Android
[
https://issues.apache.org/jira/browse/CB-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-8530:
---
Attachment: cb-8530-repro.zip
Minimal app that exhibits the behaviour.
> New Whitelisting Broken on Android
> --
>
> Key: CB-8530
> URL: https://issues.apache.org/jira/browse/CB-8530
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, mobile-spec, Plugins
>Affects Versions: Master
> Environment: Android on Windows broken. Android on OS X unverified.
>Reporter: Dmitry Blotsky
>Priority: Critical
> Labels: android
> Attachments: cb-8530-repro.zip, whitelist-error.png
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> With or without the mobilespec whitelist app, whitelisting does not work on
> Android on Windows (OS X not yet tested). An expected plugin object is
> {{null}} in {{entryMap}}, when it should not be.
> Screenshot and minimal app to reproduce attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8530) New Whitelisting Broken on Android
[
https://issues.apache.org/jira/browse/CB-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-8530:
---
Attachment: whitelist-error.png
> New Whitelisting Broken on Android
> --
>
> Key: CB-8530
> URL: https://issues.apache.org/jira/browse/CB-8530
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, mobile-spec, Plugins
>Affects Versions: Master
> Environment: Android on Windows broken. Android on OS X unverified.
>Reporter: Dmitry Blotsky
>Priority: Critical
> Labels: android
> Attachments: whitelist-error.png
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> With or without the mobilespec whitelist app, whitelisting does not work on
> Android on Windows (OS X not yet tested). An expected plugin object is
> {{null}} in {{entryMap}}, when it should not be.
> Screenshot and minimal app to reproduce attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8530) New Whitelisting Broken on Android
[
https://issues.apache.org/jira/browse/CB-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Blotsky updated CB-8530:
---
Description:
With or without the mobilespec whitelist app, whitelisting does not work on
Android on Windows (OS X not yet tested). An expected plugin object is {{null}}
in {{entryMap}}, when it should not be.
Screenshot and minimal app to reproduce attached.
was:
With or without the mobilespec whitelist app, whitelisting does not work on
Android on Windows (OS X not yet tested). An expected plugin object is {null}in
{entryMap}, when it should not be.
Screenshot and minimal app to reproduce attached.
> New Whitelisting Broken on Android
> --
>
> Key: CB-8530
> URL: https://issues.apache.org/jira/browse/CB-8530
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, mobile-spec, Plugins
>Affects Versions: Master
> Environment: Android on Windows broken. Android on OS X unverified.
>Reporter: Dmitry Blotsky
>Priority: Critical
> Labels: android
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> With or without the mobilespec whitelist app, whitelisting does not work on
> Android on Windows (OS X not yet tested). An expected plugin object is
> {{null}} in {{entryMap}}, when it should not be.
> Screenshot and minimal app to reproduce attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8530) New Whitelisting Broken on Android
Dmitry Blotsky created CB-8530:
--
Summary: New Whitelisting Broken on Android
Key: CB-8530
URL: https://issues.apache.org/jira/browse/CB-8530
Project: Apache Cordova
Issue Type: Bug
Components: Android, mobile-spec, Plugins
Affects Versions: Master
Environment: Android on Windows broken. Android on OS X unverified.
Reporter: Dmitry Blotsky
Priority: Critical
With or without the mobilespec whitelist app, whitelisting does not work on
Android on Windows (OS X not yet tested). An expected plugin object is {null}in
{entryMap}, when it should not be.
Screenshot and minimal app to reproduce attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN updated CB-8482: - Component/s: CordovaLib > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > Fix For: Master > > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN resolved CB-8482. -- Resolution: Fixed PR merged, thanks. > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > Fix For: Master > > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gorkem ERCAN updated CB-8482: - Fix Version/s: Master > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > Fix For: Master > > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334312#comment-14334312 ] ASF subversion and git services commented on CB-8482: - Commit 1229ce6cca0195ecefbf818c67841871d8eba653 in cordova-lib's branch refs/heads/master from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1229ce6 ] CB-8482: Update engine syntax within config.xml > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334313#comment-14334313 ] ASF subversion and git services commented on CB-8482: - Commit 32863b58d0ec6beae74eee83570929c3a768ba05 in cordova-lib's branch refs/heads/master from [~omefire] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=32863b5 ] CB-8482 rename: platformId -> platformName > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334314#comment-14334314 ] ASF GitHub Bot commented on CB-8482: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/168 > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334301#comment-14334301
]
ASF GitHub Bot commented on CB-8499:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224883
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions from
platforms installed on the filesystem...
+// ...Note that in this case, we won't be able to know what
source(folder, git-url) the platform came from, we'll just use versions
+return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = require(platformsJsonFile);
+var platformVersions = [];
+
+platformVersions = Object.keys(platformData).map(function(p){
+return {platform: p, version: platformData[p]};
+});
+
+return Q(platformVersions);
+}
+
+// Returns a promise
+function getPlatVersionsFromFileSystem(projectRoot){
+var platformVersions = [];
+var platforms_on_fs = cordova_util.listPlatforms(projectRoot);
+platforms_on_fs.forEach(function(platform){
+var script = path.join(projectRoot, 'platforms', platform,
'cordova', 'version');
+
+// Use version script to retrieve installed version of the platform
+var version = shelljs.exec(script).output;
+
+// clean the version we get back from the script
+// This is necessary because the version script uses console.log
to pass back
+// the version. Using console.log ends up adding additional line
breaks/newlines to the value returned.
+// ToDO: version scripts should be refactored to not use
console.log()
+var versionCleaned = version.replace(/\r?\n|\r/g, '');
+platformVersions.push({platform: platform, version:
versionCleaned});
+});
+
+return Q(platformVersions);
+}
+
+// Saves platform@version into platforms.json
+function save(projectRoot, platform, version) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformJsonFile = path.join(platformsDir, 'platforms.json');
+if(!fs.existsSync(platformJsonFile)){
+fs.writeFileSync(platformJsonFile, JSON.stringify({}, null, 4),
'utf-8');
+}
+
+var data = require(platformJsonFile);
--- End diff --
It's generally not very flexible to read and write a file in the same
method. Better to have clients explicitly read, explicitly mutate (in memory),
then explicitly write.
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'co
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334298#comment-14334298
]
ASF GitHub Bot commented on CB-8499:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224748
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions from
platforms installed on the filesystem...
+// ...Note that in this case, we won't be able to know what
source(folder, git-url) the platform came from, we'll just use versions
+return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = require(platformsJsonFile);
+var platformVersions = [];
+
+platformVersions = Object.keys(platformData).map(function(p){
+return {platform: p, version: platformData[p]};
+});
+
+return Q(platformVersions);
+}
+
+// Returns a promise
+function getPlatVersionsFromFileSystem(projectRoot){
+var platformVersions = [];
+var platforms_on_fs = cordova_util.listPlatforms(projectRoot);
+platforms_on_fs.forEach(function(platform){
+var script = path.join(projectRoot, 'platforms', platform,
'cordova', 'version');
+
+// Use version script to retrieve installed version of the platform
+var version = shelljs.exec(script).output;
+
+// clean the version we get back from the script
+// This is necessary because the version script uses console.log
to pass back
+// the version. Using console.log ends up adding additional line
breaks/newlines to the value returned.
+// ToDO: version scripts should be refactored to not use
console.log()
+var versionCleaned = version.replace(/\r?\n|\r/g, '');
+platformVersions.push({platform: platform, version:
versionCleaned});
+});
+
+return Q(platformVersions);
+}
+
+// Saves platform@version into platforms.json
+function save(projectRoot, platform, version) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformJsonFile = path.join(platformsDir, 'platforms.json');
+if(!fs.existsSync(platformJsonFile)){
+fs.writeFileSync(platformJsonFile, JSON.stringify({}, null, 4),
'utf-8');
--- End diff --
unless I'm missing something, you overwrite this file a few lines below. No
need to write an empty file here.
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334295#comment-14334295
]
ASF GitHub Bot commented on CB-8499:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25224693
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions from
platforms installed on the filesystem...
+// ...Note that in this case, we won't be able to know what
source(folder, git-url) the platform came from, we'll just use versions
+return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = require(platformsJsonFile);
+var platformVersions = [];
+
+platformVersions = Object.keys(platformData).map(function(p){
+return {platform: p, version: platformData[p]};
+});
+
+return Q(platformVersions);
+}
+
+// Returns a promise
+function getPlatVersionsFromFileSystem(projectRoot){
+var platformVersions = [];
+var platforms_on_fs = cordova_util.listPlatforms(projectRoot);
+platforms_on_fs.forEach(function(platform){
+var script = path.join(projectRoot, 'platforms', platform,
'cordova', 'version');
+
+// Use version script to retrieve installed version of the platform
+var version = shelljs.exec(script).output;
--- End diff --
`shelljs.exec` is known to have poor performance and lead to EMFILE
exceptions. Please use child_process.exec() instead
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8529) Publish old versions of core plugins to npm
Steve Gill created CB-8529: -- Summary: Publish old versions of core plugins to npm Key: CB-8529 URL: https://issues.apache.org/jira/browse/CB-8529 Project: Apache Cordova Issue Type: Bug Reporter: Steve Gill Assignee: Steve Gill -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334146#comment-14334146 ] ASF GitHub Bot commented on CB-8499: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75670437 I think this PR is ready to be merged in. > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334141#comment-14334141 ] ASF GitHub Bot commented on CB-8482: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75669608 @gorkem, I did find some things that needed to be updated in restore-util.js. those have been taken care of. > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334077#comment-14334077 ] ASF GitHub Bot commented on CB-8482: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75660844 @gorkem, cool. working on a rebase + update to new dependent modules ... > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8528) Update test framework plugin to use Jasmine 2.2.0
[ https://issues.apache.org/jira/browse/CB-8528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334061#comment-14334061 ] ASF GitHub Bot commented on CB-8528: GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/11 CB-8528 Update test framework plugin to use Jasmine 2.2.0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marcuspridham/cordova-plugin-test-framework CB-8528 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 2bddcfcd77551b1c1c7372094e05d55dadc00cbe Author: Marcus Pridham Date: 2015-02-23T19:13:50Z CB-8528 Update test framework plugin to use Jasmine 2.2.0. > Update test framework plugin to use Jasmine 2.2.0 > - > > Key: CB-8528 > URL: https://issues.apache.org/jira/browse/CB-8528 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin TestFramework >Reporter: Marcus Pridham >Priority: Minor > > The cordova-plugin-test-framework is currently using Jasmine 2.0.0. In > Jasmine 2.1.x new features such as focused tests and beforeAll/afterAll were > added. > http://pivotallabs.com/new-key-features-jasmine-2-1/ > It would be nice to have these new features available when writing Cordova > plugin tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8482) Update engine syntax within config.xml
[ https://issues.apache.org/jira/browse/CB-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334055#comment-14334055 ] ASF GitHub Bot commented on CB-8482: Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75658796 @omefire this looks OK and would like to get it in. The dependencies have changed though save.js and restore.js are gone. I could not quickly spot anything on platform.js other then the current one. Can you do a rebase and double check as well. > Update engine syntax within config.xml > -- > > Key: CB-8482 > URL: https://issues.apache.org/jira/browse/CB-8482 > Project: Apache Cordova > Issue Type: Bug >Reporter: Omar Mefire >Assignee: Omar Mefire >Priority: Minor > > Instead of the engine syntax being : version="3.7.0-dev" />, > we will switch to : -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8528) Update test framework plugin to use Jasmine 2.2.0
Marcus Pridham created CB-8528: -- Summary: Update test framework plugin to use Jasmine 2.2.0 Key: CB-8528 URL: https://issues.apache.org/jira/browse/CB-8528 Project: Apache Cordova Issue Type: Improvement Components: Plugin TestFramework Reporter: Marcus Pridham Priority: Minor The cordova-plugin-test-framework is currently using Jasmine 2.0.0. In Jasmine 2.1.x new features such as focused tests and beforeAll/afterAll were added. http://pivotallabs.com/new-key-features-jasmine-2-1/ It would be nice to have these new features available when writing Cordova plugin tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5890) Media won't play local file on iOS
[
https://issues.apache.org/jira/browse/CB-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333797#comment-14333797
]
Chris Emerson commented on CB-5890:
---
FWIW I also got this once (error very similar) when the file (URL) path was
pointing to a non-existent mp3.
> Media won't play local file on iOS
> --
>
> Key: CB-5890
> URL: https://issues.apache.org/jira/browse/CB-5890
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
>Affects Versions: 3.3.0
> Environment: iOS
>Reporter: John M. Wargo
>
> I have an application that will play a media file on Android, but not on iOS.
> When I try to play the file, the console indicates that it can find the file,
> but fails on opening it:
> Failed to initialize AVAudioPlayer
> Here's some console entries:
> 2014-01-24 08:49:51.374 Ex141[386:60b] Entering doPlay
> 2014-01-24 08:49:51.376 Ex141[386:60b] Found resource
> '/var/mobile/Applications/C557863E-BB8C-4384-8188-9C36B5B603C4/Ex141.app/www/sample.mp3'
> in the web folder.
> 2014-01-24 08:49:51.391 Ex141[386:60b] Failed to initialize AVAudioPlayer:
> The operation couldn’t be completed. (OSStatus error 1685348671.)
> 2014-01-24 08:49:51.394 Ex141[386:60b] THREAD WARNING: ['Media'] took
> '18.647949' ms. Plugin should use a background thread.
> 2014-01-24 08:49:51.396 Ex141[386:60b] Leaving doPlay
> 2014-01-24 08:49:51.397 Ex141[386:60b] ERROR: Entering mediaError
> 2014-01-24 08:49:51.398 Ex141[386:60b] ERROR: {"message":"","code":4}
> Notice that the message string is blank.
> This is my code:
> theFile = 'sample.mp3';
> theMedia = new Media(theFile, mediaSuccess, mediaError, mediaStatus);
> theMedia.play();
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[ https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333753#comment-14333753 ] ASF GitHub Bot commented on CB-8499: Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/170#issuecomment-75623519 @gorkem, yes platforms.json is a new file in the platforms directory. think of it as the equivalent of the .fetch.json file we have for plugins. > 'cordova platform save' : should save all installed platforms to config.xml > --- > > Key: CB-8499 > URL: https://issues.apache.org/jira/browse/CB-8499 > Project: Apache Cordova > Issue Type: New Feature >Reporter: Omar Mefire >Assignee: Omar Mefire > > In addition to using 'cordova platform add android --save' to both add and > save a platform to config.xml, It would be useful to have a way to 'mass > save' already installed platforms to config.xml. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333619#comment-14333619
]
ASF GitHub Bot commented on CB-7827:
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187454
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
Thanks for the review. I'll add this.
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333618#comment-14333618
]
ASF GitHub Bot commented on CB-7827:
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25187402
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
--- End diff --
Yup, typo there.
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333615#comment-14333615
]
ASF GitHub Bot commented on CB-7827:
Github user cjpearson commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25187348
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs(process.argv);
if (args['--help'] || args._.length === 0) {
-console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + '
[] [--link]');
+console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + '
[] [--link]');
--- End diff --
I wasn't sure of the best way to make both template_path and activity_name
optional. I explored using --activity-name using nopt, which
cordova-ios uses for arguments.
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333604#comment-14333604
]
ASF GitHub Bot commented on CB-7827:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25186284
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
+ args.push(activityName);
--- End diff --
We need this to continue to work for older versions of cordova-android. You
should add this arg only if:
semver.gte(platDetails.version, '4.0.0-dev')
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333599#comment-14333599
]
ASF GitHub Bot commented on CB-7827:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/160#discussion_r25186024
--- Diff: bin/create ---
@@ -23,14 +23,15 @@ var create = require('./lib/create');
var args = require('./lib/simpleargs').getArgs(process.argv);
if (args['--help'] || args._.length === 0) {
-console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + '
[] [--link]');
+console.log('Usage: ' + path.relative(process.cwd(),
path.join(__dirname, 'create')) + '
[] [--link]');
--- End diff --
Shifting the `` arg will break scripts that currently use
it. Maybe use `--activity-name=` instead?
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7827) manifest/application/activity[android:name] always CordovaApp
[
https://issues.apache.org/jira/browse/CB-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333595#comment-14333595
]
ASF GitHub Bot commented on CB-7827:
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/171#discussion_r25185875
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg,
template_dir, opts) {
if (/android|ios/.exec(platDetails.platform) &&
semver.gt(platDetails.version, '3.3.0')) {
args.push('--cli');
}
-
+
var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) :
cfg.name();
args.push(output, pkg, name);
+
+var activityName = cfg.android_activityName();
+if (activityName && platDetails.platform === 'android') {
+activityName = activityName.replace(/W/g, '');
--- End diff --
why not allow any Ws? did you mean `\W`?
> manifest/application/activity[android:name] always CordovaApp
> -
>
> Key: CB-7827
> URL: https://issues.apache.org/jira/browse/CB-7827
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
>Affects Versions: 4.0.0
> Environment: Windows 8.1 x64, NodeJs 0.10.32
>Reporter: Sergey
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for "activities" field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333581#comment-14333581
]
Axel Nennker commented on CB-8448:
--
New PR based on today's apache/cordova-lib
https://github.com/apache/cordova-lib/pull/172
> Add support for "activities" field in FirefoxOS manifest.webapp
> ---
>
> Key: CB-8448
> URL: https://issues.apache.org/jira/browse/CB-8448
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Reporter: Axel Nennker
>
> FirefoxOS manifest files allow a richer set of fields than currently
> supported by firefoxos_parser.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
> E.g.: "activities"
> https://developer.mozilla.org/de/Apps/Manifest#activities
> This is needed to e.g. open files of a defined mime type.
> Extend syntax of plugin.xml like e.g.:
>
>
>
> disposition="inline">
>
>
>
>
>
> This results e.g. in
> "activities": {
> "open": {
> "href": "./import.html",
> "disposition": "inline",
> "filters": {
> "type": "application/wallet-import"
> }
> }
> },
> Lines needed for this in firefoxos_parser.js:
> var activitiesNodes = config.doc.findall('activities');
> activitiesNodes.forEach(function(activitiesNode) {
> var activityNodes = activitiesNode.findall('activity');
> if (activityNodes.length) {
> var activities = {};
> activityNodes.forEach(function (node) {
> var name = node.attrib.name;
> var href = node.attrib.href;
> if (name && href) {
> events.emit('verbose', 'activity name='+name+'
> href='+href);
> activities[name] = {};
> activities[name].href = href;
> var disposition = node.attrib.disposition;
> if (disposition) {
> activities[name].disposition = disposition;
> }
> activities[name].filters = {};
> var filterNodes = node.findall('filter');
> filterNodes.forEach(function(filter) {
> var type = filter.attrib.type;
> if (type) {
> activities[name].filters.type = type;
> }
> });
> } else {
> events.emit('warn', 'activity without name='+name+'or
> href='+href);
> }
> });
> manifest.activities = activities;
> }
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for "activities" field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333582#comment-14333582
]
Axel Nennker commented on CB-8448:
--
New PR based on today's apache/cordova-lib
https://github.com/apache/cordova-lib/pull/172
> Add support for "activities" field in FirefoxOS manifest.webapp
> ---
>
> Key: CB-8448
> URL: https://issues.apache.org/jira/browse/CB-8448
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Reporter: Axel Nennker
>
> FirefoxOS manifest files allow a richer set of fields than currently
> supported by firefoxos_parser.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
> E.g.: "activities"
> https://developer.mozilla.org/de/Apps/Manifest#activities
> This is needed to e.g. open files of a defined mime type.
> Extend syntax of plugin.xml like e.g.:
>
>
>
> disposition="inline">
>
>
>
>
>
> This results e.g. in
> "activities": {
> "open": {
> "href": "./import.html",
> "disposition": "inline",
> "filters": {
> "type": "application/wallet-import"
> }
> }
> },
> Lines needed for this in firefoxos_parser.js:
> var activitiesNodes = config.doc.findall('activities');
> activitiesNodes.forEach(function(activitiesNode) {
> var activityNodes = activitiesNode.findall('activity');
> if (activityNodes.length) {
> var activities = {};
> activityNodes.forEach(function (node) {
> var name = node.attrib.name;
> var href = node.attrib.href;
> if (name && href) {
> events.emit('verbose', 'activity name='+name+'
> href='+href);
> activities[name] = {};
> activities[name].href = href;
> var disposition = node.attrib.disposition;
> if (disposition) {
> activities[name].disposition = disposition;
> }
> activities[name].filters = {};
> var filterNodes = node.findall('filter');
> filterNodes.forEach(function(filter) {
> var type = filter.attrib.type;
> if (type) {
> activities[name].filters.type = type;
> }
> });
> } else {
> events.emit('warn', 'activity without name='+name+'or
> href='+href);
> }
> });
> manifest.activities = activities;
> }
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for "activities" field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333578#comment-14333578
]
ASF GitHub Bot commented on CB-8448:
GitHub user AxelNennker opened a pull request:
https://github.com/apache/cordova-lib/pull/172
CB-8448 add support for activities
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AxelNennker/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
commit 7371adbd9fcb84402d69ea552242a3a44d847353
Author: Axel Nennker
Date: 2015-02-23T17:56:42Z
CB-8448 add support for activities
> Add support for "activities" field in FirefoxOS manifest.webapp
> ---
>
> Key: CB-8448
> URL: https://issues.apache.org/jira/browse/CB-8448
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
>Reporter: Axel Nennker
>
> FirefoxOS manifest files allow a richer set of fields than currently
> supported by firefoxos_parser.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
> E.g.: "activities"
> https://developer.mozilla.org/de/Apps/Manifest#activities
> This is needed to e.g. open files of a defined mime type.
> Extend syntax of plugin.xml like e.g.:
>
>
>
> disposition="inline">
>
>
>
>
>
> This results e.g. in
> "activities": {
> "open": {
> "href": "./import.html",
> "disposition": "inline",
> "filters": {
> "type": "application/wallet-import"
> }
> }
> },
> Lines needed for this in firefoxos_parser.js:
> var activitiesNodes = config.doc.findall('activities');
> activitiesNodes.forEach(function(activitiesNode) {
> var activityNodes = activitiesNode.findall('activity');
> if (activityNodes.length) {
> var activities = {};
> activityNodes.forEach(function (node) {
> var name = node.attrib.name;
> var href = node.attrib.href;
> if (name && href) {
> events.emit('verbose', 'activity name='+name+'
> href='+href);
> activities[name] = {};
> activities[name].href = href;
> var disposition = node.attrib.disposition;
> if (disposition) {
> activities[name].disposition = disposition;
> }
> activities[name].filters = {};
> var filterNodes = node.findall('filter');
> filterNodes.forEach(function(filter) {
> var type = filter.attrib.type;
> if (type) {
> activities[name].filters.type = type;
> }
> });
> } else {
> events.emit('warn', 'activity without name='+name+'or
> href='+href);
> }
> });
> manifest.activities = activities;
> }
> });
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8487) Not latest source in the CrowdIn
[ https://issues.apache.org/jira/browse/CB-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333570#comment-14333570 ] Victor Adrian Sosa Herrera commented on CB-8487: Found the problem in my setup, it was completely messed :S I managed to fix it and now I'm in the middle of the process of reconciling the English docs with the other languages. [~akurdyumov]: I haven't reconciled Russian with the latest version (as you pointed out here). Do you want me to reconcile it, which means it will probably override your changes, or do you want to do it your self? Just let me know, I'll hold Russian docs until you respond > Not latest source in the CrowdIn > > > Key: CB-8487 > URL: https://issues.apache.org/jira/browse/CB-8487 > Project: Apache Cordova > Issue Type: Bug > Components: Translation >Reporter: Andrey Kurdyumov >Assignee: Victor Adrian Sosa Herrera > > Compare > http://cordova.apache.org/docs/en/edge/guide_platforms_wp8_upgrade.md.html > and > http://cordova.apache.org/docs/ru/edge/guide_platforms_wp8_upgrade.md.html > On the main website and on the CrowdIn. The part "Upgrading 3.6.0 Projects to > 4.0.0" is missing from website and from CrowdIn. > This is indicates that not latest source file in the CrowdIn for that page. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8499) 'cordova platform save' : should save all installed platforms to config.xml
[
https://issues.apache.org/jira/browse/CB-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333565#comment-14333565
]
ASF GitHub Bot commented on CB-8499:
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25184230
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+
+var path = require('path'),
+cordova_util = require('./util'),
+fs = require('fs'),
+Q= require('q'),
+shelljs = require('shelljs');
+
+
+// Retrieves the platforms and their versions from the platforms.json file
+// Returns an array of {platform: platform, version: version} ...
+// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
+function getVersions(projectRoot) {
+var platformsDir = path.join(projectRoot, 'platforms');
+var platformsJsonFile = path.join(platformsDir, 'platforms.json');
+
+// If the platforms.json file doesn't exist, retrieve versions from
platforms installed on the filesystem...
+// ...Note that in this case, we won't be able to know what
source(folder, git-url) the platform came from, we'll just use versions
+return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
+return getPlatVersionsFromFileSystem(projectRoot);
+});
+}
+
+// Returns a promise
+function getPlatVersionsFromFile(platformsJsonFile){
+var platformData = require(platformsJsonFile);
--- End diff --
Why do a require to a data file? JSON.parse is better as it prevents
arbitrary code from being loaded.
> 'cordova platform save' : should save all installed platforms to config.xml
> ---
>
> Key: CB-8499
> URL: https://issues.apache.org/jira/browse/CB-8499
> Project: Apache Cordova
> Issue Type: New Feature
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>
> In addition to using 'cordova platform add android --save' to both add and
> save a platform to config.xml, It would be useful to have a way to 'mass
> save' already installed platforms to config.xml.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7090) [iOS 8] Integrate wkwebview branch into master branch
[ https://issues.apache.org/jira/browse/CB-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333502#comment-14333502 ] Lyle Pratt commented on CB-7090: I'm just curious on the general status of this. Apple has fixed the bug, but it has still not been released right? Is the Cordova team going to attempt to work around the bug with a local webserver or wait until Apple releases the bug? > [iOS 8] Integrate wkwebview branch into master branch > - > > Key: CB-7090 > URL: https://issues.apache.org/jira/browse/CB-7090 > Project: Apache Cordova > Issue Type: Sub-task > Components: iOS >Reporter: Shazron Abdullah > > https://git-wip-us.apache.org/repos/asf/cordova-ios.git branch "wkwebview" -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8527) Please add pgbomit functionality to the PhoneGap/Cordova CLI
Chris Emerson created CB-8527: - Summary: Please add pgbomit functionality to the PhoneGap/Cordova CLI Key: CB-8527 URL: https://issues.apache.org/jira/browse/CB-8527 Project: Apache Cordova Issue Type: Improvement Components: CLI Reporter: Chris Emerson Per the docs from PhoneGap Build here: http://phonegap.com/blog/2014/04/11/phonegap-build-adds-some-new-features/#pgbomit Please add something similar for CLI, non-PhoneGap Build users, to be able to exclude folders from a build w/out having to figure out/implement strange hooks in each project. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8524) Cordova-Windows Platform Release February 23, 2014
[ https://issues.apache.org/jira/browse/CB-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333212#comment-14333212 ] ASF subversion and git services commented on CB-8524: - Commit bf3815a4b8a1a496431edcbb8ad696b0374549d9 in cordova-windows's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=bf3815a ] CB-8524 updated RELEASENOTES > Cordova-Windows Platform Release February 23, 2014 > -- > > Key: CB-8524 > URL: https://issues.apache.org/jira/browse/CB-8524 > Project: Apache Cordova > Issue Type: Task >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8524) Cordova-Windows Platform Release February 23, 2014
[ https://issues.apache.org/jira/browse/CB-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333196#comment-14333196 ] ASF subversion and git services commented on CB-8524: - Commit d13e7ff25f7b419070e6aeb42246df26f935e184 in cordova-windows's branch refs/heads/3.8.x from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d13e7ff ] CB-8524 updated RELEASENOTES > Cordova-Windows Platform Release February 23, 2014 > -- > > Key: CB-8524 > URL: https://issues.apache.org/jira/browse/CB-8524 > Project: Apache Cordova > Issue Type: Task >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8526) cordova lib misssing
san created CB-8526: --- Summary: cordova lib misssing Key: CB-8526 URL: https://issues.apache.org/jira/browse/CB-8526 Project: Apache Cordova Issue Type: Bug Components: Android Environment: windows Reporter: san HI i have updated the project using cordova platform update android after this command lib folder inside cordovalib is missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8524) Cordova-Windows Platform Release February 23, 2014
[ https://issues.apache.org/jira/browse/CB-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333191#comment-14333191 ] ASF subversion and git services commented on CB-8524: - Commit 4536c84b8c33cb5eb451781550b5775327434b57 in cordova-windows's branch refs/heads/3.8.x from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=4536c84 ] CB-8524 updated RELEASENOTES > Cordova-Windows Platform Release February 23, 2014 > -- > > Key: CB-8524 > URL: https://issues.apache.org/jira/browse/CB-8524 > Project: Apache Cordova > Issue Type: Task >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8525) Fix audit-license-headers check on Windows
[ https://issues.apache.org/jira/browse/CB-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov resolved CB-8525. Resolution: Fixed > Fix audit-license-headers check on Windows > -- > > Key: CB-8525 > URL: https://issues.apache.org/jira/browse/CB-8525 > Project: Apache Cordova > Issue Type: Bug >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > The following files are failed: > MSBuildTools.js (missing header) > appveyor.yml (missing header) > RELEASENOTES.md (missing header) > CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle (binary, header is not > required) > CordovaApp.Windows80_0.0.1.0_anycpu_debug.appx (binary, header is not > required) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8525) Fix audit-license-headers check on Windows
[ https://issues.apache.org/jira/browse/CB-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333151#comment-14333151 ] ASF subversion and git services commented on CB-8525: - Commit 87bdf85ceeecc8eead1658d0860d156960f15cd7 in cordova-windows's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=87bdf85 ] CB-8525 Fix audit-license-headers check on Windows > Fix audit-license-headers check on Windows > -- > > Key: CB-8525 > URL: https://issues.apache.org/jira/browse/CB-8525 > Project: Apache Cordova > Issue Type: Bug >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > The following files are failed: > MSBuildTools.js (missing header) > appveyor.yml (missing header) > RELEASENOTES.md (missing header) > CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle (binary, header is not > required) > CordovaApp.Windows80_0.0.1.0_anycpu_debug.appx (binary, header is not > required) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8525) Fix audit-license-headers check on Windows
[ https://issues.apache.org/jira/browse/CB-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333148#comment-14333148 ] ASF subversion and git services commented on CB-8525: - Commit c5852e86470c461c40a8005f13b657145859c328 in cordova-coho's branch refs/heads/master from sgrebnov [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=c5852e8 ] CB-8525 Fix audit-license-headers check on Windows > Fix audit-license-headers check on Windows > -- > > Key: CB-8525 > URL: https://issues.apache.org/jira/browse/CB-8525 > Project: Apache Cordova > Issue Type: Bug >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > The following files are failed: > MSBuildTools.js (missing header) > appveyor.yml (missing header) > RELEASENOTES.md (missing header) > CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle (binary, header is not > required) > CordovaApp.Windows80_0.0.1.0_anycpu_debug.appx (binary, header is not > required) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8525) Fix audit-license-headers check on Windows
[ https://issues.apache.org/jira/browse/CB-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Grebnov reassigned CB-8525: -- Assignee: Sergey Grebnov > Fix audit-license-headers check on Windows > -- > > Key: CB-8525 > URL: https://issues.apache.org/jira/browse/CB-8525 > Project: Apache Cordova > Issue Type: Bug >Reporter: Sergey Grebnov >Assignee: Sergey Grebnov > > The following files are failed: > MSBuildTools.js (missing header) > appveyor.yml (missing header) > RELEASENOTES.md (missing header) > CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle (binary, header is not > required) > CordovaApp.Windows80_0.0.1.0_anycpu_debug.appx (binary, header is not > required) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8525) Fix audit-license-headers check on Windows
Sergey Grebnov created CB-8525: -- Summary: Fix audit-license-headers check on Windows Key: CB-8525 URL: https://issues.apache.org/jira/browse/CB-8525 Project: Apache Cordova Issue Type: Bug Reporter: Sergey Grebnov The following files are failed: MSBuildTools.js (missing header) appveyor.yml (missing header) RELEASENOTES.md (missing header) CordovaApp.Phone_0.0.1.0_AnyCPU_debug.appxbundle (binary, header is not required) CordovaApp.Windows80_0.0.1.0_anycpu_debug.appx (binary, header is not required) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8524) Cordova-Windows Platform Release February 23, 2014
Sergey Grebnov created CB-8524: -- Summary: Cordova-Windows Platform Release February 23, 2014 Key: CB-8524 URL: https://issues.apache.org/jira/browse/CB-8524 Project: Apache Cordova Issue Type: Task Reporter: Sergey Grebnov Assignee: Sergey Grebnov Following steps at https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
