[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270202#comment-15270202 ] ASF GitHub Bot commented on CB-7: - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/295#issuecomment-216759612 LGTM > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11174) cordova platformApi cache isn't dealing correctly with symlinked project dirs
[
https://issues.apache.org/jira/browse/CB-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Kotikov closed CB-11174.
-
Resolution: Fixed
> cordova platformApi cache isn't dealing correctly with symlinked project dirs
> -
>
> Key: CB-11174
> URL: https://issues.apache.org/jira/browse/CB-11174
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 6.1.1
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Labels: triaged
>
> When project dir is inside of symlinked directory (say {{/var}} on OS X),
> {{getPlatformApi}} method in cordova-lib doesn't resolve real path before
> dealing with cache and uses provided path as-is. This causes returning two
> separate instances of {{PlatformApi}} class when {{getPlatformApi}} is first
> called with symlinked path and then with real one, despite of the fact that
> both paths are pointing to the same project.
> In the real life this issue causes the following 'npm test' failures for
> cordova-lib on OS X, caused by mocking methods for one PlatformApi instance
> and using another one:
> {noformat}
> 1) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:175:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
>
> 2) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:179:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[ https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269906#comment-15269906 ] ASF GitHub Bot commented on CB-11198: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/303#issuecomment-216705549 :+1: > Skip checking android target installed > -- > > Key: CB-11198 > URL: https://issues.apache.org/jira/browse/CB-11198 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > Instead of checking this upfront - we're going to detect failure and show the > message later. > This saves a good 1 second on my Macbook pro. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269880#comment-15269880
]
ASF GitHub Bot commented on CB-11198:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61976209
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -203,6 +203,11 @@ GradleBuilder.prototype.build = function(opts) {
} else {
process.stdout.write(stdio.stdout);
}
+}).catch(function (error) {
+if (error.toString().indexOf('failed to find target with hash
string') >= 0) {
+return check_reqs.check_android_target(error);
--- End diff --
Would it be possible for check_android_target to actually find the target
and then swallow this error?
> Skip checking android target installed
> --
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269864#comment-15269864
]
ASF GitHub Bot commented on CB-11198:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975714
--- Diff: bin/lib/check_reqs.js ---
@@ -238,13 +236,13 @@ module.exports.getAbsoluteAndroidCmd = function () {
return cmd.replace(/(\s)/g, '\\$1');
};
-module.exports.check_android_target = function(valid_target) {
+module.exports.check_android_target = function(originalError) {
--- End diff --
I don't see where any value for originalError is ever passed in by a caller.
> Skip checking android target installed
> --
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269863#comment-15269863
]
ASF GitHub Bot commented on CB-11198:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r61975678
--- Diff: bin/lib/check_reqs.js ---
@@ -254,18 +252,22 @@ module.exports.check_android_target =
function(valid_target) {
}
var androidCmd = module.exports.getAbsoluteAndroidCmd();
-throw new CordovaError('Please install Android target: "' +
valid_target + '".\n\n' +
+var msg = 'Please install Android target: "' + valid_target +
'".\n\n' +
'Hint: Open the SDK manager by running: ' + androidCmd + '\n' +
'You will require:\n' +
'1. "SDK Platform" for ' + valid_target + '\n' +
'2. "Android SDK Platform-tools (latest)\n' +
-'3. "Android SDK Build-tools" (latest)');
+'3. "Android SDK Build-tools" (latest)'
--- End diff --
Missing semicolon.
> Skip checking android target installed
> --
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the
> message later.
> This saves a good 1 second on my Macbook pro.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269808#comment-15269808 ] ASF GitHub Bot commented on CB-9858: Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-216691951 Hey Everyone, I think the first implementation of this is ready to hit master behind the --fetch flag. It includes platform and plugin fetching + removing. Take a look @nikhilkh @purplecabbage @vladimir-kotikov Needs: apache/cordova-cli#239 and apache/cordova-plugman#87 I will add template fetching next. I did run into some issues with our cordova tests. The tests finish before the promise resolves. Probably a issue with how we are handling promises in cordova, but could also be related to us using jasmine 1.3 instead of jasmine 2.x. I'll continue to investigate but not a blocker. My manually testing shows that the uninstall command works fine with cordova. cordova-fetch tests are written using jasmine 2.0. No issues there. > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11193) Improve performance of `cordova build android`
[ https://issues.apache.org/jira/browse/CB-11193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal reassigned CB-11193: -- Assignee: Nikhil Khandelwal > Improve performance of `cordova build android` > -- > > Key: CB-11193 > URL: https://issues.apache.org/jira/browse/CB-11193 > Project: Apache Cordova > Issue Type: Task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > For a helloworld project, we want to improve the performance of cordova buid > android. > Here's the breakdown on warm builds on my Macbook Pro: > - Node loading time + module loading and global code – 800 ms > - Time for prepare 700ms - 1 second > - Time to check requirements - 1-2 seconds > - Gradle build time: 1.2 seconds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[ https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269800#comment-15269800 ] ASF GitHub Bot commented on CB-11198: - GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-android/pull/303 CB-11198 Skip android target sdk check You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android faster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit 2df86f9f972d0e3149306b481ca5889f711c062c Author: Nikhil Khandelwal Date: 2016-05-03T23:02:02Z CB-11198 Skip android target sdk check > Skip checking android target installed > -- > > Key: CB-11198 > URL: https://issues.apache.org/jira/browse/CB-11198 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > Instead of checking this upfront - we're going to detect failure and show the > message later. > This saves a good 1 second on my Macbook pro. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11198) Skip checking android target installed
[ https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal reassigned CB-11198: -- Assignee: Nikhil Khandelwal > Skip checking android target installed > -- > > Key: CB-11198 > URL: https://issues.apache.org/jira/browse/CB-11198 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > Instead of checking this upfront - we're going to detect failure and show the > message later. > This saves a good 1 second on my Macbook pro. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11198) Skip checking android target installed
Nikhil Khandelwal created CB-11198: -- Summary: Skip checking android target installed Key: CB-11198 URL: https://issues.apache.org/jira/browse/CB-11198 Project: Apache Cordova Issue Type: Sub-task Reporter: Nikhil Khandelwal Instead of checking this upfront - we're going to detect failure and show the message later. This saves a good 1 second on my Macbook pro. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal reassigned CB-11194: -- Assignee: Nikhil Khandelwal > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[
https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Hooey updated CB-11197:
-
Description:
When configuring for full screen app, the statusbar will appear when the
keyboard pops up for input. The iOS build is fine. The previous version
{{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem.
{code}
{code}
Also mentioned in this
[post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
was:
When configuring for full screen app, the statusbar will appear when the
keyboard pops up for input. The iOS build is fine. The previous version
`cordova-plugin-statusbar` `2.0.0` does not exhibit this problem.
{code}
{code}
Also mentioned in this
[post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
> Android status bar appears when keyboard pops up.
> -
>
> Key: CB-11197
> URL: https://issues.apache.org/jira/browse/CB-11197
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: {code}
> cordova 6.1.1
> cordova-plugin-console 1.0.2 "Console"
> cordova-plugin-device 1.1.0 "Device"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-statusbar 2.1.3 "StatusBar"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> {code}
>Reporter: David Hooey
>
> When configuring for full screen app, the statusbar will appear when the
> keyboard pops up for input. The iOS build is fine. The previous version
> {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem.
> {code}
>
>
>
> {code}
> Also mentioned in this
> [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[
https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Hooey updated CB-11197:
-
Description:
When configuring for full screen app, the statusbar will appear when the
keyboard pops up for input. The iOS build is fine. The previous version
`cordova-plugin-statusbar` `2.0.0` does not exhibit this problem.
{code}
{code}
Also mentioned in this
[post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
was:
When configuring for full screen app, the statusbar will appear when the
keyboard pops up for input. The iOS build is fine. The previous version
cordova-plugin-statusbar 2.0.0 does not exhibit this problem.
{code}
{code}
Also mentioned in this
[post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
> Android status bar appears when keyboard pops up.
> -
>
> Key: CB-11197
> URL: https://issues.apache.org/jira/browse/CB-11197
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: {code}
> cordova 6.1.1
> cordova-plugin-console 1.0.2 "Console"
> cordova-plugin-device 1.1.0 "Device"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-statusbar 2.1.3 "StatusBar"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> {code}
>Reporter: David Hooey
>
> When configuring for full screen app, the statusbar will appear when the
> keyboard pops up for input. The iOS build is fine. The previous version
> `cordova-plugin-statusbar` `2.0.0` does not exhibit this problem.
> {code}
>
>
>
> {code}
> Also mentioned in this
> [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11197) Android status bar appears when keyboard pops up.
David Hooey created CB-11197:
Summary: Android status bar appears when keyboard pops up.
Key: CB-11197
URL: https://issues.apache.org/jira/browse/CB-11197
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Statusbar
Affects Versions: 2.1.0
Environment: {code}
cordova 6.1.1
cordova-plugin-console 1.0.2 "Console"
cordova-plugin-device 1.1.0 "Device"
cordova-plugin-file 3.0.0 "File"
cordova-plugin-file-transfer 1.4.0 "File Transfer"
cordova-plugin-statusbar 2.1.3 "StatusBar"
cordova-plugin-whitelist 1.2.0 "Whitelist"
{code}
Reporter: David Hooey
When configuring for full screen app, the statusbar will appear when the
keyboard pops up for input. The iOS build is fine. The previous version
cordova-plugin-statusbar 2.0.0 does not exhibit this problem.
{code}
{code}
Also mentioned in this
[post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269645#comment-15269645
]
Omar Mefire edited comment on CB-11192 at 5/3/16 9:52 PM:
--
This issue was fixed by:
1- Allowing codesign to bypass the keychain access password:
https://support.apple.com/kb/PH18682?locale=en_US
2- Resetting the certs associated with the Devlpt Provisioning Profile
Note: No prompt was displayed requesting credentials, which made the whole
thing confusing
Tip: a restart of the buildbot slave was necessary after the operation.
was (Author: omefire):
This issue was fixed by allowing codesign to bypass the keychain access
password: https://support.apple.com/kb/PH18682?locale=en_US
Note: No prompt was displayed requesting credentials, which made the whole
thing confusing
Tip: a restart of the buildbot slave was necessary after the operation.
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
>Assignee: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire resolved CB-11192.
--
Resolution: Fixed
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
>Assignee: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269645#comment-15269645
]
Omar Mefire edited comment on CB-11192 at 5/3/16 9:37 PM:
--
This issue was fixed by allowing codesign to bypass the keychain access
password: https://support.apple.com/kb/PH18682?locale=en_US
Note: No prompt was displayed requesting credentials, which made the whole
thing confusing
Tip: a restart of the buildbot slave was necessary after the operation.
was (Author: omefire):
This issue was fixed by allowing codesign to bypass the keychain access
password: https://support.apple.com/kb/PH18682?locale=en_US
Note: No prompt was displayed requesting credentials
Tip: a restart of the buildbot slave was necessary after the operation.
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
>Assignee: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269645#comment-15269645
]
Omar Mefire commented on CB-11192:
--
This issue was fixed by allowing codesign to bypass the keychain access
password: https://support.apple.com/kb/PH18682?locale=en_US
Note: No prompt was displayed requesting credentials
Tip: a restart of the buildbot slave was necessary after the operation.
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
>Assignee: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire reassigned CB-11192:
Assignee: Omar Mefire
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
>Assignee: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269635#comment-15269635 ] ASF GitHub Bot commented on CB-7: - GitHub user jasongin opened a pull request: https://github.com/apache/cordova-windows/pull/174 CB-7: Optimize prepare for windows platform, clean prepared files This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip copying files that didn't change. Some refactoring was required because previously the target directories would just be wiped before copying; now we need to map out the source and target directories so the `FileUpdater` has the necessary information to determine the optimal set of file operations. And I'm making it so that `cordova clean windows` also cleans the prepared files (but `clean.bat` does not). You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasongin/cordova-windows CB-7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269626#comment-15269626 ] ASF GitHub Bot commented on CB-7: - GitHub user jasongin opened a pull request: https://github.com/apache/cordova-ios/pull/220 CB-7: Optimize prepare for ios platform, clean prepared files This uses the `FileUpdater` module added in apache/cordova-lib#429 to skip copying files that didn't change. Some refactoring was required because previously the target directories would just be wiped before copying; now we need to map out the source and target directories so the `FileUpdater` has the necessary information to determine the optimal set of file operations. And I'm making it so that `cordova clean ios` also cleans the prepared files (but the `clean` shell script does not). You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasongin/cordova-ios CB-7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #220 > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269612#comment-15269612 ] ASF GitHub Bot commented on CB-11196: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216668274 @jasongin maybe I can see about getting [this logo](http://www.apple.com/osx/) for OS X. Title text is added by docs.js [here](https://github.com/apache/cordova-docs/pull/593/commits/2db61d31e3b73733449a075d0330dd4f781de0e2#diff-ab90a31f2984d41d3f15121f790a71deR138). I hate doing it in the JS, but that's the only way if we ant to use the `== mark ==` syntax > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11174) cordova platformApi cache isn't dealing correctly with symlinked project dirs
[
https://issues.apache.org/jira/browse/CB-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269616#comment-15269616
]
ASF subversion and git services commented on CB-11174:
--
Commit cc83559597db1a7367252c808bc05b697aea52db in cordova-lib's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=cc83559 ]
CB-11174 Resolve symlinked path before getting PlatformApi instance
This closes #433
> cordova platformApi cache isn't dealing correctly with symlinked project dirs
> -
>
> Key: CB-11174
> URL: https://issues.apache.org/jira/browse/CB-11174
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 6.1.1
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Labels: triaged
>
> When project dir is inside of symlinked directory (say {{/var}} on OS X),
> {{getPlatformApi}} method in cordova-lib doesn't resolve real path before
> dealing with cache and uses provided path as-is. This causes returning two
> separate instances of {{PlatformApi}} class when {{getPlatformApi}} is first
> called with symlinked path and then with real one, despite of the fact that
> both paths are pointing to the same project.
> In the real life this issue causes the following 'npm test' failures for
> cordova-lib on OS X, caused by mocking methods for one PlatformApi instance
> and using another one:
> {noformat}
> 1) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:175:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
>
> 2) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:179:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11174) cordova platformApi cache isn't dealing correctly with symlinked project dirs
[
https://issues.apache.org/jira/browse/CB-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269617#comment-15269617
]
ASF GitHub Bot commented on CB-11174:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/433
> cordova platformApi cache isn't dealing correctly with symlinked project dirs
> -
>
> Key: CB-11174
> URL: https://issues.apache.org/jira/browse/CB-11174
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
>Affects Versions: 6.1.1
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
> Labels: triaged
>
> When project dir is inside of symlinked directory (say {{/var}} on OS X),
> {{getPlatformApi}} method in cordova-lib doesn't resolve real path before
> dealing with cache and uses provided path as-is. This causes returning two
> separate instances of {{PlatformApi}} class when {{getPlatformApi}} is first
> called with symlinked path and then with real one, despite of the fact that
> both paths are pointing to the same project.
> In the real life this issue causes the following 'npm test' failures for
> cordova-lib on OS X, caused by mocking methods for one PlatformApi instance
> and using another one:
> {noformat}
> 1) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:175:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
>
> 2) plugin end-to-end should not run prepare after plugin
> installation/removal if platform return non-falsy value
>Message:
> Expected spy preparePlatforms not to have been called.
>Stacktrace:
> Error: Expected spy preparePlatforms not to have been called.
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:179:50
> at _fulfilled
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269609#comment-15269609 ] ASF GitHub Bot commented on CB-11196: - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216667182 Diffing an svg file also sucks. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269606#comment-15269606 ] ASF GitHub Bot commented on CB-11196: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-21788 Do the icons have title text? If so I can't find it in the code. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269594#comment-15269594 ] ASF GitHub Bot commented on CB-11196: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216665227 > The Apple logo is now used to indicate the OS X platform. This is confusing to me, given that I never think about using Cordova to develop apps for OS X, and my iPhone has a prominent Apple logo on the back. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269571#comment-15269571 ] ASF GitHub Bot commented on CB-11196: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216662778 Also note that this changes the iOS logo (see leftmost logo in attached image). The Apple logo is now used to indicate the OS X platform. The new iOS logo is sort of hard to see in the xml docs, but looks much better in the plugin search. All of the logos have alt-text that says the platform they represent. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269564#comment-15269564 ] ASF GitHub Bot commented on CB-11196: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216661665 @rakatyal @nikhilkh please review. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269561#comment-15269561 ] ASF GitHub Bot commented on CB-11196: - Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/593#issuecomment-216661525 Here is what it looks like. The logos appear under the attribute name.  > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos
[ https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269553#comment-15269553 ] ASF GitHub Bot commented on CB-11196: - GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/593 CB-11196: Converting mark elements in docs to platform logos Changes the XML references to display platform logos rather than lists of highlighted platform names. Also adds new logos for iOS, OS X, and Browser platforms that will appear both in the docs and in plugin search. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-11196 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #593 commit 2db61d31e3b73733449a075d0330dd4f781de0e2 Author: Richard Knoll Date: 2016-05-03T20:40:42Z CB-11196: Converting mark elements in docs to platform logos Changes the XML references to display platform logos rather than lists of highlighted platform names. Also adds new logos for iOS, OS X, and Browser platforms that will appear both in the docs and in plugin search. > Convert platform lists in docs XML reference to logos > - > > Key: CB-11196 > URL: https://issues.apache.org/jira/browse/CB-11196 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Assignee: Richard B Knoll > Labels: triaged > > Overload the "mark" syntax so that writing a platform like ==android== > results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11196) Convert platform lists in docs XML reference to logos
Richard B Knoll created CB-11196: Summary: Convert platform lists in docs XML reference to logos Key: CB-11196 URL: https://issues.apache.org/jira/browse/CB-11196 Project: Apache Cordova Issue Type: Improvement Components: Docs Reporter: Richard B Knoll Assignee: Richard B Knoll Overload the "mark" syntax so that writing a platform like ==android== results in an Android logo appearing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6137) Documentation for plugins needs to be better integrated into main documentation website
[ https://issues.apache.org/jira/browse/CB-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269525#comment-15269525 ] Richard B Knoll commented on CB-6137: - The new website was recently updated to pull in the READMEs from the plugin repos when it is deployed. The READMEs will get snapshotted with the rest of the docs, so that should solve the versioning issue. I believe the plan is for the translations to live in the docs repo and not the plugin repos (they will get uploaded to crowdin along with the docs). > Documentation for plugins needs to be better integrated into main > documentation website > --- > > Key: CB-6137 > URL: https://issues.apache.org/jira/browse/CB-6137 > Project: Apache Cordova > Issue Type: New Feature > Components: Docs >Reporter: Lisa Seacat DeLuca > > Currently the documentation for the plugins is referenced from the main > documentation website that links to each plugin's git repository. Ex. > https://github.com/apache/cordova-plugin-battery-status/blob/dev/doc/index.md > > This is a problem for a number of reasons: 1. versioning 2. translation. > Ideally we keep the plugin documentation builidng and available from within > the main html documentation site. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10844) Site-wide search doesn't work
[ https://issues.apache.org/jira/browse/CB-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269537#comment-15269537 ] Richard B Knoll commented on CB-10844: -- [~RobPosener] check out the new search. We switched from Google to Algolia. > Site-wide search doesn't work > - > > Key: CB-10844 > URL: https://issues.apache.org/jira/browse/CB-10844 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Affects Versions: 6.0.0 >Reporter: Robert Posener >Assignee: Dmitry Blotsky >Priority: Minor > Labels: triaged > > No matter what you enter as search criteria (eg, "preference", "bluetooth", > "fred" and "rubbish" you always get 11,800 results and none of them are > "matches". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-5643) document CLI hooks
[ https://issues.apache.org/jira/browse/CB-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard B Knoll closed CB-5643. --- Resolution: Fixed Recently added: http://cordova.apache.org/docs/en/latest/guide/appdev/hooks/index.html > document CLI hooks > -- > > Key: CB-5643 > URL: https://issues.apache.org/jira/browse/CB-5643 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Marcel Kinard >Priority: Minor > > There currently is no documentation about the CLI hooks, and how a consumer > could use them. > Apparently this was not completed as part of CB-5122. > See > http://devgirl.org/2013/11/12/three-hooks-your-cordovaphonegap-project-needs/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10045) Extend bootstrap stylings to docs
[ https://issues.apache.org/jira/browse/CB-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard B Knoll closed CB-10045. Resolution: Fixed > Extend bootstrap stylings to docs > - > > Key: CB-10045 > URL: https://issues.apache.org/jira/browse/CB-10045 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Richard B Knoll >Priority: Minor > > We don't control the HTML that is produced by Redcarpet in the docs > generation. That means that we can't apply CSS classes to them. Certain > elements (like tables) are probably better off having the bootstrap CSS > automatically applied. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11127) Version/language dropdowns and 'deprecated' warnings shouldn't lead to 404s
[ https://issues.apache.org/jira/browse/CB-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard B Knoll closed CB-11127. Resolution: Fixed > Version/language dropdowns and 'deprecated' warnings shouldn't lead to 404s > --- > > Key: CB-11127 > URL: https://issues.apache.org/jira/browse/CB-11127 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Reporter: Dmitry Blotsky >Assignee: Dmitry Blotsky > Original Estimate: 48h > Remaining Estimate: 48h > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11126) ToC entry names should come from pages they reference
[ https://issues.apache.org/jira/browse/CB-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard B Knoll closed CB-11126. Resolution: Fixed > ToC entry names should come from pages they reference > - > > Key: CB-11126 > URL: https://issues.apache.org/jira/browse/CB-11126 > Project: Apache Cordova > Issue Type: Improvement > Components: Docs >Reporter: Dmitry Blotsky > Original Estimate: 48h > Remaining Estimate: 48h > > The ToCs should be coupled to the pages they reference, and should use the > translated titles found therein. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raghav Katyal resolved CB-10653.
Resolution: Fixed
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269408#comment-15269408
]
ASF subversion and git services commented on CB-10653:
--
Commit 58895ee4c68e2221146625855b570a0dd0fc8cf7 in cordova-windows's branch
refs/heads/master from [~rakatyal]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=58895ee ]
CB-10653 Making the windows activation context complete
This closes #173
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269409#comment-15269409
]
ASF GitHub Bot commented on CB-10653:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/173
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269405#comment-15269405
]
ASF GitHub Bot commented on CB-10653:
-
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216637263
Thanks for the feedback guys. Merging the changes.
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml
[ https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269352#comment-15269352 ] ASF GitHub Bot commented on CB-11023: - Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216629805 @macdonst @purplecabbage On my other machine (Mac), I see the same behavior that you both were seeing. I was able to fix it by doing a `cordova-coho/coho npm-link` and re-adding the android platform to the project. What was happening was the cordova-common module inside of cordova-android wasn't being linked to the one in cordova-lib, so it was using a cordova-common without my changes in it, thus using the default functionality of config-file. On a side note (this only happens for me on Mac, works fine on Windows), when coho replaces the cordova-common module with a symlink, this was treated as deleting the cordova-common module, then when I go to add the android platform, I get an error saying `Cannot find module 'cordova-common'` and when I checked the node modules folder, there's only a symlink file of cordova-common. I'm not really sure how symlinks are supposed to work on Mac since I mainly use a Windows machine. The project still runs and cordova-common is actually linked. I'm not sure if this is a Mac issue or something else. > plugin.xml should be able to add attribute to an existing element in > AndroidManifest.xml > > > Key: CB-11023 > URL: https://issues.apache.org/jira/browse/CB-11023 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Reporter: Carlos Santana > > We have a need for a plugin we develop to add the attribute android:name to > the element to be able to point to a Class that tracks app > sessions for analytics. > plugin.xml only support via only to add elements to > AndroidManfist.xml this request is to add an enhancement to also handle > adding an attribute to an existing element. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269346#comment-15269346 ] ASF GitHub Bot commented on CB-7: - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216628696 Okay, thanks for clarifying. I rescind my objection. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269326#comment-15269326 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216624907 If you're talking about a source file, then that would change the last-modified timestamp of the source file, causing it to be newer than the target file so it will be copied on the next prepare. If you save changes to a source file at precisely the wrong time _while a build is in progress_ (and the change doesn't affect the size of the file), then it's possible the change could go undetected if a hook modifies the corresponding target file to make it newer than the changed source file. But even good old 'make' has this issue. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269290#comment-15269290
]
ASF GitHub Bot commented on CB-10653:
-
Github user afourney commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216620202
@rakatyal Thanks for investigating. Your findings agree with my own
experiences. This is possibly some quirk of WinJS.
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269286#comment-15269286 ] ASF GitHub Bot commented on CB-7: - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216619728 Is it possible that a change to a file without affecting file size could go undetected? > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269271#comment-15269271 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216618237 BTW, I didn't mention above the reason I had to abandon the approach of checking for exactly-equal modified times. The problem is the OS X filesystem doesn't support sub-second timestamps, so it would be possible for a file to be modified again in the same second while still appearing to have the same timestamp. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269273#comment-15269273
]
ASF GitHub Bot commented on CB-10653:
-
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216618382
I did some digging into this with other activation kinds and I confirmed
that few event details are lost once the event handler is executed possibly to
hide/disable few properties of the object. So it looks like cloning might be
the only way out of it. I will update the PR soon.
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269264#comment-15269264 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216617718 @purplecabbage If a hook fails because it expected a file would be refreshed but it wasn't, then I'd expect the hook to print an error (or stack trace), so that should be easy to find. Is there another scenario you're concerned about? > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269225#comment-15269225 ] ASF GitHub Bot commented on CB-7: - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216614096 I would not consider that contrived. This would be an extremely tough issue to find if it happened. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269196#comment-15269196 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216611405 All right, I think this is the best we can do. The latest logic copies the file if the source's last-modified time is >= the target's last-modified time, or if the file sizes are different. At the time the file gets copied, the target's last-modified time gets set to the current time, so it is greater than the source's time until the source gets modified again. This should work fine with hooks, because a hook that modifies a file is likely to change the size, or if it doesn't change the size then the hook is likely to handle the file not being refreshed. One could contrive an artificial scenario in which the right thing doesn't happen, but in practice I don't think there would be any issues. And still there will be the 'clean' functionality to fall back on. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269158#comment-15269158
]
ASF GitHub Bot commented on CB-11194:
-
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61922956
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
-var bplist = require('bplist-parser');
-var et = require('elementtree');
-var glob = require('glob');
-var plist = require('plist');
+var modules = {};
+
+function addProperty(obj, property, modulePath) {
--- End diff --
+1
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11195) Windows platform - create windows 10 app packages
[
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
napcat updated CB-11195:
Description:
When a windows cordova platform is added using:
cordova platform add windows
And the windows 10 project, inside visual studio 2015, is used to build the app
package, the package validation fails, when it's validated using the "Windows
App Certification Kit 10.0". The selected architectures are: x86 (release),
x64(release) and ARM (release).
{code:xml}
UTF-8 file encoding
Error Found: The UTF-8 file encoding test detected the following errors:
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
...
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html is
not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
form with a corresponding byte-order mark (BOM) in order to benefit from
bytecode caching and to avoid other runtime error conditions.
{code}
{code:xml}
Bytecode generation
Error Found: The bytecode generation test detected the following errors:
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
has JavaScript syntax or other problems.
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
has JavaScript syntax or other problems.
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
has JavaScript syntax or other problems.
...
Impact if not fixed: As a performance optimization to accelerate JavaScript
execution time, JavaScript files ending in the ".js" extension generate
bytecode when the app is deployed. This optimization significantly improves
start-up and ongoing execution times for JavaScript.
How to fix: You may need consider one or more of these steps to fix the issue:
- Avoid deploying the app by pressing F5 in Visual Studio, create an appx
package instead
- Ensure that event logging is enabled
- All JavaScript files are syntactically valid; otherwise exclude the
respective files from the package
- Please note that you should uninstall all previous versions of the app
before deploying
Otherwise exclude the respective files from the package.
{code}
Can the app be submitted with this erros?
Should not the cordova generate the project ready for publication?
was:
When a windows cordova platform is added using:
cordova platform add windows
And the windows 10 project, inside visual studio 2015, is used to build the app
package, the package validation fails, when it's validated using the "Windows
App Certification Kit 10.0". The selected architectures are: x86 (release),
x64(release) and ARM (release).
{code:xml}
UTF-8 file encoding
Error Found: The UTF-8 file encoding test detected the following errors:
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
...
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html is
not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
form with a corresponding byte-order mark (BOM) in order to benefit from
bytecode caching and to avoid other runtime error conditions.
{code}
{code:xml}
Bytecode generation
Error Found: The bytecode generation test detected the following errors:
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
has JavaScript syntax or other problems.
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\c
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269100#comment-15269100
]
ASF GitHub Bot commented on CB-11194:
-
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61917593
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-events: require('./src/events'),
-superspawn: require('./src/superspawn'),
-
-ActionStack: require('./src/ActionStack'),
-CordovaError: require('./src/CordovaError/CordovaError'),
-CordovaLogger: require('./src/CordovaLogger'),
-CordovaExternalToolErrorContext:
require('./src/CordovaError/CordovaExternalToolErrorContext'),
-PlatformJson: require('./src/PlatformJson'),
-ConfigParser: require('./src/ConfigParser/ConfigParser.js'),
-
-PluginInfo: require('./src/PluginInfo/PluginInfo.js'),
-PluginInfoProvider: require('./src/PluginInfo/PluginInfoProvider.js'),
-
-PluginManager: require('./src/PluginManager'),
-
-ConfigChanges: require('./src/ConfigChanges/ConfigChanges.js'),
-ConfigKeeper: require('./src/ConfigChanges/ConfigKeeper.js'),
-ConfigFile: require('./src/ConfigChanges/ConfigFile.js'),
-mungeUtil: require('./src/ConfigChanges/munge-util.js'),
-
-xmlHelpers: require('./src/util/xml-helpers')
-};
+function addProperty(obj, property, modulePath) {
+var val = null;
+
+// Add properties as getter to delay load the modules on first
invocation
+Object.defineProperty(obj, property, {
+configurable: true,
+get: function () {
+val = val || require(modulePath);
+ob[property] = val;
--- End diff --
This was a last minute change - fixed already - yes, I can remove 'val'
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269090#comment-15269090
]
ASF GitHub Bot commented on CB-11194:
-
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61917144
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscore');
var Q = require('q');
-var shell = require('shelljs');
+var which = require('shelljs/src/which');
--- End diff --
this eliminates multiple copies of `shelljs` - since every module gets it's
own version. There are two versions of cordova-common loaded and hence two
shelljs modules.
If we do update the version of shelljs and this breaks - it would be very
obvious to fix. I have a PR in the works to submit to shelljs to delay load on
their side.
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269065#comment-15269065
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915826
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscore');
var Q = require('q');
-var shell = require('shelljs');
+var which = require('shelljs/src/which');
--- End diff --
Also, does this really save any time? Lots of sources require shelljs, so
I'd expect it to be fully loaded somewhere else anyway.
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269058#comment-15269058
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61915398
--- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
@@ -474,7 +473,12 @@ function getCreateArgs(destinationDir, projectConfig,
options) {
// CB-6992 it is necessary to normalize characters
// because node and shell scripts handles unicode symbols differently
// We need to normalize the name to NFD form since iOS uses NFD
unicode form
-args.push(platformName == 'ios' ? unorm.nfd(projectConfig.name()) :
projectConfig.name());
+var name = projectConfig.name();
+if (platformName == 'ios') {
+var unorm = require('unorm');
+name = unorm.nfd(projectConfig.name());
--- End diff --
`name = unorm.nfd(name);`
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269037#comment-15269037
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61914375
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
-var bplist = require('bplist-parser');
-var et = require('elementtree');
-var glob = require('glob');
-var plist = require('plist');
+var modules = {};
+
+function addProperty(obj, property, modulePath) {
--- End diff --
Perhaps add an optional 4th parameter which is the name of a property on
the required module.
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269021#comment-15269021
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913509
--- Diff: cordova-common/src/superspawn.js ---
@@ -22,7 +22,7 @@ var fs = require('fs');
var path = require('path');
var _ = require('underscore');
var Q = require('q');
-var shell = require('shelljs');
+var which = require('shelljs/src/which');
--- End diff --
It looks like this relies on shelljs internal layout that may change in a
future version.
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269017#comment-15269017
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913318
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path');
-var bplist = require('bplist-parser');
-var et = require('elementtree');
-var glob = require('glob');
-var plist = require('plist');
+var modules = {};
+
+function addProperty(obj, property, modulePath) {
--- End diff --
Can this be defined once and then required from other sources?
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11195) Windows platform - create windows 10 app packages
napcat created CB-11195:
---
Summary: Windows platform - create windows 10 app packages
Key: CB-11195
URL: https://issues.apache.org/jira/browse/CB-11195
Project: Apache Cordova
Issue Type: Bug
Components: Windows
Affects Versions: 6.1.1
Reporter: napcat
Fix For: 6.1.1
When a windows cordova platform is added using:
cordova platform add windows
And the windows 10 project, inside visual studio 2015, is used to build the app
package, the package validation fails, when it's validated using the "Windows
App Certification Kit 10.0". The selected architectures are: x86 (release),
x64(release) and ARM (release).
{code:xml}
UTF-8 file encoding
Error Found: The UTF-8 file encoding test detected the following errors:
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
...
File C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html is
not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte Order
Mark).
Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8
form with a corresponding byte-order mark (BOM) in order to benefit from
bytecode caching and to avoid other runtime error conditions.
{code}
{code:xml}
Bytecode generation
Error Found: The bytecode generation test detected the following errors:
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
has JavaScript syntax or other problems.
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
has JavaScript syntax or other problems.
File \\?\C:\Program
Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
has JavaScript syntax or other problems.
...
Impact if not fixed: As a performance optimization to accelerate JavaScript
execution time, JavaScript files ending in the ".js" extension generate
bytecode when the app is deployed. This optimization significantly improves
start-up and ongoing execution times for JavaScript.
How to fix: You may need consider one or more of these steps to fix the issue:
- Avoid deploying the app by pressing F5 in Visual Studio, create an appx
package instead
- Ensure that event logging is enabled
- All JavaScript files are syntactically valid; otherwise exclude the
respective files from the package
- Please note that you should uninstall all previous versions of the app
before deploying
Otherwise exclude the respective files from the package.
{code}
Can the app be submitted with this erros?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269012#comment-15269012
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61913141
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-events: require('./src/events'),
-superspawn: require('./src/superspawn'),
-
-ActionStack: require('./src/ActionStack'),
-CordovaError: require('./src/CordovaError/CordovaError'),
-CordovaLogger: require('./src/CordovaLogger'),
-CordovaExternalToolErrorContext:
require('./src/CordovaError/CordovaExternalToolErrorContext'),
-PlatformJson: require('./src/PlatformJson'),
-ConfigParser: require('./src/ConfigParser/ConfigParser.js'),
-
-PluginInfo: require('./src/PluginInfo/PluginInfo.js'),
-PluginInfoProvider: require('./src/PluginInfo/PluginInfoProvider.js'),
-
-PluginManager: require('./src/PluginManager'),
-
-ConfigChanges: require('./src/ConfigChanges/ConfigChanges.js'),
-ConfigKeeper: require('./src/ConfigChanges/ConfigKeeper.js'),
-ConfigFile: require('./src/ConfigChanges/ConfigFile.js'),
-mungeUtil: require('./src/ConfigChanges/munge-util.js'),
-
-xmlHelpers: require('./src/util/xml-helpers')
-};
+function addProperty(obj, property, modulePath) {
--- End diff --
Name this something more specific than addProperty, because it only adds a
specific kind of required-module property.
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269008#comment-15269008
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912923
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-events: require('./src/events'),
-superspawn: require('./src/superspawn'),
-
-ActionStack: require('./src/ActionStack'),
-CordovaError: require('./src/CordovaError/CordovaError'),
-CordovaLogger: require('./src/CordovaLogger'),
-CordovaExternalToolErrorContext:
require('./src/CordovaError/CordovaExternalToolErrorContext'),
-PlatformJson: require('./src/PlatformJson'),
-ConfigParser: require('./src/ConfigParser/ConfigParser.js'),
-
-PluginInfo: require('./src/PluginInfo/PluginInfo.js'),
-PluginInfoProvider: require('./src/PluginInfo/PluginInfoProvider.js'),
-
-PluginManager: require('./src/PluginManager'),
-
-ConfigChanges: require('./src/ConfigChanges/ConfigChanges.js'),
-ConfigKeeper: require('./src/ConfigChanges/ConfigKeeper.js'),
-ConfigFile: require('./src/ConfigChanges/ConfigFile.js'),
-mungeUtil: require('./src/ConfigChanges/munge-util.js'),
-
-xmlHelpers: require('./src/util/xml-helpers')
-};
+function addProperty(obj, property, modulePath) {
+var val = null;
+
+// Add properties as getter to delay load the modules on first
invocation
+Object.defineProperty(obj, property, {
+configurable: true,
+get: function () {
+val = val || require(modulePath);
+ob[property] = val;
--- End diff --
Also, there should be no need to use the 'val' cache if you are overwriting
obj[property].
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269001#comment-15269001
]
ASF GitHub Bot commented on CB-11194:
-
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61912394
--- Diff: cordova-common/cordova-common.js ---
@@ -17,26 +17,40 @@
under the License.
*/
-exports = module.exports = {
-events: require('./src/events'),
-superspawn: require('./src/superspawn'),
-
-ActionStack: require('./src/ActionStack'),
-CordovaError: require('./src/CordovaError/CordovaError'),
-CordovaLogger: require('./src/CordovaLogger'),
-CordovaExternalToolErrorContext:
require('./src/CordovaError/CordovaExternalToolErrorContext'),
-PlatformJson: require('./src/PlatformJson'),
-ConfigParser: require('./src/ConfigParser/ConfigParser.js'),
-
-PluginInfo: require('./src/PluginInfo/PluginInfo.js'),
-PluginInfoProvider: require('./src/PluginInfo/PluginInfoProvider.js'),
-
-PluginManager: require('./src/PluginManager'),
-
-ConfigChanges: require('./src/ConfigChanges/ConfigChanges.js'),
-ConfigKeeper: require('./src/ConfigChanges/ConfigKeeper.js'),
-ConfigFile: require('./src/ConfigChanges/ConfigFile.js'),
-mungeUtil: require('./src/ConfigChanges/munge-util.js'),
-
-xmlHelpers: require('./src/util/xml-helpers')
-};
+function addProperty(obj, property, modulePath) {
+var val = null;
+
+// Add properties as getter to delay load the modules on first
invocation
+Object.defineProperty(obj, property, {
+configurable: true,
+get: function () {
+val = val || require(modulePath);
+ob[property] = val;
--- End diff --
Typo, should be 'obj', not 'ob' ?
> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269000#comment-15269000 ] ASF GitHub Bot commented on CB-11194: - Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r61912274 --- Diff: cordova-common/cordova-common.js --- @@ -3,7 +3,7 @@ or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file -to you under the Apache License, Version 2.0 (the +to you under the Apache License } Version 2.0 (the --- End diff -- fix this > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268992#comment-15268992 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216585668 Well, after further testing I found creation dates don't work reliably due to some strange behavior on Windows: http://serverfault.com/questions/92757/incorrect-file-creation-date-in-windows-xp-vista So I'm still working on finding the best solution here. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268982#comment-15268982 ] ASF GitHub Bot commented on CB-11194: - GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/434 CB-11194 Improve cordova load time I instrumented module load and this change improves our load time by ~50% (300+ ms) for `cordova build android` on a hello world project. Biggest gains are from delay loading only when required: - browserify - unorm - unpack ```diff --- a/Users/nikhil/Developer/cordova/require.log +++ b/Users/nikhil/Developer/cordova/require-after.log @@ -1,116 +1,64 @@ > Module load underscore: 4 ->>> Module load graceful-fs: 3 ->>> Module load osenv: 3 ->>> Module load write-file-atomic: 4 ->> Module load configstore: 17 - Module load color-convert: 4 +>> Module load child_process: 3 +>>> Module load graceful-fs: 6 +>>> Module load osenv: 4 +> Module load crypto: 4 + Module load ./rng: 5 +>>> Module load uuid: 6 +>>> Module load write-file-atomic: 3 +>> Module load configstore: 24 + Module load color-convert: 5 >>> Module load ansi-styles: 6 ->> Module load chalk: 11 ->> Module load semver-diff: 3 -> Module load update-notifier: 36 ->> Module load ../hooks/HooksRunner: 3 -> Module load ./build: 3 ->>> Module load unorm: 24 ->> Module load ../platforms/PlatformApiPoly: 30 - Module load graceful-fs: 12 ->>> Module load ./lib/reader.js: 13 ->> Module load minimatch: 3 ->> Module load inflight: 3 -> Module load glob: 9 - Module load rimraf: 10 ->>> Module load ./lib/writer.js: 15 ->> Module load fstream: 33 -> Module load ./entry.js: 35 - Module load ./entry-writer.js: 37 ->>> Module load ./lib/pack.js: 39 ->> Module load tar: 44 -> Module load ../../util/unpack: 46 - Module load ../plugman/registry/registry: 49 ->>> Module load ./plugin: 54 ->> Module load ./restore-util: 54 ->> Module load acorn: 6 -> Module load falafel: 7 -> Module load ./loadConfig: 3 - Module load browserify-transform-tools: 13 ->>> Module load aliasify: 15 ->>> Module load resolve: 3 ->> Module load browser-resolve: 4 ->>> Module load acorn: 20 - Module load estraverse: 3 - Module load esutils: 4 ->>> Module load escodegen: 11 ->> Module load detective: 33 ->> Module load ./_stream_readable: 3 -> Module load ./_stream_duplex: 9 - Module load ./lib/_stream_transform.js: 9 ->>> Module load readable-stream/transform: 10 ->> Module load through2: 12 ->> Module load concat-stream: 3 ->>> Module load ./_stream_readable: 3 ->> Module load ./_stream_duplex: 7 -> Module load ./lib/_stream_transform.js: 7 - Module load readable-stream/transform: 8 ->>> Module load through2: 8 ->> Module load stream-combiner2: 11 -> Module load module-deps: 70 -> Module load deps-sort: 3 ->> Module load JSONStream: 3 ->> Module load ./_stream_readable: 3 -> Module load ./_stream_duplex: 6 - Module load ./lib/_stream_transform.js: 7 ->>> Module load readable-stream/transform: 8 ->> Module load through2: 8 -> Module load ./source-map/source-map-generator: 10 -> Module load ./source-map/source-node: 3 - Module load source-map: 14 ->>> Module load inline-source-map: 15 -> Module load ./source-map/source-map-generator: 9 -> Module load ./source-map/source-map-consumer: 3 - Module load source-map: 15 ->>> Module load ./lib/mappings-from-map: 16 ->> Module load combine-source-map: 33 -> Module load browser-pack: 46 - Module load acorn: 18 ->>> Module load astw: 18 ->> Module load lexical-scope: 19 -> Module load ./source-map/source-map-generator: 8 -> Module load ./source-map/source-map-consumer: 5 - Module load source-map: 16 ->>> Module load inline-source-map: 17 ->> Module load combine-source-map: 21 -> Module load insert-module-globals: 43 ->> Module load acorn: 25 -> Module load syntax-error: 26 -> Module load ./lib/builtins.js: 9 ->> Module load stream-splicer: 4 -> Module load labeled-stream-splicer: 5 - Module load browserify: 208 ->>> Module load cordova-js/tasks/lib/bundle-browserify: 216 ->> Module load ../plugman/browserify: 234 -
[jira] [Updated] (CB-11192) Codesign Error while running cordova-ios builds
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire updated CB-11192:
-
Summary: Codesign Error while running cordova-ios builds (was: Codesign
Error)
> Codesign Error while running cordova-ios builds
> ---
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11192) Codesign Error
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire updated CB-11192:
-
Description:
Log:
https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
=
{noformat}
/usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
--entitlements
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
--timestamp=none
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
User interaction is not allowed.
Command /usr/bin/codesign failed with exit code 1
** BUILD FAILED **
The following build commands failed:
CodeSign build/device/mobilespec.app
(1 failure)
Error: Error code 65 for command: xcodebuild with args:
-xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
[MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
program finished with exit code 1
elapsedTime=48.002733
{noformat}
was:
Error happening in multiple platforms. Sample Link:
https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio
{noformat}
/usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
--entitlements
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
--timestamp=none
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
User interaction is not allowed.
Command /usr/bin/codesign failed with exit code 1
** BUILD FAILED **
The following build commands failed:
CodeSign build/device/mobilespec.app
(1 failure)
Error: Error code 65 for command: xcodebuild with args:
-xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
[MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
program finished with exit code 1
elapsedTime=48.002733
{noformat}
> Codesign Error
> --
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Log:
> https://ci.apache.org/builders/cordova-ios/builds/2485/steps/running-tests/logs/stdio
> =
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mai
[jira] [Updated] (CB-11192) Codesign Error
[
https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire updated CB-11192:
-
Description:
Error happening in multiple platforms. Sample Link:
https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio
{noformat}
/usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
--entitlements
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
--timestamp=none
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
User interaction is not allowed.
Command /usr/bin/codesign failed with exit code 1
** BUILD FAILED **
The following build commands failed:
CodeSign build/device/mobilespec.app
(1 failure)
Error: Error code 65 for command: xcodebuild with args:
-xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
[MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
program finished with exit code 1
elapsedTime=48.002733
{noformat}
was:
Error happening in multiple platforms. Sample Link:
https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio
Sample Error
===
Total failures: 1
Failing tests:
cordova-plugin-device-motion-tests.tests >> Accelerometer
(navigator.accelerometer) watchAcceleration accelerometer.spec.9 success
callback Acceleration object should return a recent timestamp
Expected 1462208916338 to be greater than 1462208916528.
Error: Expected 1462208916338 to be greater than 1462208916528.
at stack
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
at buildExpectationResult
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
at Spec.Env.expectationResultFactory
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
at Spec.addExpectationResult
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
at Expectation.addExpectationResult
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
at Expectation.toBeGreaterThan
(file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
at win
(file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33)
at
file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21
> Codesign Error
> --
>
> Key: CB-11192
> URL: https://issues.apache.org/jira/browse/CB-11192
> Project: Apache Cordova
> Issue Type: Test
> Components: mobile-spec
>Reporter: Omar Mefire
> Labels: cordova-ios, found-by-ci
>
> Error happening in multiple platforms. Sample Link:
> https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio
>
> {noformat}
> /usr/bin/codesign --force --sign 868701A6834722608D692C12DCE6309040CF7DAA
> --entitlements
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/mobilespec.build/Debug-iphoneos/mobilespec.build/mobilespec.app.xcent
> --timestamp=none
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app
> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device/mobilespec.app:
> User interaction is not allowed.
> Command /usr/bin/codesign failed with exit code 1
> ** BUILD FAILED **
> The following build commands failed:
> CodeSign build/device/mobilespec.app
> (1 failure)
> Error: Error code 65 for command: xcodebuild with args:
> -xcconfig,/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/cordova/build-debug.xcconfig,-project,mobilespec.xcodeproj,ARCHS=armv7
>
> arm64,-target,mobilespec,-configuration,Debug,-sdk,iphoneos,build,VALID_ARCHS=armv7
>
> arm64,CONFIGURATION_BUILD_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/device,SHARED_PRECOMPS_DIR=/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/build/sharedpch
> [MEDIC LOG Tue, 03 May 2016 12:05:25 GMT] FATAL: running on device failed
> program finished with exit code 1
> elapsedTime=48.002733
> {noformat}
--
This message was sent by A
[jira] [Updated] (CB-11192) Codesign Error
[ https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omar Mefire updated CB-11192: - Labels: cordova-ios found-by-ci (was: flaky found-by-ci triaged) > Codesign Error > -- > > Key: CB-11192 > URL: https://issues.apache.org/jira/browse/CB-11192 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Reporter: Omar Mefire > Labels: cordova-ios, found-by-ci > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11194) Improve cordova load time
Nikhil Khandelwal created CB-11194: -- Summary: Improve cordova load time Key: CB-11194 URL: https://issues.apache.org/jira/browse/CB-11194 Project: Apache Cordova Issue Type: Sub-task Reporter: Nikhil Khandelwal We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11193) Improve performance of `cordova build android`
Nikhil Khandelwal created CB-11193: -- Summary: Improve performance of `cordova build android` Key: CB-11193 URL: https://issues.apache.org/jira/browse/CB-11193 Project: Apache Cordova Issue Type: Task Components: Android, CordovaLib Reporter: Nikhil Khandelwal For a helloworld project, we want to improve the performance of cordova buid android. Here's the breakdown on warm builds on my Macbook Pro: - Node loading time + module loading and global code – 800 ms - Time for prepare 700ms - 1 second - Time to check requirements - 1-2 seconds - Gradle build time: 1.2 seconds. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11192) Codesign Error
Omar Mefire created CB-11192: Summary: Codesign Error Key: CB-11192 URL: https://issues.apache.org/jira/browse/CB-11192 Project: Apache Cordova Issue Type: Test Components: Plugin Device Motion Reporter: Omar Mefire Error happening in multiple platforms. Sample Link: https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio Sample Error === Total failures: 1 Failing tests: cordova-plugin-device-motion-tests.tests >> Accelerometer (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success callback Acceleration object should return a recent timestamp Expected 1462208916338 to be greater than 1462208916528. Error: Expected 1462208916338 to be greater than 1462208916528. at stack (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) at buildExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) at Spec.Env.expectationResultFactory (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) at Spec.addExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) at Expectation.addExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) at Expectation.toBeGreaterThan (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) at win (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) at file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11192) Codesign Error
[ https://issues.apache.org/jira/browse/CB-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omar Mefire updated CB-11192: - Component/s: (was: Plugin Device Motion) mobile-spec > Codesign Error > -- > > Key: CB-11192 > URL: https://issues.apache.org/jira/browse/CB-11192 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Reporter: Omar Mefire > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11135) cordova-ios build failure: "TypeError: Cannot read property 'trim' of undefined"
[
https://issues.apache.org/jira/browse/CB-11135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omar Mefire resolved CB-11135.
--
Resolution: Fixed
> cordova-ios build failure: "TypeError: Cannot read property 'trim' of
> undefined"
>
>
> Key: CB-11135
> URL: https://issues.apache.org/jira/browse/CB-11135
> Project: Apache Cordova
> Issue Type: Test
> Components: Medic
> Environment: OSX
>Reporter: Omar Mefire
>Assignee: Omar Mefire
>Priority: Minor
> Labels: found-by-ci, ios, triaged
>
> Logs:
> (https://ci.apache.org/builders/cordova-ios/builds/2375/steps/running-tests/logs/stdio)
> ===
> {noformat}
> MEDIC LOG Thu, 21 Apr 2016 18:00:11 GMT] cordova run --list --emulator |
> grep ^iPhone | tail -n1
> /Users/buildbot/slaves/apache/cordova-ios/cordova-medic/lib/util.js:102
> var version = split[1].trim();
> ^
> TypeError: Cannot read property 'trim' of undefined
> at Object.getSimId
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/lib/util.js:102:31)
> at MedicIOSPermissions.updatePermissions
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/lib/medicIOSPermissions.js:18:35)
> at iOSSpecificPreparation
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/medic/medic-run.js:263:20)
> at
> /Users/buildbot/slaves/apache/cordova-ios/cordova-medic/medic/medic-run.js:394:28
> at Request._callback
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/medic/medic-run.js:309:13)
> at Request.self.callback
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/node_modules/request/request.js:368:22)
> at Request.emit (events.js:110:17)
> at Request.
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/node_modules/request/request.js:1219:14)
> at Request.emit (events.js:129:20)
> at IncomingMessage.
> (/Users/buildbot/slaves/apache/cordova-ios/cordova-medic/node_modules/request/request.js:1167:12)
> program finished with exit code 1
> elapsedTime=2.282192
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml
[ https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268781#comment-15268781 ] ASF GitHub Bot commented on CB-11023: - Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951 @purplecabbage My workspace is working off of the master branches with the tools npm linked. I modified the plugin.xml of cordova-plugin-device and added: ``` ``` Then for the project: ``` cordova create myApp cd myApp cordova platform add ../cordova-android cordova plugin add ../cordova-plugin-device ``` I check AndroidManifest.xml and the new attributes are there as expect, without a new tag being added. I'll try testing this PR on another machine and see what result I get. As for getting config-file tag into config.xml, I've been caught up in some other work so will get to this sometime later in the week. > plugin.xml should be able to add attribute to an existing element in > AndroidManifest.xml > > > Key: CB-11023 > URL: https://issues.apache.org/jira/browse/CB-11023 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Reporter: Carlos Santana > > We have a need for a plugin we develop to add the attribute android:name to > the element to be able to point to a Class that tracks app > sessions for analytics. > plugin.xml only support via only to add elements to > AndroidManfist.xml this request is to add an enhancement to also handle > adding an attribute to an existing element. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11191) Statusbar plugin causing issues with webview size
[ https://issues.apache.org/jira/browse/CB-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Philipson updated CB-11191: Description: It appears the statusbar plugin is causing issues with the iOS webview on small form factor devices (iPhone & iPod) when switching orientation whilst the camera is open (camera opened using cordova camera plugin) Steps to reproduce: Start the application and begin using it in landscape Open the camera using the cordova camera plugin Whilst the camera is open, rotate into portrait Close the camera Webview is now squashed down the left of the screen (only fills about 1/4 of the screens overall width) Can recover by changing orientation again. Sample test app on Github: https://github.com/ISeeBinary/statusbar_plugin_testapp (tapping on the red square at the top of the test app page should launch the camera) Removing the statusbar plugin rectifies the issue. was: It appears the statusbar plugin is causing issues with the iOS webview on small form factor devices (iPhone & iPod) when switching orientation whilst the camera is open (camera opened using cordova camera plugin) Steps to reproduce: Start the application and begin using it in landscape Open the camera using the cordova camera plugin Whilst the camera is open, rotate into portrait Close the camera Webview is now squashed down the left of the screen (only fills about 1/4 of the screens overall width) Can recover by changing orientation again. Sample test app on Github: https://github.com/ISeeBinary/statusbar_plugin_testapp (tapping on the red square at the top of the test app page should launch the camera) > Statusbar plugin causing issues with webview size > - > > Key: CB-11191 > URL: https://issues.apache.org/jira/browse/CB-11191 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: Cordova CLI Version: 6.1.1 > Cordova iOS Engine: 4.1.1 > Build environment: OSX El Capitan & XCode 7.3 > Device experiencing problem: iPod Touch running iOS 9.3.1 >Reporter: Dave Philipson > Labels: ios > > It appears the statusbar plugin is causing issues with the iOS webview on > small form factor devices (iPhone & iPod) when switching orientation whilst > the camera is open (camera opened using cordova camera plugin) > Steps to reproduce: > Start the application and begin using it in landscape > Open the camera using the cordova camera plugin > Whilst the camera is open, rotate into portrait > Close the camera > Webview is now squashed down the left of the screen (only fills about 1/4 of > the screens overall width) > Can recover by changing orientation again. > Sample test app on Github: > https://github.com/ISeeBinary/statusbar_plugin_testapp > (tapping on the red square at the top of the test app page should launch the > camera) > Removing the statusbar plugin rectifies the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11191) Statusbar plugin causing issues with webview size
[ https://issues.apache.org/jira/browse/CB-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Philipson updated CB-11191: Description: It appears the statusbar plugin is causing issues with the iOS webview on small form factor devices (iPhone & iPod) when switching orientation whilst the camera is open (camera opened using cordova camera plugin) Steps to reproduce: Start the application and begin using it in landscape Open the camera using the cordova camera plugin Whilst the camera is open, rotate into portrait Close the camera Webview is now squashed down the left of the screen (only fills about 1/4 of the screens overall width) Can recover by changing orientation again. Sample test app on Github: https://github.com/ISeeBinary/statusbar_plugin_testapp (tapping on the red square at the top of the test app page should launch the camera) was: It appears the statusbar plugin is causing issues with the iOS webview on small form factor devices (iPhone & iPod) when switching orientation whilst the camera is open (camera opened using cordova camera plugin) Steps to reproduce: Start the application and begin using it in landscape Open the camera using the cordova camera plugin Whilst the camera is open, rotate into portrait Close the camera Webview is now squashed down the left of the screen (only fills about 1/4 of the screens overall width) Can recover by changing orientation again. Sample test app on Github: https://github.com/ISeeBinary/statusbar_plugin_testapp > Statusbar plugin causing issues with webview size > - > > Key: CB-11191 > URL: https://issues.apache.org/jira/browse/CB-11191 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: Cordova CLI Version: 6.1.1 > Cordova iOS Engine: 4.1.1 > Build environment: OSX El Capitan & XCode 7.3 > Device experiencing problem: iPod Touch running iOS 9.3.1 >Reporter: Dave Philipson > Labels: ios > > It appears the statusbar plugin is causing issues with the iOS webview on > small form factor devices (iPhone & iPod) when switching orientation whilst > the camera is open (camera opened using cordova camera plugin) > Steps to reproduce: > Start the application and begin using it in landscape > Open the camera using the cordova camera plugin > Whilst the camera is open, rotate into portrait > Close the camera > Webview is now squashed down the left of the screen (only fills about 1/4 of > the screens overall width) > Can recover by changing orientation again. > Sample test app on Github: > https://github.com/ISeeBinary/statusbar_plugin_testapp > (tapping on the red square at the top of the test app page should launch the > camera) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11191) Statusbar plugin causing issues with webview size
Dave Philipson created CB-11191: --- Summary: Statusbar plugin causing issues with webview size Key: CB-11191 URL: https://issues.apache.org/jira/browse/CB-11191 Project: Apache Cordova Issue Type: Bug Components: Plugin Statusbar Affects Versions: 2.1.0 Environment: Cordova CLI Version: 6.1.1 Cordova iOS Engine: 4.1.1 Build environment: OSX El Capitan & XCode 7.3 Device experiencing problem: iPod Touch running iOS 9.3.1 Reporter: Dave Philipson It appears the statusbar plugin is causing issues with the iOS webview on small form factor devices (iPhone & iPod) when switching orientation whilst the camera is open (camera opened using cordova camera plugin) Steps to reproduce: Start the application and begin using it in landscape Open the camera using the cordova camera plugin Whilst the camera is open, rotate into portrait Close the camera Webview is now squashed down the left of the screen (only fills about 1/4 of the screens overall width) Can recover by changing orientation again. Sample test app on Github: https://github.com/ISeeBinary/statusbar_plugin_testapp -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete
[
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268282#comment-15268282
]
ASF GitHub Bot commented on CB-10653:
-
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216458424
@rakatyal, actually, I believe you need to clone it anyway to have it
available in the trigger.
My problem is more about how to serialize/marshaling such an
`WebUILaunchActivatedEventArgs` parameter so it can be used in C#, but this is
maybe off topic...
Looking forward to have this PR merged!
> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's
> onactivated event, and record the details in the platform.activationContext
> instance.
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation
> events. As an example, if an app is activated by a Cortana voice command, the
> details are missed. See here for more details:
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext,
> true);
> };
> To be:
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; //
> Backwards compatibility
> cordova.fireDocumentEvent('activated',
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
