[jira] [Commented] (CB-11203) Document CLI variables for config and plugin.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271733#comment-15271733
 ] 

ASF GitHub Bot commented on CB-11203:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/595#issuecomment-217050499
  
@nikhilkh please review.


> Document CLI variables for config and plugin.xml
> 
>
> Key: CB-11203
> URL: https://issues.apache.org/jira/browse/CB-11203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Two things are currently missing from our docs. First is that when adding 
> plugins using {{--save}}, the entry created in config.xml will have a 
> {{}} child element which we do not document anywhere. Second, we 
> do not make it clear that CLI variables can be referenced in plugin.xml using 
> the {{$VARIABLE}} syntax.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11205) Plugin Add does not respect variables saved in config.xml

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll updated CB-11205:
-
Description: 
If a plugin with CLI variables is saved using {{--save}}, the variables will be 
saved into config.xml along with the plugin spec like so:

{code}



{code}

Which corresponds to 

{code}
cordova plugin add my-plugin@1.2.0 --variable MY_VARIABLE=my_variable_value 
--save
{code}

Cordova prepare will restore the plugin using the saved plugin spec and 
variable values. Plugin add will used the saved spec, but not the saved 
variable values. Plugin add should behave the same way as prepare.

  was:
If a plugin with CLI variables is saved using {{--save}}, the variables will be 
saved into config.xml along with the plugin spec like so:

{code}



{code}

Cordova prepare will restore the plugin using the saved plugin spec and 
variable values. Plugin add will used the saved spec, but not the saved 
variable values. Plugin add should behave the same way as prepare.


> Plugin Add does not respect variables saved in config.xml
> -
>
> Key: CB-11205
> URL: https://issues.apache.org/jira/browse/CB-11205
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Richard B Knoll
>Priority: Minor
>  Labels: triaged
>
> If a plugin with CLI variables is saved using {{--save}}, the variables will 
> be saved into config.xml along with the plugin spec like so:
> {code}
> 
> 
> 
> {code}
> Which corresponds to 
> {code}
> cordova plugin add my-plugin@1.2.0 --variable MY_VARIABLE=my_variable_value 
> --save
> {code}
> Cordova prepare will restore the plugin using the saved plugin spec and 
> variable values. Plugin add will used the saved spec, but not the saved 
> variable values. Plugin add should behave the same way as prepare.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11205) Plugin Add does not respect variables saved in config.xml

[Richard B Knoll (JIRA)]

Richard B Knoll created CB-11205:


 Summary: Plugin Add does not respect variables saved in config.xml
 Key: CB-11205
 URL: https://issues.apache.org/jira/browse/CB-11205
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Reporter: Richard B Knoll
Priority: Minor


If a plugin with CLI variables is saved using {{--save}}, the variables will be 
saved into config.xml along with the plugin spec like so:

{code}



{code}

Cordova prepare will restore the plugin using the saved plugin spec and 
variable values. Plugin add will used the saved spec, but not the saved 
variable values. Plugin add should behave the same way as prepare.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11203) Document CLI variables for config and plugin.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271729#comment-15271729
 ] 

ASF GitHub Bot commented on CB-11203:
-

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/595

CB-11203: Improving documentation of plugin CLI variables



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-11203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #595


commit c3f3028f49a93f9aa8aa26043a53693d93d447a7
Author: Richard Knoll 
Date:   2016-05-05T00:52:46Z

CB-11203: Improving documentation of plugin CLI variables




> Document CLI variables for config and plugin.xml
> 
>
> Key: CB-11203
> URL: https://issues.apache.org/jira/browse/CB-11203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Two things are currently missing from our docs. First is that when adding 
> plugins using {{--save}}, the entry created in config.xml will have a 
> {{}} child element which we do not document anywhere. Second, we 
> do not make it clear that CLI variables can be referenced in plugin.xml using 
> the {{$VARIABLE}} syntax.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271663#comment-15271663
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217042218
  
 


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271660#comment-15271660
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217041794
  
Wohoo!  


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11203) Document CLI variables for config and plugin.xml

[Richard B Knoll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard B Knoll reassigned CB-11203:


Assignee: Richard B Knoll

> Document CLI variables for config and plugin.xml
> 
>
> Key: CB-11203
> URL: https://issues.apache.org/jira/browse/CB-11203
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Two things are currently missing from our docs. First is that when adding 
> plugins using {{--save}}, the entry created in config.xml will have a 
> {{}} child element which we do not document anywhere. Second, we 
> do not make it clear that CLI variables can be referenced in plugin.xml using 
> the {{$VARIABLE}} syntax.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271646#comment-15271646
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217040413
  
 


> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11204) WinJS is missing

[Martijn (JIRA)]

Martijn created CB-11204:


 Summary: WinJS is missing
 Key: CB-11204
 URL: https://issues.apache.org/jira/browse/CB-11204
 Project: Apache Cordova
  Issue Type: Bug
  Components: Windows
Affects Versions: 6.1.1
 Environment: Windows 10, VS2015
Reporter: Martijn


I installed VS2015. In the documentation, there are no further instruction on 
how to do that, so I went with the default options. All that just to get 
MSBuild installed.

So then:
{code}
npm install -g cordova
cordova create CordovaApp
cd CordovaApp
cordova platform add windows
cordova run windows
{code}
So it's a *completely virgin* project. The default's oughta work, right? Wrong:
{code}
d:\Projecten\CordovaApp>cordova run windows
Building project: 
d:\Projecten\CordovaApp\platforms\windows\CordovaApp.Windows.jsproj
Configuration : debug
Platform  : anycpu
C:\Program Files 
(x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(2049,5): error 
MSB3774: Could not find
SDK "Microsoft.WinJS.2.0, Version=1.0". 
[d:\Projecten\CordovaApp\platforms\windows\CordovaApp.Windows.jsproj]
Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with 
exit code 1
{code}
So, either a step is missing from the documentation, or it's looking for 
something that located someplace else.

Remember, all related components are *completely* default. I have NEVER touched 
ANY configuration of ANY of the involved components or code!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11196) Convert platform lists in docs XML reference to logos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271429#comment-15271429
 ] 

ASF GitHub Bot commented on CB-11196:
-

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/593#issuecomment-217001592
  
@jasongin @rakatyal @purplecabbage updated. iOS logo back to normal and new 
logo for OS X.


![new_logos_xml_2](https://cloud.githubusercontent.com/assets/13754588/15029050/adc6f10e-1200-11e6-94c7-c1010f453ad9.PNG)


![new_logos_plugin](https://cloud.githubusercontent.com/assets/13754588/15029053/b19ca5d0-1200-11e6-95db-ff007a7a92f9.PNG)




> Convert platform lists in docs XML reference to logos
> -
>
> Key: CB-11196
> URL: https://issues.apache.org/jira/browse/CB-11196
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Richard B Knoll
>Assignee: Richard B Knoll
>  Labels: triaged
>
> Overload the "mark" syntax so that writing a platform like ==android== 
> results in an Android logo appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271338#comment-15271338
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62104877
  
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --

Hmm. Maybe just name it differently. My concern is that presence of another 
`package.json` might be a bit confusing + break some tools in some scenarios


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11203) Document CLI variables for config and plugin.xml

[Richard B Knoll (JIRA)]

Richard B Knoll created CB-11203:


 Summary: Document CLI variables for config and plugin.xml
 Key: CB-11203
 URL: https://issues.apache.org/jira/browse/CB-11203
 Project: Apache Cordova
  Issue Type: Bug
  Components: Docs
Reporter: Richard B Knoll


Two things are currently missing from our docs. First is that when adding 
plugins using {{--save}}, the entry created in config.xml will have a 
{{}} child element which we do not document anywhere. Second, we do 
not make it clear that CLI variables can be referenced in plugin.xml using the 
{{$VARIABLE}} syntax.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271311#comment-15271311
 ] 

ASF GitHub Bot commented on CB-9858:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62101897
  
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --

I just copy it into temporary tests folder so I can test - - save. Any 
alternative suggestion? Should I store it somewhere else? 


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271298#comment-15271298
 ] 

ASF GitHub Bot commented on CB-9858:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62100822
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+//check if npm is installed
+isNpmInstalled();
--- End diff --

Your right. I originally has it connected to the promise change but removed 
it during a refactor. I'll fix this! 


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271297#comment-15271297
 ] 

ASF GitHub Bot commented on CB-9858:


Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62100600
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
--- End diff --

Thanks! I'll fix that


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11173) Media stream quits playing

[Martin Spriggs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271115#comment-15271115
 ] 

Martin Spriggs commented on CB-11173:
-

The behavior on these devices can be observed by attempting to stream 
http://wels.blob.core.windows.net/daily-devotions/20160502dev.mp3 from a Galaxy 
6S phone. The stream will stop at approximately 1:45 or so.








> Media stream quits playing
> --
>
> Key: CB-11173
> URL: https://issues.apache.org/jira/browse/CB-11173
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
> Environment: Samsung Galaxy Note 5, Samsung Galaxy S6
>Reporter: Martin Spriggs
>Assignee: Richard B Knoll
>Priority: Critical
>  Labels: Android, triaged
>
> Using Ionic and Angular to build an Android app that uses the Media plugin. 
> Had been working fine for over a year until Samsung's latest update to Note 5 
> and Galaxy S6. Now the media starts as usual (mp3 files hosted on Azure about 
> 5 minutes long), but stops playing about about 1:45.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271066#comment-15271066
 ] 

ASF GitHub Bot commented on CB-7:
-

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-ios/pull/220#issuecomment-216945466
  
## [Current coverage][cc-pull] is **51.81%**
> Merging [#220][cc-pull] into [master][cc-base-branch] will decrease 
coverage by **-2.75%**

```diff
@@ master   #220   diff @@
==
  Files11 11  
  Lines   821882+61   
  Methods 118131+13   
  Messages  0  0  
  Branches138143 +5   
==
+ Hits448457 +9   
- Misses  373425+52   
  Partials  0  0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[f41737d...b8652a0][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-ios/compare/f41737d014b3621247d6d5283ebd81f0c6720c31...b8652a083d839bb19c6deb7bb2649a0652883a00
[cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/220?src=pr


> Preparing platforms should skip copying files which haven't changed
> ---
>
> Key: CB-7
> URL: https://issues.apache.org/jira/browse/CB-7
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, iOS, Windows
>Reporter: Jason Ginchereau
>Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova 
> build', 'cordova run', 'cordova plugin add', and more. Every time each of 
> those commands runs, the target platform is "prepared", which involves 
> copying all files from the [/www, 
> /platforms//platform_www, /merges/] to 
> the platform's target www folder, as well as copying a bunch of icons and 
> splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. 
> But most of the time after that most of the files being copied have not 
> changed and therefore don't really need to be copied again. So the typical 
> developer inner loop (edit a few source files, build and run the app, repeat) 
> is a lot slower than it could be for a Cordova project, especially one that 
> includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't 
> changed, based on their last-modified timestamp. (But also there should still 
> be a way to force a clean/full/non-incremental build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11151) Image Download issue in iOS using cordova plugin

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11151:
---
Component/s: Plugin File Transfer

> Image Download issue in iOS using cordova plugin
> 
>
> Key: CB-11151
> URL: https://issues.apache.org/jira/browse/CB-11151
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File Transfer
> Environment: iOS platform using ionic framework.
> Cordova 5.3.3
> cordova-plugin-file transfer 1.5.0
>Reporter: Sohitri Sen
>
> I am facing an issue with Cordova-plugin-file transfer version 1.5.0. I am 
> trying to download images from API call into the phone memory using ionic 
> Framework. It works fine in Android platform, but i am facing a strange 
> occasional error in case of iOS platform. 
> Error in Success callbackId: FileTransfer552364304 : 
> TypeError: null is not an object (evaluating 'result.lengthComputable')
> callbackFromNative 
> cordova.js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Reopened] (CB-11164) plugins update

[Dean Le (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dean Le reopened CB-11164:
--

I already tried to remove cordova-plugin-media, and re-added it. 
cordova-plugin-file will not be updated to the latest but saying "already 
installed".

My point of view is this design needs to be changed as it's not working. My 
suggestion is for dependencies, a warning message to developers is good enough. 
They must pay attention to what they are installing/removing. Currently can't 
remove/update plugins that have been installed.

> plugins update
> --
>
> Key: CB-11164
> URL: https://issues.apache.org/jira/browse/CB-11164
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.1.0
> Environment: cordova CLI
>Reporter: Dean Le
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When we got a list of updated plugins, I can't update cordova-plugin-file. It 
> keeps looping in the between plugins below saying that "You can't remove 
> because this plugin... is required for other plugin" even with -f or 
> --force option.
> We can only update plugins by add/remove command though. I thought it's 
> developer responsibility to know which plugins for what. Or at least a 
> warning message (it does warn) but allow the plugin to be removed and 
> re-added.
> ---
> cordova-plugin-camera
> cordova-plugin-file
> cordova-plugin-media
> cordova-plugin-compat



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11202) OnlineEvent Bridge is not thread safe and does not support Embedded WebView Use Case

[Joe Bowser (JIRA)]

Joe Bowser created CB-11202:
---

 Summary: OnlineEvent Bridge is not thread safe and does not 
support Embedded WebView Use Case
 Key: CB-11202
 URL: https://issues.apache.org/jira/browse/CB-11202
 Project: Apache Cordova
  Issue Type: Bug
Reporter: Joe Bowser
Assignee: Joe Bowser
Priority: Critical


OnlineEvents bridge isn't thread safe, so we need a bridge that is threadsafe.  
This one doesn't work well with ICS, but we should probably have it anyway.

https://github.com/phonegap/cordova-android/tree/building_bridges

We plan on making this the default bridge on the next major version of Cordova, 
and this breaks the API for embedding webviews.  That said, it takes only one 
line for Crosswalk to support this new bridge mode.  This is why we're making a 
Cordova-Android 6.0.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271001#comment-15271001
 ] 

Nikhil Khandelwal commented on CB-11154:


That will be a breaking change if we integrate it - perhaps we can add another 
property that will be in the IANA format.

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11194) Improve cordova load time

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270998#comment-15270998
 ] 

ASF GitHub Bot commented on CB-11194:
-

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-lib/pull/434#issuecomment-216933920
  
## [Current coverage][cc-pull] is **80.71%**
> Merging [#434][cc-pull] into [master][cc-base-branch] will increase 
coverage by **+1.09%**

```diff
@@ master   #434   diff @@
==
  Files69 68 -1   
  Lines  5399   5323-76   
  Methods 865849-16   
  Messages  0  0  
  Branches   1017   1011 -6   
==
- Hits   4298   4296 -2   
+ Misses 1101   1027-74   
  Partials  0  0  
```

1. File `...lugman/browserify.js` (not in diff) was deleted. 
[more](https://codecov.io/gh/apache/cordova-lib/commit/f4ec82b8cec151ad81962e10f8d4a223a1dcdaac/changes?src=pr#636F72646F76612D6C69622F7372632F706C75676D616E2F62726F777365726966792E6A73)


> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[cc83559...f4ec82b][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-lib/compare/cc83559597db1a7367252c808bc05b697aea52db...f4ec82b8cec151ad81962e10f8d4a223a1dcdaac
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/434?src=pr


> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11154) Why timezone is not IANA ?

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11154:
---
Labels: triaged  (was: )

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11157) Anchor link in TOC are not working

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11157:
---
Summary: Anchor link in TOC are not working  (was: Anchor links in TOC are 
not working)

> Anchor link in TOC are not working
> --
>
> Key: CB-11157
> URL: https://issues.apache.org/jira/browse/CB-11157
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Nikhil Khandelwal
>Priority: Minor
>
> Anchor link in TOC for this anchor is not working:
> Navigate to: 
> http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html
> In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from 
> the Picture Library, and Get Thumbnails 
> ACTUAL RESULTS: navigation will not succeed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11157) Anchor links in TOC are not working

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11157:
---
Description: 
Anchor link in TOC for this anchor is not working:


Navigate to: 
http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html

In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from the 
Picture Library, and Get Thumbnails 

ACTUAL RESULTS: navigation will not succeed.


  was:
Anchor link in TOC for this anchor is not working:

http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html#sample:-take-pictures-select-pictures-from-the-picture-library-and-get-thumbnails-



> Anchor links in TOC are not working
> ---
>
> Key: CB-11157
> URL: https://issues.apache.org/jira/browse/CB-11157
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Nikhil Khandelwal
>Priority: Minor
>
> Anchor link in TOC for this anchor is not working:
> Navigate to: 
> http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html
> In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from 
> the Picture Library, and Get Thumbnails 
> ACTUAL RESULTS: navigation will not succeed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11157) Anchor link in TOC are not working

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11157:
---
Description: 
Anchor link in TOC for this anchor is not working:


Navigate to: 
http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html

In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from the 
Picture Library, and Get Thumbnails 

ACTUAL RESULT: navigation will not succeed.


  was:
Anchor link in TOC for this anchor is not working:


Navigate to: 
http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html

In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from the 
Picture Library, and Get Thumbnails 

ACTUAL RESULTS: navigation will not succeed.



> Anchor link in TOC are not working
> --
>
> Key: CB-11157
> URL: https://issues.apache.org/jira/browse/CB-11157
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Docs
>Reporter: Nikhil Khandelwal
>Priority: Minor
>
> Anchor link in TOC for this anchor is not working:
> Navigate to: 
> http://cordova.apache.org/docs/en/latest/reference/cordova-plugin-camera/index.html
> In the TOC: Click on this link: Sample: Take Pictures, Select Pictures from 
> the Picture Library, and Get Thumbnails 
> ACTUAL RESULT: navigation will not succeed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11158) Debugging with inappbrowser can result in a broken webview debugger

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11158:
---
Labels: triaged  (was: )

> Debugging with inappbrowser can result in a broken webview debugger
> ---
>
> Key: CB-11158
> URL: https://issues.apache.org/jira/browse/CB-11158
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.2.0
> Environment: Android 4.4
>Reporter: Jimmy Thomson
>Priority: Minor
>  Labels: triaged
> Attachments: repro.zip
>
>
> When attempting to debug a callback in inappbrowser, I found that a 
> particular sequence of events would result in the webview no longer 
> responding to the debugger. The app itself appears to work, but neither 
> chrome nor visual studio are able to debug the app.
> I am going to upload a repro file and give steps relative to the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11158) Debugging with inappbrowser can result in a broken webview debugger

[Jimmy Thomson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270984#comment-15270984
 ] 

Jimmy Thomson commented on CB-11158:


The reason I report it here is it only seems to happen with the inappbrowser 
plugin, and I thought that there may be either a bug in how inappbrowser 
operates, or a potential workaround for whatever underlying issue the webview 
has.

> Debugging with inappbrowser can result in a broken webview debugger
> ---
>
> Key: CB-11158
> URL: https://issues.apache.org/jira/browse/CB-11158
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.2.0
> Environment: Android 4.4
>Reporter: Jimmy Thomson
>Priority: Minor
> Attachments: repro.zip
>
>
> When attempting to debug a callback in inappbrowser, I found that a 
> particular sequence of events would result in the webview no longer 
> responding to the debugger. The app itself appears to work, but neither 
> chrome nor visual studio are able to debug the app.
> I am going to upload a repro file and give steps relative to the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11158) Debugging with inappbrowser can result in a broken webview debugger

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270981#comment-15270981
 ] 

Nikhil Khandelwal commented on CB-11158:


Why is this a Cordova issue? Sounds like an issue with Android webview.

> Debugging with inappbrowser can result in a broken webview debugger
> ---
>
> Key: CB-11158
> URL: https://issues.apache.org/jira/browse/CB-11158
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.2.0
> Environment: Android 4.4
>Reporter: Jimmy Thomson
>Priority: Minor
> Attachments: repro.zip
>
>
> When attempting to debug a callback in inappbrowser, I found that a 
> particular sequence of events would result in the webview no longer 
> responding to the debugger. The app itself appears to work, but neither 
> chrome nor visual studio are able to debug the app.
> I am going to upload a repro file and give steps relative to the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11160) Windows phone 8.1 apps cannot access remote resources

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270979#comment-15270979
 ] 

Nikhil Khandelwal commented on CB-11160:


This is a limitation of Windows app model in 8.1 - this is improved now in 
Windows 10 with the ms-appx-web:// option. 

For windows 8.1 you can use an x-ms-webview but that will not have access to 
any plugin/WinRT APIs.

There is not much that Cordova can do here.

> Windows phone 8.1 apps cannot access remote resources
> -
>
> Key: CB-11160
> URL: https://issues.apache.org/jira/browse/CB-11160
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
> Environment: I'm using Visual Studio 2015 update 2 with Tools For 
> Apache Cordova 8, OS Windows 8.1 Professional
>Reporter: Fabio Cristini
>  Labels: windows, wp8
>
> Running my app on 8.1 or Windows Phone 8.1, compiled for platform Windows, 
> lead to a problem accessing remote javascript.
> Javascript console report
> APPHOST9601: Can’t load . An app can’t load 
> remote web content in the local context.
> Putting
> 
> 
> 
> in config.xml doesn't help, since this information is not placed in 
> appxmanifest
> I'm not able to use my app compiled using this configuration, while compiled 
> for platform wp8 (deprecated) is still ok.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11160) Windows phone 8.1 apps cannot access remote resources

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal resolved CB-11160.

Resolution: Won't Fix

> Windows phone 8.1 apps cannot access remote resources
> -
>
> Key: CB-11160
> URL: https://issues.apache.org/jira/browse/CB-11160
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
> Environment: I'm using Visual Studio 2015 update 2 with Tools For 
> Apache Cordova 8, OS Windows 8.1 Professional
>Reporter: Fabio Cristini
>  Labels: windows, wp8
>
> Running my app on 8.1 or Windows Phone 8.1, compiled for platform Windows, 
> lead to a problem accessing remote javascript.
> Javascript console report
> APPHOST9601: Can’t load . An app can’t load 
> remote web content in the local context.
> Putting
> 
> 
> 
> in config.xml doesn't help, since this information is not placed in 
> appxmanifest
> I'm not able to use my app compiled using this configuration, while compiled 
> for platform wp8 (deprecated) is still ok.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11164) plugins update

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal resolved CB-11164.

Resolution: Not A Bug

> plugins update
> --
>
> Key: CB-11164
> URL: https://issues.apache.org/jira/browse/CB-11164
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.1.0
> Environment: cordova CLI
>Reporter: Dean Le
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When we got a list of updated plugins, I can't update cordova-plugin-file. It 
> keeps looping in the between plugins below saying that "You can't remove 
> because this plugin... is required for other plugin" even with -f or 
> --force option.
> We can only update plugins by add/remove command though. I thought it's 
> developer responsibility to know which plugins for what. Or at least a 
> warning message (it does warn) but allow the plugin to be removed and 
> re-added.
> ---
> cordova-plugin-camera
> cordova-plugin-file
> cordova-plugin-media
> cordova-plugin-compat



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11164) plugins update

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270975#comment-15270975
 ] 

Nikhil Khandelwal commented on CB-11164:


This is by design - I'm not sure we can do much here. Should consider re-adding 
the media plugin and the latest file plugin will also get added.

> plugins update
> --
>
> Key: CB-11164
> URL: https://issues.apache.org/jira/browse/CB-11164
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.1.0
> Environment: cordova CLI
>Reporter: Dean Le
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When we got a list of updated plugins, I can't update cordova-plugin-file. It 
> keeps looping in the between plugins below saying that "You can't remove 
> because this plugin... is required for other plugin" even with -f or 
> --force option.
> We can only update plugins by add/remove command though. I thought it's 
> developer responsibility to know which plugins for what. Or at least a 
> warning message (it does warn) but allow the plugin to be removed and 
> re-added.
> ---
> cordova-plugin-camera
> cordova-plugin-file
> cordova-plugin-media
> cordova-plugin-compat



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270968#comment-15270968
 ] 

Nikhil Khandelwal commented on CB-11167:


I see you are using the browser platform.

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11167:
---
Comment: was deleted

(was: [~rakatyal] Can you please help triage?)

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270966#comment-15270966
 ] 

Nikhil Khandelwal commented on CB-11167:


[~rakatyal] Can you please help triage?

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11167:
---
Labels: browser triaged  (was: browser)

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11167:
---
Component/s: (was: CordovaJS)

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11167) Trying to use truncate produces an "Error: exec proxy not found for :: File :: truncate" error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11167:
---
Component/s: Plugin File

> Trying to use truncate produces an "Error: exec proxy not found for :: File 
> :: truncate" error
> --
>
> Key: CB-11167
> URL: https://issues.apache.org/jira/browse/CB-11167
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 6.1.1
> Environment: Windows 7
> Firefox 46
>Reporter: Pawel
>  Labels: browser, triaged
>
> As in title - when trying to call `truncate` on a FileWriter for existing 
> FileEntry will cause `Error: exec proxy not found for :: File :: truncate` 
> error. Same code works fine in Chrome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11173) Media stream quits playing

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11173:
---
Priority: Critical  (was: Major)

> Media stream quits playing
> --
>
> Key: CB-11173
> URL: https://issues.apache.org/jira/browse/CB-11173
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
> Environment: Samsung Galaxy Note 5, Samsung Galaxy S6
>Reporter: Martin Spriggs
>Assignee: Richard B Knoll
>Priority: Critical
>  Labels: Android, triaged
>
> Using Ionic and Angular to build an Android app that uses the Media plugin. 
> Had been working fine for over a year until Samsung's latest update to Note 5 
> and Galaxy S6. Now the media starts as usual (mp3 files hosted on Azure about 
> 5 minutes long), but stops playing about about 1:45.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11173) Media stream quits playing

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11173:
---
Assignee: Richard B Knoll

> Media stream quits playing
> --
>
> Key: CB-11173
> URL: https://issues.apache.org/jira/browse/CB-11173
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
> Environment: Samsung Galaxy Note 5, Samsung Galaxy S6
>Reporter: Martin Spriggs
>Assignee: Richard B Knoll
>  Labels: Android, triaged
>
> Using Ionic and Angular to build an Android app that uses the Media plugin. 
> Had been working fine for over a year until Samsung's latest update to Note 5 
> and Galaxy S6. Now the media starts as usual (mp3 files hosted on Azure about 
> 5 minutes long), but stops playing about about 1:45.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11173) Media stream quits playing

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11173:
---
Labels: Android triaged  (was: Android)

> Media stream quits playing
> --
>
> Key: CB-11173
> URL: https://issues.apache.org/jira/browse/CB-11173
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
> Environment: Samsung Galaxy Note 5, Samsung Galaxy S6
>Reporter: Martin Spriggs
>  Labels: Android, triaged
>
> Using Ionic and Angular to build an Android app that uses the Media plugin. 
> Had been working fine for over a year until Samsung's latest update to Note 5 
> and Galaxy S6. Now the media starts as usual (mp3 files hosted on Azure about 
> 5 minutes long), but stops playing about about 1:45.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11190) Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11190:
---
Labels: easyfix ios triaged  (was: ios triaged)

> Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0
> -
>
> Key: CB-11190
> URL: https://issues.apache.org/jira/browse/CB-11190
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: XCode 7.3
>Reporter: Danilo Cicognani
>  Labels: easyfix, ios, triaged
>
> After adding plugin Geolocation XCode 7.3 repors some warning.
> To test I created a test app:
> cordova create testPlugin com.example.testplugin testPlugin
> cd testPlugin
> cordova platform add ios
> cordova plugin add cordova-plugin-geolocation
> Then I opened XCode and run the App. I got these warnings:
> 'kCLAuthorizationStatusAuthorized' is deprecated: first deprecated in iOS 8.0 
> - Use kCLAuthorizationStatisAuthorizedAlways
> 'locationServicesEnabled' is deprecated: first deprecated in iOS 4.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11189) Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11189:
---
Labels: easyfix ios triaged  (was: )

> Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0
> --
>
> Key: CB-11189
> URL: https://issues.apache.org/jira/browse/CB-11189
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: XCode 7.3
>Reporter: Danilo Cicognani
>  Labels: easyfix, ios, triaged
>
> After adding plugin InAppBrowser XCode 7.3 repors some warning.
> To test I created a test app:
> cordova create testPlugin com.example.testplugin testPlugin
> cd testPlugin
> cordova platform add ios
> cordova plugin add cordova-plugin-inappbrowser
> Then I opened XCode and run the App. I got these warnings:
> 'UIBarButtonItemStyleBordered' is deprecated: first deprecated in iOS 8.0 - 
> Use UIBarButtonItemStylePlain when minimum deployment target is iOS7 or later.
> Null passed to a callee that requires a non-null argument
> Conflicting return type in implementation of 'supported interface 
> orientations': 'UIInterfaceOrientationMask' (aka 'enum 
> UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned int')



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11189) Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11189:
---
Summary: Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0  (was: 
Warnings with XCode 7.3 and InAppBrowser 1.4.0)

> Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0
> --
>
> Key: CB-11189
> URL: https://issues.apache.org/jira/browse/CB-11189
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
> Environment: XCode 7.3
>Reporter: Danilo Cicognani
>  Labels: easyfix, ios, triaged
>
> After adding plugin InAppBrowser XCode 7.3 repors some warning.
> To test I created a test app:
> cordova create testPlugin com.example.testplugin testPlugin
> cd testPlugin
> cordova platform add ios
> cordova plugin add cordova-plugin-inappbrowser
> Then I opened XCode and run the App. I got these warnings:
> 'UIBarButtonItemStyleBordered' is deprecated: first deprecated in iOS 8.0 - 
> Use UIBarButtonItemStylePlain when minimum deployment target is iOS7 or later.
> Null passed to a callee that requires a non-null argument
> Conflicting return type in implementation of 'supported interface 
> orientations': 'UIInterfaceOrientationMask' (aka 'enum 
> UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned int')



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11190) Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11190:
---
Summary: Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0  (was: 
Warnings with XCode 7.3 and Geolocation 2.2.0)

> Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0
> -
>
> Key: CB-11190
> URL: https://issues.apache.org/jira/browse/CB-11190
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: XCode 7.3
>Reporter: Danilo Cicognani
>  Labels: ios, triaged
>
> After adding plugin Geolocation XCode 7.3 repors some warning.
> To test I created a test app:
> cordova create testPlugin com.example.testplugin testPlugin
> cd testPlugin
> cordova platform add ios
> cordova plugin add cordova-plugin-geolocation
> Then I opened XCode and run the App. I got these warnings:
> 'kCLAuthorizationStatusAuthorized' is deprecated: first deprecated in iOS 8.0 
> - Use kCLAuthorizationStatisAuthorizedAlways
> 'locationServicesEnabled' is deprecated: first deprecated in iOS 4.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11190) Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11190:
---
Labels: ios triaged  (was: )

> Deprecation Warnings with XCode 7.3 and Geolocation 2.2.0
> -
>
> Key: CB-11190
> URL: https://issues.apache.org/jira/browse/CB-11190
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation
>Affects Versions: 2.2.0
> Environment: XCode 7.3
>Reporter: Danilo Cicognani
>  Labels: ios, triaged
>
> After adding plugin Geolocation XCode 7.3 repors some warning.
> To test I created a test app:
> cordova create testPlugin com.example.testplugin testPlugin
> cd testPlugin
> cordova platform add ios
> cordova plugin add cordova-plugin-geolocation
> Then I opened XCode and run the App. I got these warnings:
> 'kCLAuthorizationStatusAuthorized' is deprecated: first deprecated in iOS 8.0 
> - Use kCLAuthorizationStatisAuthorizedAlways
> 'locationServicesEnabled' is deprecated: first deprecated in iOS 4.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11191) Statusbar plugin causing issues with webview size

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11191:
---
Labels: ios triaged  (was: ios)

> Statusbar plugin causing issues with webview size
> -
>
> Key: CB-11191
> URL: https://issues.apache.org/jira/browse/CB-11191
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: Cordova CLI Version: 6.1.1
> Cordova iOS Engine: 4.1.1
> Build environment: OSX El Capitan & XCode 7.3
> Device experiencing problem: iPod Touch running iOS 9.3.1
>Reporter: Dave Philipson
>Assignee: Sergey Shakhnazarov
>  Labels: ios, triaged
>
> It appears the statusbar plugin is causing issues with the iOS webview on 
> small form factor devices (iPhone & iPod) when switching orientation whilst 
> the camera is open (camera opened using cordova camera plugin)
> Steps to reproduce:
> Start the application and begin using it in landscape
> Open the camera using the cordova camera plugin
> Whilst the camera is open, rotate into portrait
> Close the camera
> Webview is now squashed down the left of the screen (only fills about 1/4 of 
> the screens overall width)
> Can recover by changing orientation again.
> Sample test app on Github:
> https://github.com/ISeeBinary/statusbar_plugin_testapp
> (tapping on the red square at the top of the test app page should launch the 
> camera)
> Removing the statusbar plugin rectifies the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11191) Statusbar plugin causing issues with webview size

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11191:
---
Assignee: Sergey Shakhnazarov

> Statusbar plugin causing issues with webview size
> -
>
> Key: CB-11191
> URL: https://issues.apache.org/jira/browse/CB-11191
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: Cordova CLI Version: 6.1.1
> Cordova iOS Engine: 4.1.1
> Build environment: OSX El Capitan & XCode 7.3
> Device experiencing problem: iPod Touch running iOS 9.3.1
>Reporter: Dave Philipson
>Assignee: Sergey Shakhnazarov
>  Labels: ios, triaged
>
> It appears the statusbar plugin is causing issues with the iOS webview on 
> small form factor devices (iPhone & iPod) when switching orientation whilst 
> the camera is open (camera opened using cordova camera plugin)
> Steps to reproduce:
> Start the application and begin using it in landscape
> Open the camera using the cordova camera plugin
> Whilst the camera is open, rotate into portrait
> Close the camera
> Webview is now squashed down the left of the screen (only fills about 1/4 of 
> the screens overall width)
> Can recover by changing orientation again.
> Sample test app on Github:
> https://github.com/ISeeBinary/statusbar_plugin_testapp
> (tapping on the red square at the top of the test app page should launch the 
> camera)
> Removing the statusbar plugin rectifies the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11199) Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11199:
---
Summary: Plugin File: FileReader readAsDataURL does not work with JPG on 
Android 4.4.2  (was: File plugin FileReader readAsDataURL)

> Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2
> -
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>  Labels: Android, triaged, wfc
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11195) Windows platform - create windows 10 app packages - BOM error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11195:
---
Summary: Windows platform - create windows 10 app packages - BOM error  
(was: Windows platform - create windows 10 app packages)

> Windows platform - create windows 10 app packages - BOM error
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
>Assignee: Raghav Katyal
>  Labels: triaged
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
>  has JavaScript syntax or other problems.
> ...
> Impact if not fixed: As a performance optimization to accelerate JavaScript 
> execution time, JavaScript files ending in the ".js" extension generate 
> bytecode when the app is deployed. This optimization significantly improves 
> start-up and ongoing execution times for JavaScript.
> How to fix: You may need consider one or more of these steps to fix the issue:
> - Avoid deploying the app by pressing F5 in Visual Studio, create an appx 
> package instead
> - Ensure that event logging is enabled
> - All JavaScript files are syntactically valid; otherwise exclude the 
> respective files from the package
> - Please note that you should uninstall all previous versions of the app 
> before deploying
> Otherwise exclude the respective files from the package.
> {code}
> Can the app be submitted with this erros?
> Should not the cordova generate the project ready for publication?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11195) Windows platform - create windows 10 app packages - BOM error

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11195:
---
Labels: triaged  (was: )

> Windows platform - create windows 10 app packages - BOM error
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
>Assignee: Raghav Katyal
>  Labels: triaged
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
>  has JavaScript syntax or other problems.
> ...
> Impact if not fixed: As a performance optimization to accelerate JavaScript 
> execution time, JavaScript files ending in the ".js" extension generate 
> bytecode when the app is deployed. This optimization significantly improves 
> start-up and ongoing execution times for JavaScript.
> How to fix: You may need consider one or more of these steps to fix the issue:
> - Avoid deploying the app by pressing F5 in Visual Studio, create an appx 
> package instead
> - Ensure that event logging is enabled
> - All JavaScript files are syntactically valid; otherwise exclude the 
> respective files from the package
> - Please note that you should uninstall all previous versions of the app 
> before deploying
> Otherwise exclude the respective files from the package.
> {code}
> Can the app be submitted with this erros?
> Should not the cordova generate the project ready for publication?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11195) Windows platform - create windows 10 app packages

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11195:
---
Assignee: Raghav Katyal

> Windows platform - create windows 10 app packages
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
>Assignee: Raghav Katyal
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
>  has JavaScript syntax or other problems.
> ...
> Impact if not fixed: As a performance optimization to accelerate JavaScript 
> execution time, JavaScript files ending in the ".js" extension generate 
> bytecode when the app is deployed. This optimization significantly improves 
> start-up and ongoing execution times for JavaScript.
> How to fix: You may need consider one or more of these steps to fix the issue:
> - Avoid deploying the app by pressing F5 in Visual Studio, create an appx 
> package instead
> - Ensure that event logging is enabled
> - All JavaScript files are syntactically valid; otherwise exclude the 
> respective files from the package
> - Please note that you should uninstall all previous versions of the app 
> before deploying
> Otherwise exclude the respective files from the package.
> {code}
> Can the app be submitted with this erros?
> Should not the cordova generate the project ready for publication?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11197:
---
Assignee: Vladimir Kotikov

> Android status bar appears when keyboard pops up.
> -
>
> Key: CB-11197
> URL: https://issues.apache.org/jira/browse/CB-11197
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: {code}
> cordova 6.1.1
> cordova-plugin-console 1.0.2 "Console"
> cordova-plugin-device 1.1.0 "Device"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-statusbar 2.1.3 "StatusBar"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> {code}
>Reporter: David Hooey
>Assignee: Vladimir Kotikov
>  Labels: regression, triaged
>
> When configuring for full screen app, the statusbar will appear when the 
> keyboard pops up for input. The iOS build is fine. The previous version 
> {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem.
> {code}
> 
> 
> 
> {code}
> Also mentioned in this 
> [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11197) Android status bar appears when keyboard pops up.

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270955#comment-15270955
 ] 

Nikhil Khandelwal commented on CB-11197:


[~vladimir.kotikov] Did this change cause a regression here? 
https://github.com/apache/cordova-plugin-statusbar/commit/a4a1065c4f47243f835f195c8359f33c2379922a


> Android status bar appears when keyboard pops up.
> -
>
> Key: CB-11197
> URL: https://issues.apache.org/jira/browse/CB-11197
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: {code}
> cordova 6.1.1
> cordova-plugin-console 1.0.2 "Console"
> cordova-plugin-device 1.1.0 "Device"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-statusbar 2.1.3 "StatusBar"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> {code}
>Reporter: David Hooey
>  Labels: regression, triaged
>
> When configuring for full screen app, the statusbar will appear when the 
> keyboard pops up for input. The iOS build is fine. The previous version 
> {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem.
> {code}
> 
> 
> 
> {code}
> Also mentioned in this 
> [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11197:
---
Labels: regression triaged  (was: )

> Android status bar appears when keyboard pops up.
> -
>
> Key: CB-11197
> URL: https://issues.apache.org/jira/browse/CB-11197
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: {code}
> cordova 6.1.1
> cordova-plugin-console 1.0.2 "Console"
> cordova-plugin-device 1.1.0 "Device"
> cordova-plugin-file 3.0.0 "File"
> cordova-plugin-file-transfer 1.4.0 "File Transfer"
> cordova-plugin-statusbar 2.1.3 "StatusBar"
> cordova-plugin-whitelist 1.2.0 "Whitelist"
> {code}
>Reporter: David Hooey
>  Labels: regression, triaged
>
> When configuring for full screen app, the statusbar will appear when the 
> keyboard pops up for input. The iOS build is fine. The previous version 
> {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem.
> {code}
> 
> 
> 
> {code}
> Also mentioned in this 
> [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11199) Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11199:
---
Labels: Android triaged wfc  (was: Android triaged)

> Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2
> -
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>  Labels: Android, triaged, wfc
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11199) File plugin FileReader readAsDataURL

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11199:
---
Priority: Major  (was: Critical)

> File plugin FileReader readAsDataURL
> 
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>  Labels: Android, triaged
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11199) File plugin FileReader readAsDataURL

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11199:
---
Labels: Android triaged  (was: Android)

> File plugin FileReader readAsDataURL
> 
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>Priority: Critical
>  Labels: Android, triaged
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11199) File plugin FileReader readAsDataURL

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270952#comment-15270952
 ] 

Nikhil Khandelwal commented on CB-11199:


Can you share a snippet of code that you are using?

> File plugin FileReader readAsDataURL
> 
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>Priority: Critical
>  Labels: Android, triaged
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11199) File plugin FileReader readAsDataURL

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11199:
---
Labels: Android  (was: )

> File plugin FileReader readAsDataURL
> 
>
> Key: CB-11199
> URL: https://issues.apache.org/jira/browse/CB-11199
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Affects Versions: 4.2.0
> Environment: Android 4.4.2
>Reporter: Caner Patır
>Priority: Critical
>  Labels: Android
>
> FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. 
> I could not decode the generate base64 data. But iI tried the same situation 
> on version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11200) Cordova-lib test failure on Node 6.0.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11200:
---
Labels: triaged  (was: )

> Cordova-lib test failure on Node 6.0.0
> --
>
> Key: CB-11200
> URL: https://issues.apache.org/jira/browse/CB-11200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
> Environment: Windows, OSX
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>  Labels: triaged
>
> When running "npm test" in cordova-lib folder, the following test fails on 
> Node 6.0.0:
> {noformat}
>   1) ios project handler uninstallation of  elements with 
> custom="true" attribute should rm the file from the right target location
>Message:
>  TypeError: Path must be a string. Received undefined
>Stacktrace:
>  TypeError: Path must be a string. Received undefined
> at assertPath (path.js:7:11)
> at Object.dirname (path.js:697:5)
> at searchPathForFile 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
> at pbxProject.removeFromFrameworkSearchPaths 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
> at pbxProject.removeFramework 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
> at Object.module.exports.framework.uninstall 
> (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
> at . 
> (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
> {noformat}
> Initial investigation points out that the bug in node-xcode can be the cause 
> of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11200) Cordova-lib test failure on Node 6.0.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11200:
---
Priority: Critical  (was: Major)

> Cordova-lib test failure on Node 6.0.0
> --
>
> Key: CB-11200
> URL: https://issues.apache.org/jira/browse/CB-11200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
> Environment: Windows, OSX
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>Priority: Critical
>  Labels: triaged
>
> When running "npm test" in cordova-lib folder, the following test fails on 
> Node 6.0.0:
> {noformat}
>   1) ios project handler uninstallation of  elements with 
> custom="true" attribute should rm the file from the right target location
>Message:
>  TypeError: Path must be a string. Received undefined
>Stacktrace:
>  TypeError: Path must be a string. Received undefined
> at assertPath (path.js:7:11)
> at Object.dirname (path.js:697:5)
> at searchPathForFile 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
> at pbxProject.removeFromFrameworkSearchPaths 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
> at pbxProject.removeFramework 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
> at Object.module.exports.framework.uninstall 
> (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
> at . 
> (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
> {noformat}
> Initial investigation points out that the bug in node-xcode can be the cause 
> of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11200) Cordova-lib test failure on Node 6.0.0

[Nikhil Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270951#comment-15270951
 ] 

Nikhil Khandelwal commented on CB-11200:


After we fix this - we should ensure travis runs these tests with node 6.0 in 
addition to other older versions of node.

> Cordova-lib test failure on Node 6.0.0
> --
>
> Key: CB-11200
> URL: https://issues.apache.org/jira/browse/CB-11200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
> Environment: Windows, OSX
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>
> When running "npm test" in cordova-lib folder, the following test fails on 
> Node 6.0.0:
> {noformat}
>   1) ios project handler uninstallation of  elements with 
> custom="true" attribute should rm the file from the right target location
>Message:
>  TypeError: Path must be a string. Received undefined
>Stacktrace:
>  TypeError: Path must be a string. Received undefined
> at assertPath (path.js:7:11)
> at Object.dirname (path.js:697:5)
> at searchPathForFile 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
> at pbxProject.removeFromFrameworkSearchPaths 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
> at pbxProject.removeFramework 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
> at Object.module.exports.framework.uninstall 
> (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
> at . 
> (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
> {noformat}
> Initial investigation points out that the bug in node-xcode can be the cause 
> of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11200) Cordova-lib test failure on Node 6.0.0

[Nikhil Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Khandelwal updated CB-11200:
---
Assignee: Vladimir Kotikov

> Cordova-lib test failure on Node 6.0.0
> --
>
> Key: CB-11200
> URL: https://issues.apache.org/jira/browse/CB-11200
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: Master
> Environment: Windows, OSX
>Reporter: Alexander Sorokin
>Assignee: Vladimir Kotikov
>
> When running "npm test" in cordova-lib folder, the following test fails on 
> Node 6.0.0:
> {noformat}
>   1) ios project handler uninstallation of  elements with 
> custom="true" attribute should rm the file from the right target location
>Message:
>  TypeError: Path must be a string. Received undefined
>Stacktrace:
>  TypeError: Path must be a string. Received undefined
> at assertPath (path.js:7:11)
> at Object.dirname (path.js:697:5)
> at searchPathForFile 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
> at pbxProject.removeFromFrameworkSearchPaths 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
> at pbxProject.removeFramework 
> (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
> at Object.module.exports.framework.uninstall 
> (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
> at . 
> (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
> {noformat}
> Initial investigation points out that the bug in node-xcode can be the cause 
> of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11194) Improve cordova load time

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270917#comment-15270917
 ] 

ASF GitHub Bot commented on CB-11194:
-

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/434#discussion_r62068625
  
--- Diff: cordova-lib/cordova-lib.js ---
@@ -18,19 +18,35 @@
 */
 
 // For now expose plugman and cordova just as they were in the old repos
+
+
+function addProperty(obj, property, modulePath) {
--- End diff --

Nice, that should definitely be consolidated. It will have to be moved into 
cordova-common though.


> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11195) Windows platform - create windows 10 app packages

[napcat (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270681#comment-15270681
 ] 

napcat edited comment on CB-11195 at 5/4/16 4:20 PM:
-

I made a cordova hook that run on "after_build".

The scripts reads and writes again the .js files on the utf8 encoding system.

I used "iconv-lite" and "glob" as dependencies.

{code:javascript}
#!/usr/bin/env node

module.exports = function(context) 
{
var path = context.requireCordovaModule('path');
var fs = context.requireCordovaModule('fs');

var iconvlite = require('iconv-lite');
var glob = require("glob");

var appxManifestPath = path.join(context.opts.projectRoot, 
'\\platforms\\windows\\www\\');

console.log("AppxManifestPath: " + appxManifestPath);

if (fs.existsSync(appxManifestPath))
{
glob(appxManifestPath + "**/*.js", function (er, files) 
{
files.forEach(function(filePath) 
{
var file = fs.readFileSync(filePath);

var buffer = iconvlite.encode(file, "utf8");

fs.writeFile(filePath, buffer.toString('utf8'), 'utf8', 
function (error)
{
if (error) 
throw new error('error saving file as utf8: ' + 
filePath + " " + error);
});
});
});
}
};
{code}


was (Author: napcat):
I made a cordova hook that run on "after_prepare".

The scripts reads and writes again the .js files on the utf8 encoding system.

I used "iconv-lite" and "glob" as dependencies.

{code:javascript}
#!/usr/bin/env node

module.exports = function(context) 
{
var path = context.requireCordovaModule('path');
var fs = context.requireCordovaModule('fs');

var iconvlite = require('iconv-lite');
var glob = require("glob");

var appxManifestPath = path.join(context.opts.projectRoot, 
'\\platforms\\windows\\www\\');

console.log("AppxManifestPath: " + appxManifestPath);

if (fs.existsSync(appxManifestPath))
{
glob(appxManifestPath + "**/*.js", function (er, files) 
{
files.forEach(function(filePath) 
{
var file = fs.readFileSync(filePath);

var buffer = iconvlite.encode(file, "utf8");

fs.writeFile(filePath, buffer.toString('utf8'), 'utf8', 
function (error)
{
if (error) 
throw new error('error saving file as utf8: ' + 
filePath + " " + error);
});
});
});
}
};
{code}

> Windows platform - create windows 10 app packages
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> 

[jira] [Created] (CB-11201) iOS next/prev buttons don't fire key(press/up/down) events

[cjardmore (JIRA)]

cjardmore created CB-11201:
--

 Summary: iOS next/prev buttons don't fire key(press/up/down) events
 Key: CB-11201
 URL: https://issues.apache.org/jira/browse/CB-11201
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaJS
Affects Versions: 6.1.1
 Environment: iOS 9.3.1
Reporter: cjardmore
Priority: Minor


I don't know if this is an upstream issue w/ iOS.

Within a cordova app, pressing the next/prev keys on the iOS virtual keyboard 
do not propagate a key(up/down/press) event into the app.

The prev/next keys (as far as I know) are useful to toggle from one input field 
to the next (when filling out a form).  Using any sophisticated framework (such 
as angular material) in some cases does not use native html form elements.  
These elements do not get detected by iOS when the user presses next/prev 
buttons.  So ideally the key event will fire so I can handle how the form 
fields are traversed by the next/prev buttons.

Since this event is not firing I have no option (to the best of my 
understanding) except to gracefully degrade from angular material components to 
native HTML components, and attempt to style them similarly to how the angular 
components are styled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[Sergey Shakhnazarov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Shakhnazarov resolved CB-11176.
--
Resolution: Fixed

> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270815#comment-15270815
 ] 

ASF subversion and git services commented on CB-8056:
-

Commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a in 
cordova-plugin-splashscreen's branch refs/heads/master from [~daserge]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=3d924fc
 ]

CB-8056 Updated the dependency version, added it to the docs


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8056) Implement splashscreen for Windows platform

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270816#comment-15270816
 ] 

ASF GitHub Bot commented on CB-8056:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/100


> Implement splashscreen for Windows platform
> ---
>
> Key: CB-8056
> URL: https://issues.apache.org/jira/browse/CB-8056
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin SplashScreen, Windows
>Affects Versions: 3.6.0
>Reporter: Doug Estey
>Assignee: Sergey Shakhnazarov
>  Labels: reproduced, triaged, windows
>
> {code:title=config.xml|borderStyle=solid}
> 
> 
> 
> {code}
> This has no effect on the cordova-windows platform. Splash screen autohides 
> after <1000ms.
> Tested on WP 8.1.
> Let me know if there's any other information I can provide. The documentation 
> for splash screens on 8.1 seems to be somewhat lacking, so I may have missed 
> something somewhere.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270809#comment-15270809
 ] 

ASF GitHub Bot commented on CB-11176:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/172


> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270806#comment-15270806
 ] 

ASF subversion and git services commented on CB-11176:
--

Commit b8b636cd097c8cf40e1313075ef5195cdcf247f8 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=b8b636c ]

CB-11176 Fix windows-splashscreen compatibility with older plugin versions


> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270769#comment-15270769
 ] 

ASF GitHub Bot commented on CB-11176:
-

Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-windows/pull/172#issuecomment-216891242
  
## [Current coverage][cc-pull] is **73.42%**
> Merging [#172][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #172   diff @@
==
  Files14 14  
  Lines  1862   1862  
  Methods 342342  
  Messages  0  0  
  Branches379379  
==
  Hits   1367   1367  
  Misses  495495  
  Partials  0  0  
```



> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[033956d...b48e5d8][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-windows/compare/033956d1f561a0d3321199115d7b556ea6ed7d8e...b48e5d8b12a8656b1ddf3a1bd35d86d104d701a2
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/172?src=pr


> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270728#comment-15270728
 ] 

ASF GitHub Bot commented on CB-11176:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/172#discussion_r62049082
  
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
  */
 module.exports = function (success, fail, service, action, args) {
 
+// Handle the case when we have an old version of splashscreen plugin 
to avoid the API calls failures
+if (service === 'SplashScreen') {
+var pluginsVersions = require("cordova/plugin_list").metadata;
+var splashscreenVersion = 
pluginsVersions['cordova-plugin-splashscreen'];
+var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) < 
MIN_SPLASHSCREEN_SUPPORTED_VER) {
+console.log('Warning: cordova-plugin-splashscreen has been 
hooked into for compatibility reasons. Update the plugin to version >= 4.');
--- End diff --

Updated, thanks.


> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270713#comment-15270713
 ] 

ASF GitHub Bot commented on CB-11176:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/172#discussion_r62048444
  
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
  */
 module.exports = function (success, fail, service, action, args) {
 
+// Handle the case when we have an old version of splashscreen plugin 
to avoid the API calls failures
+if (service === 'SplashScreen') {
+var pluginsVersions = require("cordova/plugin_list").metadata;
+var splashscreenVersion = 
pluginsVersions['cordova-plugin-splashscreen'];
+var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) < 
MIN_SPLASHSCREEN_SUPPORTED_VER) {
--- End diff --

This regards to the plugin version and not to the platform' one,  i.e. it 
should work starting with cordova-plugin-splashscreen@4 (as it will just 
redirect API calls to the platform).


> Fix windows-splashscreen compatibility with older plugin versions
> -
>
> Key: CB-11176
> URL: https://issues.apache.org/jira/browse/CB-11176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference 
> with a {{navigator.splashscreen.hide()}} call does not work with updated 
> {{cordova-windows}} and an old {{cordova-plugin-splashscreen}} (<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11200) Cordova-lib test failure on Node 6.0.0

[Alexander Sorokin (JIRA)]

Alexander Sorokin created CB-11200:
--

 Summary: Cordova-lib test failure on Node 6.0.0
 Key: CB-11200
 URL: https://issues.apache.org/jira/browse/CB-11200
 Project: Apache Cordova
  Issue Type: Bug
  Components: CordovaLib
Affects Versions: Master
 Environment: Windows, OSX
Reporter: Alexander Sorokin


When running "npm test" in cordova-lib folder, the following test fails on Node 
6.0.0:

{noformat}
  1) ios project handler uninstallation of  elements with 
custom="true" attribute should rm the file from the right target location
   Message:
 TypeError: Path must be a string. Received undefined
   Stacktrace:
 TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.dirname (path.js:697:5)
at searchPathForFile 
(C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24)
at pbxProject.removeFromFrameworkSearchPaths 
(C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20)
at pbxProject.removeFramework 
(C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12)
at Object.module.exports.framework.uninstall 
(C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41)
at . 
(C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38)
{noformat}

Initial investigation points out that the bug in node-xcode can be the cause of 
this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11195) Windows platform - create windows 10 app packages

[napcat (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270681#comment-15270681
 ] 

napcat commented on CB-11195:
-

I made a cordova hook that run on "after_prepare".

The scripts reads and writes again the .js files on the utf8 encoding system.

I used "iconv-lite" and "glob" as dependencies.

{code:js}
#!/usr/bin/env node

module.exports = function(context) 
{
var path = context.requireCordovaModule('path');
var fs = context.requireCordovaModule('fs');

var iconvlite = require('iconv-lite');
var glob = require("glob");

var appxManifestPath = path.join(context.opts.projectRoot, 
'\\platforms\\windows\\www\\');

console.log("AppxManifestPath: " + appxManifestPath);

if (fs.existsSync(appxManifestPath))
{
glob(appxManifestPath + "**/*.js", function (er, files) 
{
files.forEach(function(filePath) 
{
var file = fs.readFileSync(filePath);

var buffer = iconvlite.encode(file, "utf8");

fs.writeFile(filePath, buffer.toString('utf8'), 'utf8', 
function (error)
{
if (error) 
throw new error('error saving file as utf8: ' + 
filePath + " " + error);
});
});
});
}
};
{code}

> Windows platform - create windows 10 app packages
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\splashscreen.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\js\app.min.js
>  has JavaScript syntax or other problems.
> ...
> Impact if not fixed: As a performance optimization to accelerate JavaScript 
> execution time, JavaScript files ending in the ".js" extension generate 
> bytecode when the app is deployed. This optimization significantly improves 
> start-up and ongoing execution times for JavaScript.
> How to fix: You may need consider one or more of these steps to fix the issue:
> - Avoid deploying the app by pressing F5 in Visual Studio, create an appx 
> package instead
> - Ensure that event logging is enabled
> - All JavaScript files are syntactically valid; otherwise exclude the 
> respective files from the package
> - Please note that you should uninstall all previous versions of the app 
> before deploying
> Otherwise exclude the respective files from the package.
> {code}
> Can the app be submitted with this erros?
> Should not the cordova generate the project ready for publication?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To 

[jira] [Comment Edited] (CB-11195) Windows platform - create windows 10 app packages

[napcat (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270681#comment-15270681
 ] 

napcat edited comment on CB-11195 at 5/4/16 2:16 PM:
-

I made a cordova hook that run on "after_prepare".

The scripts reads and writes again the .js files on the utf8 encoding system.

I used "iconv-lite" and "glob" as dependencies.

{code:javascript}
#!/usr/bin/env node

module.exports = function(context) 
{
var path = context.requireCordovaModule('path');
var fs = context.requireCordovaModule('fs');

var iconvlite = require('iconv-lite');
var glob = require("glob");

var appxManifestPath = path.join(context.opts.projectRoot, 
'\\platforms\\windows\\www\\');

console.log("AppxManifestPath: " + appxManifestPath);

if (fs.existsSync(appxManifestPath))
{
glob(appxManifestPath + "**/*.js", function (er, files) 
{
files.forEach(function(filePath) 
{
var file = fs.readFileSync(filePath);

var buffer = iconvlite.encode(file, "utf8");

fs.writeFile(filePath, buffer.toString('utf8'), 'utf8', 
function (error)
{
if (error) 
throw new error('error saving file as utf8: ' + 
filePath + " " + error);
});
});
});
}
};
{code}


was (Author: napcat):
I made a cordova hook that run on "after_prepare".

The scripts reads and writes again the .js files on the utf8 encoding system.

I used "iconv-lite" and "glob" as dependencies.

{code:js}
#!/usr/bin/env node

module.exports = function(context) 
{
var path = context.requireCordovaModule('path');
var fs = context.requireCordovaModule('fs');

var iconvlite = require('iconv-lite');
var glob = require("glob");

var appxManifestPath = path.join(context.opts.projectRoot, 
'\\platforms\\windows\\www\\');

console.log("AppxManifestPath: " + appxManifestPath);

if (fs.existsSync(appxManifestPath))
{
glob(appxManifestPath + "**/*.js", function (er, files) 
{
files.forEach(function(filePath) 
{
var file = fs.readFileSync(filePath);

var buffer = iconvlite.encode(file, "utf8");

fs.writeFile(filePath, buffer.toString('utf8'), 'utf8', 
function (error)
{
if (error) 
throw new error('error saving file as utf8: ' + 
filePath + " " + error);
});
});
});
}
};
{code}

> Windows platform - create windows 10 app packages
> -
>
> Key: CB-11195
> URL: https://issues.apache.org/jira/browse/CB-11195
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 6.1.1
>Reporter: napcat
> Fix For: 6.1.1
>
>
> When a windows cordova platform is added using:
> cordova platform add windows
> And the windows 10 project, inside visual studio 2015, is used to build the 
> app package, the package validation fails, when it's validated using the 
> "Windows App Certification Kit 10.0". The selected architectures are: x86 
> (release), x64(release) and ARM (release).
> {code:xml}
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova_plugins.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\exec.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\cordova-js-src\platform.js
>  is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> ...
> File C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\index.html 
> is not properly UTF-8 encoded. Re-save the file as UTF-8 (including Byte 
> Order Mark).
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 
> form with a corresponding byte-order mark (BOM) in order to benefit from 
> bytecode caching and to avoid other runtime error conditions.
> {code}
> {code:xml}
> Bytecode generation
> Error Found: The bytecode generation test detected the following errors:
> File \\?\C:\Program 
> Files\WindowsApps\BECC1407.AppXPTO_1.4.0.0_x64__6hmvhj7j5fc1t\www\plugins\cordova-plugin-splashscreen\www\windows\SplashScreenProxy.js
>  has JavaScript syntax or other problems.
> File \\?\C:\Program 
> 

[jira] [Created] (CB-11199) File plugin FileReader readAsDataURL

[JIRA]

Caner Patır created CB-11199:


 Summary: File plugin FileReader readAsDataURL
 Key: CB-11199
 URL: https://issues.apache.org/jira/browse/CB-11199
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 4.2.0
 Environment: Android 4.4.2
Reporter: Caner Patır
Priority: Critical


FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. I 
could not decode the generate base64 data. But iI tried the same situation on 
version 4.1.1 it works successfully. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-9142) `cordova emulate` doesn't populate the `CORDOVA_PLATORMS` environment variable for `before_prepare` hook.

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CB-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko Marković resolved CB-9142.

   Resolution: Fixed
Fix Version/s: 6.1.1

This appears to be fixed in 6.1.1. I haven't tested any previous versions.

> `cordova emulate` doesn't populate the `CORDOVA_PLATORMS` environment 
> variable for `before_prepare` hook.
> -
>
> Key: CB-9142
> URL: https://issues.apache.org/jira/browse/CB-9142
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 5.0.0
> Environment: Replicated on linux and osx.
> {noformat}
> OS: Distributor ID:   LinuxMint Description:  Linux Mint 17.1 Rebecca 
> Node Version: v0.10.38
> Cordova CLI: 5.0.0
> {noformat}
> {noformat}
> OS: Mac OS X Yosemite
> Node Version: v0.12.4
> Cordova CLI: 5.0.0
> {noformat}
>Reporter: Marko Marković
>Priority: Minor
>  Labels: triaged
> Fix For: 6.1.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> See [this gist|https://gist.github.com/markomarkovic/63ec0f0ffcb2ea9d4a11] 
> for a simple test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11194) Improve cordova load time

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270346#comment-15270346
 ] 

ASF GitHub Bot commented on CB-11194:
-

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/434#discussion_r62007337
  
--- Diff: cordova-lib/cordova-lib.js ---
@@ -18,19 +18,35 @@
 */
 
 // For now expose plugman and cordova just as they were in the old repos
+
+
+function addProperty(obj, property, modulePath) {
--- End diff --

Similar functionality already exists at 
[`src/cordova/util.js:339`](https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/util.js#L339).
 There is a slight difference but it looks like it could be reused.


> Improve cordova load time
> -
>
> Key: CB-11194
> URL: https://issues.apache.org/jira/browse/CB-11194
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11198) Skip checking android target installed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270301#comment-15270301
 ] 

ASF GitHub Bot commented on CB-11198:
-

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/303#discussion_r62002478
  
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
 var args = this.getArgs(opts.buildType == 'debug' ? 'debug' : 
'release', opts);
 return check_reqs.check_ant()
 .then(function() {
-return spawn('ant', args, {stdio: 'inherit'});
+return spawn('ant', args, {stdio: 'pipe'});
+}).progress(function (stdio){
--- End diff --

Should we handle stdio of `ant build` manually here?


> Skip checking android target installed
> --
>
> Key: CB-11198
> URL: https://issues.apache.org/jira/browse/CB-11198
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Android, CordovaLib
>Reporter: Nikhil Khandelwal
>Assignee: Nikhil Khandelwal
>
> Instead of checking this upfront - we're going to detect failure and show the 
> message later.
> This saves a good 1 second on my Macbook pro.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-10833) Deduplicate common logic for plugin installation/uninstallation in platforms

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov resolved CB-10833.
---
Resolution: Done

> Deduplicate common logic for plugin installation/uninstallation in platforms
> 
>
> Key: CB-10833
> URL: https://issues.apache.org/jira/browse/CB-10833
> Project: Apache Cordova
>  Issue Type: Task
>  Components: Android, CordovaCommon, iOS, Windows
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11161) Reuse PluginManager class to add/rm plugins in cordova-ios

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11161.
-
Resolution: Done

> Reuse PluginManager class to add/rm plugins in cordova-ios
> --
>
> Key: CB-11161
> URL: https://issues.apache.org/jira/browse/CB-11161
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Affects Versions: 4.2.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11139.
-
Resolution: Done

> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270275#comment-15270275
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62000656
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+//check if npm is installed
+isNpmInstalled();
+
+if(dest && target) {
+//add target to fetchArgs Array
+fetchArgs.push(target);
+
+//append node_modules to dest if it doesn't come included
+if (path.basename(dest) !== 'node_modules') {
+dest = path.resolve(path.join(dest, 'node_modules'));
+}
+
+//create dest if it doesn't exist
+if(!fs.existsSync(dest)) {
+shell.mkdir('-p', dest); 
+} 
+
+} else return Q.reject(new CordovaError('Need to supply a target and 
destination'));
+
+//set the directory where npm install will be run
+opts.cwd = dest;
+
+//if user added --save flag, pass it to npm install command
+if(opts.save) {
+events.emit('verbose', 'saving');
+fetchArgs.push('--save'); 
+} 
+
+
+//Grab json object of installed modules before npm install
+return depls(dest)
+.then(function(depTree) {
+tree1 = depTree;
+
+//install new module
+return superspawn.spawn('npm', fetchArgs, opts);
+})
+.then(function(output) {
+//Grab object of installed modules after npm install
+return depls(dest);
+})
+.then(function(depTree2) {
+var tree2 = depTree2;
+
+//getJsonDiff will fail if the module already exists in 
node_modules.
+//Need to use trimID in that case. 
+//This could happen on a platform update.
+var id = getJsonDiff(tree1, tree2) || trimID(target); 
+
+return getPath(id, dest);
+}) 
+.fail(function(err){
+return Q.reject(new CordovaError(err));
+});
+};
+
+
+/*
+ * Takes two JSON objects and returns the key of the new property as a 
string.
+ * If a module already exists in node_modules, the diff will be blank. 
+ * cordova-fetch will use trimID in that case.
+ *
+ * @param {Object} obj1 json object representing installed modules 
before latest npm install
+ * @param {Object} obj2 json object representing installed modules 
after latest npm install
+ *
+ * @return {String} String containing the key value of the 
difference between the two objects
+ *
+ */
+function getJsonDiff(obj1, obj2) {
+var result = '';
+
+//regex to filter out peer dependency warnings from result
+var re = /UNMET PEER DEPENDENCY/;
+
+for (var key in obj2) {
+//if it 

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270272#comment-15270272
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r62000572
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+//check if npm is installed
+isNpmInstalled();
--- End diff --

Looks like in case if `npm` is not available this will return a promise 
rejection which is never propagated to the caller. Probably you need to wrap 
this call and all the code below into top-level promise (similar to #384). This 
would also protect the code against 
[CB-10519](https://issues.apache.org/jira/browse/CB-10519)


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270265#comment-15270265
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r61999817
  
--- Diff: cordova-fetch/spec/package.json ---
@@ -0,0 +1,11 @@
+{
--- End diff --

Do we need a separate `package.json` for specs?


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270246#comment-15270246
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r61998473
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
+ *
+ */
+module.exports = function(target, dest, opts) {
+var fetchArgs = ['install'];
+opts = opts || {};
+var tree1;
+
+//check if npm is installed
+isNpmInstalled();
+
+if(dest && target) {
+//add target to fetchArgs Array
+fetchArgs.push(target);
+
+//append node_modules to dest if it doesn't come included
+if (path.basename(dest) !== 'node_modules') {
+dest = path.resolve(path.join(dest, 'node_modules'));
+}
+
+//create dest if it doesn't exist
+if(!fs.existsSync(dest)) {
+shell.mkdir('-p', dest); 
+} 
+
+} else return Q.reject(new CordovaError('Need to supply a target and 
destination'));
+
+//set the directory where npm install will be run
+opts.cwd = dest;
+
+//if user added --save flag, pass it to npm install command
+if(opts.save) {
+events.emit('verbose', 'saving');
+fetchArgs.push('--save'); 
+} 
+
+
+//Grab json object of installed modules before npm install
+return depls(dest)
+.then(function(depTree) {
+tree1 = depTree;
+
+//install new module
+return superspawn.spawn('npm', fetchArgs, opts);
+})
+.then(function(output) {
+//Grab object of installed modules after npm install
+return depls(dest);
+})
+.then(function(depTree2) {
+var tree2 = depTree2;
+
+//getJsonDiff will fail if the module already exists in 
node_modules.
+//Need to use trimID in that case. 
+//This could happen on a platform update.
+var id = getJsonDiff(tree1, tree2) || trimID(target); 
+
+return getPath(id, dest);
+}) 
+.fail(function(err){
+return Q.reject(new CordovaError(err));
+});
+};
+
+
+/*
+ * Takes two JSON objects and returns the key of the new property as a 
string.
+ * If a module already exists in node_modules, the diff will be blank. 
+ * cordova-fetch will use trimID in that case.
+ *
+ * @param {Object} obj1 json object representing installed modules 
before latest npm install
+ * @param {Object} obj2 json object representing installed modules 
after latest npm install
+ *
+ * @return {String} String containing the key value of the 
difference between the two objects
+ *
+ */
+function getJsonDiff(obj1, obj2) {
+var result = '';
+
+//regex to filter out peer dependency warnings from result
+var re = /UNMET PEER DEPENDENCY/;
+
+for (var key in obj2) {
+//if it 

[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270244#comment-15270244
 ] 

ASF GitHub Bot commented on CB-9858:


Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/407#discussion_r61998292
  
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,234 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ 'License'); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+var Q = require('q');
+var shell = require('shelljs');
+var superspawn = require('cordova-common').superspawn;
+var events = require('cordova-common').events;
+var depls = require('dependency-ls');
+var path = require('path');
+var fs = require('fs');
+var CordovaError = require('cordova-common').CordovaError;
+var isUrl = require('is-url');
+
+/* 
+ * A function that npm installs a module from npm or a git url
+ *
+ * @param {String} target   the packageID or git url
+ * @param {String} dest destination of where to install the module
+ * @param {Object} opts [opts={save:true}] options to pass to fetch 
module
+ *
+ * @return {String||Promise}Returns string of the absolute path to the 
installed module.
--- End diff --

Nit: the JSDoc notation for multiple types is a bit different - single `|` 
instead `||` (please see http://usejsdoc.org/tags-type.html).


> Implement Cordova Fetch Proposal
> 
>
> Key: CB-9858
> URL: https://issues.apache.org/jira/browse/CB-9858
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Steve Gill
>  Labels: cordova-fetch
> Fix For: 6.0.0
>
>
> https://github.com/cordova/cordova-discuss/pull/33



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270236#comment-15270236
 ] 

ASF subversion and git services commented on CB-11139:
--

Commit 033956d1f561a0d3321199115d7b556ea6ed7d8e in cordova-windows's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=033956d ]

CB-11139 Use PluginManager from common to install/uninstall plugins

 This closes #171


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11139) Reuse PluginManager class to add/rm plugins in cordova-windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270237#comment-15270237
 ] 

ASF GitHub Bot commented on CB-11139:
-

Github user vladimir-kotikov closed the pull request at:

https://github.com/apache/cordova-windows/pull/171


> Reuse PluginManager class to add/rm plugins in cordova-windows
> --
>
> Key: CB-11139
> URL: https://issues.apache.org/jira/browse/CB-11139
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11161) Reuse PluginManager class to add/rm plugins in cordova-ios

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270235#comment-15270235
 ] 

ASF GitHub Bot commented on CB-11161:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/219


> Reuse PluginManager class to add/rm plugins in cordova-ios
> --
>
> Key: CB-11161
> URL: https://issues.apache.org/jira/browse/CB-11161
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Affects Versions: 4.2.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11161) Reuse PluginManager class to add/rm plugins in cordova-ios

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270232#comment-15270232
 ] 

ASF subversion and git services commented on CB-11161:
--

Commit 77c848ad9db1a9a5e1336f110f1099f0f5140646 in cordova-ios's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=77c848a ]

CB-11161 Bump cordova-common to 1.2.0


> Reuse PluginManager class to add/rm plugins in cordova-ios
> --
>
> Key: CB-11161
> URL: https://issues.apache.org/jira/browse/CB-11161
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Affects Versions: 4.2.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11161) Reuse PluginManager class to add/rm plugins in cordova-ios

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270233#comment-15270233
 ] 

ASF subversion and git services commented on CB-11161:
--

Commit f41737d014b3621247d6d5283ebd81f0c6720c31 in cordova-ios's branch 
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=f41737d ]

CB-11161 Reuse PluginManager from common to add/rm plugins

 This closes #219


> Reuse PluginManager class to add/rm plugins in cordova-ios
> --
>
> Key: CB-11161
> URL: https://issues.apache.org/jira/browse/CB-11161
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Affects Versions: 4.2.0
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11166) Implement an Appium test checking if contact birthday is saved properly

[Alexander Sorokin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin closed CB-11166.
--
Resolution: Fixed

> Implement an Appium test checking if contact birthday is saved properly
> ---
>
> Key: CB-11166
> URL: https://issues.apache.org/jira/browse/CB-11166
> Project: Apache Cordova
>  Issue Type: Test
>  Components: Appium, Plugin Contacts
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270202#comment-15270202
 ] 

ASF GitHub Bot commented on CB-7:
-

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-android/pull/295#issuecomment-216759612
  
LGTM


> Preparing platforms should skip copying files which haven't changed
> ---
>
> Key: CB-7
> URL: https://issues.apache.org/jira/browse/CB-7
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android, iOS, Windows
>Reporter: Jason Ginchereau
>Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova 
> build', 'cordova run', 'cordova plugin add', and more. Every time each of 
> those commands runs, the target platform is "prepared", which involves 
> copying all files from the [/www, 
> /platforms//platform_www, /merges/] to 
> the platform's target www folder, as well as copying a bunch of icons and 
> splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. 
> But most of the time after that most of the files being copied have not 
> changed and therefore don't really need to be copied again. So the typical 
> developer inner loop (edit a few source files, build and run the app, repeat) 
> is a lot slower than it could be for a Cordova project, especially one that 
> includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't 
> changed, based on their last-modified timestamp. (But also there should still 
> be a way to force a clean/full/non-incremental build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11174) cordova platformApi cache isn't dealing correctly with symlinked project dirs

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11174.
-
Resolution: Fixed

> cordova platformApi cache isn't dealing correctly with symlinked project dirs
> -
>
> Key: CB-11174
> URL: https://issues.apache.org/jira/browse/CB-11174
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.1.1
>Reporter: Vladimir Kotikov
>Assignee: Vladimir Kotikov
>  Labels: triaged
>
> When project dir is inside of symlinked directory (say {{/var}} on OS X), 
> {{getPlatformApi}} method in cordova-lib doesn't resolve real path before 
> dealing with cache and uses provided path as-is. This causes returning two 
> separate instances of {{PlatformApi}} class when {{getPlatformApi}} is first 
> called with symlinked path and then with real one, despite of the fact that 
> both paths are pointing to the same project.
> In the real life this issue causes the following 'npm test' failures for 
> cordova-lib on OS X, caused by mocking methods for one PlatformApi instance 
> and using another one:
> {noformat}
>   1) plugin end-to-end should not run prepare after plugin 
> installation/removal if platform return non-falsy value
>Message:
>  Expected spy preparePlatforms not to have been called.
>Stacktrace:
>  Error: Expected spy preparePlatforms not to have been called.
> at 
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:175:50
> at _fulfilled 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
>  
>   2) plugin end-to-end should not run prepare after plugin 
> installation/removal if platform return non-falsy value
>Message:
>  Expected spy preparePlatforms not to have been called.
>Stacktrace:
>  Error: Expected spy preparePlatforms not to have been called.
> at 
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/spec-cordova/plugin.spec.js:179:50
> at _fulfilled 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
> at 
> /Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
> at flush 
> (/Users/csantana23/Documents/dev/cordova/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
> at nextTickCallbackWith0Args (node.js:419:9)
> at process._tickCallback (node.js:348:13)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org