[jira] [Updated] (CB-11214) prompt() defaultText on Android sets placeholder text instead of default text
[ https://issues.apache.org/jira/browse/CB-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Armstrong updated CB-11214: - Description: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282): {{ public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); }} Instead of EditText.setHint(), EditText.setText() should be called with the default text. was: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282): {{ public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); }}} Instead of EditText.setHint(), EditText.setText() should be called with the default text. > prompt() defaultText on Android sets placeholder text instead of default text > - > > Key: CB-11214 > URL: https://issues.apache.org/jira/browse/CB-11214 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Dialogs > Environment: Android >Reporter: Chris Armstrong > > On Android, a string passed for the defaultText parameter to prompt() is > instead used as the placeholder text (i.e. the text shown when the box is > empty). This behaviour is inconsistent with other platforms and incorrect > compared to the documentation. > The offending code (from line 282): > {{ > public synchronized void prompt(final String message, final String title, > final JSONArray buttonLabels, final String defaultText, final CallbackContext > callbackContext) { > ... > promptInput.setHint(defaultText); > }} > Instead of EditText.setHint(), EditText.setText() should be called with the > default text. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11214) prompt() defaultText on Android sets placeholder text instead of default text
[ https://issues.apache.org/jira/browse/CB-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Armstrong updated CB-11214: - Description: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282): {{ public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); }}} Instead of EditText.setHint(), EditText.setText() should be called with the default text. was: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282: {{{ public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); }}} Instead of EditText.setHint(), EditText.setText() should be called with the default text. > prompt() defaultText on Android sets placeholder text instead of default text > - > > Key: CB-11214 > URL: https://issues.apache.org/jira/browse/CB-11214 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Dialogs > Environment: Android >Reporter: Chris Armstrong > > On Android, a string passed for the defaultText parameter to prompt() is > instead used as the placeholder text (i.e. the text shown when the box is > empty). This behaviour is inconsistent with other platforms and incorrect > compared to the documentation. > The offending code (from line 282): > {{ > public synchronized void prompt(final String message, final String title, > final JSONArray buttonLabels, final String defaultText, final CallbackContext > callbackContext) { > ... > promptInput.setHint(defaultText); > }}} > Instead of EditText.setHint(), EditText.setText() should be called with the > default text. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11214) prompt() defaultText on Android sets placeholder text instead of default text
[ https://issues.apache.org/jira/browse/CB-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Armstrong updated CB-11214: - Description: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282: {{{ public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); }}} Instead of EditText.setHint(), EditText.setText() should be called with the default text. was: On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282: ``` public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); ``` Instead of EditText.setHint(), EditText.setText() should be called with the default text. > prompt() defaultText on Android sets placeholder text instead of default text > - > > Key: CB-11214 > URL: https://issues.apache.org/jira/browse/CB-11214 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Dialogs > Environment: Android >Reporter: Chris Armstrong > > On Android, a string passed for the defaultText parameter to prompt() is > instead used as the placeholder text (i.e. the text shown when the box is > empty). This behaviour is inconsistent with other platforms and incorrect > compared to the documentation. > The offending code (from line 282: > {{{ > public synchronized void prompt(final String message, final String title, > final JSONArray buttonLabels, final String defaultText, final CallbackContext > callbackContext) { > ... > promptInput.setHint(defaultText); > }}} > Instead of EditText.setHint(), EditText.setText() should be called with the > default text. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11214) prompt() defaultText on Android sets placeholder text instead of default text
Chris Armstrong created CB-11214: Summary: prompt() defaultText on Android sets placeholder text instead of default text Key: CB-11214 URL: https://issues.apache.org/jira/browse/CB-11214 Project: Apache Cordova Issue Type: Bug Components: Plugin Dialogs Environment: Android Reporter: Chris Armstrong On Android, a string passed for the defaultText parameter to prompt() is instead used as the placeholder text (i.e. the text shown when the box is empty). This behaviour is inconsistent with other platforms and incorrect compared to the documentation. The offending code (from line 282: ``` public synchronized void prompt(final String message, final String title, final JSONArray buttonLabels, final String defaultText, final CallbackContext callbackContext) { ... promptInput.setHint(defaultText); ``` Instead of EditText.setHint(), EditText.setText() should be called with the default text. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11213) Multiple .svg not displaying
Ian Howse created CB-11213: -- Summary: Multiple .svg not displaying Key: CB-11213 URL: https://issues.apache.org/jira/browse/CB-11213 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 3.5.0 Environment: Windows 10 Desktop ios 9.3.1 iPhone 5 and iPad Reporter: Ian Howse If 1 .svg is displayed in
[jira] [Commented] (CB-11050) XHR tests failing intermittently in windows Phone 8.1 CI
[ https://issues.apache.org/jira/browse/CB-11050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273570#comment-15273570 ] ASF GitHub Bot commented on CB-11050: - Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217338006 Yes it is needed. jQuery mobile broke because apps were not permitted to xhr to their own resources. It IS browser functionality, BUT we still need tests to prove we are not breaking it. > XHR tests failing intermittently in windows Phone 8.1 CI > > > Key: CB-11050 > URL: https://issues.apache.org/jira/browse/CB-11050 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec > Environment: Windows Phone 8.1 >Reporter: Richard B Knoll >Assignee: Raghav Katyal > Labels: found-by-ci, triaged, windows > > {noformat} > Total failures: 1 > Failing tests: > org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest > XMLHttpRequest.spec.9 calls onload from successful http get > Error: Timeout - Async callback was not invoked within timeout > specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11050) XHR tests failing intermittently in windows Phone 8.1 CI
[ https://issues.apache.org/jira/browse/CB-11050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273550#comment-15273550 ] ASF GitHub Bot commented on CB-11050: - Github user omefire commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217334128 It seems like this whole test suite is only about checking browser/webview functionality. Do we still really need them ? > XHR tests failing intermittently in windows Phone 8.1 CI > > > Key: CB-11050 > URL: https://issues.apache.org/jira/browse/CB-11050 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec > Environment: Windows Phone 8.1 >Reporter: Richard B Knoll >Assignee: Raghav Katyal > Labels: found-by-ci, triaged, windows > > {noformat} > Total failures: 1 > Failing tests: > org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest > XMLHttpRequest.spec.9 calls onload from successful http get > Error: Timeout - Async callback was not invoked within timeout > specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-11152) Kill the Android Win Builder on CI
[ https://issues.apache.org/jira/browse/CB-11152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Katyal resolved CB-11152. Resolution: Fixed > Kill the Android Win Builder on CI > -- > > Key: CB-11152 > URL: https://issues.apache.org/jira/browse/CB-11152 > Project: Apache Cordova > Issue Type: Task >Reporter: Raghav Katyal >Assignee: Raghav Katyal > > It's not adding much to the value and has been flaky since a long time. It's > a good idea to get rid of it since we already have android on osx. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11099) Crashing when select dropdown in android Motorola Droid Turbo 2
[ https://issues.apache.org/jira/browse/CB-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273363#comment-15273363 ] BeTop commented on CB-11099: See this stackoverflow link for issue. This happened on only Motorola Driod phone. http://stackoverflow.com/questions/36667121/adreno-error-crashes-android-cordova-app-on-select-dropdown > Crashing when select dropdown in android Motorola Droid Turbo 2 > --- > > Key: CB-11099 > URL: https://issues.apache.org/jira/browse/CB-11099 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 6.0.0 >Reporter: BeTop >Priority: Minor > > The app crashes when choose select on an Motorola Droid Turbo 2, Android > Version 6.0. > Here are the crucial logcat lines. They start with when I tap the dropdown. > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:56] > isActive: true > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:65] > hideSoftInputFromWindow > 04-16 12:04:37.181: I/chromium(13068): [INFO:CONSOLE(25)] "No > Content-Security-Policy meta tag found. Please add one when using the > cordova-plugin-whitelist plugin.", source: > file:///android_asset/www/plugins/cordova-plugin-whitelist/whitelist.js (25) > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): - beginning of crash > Everytime the app crashes there is one or more of these at the end of the log: > W/Adreno-GSL(13068): ... (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) > failed: errno 16 Device or resource busy -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11198) Skip checking android target installed
[ https://issues.apache.org/jira/browse/CB-11198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1527#comment-1527 ] ASF GitHub Bot commented on CB-11198: - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/303#discussion_r62273198 --- Diff: bin/templates/cordova/lib/builders/AntBuilder.js --- @@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) { var args = this.getArgs(opts.buildType == 'debug' ? 'debug' : 'release', opts); return check_reqs.check_ant() .then(function() { -return spawn('ant', args, {stdio: 'inherit'}); +return spawn('ant', args, {stdio: 'pipe'}); +}).progress(function (stdio){ --- End diff -- Can you elaborate? As far as I can see superspawn only returns `stderr` output only if you 'pipe'. Piping implies that someone has to still write this to process.stdout & process.stderr. > Skip checking android target installed > -- > > Key: CB-11198 > URL: https://issues.apache.org/jira/browse/CB-11198 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > Instead of checking this upfront - we're going to detect failure and show the > message later. > This saves a good 1 second on my Macbook pro. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11212) Images cannot be loaded if CordovaLib is in an iOS Framework
[ https://issues.apache.org/jira/browse/CB-11212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273329#comment-15273329 ] ASF GitHub Bot commented on CB-11212: - GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/61 CB-11212 iOS: Explicitly set the bundle for images - set the bundle to the CDVCapture's bundle instead of assuming application bundle. You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe-marketing-cloud-mobile/cordova-plugin-media-capture CB-11212cordova-plugin-media-capture Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 9778908e151e7f4959311989a38d03d7a07a96db Author: Andrew ZellmanDate: 2016-05-05T23:47:52Z CB-11212 iOS: Explicitly set the bundle for images - set the bundle to the CDVCapture's bundle instead of assuming application bundle. > Images cannot be loaded if CordovaLib is in an iOS Framework > > > Key: CB-11212 > URL: https://issues.apache.org/jira/browse/CB-11212 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Media Capture > Environment: iOS >Reporter: Andrew Zellman >Priority: Minor > > We are using CordovaLib and the plugins within an iOS Framework. The Media > Capture plugin assumes the application bundle when retrieving images, but > they are inside the framework bundle. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11212) Images cannot be loaded if CordovaLib is in an iOS Framework
[ https://issues.apache.org/jira/browse/CB-11212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273326#comment-15273326 ] Andrew Zellman commented on CB-11212: - Please assign this to me. > Images cannot be loaded if CordovaLib is in an iOS Framework > > > Key: CB-11212 > URL: https://issues.apache.org/jira/browse/CB-11212 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Media Capture > Environment: iOS >Reporter: Andrew Zellman >Priority: Minor > > We are using CordovaLib and the plugins within an iOS Framework. The Media > Capture plugin assumes the application bundle when retrieving images, but > they are inside the framework bundle. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11212) Images cannot be loaded if CordovaLib is in an iOS Framework
Andrew Zellman created CB-11212: --- Summary: Images cannot be loaded if CordovaLib is in an iOS Framework Key: CB-11212 URL: https://issues.apache.org/jira/browse/CB-11212 Project: Apache Cordova Issue Type: Improvement Components: Plugin Media Capture Environment: iOS Reporter: Andrew Zellman Priority: Minor We are using CordovaLib and the plugins within an iOS Framework. The Media Capture plugin assumes the application bundle when retrieving images, but they are inside the framework bundle. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11050) XHR tests failing intermittently in windows Phone 8.1 CI
[ https://issues.apache.org/jira/browse/CB-11050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273300#comment-15273300 ] ASF GitHub Bot commented on CB-11050: - Github user rakatyal commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217307363 @sarangan12 , @omefire: Please review. > XHR tests failing intermittently in windows Phone 8.1 CI > > > Key: CB-11050 > URL: https://issues.apache.org/jira/browse/CB-11050 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec > Environment: Windows Phone 8.1 >Reporter: Richard B Knoll >Assignee: Raghav Katyal > Labels: found-by-ci, triaged, windows > > {noformat} > Total failures: 1 > Failing tests: > org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest > XMLHttpRequest.spec.9 calls onload from successful http get > Error: Timeout - Async callback was not invoked within timeout > specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11050) XHR tests failing intermittently in windows Phone 8.1 CI
[ https://issues.apache.org/jira/browse/CB-11050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273299#comment-15273299 ] ASF GitHub Bot commented on CB-11050: - GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/140 CB-11050 Removing the flaky XHR Test This test isn't really needed since it's just checking the browser's functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-mobile-spec raghav/xhr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit 128b7b9fd1d9220446240f19d78d1e82329448ef Author: Raghav KatyalDate: 2016-05-05T23:16:45Z CB-11050 Removing the flaky XHR Test > XHR tests failing intermittently in windows Phone 8.1 CI > > > Key: CB-11050 > URL: https://issues.apache.org/jira/browse/CB-11050 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec > Environment: Windows Phone 8.1 >Reporter: Richard B Knoll >Assignee: Raghav Katyal > Labels: found-by-ci, triaged, windows > > {noformat} > Total failures: 1 > Failing tests: > org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest > XMLHttpRequest.spec.9 calls onload from successful http get > Error: Timeout - Async callback was not invoked within timeout > specified by jasmine.DEFAULT_TIMEOUT_INTERVAL. > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273232#comment-15273232 ] ASF subversion and git services commented on CB-11194: -- Commit 441fd90e8a9e7e647ca3c19a796bbde01734cc50 in cordova-lib's branch refs/heads/master from [~nikhilkh] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=441fd90 ] CB-11194 Improve cordova load time This closes #434 > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273233#comment-15273233 ] ASF GitHub Bot commented on CB-11194: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/434 > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-10475) iOS contacts permission modal causes contacts tests to fail
[ https://issues.apache.org/jira/browse/CB-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omar Mefire updated CB-10475: - Assignee: Sarangan Rajamanickam (was: Omar Mefire) > iOS contacts permission modal causes contacts tests to fail > --- > > Key: CB-10475 > URL: https://issues.apache.org/jira/browse/CB-10475 > Project: Apache Cordova > Issue Type: Test > Components: Medic > Environment: OSX >Reporter: Richard B Knoll >Assignee: Sarangan Rajamanickam >Priority: Minor > Labels: found-by-ci, ios, triaged > > cordova-ios CI returned test results and all of the contacts tests failed: > https://ci.apache.org/builders/cordova-ios/builds/1605/steps/getting-test-results/logs/stdio > Turns out a modal had appeared asking for permission to access contacts and > was never dismissed. After I clicked okay in the modal, everything was green > on the next build: > https://ci.apache.org/builders/cordova-ios/builds/1606 > We either need a way to grant the permissions or we should exclude these > tests from the CI. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-1117) Add onResume utility method
[ https://issues.apache.org/jira/browse/CB-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273122#comment-15273122 ] ASF subversion and git services commented on CB-1117: - Commit f409d27cb43fe5b89d7b6bf260ea1a00be2ef6e2 in cordova-lib's branch refs/heads/master from [~jasongin] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=f409d27 ] CB-1117 Add FileUpdater module to cordova-common. This closes #429. The new FileUpdater module contains a few functions that enable optimized file copies by comparing timestamps. These functions are primarily intended to be used by each platform's prepare operation to avoid redundantly copying files that haven't changed since the last build, thus greatly speeding up build times after the first build. But the usfulness isn't necessarily limited to the prepare operation; the functions could be used for any Cordova file copy operations that benefit from the same optimization. > Add onResume utility method > --- > > Key: CB-1117 > URL: https://issues.apache.org/jira/browse/CB-1117 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: Joe Bowser >Assignee: Joe Bowser > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273123#comment-15273123 ] ASF GitHub Bot commented on CB-7: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/429 > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273110#comment-15273110 ] ASF GitHub Bot commented on CB-7: - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217283363 Great! Thanks @jasongin! Merging now. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273101#comment-15273101 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217281613 As discussed, I tested this with symbolic links both at the root and in a subdirectory. It works fine without any special symlink handling in the code. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273040#comment-15273040 ] ASF GitHub Bot commented on CB-11194: - Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62252220 --- Diff: cordova-common/src/superspawn.js --- @@ -22,20 +22,20 @@ var fs = require('fs'); var path = require('path'); var _ = require('underscore'); var Q = require('q'); -var shell = require('shelljs'); var events = require('./events'); var iswin32 = process.platform == 'win32'; // On Windows, spawn() for batch files requires absolute path & having the extension. function resolveWindowsExe(cmd) { +var which = require('shelljs/src/which'); var winExtensions = ['.exe', '.bat', '.cmd', '.js', '.vbs']; function isValidExe(c) { return winExtensions.indexOf(path.extname(c)) !== -1 && fs.existsSync(c); } if (isValidExe(cmd)) { return cmd; } -cmd = shell.which(cmd) || cmd; +cmd = which({}, cmd) || cmd; if (!isValidExe(cmd)) { --- End diff -- I think this won't work now. The non-wrapped `which()` returns a `ShellString` object, then `path.extname()` throws if `(typeof path !== 'string')`. Did you test on Windows? > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11099) Crashing when select dropdown in android Motorola Droid Turbo 2
[ https://issues.apache.org/jira/browse/CB-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273039#comment-15273039 ] Nick Rardin commented on CB-11099: -- If this helps... Qualcomm Adreno 430 w driver version 139.0, Google Chrome 50.0.2661.89, Android 6.0.0 > Crashing when select dropdown in android Motorola Droid Turbo 2 > --- > > Key: CB-11099 > URL: https://issues.apache.org/jira/browse/CB-11099 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 6.0.0 >Reporter: BeTop >Priority: Minor > > The app crashes when choose select on an Motorola Droid Turbo 2, Android > Version 6.0. > Here are the crucial logcat lines. They start with when I tap the dropdown. > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:56] > isActive: true > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:65] > hideSoftInputFromWindow > 04-16 12:04:37.181: I/chromium(13068): [INFO:CONSOLE(25)] "No > Content-Security-Policy meta tag found. Please add one when using the > cordova-plugin-whitelist plugin.", source: > file:///android_asset/www/plugins/cordova-plugin-whitelist/whitelist.js (25) > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): - beginning of crash > Everytime the app crashes there is one or more of these at the end of the log: > W/Adreno-GSL(13068): ... (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) > failed: errno 16 Device or resource busy -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11099) Crashing when select dropdown in android Motorola Droid Turbo 2
[ https://issues.apache.org/jira/browse/CB-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273008#comment-15273008 ] Nick Rardin commented on CB-11099: -- I am also seeing this bug on dropdown menus with my Droid Turbo 2 but other phones are not affected by this issue. What is the next step to resolve it? > Crashing when select dropdown in android Motorola Droid Turbo 2 > --- > > Key: CB-11099 > URL: https://issues.apache.org/jira/browse/CB-11099 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 6.0.0 >Reporter: BeTop >Priority: Minor > > The app crashes when choose select on an Motorola Droid Turbo 2, Android > Version 6.0. > Here are the crucial logcat lines. They start with when I tap the dropdown. > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:56] > isActive: true > 04-16 12:04:32.045: D/cr_Ime(13068): [InputMethodManagerWrapper.java:65] > hideSoftInputFromWindow > 04-16 12:04:37.181: I/chromium(13068): [INFO:CONSOLE(25)] "No > Content-Security-Policy meta tag found. Please add one when using the > cordova-plugin-whitelist plugin.", source: > file:///android_asset/www/plugins/cordova-plugin-whitelist/whitelist.js (25) > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.204: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): : ioctl fd 38 > code 0x40180917 (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) failed: > errno 16 Device or resource busy > 04-16 12:04:44.205: W/Adreno-GSL(13068): - beginning of crash > Everytime the app crashes there is one or more of these at the end of the log: > W/Adreno-GSL(13068): ... (IOCTL_KGSL_CMDSTREAM_FREEMEMONTIMESTAMP_CTXTID) > failed: errno 16 Device or resource busy -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272989#comment-15272989 ] ASF GitHub Bot commented on CB-11194: - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/434#discussion_r62247519 --- Diff: cordova-lib/cordova-lib.js --- @@ -18,19 +18,35 @@ */ // For now expose plugman and cordova just as they were in the old repos + + +function addProperty(obj, property, modulePath) { --- End diff -- util.js has a side effect in global code of invoking a mkrdir. Also, the addModuleProperty is not quite the same and it's used in a number of places. I have already created a shared version in cordova-common. > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11194) Improve cordova load time
[ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272991#comment-15272991 ] ASF GitHub Bot commented on CB-11194: - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/434#issuecomment-217265794 Looking to merge this by EOD today if there are no other concerns. > Improve cordova load time > - > > Key: CB-11194 > URL: https://issues.apache.org/jira/browse/CB-11194 > Project: Apache Cordova > Issue Type: Sub-task > Components: Android, CordovaLib >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal > > We can delay load some of our dependencies to improve our load time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11164) Updating plugin dependencies
[ https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272985#comment-15272985 ] Dean Le commented on CB-11164: -- Try to install the older cordova-plugins then upgrade. It won't upgrade. I still have cordova-plugin-file as 4.1.0. I'm not sure if you install as new. Regards, Dean Le > Updating plugin dependencies > > > Key: CB-11164 > URL: https://issues.apache.org/jira/browse/CB-11164 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 6.1.0 > Environment: cordova CLI >Reporter: Dean Le >Priority: Minor > Labels: triaged, wfc > Original Estimate: 24h > Remaining Estimate: 24h > > When we got a list of updated plugins, I can't update cordova-plugin-file. It > keeps looping in the between plugins below saying that "You can't remove > because this plugin... is required for other plugin" even with -f or > --force option. > We can only update plugins by add/remove command though. I thought it's > developer responsibility to know which plugins for what. Or at least a > warning message (it does warn) but allow the plugin to be removed and > re-added. > --- > cordova-plugin-camera > cordova-plugin-file > cordova-plugin-media > cordova-plugin-compat -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272982#comment-15272982 ] ASF GitHub Bot commented on CB-11188: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/43 > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272976#comment-15272976 ] ASF subversion and git services commented on CB-11188: -- Commit 7a6259db32c7d3cbfc9f78d193bba07fdcffc78a in cordova-plugin-device-motion's branch refs/heads/master from [~sarangan12] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-motion.git;h=7a6259d ] CB-11188: cordova-plugin-device-motion-tests are failing in CI This closes #43 > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11164) Updating plugin dependencies
[ https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11164: --- Summary: Updating plugin dependencies (was: plugins update) > Updating plugin dependencies > > > Key: CB-11164 > URL: https://issues.apache.org/jira/browse/CB-11164 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 6.1.0 > Environment: cordova CLI >Reporter: Dean Le >Priority: Minor > Labels: triaged, wfc > Original Estimate: 24h > Remaining Estimate: 24h > > When we got a list of updated plugins, I can't update cordova-plugin-file. It > keeps looping in the between plugins below saying that "You can't remove > because this plugin... is required for other plugin" even with -f or > --force option. > We can only update plugins by add/remove command though. I thought it's > developer responsibility to know which plugins for what. Or at least a > warning message (it does warn) but allow the plugin to be removed and > re-added. > --- > cordova-plugin-camera > cordova-plugin-file > cordova-plugin-media > cordova-plugin-compat -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11164) plugins update
[ https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11164: --- Labels: triaged wfc (was: ) > plugins update > -- > > Key: CB-11164 > URL: https://issues.apache.org/jira/browse/CB-11164 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 6.1.0 > Environment: cordova CLI >Reporter: Dean Le >Priority: Minor > Labels: triaged, wfc > Original Estimate: 24h > Remaining Estimate: 24h > > When we got a list of updated plugins, I can't update cordova-plugin-file. It > keeps looping in the between plugins below saying that "You can't remove > because this plugin... is required for other plugin" even with -f or > --force option. > We can only update plugins by add/remove command though. I thought it's > developer responsibility to know which plugins for what. Or at least a > warning message (it does warn) but allow the plugin to be removed and > re-added. > --- > cordova-plugin-camera > cordova-plugin-file > cordova-plugin-media > cordova-plugin-compat -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11164) plugins update
[ https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272971#comment-15272971 ] Nikhil Khandelwal commented on CB-11164: I just tried it & media plugin always get the latest version of the file plugin with it: {code} λ cordova plugin ls cordova-plugin-compat 1.0.0 "Compat" cordova-plugin-file 4.2.0 "File" cordova-plugin-media 2.3.0 "Media" cordova-plugin-whitelist 1.2.2 "Whitelist" cordova-sqlite-storage 1.4.0 "Cordova sqlite storage plugin" {code} You might need to follow the following steps: {code} cordova plugin rm media cordova plugin rm file cordova plugin add cordova-plugin-media {code} > plugins update > -- > > Key: CB-11164 > URL: https://issues.apache.org/jira/browse/CB-11164 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 6.1.0 > Environment: cordova CLI >Reporter: Dean Le > Labels: triaged, wfc > Original Estimate: 24h > Remaining Estimate: 24h > > When we got a list of updated plugins, I can't update cordova-plugin-file. It > keeps looping in the between plugins below saying that "You can't remove > because this plugin... is required for other plugin" even with -f or > --force option. > We can only update plugins by add/remove command though. I thought it's > developer responsibility to know which plugins for what. Or at least a > warning message (it does warn) but allow the plugin to be removed and > re-added. > --- > cordova-plugin-camera > cordova-plugin-file > cordova-plugin-media > cordova-plugin-compat -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11164) plugins update
[ https://issues.apache.org/jira/browse/CB-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11164: --- Priority: Minor (was: Major) > plugins update > -- > > Key: CB-11164 > URL: https://issues.apache.org/jira/browse/CB-11164 > Project: Apache Cordova > Issue Type: Bug > Components: CLI >Affects Versions: 6.1.0 > Environment: cordova CLI >Reporter: Dean Le >Priority: Minor > Labels: triaged, wfc > Original Estimate: 24h > Remaining Estimate: 24h > > When we got a list of updated plugins, I can't update cordova-plugin-file. It > keeps looping in the between plugins below saying that "You can't remove > because this plugin... is required for other plugin" even with -f or > --force option. > We can only update plugins by add/remove command though. I thought it's > developer responsibility to know which plugins for what. Or at least a > warning message (it does warn) but allow the plugin to be removed and > re-added. > --- > cordova-plugin-camera > cordova-plugin-file > cordova-plugin-media > cordova-plugin-compat -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11134) Double "and cannot be removed" in a warning message
[ https://issues.apache.org/jira/browse/CB-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11134: --- Labels: triaged (was: ) > Double "and cannot be removed" in a warning message > --- > > Key: CB-11134 > URL: https://issues.apache.org/jira/browse/CB-11134 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: Master >Reporter: Alexander Sorokin >Assignee: Richard B Knoll >Priority: Minor > Labels: triaged > > {noformat} > C:\Cordova>cordova create test-app > Creating a new cordova project. > C:\Cordova>cd test-app > C:\Cordova\test-app>cordova platform add windows > Adding windows project... > Creating Cordova Windows Project: > App Name : HelloCordova > Namespace : io.cordova.hellocordova > Path : C:\Cordova\test-app\platforms\windows > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for windows > C:\Cordova\test-app>cordova plugin add cordova-plugin-camera > cordova-plugin-contacts > Fetching plugin "cordova-plugin-camera" via npm > Installing "cordova-plugin-camera" for windows > Fetching plugin "cordova-plugin-compat" via npm > Installing "cordova-plugin-compat" for windows > Fetching plugin "cordova-plugin-contacts" via npm > Installing "cordova-plugin-contacts" for windows > Dependent plugin "cordova-plugin-compat" already installed on windows. > C:\Cordova\test-app>cordova plugin rm camera > Uninstalling cordova-plugin-camera from windows > Removing "cordova-plugin-camera" > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > C:\Cordova\test-app> > {noformat} > Expected warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) > {noformat} > Actual warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11134) Double "and cannot be removed" in a warning message
[ https://issues.apache.org/jira/browse/CB-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11134: --- Priority: Minor (was: Major) > Double "and cannot be removed" in a warning message > --- > > Key: CB-11134 > URL: https://issues.apache.org/jira/browse/CB-11134 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: Master >Reporter: Alexander Sorokin >Priority: Minor > Labels: triaged > > {noformat} > C:\Cordova>cordova create test-app > Creating a new cordova project. > C:\Cordova>cd test-app > C:\Cordova\test-app>cordova platform add windows > Adding windows project... > Creating Cordova Windows Project: > App Name : HelloCordova > Namespace : io.cordova.hellocordova > Path : C:\Cordova\test-app\platforms\windows > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for windows > C:\Cordova\test-app>cordova plugin add cordova-plugin-camera > cordova-plugin-contacts > Fetching plugin "cordova-plugin-camera" via npm > Installing "cordova-plugin-camera" for windows > Fetching plugin "cordova-plugin-compat" via npm > Installing "cordova-plugin-compat" for windows > Fetching plugin "cordova-plugin-contacts" via npm > Installing "cordova-plugin-contacts" for windows > Dependent plugin "cordova-plugin-compat" already installed on windows. > C:\Cordova\test-app>cordova plugin rm camera > Uninstalling cordova-plugin-camera from windows > Removing "cordova-plugin-camera" > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > C:\Cordova\test-app> > {noformat} > Expected warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) > {noformat} > Actual warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11134) Double "and cannot be removed" in a warning message
[ https://issues.apache.org/jira/browse/CB-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11134: --- Assignee: Richard B Knoll > Double "and cannot be removed" in a warning message > --- > > Key: CB-11134 > URL: https://issues.apache.org/jira/browse/CB-11134 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: Master >Reporter: Alexander Sorokin >Assignee: Richard B Knoll >Priority: Minor > Labels: triaged > > {noformat} > C:\Cordova>cordova create test-app > Creating a new cordova project. > C:\Cordova>cd test-app > C:\Cordova\test-app>cordova platform add windows > Adding windows project... > Creating Cordova Windows Project: > App Name : HelloCordova > Namespace : io.cordova.hellocordova > Path : C:\Cordova\test-app\platforms\windows > Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the > project > Fetching plugin "cordova-plugin-whitelist@1" via npm > Installing "cordova-plugin-whitelist" for windows > C:\Cordova\test-app>cordova plugin add cordova-plugin-camera > cordova-plugin-contacts > Fetching plugin "cordova-plugin-camera" via npm > Installing "cordova-plugin-camera" for windows > Fetching plugin "cordova-plugin-compat" via npm > Installing "cordova-plugin-compat" for windows > Fetching plugin "cordova-plugin-contacts" via npm > Installing "cordova-plugin-contacts" for windows > Dependent plugin "cordova-plugin-compat" already installed on windows. > C:\Cordova\test-app>cordova plugin rm camera > Uninstalling cordova-plugin-camera from windows > Removing "cordova-plugin-camera" > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > C:\Cordova\test-app> > {noformat} > Expected warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) > {noformat} > Actual warning: > {noformat} > "cordova-plugin-compat" is required by (cordova-plugin-contacts) and cannot > be removed (hint: use -f or --force) and cannot be removed (hint: use -f or > --force) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272950#comment-15272950 ] ASF GitHub Bot commented on CB-11188: - Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217259632 a comment would also be great > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11211) File Transfer Plugin with multiple uploads
Akash Pal created CB-11211: -- Summary: File Transfer Plugin with multiple uploads Key: CB-11211 URL: https://issues.apache.org/jira/browse/CB-11211 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Transfer Affects Versions: 1.4.0 Environment: Android , ios Reporter: Akash Pal Fix For: 1.4.0 Current File Transfer Plugin enables to upload single file in a single request. Improvement has to be made to provide ability to upload multiple files ina single request. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11210) StatusBar Plugin 2.1.0 ignoring container size
[ https://issues.apache.org/jira/browse/CB-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shnip updated CB-11210: -- Summary: StatusBar Plugin 2.1.0 ignoring container size (was: StatusBar Plugin 2.1.0 has wrong size) > StatusBar Plugin 2.1.0 ignoring container size > -- > > Key: CB-11210 > URL: https://issues.apache.org/jira/browse/CB-11210 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Reporter: Sergey Shnip > > The problem appears when cordova view placed into UIView. The problem is that > cordova view size changed to app window bounds but not to its superview. > This may happen in hybrid applications where cordova view is not a single > full screen view. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11210) StatusBar Plugin 2.1.0 has wrong size
Sergey Shnip created CB-11210: - Summary: StatusBar Plugin 2.1.0 has wrong size Key: CB-11210 URL: https://issues.apache.org/jira/browse/CB-11210 Project: Apache Cordova Issue Type: Bug Components: iOS Reporter: Sergey Shnip The problem appears when cordova view placed into UIView. The problem is that cordova view size changed to app window bounds but not to its superview. This may happen in hybrid applications where cordova view is not a single full screen view. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272876#comment-15272876 ] ASF GitHub Bot commented on CB-11188: - Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62237574 --- Diff: tests/tests.js --- @@ -122,6 +122,7 @@ exports.defineAutoTests = function () { describe("watchAcceleration", function() { var id; + var ACCEPTABLE_PERCENT_RANGE = 95; --- End diff -- @omefire Done > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272814#comment-15272814 ] ASF GitHub Bot commented on CB-11188: - Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217239510 Other than the minor stuff mentioned, LGTM! > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272809#comment-15272809 ] ASF GitHub Bot commented on CB-11188: - Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217238656 +1 . Introducing a delta for this kind of comparisons is a good strategy for this issue. > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272808#comment-15272808 ] ASF GitHub Bot commented on CB-11188: - Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62233809 --- Diff: tests/tests.js --- @@ -122,6 +122,7 @@ exports.defineAutoTests = function () { describe("watchAcceleration", function() { var id; + var ACCEPTABLE_PERCENT_RANGE = 95; --- End diff -- Plz, Move this variable to within spec.9 as it's the only test that currently uses it. > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
[ https://issues.apache.org/jira/browse/CB-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272803#comment-15272803 ] ASF GitHub Bot commented on CB-7: - Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-217236642 @nikhilkh waiting on you. Thanks. > Preparing platforms should skip copying files which haven't changed > --- > > Key: CB-7 > URL: https://issues.apache.org/jira/browse/CB-7 > Project: Apache Cordova > Issue Type: Improvement > Components: Android, iOS, Windows >Reporter: Jason Ginchereau >Assignee: Jason Ginchereau > > Many cordova CLI commands include a "prepare" operation, including 'cordova > build', 'cordova run', 'cordova plugin add', and more. Every time each of > those commands runs, the target platform is "prepared", which involves > copying all files from the [/www, > /platforms//platform_www, /merges/] to > the platform's target www folder, as well as copying a bunch of icons and > splash screens to platform-specific locations. > For the very first prepare of a platform, all that file copying is necessary. > But most of the time after that most of the files being copied have not > changed and therefore don't really need to be copied again. So the typical > developer inner loop (edit a few source files, build and run the app, repeat) > is a lot slower than it could be for a Cordova project, especially one that > includes a significant number of source files or resources. > Instead, Cordova should be smart enough to skip copying of files that haven't > changed, based on their last-modified timestamp. (But also there should still > be a way to force a clean/full/non-incremental build if desired.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11206) Contacts plugin causes app crash
[ https://issues.apache.org/jira/browse/CB-11206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272773#comment-15272773 ] Omar Mefire commented on CB-11206: -- It seems like while retrieving IMs, we are not correctly dealing with the custom type: http://developer.android.com/reference/android/provider/ContactsContract.CommonDataKinds.Im.html#CUSTOM_PROTOCOL There might be some contact on the samsung phone with an IM field that's not part of the default list supported by Android. Further investigation is needed to make definitive conclusions. > Contacts plugin causes app crash > > > Key: CB-11206 > URL: https://issues.apache.org/jira/browse/CB-11206 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Reporter: Petr Odut > > On Samsung phone app crashes instantly with a stack trace: > {noformat} > java.lang.NumberFormatException > java.lang.Integer.invalidInt(Integer.java:138) > java.lang.Integer.parseInt(Integer.java:358) > java.lang.Integer.parseInt(Integer.java:334) > org.apache.cordova.contacts.ContactAccessorSdk5.imQuery(ContactAccessorSdk5.java:907) > org.apache.cordova.contacts.ContactAccessorSdk5.populateContactArray(ContactAccessorSdk5.java:435) > org.apache.cordova.contacts.ContactAccessorSdk5.search(ContactAccessorSdk5.java:282) > org.apache.cordova.contacts.ContactManager$3.run(ContactManager.java:209) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) > java.lang.Thread.run(Thread.java:818) > {noformat} > JS code to retrieve contacts, on Sony phone the same code works properly: > {code:javascript} > if(navigator.contacts) { > var options = new ContactFindOptions(); > options.multiple = true; > options.hasPhoneNumber = true; > navigator.contacts.find([navigator.contacts.fieldType.phoneNumbers], > contacts => { > this.phoneContacts = contacts; > d.resolve(contacts); > }, e => d.reject(e), options); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272769#comment-15272769 ] ASF GitHub Bot commented on CB-11188: - GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/43 CB-11188: cordova-plugin-device-motion-tests are failing in CI The error is happening in an assert statement where it tries to compare two timestamp values. This kind of comparison is risky as there might be slight variations. For eg: 1. Expected 1462451458702 to be greater than 1462451458723 2. Expected 1462470496780 to be greater than 1462470496875 In the above examples, you can see the actual value is very close to the expected value. It is 99. percent of the actual value. But, the test is failing due to the strict comparison. So, I have changed the assert to accept the actual value is above 95% of the expected value. @omefire Could you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-plugin-device-motion CB-11188 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 98a29cd2ac776d8717f4636f7c7aea09d52c8fe1 Author: Sarangan RajamanickamDate: 2016-05-05T18:11:05Z CB-11188: cordova-plugin-device-motion-tests are failing in CI > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272760#comment-15272760 ] David Hooey commented on CB-11197: -- Added a couple of screen shots from the Samsung Galaxy Tab S2 device running Android 5.1.1. > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > Attachments: NoStatusBar.png, > StatusBarShowsAfterKeyboardShowAndHide.png > > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hooey updated CB-11197: - Attachment: NoStatusBar.png > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > Attachments: NoStatusBar.png, > StatusBarShowsAfterKeyboardShowAndHide.png > > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hooey updated CB-11197: - Attachment: StatusBarShowsAfterKeyboardShowAndHide.png > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > Attachments: NoStatusBar.png, > StatusBarShowsAfterKeyboardShowAndHide.png > > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272743#comment-15272743 ] David Hooey commented on CB-11197: -- I have reproduce the issue within a new app. I have added it to GitHub. [https://github.com/davidhooey/cb-11197|https://github.com/davidhooey/cb-11197]. > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml
[ https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272738#comment-15272738 ] ASF GitHub Bot commented on CB-11023: - Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-217228255 @ktop thanks for the hint about running `cordova-coho/coho npm-link`. Once I did I was able to get your code to run. It seems to be working pretty good to me. So I would love to get this into cordova ASAP. Folks do you think we should merge this PR then look at changes to config.xml or land it all in one PR? > plugin.xml should be able to add attribute to an existing element in > AndroidManifest.xml > > > Key: CB-11023 > URL: https://issues.apache.org/jira/browse/CB-11023 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI, Plugman >Reporter: Carlos Santana > > We have a need for a plugin we develop to add the attribute android:name to > the element to be able to point to a Class that tracks app > sessions for analytics. > plugin.xml only support via only to add elements to > AndroidManfist.xml this request is to add an enhancement to also handle > adding an attribute to an existing element. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11163) Android Builds are failing in CI
[ https://issues.apache.org/jira/browse/CB-11163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarangan Rajamanickam closed CB-11163. -- > Android Builds are failing in CI > > > Key: CB-11163 > URL: https://issues.apache.org/jira/browse/CB-11163 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Reporter: Sarangan Rajamanickam >Assignee: Sergey Shakhnazarov >Priority: Critical > Labels: android, found-by-ci > > Android Builds (esp. on OSX) are failing in CI process. > Error: > Total time: 31.516 secs > Built the following apk(s): > > /Users/buildbot/slaves/apache/cordova-android-osx/mobilespec/platforms/android/build/outputs/apk/android-debug.apk > [MEDIC LOG Wed, 27 Apr 2016 12:29:23 GMT] running: > [MEDIC LOG Wed, 27 Apr 2016 12:29:23 GMT] ./cordova run --device android > -- --gradle > ANDROID_HOME=/Users/buildbot/Developer/android-sdk-macosx > JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home > Error: Failed to deploy to device, no devices found. > [MEDIC LOG Wed, 27 Apr 2016 12:29:31 GMT] no device found, so switching to > emulator > [MEDIC LOG Wed, 27 Apr 2016 12:29:31 GMT] Attempting to start Android emulator > Link: https://ci.apache.org/builders/cordova-android-osx > This started failing from build 2445: Link: > https://ci.apache.org/builders/cordova-android-osx/builds/2445 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11150) CI Error - Windows Platform - Could not find XHR config file
[ https://issues.apache.org/jira/browse/CB-11150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarangan Rajamanickam closed CB-11150. -- > CI Error - Windows Platform - Could not find XHR config file > - > > Key: CB-11150 > URL: https://issues.apache.org/jira/browse/CB-11150 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sarangan Rajamanickam >Assignee: Sergey Shakhnazarov >Priority: Critical > Labels: found-by-ci > > The CI builds for Windows Phone 8.1 and Windows Store 8.1 platforms are > failing consistently. Link: https://ci.apache.org/waterfall?category=cordova > On analysis, the failure began with this commit: > 1. > https://github.com/apache/cordova-windows/commit/d6988f5c863ec3ba5cde33a678a4b93badc64395 > 2. https://ci.apache.org/builders/cordova-windows-store8.1/builds/2218 > Assigning this issue to Sergey > Error: > Channel: Microsoft-Windows-AppHost/Admin > Time Created: 2016-04-22T23:23:04.064399500Z > Process ID:7476 > Document File: /www/cdvtests/index.html > Display Name: mobilespec > Error Description: "[Windows][cordova.js][readConfig] Could not XHR > config.xml: {\"description\":\"The system cannot locate the resource > specified.\\r\\n\",\"number\":-2146697211,\"stack\":\"Error: The system > cannot locate the resource specified.\\r\\n\\n at readConfig > (ms-appx://org.apache.mobilespec/www/cordova.js:870:9)\\n at init > (ms-appx://org.apache.mobilespec/www/cordova.js:1517:25)\\n at Promise_ctor > (ms-appx://microsoft.winjs.2.0/js/base.js:2025:17)\\n at makePromise > (ms-appx://org.apache.mobilespec/www/cordova.js:1516:21)\\n at > activationHandler (ms-appx://org.apache.mobilespec/www/cordova.js:1525:17)\\n > at dispatchOne (ms-appx://microsoft.winjs.2.0/js/base.js:9416:25)\\n at > dispatchEvent (ms-appx://microsoft.winjs.2.0/js/base.js:9415:21)\\n at > drainOneEvent (ms-appx://microsoft.winjs.2.0/js/base.js:9469:13)\\n at > drainQueue (ms-appx://microsoft.winjs.2.0/js/base.js:9486:9)\\n at > Anonymous function (ms-appx://microsoft.winjs.2.0/js/base.js:2952:17)\"}" -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11188) cordova-plugin-device-motion-tests are failing in CI
[ https://issues.apache.org/jira/browse/CB-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarangan Rajamanickam reassigned CB-11188: -- Assignee: Sarangan Rajamanickam > cordova-plugin-device-motion-tests are failing in CI > > > Key: CB-11188 > URL: https://issues.apache.org/jira/browse/CB-11188 > Project: Apache Cordova > Issue Type: Test > Components: Plugin Device Motion >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: flaky, found-by-ci, triaged > > Error happening in multiple platforms. Sample Link: > https://ci.apache.org/builders/cordova-android-win/builds/2276/steps/getting-test-results/logs/stdio > > Sample Error > === > Total failures: 1 > Failing tests: > cordova-plugin-device-motion-tests.tests >> Accelerometer > (navigator.accelerometer) watchAcceleration accelerometer.spec.9 success > callback Acceleration object should return a recent timestamp > Expected 1462208916338 to be greater than 1462208916528. > Error: Expected 1462208916338 to be greater than 1462208916528. > at stack > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17) > at buildExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14) > at Spec.Env.expectationResultFactory > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18) > at Spec.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34) > at Expectation.addExpectationResult > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21) > at Expectation.toBeGreaterThan > (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12) > at win > (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:186:33) > at > file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:156:21 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11168) Fix the appName in cordova-medic
[ https://issues.apache.org/jira/browse/CB-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarangan Rajamanickam closed CB-11168. -- > Fix the appName in cordova-medic > > > Key: CB-11168 > URL: https://issues.apache.org/jira/browse/CB-11168 > Project: Apache Cordova > Issue Type: Test > Components: Medic >Reporter: Sarangan Rajamanickam >Assignee: Sarangan Rajamanickam > Labels: found-by-ci > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11209) targetWidth and targetHeight are not respected when taking a picture from SAVEDPHOTOALBUM or PHOTOLIBRARY and with destinationType=NATIVE_URI on iOS
[ https://issues.apache.org/jira/browse/CB-11209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-11209: --- Labels: iOS (was: ) > targetWidth and targetHeight are not respected when taking a picture from > SAVEDPHOTOALBUM or PHOTOLIBRARY and with destinationType=NATIVE_URI on iOS > > > Key: CB-11209 > URL: https://issues.apache.org/jira/browse/CB-11209 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Camera >Reporter: Alexander Sorokin > Labels: iOS > > Can be reproduced on mobilespec app on iOS: > Go to camera manual tests > Select sourceType = SAVEDPHOTOLIBRARY > Select destinationType = NATIVE_URI > Select targetWidth and targetHeight = 200 > Tap "Get Picture" > Tap a picture > Tap "Use" > Look at the console. In my case, it says "img size: 768x768" -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272644#comment-15272644 ] David Hooey commented on CB-11197: -- Thanks! I will create a sample project based on my existing. Installed cordova-android is 5.1.1. Device is Samsung Galaxy Tab S2 with Android 5.1.1. > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11183) Appium tests, Camera plugin: Better validation of the image
[ https://issues.apache.org/jira/browse/CB-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272592#comment-15272592 ] ASF GitHub Bot commented on CB-11183: - GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/209 CB-11183 Appium tests: Added image verification https://issues.apache.org/jira/browse/CB-11183 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-11183 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #209 commit 249e3c08694c8a039313c1b5e054010269fbff06 Author: Alexander SorokinDate: 2016-05-05T16:27:25Z CB-11183 Appium tests: Added image verification > Appium tests, Camera plugin: Better validation of the image > --- > > Key: CB-11183 > URL: https://issues.apache.org/jira/browse/CB-11183 > Project: Apache Cordova > Issue Type: Test > Components: Appium, Plugin Camera >Reporter: Alexander Sorokin >Assignee: Alexander Sorokin > > Right now Appium tests only check that we get the picture and the app doesn't > crash doing it. > Better validation needs to be performed. For example, we need to check if the > image has the right height and width. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11209) targetWidth and targetHeight are not respected when taking a picture from SAVEDPHOTOALBUM or PHOTOLIBRARY and with destinationType=NATIVE_URI on iOS
Alexander Sorokin created CB-11209: -- Summary: targetWidth and targetHeight are not respected when taking a picture from SAVEDPHOTOALBUM or PHOTOLIBRARY and with destinationType=NATIVE_URI on iOS Key: CB-11209 URL: https://issues.apache.org/jira/browse/CB-11209 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Alexander Sorokin Can be reproduced on mobilespec app on iOS: Go to camera manual tests Select sourceType = SAVEDPHOTOLIBRARY Select destinationType = NATIVE_URI Select targetWidth and targetHeight = 200 Tap "Get Picture" Tap a picture Tap "Use" Look at the console. In my case, it says "img size: 768x768" -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272327#comment-15272327 ] Vladimir Kotikov edited comment on CB-11197 at 5/5/16 1:35 PM: --- I can't reproduce the issue - This is odd, but in my case the status bar behaves the same way _despite of the plugin version installed_: 1. On Android 6.0.1 device it works exactly as you described - it appears along with the keyboard when i tap on the input field and doesn't disappear after keyboard is hidden. 2. On Android 4.3 status bar behaves as expected and doesn't show up when the keyboard pops up. All this looks like the different issue, related to the way how cordova-android handles {{Fullscreen}} preference and not to the StatusBar plugin directly (the CB-9696 is very similar) [~davidhooey], could you please attach the sample project where the problem reproduces? Also it'd be great if you could specify a version of cordova-android platform you're using and Android version on your device/emulator. was (Author: vladimir.kotikov): I can't reproduce the issue - This is odd, but in my case the status bar behaves the same way _despite of the plugin version installed_: 1. On Android 6.0.1 device it works exactly as you described - it appears along with the keyboard when i tap on the input field and doesn't disappear after keyboard is hidden. 2. On Android 4.3 status bar behaves as expected and doesn't show up when the keyboard pops up. All this looks like the different issue, related to the way how cordova-android handles {{Fullscreen}} preference and not to the StatusBar plugin directly [~davidhooey], could you please attach the sample project where the problem reproduces? Also it'd be great if you could specify a version of cordova-android platform you're using and Android version on your device/emulator. > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272327#comment-15272327 ] Vladimir Kotikov commented on CB-11197: --- I can't reproduce the issue - This is odd, but in my case the status bar behaves the same way _despite of the plugin version installed_: 1. On Android 6.0.1 device it works exactly as you described - it appears along with the keyboard when i tap on the input field and doesn't disappear after keyboard is hidden. 2. On Android 4.3 status bar behaves as expected and doesn't show up when the keyboard pops up. All this looks like the different issue, related to the way how cordova-android handles {{Fullscreen}} preference and not to the StatusBar plugin directly [~davidhooey], could you please attach the sample project where the problem reproduces? Also it'd be great if you could specify a version of cordova-android platform you're using and Android version on your device/emulator. > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-11197: -- Labels: cannot-reproduce regression triaged wfc (was: regression triaged) > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: cannot-reproduce, regression, triaged, wfc > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11208) cordova6.1.1(Android platform 5.1.1) gallery image is not uploading correctly in UI
manikandan created CB-11208: --- Summary: cordova6.1.1(Android platform 5.1.1) gallery image is not uploading correctly in UI Key: CB-11208 URL: https://issues.apache.org/jira/browse/CB-11208 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 6.1.1 Environment: Android environment Reporter: manikandan Uploading gallery image working properly in cordova(3.6.3) version. After upgrading cordova6.1.1(Android platform 5.1.1) gallery image is not uploading correctly. I am able to select the image from the gallery but selected image is not visible in the UI. Same time captured camera image is getting updated in the UI. I have checked with fileEntry.js var localURL = this.toInternalURL(); For version Cordova 6.1.1 url : cdvfile://localhost/content/media/external/images/media/506 For cordova(3.6.3) version url : content://media/external/images/media/511. fileEntry.prototype.file = function(){} inside the win method is not executing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11189) Deprecation and other Warnings with XCode 7.3 and InAppBrowser 1.4.0
[ https://issues.apache.org/jira/browse/CB-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danilo Cicognani updated CB-11189: -- Summary: Deprecation and other Warnings with XCode 7.3 and InAppBrowser 1.4.0 (was: Deprecation Warnings with XCode 7.3 and InAppBrowser 1.4.0) > Deprecation and other Warnings with XCode 7.3 and InAppBrowser 1.4.0 > > > Key: CB-11189 > URL: https://issues.apache.org/jira/browse/CB-11189 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser >Affects Versions: 1.4.0 > Environment: XCode 7.3 >Reporter: Danilo Cicognani > Labels: easyfix, ios, triaged > > After adding plugin InAppBrowser XCode 7.3 repors some warning. > To test I created a test app: > cordova create testPlugin com.example.testplugin testPlugin > cd testPlugin > cordova platform add ios > cordova plugin add cordova-plugin-inappbrowser > Then I opened XCode and run the App. I got these warnings: > 'UIBarButtonItemStyleBordered' is deprecated: first deprecated in iOS 8.0 - > Use UIBarButtonItemStylePlain when minimum deployment target is iOS7 or later. > Null passed to a callee that requires a non-null argument > Conflicting return type in implementation of 'supported interface > orientations': 'UIInterfaceOrientationMask' (aka 'enum > UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned int') -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11207) "There was a network error" message is getting displayed when call network url from Cordova-android 5.1.1 webview
[ https://issues.apache.org/jira/browse/CB-11207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kush Patel updated CB-11207: Summary: "There was a network error" message is getting displayed when call network url from Cordova-android 5.1.1 webview (was: "There was a network error" message is getting displayed when call network url from Cordovawebview android) > "There was a network error" message is getting displayed when call network > url from Cordova-android 5.1.1 webview > - > > Key: CB-11207 > URL: https://issues.apache.org/jira/browse/CB-11207 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Whitelist >Affects Versions: 5.1.1 > Environment: cordova-android 5.1.1 >Reporter: Kush Patel > Labels: android, cordova-5.1.1, cordova-plugin, whitelist > Fix For: 5.1.1 > > > http://stackoverflow.com/questions/37044969/cordova-5-1-1-there-was-a-network-error-message-in-onreceivederror-method-when > Watch this question on stackoverflow for further description. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11207) "There was a network error" message is getting displayed when call network url from Cordovawebview android
Kush Patel created CB-11207: --- Summary: "There was a network error" message is getting displayed when call network url from Cordovawebview android Key: CB-11207 URL: https://issues.apache.org/jira/browse/CB-11207 Project: Apache Cordova Issue Type: Bug Components: Plugin Whitelist Affects Versions: 5.1.1 Environment: cordova-android 5.1.1 Reporter: Kush Patel Fix For: 5.1.1 http://stackoverflow.com/questions/37044969/cordova-5-1-1-there-was-a-network-error-message-in-onreceivederror-method-when Watch this question on stackoverflow for further description. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11197) Android status bar appears when keyboard pops up.
[ https://issues.apache.org/jira/browse/CB-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Kotikov updated CB-11197: -- Environment: cordova 6.1.1 cordova-plugin-console 1.0.2 "Console" cordova-plugin-device 1.1.0 "Device" cordova-plugin-file 3.0.0 "File" cordova-plugin-file-transfer 1.4.0 "File Transfer" cordova-plugin-statusbar 2.1.3 "StatusBar" cordova-plugin-whitelist 1.2.0 "Whitelist" was: {code} cordova 6.1.1 cordova-plugin-console 1.0.2 "Console" cordova-plugin-device 1.1.0 "Device" cordova-plugin-file 3.0.0 "File" cordova-plugin-file-transfer 1.4.0 "File Transfer" cordova-plugin-statusbar 2.1.3 "StatusBar" cordova-plugin-whitelist 1.2.0 "Whitelist" {code} > Android status bar appears when keyboard pops up. > - > > Key: CB-11197 > URL: https://issues.apache.org/jira/browse/CB-11197 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Statusbar >Affects Versions: 2.1.0 > Environment: cordova 6.1.1 > cordova-plugin-console 1.0.2 "Console" > cordova-plugin-device 1.1.0 "Device" > cordova-plugin-file 3.0.0 "File" > cordova-plugin-file-transfer 1.4.0 "File Transfer" > cordova-plugin-statusbar 2.1.3 "StatusBar" > cordova-plugin-whitelist 1.2.0 "Whitelist" >Reporter: David Hooey >Assignee: Vladimir Kotikov > Labels: regression, triaged > > When configuring for full screen app, the statusbar will appear when the > keyboard pops up for input. The iOS build is fine. The previous version > {{cordova-plugin-statusbar 2.0.0}} does not exhibit this problem. > {code} > > > > {code} > Also mentioned in this > [post|http://stackoverflow.com/questions/36156357/cordova-status-bar-plugin-doesnt-work-in-android-when-keyboard-pops-up]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11200) Cordova-lib test failure on Node 6.0.0
[ https://issues.apache.org/jira/browse/CB-11200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272182#comment-15272182 ] Vladimir Kotikov commented on CB-11200: --- Here is the PR to node-xcode: https://github.com/alunny/node-xcode/pull/86 > Cordova-lib test failure on Node 6.0.0 > -- > > Key: CB-11200 > URL: https://issues.apache.org/jira/browse/CB-11200 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Affects Versions: Master > Environment: Windows, OSX >Reporter: Alexander Sorokin >Assignee: Vladimir Kotikov >Priority: Critical > Labels: triaged > > When running "npm test" in cordova-lib folder, the following test fails on > Node 6.0.0: > {noformat} > 1) ios project handler uninstallation of elements with > custom="true" attribute should rm the file from the right target location >Message: > TypeError: Path must be a string. Received undefined >Stacktrace: > TypeError: Path must be a string. Received undefined > at assertPath (path.js:7:11) > at Object.dirname (path.js:697:5) > at searchPathForFile > (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:985:24) > at pbxProject.removeFromFrameworkSearchPaths > (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:711:20) > at pbxProject.removeFramework > (C:\Cordova\cordova-lib\cordova-lib\node_modules\xcode\lib\pbxProject.js:222:12) > at Object.module.exports.framework.uninstall > (C:\Cordova\cordova-lib\cordova-lib\src\plugman\platforms\ios.js:230:41) > at . > (C:\Cordova\cordova-lib\cordova-lib\spec-plugman\platforms\ios.spec.js:441:38) > {noformat} > Initial investigation points out that the bug in node-xcode can be the cause > of this. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11206) Contacts plugin causes app crash
Petr Odut created CB-11206: -- Summary: Contacts plugin causes app crash Key: CB-11206 URL: https://issues.apache.org/jira/browse/CB-11206 Project: Apache Cordova Issue Type: Bug Components: Plugin Contacts Reporter: Petr Odut On Samsung phone app crashes instantly with a stack trace: {noformat} java.lang.NumberFormatException java.lang.Integer.invalidInt(Integer.java:138) java.lang.Integer.parseInt(Integer.java:358) java.lang.Integer.parseInt(Integer.java:334) org.apache.cordova.contacts.ContactAccessorSdk5.imQuery(ContactAccessorSdk5.java:907) org.apache.cordova.contacts.ContactAccessorSdk5.populateContactArray(ContactAccessorSdk5.java:435) org.apache.cordova.contacts.ContactAccessorSdk5.search(ContactAccessorSdk5.java:282) org.apache.cordova.contacts.ContactManager$3.run(ContactManager.java:209) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) java.lang.Thread.run(Thread.java:818) {noformat} JS code to retrieve contacts, on Sony phone the same code works properly: {code:javascript} if(navigator.contacts) { var options = new ContactFindOptions(); options.multiple = true; options.hasPhoneNumber = true; navigator.contacts.find([navigator.contacts.fieldType.phoneNumbers], contacts => { this.phoneContacts = contacts; d.resolve(contacts); }, e => d.reject(e), options); } {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272002#comment-15272002 ] ASF GitHub Bot commented on CB-9858: Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217091665 LGTM > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9858) Implement Cordova Fetch Proposal
[ https://issues.apache.org/jira/browse/CB-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271979#comment-15271979 ] ASF GitHub Bot commented on CB-9858: Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-217087853 Made the changes. LMK. > Implement Cordova Fetch Proposal > > > Key: CB-9858 > URL: https://issues.apache.org/jira/browse/CB-9858 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > https://github.com/cordova/cordova-discuss/pull/33 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11199) Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2
[ https://issues.apache.org/jira/browse/CB-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271959#comment-15271959 ] Caner Patır commented on CB-11199: -- Encode : function (path, file) { var q = $q.defer(); if ((/^\//.test(file))) { q.reject('file-name cannot start with \/'); } try { $window.resolveLocalFileSystemURL(path, function (fileSystem) { fileSystem.getFile(file, { create: false }, function (fileEntry) { fileEntry.file(function (fileData) { var reader = new FileReader(); reader.onloadend = function (evt) { if (evt.target.result !== undefined || evt.target.result !== null) { q.resolve(evt.target.result); } else if (evt.target.error !== undefined || evt.target.error !== null) { q.reject(evt.target.error); } else { q.reject({ code: null, message: 'READER_ONLOADEND_ERR' }); } }; reader.readAsDataURL(fileData); }); }, function (error) { error.message = $cordovaFileError[error.code]; q.reject(error); }); }, function (err) { err.message = $cordovaFileError[err.code]; q.reject(err); }); } catch (e) { e.message = $cordovaFileError[e.code]; q.reject(e); } return q.promise; }, Decode with c#: string base64 = ; var bytes = Convert.FromBase64String(base64); > Plugin File: FileReader readAsDataURL does not work with JPG on Android 4.4.2 > - > > Key: CB-11199 > URL: https://issues.apache.org/jira/browse/CB-11199 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File >Affects Versions: 4.2.0 > Environment: Android 4.4.2 >Reporter: Caner Patır > Labels: Android, triaged, wfc > > FileReader readAsDataURL method encodes invalid base64 data for a jpeg image. > I could not decode the generate base64 data. But iI tried the same situation > on version 4.1.1 it works successfully. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10844) Site-wide search doesn't work
[ https://issues.apache.org/jira/browse/CB-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271949#comment-15271949 ] Robert Posener commented on CB-10844: - That seems to fit the need. I'm not convinced that it works 100% though. If you search for "locale" (without the quotes) you don't get hits on many pages that have the word "locale" on them (eg, Introduction, Customize Icons, GeoLocation and Splashscreen), but you do get hits on pages that DO NOT have "locale" on them (eg, containing "local"). There are other examples. Rob Regards *Rob Posener* 0419 012 627 > Site-wide search doesn't work > - > > Key: CB-10844 > URL: https://issues.apache.org/jira/browse/CB-10844 > Project: Apache Cordova > Issue Type: Bug > Components: Docs >Affects Versions: 6.0.0 >Reporter: Robert Posener >Assignee: Dmitry Blotsky >Priority: Minor > Labels: triaged > > No matter what you enter as search criteria (eg, "preference", "bluetooth", > "fred" and "rubbish" you always get 11,800 results and none of them are > "matches". -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org