[jira] [Commented] (CB-11641) MediaError object missing message member

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525285#comment-15525285
 ] 

ASF GitHub Bot commented on CB-11641:
-

GitHub user matrosov-nikita opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/117

CB-11641 android: add 'message' field to media error



### Platforms affected
Android

### What does this PR do?
It was not possible before to get error message.This updated Android 
implementation to return error code with message similar to iOS.

### What testing has been done on this change?
Auto test

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosov-nikita/cordova-plugin-media 
CB-11641-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 9d0261c3ac9b7ccd1dc0d6873bd181f5121e6e68
Author: Nikita Matrosov 
Date:   2016-09-27T06:49:24Z

CB-11641 android: add 'message' field to media error

It was not possible before to get error message.This updated Android 
implementation to return error code with message similar to iOS.




> MediaError object missing message member
> 
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
>
> on iOS, the MediaError object contains both the error code and the message. 
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+ 
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not 
> documented. 
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11641) MediaError object missing message member

[Nikita Matrosov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikita Matrosov reassigned CB-11641:


Assignee: Nikita Matrosov

> MediaError object missing message member
> 
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
>
> on iOS, the MediaError object contains both the error code and the message. 
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+ 
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not 
> documented. 
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11909) Updating command in coho (prepare-release-branch) - grab the argv.version from package.json

[Audrey So (JIRA)]

Audrey So created CB-11909:
--

 Summary: Updating command in coho (prepare-release-branch) - grab 
the argv.version from package.json
 Key: CB-11909
 URL: https://issues.apache.org/jira/browse/CB-11909
 Project: Apache Cordova
  Issue Type: Bug
Reporter: Audrey So
Assignee: Audrey So
Priority: Trivial


If no version is passed in, grab the version from package.json



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-10929) OSX icon and filter ability missing from plugins site

[Audrey So (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So resolved CB-10929.

Resolution: Fixed

Merged to master and will be live when the site is updated next

> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524559#comment-15524559
 ] 

ASF GitHub Bot commented on CB-10929:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/643


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524558#comment-15524558
 ] 

ASF subversion and git services commented on CB-10929:
--

Commit a3589ce66336821f2fd714a1115125cfcfa9fd1b in cordova-docs's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=a3589ce ]

CB-10929 changed OXS to macOS on filter button

 This closes #643


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524554#comment-15524554
 ] 

ASF GitHub Bot commented on CB-10929:
-

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-docs/pull/643

CB-10929 changed OXS to macOS on filter button

CB-10929 changed OXS to macOS on filter button

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #643


commit 39edb391e78bd4d8f2eb6423df08955b7b43bf5f
Author: audreyso 
Date:   2016-09-26T23:38:51Z

CB-10929 added OXS filter button to plugin search and removed fire os 
filter button

commit 83538adb285122f4a3245cda498f48db41e50b3b
Author: audreyso 
Date:   2016-09-26T23:57:03Z

CB-10929 changed OXS to macOS on filter button




> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524535#comment-15524535
 ] 

ASF GitHub Bot commented on CB-10929:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-docs/pull/642
  
Send a new pr. I already closed this one :)


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524534#comment-15524534
 ] 

ASF GitHub Bot commented on CB-10929:
-

Github user audreyso commented on the issue:

https://github.com/apache/cordova-docs/pull/642
  
Sure! I can do that… that makes sense. Thanks for pointing that out.

From: Darryl Pogue 
Reply-To: apache/cordova-docs 
Date: Monday, September 26, 2016 at 4:46 PM
To: apache/cordova-docs 
Cc: auso , Author 
Subject: Re: [apache/cordova-docs] CB-10929 added OXS filter button to 
plugin search and removed fire os… (#642)


With 10.12, Apple rebranded their desktop OS to macOS. Maybe we want to say 
OSX / macOS?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.



> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524526#comment-15524526
 ] 

ASF GitHub Bot commented on CB-10929:
-

Github user dpogue commented on the issue:

https://github.com/apache/cordova-docs/pull/642
  
With 10.12, Apple rebranded their desktop OS to `macOS`. Maybe we want to 
say `OSX / macOS`?


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524527#comment-15524527
 ] 

ASF subversion and git services commented on CB-10929:
--

Commit 6c65415b020f6ddc864ce6b951c90b88dfda0cd4 in cordova-docs's branch 
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=6c65415 ]

CB-10929 added OXS filter button to plugin search and removed fire os filter 
button

 This closes #642


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524531#comment-15524531
 ] 

ASF GitHub Bot commented on CB-10929:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/642


> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10929) OSX icon and filter ability missing from plugins site

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524516#comment-15524516
 ] 

ASF GitHub Bot commented on CB-10929:
-

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-docs/pull/642

CB-10929 added OXS filter button to plugin search and removed fire os…

CB-10929 added OXS filter button to plugin search and removed fire os 
filter button

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #642


commit 39edb391e78bd4d8f2eb6423df08955b7b43bf5f
Author: audreyso 
Date:   2016-09-26T23:38:51Z

CB-10929 added OXS filter button to plugin search and removed fire os 
filter button




> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-10929) OSX icon and filter ability missing from plugins site

[Audrey So (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So reassigned CB-10929:
--

Assignee: Audrey So

> OSX icon and filter ability missing from plugins site
> -
>
> Key: CB-10929
> URL: https://issues.apache.org/jira/browse/CB-10929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Website
>Reporter: Raymond Camden
>Assignee: Audrey So
>Priority: Minor
>  Labels: triaged
>
> An icon to represent a plugin being usable on OSX is not showing up for 
> compatible plugins. Also, you can't actually filter by OSX. Credit for this 
> goes to [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml

[Steve Gill (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-11023.
-
Resolution: Fixed

> plugin.xml should be able to add attribute to an existing element in 
> AndroidManifest.xml
> 
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Reporter: Carlos Santana
>Assignee: Karen Tran
>
> We have a need for a plugin we develop to add the attribute android:name to 
> the  element to be able to point to a Class that tracks app 
> sessions for analytics.
> plugin.xml only support via  only to add elements to 
> AndroidManfist.xml this request is to add an enhancement to also handle 
> adding an attribute to an existing element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11023) plugin.xml should be able to add attribute to an existing element in AndroidManifest.xml

[Steve Gill (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-11023:

Assignee: Karen Tran

> plugin.xml should be able to add attribute to an existing element in 
> AndroidManifest.xml
> 
>
> Key: CB-11023
> URL: https://issues.apache.org/jira/browse/CB-11023
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI, Plugman
>Reporter: Carlos Santana
>Assignee: Karen Tran
>
> We have a need for a plugin we develop to add the attribute android:name to 
> the  element to be able to point to a Class that tracks app 
> sessions for analytics.
> plugin.xml only support via  only to add elements to 
> AndroidManfist.xml this request is to add an enhancement to also handle 
> adding an attribute to an existing element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524441#comment-15524441
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/493
  
Travis and appveyor failures are likely due to missing 
https://github.com/apache/cordova-lib/pull/492


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524436#comment-15524436
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
JSHint is failing for you


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-11907.
-
Resolution: Fixed

> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524372#comment-15524372
 ] 

ASF subversion and git services commented on CB-11907:
--

Commit 9586a7ddcd46b4d7bad432cf407f5c58f737d942 in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=9586a7d ]

CB-11907: Bumping Android Gradle Plugin version to 2.2 so this works with 
Android Studio


> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524377#comment-15524377
 ] 

ASF GitHub Bot commented on CB-11907:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/336


> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524373#comment-15524373
 ] 

ASF subversion and git services commented on CB-11907:
--

Commit 7de4803e21f852d8fd479ad58bc7cae2e314689c in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=7de4803 ]

CB-11907: Bumping Gradle to work with Android Studio 2.2 and the Android Gradle 
Plugin


> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524374#comment-15524374
 ] 

ASF subversion and git services commented on CB-11907:
--

Commit 9cf38f8705654e28ae2e2fa6d3044295afc6c185 in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=9cf38f8 ]

CB-11907: Bumping Gradle to work with Android Studio 2.2 and the Gradle Plugin, 
I should have done this last commit

This closes #336


> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524353#comment-15524353
 ] 

ASF GitHub Bot commented on CB-11907:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/336
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/336?src=pr) is 
35.15% (diff: 100%)
> Merging 
[#336](https://codecov.io/gh/apache/cordova-android/pull/336?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #336   diff @@
==
  Files12 12  
  Lines  1007   1007  
  Methods 198198  
  Messages  0  0  
  Branches168168  
==
  Hits354354  
  Misses  653653  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[a4f6c8b...616ed79](https://codecov.io/gh/apache/cordova-android/compare/a4f6c8bf7bf5ba49855f31831662f7964b17f962...616ed79782dfc4978a08db51069713f5d09decaf?src=pr)


> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524330#comment-15524330
 ] 

ASF GitHub Bot commented on CB-11907:
-

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/336

CB-11907: Upgrading the Gradle Plugins so they work with Android Studio 2.2

This is a PR to run against our CI before I put these into master.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #336






> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524309#comment-15524309
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/187/commits/f3a8fbe1c0737138d4b0e1b358b1c2d6d5d2c16b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/78//PLATFORM=android/artifact/)
 |
 



> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To 

[jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524259#comment-15524259
 ] 

ASF GitHub Bot commented on CB-11136:
-

Github user manucorporat commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
@shazron done!
renamed to tmpWindow and tmpController


> InAppBrowser fails to close with WKWebView OAuth 
> -
>
> Key: CB-11136
> URL: https://issues.apache.org/jira/browse/CB-11136
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>Affects Versions: 4.1.0
> Environment: iOS 8+ with WKWebView
>Reporter: Geordie Jay
>Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for 
> OAuth (e.g. Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another 
> view controller is presented. This can be confirmed by inspecting the 
> WKWebView session in Safari, running `window.open('http://something.com')` 
> and then trying to enter another command into that Safari console.
> I made a hacky but working version of this that animated in the 
> InAppBrowser's view manually, rather than 'presenting' the ViewController in 
> the traditional iOS style. In that instance the WKWebView thread continues as 
> normal and receives the confirmation to close the other InAppBrowser when the 
> OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big 
> usability fail for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the 
> InAppBrowser acceptable? Would be happy to make a pull request along these 
> lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11904) geolocation plugin release September 26, 2016

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524255#comment-15524255
 ] 

ASF subversion and git services commented on CB-11904:
--

Commit 7832b19b533f3322c742a577eed43f62cd2cb917 in cordova-plugin-geolocation's 
branch refs/heads/master from [~stevegill]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=7832b19
 ]

CB-11904 Incremented plugin version.


> geolocation plugin release September 26, 2016
> -
>
> Key: CB-11904
> URL: https://issues.apache.org/jira/browse/CB-11904
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11904) geolocation plugin release September 26, 2016

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524254#comment-15524254
 ] 

ASF subversion and git services commented on CB-11904:
--

Commit 111c7478232c99407b5a38fae512f5d0aa1828ec in cordova-plugin-geolocation's 
branch refs/heads/master from [~stevegill]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=111c747
 ]

CB-11904 Updated version and RELEASENOTES.md for release 2.4.0


> geolocation plugin release September 26, 2016
> -
>
> Key: CB-11904
> URL: https://issues.apache.org/jira/browse/CB-11904
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524229#comment-15524229
 ] 

ASF GitHub Bot commented on CB-11908:
-

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/493

CB-11908 Handle edit-config in config.xml on prepare

Needs this PR: https://github.com/apache/cordova-lib/pull/492

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib libEditConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #493


commit 34b50acee4fa9eb27d7225a3e4497c7917570667
Author: ktop 
Date:   2016-09-26T21:10:15Z

CB-11908 Handle edit-config in config.xml on prepare




> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524226#comment-15524226
 ] 

ASF GitHub Bot commented on CB-11908:
-

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-lib/pull/492

CB-11908 Add edit-config to config.xml

Handles edit-config for config.xml. 

Fixed up the conflict checking so that config.xml will take precedence over 
plugin.xml changes. 
Added a remove mode to config.xml only, explained more below. 

To test out these changes, remember to copy it to the platform's 
cordova-common. 

A couple things to discuss/clarify:
1. These changes will make config.xml changes take precedence over 
plugin.xml changes even if --force is used. Is this alright? Or should --force 
actually force add the plugin anyways? 

2. There's no real way to "undo" edit-config changes in config.xml. As a 
fix, I've added a "remove" mode that will remove the attributes specified. Do 
you think this is useful to have? There's no such thing as restoring/reverting 
the xml elements to what they were before. What was initially the old list of 
attributes from before the edit-config change will get overwritten on every 
prepare. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-lib editconfigxml

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #492


commit d0ce4c506d2f7f24bda145e21f9b9af1543b1ecd
Author: ktop 
Date:   2016-09-26T21:07:09Z

CB-11908 Add edit-config to config.xml




> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11908) Add edit-config to config.xml

[Karen Tran (JIRA)]

Karen Tran created CB-11908:
---

 Summary: Add edit-config to config.xml
 Key: CB-11908
 URL: https://issues.apache.org/jira/browse/CB-11908
 Project: Apache Cordova
  Issue Type: Improvement
  Components: CordovaCommon, CordovaLib
Affects Versions: Master
Reporter: Karen Tran
Assignee: Karen Tran
 Fix For: Master


edit-config tag in plugin.xml allows users to modify xml elements from plugins. 

This feature should be added to config.xml as well, so that users wouldn't need 
a plugin in order to modify xml elements. 

*config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-11907:

Component/s: Android

> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[Joe Bowser (JIRA)]

Joe Bowser created CB-11907:
---

 Summary: Cordova Android projects don't import cleanly into 
Android Studio 2.2
 Key: CB-11907
 URL: https://issues.apache.org/jira/browse/CB-11907
 Project: Apache Cordova
  Issue Type: Bug
Reporter: Joe Bowser
Priority: Blocker


Projects generated with master don't migrate cleanly into Android Studio since 
the last version bump.  This may be as trivial as changing the Android plugin 
used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11907) Cordova Android projects don't import cleanly into Android Studio 2.2

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser reassigned CB-11907:
---

Assignee: Joe Bowser

> Cordova Android projects don't import cleanly into Android Studio 2.2
> -
>
> Key: CB-11907
> URL: https://issues.apache.org/jira/browse/CB-11907
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Joe Bowser
>Assignee: Joe Bowser
>Priority: Blocker
>
> Projects generated with master don't migrate cleanly into Android Studio 
> since the last version bump.  This may be as trivial as changing the Android 
> plugin used, and the Gradle version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11343) Handle Java 9 after JEP 223

[Joe Bowser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-11343:

Priority: Minor  (was: Major)

> Handle Java 9 after JEP 223
> ---
>
> Key: CB-11343
> URL: https://issues.apache.org/jira/browse/CB-11343
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Affects Versions: 5.1.1
>Reporter: Andreas Kohn
>Assignee: Joe Bowser
>Priority: Minor
>
> `cordova requirements android` fails on a system with Java 9(-ea) installed 
> and accessible via PATH/JAVA_HOME:
> {code}
> $ cordova requirements android
> Requirements check results for android:
> Java JDK: not installed 
> Cannot read property '1' of null
> Android SDK: installed 
> Android target: installed 
> android-17,android-18,android-19,android-21,android-22,android-23,android-N
> Gradle: installed 
> Error: Some of requirements check failed
> $ echo $PATH
> /usr/lib64/qt-3.3/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/andreas/.local/bin:/home/andreas/bin:/usr/java/jdk-9/bin:/home/andreas/modules/apache-maven/bin:/home/andreas/modules/apache-ant/bin:/home/andreas/modules/mongodb/bin:/home/andreas/modules/node/bin:/home/andreas/modules/android-sdk-linux/tools:/home/andreas/modules/android-sdk-linux/platform-tools
> $ which javac
> /usr/java/jdk-9/bin/javac
> $ echo $JAVA_HOME
> /usr/java/jdk-9
> $ javac -version
> javac 9-ea
> $ java -version
> java version "9-ea"
> Java(TM) SE Runtime Environment (build 9-ea+120)
> Java HotSpot(TM) 64-Bit Server VM (build 9-ea+120, mixed mode)
> {code}
> The exception is caused by the regular expression magic in check_reqs.js, 
> `check_java` function:
> {code}
> var match = /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> {code}
> (5.2.0-dev is slightly different, but has the same issue).
> I think the easiest fix here is to change the expression to this:
> {code}
> var match = /javac ((?:\d+\.)*(?:\d+))/i.exec(output)[1];
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11903) Empty audio file on Android 4.2.2

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524129#comment-15524129
 ] 

Joe Bowser commented on CB-11903:
-

Ok, so the file isn't recording, or the file isn't being transferred?  Can you 
play the file locally after you recorded it? 

> Empty audio file on Android 4.2.2
> -
>
> Key: CB-11903
> URL: https://issues.apache.org/jira/browse/CB-11903
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, Plugin Media, Plugins
>Affects Versions: 2.4.0
> Environment: Android 4.2.2 (Huawei Y511-U30)
> cordova-android 5.2.0
> cordova-plugin-media 2.4.0
>Reporter: Stanislav Dzhus
>
> After update from 2.3.0 to 2.4.0 my device records empty .amr file
> I send my file to server. The size is 0. Here is a log from server (.wav file 
> is sent from iOS, it is not empty. Plugin version is the same):
> {code} 
> -rw-rw 1 www-data www-data
> 0 Sep 26 10:21 16-09-26_11-21-28_6wUo.amr
> -rw-rw 1 www-data www-data
> 0 Sep 26 10:20 16-09-26_11-20-10_UtMz.amr
> -rw-rw 1 www-data www-data
> 73728 Sep 26 10:13 16-09-26_11-13-05_yv2P.wav
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11617) [ubuntu] confusion between vertical and horizontal accuracy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524016#comment-15524016
 ] 

ASF GitHub Bot commented on CB-11617:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-geolocation/pull/79


> [ubuntu] confusion between vertical and horizontal accuracy
> ---
>
> Key: CB-11617
> URL: https://issues.apache.org/jira/browse/CB-11617
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Geolocation, Ubuntu
>Reporter: Alexandre Abreu
>Assignee: Alexandre Abreu
>
> The results sent back by the geolocalisation plugin are not 100% correct:
> - altitude can be false,
> - there is a confusion between the horizontal and vertical accuracy



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11906) Ajax call fails on iOS 10 but works fine on previous versions for Cordova application

[Nikita Ahluwalia (JIRA)]

Nikita Ahluwalia created CB-11906:
-

 Summary: Ajax call fails on iOS 10 but works fine on previous 
versions for Cordova application
 Key: CB-11906
 URL: https://issues.apache.org/jira/browse/CB-11906
 Project: Apache Cordova
  Issue Type: Bug
 Environment: ios10
Reporter: Nikita Ahluwalia


I am using the latest iOS platform and plugins in my cordova application. The 
app works fine on older versions of iOS but not on iOS 10. I am getting timeout 
error (I already have timeout in my application. But this seems to be even 
before establishing connection with web service). Tried removing platform and 
adding again. Also created a fresh project. Still no luck. The app works fine 
on Android as well. The same application pointing to webservice on staging 
environment works (on iOS 10 too) but when pointing to production APIs, it does 
not work on iOS 10 but works on older version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11829) Support Launch Storyboards

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523883#comment-15523883
 ] 

ASF GitHub Bot commented on CB-11829:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/114
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/114/commits/83a7ca0b02b6217ced8ca7116fd34b449fb06fc1)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/27//PLATFORM=android/artifact/)
 |
 



> Support Launch Storyboards
> --
>
> Key: CB-11829
> URL: https://issues.apache.org/jira/browse/CB-11829
> Project: Apache Cordova
>  Issue Type: Task
>  Components: iOS, Plugin SplashScreen
>Reporter: Kerri Shotts
>Assignee: Kerri Shotts
>
> Once CB-9762 is in place, the splash screen plugin will need to be updated. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11905) Error message when adding IAB to iOS project

[Steve Husting (JIRA)]

Steve Husting created CB-11905:
--

 Summary: Error message when adding IAB to iOS project
 Key: CB-11905
 URL: https://issues.apache.org/jira/browse/CB-11905
 Project: Apache Cordova
  Issue Type: Bug
  Components: CLI, iOS, Plugin InAppBrowser
Affects Versions: 1.4.0
 Environment: OS X El Capitan 10.11.6, ios 4.2.1
Reporter: Steve Husting
 Fix For: 1.4.0


When I ran cordova platform add ios on a new project for the first time, I got 
the error:

iOS project created with cordova-ios@4.2.1
Installing "cordova-plugin-inappbrowser" for ios
Failed to install 'cordova-plugin-inappbrowser':undefined
Error: Expected "/*" or ";" but "/" found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11904) geolocation plugin release September 26, 2016

[Steve Gill (JIRA)]

Steve Gill created CB-11904:
---

 Summary: geolocation plugin release September 26, 2016
 Key: CB-11904
 URL: https://issues.apache.org/jira/browse/CB-11904
 Project: Apache Cordova
  Issue Type: Task
Reporter: Steve Gill
Assignee: Steve Gill


Following steps at 
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6132) Globalization plugin method getDatePattern always returns short date style on iOS.

[Richard (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523434#comment-15523434
 ] 

Richard commented on CB-6132:
-

Looks like this is broken again. For me sample code returns:

[Log] pattern: dd/MM/yy
[Log] pattern: dd/MM/yy
[Log] pattern: dd/MM/yy
[Log] pattern: dd/MM/yy

Testing on iOS 9.0.2

> Globalization plugin method getDatePattern always returns short date style on 
> iOS.
> --
>
> Key: CB-6132
> URL: https://issues.apache.org/jira/browse/CB-6132
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Affects Versions: 3.4.0
> Environment: iOS 7
>Reporter: Alan Rahlf
>  Labels: ios, triaged
>
> Here are a few examples to demonstrate the problem:
> {code}
> navigator.globalization.getDatePattern(function(properties) {
> console.log('pattern: ' + properties.pattern); // prints "M/d/yy"
> }, function() {}, { formatLength: 'short', selector: 'date' });
> navigator.globalization.getDatePattern(function(properties) {
> console.log('pattern: ' + properties.pattern); // prints "M/d/yy"
> }, function() {}, { formatLength: 'medium', selector: 'date' });
> navigator.globalization.getDatePattern(function(properties) {
> console.log('pattern: ' + properties.pattern); // prints "M/d/yy"
> }, function() {}, { formatLength: 'long', selector: 'date' });
> navigator.globalization.getDatePattern(function(properties) {
> console.log('pattern: ' + properties.pattern); // prints "M/d/yy"
> }, function() {}, { formatLength: 'full', selector: 'date' });
> {code}
> As you can see, the pattern is the same for all format lengths.  This is 
> happening because in the iOS plugin code it's iterating over the options 
> dictionary keys, but because order matters, the logic inside the loop is 
> flawed.  Here's the block I'm referring to:
> {code}
> if (items && [items isKindOfClass:[NSMutableDictionary class]]) {
> NSEnumerator* enumerator = [items keyEnumerator];
> id key;
> // iterate through all the options
> while ((key = [enumerator nextObject])) {
> id item = [items valueForKey:key];
> // make sure that only string values are present
> if ([item isKindOfClass:[NSString class]]) {
> // get the desired format length
> if ([key isEqualToString:@"formatLength"]) {
> if ([item isEqualToString:@"short"]) {
> style = kCFDateFormatterShortStyle;
> } else if ([item isEqualToString:@"medium"]) {
> style = kCFDateFormatterMediumStyle;
> } else if ([item isEqualToString:@"long"]) {
> style = kCFDateFormatterLongStyle;
> } else if ([item isEqualToString:@"full"]) {
> style = kCFDateFormatterFullStyle;
> }
> }
> // get the type of date and time to generate
> else if ([key isEqualToString:@"selector"]) {
> if ([item isEqualToString:@"date"]) {
> dateStyle = style;
> timeStyle = kCFDateFormatterNoStyle;
> } else if ([item isEqualToString:@"time"]) {
> dateStyle = kCFDateFormatterNoStyle;
> timeStyle = style;
> } else if ([item isEqualToString:@"date and time"]) {
> dateStyle = style;
> timeStyle = style;
> }
> }
> }
> }
> }
> {code}
> The selector key runs first, which relies on the style variable being set 
> correctly, but this doesn't get set until the 2nd iteration of the loop when 
> the formatLength key is evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11154) Why timezone is not IANA ?

[Richard (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523165#comment-15523165
 ] 

Richard commented on CB-11154:
--

Any chance that this could be implemented? It seems like a small enough change. 
I installed this plugin specifically to get the long form timezone name.

> Why timezone is not IANA ?
> --
>
> Key: CB-11154
> URL: https://issues.apache.org/jira/browse/CB-11154
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Globalization
>Reporter: Simon Constans
>  Labels: triaged
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Hello,
> I don't understand why you don't return correctly the IANA timezone name?
> I think it's a simple information.
> I change my plugin for this repository: 
> https://github.com/StyrLabs/cordova-plugin-globalization
> You can see commit:
> - for Android: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/b251053cc7b0fa0b055544437c8a960afedab530
> - for iPhone: 
> https://github.com/StyrLabs/cordova-plugin-globalization/commit/1a67a5a94e45ecc037b3226f96ed3d2fab114c57
> Can you integrate it?
> Simon



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11028) Android version of the contacts plugin behaves differently for Contact Detail "type"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522856#comment-15522856
 ] 

ASF GitHub Bot commented on CB-11028:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/136
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/136/commits/200f1fdd9d69bdad2c3d4c315f6c4bc40159ae6e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/39//PLATFORM=android/artifact/)
 |
 



> Android version of the contacts plugin behaves differently for Contact Detail 
> "type"
> 
>
> Key: CB-11028
> URL: https://issues.apache.org/jira/browse/CB-11028
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Reporter: Tobias Mücksch
>Assignee: Nikita Matrosov
>  Labels: Android, triaged
>
> After inspecting the code for the android version of the plugin, I found out, 
> that for some reason the coders decided to return { ..., type: "custom", ... 
> } for contact details with custom labels. But the iOS Version returns the 
> actual custom label as type.
> Example:
> *iOS:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "My super fancy label",
> value: "+41 45654 214654"
> }]
> }
> {code}
> *Android:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "custom", // WHAT THE HECK?
> value: "+41 45654 214654"
> }]
> }
> {code}
> This behaviour is not exclusive to phoneNumbers. It's the same for all 
> ContactDetails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11350) Find with 'desiredFields' returns a field as null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522832#comment-15522832
 ] 

ASF GitHub Bot commented on CB-11350:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-contacts/pull/135
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-contacts/pull/135/commits/1940b1688e217acd5b40d8afcacef7a2e326409c)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/38//PLATFORM=android/artifact/)
 |
 



> Find with 'desiredFields' returns a field as null
> -
>
> Key: CB-11350
> URL: https://issues.apache.org/jira/browse/CB-11350
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: LG G4, Android 6
>Reporter: Maria Ines Parnisari
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: triaged
>
> Full repro here: https://github.com/miparnisari/ionic-demo
> When you run navigator.contacts.find() with the option 'desiredFields' set 
> including 'displayName', this particular field returns as null for all 
> contacts. However, if you do not set this option, the field is populated 
> properly for each contact.
> Also, it is unclear to me why when you use 'desiredFields' a full-blown 
> object is returned for each contact with almost every field set as null. 
> Wouldn't it make more sense to just return objects with those fields?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11878) The inAppBrowser acts weirldy

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522691#comment-15522691
 ] 

jcesarmobile commented on CB-11878:
---

The strange thing is that it works when using _self, loadstop is only supposed 
to work when using _blank

> The inAppBrowser acts weirldy
> -
>
> Key: CB-11878
> URL: https://issues.apache.org/jira/browse/CB-11878
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Reporter: Nasser Alminji
>Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
>  var ref;
> if (device.platform == 'Android') {
> ref = window.open('https://hadaf.pro', '_blank' 
> ,'location=no,toolbar=no');
> } else {
> ref = window.open('https://hadaf.pro', '_blank' 
> ,'location=no,toolbar=no');
> }
> /*
> var ref;
> if (device.platform == 'Android') {
> ref = window.open('http://192.168.1.7:3000', '_self' 
> ,'location=no,toolbar=no');
> } else {
> ref = window.open('http://192.168.1.7:3000', '_blank' 
> ,'location=no,toolbar=no');
> }
> */
> ref.addEventListener( "loadstop", function() {
> ref.executeScript({ 
> code: "localStorage.setItem('pushnotifId','"+regId+"'); 
> localStorage.setItem('platform','"+device.platform+"');"
> //code: "alert('InApp');if (typeof(Storage) !== 'undefined') 
> { alert('There is '); } else { alert('No local storage '); }; 
> localStorage.setItem('pushnotifId','"+regId+"'); 
> localStorage.setItem('platform','"+device.platform+"'); 
> alert('LocalStorage'+localStorage.getItem('platform'));"
> },function(data) { alert("Code Inserted Succesfully")});
> })
> In android I get "Code Inserted Succesfully" when using _blank in both 
> https://hadaf.pro and the local http://192..., however I get "Code Inserted 
> Succesfully" when using _self only in the http://192.. but not in the 
> https://hadaf.pro
> So basically local storage seems to act weirdly in _self;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11888) Phonegap webview gets cut when orientation changes

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-11888.
-
Resolution: Duplicate
  Assignee: jcesarmobile

Closing as duplicate of CB-11191

> Phonegap webview gets cut when orientation changes
> --
>
> Key: CB-11888
> URL: https://issues.apache.org/jira/browse/CB-11888
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlatforms
>Reporter: Rolando Arbitrario
>Assignee: jcesarmobile
>Priority: Critical
>
> There's a major bug on webview, when orientation changes. Sometimes the 
> webview gets cut off or means set in different orientation, that's why it's 
> showing cuts screen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11892) Online/Offline event not fired under ios10

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-11892.
-
Resolution: Duplicate
  Assignee: jcesarmobile

Closing as duplicate of CB-11891

> Online/Offline event not fired under ios10
> --
>
> Key: CB-11892
> URL: https://issues.apache.org/jira/browse/CB-11892
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: Alexandru Ghioroae
>Assignee: jcesarmobile
>
> The online/offline event seem to stop working on ios10



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11902) Cordova SQLite Plugin

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-11902.
-
Resolution: Invalid

SQLite isn't a core plugin, please, report the issue on the github plugin repo

> Cordova SQLite Plugin
> -
>
> Key: CB-11902
> URL: https://issues.apache.org/jira/browse/CB-11902
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: AllPlugins, Android
> Environment: Android 5.0 , cordova 6.3.1  cordova-sqlite-storage 1.4.7
>Reporter: Sumit Desai
>Priority: Blocker
>
> I'm using cordova SQLite plugin in my cordova mobile app project .
> DB is getting opened properly but after execution of any transaction like 
> select ,update delete etc I'm getting below error
> !JavaScript ERROR: Plugin SQLitePlugin.open is not supported
> Please suggest and help .
> Thanks in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11028) Android version of the contacts plugin behaves differently for Contact Detail "type"

[Nikita Matrosov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikita Matrosov reassigned CB-11028:


Assignee: Nikita Matrosov

> Android version of the contacts plugin behaves differently for Contact Detail 
> "type"
> 
>
> Key: CB-11028
> URL: https://issues.apache.org/jira/browse/CB-11028
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Reporter: Tobias Mücksch
>Assignee: Nikita Matrosov
>  Labels: Android, triaged
>
> After inspecting the code for the android version of the plugin, I found out, 
> that for some reason the coders decided to return { ..., type: "custom", ... 
> } for contact details with custom labels. But the iOS Version returns the 
> actual custom label as type.
> Example:
> *iOS:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "My super fancy label",
> value: "+41 45654 214654"
> }]
> }
> {code}
> *Android:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "custom", // WHAT THE HECK?
> value: "+41 45654 214654"
> }]
> }
> {code}
> This behaviour is not exclusive to phoneNumbers. It's the same for all 
> ContactDetails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11350) Find with 'desiredFields' returns a field as null

[Nikita Matrosov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikita Matrosov reassigned CB-11350:


Assignee: Nikita Matrosov

> Find with 'desiredFields' returns a field as null
> -
>
> Key: CB-11350
> URL: https://issues.apache.org/jira/browse/CB-11350
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: LG G4, Android 6
>Reporter: Maria Ines Parnisari
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: triaged
>
> Full repro here: https://github.com/miparnisari/ionic-demo
> When you run navigator.contacts.find() with the option 'desiredFields' set 
> including 'displayName', this particular field returns as null for all 
> contacts. However, if you do not set this option, the field is populated 
> properly for each contact.
> Also, it is unclear to me why when you use 'desiredFields' a full-blown 
> object is returned for each contact with almost every field set as null. 
> Wouldn't it make more sense to just return objects with those fields?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11028) Android version of the contacts plugin behaves differently for Contact Detail "type"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522555#comment-15522555
 ] 

ASF GitHub Bot commented on CB-11028:
-

GitHub user matrosovN opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/136

CB-11028 android: Allow to set custom labels for contacts' fields



### Platforms affected
Android

### What does this PR do?
It was not possible before to retrieve the value of custom field's label 
(e.g. 'My phone'). The returned contact was always containing  for such fields. 
This updates Android implementation to return custom label's value rather than 
custom similar to iOS.

### What testing has been done on this change?
Auto test

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosovN/cordova-plugin-contacts CB-11028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit 200f1fdd9d69bdad2c3d4c315f6c4bc40159ae6e
Author: Nikita Matrosov 
Date:   2016-09-26T09:22:13Z

CB-11028 android: Allow to set custom labels for contacts' fields

It was not possible before to retrieve the value of custom field's label 
(e.g. 'My phone'). The returned contact was always containing  for such fields. 
This updates Android implementation to return custom label's value rather than 
custom similar to iOS.




> Android version of the contacts plugin behaves differently for Contact Detail 
> "type"
> 
>
> Key: CB-11028
> URL: https://issues.apache.org/jira/browse/CB-11028
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Reporter: Tobias Mücksch
>  Labels: Android, triaged
>
> After inspecting the code for the android version of the plugin, I found out, 
> that for some reason the coders decided to return { ..., type: "custom", ... 
> } for contact details with custom labels. But the iOS Version returns the 
> actual custom label as type.
> Example:
> *iOS:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "My super fancy label",
> value: "+41 45654 214654"
> }]
> }
> {code}
> *Android:*
> {code:javascript}
> {
> name: [ ... ],
> phoneNumbers: [{
> id: 1337,
> type: "custom", // WHAT THE HECK?
> value: "+41 45654 214654"
> }]
> }
> {code}
> This behaviour is not exclusive to phoneNumbers. It's the same for all 
> ContactDetails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11350) Find with 'desiredFields' returns a field as null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522543#comment-15522543
 ] 

ASF GitHub Bot commented on CB-11350:
-

GitHub user matrosovN opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/135

CB-11350 android: retrieve displayName for contact when specified in 
desiredFields



### Platforms affected
Android

### What does this PR do?
DisplayName wasn't being retrieved because of wrong condition in 
populateContactArray. This PR allows to retrieve displayName for contact when 
specified in desiredFields.

### What testing has been done on this change?
Auto test

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosovN/cordova-plugin-contacts CB-11350

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit 1940b1688e217acd5b40d8afcacef7a2e326409c
Author: Nikita Matrosov 
Date:   2016-09-26T08:42:56Z

CB-11350 android: retrieve displayName for contact when specified in 
desiredFields

displayName wasn't being retrieved because of wrong condition in 
populateContactArray




> Find with 'desiredFields' returns a field as null
> -
>
> Key: CB-11350
> URL: https://issues.apache.org/jira/browse/CB-11350
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: LG G4, Android 6
>Reporter: Maria Ines Parnisari
>Priority: Minor
>  Labels: triaged
>
> Full repro here: https://github.com/miparnisari/ionic-demo
> When you run navigator.contacts.find() with the option 'desiredFields' set 
> including 'displayName', this particular field returns as null for all 
> contacts. However, if you do not set this option, the field is populated 
> properly for each contact.
> Also, it is unclear to me why when you use 'desiredFields' a full-blown 
> object is returned for each contact with almost every field set as null. 
> Wouldn't it make more sense to just return objects with those fields?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11903) Empty audio file on Android 4.2.2

[Stanislav Dzhus (JIRA)]

Stanislav Dzhus created CB-11903:


 Summary: Empty audio file on Android 4.2.2
 Key: CB-11903
 URL: https://issues.apache.org/jira/browse/CB-11903
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android, Plugin Media, Plugins
Affects Versions: 2.4.0
 Environment: Android 4.2.2 (Huawei Y511-U30)
cordova-android 5.2.0
cordova-plugin-media 2.4.0
Reporter: Stanislav Dzhus


After update from 2.3.0 to 2.4.0 my device records empty .amr file
I send my file to server. The size is 0. Here is a log from server (.wav file 
is sent from iOS, it is not empty. Plugin version is the same):
{code} 
-rw-rw 1 www-data www-data0 
Sep 26 10:21 16-09-26_11-21-28_6wUo.amr
-rw-rw 1 www-data www-data0 
Sep 26 10:20 16-09-26_11-20-10_UtMz.amr
-rw-rw 1 www-data www-data73728 
Sep 26 10:13 16-09-26_11-13-05_yv2P.wav
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11694) hardwareback value persists across usages

[Nikita Matrosov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikita Matrosov reassigned CB-11694:


Assignee: Nikita Matrosov

> hardwareback value persists across usages
> -
>
> Key: CB-11694
> URL: https://issues.apache.org/jira/browse/CB-11694
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: 1.4.0
>Reporter: Jacob Weber
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: Android, android, triaged
>
> 1. Open an InAppBrowser without passing hardwareback. It will use the default 
> value ("yes"), so the hardware Back button will take you back in history.
> 2. Open an InAppBrowser and pass hardwareback=no. The hardware Back button 
> will close the browser.
> 3. Open an InAppBrowser without passing hardwareback. It will now use the 
> previous value ("no"), so the hardware Back button will take you back in 
> history. It should go back to the default value ("yes").



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11902) Cordova SQLite Plugin

[Sumit Desai (JIRA)]

Sumit Desai created CB-11902:


 Summary: Cordova SQLite Plugin
 Key: CB-11902
 URL: https://issues.apache.org/jira/browse/CB-11902
 Project: Apache Cordova
  Issue Type: Bug
  Components: AllPlugins, Android
 Environment: Android 5.0 , cordova 6.3.1  cordova-sqlite-storage 1.4.7
Reporter: Sumit Desai
Priority: Blocker


I'm using cordova SQLite plugin in my cordova mobile app project .

DB is getting opened properly but after execution of any transaction like 
select ,update delete etc I'm getting below error

!JavaScript ERROR: Plugin SQLitePlugin.open is not supported

Please suggest and help .

Thanks in advance.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11901) Ionic 2 In App Browser hides accessory bar by default

[tobias (JIRA)]

tobias created CB-11901:
---

 Summary: Ionic 2 In App Browser hides accessory bar by default
 Key: CB-11901
 URL: https://issues.apache.org/jira/browse/CB-11901
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin InAppBrowser
Affects Versions: 1.4.0
 Environment: Tested on ios 9
Reporter: tobias
Priority: Critical



0
down vote
favorite
I made my very first iOS app, but I'm having a problem with the keyboard. There 
is no way you can hide the keyboard. The accessorybar (with close/previous/next 
arrow) is not visible.

And another problem is that it does not close automatically after login. So the 
user ends up with a keyboard all over his screen. It only closes when you 
navigate inside the site.

the code is quite easy though, the app opens up the InAppBrowser and loads up a 
site where you need to login.

When clicked on login textfield: http://i.stack.imgur.com/kydAC.jpg
After login, keyboard stays open: http://i.stack.imgur.com/9JgEy.png

Code sample:
import {Component, ViewChild} from '@angular/core';
import {ionicBootstrap, Platform, MenuController, Nav} from 'ionic-angular';
import {StatusBar} from 'ionic-native';
import {HelloIonicPage} from './pages/hello-ionic/hello-ionic';
import {ListPage} from './pages/list/list';
import {InfoPage} from './pages/info/info';
import {InAppBrowser} from 'ionic-native';
import {Splashscreen} from 'ionic-native';
import {Keyboard} from 'ionic-native';

@Component({
  templateUrl: 'build/app.html'
})
class MyApp {
  @ViewChild(Nav) nav: Nav;

  // make HelloIonicPage the root (or first) page
  rootPage: any = HelloIonicPage;
  pages: Array<{title: string, component: any}>;
  inAppBrowserRef;

  constructor(
private platform: Platform,
private menu: MenuController
  ) {
document.addEventListener('resume', () => {
console.log("App has been resumed, reopen InAppBrowser url");
this.openInAppBrowser();
});
this.initializeApp();

// set our app's pages
this.pages = [
  { title: 'Launch', component: HelloIonicPage },
  { title: 'Info', component: InfoPage }, 
];
  }

  initializeApp() {
this.platform.ready().then(() => {
  // Okay, so the platform is ready and our plugins are available.
  // Here you can do any higher level native things you might need.
  StatusBar.styleDefault();
  //Show previous/next/done button on keyboard
  this.openInAppBrowser();
});
  }

  openInAppBrowser() {
//Directly load website
this.inAppBrowserRef = 
InAppBrowser.open("http://ws001.domeassistance.be:50001/";, "_blank", 
"location=no,fullscreen=yes,toolbar=no,clearcache=yes,clearsessioncache=yes");
  }
}

ionicBootstrap(MyApp);

Another mystery: when debugging with Phonegap on iOS I DO get the accessorybar, 
but not when i've build it into a real App?

URL to test yourself:
https://itunes.apple.com/us/app/dome-assistance-app/id1135786020?mt=8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org