[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252954#comment-16252954 ] ASF GitHub Bot commented on CB-13523: - dpogue opened a new pull request #762: CB-13523: Add automaticProvisioning to iOS signing docs URL: https://github.com/apache/cordova-docs/pull/762 Docs side of https://github.com/apache/cordova-ios/commit/5cb8bd199fe8df85272678d6d4c6343dd080f2a3 Also tried to clean up the manual flags to indicate that automatic signing is generally recommended, and you should only need to specify a provisioningProfile UUID if you're using manual signing. ### Platforms affected iOS ### What does this PR do? Adds docs for the `--automaticProvisioning` option This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252737#comment-16252737 ] ASF subversion and git services commented on CB-13523: -- Commit 5cb8bd199fe8df85272678d6d4c6343dd080f2a3 in cordova-ios's branch refs/heads/master from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=5cb8bd1 ] CB-13523: Add flag for Xcode-managed provisioning This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing. > Add build config option to enable Xcode automatic provisioning > -- > > Key: CB-13523 > URL: https://issues.apache.org/jira/browse/CB-13523 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios > Environment: Xcode 9 > Cordova-iOS 4.5.3 >Reporter: Darryl Pogue >Assignee: Darryl Pogue > > Xcode 9 made more changes to how provisioning works for apps, particularly > around manual vs automatic signing. > The changes required to support manual signing of release builds was > implemented as part of CB-13315. > In order for automatic signing to work, we need to pass an additional flag to > xcodebuild to allow Xcode to manage automatically updating provisioning > profiles as needed. I want to keep this being a build config option because > many people may not want to grant Xcode such power by default. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13523) Add build config option to enable Xcode automatic provisioning
[ https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252736#comment-16252736 ] ASF GitHub Bot commented on CB-13523: - surajpindoria closed pull request #347: CB-13523: Add flag for Xcode-managed provisioning URL: https://github.com/apache/cordova-ios/pull/347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/bin/templates/scripts/cordova/build b/bin/templates/scripts/cordova/build index 61d26cca3..bd5a61947 100755 --- a/bin/templates/scripts/cordova/build +++ b/bin/templates/scripts/cordova/build @@ -42,6 +42,7 @@ var buildOpts = nopt({ 'codeSignIdentity': String, 'codeSignResourceRules': String, 'provisioningProfile': String, +'automaticProvisioning': Boolean, 'developmentTeam': String, 'packageType': String, 'buildConfig' : String, diff --git a/bin/templates/scripts/cordova/lib/build.js b/bin/templates/scripts/cordova/lib/build.js index f51b084c1..b68262e9d 100644 --- a/bin/templates/scripts/cordova/lib/build.js +++ b/bin/templates/scripts/cordova/lib/build.js @@ -97,7 +97,7 @@ module.exports.run = function (buildOpts) { var buildType = buildOpts.release ? 'release' : 'debug'; var config = buildConfig.ios[buildType]; if (config) { -['codeSignIdentity', 'codeSignResourceRules', 'provisioningProfile', 'developmentTeam', 'packageType', 'buildFlag', 'iCloudContainerEnvironment'].forEach( +['codeSignIdentity', 'codeSignResourceRules', 'provisioningProfile', 'developmentTeam', 'packageType', 'buildFlag', 'iCloudContainerEnvironment', 'automaticProvisioning'].forEach( function (key) { buildOpts[key] = buildOpts[key] || config[key]; }); @@ -225,7 +225,7 @@ module.exports.run = function (buildOpts) { } function packageArchive () { -var xcodearchiveArgs = getXcodeArchiveArgs(projectName, projectPath, buildOutputDir, exportOptionsPath); +var xcodearchiveArgs = getXcodeArchiveArgs(projectName, projectPath, buildOutputDir, exportOptionsPath, buildOpts.automaticProvisioning); return spawn('xcodebuild', xcodearchiveArgs, projectPath); } @@ -337,15 +337,16 @@ function getXcodeBuildArgs (projectName, projectPath, configuration, isDevice, b * @param {String} projectPathPath to project file. Will be used to set CWD for xcodebuild * @param {String} outputPath Output directory to contain the IPA * @param {String} exportOptionsPath Path to the exportOptions.plist file + * @param {Boolean} autoProvisioning Whether to allow Xcode to automatically update provisioning * @return {Array} Array of arguments that could be passed directly to spawn method */ -function getXcodeArchiveArgs (projectName, projectPath, outputPath, exportOptionsPath) { +function getXcodeArchiveArgs (projectName, projectPath, outputPath, exportOptionsPath, autoProvisioning) { return [ '-exportArchive', '-archivePath', projectName + '.xcarchive', '-exportOptionsPlist', exportOptionsPath, '-exportPath', outputPath -]; +].concat(autoProvisioning ? ['-allowProvisioningUpdates'] : []); } function parseBuildFlag (buildFlag, args) { diff --git a/bin/templates/scripts/cordova/run b/bin/templates/scripts/cordova/run index 470384b52..c4cfca30a 100755 --- a/bin/templates/scripts/cordova/run +++ b/bin/templates/scripts/cordova/run @@ -45,6 +45,7 @@ var opts = nopt({ 'codeSignIdentity': String, 'codeSignResourceRules': String, 'provisioningProfile': String, +'automaticProvisioning': Boolean, 'buildConfig' : String, 'noSign' : Boolean }, { 'd' : '--verbose' }, args); diff --git a/tests/spec/unit/build.spec.js b/tests/spec/unit/build.spec.js index 6cf005c80..4b123361f 100644 --- a/tests/spec/unit/build.spec.js +++ b/tests/spec/unit/build.spec.js @@ -199,6 +199,20 @@ describe('build', function () { expect(archiveArgs.length).toEqual(7); done(); }); + +it('should generate the appropriate arguments for automatic provisioning', function (done) { +var archiveArgs = getXcodeArchiveArgs('TestProjectName', testProjectPath, '/test/output/path', '/test/export/options/path', true); +expect(archiveArgs[0]).toEqual('-exportArchive'); +expect(archiveArgs[1]).toEqual('-archivePath'); +expect(archiveArgs[2]).toEqual('TestProjectName.xcarchive'); +expect(archiveArgs[3]).toEqual('-exportOptionsPlist'); +
[jira] [Created] (CB-13577) bug with ionic cordova emulate android
gilles Godefroid created CB-13577: - Summary: bug with ionic cordova emulate android Key: CB-13577 URL: https://issues.apache.org/jira/browse/CB-13577 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova@7.0.0 Environment: ionic info : cli packages: (/usr/local/lib/node_modules) @ionic/cli-utils : 1.18.0 ionic (Ionic CLI) : 3.18.0 global packages: cordova (Cordova CLI) : 7.1.0 local packages: @ionic/app-scripts : 3.1.2 Cordova Platforms : android 6.3.0 ios 4.5.3 Ionic Framework: ionic-angular 3.9.2 System: ios-deploy : 1.9.2 ios-sim: 6.1.2 Node : v8.9.1 npm: 5.5.1 OS : macOS High Sierra Xcode : Xcode 9.1 Build version 9B55 Environment Variables: ANDROID_HOME : not set Misc: backend : pro Reporter: gilles Godefroid Assignee: Joe Bowser ionic cordova emulate android --list > cordova run android --list --emulator Available android virtual devices: Nexus_5_API_26 Nexus_6_API_23 ionic cordova emulate android --verbose [DEBUG] Reason for not using local CLI: LOCAL_CLI_NOT_FOUND [DEBUG] CLI flags: { interactive: true, confirm: false } [DEBUG] { cwd: '/Users/gillesgodefroid/Documents/Ionic2Weather', local: false, binPath: '/usr/local/lib/node_modules/ionic/bin/ionic', libPath: '/usr/local/lib/node_modules/ionic/dist/index.js' } [DEBUG] Daemon found (pid: 2011) Running app-scripts build: --platform android --target cordova [16:48:26] build dev started ... [16:48:26] clean started ... [16:48:26] clean finished in 122 ms [16:48:26] copy started ... [16:48:27] deeplinks started ... [16:48:27] deeplinks finished in 27 ms [16:48:27] transpile started ... [16:48:42] transpile finished in 14.95 s [16:48:42] preprocess started ... [16:48:42] preprocess finished in 4 ms [16:48:42] webpack started ... [16:48:44] copy finished in 17.39 s [16:48:52] webpack finished in 10.10 s [16:48:52] sass started ... [16:48:59] sass finished in 7.02 s [16:48:59] postprocess started ... [16:48:59] postprocess finished in 11 ms [16:48:59] lint started ... [16:48:59] build dev finished in 33.20 s > cordova emulate android [16:49:02] lint finished in 2.72 s ANDROID_HOME=/Users/gillesgodefroid/Library/Android/sdk JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home Error: spawn EACCES [ERROR] An error occurred while running cordova emulate android (exit code 1). [DEBUG] registerShutdownFunction process.exit/normal shutdown -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252631#comment-16252631 ] Darryl Pogue edited comment on CB-12886 at 11/14/17 10:51 PM: -- bq. As far as I remember, that didn't happen on a regular WKWebView, just on the plugin. That's correct. It only happens with the Cordova WKWebView plugin, it does not happen with a native project using WKWebView. [~Jespertheend] That second radar is closed because using {{viewport-fit=cover}} works in a native WKWebView. was (Author: dpogue): bq. As far as I remember, that didn't happen on a regular WKWebView, just on the plugin. That's correct. It only happens with the Cordova WKWebView plugin, it does not happen with a native project using WKWebView. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252631#comment-16252631 ] Darryl Pogue commented on CB-12886: --- bq. As far as I remember, that didn't happen on a regular WKWebView, just on the plugin. That's correct. It only happens with the Cordova WKWebView plugin, it does not happen with a native project using WKWebView. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252564#comment-16252564 ] Jesper van den Ende commented on CB-12886: -- Hmm, It might be a WKWebView bug. There's this one: http://www.openradar.me/35358020 And this one: http://www.openradar.me/32599304 although the last one is closed for some reason. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252544#comment-16252544 ] jcesarmobile commented on CB-12886: --- That doesn't look right to me, "viewport-fit=cover" should be enough, adding UIScrollViewContentInsetAdjustmentNever is a workaround to not use "viewport-fit=cover". We should check why it doesn't work on WKWebView. As far as I remember, that didn't happen on a regular WKWebView, just on the plugin. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252524#comment-16252524 ] Jesper van den Ende commented on CB-12886: -- Alright cool, Let me know if you need any help. I was thinking of adding an extra preference option to the config.xml similar to the AllowBackForwardNavigationGestures but I'm not sure if you'd rather implement this yourself. I don't think everyone wants to have this behaviour so I guess a preference would be nice. Also check out [the ionic fork|https://github.com/ionic-team/cordova-plugin-wkwebview-engine/blob/0ba9a65318d3b951755d7455df2bc10670b03162/src/ios/CDVWKWebViewEngine.m#L202]. Since that's basically where I got that line of code form. They have a bunch of extra guards and stuff. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252523#comment-16252523 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Ok, thought about that a bit. I assume now Travis works on all repos where it has access (so branches and also my forks with its branches) if a `travis.yml` exists, which it does. So Travis can be used both for branches and forks to see if the tests pass, and on `master` to do the same and also automatically deploy. Did I get this right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252511#comment-16252511 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150976912 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Ok, thought about that a bit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252243#comment-16252243 ] Suraj Pindoria commented on CB-12886: - [~Jespertheend] You are right that the error is actually with cordova-plugin-wkwebview-engine. I just tested adding the above code you mentioned and that does fix the issue. Once I finish off the current cordova-ios release I will work on getting the wkwebview plugin updated. > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226808#comment-16226808 ] jerome edited comment on CB-12886 at 11/14/17 9:34 PM: --- Hi all, I am following this thread since several weeks but I still can't make it work on my side. +My config : + - Cordova 7.0.1 - Cordova iOS 4.5.2 - last version of Xcode When I use the "cordova-plugin-ios11-inset-statusbar", all seems OK on "older" iPhone form factors up to the iPhone 8 and 8 Plus (status bar ok, no white bars, no space in forms pages) but I can't have a full screen app on iPhone X, even if I use Launch Storyboard Images or viewport-fit. This is a screen on an iPhone 8, all is ok : !https://c1.staticflickr.com/5/4487/26287471709_0dd9e596de_c.jpg! On the iPhone X I have many issues. When I use Launch storyboard images, I have a strange bug on the splash screen, there is a white bar on the bottom for some seconds then the image is stretched to full screen. Is it normal ? iPhone X splash screen with white bar for a few seconds : !https://c1.staticflickr.com/5/4494/38032828592_1f2e4924b6_c.jpg! iPhone X stretched splash screen. !https://c1.staticflickr.com/5/4479/24211179268_6c64a21360_b.jpg! And after, the app Is not in full screen even if I set "viewport-fit= cover » in my meta. I try some changes in the CSS with the safe area but same issue. !https://c1.staticflickr.com/5/4490/38010757616_1089985a8e_c.jpg! I can't find a solution :'( Can anyone help me please ? I really need your help because I think Apple will reject my app if it's not compliant to the iPhone X ;) Thx in advance ;) was (Author: jay34fr): Hi all, I am following this thread since several weeks but I still can't make it work on my side. +My config : + - Cordova 7.0.1 - Cordova iOS 4.5.2 - last version of Xcode When I use the "cordova-plugin-ios11-inset-statusbar", all seems OK on "older" iPhone form factors up to the iPhone 8 and 8 Plus (status bar ok, no white bars, no space in forms pages) but I can't have a full screen app on iPhone X, even if I use Launch Storyboard Images or viewport-fit. This is a screen on an iPhone 8, all is ok : !https://c1.staticflickr.com/5/4487/26287471709_0dd9e596de_c.jpg! On the iPhone X I have many issues. When I use Launch storyboard images, I have a strange bug on the splash screen, there is a white bar on the bottom for some seconds then the image is stretched to full screen. Is it normal ? iPhone X splash screen with white bar for a few seconds : !https://c1.staticflickr.com/5/4494/38032828592_1f2e4924b6_c.jpg! iPhone X stretched splash screen. !https://c1.staticflickr.com/5/4479/24211179268_6c64a21360_b.jpg! And after, the app Is not in full screen even if I set "viewport-fit= cover » in my meta. I try some changes in the CSS with the safe area but same issue. !https://c1.staticflickr.com/5/4490/38010757616_1089985a8e_c.jpg! I can't find a solution :'( Can anyone help me please ? I really need your help because I think Apple will reject my app if it's not compliant to the iPhone X ;) Here is the zip of my app. http://www.votreappli1.fr/jay/Sdis34/SDIS34_copie_2.zip Thx in advance ;) > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png, screenshot-6.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reed Richards updated CB-13575: --- Description: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: {code} need camera access to take pictures {code} This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like {code} need camera access to take pictures die Berechtigungen für den Zugriff zu deiner Kamera sind nötig autorises-tu l'accès à ton appareil photo? {code} was: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: {code} need camera access to take pictures {code} This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like {code} need camera access to take pictures die Berechtigungen für den Zugriff zu deine Kamera sind nötig autorises-tu l'accès à ton appareil photo? {code} > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > {code} > mode="merge"> > need camera access to take pictures > > {code} > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > {code} > mode="merge"> > need camera access to take pictures > die Berechtigungen für den Zugriff zu deiner Kamera sind > nötig > autorises-tu l'accès à ton appareil photo? > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reed Richards updated CB-13575: --- Description: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: {code} need camera access to take pictures {code} This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like {code} need camera access to take pictures die Berechtigungen für den Zugriff zu deine Kamera sind nötig autorises-tu l'accès à ton appareil photo? {code} was: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: {code} need camera access to take pictures {code} This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like {code} need camera access to take pictures ja ja genau c'est super {code} > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > {code} > mode="merge"> > need camera access to take pictures > > {code} > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > {code} > mode="merge"> > need camera access to take pictures > die Berechtigungen für den Zugriff zu deine Kamera sind > nötig > autorises-tu l'accès à ton appareil photo? > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13576) android cordova Could not open camera with
[ https://issues.apache.org/jira/browse/CB-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bahgat Samy Mashaly updated CB-13576: - Description: i can't use capture="camera" with cordova app in android device, although if i open the application from browser it work fine, I am sure the cordova app have all permissions to open camera when use cordova app: !https://i.stack.imgur.com/3nk2P.jpg! . .. . when use browser it work fine and ask to select an action: when use browser it work fine and ask to select an action : !https://i.stack.imgur.com/wb1mC.jpg! was: i can't use capture="camera" with cordova app in android device, although if i open the application from browser it work fine, I am sure the cordova app have all permissions to open camera when use cordova app: !https://i.stack.imgur.com/3nk2P.jpg! . .. . when use browser work fine: when use browser work fine: when use browser work fine: !https://i.stack.imgur.com/wb1mC.jpg! > android cordova Could not open camera with accept="image/*" capture="camera"> > > > Key: CB-13576 > URL: https://issues.apache.org/jira/browse/CB-13576 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Bahgat Samy Mashaly >Assignee: Joe Bowser >Priority: Critical > > i can't use capture="camera" with cordova app in android device, although if > i open the application from browser it work fine, I am sure the cordova app > have all permissions to open camera > when use cordova app: > !https://i.stack.imgur.com/3nk2P.jpg! > . > .. > . > when use browser it work fine and ask to select an action: > when use browser it work fine and ask to select an action : > > !https://i.stack.imgur.com/wb1mC.jpg! > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13576) android cordova Could not open camera with
[ https://issues.apache.org/jira/browse/CB-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bahgat Samy Mashaly updated CB-13576: - Description: i can't use capture="camera" with cordova app in android device, although if i open the application from browser it work fine, I am sure the cordova app have all permissions to open camera when use cordova app: !https://i.stack.imgur.com/3nk2P.jpg! . .. . when use browser work fine: when use browser work fine: when use browser work fine: !https://i.stack.imgur.com/wb1mC.jpg! was: i can't use capture="camera" with cordova app in android device, although if i open the application from browser it work fine, I am sure the cordova app have all permissions to open camera when use cordova app: !https://i.stack.imgur.com/3nk2P.jpg! hen use browser work fine: !https://i.stack.imgur.com/wb1mC.jpg! > android cordova Could not open camera with accept="image/*" capture="camera"> > > > Key: CB-13576 > URL: https://issues.apache.org/jira/browse/CB-13576 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Bahgat Samy Mashaly >Assignee: Joe Bowser >Priority: Critical > > i can't use capture="camera" with cordova app in android device, although if > i open the application from browser it work fine, I am sure the cordova app > have all permissions to open camera > when use cordova app: > !https://i.stack.imgur.com/3nk2P.jpg! > . > .. > . > when use browser work fine: > when use browser work fine: > when use browser work fine: > !https://i.stack.imgur.com/wb1mC.jpg! > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13576) android cordova Could not open camera with
Bahgat Samy Mashaly created CB-13576: Summary: android cordova Could not open camera with Key: CB-13576 URL: https://issues.apache.org/jira/browse/CB-13576 Project: Apache Cordova Issue Type: Bug Components: cordova-android Reporter: Bahgat Samy Mashaly Assignee: Joe Bowser Priority: Critical i can't use capture="camera" with cordova app in android device, although if i open the application from browser it work fine, I am sure the cordova app have all permissions to open camera when use cordova app: !https://i.stack.imgur.com/3nk2P.jpg! hen use browser work fine: !https://i.stack.imgur.com/wb1mC.jpg! -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252120#comment-16252120 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. Huh wait. Does Travis also work on my fork? I thought only on `master`. I am confused now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252114#comment-16252114 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. Huh wait. Does Travis also work on my Fork? I thought only on `master`. I am confused now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252113#comment-16252113 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950467 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,20 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. In [travis.yml](../.travis.yml), Travis installs required dependencies and runs the build script. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. You can read more about is happening under the hood with SVN [here](deploying-the-website.md). Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: > When Travis is done building and deploying, send a pull request and ask for a review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252111#comment-16252111 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha node_modules/.bin/gulp watch ### Next steps +When you are done with developing, you can [build and deploy](building-and-deploying-the-website.md) using the automated steps. -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +You can also [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. In case Travis build breaks, you may want to build and deploy manually. + +Here are a few use cases that Travis auto build and deploy doesn't cover: Review comment: Are these "developnig the website" tasks? Could move this over to `building-and-deploying-the-website.md` in a new subheadline "Not covered by automated build and deploy" (or similar) if not... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252109#comment-16252109 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150950232 ## File path: doc/developing-the-website.md ## @@ -13,5 +13,14 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha node_modules/.bin/gulp watch ### Next steps +When you are done with developing, you can [build and deploy](building-and-deploying-the-website.md) using the automated steps. -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +You can also [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. In case Travis build breaks, you may want to build and deploy manually. + +Here are a few use cases that Travis auto build and deploy doesn't cover: Review comment: Are these "developnig the website" tasks?I suggest to move this over to `building-and-deploying-the-website.md` in a new subheadline "Not covered by automated build and deploy" (or similar). Here this is a This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252101#comment-16252101 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Got it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252097#comment-16252097 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150949639 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Got it. 1,2,3 should definitely be added to the autmated deploy documentation then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252088#comment-16252088 ] Jan Piotrowski (Sujan) commented on CB-13575: - How is this done with native apps? `edit-config` copies something over to a `.plist`-file, so this is probably something done similar with true native apps. How do they handle multi language descriptions? > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > {code} > mode="merge"> > need camera access to take pictures > > {code} > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > {code} > mode="merge"> > need camera access to take pictures > ja ja genau > c'est super > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13575: Description: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: {code} need camera access to take pictures {code} This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like {code} need camera access to take pictures ja ja genau c'est super {code} was: With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: need camera access to take pictures This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like need camera access to take pictures ja ja genau c'est super > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > {code} > mode="merge"> > need camera access to take pictures > > {code} > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > {code} > mode="merge"> > need camera access to take pictures > ja ja genau > c'est super > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13573) Clarify Cordova Android 6.4.0 blog post
[ https://issues.apache.org/jira/browse/CB-13573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252075#comment-16252075 ] ASF GitHub Bot commented on CB-13573: - janpio opened a new pull request #761: CB-13573: Clarify Cordova Android 6.4.0 blog post URL: https://github.com/apache/cordova-docs/pull/761 - add link to gradle install instructions - add link to crosswalk project and issue (I created for this) - reword and restructure text a bit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Clarify Cordova Android 6.4.0 blog post > --- > > Key: CB-13573 > URL: https://issues.apache.org/jira/browse/CB-13573 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) > > Talked to user that had problems understanding what was actually required of > them (install standalone Gradle) and why this was happening. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251999#comment-16251999 ] ASF GitHub Bot commented on CB-13543: - audreyso commented on issue #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#issuecomment-344366275 Thanks for your feedback @stevengill @dblotsky @janpio ... made a few updates. Let me know if there's anything else! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13575) iOS Quirks: Internationalization of edit-config tags
[ https://issues.apache.org/jira/browse/CB-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reed Richards updated CB-13575: --- Summary: iOS Quirks: Internationalization of edit-config tags (was: Internationalization iOS Quirks edit-config tags) > iOS Quirks: Internationalization of edit-config tags > > > Key: CB-13575 > URL: https://issues.apache.org/jira/browse/CB-13575 > Project: Apache Cordova > Issue Type: Improvement > Components: AllPlugins >Reporter: Reed Richards > > With the release of the last plugins the 10th November 2017 > (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of > `edit-config` become a must to display the users the usage description of the > required permissions > As far as I understand, right now it's only possible to specify one `string` > value for an `edit-config` tag, for example: > mode="merge"> > need camera access to take pictures > > This isn't unfortunately enough for apps operating in several languages, > therefore, it should be possible for each `edit-config` tags to specify > multiple languages like > mode="merge"> > need camera access to take pictures > ja ja genau > c'est super > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13575) Internationalization iOS Quirks edit-config tags
Reed Richards created CB-13575: -- Summary: Internationalization iOS Quirks edit-config tags Key: CB-13575 URL: https://issues.apache.org/jira/browse/CB-13575 Project: Apache Cordova Issue Type: Improvement Components: AllPlugins Reporter: Reed Richards With the release of the last plugins the 10th November 2017 (http://cordova.apache.org/news/2017/11/10/plugins-release.html) the usage of `edit-config` become a must to display the users the usage description of the required permissions As far as I understand, right now it's only possible to specify one `string` value for an `edit-config` tag, for example: need camera access to take pictures This isn't unfortunately enough for apps operating in several languages, therefore, it should be possible for each `edit-config` tags to specify multiple languages like need camera access to take pictures ja ja genau c'est super -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251861#comment-16251861 ] ASF GitHub Bot commented on CB-13543: - stevengill commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150916965 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: You can! Incase travis builds break you may want to build + deploy manually. A few usecases that this travis auto build + deploy doesn't cover 1) Doesn't auto pull in translation changes 2) Doesn't update latest (7.x) from dev version of docs. Need to do this manually 3) Doesn't create a new version of the docs (future 8.x). Of course, you could do all 3 as commits and commit them and then travis will do the deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
[ https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251860#comment-16251860 ] ASF GitHub Bot commented on CB-13555: - jonathanli2 commented on a change in pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#discussion_r150916912 ## File path: src/ios/CDVNotification.m ## @@ -228,9 +228,19 @@ - (void)beep:(CDVInvokedUrlCommand*)command -(UIViewController *)getTopPresentedViewController { UIViewController *presentingViewController = self.viewController; -while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]) -{ -presentingViewController = presentingViewController.presentedViewController; +if (presentingViewController.view.window != [UIApplication sharedApplication].keyWindow){ +//for wkwebview, the privacy screen plugin is presented from a different window object +presentingViewController = [UIApplication sharedApplication].keyWindow.rootViewController; +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ +presentingViewController = presentingViewController.presentedViewController; +} +} +else { +//for uiwebview viewcontroller, if inappbrowser or privacyscreen viewcontroller is presented, +//then they should be used to repsent the new view control. +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ Review comment: Sure, I will remove the comment in a new commit. Jonathan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > (ios) Present notification view controller by inappbrowser view controller > -- > > Key: CB-13555 > URL: https://issues.apache.org/jira/browse/CB-13555 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-dialogs >Affects Versions: cordova-ios 4.5.0 > Environment: IOS 10 and 11 >Reporter: Jonathan Li > Labels: dialog, inappbrowser > Fix For: Master > > > When inappbrowser window is shown, if main uiwebview or wkwebview calls > cordova Dialog plugin method to show the dialog view, the dialog should show > to user on top of the inappbrowser view controller. > However, currently the dialog view is shown behind the inappbrowser view, so > user cannot see it or click button on the dialog > An similar issue was reported for barcode scanner plugin at > https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570 > The issue can be repeated with the below method > function confirm(){ > var win = window.open( "https://www.google.com";, "_blank" ); > win.addEventListener( "loadstop", function() { > setTimeout(function() { > function onConfirm(buttonIndex) { > console.log('You selected button ' + buttonIndex); > } > > navigator.notification.confirm( > 'You are the winner!', // message > onConfirm,// callback to invoke with index of button > pressed > 'Game Over', // title > ['Restart','Exit'] // buttonLabels > ); > }, 1000 ); > }); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13574) Blog post about Github move
Jan Piotrowski (Sujan) created CB-13574: --- Summary: Blog post about Github move Key: CB-13574 URL: https://issues.apache.org/jira/browse/CB-13574 Project: Apache Cordova Issue Type: Improvement Components: cordova-docs Reporter: Jan Piotrowski (Sujan) Short blog post about the move to Github. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13573) Clarify Cordova Android 6.4.0 blog post
Jan Piotrowski (Sujan) created CB-13573: --- Summary: Clarify Cordova Android 6.4.0 blog post Key: CB-13573 URL: https://issues.apache.org/jira/browse/CB-13573 Project: Apache Cordova Issue Type: Bug Components: cordova-docs Reporter: Jan Piotrowski (Sujan) Talked to user that had problems understanding what was actually required of them (install standalone Gradle) and why this was happening. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13573) Clarify Cordova Android 6.4.0 blog post
[ https://issues.apache.org/jira/browse/CB-13573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) reassigned CB-13573: --- Assignee: Jan Piotrowski (Sujan) > Clarify Cordova Android 6.4.0 blog post > --- > > Key: CB-13573 > URL: https://issues.apache.org/jira/browse/CB-13573 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) > > Talked to user that had problems understanding what was actually required of > them (install standalone Gradle) and why this was happening. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 The next code in iOS works correctly and in Android fails. {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("works ok"); console.log(entry); }, function(error){ console.log("error"); }); }, function cameraError(error){ }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("works ok"); console.log(entry); }, function(error){ console.log("error"); }); }, function cameraError(error){ }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is for example: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works. The response should be > file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 > The next code in iOS works correctly and in Android fails. > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > console.log("works ok"); > console.log(entry); > }, > function(error){ > console.log("error"); > }); > }, function cameraError(error){ > }, { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("works ok"); console.log(entry); }, function(error){ console.log("error"); }); }, function cameraError(error){ }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is for example: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works. The response should be > file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > console.log("works ok"); > console.log(entry); > }, > function(error){ > console.log("error"); > }); > }, function cameraError(error){ > }, { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.or
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file://storage/emu. {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is for example: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works. The response should be > file://storage/emu. > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > alert('s'); > console.log("yes"); > console.log(entry); > console.log(JSON.stringify(entry)); > }, > function(error){ > alert('n'); > console.log("error"); > console.log(JSON.stringify(error)); > }); > }, function cameraError(error){ > console.log("nnn"); > console.log(error); > > }, { > destinationType: Camera.DestinationType.FILE_URI, > sou
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works. The response should be file://storage/emu. {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is for example: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works. The response should be > file:///storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > alert('s'); > console.log("yes"); > console.log(entry); > console.log(JSON.stringify(entry)); > }, > function(error){ > alert('n'); > console.log("error"); > console.log(JSON.stringify(error)); > }); > }, function cameraError(error){ > console.log("nnn"); >
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is for example: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is for example: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > alert('s'); > console.log("yes"); > console.log(entry); > console.log(JSON.stringify(entry)); > }, > function(error){ > alert('n'); > console.log("error"); > console.log(JSON.stringify(error)); > }); > }, function cameraError(error){ > console.log("nnn"); > console.log(error); > > }, { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }); >
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} navigator.camera.getPicture( function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); }, function cameraError(error){ console.log("nnn"); console.log(error); }, { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }); {code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("Works Ok"); console.log(entry); }, function(error){ console.log("error"); console.log(entry); }); } function cameraError(error){ } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works > {code:javascript} > navigator.camera.getPicture( > function cameraSuccess(imageUri){ > > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > alert('s'); > console.log("yes"); > console.log(entry); > console.log(JSON.stringify(entry)); > }, > function(error){ > alert('n'); > console.log("error"); > console.log(JSON.stringify(error)); > }); > }, function cameraError(error){ > console.log("nnn"); > console.log(error); > > }, { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional com
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the resolveLocalFileSystemURL not works {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("Works Ok"); console.log(entry); }, function(error){ console.log("error"); console.log(entry); }); } function cameraError(error){ } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} was: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("Works Ok"); console.log(entry); }, function(error){ console.log("error"); console.log(entry); }); } function cameraError(error){ } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 and the > resolveLocalFileSystemURL not works > {code:javascript} > var options = { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }; > function cameraSuccess(imageUri){ > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > console.log("Works Ok"); > console.log(entry); > }, > function(error){ > console.log("error"); > console.log(entry); > }); > } > function cameraError(error){ > > } > navigator.camera.getPicture(cameraSuccess, cameraError, > options);{code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
[ https://issues.apache.org/jira/browse/CB-13572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Gonzalez updated CB-13572: Description: This error is only in Android. In other platforms works succesfully. If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable is for example: content://com.android.providers.media.documents/document/image%3A125 the resolveLocalFileSystemURL function works ok. If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the "imageUri" variable is: /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.VIDEO }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ console.log("Works Ok"); console.log(entry); }, function(error){ console.log("error"); console.log(entry); }); } function cameraError(error){ } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} was: {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.PICTURE }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); } function cameraError(error){ console.log("nnn"); console.log(error); } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} > resolveLocalFileSystemURL in camera.getPicture not works > > > Key: CB-13572 > URL: https://issues.apache.org/jira/browse/CB-13572 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Gonzalez >Priority: Critical > Labels: android > > This error is only in Android. In other platforms works succesfully. > If mediaType is "Camera.MediaType.PICTURE" works ok. The "imageUri" variable > is for example: > content://com.android.providers.media.documents/document/image%3A125 the > resolveLocalFileSystemURL function works ok. > If mediaType is "Camera.MediaType.VIDEO" or "Camera.MediaType.ALLMEDIA" the > "imageUri" variable is: > /storage/emulated/0/DCIM/Camera/VID_20171114_181057214.mp4 > {code:javascript} > var options = { > destinationType: Camera.DestinationType.FILE_URI, > sourceType: Camera.PictureSourceType.PHOTOLIBRARY, > mediaType: Camera.MediaType.VIDEO > }; > function cameraSuccess(imageUri){ > console.log(imageUri); > window.resolveLocalFileSystemURL(imageUri, > function(entry){ > console.log("Works Ok"); > console.log(entry); > }, > function(error){ > console.log("error"); > console.log(entry); > }); > } > function cameraError(error){ > > } > navigator.camera.getPicture(cameraSuccess, cameraError, > options);{code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
[ https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251769#comment-16251769 ] ASF GitHub Bot commented on CB-13555: - jcesarmobile commented on a change in pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#discussion_r150903309 ## File path: src/ios/CDVNotification.m ## @@ -228,9 +228,19 @@ - (void)beep:(CDVInvokedUrlCommand*)command -(UIViewController *)getTopPresentedViewController { UIViewController *presentingViewController = self.viewController; -while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]) -{ -presentingViewController = presentingViewController.presentedViewController; +if (presentingViewController.view.window != [UIApplication sharedApplication].keyWindow){ +//for wkwebview, the privacy screen plugin is presented from a different window object +presentingViewController = [UIApplication sharedApplication].keyWindow.rootViewController; +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ +presentingViewController = presentingViewController.presentedViewController; +} +} +else { +//for uiwebview viewcontroller, if inappbrowser or privacyscreen viewcontroller is presented, +//then they should be used to repsent the new view control. +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ Review comment: I don't really know what do you mean by "privacy screen plugin", that's why I said that it didn't make much sense. The problem is about InAppBrowser plugin, right? In InAppBrowser plugin, it's presented in a different window for both UIWebView and WKWebView. If you want to put a comment, you can do it before the if and say, something like "Some plugins might be presented from a different window than the app window" or something like that, but I think the code is clear enough. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > (ios) Present notification view controller by inappbrowser view controller > -- > > Key: CB-13555 > URL: https://issues.apache.org/jira/browse/CB-13555 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-dialogs >Affects Versions: cordova-ios 4.5.0 > Environment: IOS 10 and 11 >Reporter: Jonathan Li > Labels: dialog, inappbrowser > Fix For: Master > > > When inappbrowser window is shown, if main uiwebview or wkwebview calls > cordova Dialog plugin method to show the dialog view, the dialog should show > to user on top of the inappbrowser view controller. > However, currently the dialog view is shown behind the inappbrowser view, so > user cannot see it or click button on the dialog > An similar issue was reported for barcode scanner plugin at > https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570 > The issue can be repeated with the below method > function confirm(){ > var win = window.open( "https://www.google.com";, "_blank" ); > win.addEventListener( "loadstop", function() { > setTimeout(function() { > function onConfirm(buttonIndex) { > console.log('You selected button ' + buttonIndex); > } > > navigator.notification.confirm( > 'You are the winner!', // message > onConfirm,// callback to invoke with index of button > pressed > 'Game Over', // title > ['Restart','Exit'] // buttonLabels > ); > }, 1000 ); > }); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13572) resolveLocalFileSystemURL in camera.getPicture not works
David Gonzalez created CB-13572: --- Summary: resolveLocalFileSystemURL in camera.getPicture not works Key: CB-13572 URL: https://issues.apache.org/jira/browse/CB-13572 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Reporter: David Gonzalez Priority: Critical {code:javascript} var options = { destinationType: Camera.DestinationType.FILE_URI, sourceType: Camera.PictureSourceType.PHOTOLIBRARY, mediaType: Camera.MediaType.PICTURE }; function cameraSuccess(imageUri){ console.log(imageUri); window.resolveLocalFileSystemURL(imageUri, function(entry){ alert('s'); console.log("yes"); console.log(entry); console.log(JSON.stringify(entry)); }, function(error){ alert('n'); console.log("error"); console.log(JSON.stringify(error)); }); } function cameraError(error){ console.log("nnn"); console.log(error); } navigator.camera.getPicture(cameraSuccess, cameraError, options);{code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13555) (ios) Present notification view controller by inappbrowser view controller
[ https://issues.apache.org/jira/browse/CB-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251704#comment-16251704 ] ASF GitHub Bot commented on CB-13555: - jonathanli2 commented on a change in pull request #98: CB-13555 (ios) Present notification view controller by inappbrowser view controller URL: https://github.com/apache/cordova-plugin-dialogs/pull/98#discussion_r150892340 ## File path: src/ios/CDVNotification.m ## @@ -228,9 +228,19 @@ - (void)beep:(CDVInvokedUrlCommand*)command -(UIViewController *)getTopPresentedViewController { UIViewController *presentingViewController = self.viewController; -while(presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]) -{ -presentingViewController = presentingViewController.presentedViewController; +if (presentingViewController.view.window != [UIApplication sharedApplication].keyWindow){ +//for wkwebview, the privacy screen plugin is presented from a different window object +presentingViewController = [UIApplication sharedApplication].keyWindow.rootViewController; +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ +presentingViewController = presentingViewController.presentedViewController; +} +} +else { +//for uiwebview viewcontroller, if inappbrowser or privacyscreen viewcontroller is presented, +//then they should be used to repsent the new view control. +while (presentingViewController.presentedViewController != nil && ![presentingViewController.presentedViewController isBeingDismissed]){ Review comment: The while clause will be moved out the if-else block; and the whole else block will be removed. Should I keep the below comment in the if block? "//for wkwebview, the privacy screen plugin is presented from a different window object" Jonathan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > (ios) Present notification view controller by inappbrowser view controller > -- > > Key: CB-13555 > URL: https://issues.apache.org/jira/browse/CB-13555 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-dialogs >Affects Versions: cordova-ios 4.5.0 > Environment: IOS 10 and 11 >Reporter: Jonathan Li > Labels: dialog, inappbrowser > Fix For: Master > > > When inappbrowser window is shown, if main uiwebview or wkwebview calls > cordova Dialog plugin method to show the dialog view, the dialog should show > to user on top of the inappbrowser view controller. > However, currently the dialog view is shown behind the inappbrowser view, so > user cannot see it or click button on the dialog > An similar issue was reported for barcode scanner plugin at > https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/570 > The issue can be repeated with the below method > function confirm(){ > var win = window.open( "https://www.google.com";, "_blank" ); > win.addEventListener( "loadstop", function() { > setTimeout(function() { > function onConfirm(buttonIndex) { > console.log('You selected button ' + buttonIndex); > } > > navigator.notification.confirm( > 'You are the winner!', // message > onConfirm,// callback to invoke with index of button > pressed > 'Game Over', // title > ['Restart','Exit'] // buttonLabels > ); > }, 1000 ); > }); > } -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251530#comment-16251530 ] Lukas Plachy commented on CB-13536: --- Hi, so from the last item to the first: - The "reinstall cycles" are allready behind me :-/ This is one of first things Im trying, however when I finish the other commands, I shall retry, however due to the nature of our (main) project I have to downgrade npm in version in order to be able to compile. - As installing, im not sure what means "install directly", I expect the msi package from https://nodejs.org/en/ ... will retry through nvm. - As for the commands outputs: {{D:\XXX\nodejs>node -v v8.8.1 D:\XXX\nodejs>cordova -v 7.1.0 D:\XXX\nodejs>npm list -g --depth=0 D:\XXX\nodejs +-- colors@1.1.2 +-- cordova@7.1.0 +-- npm@5.5.1 +-- quasar-cli@0.6.4 `-- webpack-merge@4.1.1 }} - ad cordova create on empty directory: the same, see [^cordova_create_on_empty.png] - ad Windows language, it is CZE (CS) Windows 7 Pro 64bit SP1 Going to remove and install nodejs again using nvm and perform the test, please stand-by. > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_create_on_empty.png, cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Plachy updated CB-13536: -- Attachment: cordova_create_on_empty.png > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_create_on_empty.png, cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251480#comment-16251480 ] Jan Piotrowski (Sujan) commented on CB-13536: - Thanks, and sorry for the runaround. Now I have something we can start debugging. Run these commands please and post their output: {code} node -v cordova -v npm list -g --depth=0 {code} Did you install NodeJS directly or via nvm-windows or a similar tool? Could you also run the `cordova create ...` command in another, new and empty folder. What language is you Windows? May first advice would be: Uninstall and reinstall Cordova via `npm uninstall cordova` and then `npm install -g cordova`. Maybe there is just something wrong with your installation. If that doesn't help, try reinstalling nodejs via nvm-windows. That is only indirectly connected, but in my experience it fixes similar problems in 90% of the cases. > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json fi
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251480#comment-16251480 ] Jan Piotrowski (Sujan) edited comment on CB-13536 at 11/14/17 2:47 PM: --- Thanks, and sorry for the runaround. Now I have something we can start debugging. Run these commands please and post their output: {code} node -v cordova -v npm list -g --depth=0 {code} Did you install NodeJS directly or via nvm-windows or a similar tool? Could you also run the `cordova create ...` command in another, new and empty folder. Same error message? What language is you Windows? May first advice would be: Uninstall and reinstall Cordova via `npm uninstall cordova` and then `npm install -g cordova`. Maybe there is just something wrong with your installation. If that doesn't help, try reinstalling nodejs via nvm-windows. That is only indirectly connected, but in my experience it fixes similar problems in 90% of the cases. was (Author: sujan12): Thanks, and sorry for the runaround. Now I have something we can start debugging. Run these commands please and post their output: {code} node -v cordova -v npm list -g --depth=0 {code} Did you install NodeJS directly or via nvm-windows or a similar tool? Could you also run the `cordova create ...` command in another, new and empty folder. What language is you Windows? May first advice would be: Uninstall and reinstall Cordova via `npm uninstall cordova` and then `npm install -g cordova`. Maybe there is just something wrong with your installation. If that doesn't help, try reinstalling nodejs via nvm-windows. That is only indirectly connected, but in my experience it fixes similar problems in 90% of the cases. > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json fi
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251427#comment-16251427 ] Lukas Plachy edited comment on CB-13536 at 11/14/17 2:17 PM: - OK, done that, here is - what a surprise - the result: [^cordova_create_cordova.png] [^2017-11-14T14_08_29_042Z-debug.log] Yes and btw, should you try the testing ... the path (in the parts I had to anonymize - contains in the name of the directory a "@" character. was (Author: rheingold): OK, done that, here is - what a surprise - the result: [^cordova_create_cordova.png] [^2017-11-14T14_08_29_042Z-debug.log] > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json fi
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251427#comment-16251427 ] Lukas Plachy edited comment on CB-13536 at 11/14/17 2:16 PM: - OK, done that, here is - what a surprise - the result: [^cordova_create_cordova.png] [^2017-11-14T14_08_29_042Z-debug.log] was (Author: rheingold): OK, done that, here is - what a surprise - the result: !cordova_create_cordova.png|thumbnail! > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251427#comment-16251427 ] Lukas Plachy commented on CB-13536: --- OK, done that, here is - what a surprise - the result: !cordova_create_cordova.png|thumbnail! > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Plachy updated CB-13536: -- Attachment: cordova_create_cordova.png 2017-11-14T14_08_29_042Z-debug.log > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > 2017-11-14T14_08_29_042Z-debug.log, cordova_create_cordova.png, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json fi
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251411#comment-16251411 ] Lukas Plachy edited comment on CB-13536 at 11/14/17 2:13 PM: - as per answer on quasar support: "quasar wrap" calls "cordova create cordova [..rest of params]" then makes a symlink for /cordova/www to point to /dist folder. And this is it. Reference: https://github.com/quasarframework/quasar-cli/blob/dev/bin/wrappers/cordova/install.js#L43 You can manually do the above and then fill this out in the Cordova bug. was (Author: rheingold): as per answer on quasar support: "quasar wrap" calls "cordova create cordova [..rest of params]" then makes a symlink for /cordova/www to point to /dist folder. And this is it. Reference: https://github.com/quasarframework/quasar-cli/blob/dev/bin/wrappers/cordova/install.js#L43 You can manually do the above and then fill this out in the Cordova bug. > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13536) cordova being called from "quasar wrap" not working - cordova-realted error: Could not install from (path_of_nodejs_modules) as it does not contain a package.json file
[ https://issues.apache.org/jira/browse/CB-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251411#comment-16251411 ] Lukas Plachy commented on CB-13536: --- as per answer on quasar support: "quasar wrap" calls "cordova create cordova [..rest of params]" then makes a symlink for /cordova/www to point to /dist folder. And this is it. Reference: https://github.com/quasarframework/quasar-cli/blob/dev/bin/wrappers/cordova/install.js#L43 You can manually do the above and then fill this out in the Cordova bug. > cordova being called from "quasar wrap" not working - cordova-realted error: > Could not install from (path_of_nodejs_modules) as it does not contain a > package.json file > --- > > Key: CB-13536 > URL: https://issues.apache.org/jira/browse/CB-13536 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-app-hello-world, cordova-cli >Reporter: Lukas Plachy > Attachments: 2017-11-03T12_42_43_016Z-debug_anonymized.log, > cordova_wrap_fail.png > > > Hi, anybody an idea, whats wrong here (see attached image), before I'll have > to make a deepdive into the sources? Such error does not help when doing > first hands-on! > Note: has been reported to and rejected by quasar as not quasar-related. > Thanks > [^cordova_wrap_fail.png] -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13503) Problems with using plugins from local file system
[ https://issues.apache.org/jira/browse/CB-13503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251376#comment-16251376 ] Francesco D'Ambrosio commented on CB-13503: --- I have the same problem using _cordova (Cordova CLI) : 7.1.0_ > Problems with using plugins from local file system > -- > > Key: CB-13503 > URL: https://issues.apache.org/jira/browse/CB-13503 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlatforms, cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Mark Veenstra >Priority: Blocker > > I am struggling to get up and running with {{cordova@7.1.0}} sometime now. > Maybe I am doing something wrong here but I can't figure it out. It seems to > me something is going wrong with locally defined plugins that needs to be > installed and the way it is saved into {{package.json}}. > So to get upgraded I first installed the latest version {{npm install -g > cordova@7.1.0}}. Then I did a {{cordova prepare}}. > This {{prepare}} failed, after [some digging and > trying|https://github.com/dpa99c/cordova-diagnostic-plugin/issues/245] it > seemed that some locally plugins that needs to be installed into the project > are interrupting other plugins. So I needed to disable the {{cordova-fetch}}. > I set this globally with {{cordova config set fetch false}}. > After this config change the {{codova prepare}} command went all fine. So I > thought this is it. > But when I tried to let my project be build by my CI server it failed on > installating NPM packages. > Because a {{npm install}} command will install the dependencies defined in > {{package.json}} it will install the cordova plugins also. But in the > beginning my plugins are in there like this: > {code} > { > "name": "myApp", > "version": "1.0.0", > "description": "myApp description", > "dependencies": { > "cordova-android": "6.3.0", > "cordova-browser": "5.0.1", > "cordova-ios": "4.5.2", > "cordova-plugin-myplugin": "resources/cordova-plugin-myplugin", > "cordova-plugin-myplugin-locker": > "resources/cordova-plugin-myplugin-locker" > }, > "devDependencies": { > }, > "scripts": { > }, > "cordova": { > "platforms": [ > "browser", > "android", > "ios" > ], > "plugins": { > "cordova-plugin-myplugin": {}, > "cordova-plugin-myplugin-locker": {} > } > } > } > {code} > With above {{npm install}} fails and tries to get the dependecies from git, > which is incorrect. So I search the {{package.json}} definition and they say > I should put {{file:}} in front of it, like this: > {code} > { > "name": "myApp", > "version": "1.0.0", > "description": "myApp description", > "dependencies": { > "cordova-android": "6.3.0", > "cordova-browser": "5.0.1", > "cordova-ios": "4.5.2", > "cordova-plugin-myplugin": "file:resources/cordova-plugin-myplugin", > "cordova-plugin-myplugin-locker": > "file:resources/cordova-plugin-myplugin-locker" > }, > "devDependencies": { > }, > "scripts": { > }, > "cordova": { > "platforms": [ > "browser", > "android", > "ios" > ], > "plugins": { > "cordova-plugin-myplugin": {}, > "cordova-plugin-myplugin-locker": {} > } > } > } > {code} > Now NPM finds the dependecies OK, but now when I do a {{cordova prepare}} > again it throws an error that the plugin can't be installed from > {{file:resources/cordova-plugin-myplugin}}. > So I get stuck into different needs for different tools. Any ideas? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13507) git+https or git+ssh fails when trying to install
[ https://issues.apache.org/jira/browse/CB-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251373#comment-16251373 ] Francesco D'Ambrosio commented on CB-13507: --- I have the same problem > git+https or git+ssh fails when trying to install > - > > Key: CB-13507 > URL: https://issues.apache.org/jira/browse/CB-13507 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlatforms >Affects Versions: 7.0.2 > Environment: I am selecting 7.0.2 since it's the closest but I am > running cordova 7.1.0 > OS: Mac OS X Sierra. > Although I don't think it has anything to do with cordova-ios and > cordova-android, my platform versions are: > - android 6.3.0 > - ios 4.5.2 >Reporter: Pablo Caselas > Fix For: 7.0.2 > > > I start with adding plugin dependencies with https://.. on package.json > (no plugin references on config.xml) and no platforms or plugins installed > then I run "cordova platform ios". > It installs the plugins without any problem, but changes config.xml and > package.json plugin references from https to git+https, and ssh to git+ssh. > Failed to restore plugin "cordova-plugin-document-viewer" from config.xml. > You might need to try adding it again. Error: Failed to fetch plugin > git+https://github.com/kas84/cordova-plugin-document-viewer.git via registry -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13571) 'semver' property not found block the emulator
Vincent created CB-13571: Summary: 'semver' property not found block the emulator Key: CB-13571 URL: https://issues.apache.org/jira/browse/CB-13571 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: Master, 6.3.0 Environment: $ cordova requirement android {code} Requirements check results for android: Java JDK: installed 1.8.0 Android SDK: installed true Android target: installed android-27,android-26,android-25 Gradle: installed /Applications/Android Studio.app/Contents/gradle/gradle-4.1/bin/gradle Requirements check results for ios: Apple macOS: installed darwin Xcode: installed [object Object] ios-deploy: installed [object Object] CocoaPods: installed [object Object] {code} $ cordova info {code} Node version: v8.9.1 Cordova version: 7.1.0 Config.xml file: http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> MyApp An awesome Ionic/Cordova app. http://ionicframework.com/";>Ionic Framework Team http://*/*"; /> https://*/*"; /> mailto:*"; /> http://localhost:8100"; /> Plugins: cordova-plugin-device,cordova-plugin-ionic-webview,cordova-plugin-splashscreen,cordova-plugin-whitelist,ionic-plugin-keyboard Android platform: * The "android" command is deprecated. For manual SDK, AVD, and project management, please use Android Studio. For command-line tools, use tools/bin/sdkmanager and tools/bin/avdmanager * Running /Users/vincentherl/Library/Android/sdk/tools/bin/avdmanager list target Available Android targets:==] 100% Fetch remote repository... -- id: 1 or "android-25" Name: Android API 25 Type: Platform API level: 25 Revision: 3 -- id: 2 or "android-26" Name: Android API 26 Type: Platform API level: 26 Revision: 2 -- id: 3 or "android-27" Name: Android API 27 Type: Platform API level: 27 Revision: 1 iOS platform: Xcode 9.1 Build version 9B55 {code} Reporter: Vincent Assignee: Joe Bowser When run my application with android emulator, the error {code}Error: Cannot read property 'semver' of null{code} exit the process. You can see here the log trace : $ cordova run android --emulator -d {code} BUILD SUCCESSFUL Total time: 1.014 secs Command finished with error code 0: /Users/vincentherl/Documents/lire/platforms/android/gradlew cdvBuildDebug,-b,/Users/vincentherl/Documents/lire/platforms/android/build.gradle,-Dorg.gradle.daemon=true,-Dorg.gradle.jvmargs=-Xmx2048m,-Pandroid.useDeprecatedNdk=true Built the following apk(s): /Users/vincentherl/Documents/lire/platforms/android/build/outputs/apk/android-debug.apk No scripts found for hook "before_deploy". ANDROID_HOME=/Users/vincentherl/Library/Android/sdk JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home Running command: adb devices Command finished with error code 0: adb devices Running command: avdmanager list avd Command finished with error code 0: avdmanager list,avd Error: Cannot read property 'semver' of null {code} Mabe a way, this line : https://github.com/apache/cordova-android/blob/83601dca2fa468a76bcb2c687b5baebfcb69588b/bin/templates/cordova/lib/emulator.js#L190 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13570) FileReader#readAsText fails with multi-byte UTF-8 characters
Ralf Kistner created CB-13570: - Summary: FileReader#readAsText fails with multi-byte UTF-8 characters Key: CB-13570 URL: https://issues.apache.org/jira/browse/CB-13570 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-file Affects Versions: 5.0.0, 4.2.0 Environment: Tested on: * iOS 10.2 * cordova-ios 4.3.0 * UIWebView (not WKWebView) * cordova 6.4.0 * cordova-plugin-file 4.2.0 and 5.0.0 (Slightly old cordova version, but the issue seems to be in the plugin) Reporter: Ralf Kistner `FileReader#readAsText` reads the file in chunks of 256KB. If the file contains a multi-byte UTF-8 character that is split into two separate chunks, reading fails with an encoding error (ENCODING_ERR: 5). For many apps this is not an issue. However, if I file is larger than 256KB and contains many multi-byte characters, this is likely to happen. I have not experienced this issue on Android yet. Code that demonstrates the issue: https://gist.github.com/anonymous/0fdc1ec212be1e29309820477257a0c3 In the example, the reading will split the '\u0153' character into '...\x01' and '\x53', which fails to decode in UTF-8. A workaround is to use readAsArrayBuffer instead, and do the decoding in JavaScript. However, the decoding can be quite slow on iOS where a native TextDecoder is not available. One solution would be to make the chunk sizes semi-flexible, to ensure that it ends on a character boundary (make the chunk larger until decoding succeeds). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Piotrowski (Sujan) updated CB-13568: Description: The recent update for the file-transfer plugin started crashing the phonegap build for android today. Last stable build was on Friday. It produce the error below. (More than 19 people had reported the same issue on the adobe forum with no one assigned, https://forums.adobe.com/thread/2410942?start=0&tstart=0 https://forums.adobe.com/thread/2411286) {code} :generateDebugSources :incrementalDebugJavaCompilationSafeguard :compileDebugJavaWithJavac :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.). /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors :compileDebugJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 6.438 secs Error: /project/gradlew: Command failed with exit code 1 Error output: Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. warning: string 'menu_settings' has no default translation. Warning: AndroidManifest.xml already defines debuggable (in http://schemas.android.com/apk/res/android); using existing value in manifest. /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 3 errors FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileDebugJavaWithJavac'. > Compilation failed; see the compiler error output for details. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. at ChildProcess.whenDone (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:191:7) at maybeClose (internal/child_process.js:877:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) {code} was: The recent update for the file-transfer plugin started crashing the phonegap build for android today. Last stable build was on Friday. It produce the error below. (More than 19 people had reported the same issue on the adobe forum with no one assigned, https://forums.adobe.com/thread/2410942?start=0&tstart=0 https://forums.adobe.com/thread/2411286) :generateDebugSources :incrementalDebugJavaCompilationSafeguard :compileDebugJavaWithJavac :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.). /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: package org.apache.cordova.file does not exist import org.apache.cordova.file.FileUtils; ^ /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: cannot find symbol FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); ^ symbol: class FileUtils Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecatio
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251214#comment-16251214 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795138 ## File path: doc/developing-the-website.md ## @@ -14,4 +14,8 @@ Alternatively, to dynamically rebuild the site and refresh the browser _when cha ### Next steps -When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md). \ No newline at end of file +When you are done with developing you can [build](building-the-website.md) and [deploy](deploying-the-website.md) manually. + +OR Review comment: Is the manual deploy still an option at all? If Travis builds on every commit, you can't really deploy manually any more, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251213#comment-16251213 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795285 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. + +Lastly, Travis also runs `npm test` and will notify you if any of your `eslint` or `mocha` tests are failing. When Travis is done building and deploying, send a pull request and ask for a review. Review comment: Why the seperate "Testing" paragraph if Travis automatically runs the tests? Is this a safeguard somehow? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251215#comment-16251215 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795585 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Maybe add some information how Travis is setup and configured (after the first sentence maybe?). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251216#comment-16251216 ] ASF GitHub Bot commented on CB-13543: - janpio commented on a change in pull request #760: CB-13543 : updated instructions/documentation around travis build/dep… URL: https://github.com/apache/cordova-docs/pull/760#discussion_r150795585 ## File path: doc/building-and-deploying-the-website.md ## @@ -0,0 +1,22 @@ +## Building and Deploying (Automated) + +### Testing + +After you are finished developing and making your changes, make sure to test them. Run: + + npm test + +`npm test` runs both [eslint] and [mocha] tests. If your tests pass, commit and push your work to Github. + +### Travis + +[Travis] automatically builds and publishes the website on every change. Travis will build the full website for you by running `gulp build --prod` under the hood. Travis also uses [SVN] to update, copy, add, and commit the new changes over to the website. Committing to svn can only occur once the commit has been merged to master. Review comment: Maybe add some information how Travis is setup and configured (after the first sentence maybe?). This paragraph could also link to the old, manual steps to document what exactly happens under the hood (with SVN). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251164#comment-16251164 ] clarklight edited comment on CB-13568 at 11/14/17 10:01 AM: The file plugin is already included and that has no problem, it is the file transfer update that is not working with PGB. But PGB isnt replying. There is no other version of file transfer plugin for PGBmore than 34 "I have the same problem" had been marked on the PGB forum. Is there anyway the issue can be raised to PGB? Because the development process for many users are totally stuck at this point. (Or if there is anyway to ask PGB team to atleast give some indication on what we are looking at?) Or do we just move away from file transfer and use the XMLHttpRequest was (Author: clarklight): The file plugin is already included and that has no problem, it is the file transfer update that is not working with PGB. But PGB isnt replying. There is no other version of file transfer plugin for PGBmore than 34 "I have the same problem" had been marked on the PGB forum. Is there anyway the issue can be raised to PGB? Because the development process for many paid users are totally stuck at this point. > Update from Cordova file transfer plugin crash Phonegap build for Android > - > > Key: CB-13568 > URL: https://issues.apache.org/jira/browse/CB-13568 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-cli >Affects Versions: 6.3.0, cordova-cli@6.4.0, cordova@7.0.0 > Environment: Android for all Phonegap build >Reporter: clarklight >Assignee: Joe Bowser >Priority: Critical > > The recent update for the file-transfer plugin started crashing the phonegap > build for android today. Last stable build was on Friday. It produce the > error below. > (More than 19 people had reported the same issue on the adobe forum with no > one assigned, > https://forums.adobe.com/thread/2410942?start=0&tstart=0 > https://forums.adobe.com/thread/2411286) > :generateDebugSources > :incrementalDebugJavaCompilationSafeguard > :compileDebugJavaWithJavac > :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, > no previous execution, etc.). > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > :compileDebugJavaWithJavac FAILED > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > > BUILD FAILED > > Total time: 6.438 secs > Error: /project/gradlew: Command failed with exit code 1 Error output: > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > warning: string 'menu_settings' has no default translation. > Warning: AndroidManifest.xml already defines debuggable (in > http://schemas.android.com/apk/res/android); using existing value in manifest. > > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:uncheck
[jira] [Reopened] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clarklight reopened CB-13568: - The file plugin is already included and that has no problem, it is the file transfer update that is not working with PGB. But PGB isnt replying. There is no other version of file transfer plugin for PGBmore than 34 "I have the same problem" had been marked on the PGB forum. Is there anyway the issue can be raised to PGB? Because the development process for many paid users are totally stuck at this point. > Update from Cordova file transfer plugin crash Phonegap build for Android > - > > Key: CB-13568 > URL: https://issues.apache.org/jira/browse/CB-13568 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-cli >Affects Versions: 6.3.0, cordova-cli@6.4.0, cordova@7.0.0 > Environment: Android for all Phonegap build >Reporter: clarklight >Assignee: Joe Bowser >Priority: Critical > > The recent update for the file-transfer plugin started crashing the phonegap > build for android today. Last stable build was on Friday. It produce the > error below. > (More than 19 people had reported the same issue on the adobe forum with no > one assigned, > https://forums.adobe.com/thread/2410942?start=0&tstart=0 > https://forums.adobe.com/thread/2411286) > :generateDebugSources > :incrementalDebugJavaCompilationSafeguard > :compileDebugJavaWithJavac > :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, > no previous execution, etc.). > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > :compileDebugJavaWithJavac FAILED > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > > BUILD FAILED > > Total time: 6.438 secs > Error: /project/gradlew: Command failed with exit code 1 Error output: > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > warning: string 'menu_settings' has no default translation. > Warning: AndroidManifest.xml already defines debuggable (in > http://schemas.android.com/apk/res/android); using existing value in manifest. > > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > at ChildProcess.whenDone > (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) > at emitTwo (events.js:106:13) > at ChildProcess.emit (events.js:191:7) > at maybeClose (internal/child_process.js:877:16) > at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) -- This message was sent by Atlassian JIRA (v6.4.14#6402
[jira] [Commented] (CB-13568) Update from Cordova file transfer plugin crash Phonegap build for Android
[ https://issues.apache.org/jira/browse/CB-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251119#comment-16251119 ] clarklight commented on CB-13568: - Hi, i already have the file plugin included, but soon as i include the file transfer plugin, then it gives the error. Everything was ok 2 days ago as well. And i didn't change anything on the build on PGB, it was all working and i simply clicked Rebuild and now its error and won't build. I just checked more than 20 people are reporting the same problem as well. > Update from Cordova file transfer plugin crash Phonegap build for Android > - > > Key: CB-13568 > URL: https://issues.apache.org/jira/browse/CB-13568 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-cli >Affects Versions: 6.3.0, cordova-cli@6.4.0, cordova@7.0.0 > Environment: Android for all Phonegap build >Reporter: clarklight >Assignee: Joe Bowser >Priority: Critical > > The recent update for the file-transfer plugin started crashing the phonegap > build for android today. Last stable build was on Friday. It produce the > error below. > (More than 19 people had reported the same issue on the adobe forum with no > one assigned, > https://forums.adobe.com/thread/2410942?start=0&tstart=0 > https://forums.adobe.com/thread/2411286) > :generateDebugSources > :incrementalDebugJavaCompilationSafeguard > :compileDebugJavaWithJavac > :compileDebugJavaWithJavac - is not incremental (e.g. outputs have changed, > no previous execution, etc.). > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > :compileDebugJavaWithJavac FAILED > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > > BUILD FAILED > > Total time: 6.438 secs > Error: /project/gradlew: Command failed with exit code 1 Error output: > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > warning: string 'menu_settings' has no default translation. > Warning: AndroidManifest.xml already defines debuggable (in > http://schemas.android.com/apk/res/android); using existing value in manifest. > > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:49: error: > package org.apache.cordova.file does not exist > import org.apache.cordova.file.FileUtils; > ^ > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > /project/src/org/apache/cordova/filetransfer/FileTransfer.java:851: error: > cannot find symbol > FileUtils filePlugin = (FileUtils) pm.getPlugin("File"); > ^ > symbol: class FileUtils > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 3 errors > > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':compileDebugJavaWithJavac'. > > Compilation failed; see the compiler error output for details. > > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > at ChildProcess.whenDone > (/project/cordova/node_modules/cordova-common/src/superspawn.js:169:23) > at emitTwo (events.js:106:13) > at ChildProcess.emit (events.js:191:7) > at maybeClose (internal/child_process.js:877:16) > at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) -- This message was sent by Atlassian JIRA (v6.4
[jira] [Commented] (CB-13208) File plugin on Windows reads entire file into memory when only a small fragment is requested on `readAsBinaryString`
[ https://issues.apache.org/jira/browse/CB-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251115#comment-16251115 ] ASF GitHub Bot commented on CB-13208: - salbahra commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-344190974 Any status update on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > File plugin on Windows reads entire file into memory when only a small > fragment is requested on `readAsBinaryString` > > > Key: CB-13208 > URL: https://issues.apache.org/jira/browse/CB-13208 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: 6.5.0 > Environment: All Windows UAP applications >Reporter: Samer Albahra > > `readAsBinaryString` for `FileReader` on Windows is reading the entire file > to a buffer then slicing the requested fragment causing the app to crash due > to out of memory errors. It should instead be using a stream which seeks to > the requested start position and only reads the requested length. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13208) File plugin on Windows reads entire file into memory when only a small fragment is requested on `readAsBinaryString`
[ https://issues.apache.org/jira/browse/CB-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251114#comment-16251114 ] ASF GitHub Bot commented on CB-13208: - salbahra commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-344190974 Any status on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > File plugin on Windows reads entire file into memory when only a small > fragment is requested on `readAsBinaryString` > > > Key: CB-13208 > URL: https://issues.apache.org/jira/browse/CB-13208 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: 6.5.0 > Environment: All Windows UAP applications >Reporter: Samer Albahra > > `readAsBinaryString` for `FileReader` on Windows is reading the entire file > to a buffer then slicing the requested fragment causing the app to crash due > to out of memory errors. It should instead be using a stream which seeks to > the requested start position and only reads the requested length. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12700) contacts.spec.7.3 failure in mobilespec
[ https://issues.apache.org/jira/browse/CB-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251055#comment-16251055 ] inoue yuta commented on CB-12700: - spec.21 spec.22 spec.31 is failed in ios11.in ios9、ios10 is OK. --- contacts.spec.21 expect(obj.birthday.toDateString()).toBe(bDay.toDateString());←failed obj.birthday.toDateString() is one day late than bDay.toDateString(). > contacts.spec.7.3 failure in mobilespec > --- > > Key: CB-12700 > URL: https://issues.apache.org/jira/browse/CB-12700 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-contacts > Environment: iOS >Reporter: Shazron Abdullah > > See CB-12687 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13569) The LocalFileSystem enum in the typescript file is inverted
[ https://issues.apache.org/jira/browse/CB-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251051#comment-16251051 ] ASF GitHub Bot commented on CB-13569: - antondb closed pull request #224: CB-13569 URL: https://github.com/apache/cordova-plugin-file/pull/224 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/types/index.d.ts b/types/index.d.ts index c748e3d..38f8f8d 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -373,6 +373,6 @@ interface Cordova { declare enum LocalFileSystem { -PERSISTENT=0, -TEMPORARY=1 -} \ No newline at end of file +PERSISTENT=1, +TEMPORARY=0 +} This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The LocalFileSystem enum in the typescript file is inverted > --- > > Key: CB-13569 > URL: https://issues.apache.org/jira/browse/CB-13569 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file > Environment: Problem when using typescript. >Reporter: anton deblasio >Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > When using the typescript type file one of the enums is inverted > the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate > to the values 1 and 0 respectively. However in the typescript file they are > set to 0 and 1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13569) The LocalFileSystem enum in the typescript file is inverted
[ https://issues.apache.org/jira/browse/CB-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251050#comment-16251050 ] ASF GitHub Bot commented on CB-13569: - antondb opened a new pull request #224: CB-13569 URL: https://github.com/apache/cordova-plugin-file/pull/224 …STENT were swapped. ### Platforms affected This bug affects anyone using the typescript type file. ### What does this PR do? Changes the localfilesystem enum so that it reflects the values in the code. ### What testing has been done on this change? Loaded the type file in VSCode and tested a phone build on Android and IOS. ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The LocalFileSystem enum in the typescript file is inverted > --- > > Key: CB-13569 > URL: https://issues.apache.org/jira/browse/CB-13569 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file > Environment: Problem when using typescript. >Reporter: anton deblasio >Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > When using the typescript type file one of the enums is inverted > the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate > to the values 1 and 0 respectively. However in the typescript file they are > set to 0 and 1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13569) The LocalFileSystem enum in the typescript file is inverted
anton deblasio created CB-13569: --- Summary: The LocalFileSystem enum in the typescript file is inverted Key: CB-13569 URL: https://issues.apache.org/jira/browse/CB-13569 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-file Environment: Problem when using typescript. Reporter: anton deblasio Priority: Trivial When using the typescript type file one of the enums is inverted the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate to the values 1 and 0 respectively. However in the typescript file they are set to 0 and 1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org