date:20180119

[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1

2018-01-19 Thread Terence Bandoian (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332978#comment-16332978
 ] 

Terence Bandoian commented on CB-13802:
---

Thanks [~brodybits] for reviewing.  Nice catch.

> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where 
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called 
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1" 
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>  
>  // Enter fullscreen mode
>  function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
>  var view = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
>  view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>  
>  // Exit fullscreen mode
>  function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
>  var view = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
>  view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>  
>  // Make title bg color match splashscreen bg color
>  function colorizeTitleBar() {
> -var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
>  titleInitialBgColor = appView.titleBar.backgroundColor;
>  
>  appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>  
>  // Revert title bg color
>  function revertTitleBarColor() {
> -var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
>  appView.titleBar.backgroundColor = titleInitialBgColor;
>  appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
>  }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance 
> would be appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13684) Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in build.json

2018-01-19 Thread Eric Parlier (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332779#comment-16332779
 ] 

Eric Parlier commented on CB-13684:
---

[~bowserj] so can we have an empty password in the build file for 
*storePassword*, which is optional? For us using the build file, this is the 
only issue.

> Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in 
> build.json
> ---
>
> Key: CB-13684
> URL: https://issues.apache.org/jira/browse/CB-13684
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Reporter: Kevin Lot
>Assignee: Joe Bowser
>Priority: Major
>
> Since 6.4.0, sign APK without specify passwords in config file does not work.
> Cause gradle 4.1.0 has this issue [#2826] - Use SwingBuilder in customize 
> task on Android studio throw java.awt.HeadlessException. 
> ([link|https://github.com/gradle/gradle/issues/2826]).
> If you don't specify passwords in config file to sign your APK, compilation 
> launches a window with SwingBuilder to prompt passwords.
> {code:java}
> def doPromptForPassword(msg) {
> if (System.console() == null) {
> def ret = null
> new SwingBuilder().edt {
> dialog(modal: true, title: 'Enter password', alwaysOnTop: true, 
> resizable: false, locationRelativeTo: null, pack: true, show: true) {
> vbox {
> label(text: msg)
> def input = passwordField()
> button(defaultButton: true, text: 'OK', actionPerformed: {
> ret = input.password;
> dispose();
> })
> }
> }
> }
> if (!ret) {
> throw new GradleException('User canceled build')
> }
> return new String(ret)
> } else {
> return System.console().readPassword('\n' + msg);
> }
> }
> {code}
> On Linux Mint 18.3 and MacOs High sierra, even in terminal, System.console() 
> return null and compilation crashes due to gradle issue.
> Thanks for help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332771#comment-16332771
 ] 

ASF subversion and git services commented on CB-13800:
--

Commit cc08e9d84a3f7cf76a623006c6a7e48814d74cec in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=cc08e9d ]

Merge pull request #429 from BBosman/cb13800

CB-13800: Drop pre-KitKat specific code

> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332768#comment-16332768
 ] 

ASF GitHub Bot commented on CB-13800:
-

infil00p commented on issue #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429#issuecomment-359060673
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332769#comment-16332769
 ] 

ASF GitHub Bot commented on CB-13800:
-

infil00p closed pull request #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/framework/src/org/apache/cordova/CordovaActivity.java 
b/framework/src/org/apache/cordova/CordovaActivity.java
index e2ed1cb82..dbbb48f69 100755
--- a/framework/src/org/apache/cordova/CordovaActivity.java
+++ b/framework/src/org/apache/cordova/CordovaActivity.java
@@ -123,7 +123,7 @@ public void onCreate(Bundle savedInstanceState) {
 if (preferences.getBoolean("Fullscreen", false)) {
 // NOTE: use the FullscreenNotImmersive configuration key to set 
the activity in a REAL full screen
 // (as was the case in previous cordova versions)
-if ((Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) && 
!preferences.getBoolean("FullscreenNotImmersive", false)) {
+if (!preferences.getBoolean("FullscreenNotImmersive", false)) {
 immersiveMode = true;
 } else {
 
getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
diff --git a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java 
b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
index 3ea5e5765..a27fc6af4 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
@@ -149,21 +149,6 @@ public void onExceededDatabaseQuota(String url, String 
databaseIdentifier, long
 quotaUpdater.updateQuota(MAX_QUOTA);
 }
 
-// console.log in api level 7: 
http://developer.android.com/guide/developing/debug-tasks.html
-// Expect this to not compile in a future Android release!
-@SuppressWarnings("deprecation")
-@Override
-public void onConsoleMessage(String message, int lineNumber, String 
sourceID)
-{
-//This is only for Android 2.1
-if(android.os.Build.VERSION.SDK_INT == 
android.os.Build.VERSION_CODES.ECLAIR_MR1)
-{
-LOG.d(LOG_TAG, "%s: Line %d : %s", sourceID, lineNumber, message);
-super.onConsoleMessage(message, lineNumber, sourceID);
-}
-}
-
-@TargetApi(8)
 @Override
 public boolean onConsoleMessage(ConsoleMessage consoleMessage)
 {
diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java 
b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
index d17650240..0b6a577ea 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
@@ -112,7 +112,7 @@ public void onReceivedHttpAuthRequest(WebView view, 
HttpAuthHandler handler, Str
  * @param request
  */
 @Override
-@TargetApi(21)
+@TargetApi(Build.VERSION_CODES.LOLLIPOP)
 public void onReceivedClientCertRequest (WebView view, ClientCertRequest 
request)
 {
 
@@ -219,7 +219,6 @@ public void onReceivedError(WebView view, int errorCode, 
String description, Str
  * @param handler   An SslErrorHandler object that will handle the 
user's response.
  * @param error The SSL error object.
  */
-@TargetApi(8)
 @Override
 public void onReceivedSslError(WebView view, SslErrorHandler handler, 
SslError error) {
 
@@ -316,7 +315,6 @@ public void clearAuthenticationTokens() {
 this.authenticationTokens.clear();
 }
 
-@TargetApi(Build.VERSION_CODES.HONEYCOMB)
 @Override
 public WebResourceResponse shouldInterceptRequest(WebView view, String 
url) {
 try {
@@ -349,7 +347,7 @@ public WebResourceResponse shouldInterceptRequest(WebView 
view, String url) {
 }
 
 private static boolean needsKitKatContentUrlFix(Uri uri) {
-return android.os.Build.VERSION.SDK_INT >= 
android.os.Build.VERSION_CODES.KITKAT && "content".equals(uri.getScheme());
+return "content".equals(uri.getScheme());
 }
 
 private static boolean needsSpecialsInAssetUrlFix(Uri uri) {
@@ -364,11 +362,6 @@ private static boolean needsSpecialsInAssetUrlFix(Uri uri) 
{
 return false;
 }
 
-switch(android.os.Build.VERSION.SDK_INT){
-case android.os.Build.VERSION_CODES.ICE_CREAM_SANDWICH:
-case android.os.Build.VERSION_CODES.ICE_CREAM_SANDWICH_MR1:
-return true;
-}
 return false;
 }
 }
diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332770#comment-16332770
 ] 

ASF subversion and git services commented on CB-13800:
--

Commit 075d38117ae19ee8832f3f16eb9340a1786674b6 in cordova-android's branch 
refs/heads/master from [~BBosman]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=075d381 ]

CB-13800: (android) Drop pre-KitKat specific code


> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-13684) Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in build.json

2018-01-19 Thread Joe Bowser (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332759#comment-16332759
 ] 

Joe Bowser edited comment on CB-13684 at 1/19/18 7:04 PM:
--

[~danielcooper_xyz] The keyPassword argument does not exist, and you can't pass 
the password through command line arguments this way.  Right now there's no way 
for this to be skipped, and you have to provide it via the build.json in the 
top-level of the project.

If you're using a Stand-Alone Android Project, you could just write to the 
release-signing.properties file directly and put the passwords there before 
executing the build.  Below is my build.json from recreating the WeatherApp to 
try and reproduce the bug:
{code:java}
{ "android": { "release": { "keystore": "keystore", "alias": "alias1", 
"storePassword": "password", "password": "password" } } }
{code}

And here's the release-signing .properties when I use the command line to try 
and generate this file: 
{noformat}
# This file is automatically generated. # Do not modify this file -- YOUR 
CHANGES WILL BE ERASED! 
key.store=../../keystore 
key.alias=alias1 
key.store.password=password
{noformat}
This is obviously missing the much-needed key.alias.password, which will allow 
the build to work.


was (Author: bowserj):
[~danielcooper_xyz] The keyPassword argument does not exist, and you can't pass 
the password through command line arguments this way.  Right now there's no way 
for this to be skipped, and you have to provide it via the build.json in the 
top-level of the project.

If you're using a Stand-Alone Android Project, you could just write to the 
release-signing.properties file directly and put the passwords there before 
executing the build.

> Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in 
> build.json
> ---
>
> Key: CB-13684
> URL: https://issues.apache.org/jira/browse/CB-13684
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Reporter: Kevin Lot
>Assignee: Joe Bowser
>Priority: Major
>
> Since 6.4.0, sign APK without specify passwords in config file does not work.
> Cause gradle 4.1.0 has this issue [#2826] - Use SwingBuilder in customize 
> task on Android studio throw java.awt.HeadlessException. 
> ([link|https://github.com/gradle/gradle/issues/2826]).
> If you don't specify passwords in config file to sign your APK, compilation 
> launches a window with SwingBuilder to prompt passwords.
> {code:java}
> def doPromptForPassword(msg) {
> if (System.console() == null) {
> def ret = null
> new SwingBuilder().edt {
> dialog(modal: true, title: 'Enter password', alwaysOnTop: true, 
> resizable: false, locationRelativeTo: null, pack: true, show: true) {
> vbox {
> label(text: msg)
> def input = passwordField()
> button(defaultButton: true, text: 'OK', actionPerformed: {
> ret = input.password;
> dispose();
> })
> }
> }
> }
> if (!ret) {
> throw new GradleException('User canceled build')
> }
> return new String(ret)
> } else {
> return System.console().readPassword('\n' + msg);
> }
> }
> {code}
> On Linux Mint 18.3 and MacOs High sierra, even in terminal, System.console() 
> return null and compilation crashes due to gradle issue.
> Thanks for help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13684) Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in build.json

2018-01-19 Thread Joe Bowser (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332759#comment-16332759
 ] 

Joe Bowser commented on CB-13684:
-

[~danielcooper_xyz] The keyPassword argument does not exist, and you can't pass 
the password through command line arguments this way.  Right now there's no way 
for this to be skipped, and you have to provide it via the build.json in the 
top-level of the project.

If you're using a Stand-Alone Android Project, you could just write to the 
release-signing.properties file directly and put the passwords there before 
executing the build.

> Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in 
> build.json
> ---
>
> Key: CB-13684
> URL: https://issues.apache.org/jira/browse/CB-13684
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Reporter: Kevin Lot
>Assignee: Joe Bowser
>Priority: Major
>
> Since 6.4.0, sign APK without specify passwords in config file does not work.
> Cause gradle 4.1.0 has this issue [#2826] - Use SwingBuilder in customize 
> task on Android studio throw java.awt.HeadlessException. 
> ([link|https://github.com/gradle/gradle/issues/2826]).
> If you don't specify passwords in config file to sign your APK, compilation 
> launches a window with SwingBuilder to prompt passwords.
> {code:java}
> def doPromptForPassword(msg) {
> if (System.console() == null) {
> def ret = null
> new SwingBuilder().edt {
> dialog(modal: true, title: 'Enter password', alwaysOnTop: true, 
> resizable: false, locationRelativeTo: null, pack: true, show: true) {
> vbox {
> label(text: msg)
> def input = passwordField()
> button(defaultButton: true, text: 'OK', actionPerformed: {
> ret = input.password;
> dispose();
> })
> }
> }
> }
> if (!ret) {
> throw new GradleException('User canceled build')
> }
> return new String(ret)
> } else {
> return System.console().readPassword('\n' + msg);
> }
> }
> {code}
> On Linux Mint 18.3 and MacOs High sierra, even in terminal, System.console() 
> return null and compilation crashes due to gradle issue.
> Thanks for help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13804) Always log a message when catching an exception

2018-01-19 Thread Chris Brody (JIRA)

Chris Brody created CB-13804:


 Summary: Always log a message when catching an exception
 Key: CB-13804
 URL: https://issues.apache.org/jira/browse/CB-13804
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-android, cordova-browser, cordova-ios, 
cordova-js, cordova-osx, cordova-windows
Reporter: Chris Brody
Assignee: Joe Bowser


Looking at cordova.js in cordova-windows along with the other platforms I 
noticed that the JavaScript logs a message in most but not all {{catch}} 
blocks. Here are a few exceptions I spotted so far:

In {{cordova-js}} {{src/common/builder.js}}:
{code:javascript}
function include (parent, objects, clobber, merge) {
each(objects, function (obj, key) {
try {
var result = obj.path ? require(obj.path) : {};

// ...
} catch (e) {
utils.alert('Exception building Cordova JS globals: ' + e + ' for 
key "' + key + '"');
}
});
}
{code}

{{utils.alert}} would show an alert if possible, otherwise log a message. I 
would rather to see the JavaScript log the message regardless of whether or not 
it is possible to show the alert (ideally log first). Possible fix (NOT TESTED):
{code:javascript}
diff --git a/src/common/utils.js b/src/common/utils.js
index febfd91..7244b8f 100644
--- a/src/common/utils.js
+++ b/src/common/utils.js
@@ -170,12 +170,9 @@ utils.extend = (function () {
 }());
 
 /**
- * Alerts a message in any available way: alert or console.log.
+ * Alerts a message in any possible way: alert / console.log
  */
 utils.alert = function (msg) {
-if (window.alert) {
-window.alert(msg);
-} else if (console && console.log) {
-console.log(msg);
-}
+console && console.log && console.log(msg);
+window.alert && window.alert(msg);
 };
{code}

Possible fixes in {{cordova-windows}} (NOT TESTED):

{code:javascript}
diff --git a/cordova-js-src/confighelper.js b/cordova-js-src/confighelper.js
index c166052..faa65e3 100644
--- a/cordova-js-src/confighelper.js
+++ b/cordova-js-src/confighelper.js
@@ -89,7 +89,11 @@ function requestFile(filePath, success, error) {
 xhr.open("get", filePath, true);
 xhr.send();
 } catch (e) {
-fail('[Windows][cordova.js][xhrFile] Could not XHR ' + filePath + ': ' 
+ JSON.stringify(e));
+var msg =
+'[Windows][cordova.js][xhrFile] Could not XHR ' + filePath + ': ' +
+JSON.stringify(e);
+console.error(msg);
+fail(msg);
 }
 }
 
diff --git a/cordova-js-src/platform.js b/cordova-js-src/platform.js
index 4bc4025..dbc1c75 100644
--- a/cordova-js-src/platform.js
+++ b/cordova-js-src/platform.js
@@ -99,7 +99,9 @@ module.exports = {
 try {
 Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 isCoreWindowAvailable = true;
-} catch (e) { }
+} catch (e) {
+console && console.log && console.log('NOTICE: CoreWindow 
functionality is not available');
+}
 
 if (isCoreWindowAvailable) {
 app.addEventListener("checkpoint", checkpointHandler);
@@ -160,6 +162,7 @@ function injectBackButtonHandler() {
 return true;
 }
 catch (e) {
+console && console.log && console.log('NOTICE: backbutton 
handler not available, ignored');
 return false;
 }
 }
{code}

I would need some time to check for unlogged exceptions on the other platforms.

A case where I think logging should NOT be done in release build is in the 
{{clobber}} funciton in {{cordova-js/src/common/builder.js}}:
{code:javascript}
function clobber (obj, key, value) {
exports.replaceHookForTesting(obj, key);
var needsProperty = false;
try {
obj[key] = value;
} catch (e) {
needsProperty = true;
}
// ...
{code}

I originally spotted this issue on Windows when looking at the ApplicationView 
calls related to the changes in CB-12238, CB-12784, and CB-13641 along with 
suggested changes I raised in CB-13802.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread Jan Piotrowski (Sujan) (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) resolved CB-13641.
-
Resolution: Fixed

Next release will include this change.

Thanks for the work!

> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13155) Running windows app through cordova CLI in an emulator produces error

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332656#comment-16332656
 ] 

ASF GitHub Bot commented on CB-13155:
-

janpio closed pull request #240: CB-13155: Improved target parsing
URL: https://github.com/apache/cordova-windows/pull/240
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/template/cordova/lib/package.js b/template/cordova/lib/package.js
index 6269885f..d811f4da 100644
--- a/template/cordova/lib/package.js
+++ b/template/cordova/lib/package.js
@@ -147,7 +147,10 @@ module.exports.findDevice = function (deploymentTool, 
target) {
 return Q.resolve(deviceList[0]);
 } else {
 var candidateList = deviceList.filter(function (device) {
-return device.index === parseInt(target, 10);
+var deviceIndexEqualsTarget = device.index === 
parseInt(target, 10);
+var deviceNameContainsTarget = 
device.name.toLowerCase().indexOf(target.toLowerCase()) >= 0;
+
+return deviceIndexEqualsTarget || deviceNameContainsTarget;
 });
 
 if (candidateList.length > 0) {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Running windows app through cordova CLI in an emulator produces error
> -
>
> Key: CB-13155
> URL: https://issues.apache.org/jira/browse/CB-13155
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: Master
> Environment: *OS:* Windows 10
> *Ver:* 1703
> *Build:* 15063.413
> *Processor:* i3
> *Cordova Version:* 7.0.1
> *Cordova-windows:* 5.0.0
>Reporter: Ayan Dey
>Assignee: Alexander Sorokin
>Priority: Major
>  Labels: triaged
>
> I am trying to run a windows app on an emulator using the command given in 
> the docs but it gives out errors.
> **Command:** `cordova run windows --target="Mobile Emulator 10.0.14393.0 720P 
> 5 inch 1GB" -- --appx=8.1-phone`
> **Result:** `Error: Specified device not found`
> **Command:** `cordova run windows --target=4 -- --appx=8.1-phone`
> **Result:** _The emulator runs_
> **Command:** `cordova run windows --target="Mobile Emulator 10.0.14393.0 720P 
> 5 inch 1GB" -- --appx=uap`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap --emulator`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap --archs="arm"`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> *CONFIG.XML*
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Crosby
> 
> A remote controller for Crosby room cleaning bot
> 
> http://ayandey.com;>
> Ayan Dey
> 
> 
> 
> http://*/*; />
> https://*/*; />
> 
> 
> mailto:*; />
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13155) Running windows app through cordova CLI in an emulator produces error

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332655#comment-16332655
 ] 

ASF GitHub Bot commented on CB-13155:
-

janpio commented on issue #240: CB-13155: Improved target parsing
URL: https://github.com/apache/cordova-windows/pull/240#issuecomment-359042670
 
 
   When checking the conflict, I noticed that `master` already has these 
changes, although a little bit differently formatted: 
https://github.com/apache/cordova-windows/commit/ab9837ba05e0c8485070bf463fee635d3c212aae
   
   Please reopen if I really misunderstood the code and this is actually not 
the same.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Running windows app through cordova CLI in an emulator produces error
> -
>
> Key: CB-13155
> URL: https://issues.apache.org/jira/browse/CB-13155
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: Master
> Environment: *OS:* Windows 10
> *Ver:* 1703
> *Build:* 15063.413
> *Processor:* i3
> *Cordova Version:* 7.0.1
> *Cordova-windows:* 5.0.0
>Reporter: Ayan Dey
>Assignee: Alexander Sorokin
>Priority: Major
>  Labels: triaged
>
> I am trying to run a windows app on an emulator using the command given in 
> the docs but it gives out errors.
> **Command:** `cordova run windows --target="Mobile Emulator 10.0.14393.0 720P 
> 5 inch 1GB" -- --appx=8.1-phone`
> **Result:** `Error: Specified device not found`
> **Command:** `cordova run windows --target=4 -- --appx=8.1-phone`
> **Result:** _The emulator runs_
> **Command:** `cordova run windows --target="Mobile Emulator 10.0.14393.0 720P 
> 5 inch 1GB" -- --appx=uap`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap --emulator`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> **Command:** `cordova run windows --target=4 -- --appx=uap --archs="arm"`
> **Result:** `Error: Deploying desktop apps to specific target not supported`
> *CONFIG.XML*
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Crosby
> 
> A remote controller for Crosby room cleaning bot
> 
> http://ayandey.com;>
> Ayan Dey
> 
> 
> 
> http://*/*; />
> https://*/*; />
> 
> 
> mailto:*; />
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1

2018-01-19 Thread Chris Brody (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332652#comment-16332652
 ] 

Chris Brody commented on CB-13802:
--

I also raised CB-13803 to report the possible crash on Windows 8.1, which would 
be resolved by the suggested changes.

> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where 
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called 
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1" 
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>  
>  // Enter fullscreen mode
>  function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
>  var view = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
>  view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>  
>  // Exit fullscreen mode
>  function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
>  var view = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
>  view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>  
>  // Make title bg color match splashscreen bg color
>  function colorizeTitleBar() {
> -var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
>  titleInitialBgColor = appView.titleBar.backgroundColor;
>  
>  appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>  
>  // Revert title bg color
>  function revertTitleBarColor() {
> -var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>  if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
>  appView.titleBar.backgroundColor = titleInitialBgColor;
>  appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
>  }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance 
> would be appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13803) Possible crash on Windows 8.1 in case of fullscreen mode

2018-01-19 Thread Chris Brody (JIRA)

Chris Brody created CB-13803:


 Summary: Possible crash on Windows 8.1 in case of fullscreen mode
 Key: CB-13803
 URL: https://issues.apache.org/jira/browse/CB-13803
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-windows
Reporter: Chris Brody
Assignee: Jesse MacFadyen


From CB-13802 I noticed a couple spots in splashscreen.js, related to 
fullscreen mode, marked "else crash on 8.1". The changes I recommended in 
CB-13802 should resolve this issue.

I would be happy if CB-13802 would be resolved, with this one marked as a 
duplicate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332617#comment-16332617
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on a change in pull request #245: CB-13641: (windows) 
support transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162686968
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   I just raised CB-13802 (https://issues.apache.org/jira/browse/CB-13802) to 
handle the issues with the unneeded calls (along with a couple "else crash on 
8.1" comments).
   
   Thanks @janpio for merging this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1

2018-01-19 Thread Chris Brody (JIRA)

Chris Brody created CB-13802:


 Summary: Avoid unnecessary ApplicationView access on Windows 8.1
 Key: CB-13802
 URL: https://issues.apache.org/jira/browse/CB-13802
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-windows
Reporter: Chris Brody
Assignee: Jesse MacFadyen


>From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where 
>{{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called 
>for no good reason on Windows 8.1, along with a couple "else crash on 8.1" 
>comments nearby.

The following changes (NOT TESTED) would resolve this issue:

{code:sh}
diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
index 97fd86c..77bca75 100644
--- a/cordova-js-src/splashscreen.js
+++ b/cordova-js-src/splashscreen.js
@@ -198,7 +198,7 @@ function enableUserInteraction() {
 
 // Enter fullscreen mode
 function enterFullScreen() {
-if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
on 8.1
+if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
 var view = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
 view.suppressSystemOverlays = true;
@@ -207,7 +207,7 @@ function enterFullScreen() {
 
 // Exit fullscreen mode
 function exitFullScreen() {
-if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash 
on 8.1
+if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
 var view = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
 view.suppressSystemOverlays = false;
@@ -216,8 +216,10 @@ function exitFullScreen() {
 
 // Make title bg color match splashscreen bg color
 function colorizeTitleBar() {
-var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 if (isWin10UWP && !isBgColorTransparent) {
+var appView =
+Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+
 titleInitialBgColor = appView.titleBar.backgroundColor;
 
 appView.titleBar.backgroundColor = titleBgColor;
@@ -227,8 +229,10 @@ function colorizeTitleBar() {
 
 // Revert title bg color
 function revertTitleBarColor() {
-var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 if (isWin10UWP && !isBgColorTransparent) {
+var appView =
+Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
+
 appView.titleBar.backgroundColor = titleInitialBgColor;
 appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
 }
{code}

Unfortunately I do not know how to test splashscreen changes myself, guidance 
would be appreciated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332561#comment-16332561
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359030057
 
 
   I think that worked well enough :)
   
https://github.com/apache/cordova-windows/commit/c288357b1e3e098472f99805c0d350db1e63a542


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332554#comment-16332554
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio closed pull request #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
index 99b60d9f..97fd86cd 100644
--- a/cordova-js-src/splashscreen.js
+++ b/cordova-js-src/splashscreen.js
@@ -43,6 +43,7 @@ var DEFAULT_SPLASHSCREEN_DURATION = 3000, // in milliseconds
 PROGRESSRING_BOTTOM_MARGIN = 10; // needed for windows 10 min height window
 
 var bgColor = "#464646",
+isBgColorTransparent = false,
 titleInitialBgColor,
 titleBgColor,
 autoHideSplashScreen = true,
@@ -69,18 +70,22 @@ function readPreferencesFromCfg(cfg, manifest) {
 splashImageSrc = schema + ':///' + 
manifest.getSplashScreenImagePath().replace(/\\/g, '/');
 
 bgColor = cfg.getPreferenceValue('SplashScreenBackgroundColor') || 
bgColor;
-bgColor = bgColor.replace('0x', '#').replace('0X', '#');
-if (bgColor.length > 7) {
-// Remove aplha
-bgColor = bgColor.slice(0, 1) + bgColor.slice(3, bgColor.length);
-}
+bgColor = bgColor.toLowerCase().replace('0x', '#');
+isBgColorTransparent = (bgColor === 'transparent');
+
+if (!isBgColorTransparent) {
+if (bgColor.length > 7) {
+// Remove alpha
+bgColor = bgColor.slice(0, 1) + bgColor.slice(3, 
bgColor.length);
+}
 
-titleBgColor = {
-a: 255,
-r: parseInt(bgColor.slice(1, 3), 16),
-g: parseInt(bgColor.slice(3, 5), 16),
-b: parseInt(bgColor.slice(5, 7), 16)
-};
+titleBgColor = {
+a: 255,
+r: parseInt(bgColor.slice(1, 3), 16),
+g: parseInt(bgColor.slice(3, 5), 16),
+b: parseInt(bgColor.slice(5, 7), 16)
+};
+}
 
 autoHideSplashScreen = readBoolFromCfg('AutoHideSplashScreen', 
autoHideSplashScreen, cfg);
 splashScreenDelay = cfg.getPreferenceValue('SplashScreenDelay') || 
splashScreenDelay;
@@ -212,7 +217,7 @@ function exitFullScreen() {
 // Make title bg color match splashscreen bg color
 function colorizeTitleBar() {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
-if (isWin10UWP) {
+if (isWin10UWP && !isBgColorTransparent) {
 titleInitialBgColor = appView.titleBar.backgroundColor;
 
 appView.titleBar.backgroundColor = titleBgColor;
@@ -223,7 +228,7 @@ function colorizeTitleBar() {
 // Revert title bg color
 function revertTitleBarColor() {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
-if (isWin10UWP) {
+if (isWin10UWP && !isBgColorTransparent) {
 appView.titleBar.backgroundColor = titleInitialBgColor;
 appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
 }
diff --git a/template/www/cordova.js b/template/www/cordova.js
index b412c0f7..3d9d4140 100644
--- a/template/www/cordova.js
+++ b/template/www/cordova.js
@@ -1879,6 +1879,7 @@
 var PROGRESSRING_BOTTOM_MARGIN = 10; // needed for windows 10 min 
height window
 
 var bgColor = '#464646';
+var isBgColorTransparent = false;
 var titleInitialBgColor;
 var titleBgColor;
 var autoHideSplashScreen = true;
@@ -1905,18 +1906,22 @@
 splashImageSrc = schema + ':///' + 
manifest.getSplashScreenImagePath().replace(/\\/g, '/');
 
 bgColor = 
cfg.getPreferenceValue('SplashScreenBackgroundColor') || bgColor;
-bgColor = bgColor.replace('0x', '#').replace('0X', '#');
-if (bgColor.length > 7) {
-// Remove aplha
-bgColor = bgColor.slice(0, 1) + bgColor.slice(3, 
bgColor.length);
-}
+bgColor = bgColor.toLowerCase().replace('0x', '#');
+isBgColorTransparent = (bgColor === 'transparent');
 
-titleBgColor = {
-a: 255,
-r: parseInt(bgColor.slice(1, 3), 16),
-g: parseInt(bgColor.slice(3, 5), 16),
-b: parseInt(bgColor.slice(5, 7), 16)
-};
+if (!isBgColorTransparent) {
+if (bgColor.length > 7) {
+// Remove alpha
+bgColor = bgColor.slice(0, 1) + bgColor.slice(3,

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332555#comment-16332555
 ] 

ASF subversion and git services commented on CB-13641:
--

Commit c288357b1e3e098472f99805c0d350db1e63a542 in cordova-windows's branch 
refs/heads/master from IndieSW
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=c288357 ]

CB-13641: support transparent splash screen background color. (#245)



> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332538#comment-16332538
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on issue #245: CB-13641: (windows) support transparent 
splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359022090
 
 
   FYI I just did a squash and rebase in 

 (with some hand-work). I did NOT test this at all but I just wanted to see how 
the changes would come out in the merge (code should be exactly the same as in 
this PR).
   
   _P.S. Adding link to original 
 report for easy access_


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332529#comment-16332529
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on issue #245: CB-13641: (windows) support transparent 
splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359022090
 
 
   FYI I just did a squash and rebase in 

 (with some hand-work). I did NOT test this at all but I just wanted to see how 
the changes would come out in the merge (code should be exactly the same as in 
this PR).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332524#comment-16332524
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359019900
 
 
   I am just finding out if I may use the "Squash and merge" button in the 
Github UI or if I have use a CLI tool of cordova... But yeah, goal is to squash 
it into one commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332520#comment-16332520
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on a change in pull request #245: CB-13641: (windows) support 
transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162669620
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   Ok. I think I can merge this then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332509#comment-16332509
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on issue #245: CB-13641: (windows) support transparent 
splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359017484
 
 
   Another nit: I hope someone will rebase and squash. It would be nice to see 
the cleaned-up changes together in a single commit:)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332489#comment-16332489
 ] 

ASF GitHub Bot commented on CB-13641:
-

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359014617
 
 
   @janpio Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332487#comment-16332487
 ] 

ASF GitHub Bot commented on CB-13641:
-

IndieSW commented on a change in pull request #245: CB-13641: (windows) support 
transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162665269
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   I agree that the calls are unnecessary outside of the if blocks but I'm not 
really sure about the Cordova procedures.  Raising another issue would likely 
get the job done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332486#comment-16332486
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359013090
 
 
   > I think that got it. 
   
   Great.
   
   > I'm still a little confused about why cordova.js is in the repo because it 
appears to be a build artifact but I guess that's for another day. 
   
   Me too. Will see what happens when I continue with the release process later 
today or tomorrow, which will hopefully this PR merged :)
   
   > In any case, merge conflicts resolved.
   
    


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332484#comment-16332484
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on a change in pull request #245: CB-13641: (windows) support 
transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162663964
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   Yes please. 
   Unless @IndieSW just wants to piggyback that change onto their PR... that is 
going to be merged... soon...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332470#comment-16332470
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on a change in pull request #245: CB-13641: (windows) 
support transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162662388
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   @IndieSW I guess you are right. I think it should have been done in the 
change PR #232 (279816743f995510a1070a0bf77a3180f11e468a). I think it would be 
better not to execute 
`Windows.UI.ViewManagement.ApplicationView.getForCurrentView()` if it is not 
needed. I guess we should raise another JIRA issue to fix this one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332461#comment-16332461
 ] 

ASF GitHub Bot commented on CB-13641:
-

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359007743
 
 
   Hi, @janpio, I think that got it.  I'm still a little confused about why 
cordova.js is in the repo because it appears to be a build artifact but I guess 
that's for another day.  In any case, merge conflicts resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332455#comment-16332455
 ] 

ASF GitHub Bot commented on CB-13641:
-

IndieSW commented on a change in pull request #245: CB-13641: (windows) support 
transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162660627
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   I think that makes sense in both cases but it was unrelated to the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332452#comment-16332452
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on a change in pull request #245: CB-13641: (windows) 
support transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162660144
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2064,7 +2064,7 @@
 // Revert title bg color
 function revertTitleBarColor () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   Ditto (move into if block?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332451#comment-16332451
 ] 

ASF GitHub Bot commented on CB-13641:
-

IndieSW commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-359007743
 
 
   Hi, @janpio, I think that got it.  I'm still a little confused about why 
cordova.js is in the repo because it appears to be a build artifact but I guess 
that's for another day.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332449#comment-16332449
 ] 

ASF GitHub Bot commented on CB-13641:
-

brodybits commented on a change in pull request #245: CB-13641: (windows) 
support transparent splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#discussion_r162659876
 
 

 ##
 File path: template/www/cordova.js
 ##
 @@ -2053,7 +2053,7 @@
 // Make title bg color match splashscreen bg color
 function colorizeTitleBar () {
 var appView = 
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
 
 Review comment:
   Why not move the `var appView` declaration into the if block?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332391#comment-16332391
 ] 

ASF GitHub Bot commented on CB-13264:
-

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage 
descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358996934
 
 
   edit-config used to work in PGB. If it's now broken in cli-7.1.0 report it 
to Adobe, this plugin is from Apache.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332390#comment-16332390
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703
 
 
   just stating that thousands of PGB users will soon have problem building 
native iOS when they update this plugin
   
   however this may have a good impact, as they may think of switching to PWA 
;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332388#comment-16332388
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703
 
 
   just stating that thousands of PGB users will soon have problem building 
native iOS when they update this plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332386#comment-16332386
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995703
 
 
   just stating that thousands of PGB users will soon have problem when they 
update this plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332385#comment-16332385
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995532
 
 
   edit-config doesn't work in the Phonegap Build version cli-7.1.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332382#comment-16332382
 ] 

ASF GitHub Bot commented on CB-13264:
-

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage 
descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358995278
 
 
   Yes, there is a way, you have to use `edit-config` tag as documented in the 
README.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332379#comment-16332379
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358994990
 
 
   thats true, but there is no way to add those params to the plist file with 
the latest update of PGB
   which more or less makes the cordova-plugin-camera version stuck at 2.4.1...
   
   unless using cordova-plugin-ios-camera-permissions


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332373#comment-16332373
 ] 

ASF GitHub Bot commented on CB-13264:
-

jcesarmobile commented on issue #295: CB-13264 (iOS): Remove ios usage 
descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358993466
 
 
   This just removes the usage description variables from the plugin.xml, so 
not sure how this "is not working in Phonegap build".
   
   Anyway, this is not the place to report your Phonegap build problems


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332352#comment-16332352
 ] 

ASF GitHub Bot commented on CB-12367:
-

willmero commented on issue #210: CB-12367: Modernize styling of iOS 
InAppBrowser view
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-358989090
 
 
   WE ARE SO CLOSE! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>Priority: Major
>
> I've been working on a branch that brings several visual and configuration 
> improvements to the iOS InAppBrowser view, along with a little refactoring of 
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method 
> into several smaller helper methods to handle the creation of individual 
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of 
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to 
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or 
> {{black}}
> * sets the status bar style and background color to match the 
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match 
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like 
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered 
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13264) Remove ios usage descriptions from camera plugin

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332316#comment-16332316
 ] 

ASF GitHub Bot commented on CB-13264:
-

kleeb commented on issue #295: CB-13264 (iOS): Remove ios usage descriptions
URL: 
https://github.com/apache/cordova-plugin-camera/pull/295#issuecomment-358981134
 
 
   its not working in Phonegap Build


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove ios usage descriptions from camera plugin
> 
>
> Key: CB-13264
> URL: https://issues.apache.org/jira/browse/CB-13264
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332234#comment-16332234
 ] 

ASF GitHub Bot commented on CB-13800:
-

codecov-io commented on issue #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429#issuecomment-358963013
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=h1) 
Report
   > Merging 
[#429](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/6cc4896690e73503a2281d7b63640f6d4ed5ffaa?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/429/graphs/tree.svg?width=650=pr=q14nMf6C5a=150)](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #429   +/-   ##
   ===
 Coverage   43.95%   43.95%   
   ===
 Files  17   17   
 Lines1711 1711   
 Branches  318  318   
   ===
 Hits  752  752   
 Misses959  959
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=footer).
 Last update 
[6cc4896...075d381](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13801) Fail to restore plugins with relative path

2018-01-19 Thread Michael Goffioul (JIRA)

Michael Goffioul created CB-13801:
-

 Summary: Fail to restore plugins with relative path
 Key: CB-13801
 URL: https://issues.apache.org/jira/browse/CB-13801
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-lib
Reporter: Michael Goffioul


1. Create a cordova project
2. Add android platform
3. Add a local plugin using a relative path: {{cordova plugin add 
myplugins/testplugin}}
4. Delete directories platforms/ and plugins/
5. Prepare android: {{cordova prepare android}}

Cordova will fail to restore the local plugin. The plugin has been added to 
{{package.json}} using the spec {{file:myplugins/testplugin}} and the 
restoration utility is unable to handle such URL. Note that {{config.xml}} 
contains the spec {{myplugins/testplugin}} (that is, without the file: scheme), 
but the one in {{package.json}} takes precedence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13792) Settings in config.xml seem to have no effect

2018-01-19 Thread Anders Borg (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332232#comment-16332232
 ] 

Anders Borg commented on CB-13792:
--

I checked whether there would be a difference if I put the settings in 
config.xml outside of a "", but it didn't. It seems the 
iOS plugin code simply ignores settings in config.xml, and only uses dynamic 
settings.

> Settings in config.xml seem to have no effect
> -
>
> Key: CB-13792
> URL: https://issues.apache.org/jira/browse/CB-13792
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: cli-7.1.0 with iOS 4.5.4
> cordova-plugin-statusbar 2.4.1
> Building with PhoneGap Build
>  
>Reporter: Anders Borg
>Priority: Minor
>  Labels: cordova-plugin-statusbar, ios
>
> These settings seem to do nothing at all on iOS:
> 
>  
>  
> (the status bar still overlays the app window and colors are not changed)
> I need to do this to get the intended effect:
> StatusBar.overlaysWebView(false);
>  StatusBar.backgroundColorByHexString("#ff");
>  StatusBar.styleDefault();
> This behavior is not obvious to me from reading the documentation.
> As there's a workaround with dynamic settings, it's not a showstopper, but 
> the drawback is that the dynamic setting is not done until Cordova is ready, 
> so there's some "jerkiness" to the UX.
> Cheers,
> Anders



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332220#comment-16332220
 ] 

ASF GitHub Bot commented on CB-13800:
-

BBosman opened a new pull request #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429
 
 
   ### Platforms affected
   Android
   
   ### What does this PR do?
   
   With the release of cordova-android 7.0.0 the minimum API-Level was set to 
19. There are a couple of places in the codebase where we have specific logic 
for older API-levels which are now no longer needed and can therefore be 
removed.
   
   This PR removes them. It results in (negligible) faster execution and 
smaller binary sizes, but most importantly less code to maintain.
   
   ### What testing has been done on this change?
Ran:
   * npm test
   * gradlew test
   * gradlew connectedAndroidTest
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13800) Drop pre-KitKat specific code

2018-01-19 Thread Bas Bosman (JIRA)

Bas Bosman created CB-13800:
---

 Summary: Drop pre-KitKat specific code
 Key: CB-13800
 URL: https://issues.apache.org/jira/browse/CB-13800
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-android
Affects Versions: 7.0.0
Reporter: Bas Bosman
Assignee: Bas Bosman


With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.

 

There are a couple of places in the codebase where we have specific logic for 
older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018

2018-01-19 Thread Jan Piotrowski (Sujan) (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332115#comment-16332115
 ] 

Jan Piotrowski (Sujan) commented on CB-13799:
-

Sent "Get Buy-in" email to dev mailing-list at d...@cordova.apache.org

> Cordova-Windows Platform Release January 19/20, 2018
> 
>
> Key: CB-13799
> URL: https://issues.apache.org/jira/browse/CB-13799
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13799) Cordova-Windows Platform Release January 19/20, 2018

2018-01-19 Thread Jan Piotrowski (Sujan) (JIRA)

Jan Piotrowski (Sujan) created CB-13799:
---

 Summary: Cordova-Windows Platform Release January 19/20, 2018
 Key: CB-13799
 URL: https://issues.apache.org/jira/browse/CB-13799
 Project: Apache Cordova
  Issue Type: Task
Reporter: Jan Piotrowski (Sujan)


Following steps at 
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13798) cordova-plugin-network-information plugin throws runtime error

2018-01-19 Thread Johannes (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Johannes closed CB-13798.
-
Resolution: Fixed

reinstalled cordova android platform

reinstalled plugin

worked :/ 

> cordova-plugin-network-information plugin throws runtime error
> --
>
> Key: CB-13798
> URL: https://issues.apache.org/jira/browse/CB-13798
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-network-information
>Reporter: Johannes
>Priority: Major
>
> Hello!
>  This is my first post on here, so I'm apologizing for anything I forgot or 
> upsetting someone here
> I want to use the cordova-plugin-network-information and think I have 
> installed it correctly. 
>  I have an Ionic project with latest npm updates.
> Installed the plugin as stated here:
> [https://ionicframework.com/docs/native/network/]
>  
> The folowing error pops up when compiling the project via ionic serve
> Uncaught Error: Unexpected value 'Network' declared by the module 
> 'AppModule'. Please add a @Pipe/@Directive/@Component annotation.
>  at syntaxError (compiler.es5.js:1694)
>  at compiler.es5.js:15590
>  at Array.forEach ()
>  at CompileMetadataResolver.getNgModuleMetadata (compiler.es5.js:15572)
>  at JitCompiler._loadModules (compiler.es5.js:26958)
>  at JitCompiler._compileModuleAndComponents (compiler.es5.js:26931)
>  at JitCompiler.compileModuleAsync (compiler.es5.js:26860)
>  at PlatformRef_._bootstrapModuleWithZone (core.es5.js:4536)
>  at PlatformRef_.bootstrapModule (core.es5.js:4522)
>  at Object.297 (main.ts:5)
>  08:14:45.765
> Guessing what causes this is that I cannot test this plugin within my 
> computer's browser, but then again I don't know how to test it then :(
>  Any help is greatly appreciated
>  
> Version is 2.0.1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13795) cordova-plugin-camera. When click on browse image it return errors encountered while discovering extensions: Error Domain=PlugInKit Code=13 "query cancelled" UserInfo={NS

2018-01-19 Thread Zeeshan Aslam (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331957#comment-16331957
 ] 

Zeeshan Aslam commented on CB-13795:


Same issue with 4.0.1

> cordova-plugin-camera. When click on browse image it return errors 
> encountered while discovering extensions: Error Domain=PlugInKit Code=13 
> "query cancelled" UserInfo={NSLocalizedDescription=query cancelled} on Ipad 
> pro.
> 
>
> Key: CB-13795
> URL: https://issues.apache.org/jira/browse/CB-13795
> Project: Apache Cordova
>  Issue Type: Bug
> Environment: ionic version 
> 3.19.0
> Cordova Version
> 6.0.0
> Cordova Plugin Camera 
> 2.1.1
>  
>Reporter: Zeeshan Aslam
>Priority: Major
>
> I am using *cordova-plugin-camera-2.1.1.*
> When click on Image in browser images list. it return
> *errors encountered while discovering extensions: Error Domain=PlugInKit 
> Code=13 "query cancelled" UserInfo=\{NSLocalizedDescription=query cancelled}*
> i already add '*NSLocalizedDescription*' in *info.plist*. 
> it is working on other iPhone. This is happening only on iPad pro.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331950#comment-16331950
 ] 

ASF GitHub Bot commented on CB-13641:
-

janpio commented on issue #245: CB-13641: (windows) support transparent splash 
screen background color.
URL: https://github.com/apache/cordova-windows/pull/245#issuecomment-358905936
 
 
   Hey @IndieSW, can you take a look at the conflict? If you resolve this, I 
think this is good to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen on Windows does not allow for transparent background color.
> -
>
> Key: CB-13641
> URL: https://issues.apache.org/jira/browse/CB-13641
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10.
>Reporter: Terence Bandoian
>Priority: Trivial
>  Labels: newbie
> Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13684) Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in build.json

2018-01-19 Thread Daniel Cooper (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331921#comment-16331921
 ] 

Daniel Cooper commented on CB-13684:


[~bowserj] thank you for explaining the situation regarding console prompts.

The issue is that when the passwords are passed as command line args, the 
process presumably attempts to display the prompt and throws the exception. Is 
it not possible to skip the prompt if the password are provided at the cli?

> Not be able to sign apk with 6.4.0 and 7.0.0 without specifying passwords in 
> build.json
> ---
>
> Key: CB-13684
> URL: https://issues.apache.org/jira/browse/CB-13684
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Reporter: Kevin Lot
>Assignee: Joe Bowser
>Priority: Major
>
> Since 6.4.0, sign APK without specify passwords in config file does not work.
> Cause gradle 4.1.0 has this issue [#2826] - Use SwingBuilder in customize 
> task on Android studio throw java.awt.HeadlessException. 
> ([link|https://github.com/gradle/gradle/issues/2826]).
> If you don't specify passwords in config file to sign your APK, compilation 
> launches a window with SwingBuilder to prompt passwords.
> {code:java}
> def doPromptForPassword(msg) {
> if (System.console() == null) {
> def ret = null
> new SwingBuilder().edt {
> dialog(modal: true, title: 'Enter password', alwaysOnTop: true, 
> resizable: false, locationRelativeTo: null, pack: true, show: true) {
> vbox {
> label(text: msg)
> def input = passwordField()
> button(defaultButton: true, text: 'OK', actionPerformed: {
> ret = input.password;
> dispose();
> })
> }
> }
> }
> if (!ret) {
> throw new GradleException('User canceled build')
> }
> return new String(ret)
> } else {
> return System.console().readPassword('\n' + msg);
> }
> }
> {code}
> On Linux Mint 18.3 and MacOs High sierra, even in terminal, System.console() 
> return null and compilation crashes due to gradle issue.
> Thanks for help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

55 matches

Mail list logo