[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518928#comment-16518928 ] ASF GitHub Bot commented on CB-13685: - codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) Report > Merging [#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/559b0833b42402a2b0fba6d6369fbc713e1063c1?src=pr&el=desc) will **decrease** coverage by `3.79%`. > The diff coverage is `66.92%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?src=pr&token=q14nMf6C5a&width=650&height=150)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #448 +/- ## = - Coverage 47.63% 43.84% -3.8% = Files 17 18 +1 Lines1694 2023+329 Branches 311 383 +72 = + Hits 807 887 +80 - Misses887 1136+249 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `35.44% <40%> (+0.3%)` | :arrow_up: | | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `41.66% <68%> (ø)` | | | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `15.38% <0%> (-84.62%)` | :arrow_down: | | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `26.98% <0%> (-73.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer). Last update [559b083...240ff04](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority: Minor > > Starting with Android 8 Oreo (API level 26) Android allows developers to > create app icons using a background and a foreground image file. This feature > is called "adaptive icons". One major change that goes with this feature is > that icons get now clipped into a shape by the system. This leads to a very > uniform and clean design like on iOS where all icons are a rounded rectangle. > The other advantage is that visual effects can be applied to the icon by the > system due to the separation between foreground an background. > Android Studio greatly assists the developer at the creation of the app icon > resources because it creates backwards compatible icons for older devices > that don't support the adaptive icons feature. > https://developer.android.com/studio/write/image-asset-studio.html > The following resources are created. > {code} > res > ├── drawable > │ ├── ic_launcher_background.xml > │ └── ic_launcher_foreground.xml > ├── mipmap-anydpi-v26 > │ ├── ic_launcher.xml > │ └── ic_launcher_round.xml > ├── mipmap-hdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-mdpi > │ ├── ic_launcher.
[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518927#comment-16518927 ] ASF GitHub Bot commented on CB-13685: - codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=h1) Report > Merging [#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/559b0833b42402a2b0fba6d6369fbc713e1063c1?src=pr&el=desc) will **decrease** coverage by `3.79%`. > The diff coverage is `66.92%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/448/graphs/tree.svg?src=pr&token=q14nMf6C5a&width=650&height=150)](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #448 +/- ## = - Coverage 47.63% 43.84% -3.8% = Files 17 18 +1 Lines1694 2023+329 Branches 311 383 +72 = + Hits 807 887 +80 - Misses887 1136+249 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=) | `35.44% <40%> (+0.3%)` | :arrow_up: | | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `41.66% <68%> (ø)` | | | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `15.38% <0%> (-84.62%)` | :arrow_down: | | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `26.98% <0%> (-73.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=footer). Last update [559b083...240ff04](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority: Minor > > Starting with Android 8 Oreo (API level 26) Android allows developers to > create app icons using a background and a foreground image file. This feature > is called "adaptive icons". One major change that goes with this feature is > that icons get now clipped into a shape by the system. This leads to a very > uniform and clean design like on iOS where all icons are a rounded rectangle. > The other advantage is that visual effects can be applied to the icon by the > system due to the separation between foreground an background. > Android Studio greatly assists the developer at the creation of the app icon > resources because it creates backwards compatible icons for older devices > that don't support the adaptive icons feature. > https://developer.android.com/studio/write/image-asset-studio.html > The following resources are created. > {code} > res > ├── drawable > │ ├── ic_launcher_background.xml > │ └── ic_launcher_foreground.xml > ├── mipmap-anydpi-v26 > │ ├── ic_launcher.xml > │ └── ic_launcher_round.xml > ├── mipmap-hdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-mdpi > │ ├── ic_launcher.
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518910#comment-16518910 ] ASF GitHub Bot commented on CB-14145: - brodybits commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-398976030 @raphinesse I just updated the last 2 commits to reference the PRs they originated from and show what kind of scripts are affected. (GitHub links to the PRs from the commits in master, would be nice to have the same kind of thing in the 7.1.x branch. To show what kind of scripts are affected would also be good for the patch release notes.) I may just include all the fixes in the same patch release to streamline things. I think the npm audit issues will not lead to any real vulnerabilities, at least not yet:) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518909#comment-16518909 ] ASF GitHub Bot commented on CB-14145: - codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=h1) Report > Merging [#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=desc) into [7.1.x](https://codecov.io/gh/apache/cordova-android/commit/0bd3309323612bc9d4e8bac474bbb185ab93e1a0?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/451/graphs/tree.svg?width=650&height=150&token=q14nMf6C5a&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=tree) ```diff @@ Coverage Diff @@ ##7.1.x #451 +/- ## === Coverage 43.95% 43.95% === Files 17 17 Lines1711 1711 Branches 318 318 === Hits 752 752 Misses959 959 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=footer). Last update [0bd3309...c14e0dc](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518908#comment-16518908 ] ASF GitHub Bot commented on CB-14145: - codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=h1) Report > Merging [#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=desc) into [7.1.x](https://codecov.io/gh/apache/cordova-android/commit/0bd3309323612bc9d4e8bac474bbb185ab93e1a0?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/451/graphs/tree.svg?width=650&src=pr&token=q14nMf6C5a&height=150)](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=tree) ```diff @@ Coverage Diff @@ ##7.1.x #451 +/- ## === Coverage 43.95% 43.95% === Files 17 17 Lines1711 1711 Branches 318 318 === Hits 752 752 Misses959 959 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=footer). Last update [0bd3309...c14e0dc](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518900#comment-16518900 ] ASF GitHub Bot commented on CB-14145: - brodybits commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-398971798 @raphinesse you convinced me about the first 2 commits you added: - f05e61d - CB-13923 (android) fix -1 length for compressed files - 5cd19a3 - CB-14127: (android) Move google maven repo ahead of jcenter I am still not so convinced about the 3 commits: - 056fe36 - change from #446 (CB-14101 Fix Java version check for Java >= 9) more drastic than I would like to include in a security audit patch - 7c278e3 - change from #452 (emit log event) looks straightforward enough, would have liked a JIRA issue number before sticking it into this patch release. 552e4be - fix unsafe property access (ported from 1a8154c90e5defb6a67b8947e4940666521355bb) is even more ugly since it appears to be a side effect of a PR to add more unit test coverage (#445). I think it would be ideal to move the last 3 commits to a followup patch, not sure if it is worth the effort to split them out or not. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518877#comment-16518877 ] ASF GitHub Bot commented on CB-13685: - dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398967376 I will make sure this gets merged into the next major This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority: Minor > > Starting with Android 8 Oreo (API level 26) Android allows developers to > create app icons using a background and a foreground image file. This feature > is called "adaptive icons". One major change that goes with this feature is > that icons get now clipped into a shape by the system. This leads to a very > uniform and clean design like on iOS where all icons are a rounded rectangle. > The other advantage is that visual effects can be applied to the icon by the > system due to the separation between foreground an background. > Android Studio greatly assists the developer at the creation of the app icon > resources because it creates backwards compatible icons for older devices > that don't support the adaptive icons feature. > https://developer.android.com/studio/write/image-asset-studio.html > The following resources are created. > {code} > res > ├── drawable > │ ├── ic_launcher_background.xml > │ └── ic_launcher_foreground.xml > ├── mipmap-anydpi-v26 > │ ├── ic_launcher.xml > │ └── ic_launcher_round.xml > ├── mipmap-hdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-mdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xxhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > └── mipmap-xxxhdpi > ├── ic_launcher.png > └── ic_launcher_round.png > {code} > It is currently not clear how these files can be used inside a cordova > project. > - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources > (foreground, background) > - The foreground and background can be vector graphics (-> xml files in > res/drawable) > - The documentation needs to be updated > (I've never reported an issue using JIRA before - I'm only used to github. > So, please guide me if I'm doing something incorrect) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518841#comment-16518841 ] ASF GitHub Bot commented on CB-14145: - raphinesse commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-398959505 As a user, I'd be annoyed by a patch release not including fixes to my problems even though they are ready to ship. I see your point however. Since you do the release, decide at your own discretion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[ https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518767#comment-16518767 ] ASF GitHub Bot commented on CB-13685: - Menardi commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398943023 This PR looks good to me. I need adaptive icons for one of my own apps, so I'm eager to see this get merged soon. Without support for this, icons for apps using `cordova-android@7` (targeting API 26+) look a bit rubbish on newer devices. I noticed the main cordova-android maintainer, Joe, has announced on the mailing list that he is stepping down. So, I expect that getting this thoroughly reviewed is now more difficult. If there is anything I can do to get this over the line, please let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android Adaptive Icons > -- > > Key: CB-13685 > URL: https://issues.apache.org/jira/browse/CB-13685 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android > Environment: All >Reporter: Josef Brandl >Assignee: Joe Bowser >Priority: Minor > > Starting with Android 8 Oreo (API level 26) Android allows developers to > create app icons using a background and a foreground image file. This feature > is called "adaptive icons". One major change that goes with this feature is > that icons get now clipped into a shape by the system. This leads to a very > uniform and clean design like on iOS where all icons are a rounded rectangle. > The other advantage is that visual effects can be applied to the icon by the > system due to the separation between foreground an background. > Android Studio greatly assists the developer at the creation of the app icon > resources because it creates backwards compatible icons for older devices > that don't support the adaptive icons feature. > https://developer.android.com/studio/write/image-asset-studio.html > The following resources are created. > {code} > res > ├── drawable > │ ├── ic_launcher_background.xml > │ └── ic_launcher_foreground.xml > ├── mipmap-anydpi-v26 > │ ├── ic_launcher.xml > │ └── ic_launcher_round.xml > ├── mipmap-hdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-mdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > ├── mipmap-xxhdpi > │ ├── ic_launcher.png > │ └── ic_launcher_round.png > └── mipmap-xxxhdpi > ├── ic_launcher.png > └── ic_launcher_round.png > {code} > It is currently not clear how these files can be used inside a cordova > project. > - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources > (foreground, background) > - The foreground and background can be vector graphics (-> xml files in > res/drawable) > - The documentation needs to be updated > (I've never reported an issue using JIRA before - I'm only used to github. > So, please guide me if I'm doing something incorrect) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14148) cordova platform ls shows nonsense www ^3.12.0 platform
[ https://issues.apache.org/jira/browse/CB-14148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518760#comment-16518760 ] Chris Brody commented on CB-14148: -- I suspect the culprit is the {{www}} entry in: [github.com/apache/cordova-lib/.../src/platforms/platformsConfig.json#L22-L28|https://github.com/apache/cordova-lib/blob/master/src/platforms/platformsConfig.json#L22-L28] > cordova platform ls shows nonsense www ^3.12.0 platform > --- > > Key: CB-14148 > URL: https://issues.apache.org/jira/browse/CB-14148 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-common, cordova-lib >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Minor > > As I already reported in > [apache/cordova-discuss#86|https://github.com/apache/cordova-discuss/issues/86] > and saw someone else report in Slack: > {code:bash} > $ cordova --version > 8.0.0 > {code} > {code:bash} > $ cordova platform ls > Installed platforms: > > Available platforms: > android ~7.0.0 > browser ~5.0.1 > ios ~4.5.4 > osx ~4.0.1 > windows ~5.0.0 > www ^3.12.0 > {code} > If I would do {{cordova platform add www}}: > {code:bash} > $ cordova platform add www > (node:10383) UnhandledPromiseRejectionWarning: CordovaError: Error: npm: > Command failed with exit code 1 Error output: > npm ERR! code ENOLOCAL > npm ERR! Could not install from "www" as it does not contain a package.json > file. > npm ERR! A complete log of this run can be found in: > npm ERR! /Users/brodybits/.npm/_logs/2018-01-04T04_21_59_700Z-debug.log > at > /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/cordova-fetch/index.js:104:29 > at _rejected > (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:864:24) > at > /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:890:30 > at Promise.when > (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:1142:31) > at Promise.promise.promiseDispatch > (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:808:41) > at > /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:624:44 > at runSingle > (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:137:13) > at flush > (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > (node:10383) UnhandledPromiseRejectionWarning: Unhandled promise rejection. > This error originated either by throwing inside of an async function without > a catch block, or by rejecting a promise which was not handled with .catch(). > (rejection id: 1) > (node:10383) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14152) cordova-js tools patch release Jun 20, 2018
Chris Brody created CB-14152: Summary: cordova-js tools patch release Jun 20, 2018 Key: CB-14152 URL: https://issues.apache.org/jira/browse/CB-14152 Project: Apache Cordova Issue Type: Task Components: cordova-js Reporter: Chris Brody Assignee: Chris Brody Following steps at [https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md] (with some adaptations) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-9366) Log error.stack when a call to a plugin throws an exception
[ https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Brody resolved CB-9366. - Resolution: Fixed Assignee: Chris Brody (was: Nikhil Khandelwal) Fix Version/s: 4.2.4 > Log error.stack when a call to a plugin throws an exception > --- > > Key: CB-9366 > URL: https://issues.apache.org/jira/browse/CB-9366 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: Master >Reporter: Nikhil Khandelwal >Assignee: Chris Brody >Priority: Minor > Fix For: 4.2.4 > > > This can help in isolating the cause of the error. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-7078) serve.spec.js is slow, should be rewritten to be like plugin.spec.js
[ https://issues.apache.org/jira/browse/CB-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raphael reassigned CB-7078: --- Assignee: Raphael > serve.spec.js is slow, should be rewritten to be like plugin.spec.js > - > > Key: CB-7078 > URL: https://issues.apache.org/jira/browse/CB-7078 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-serve >Reporter: Mark Koudritsky >Assignee: Raphael >Priority: Major > > The spec for `cordova serve` is slow and overly complicated. > It re-creates the project for each sub-test and and uses the vanilla platform > files which causes it to hit the network if platform files are not cached in > ~/.cordova/lib. > The attempt to test all platforms usable on the current box the test is > running on is admirable, but it results in non-repeatability between machines > which is more of a problem than benefit. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[ https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518685#comment-16518685 ] altShiftDev commented on CB-14144: -- [~jcesarmobile] this isn't some kind of conspiracy where I know quasar is the issue and I'm trying to mislead you... My troubleshooting of quasar found it was not the culprit, the line in question is the only "addEventListener" for backbutton in the entire framework and it doesn't fire before the app closes, see for yourself by commenting out the line: node_modules > quasar-framework > dist > quasar.mat.esm.js (line 310) The reason I believe it's a cordova issue is that the event when that navigator.app.exitApp is commented out the backbutton still kills the app, but only on API 23 and below. > BackButton Event Listeners do not fire on Android API 23 or below > - > > Key: CB-14144 > URL: https://issues.apache.org/jira/browse/CB-14144 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... > all exhibit this behaviour. > Quasar Framework is building my project a long with webpack but I've no > reason to suspect Quasar as the cause, they only register a single > eventListener for backbutton and I've manually gone in and edited the source > code for this listener and it never fires leading me to believe the problem > is with Cordova. >Reporter: altShiftDev >Assignee: Joe Bowser >Priority: Major > > App exits immediately on back button press without ever firing the > eventListener designed to capture and reroute it. > There is nothing wrong with my eventListener code, it's been tested on Api 25 > and higher and is very stable: > `document.addEventListener('backbutton', this.onBackButton, false)` > I have not yet tested to confirm if API 24 has this bug or not. > This affects many of my users, including myself as I've got a phone running > Android at these versions. The app is completely killed with every tap of the > back button (new launches of the app cold boot with splashscreen) making it > impossible to properly navigate the app: closing modals, moving backwards in > operations, etc... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[ https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-14144. - Resolution: Not A Problem Closing as not a problem because it's not a Cordova problem. You say that you have no clue about what is going on, but I've seen this commit where you commented about that quasar change breaking your app https://github.com/quasarframework/quasar/commit/ad08d33e54f283efeda3f1cfafed36a8b737deb0#diff-19f17119652f3ca089e2e90679f0e82eR30 quasar is messing with the backbutton event and forcing the app to close > BackButton Event Listeners do not fire on Android API 23 or below > - > > Key: CB-14144 > URL: https://issues.apache.org/jira/browse/CB-14144 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... > all exhibit this behaviour. > Quasar Framework is building my project a long with webpack but I've no > reason to suspect Quasar as the cause, they only register a single > eventListener for backbutton and I've manually gone in and edited the source > code for this listener and it never fires leading me to believe the problem > is with Cordova. >Reporter: altShiftDev >Assignee: Joe Bowser >Priority: Major > > App exits immediately on back button press without ever firing the > eventListener designed to capture and reroute it. > There is nothing wrong with my eventListener code, it's been tested on Api 25 > and higher and is very stable: > `document.addEventListener('backbutton', this.onBackButton, false)` > I have not yet tested to confirm if API 24 has this bug or not. > This affects many of my users, including myself as I've got a phone running > Android at these versions. The app is completely killed with every tap of the > back button (new launches of the app cold boot with splashscreen) making it > impossible to properly navigate the app: closing modals, moving backwards in > operations, etc... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception
[ https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518654#comment-16518654 ] ASF GitHub Bot commented on CB-9366: brodybits closed pull request #118: CB-9366 Log error.stack as it helps with diagnosing the source of the… URL: https://github.com/apache/cordova-js/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log error.stack when a call to a plugin throws an exception > --- > > Key: CB-9366 > URL: https://issues.apache.org/jira/browse/CB-9366 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: Master >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal >Priority: Minor > > This can help in isolating the cause of the error. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception
[ https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518653#comment-16518653 ] ASF GitHub Bot commented on CB-9366: brodybits closed pull request #161: CB-9366 Log error.stack (as it helps with diagnosing the source of the error) URL: https://github.com/apache/cordova-js/pull/161 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/cordova.js b/src/cordova.js index 6297c4e8..09d3451a 100644 --- a/src/cordova.js +++ b/src/cordova.js @@ -227,6 +227,7 @@ var cordova = { } catch (err) { var msg = 'Error in ' + (isSuccess ? 'Success' : 'Error') + ' callbackId: ' + callbackId + ' : ' + err; console && console.log && console.log(msg); +console && console.log && err.stack && console.log(err.stack); cordova.fireWindowEvent('cordovacallbackerror', { 'message': msg }); throw err; } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log error.stack when a call to a plugin throws an exception > --- > > Key: CB-9366 > URL: https://issues.apache.org/jira/browse/CB-9366 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: Master >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal >Priority: Minor > > This can help in isolating the cause of the error. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception
[ https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518645#comment-16518645 ] ASF GitHub Bot commented on CB-9366: brodybits opened a new pull request #161: CB-9366 Log error.stack (as it helps with diagnosing the source of the error) URL: https://github.com/apache/cordova-js/pull/161 ### Platforms affected All ### What does this PR do? See title - rebase PR #118 & rework the JavaScript change ### What testing has been done on this change? - ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - ~~Added automated test coverage as appropriate for this change.~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log error.stack when a call to a plugin throws an exception > --- > > Key: CB-9366 > URL: https://issues.apache.org/jira/browse/CB-9366 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: Master >Reporter: Nikhil Khandelwal >Assignee: Nikhil Khandelwal >Priority: Minor > > This can help in isolating the cause of the error. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518607#comment-16518607 ] ASF GitHub Bot commented on CB-14145: - brodybits closed pull request #159: CB-14145 resolve npm audit issues in package.json URL: https://github.com/apache/cordova-js/pull/159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/package.json b/package.json index 3e486fb8..8fcc9330 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,6 @@ } ], "devDependencies": { -"connect": "^3.5.0", "eslint": "^4.7.2", "eslint-config-semistandard": "^11.0.0", "eslint-config-standard": "^10.2.1", @@ -79,10 +78,9 @@ "grunt": "^1.0.1", "grunt-contrib-clean": "^1.0.0", "istanbul": "^0.4.5", -"jasmine-node": "1.14.5", +"jasmine-node": "^1.14.6", "jsdom-no-contextify": "^3.1.0", -"mkdirp": "^0.5.0", -"open": "0.0.5" +"mkdirp": "^0.5.0" }, "dependencies": { "browserify": "14.4.0" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518597#comment-16518597 ] ASF GitHub Bot commented on CB-14145: - brodybits opened a new pull request #159: CB-14145 resolve npm audit issues in package.json URL: https://github.com/apache/cordova-js/pull/159 ### Platforms affected All ### What does this PR do? Resolve existing npm audit issues: - remove open & other devDepenencies for broken btest - update jasmine-node@^1.14.6 ### What testing has been done on this change? These changes are part of WIP PR #151 which passes AppVeyor CI & Travis CI. Note that AppVeyor CI is expected to be flaky in this PR. This should be fixed by removing clone of old, unsupported Cordova platforms. ### Checklist - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~ - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected.~~ - ~~Added automated test coverage as appropriate for this change.~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518576#comment-16518576 ] ASF GitHub Bot commented on CB-14145: - brodybits commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-398889164 FYI the delay is because it is taking me much longer than I expected to resolve the npm audit issues on cordova-js which I would consider to be an upstream dependency. My apologies for the confusion. /cc @jcesarmobile This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518574#comment-16518574 ] ASF GitHub Bot commented on CB-14145: - brodybits commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-39401 > I've cherry-picked all code fix commits from master that I could identify. Thanks @raphinesse, updated title yet again to reflect what we actually want to do in the patch release. TBH I have some mixed feelings, though not major. In general I would rather avoid including other fixes when making a security related patch. For a security patch we want the least risk possible that something goes wrong and the "end" user decides to roll back. I think the actual security risk is very low. In general I would rather keep it this way. Another really strange thing is that f05e61db07ff7b7acbcadaa6427b7b12eaac8950 seems to have a MacBook-Pro.local address, not linked to any user on GitHub. What do you think, any comments? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518519#comment-16518519 ] ASF GitHub Bot commented on CB-14145: - codecov-io edited a comment on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=h1) Report > Merging [#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=desc) into [7.1.x](https://codecov.io/gh/apache/cordova-android/commit/0bd3309323612bc9d4e8bac474bbb185ab93e1a0?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/451/graphs/tree.svg?token=q14nMf6C5a&src=pr&height=150&width=650)](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=tree) ```diff @@ Coverage Diff @@ ##7.1.x #451 +/- ## === Coverage 43.95% 43.95% === Files 17 17 Lines1711 1711 Branches 318 318 === Hits 752 752 Misses959 959 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=footer). Last update [0bd3309...552e4be](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[ https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518512#comment-16518512 ] ASF GitHub Bot commented on CB-14145: - raphinesse commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-398865708 I've cherry-picked all code fix commits from master that I could identify. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Resolve npm audit issues > > > Key: CB-14145 > URL: https://issues.apache.org/jira/browse/CB-14145 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-app-hello-world, > cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch, > cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > From private discussions I discovered that running {{npm audit}} on a number > of components would report dependencies with security issues. While we could > not see any {{npm audit}} issues that may affect applications built using > Cordova I think it is extremely important to resolve these issues as soon as > possible. Most affect devDependencies used for testing of Cordova itself; a > minority seem to affect Cordova scripts that may be run by Cordova > application developers. Better safe than sorry! > I would like to resolve this issue as follows: > * patch release of common library components such as {{cordova-common}}, > {{cordova-lib}}, etc. (fixed in minor release branch) > * patch or minor release of other affected components such as CLI, Cordova > platform implementations, major plugins, etc. (expected to be fixed in minor > release branch; do not want to pollute the master branch with extra reverts, > updated node_modules committed, etc.) > * {{npm audit}} issues resolved in master branch for next major release, > which should NOT be shipped with any {{npm audit}} issues lurking > * {{npm audit}} step added to CI for both patch release and next major release -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14151) Device Camera is not opening in samsung j7
Sandip Gadekar created CB-14151: --- Summary: Device Camera is not opening in samsung j7 Key: CB-14151 URL: https://issues.apache.org/jira/browse/CB-14151 Project: Apache Cordova Issue Type: Bug Reporter: Sandip Gadekar I am using [https://ionicframework.com/docs/native/media-capture/] this plugin to select images from device camera and gallery. but camera seems not working when I do this.mediaCapture.captureImage(imagesOptions).then((media: MediaFile[]) => { }), and application gets crashed It seems device specific since it is working on other device but not in samsung j7 since it has duel camera sensors -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[ https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518363#comment-16518363 ] altShiftDev commented on CB-14144: -- [~jcesarmobile] I really appreciate you helping, I made a barebones repo: [https://github.com/altShiftDev/backbuttontest] Sorry it includes quasar + vue but if Cordova isn't at fault then something else in my environment is and these are the likely suspects. These are the 2 commands needed to be able to build the project: yarn global add vue-cli yarn global add quasar-cli Also run "yarn" inside the directory to make all dependencies are met then run: quasar dev -m cordova -T android The above should create a folder called src-cordova/ add the android platform and build the app in dev mode and launch an emulator from android studio. If you already have one running it will use that one. The addEventListener is located in /src/app.vue in the "mounted" section which [according to quasar guarantees that deviceReady has already fired|https://quasar-framework.org/guide/cordova-plugins.html#Caveat]. > BackButton Event Listeners do not fire on Android API 23 or below > - > > Key: CB-14144 > URL: https://issues.apache.org/jira/browse/CB-14144 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... > all exhibit this behaviour. > Quasar Framework is building my project a long with webpack but I've no > reason to suspect Quasar as the cause, they only register a single > eventListener for backbutton and I've manually gone in and edited the source > code for this listener and it never fires leading me to believe the problem > is with Cordova. >Reporter: altShiftDev >Assignee: Joe Bowser >Priority: Major > > App exits immediately on back button press without ever firing the > eventListener designed to capture and reroute it. > There is nothing wrong with my eventListener code, it's been tested on Api 25 > and higher and is very stable: > `document.addEventListener('backbutton', this.onBackButton, false)` > I have not yet tested to confirm if API 24 has this bug or not. > This affects many of my users, including myself as I've got a phone running > Android at these versions. The app is completely killed with every tap of the > back button (new launches of the app cold boot with splashscreen) making it > impossible to properly navigate the app: closing modals, moving backwards in > operations, etc... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518352#comment-16518352 ] Austin France commented on CB-14150: for information, I am currently using the following hack, not ideal but in the absence of a proper fix or time to perform a toolset major version upgrade I am left with little choice. {code:java} if (obj2[key] !== obj1[key] && obj2[key] !== 'UNMET') {{code} > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[ https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518307#comment-16518307 ] jcesarmobile commented on CB-14144: --- I can't help you unless you provide a sample project where we can reproduce your issue > BackButton Event Listeners do not fire on Android API 23 or below > - > > Key: CB-14144 > URL: https://issues.apache.org/jira/browse/CB-14144 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... > all exhibit this behaviour. > Quasar Framework is building my project a long with webpack but I've no > reason to suspect Quasar as the cause, they only register a single > eventListener for backbutton and I've manually gone in and edited the source > code for this listener and it never fires leading me to believe the problem > is with Cordova. >Reporter: altShiftDev >Assignee: Joe Bowser >Priority: Major > > App exits immediately on back button press without ever firing the > eventListener designed to capture and reroute it. > There is nothing wrong with my eventListener code, it's been tested on Api 25 > and higher and is very stable: > `document.addEventListener('backbutton', this.onBackButton, false)` > I have not yet tested to confirm if API 24 has this bug or not. > This affects many of my users, including myself as I've got a phone running > Android at these versions. The app is completely killed with every tap of the > back button (new launches of the app cold boot with splashscreen) making it > impossible to properly navigate the app: closing modals, moving backwards in > operations, etc... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[ https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518295#comment-16518295 ] altShiftDev commented on CB-14144: -- [~jcesarmobile] you're right, that code works. Unfortunately this doesn't help me much in figuring out why mine doesn't. I would really appreciate if you could post the commands and versions for your setup as since if Cordova isn't the issue something else is interfering with it. I'm at a loss here on how to proceed, your help would be very much appreciated. :( > BackButton Event Listeners do not fire on Android API 23 or below > - > > Key: CB-14144 > URL: https://issues.apache.org/jira/browse/CB-14144 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5... > all exhibit this behaviour. > Quasar Framework is building my project a long with webpack but I've no > reason to suspect Quasar as the cause, they only register a single > eventListener for backbutton and I've manually gone in and edited the source > code for this listener and it never fires leading me to believe the problem > is with Cordova. >Reporter: altShiftDev >Assignee: Joe Bowser >Priority: Major > > App exits immediately on back button press without ever firing the > eventListener designed to capture and reroute it. > There is nothing wrong with my eventListener code, it's been tested on Api 25 > and higher and is very stable: > `document.addEventListener('backbutton', this.onBackButton, false)` > I have not yet tested to confirm if API 24 has this bug or not. > This affects many of my users, including myself as I've got a phone running > Android at these versions. The app is completely killed with every tap of the > back button (new launches of the app cold boot with splashscreen) making it > impossible to properly navigate the app: closing modals, moving backwards in > operations, etc... -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518276#comment-16518276 ] ASF GitHub Bot commented on CB-14127: - smart-union removed a comment on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398793492 Makes sense, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518275#comment-16518275 ] ASF GitHub Bot commented on CB-14127: - smart-union commented on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398793492 Makes sense, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518268#comment-16518268 ] ASF GitHub Bot commented on CB-14127: - jcesarmobile commented on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398792735 It doesn't directly affect cordova-android, it affects some plugins that can't fetch the dependencies because Google didn't publish their libraries correctly in jcenter. This fix is more a workaround than a real fix, the real fix is that Google republish the libraries again and do it right. And even if it affected all cordova-android versions and all Cordova apps, we only backport security fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518259#comment-16518259 ] Austin France edited comment on CB-14150 at 6/20/18 3:20 PM: - Upgrading to 8 introduces a whole set of other issues, and I just want to build my project not embark on major version toolset upgrade project. Would prefer a solution that works with 7.1 was (Author: mehuge): Upgrading to 8 introduces a whole set of other issues, and I just want to build my project not embark on major version toolset upgrade project. "this a major breaking change for people creating standalone Cordova Android projects." Would prefer a solution that works with 7.1 > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518259#comment-16518259 ] Austin France commented on CB-14150: Upgrading to 8 introduces a whole set of other issues, and I just want to build my project not embark on major version toolset upgrade project. "this a major breaking change for people creating standalone Cordova Android projects." Would prefer a solution that works with 7.1 > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518249#comment-16518249 ] ASF GitHub Bot commented on CB-14127: - garyjohnson commented on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398787762 Understandable, but aren't all released versions of cordova-android currently broken because of this? Or does this only affect a subset of projects somehow? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518246#comment-16518246 ] ASF GitHub Bot commented on CB-14127: - jcesarmobile commented on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398786870 Only security fixes are back ported to previous versions, and only for 6 months since latest major version bump, so 6.4.0 won't get this because it's not security related. This is not released yet, so you have to install from git, or probably using @nightly as version (didn't try, might also need nightly CLI). You can also manually move it up in your project as workaround This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14127) Move google maven repo ahead of jcenter
[ https://issues.apache.org/jira/browse/CB-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518229#comment-16518229 ] ASF GitHub Bot commented on CB-14127: - garyjohnson commented on issue #450: CB-14127: (android) Move google maven repo ahead of jcenter URL: https://github.com/apache/cordova-android/pull/450#issuecomment-398783097 Seeing this issue in 6.4.0 -- are all versions of cordova-android broken due to this? Will they be patched? Is there a version I can upgrade to now without installing the plugin from git? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move google maven repo ahead of jcenter > --- > > Key: CB-14127 > URL: https://issues.apache.org/jira/browse/CB-14127 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Simon MacDonald >Assignee: Joe Bowser >Priority: Major > > Basically there was a problem uploading Google jars to jcenter and it is > causing builds to fail. > [https://twitter.com/bintray/status/1004974875851685888] > Builds will work if we put the google maven repo ahead of jcenter. > On the other had jFrog may end up resolving this issue without us having to > do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518224#comment-16518224 ] Phùng Chí Cơ commented on CB-14150: --- npm install -g cordova > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518194#comment-16518194 ] Austin France edited comment on CB-14150 at 6/20/18 2:26 PM: - $ cordova create myApp org.apache.cordova.myApp myApp $ cd myApp $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android Fails was (Author: mehuge): $ cordova create myApp org.apache.cordova.myApp myApp $ cd myApp $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Works $ cd myApp $ rm -rf platforms plugins $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Fails $ cd myApp $ rm -rf platforms plugins node_modules package.json package-lock.json $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Works So, there is a simple work-around, remove node_modules and package.json as well as platforms and plugins > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518194#comment-16518194 ] Austin France commented on CB-14150: $ cordova create myApp org.apache.cordova.myApp myApp $ cd myApp $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Works $ cd myApp $ rm -rf platforms plugins $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Fails $ cd myApp $ rm -rf platforms plugins node_modules package.json package-lock.json $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase Works So, there is a simple work-around, remove node_modules and package.json as well as platforms and plugins > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin France updated CB-14150: --- Priority: Major (was: Blocker) > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Major > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518175#comment-16518175 ] Austin France commented on CB-14150: [https://github.com/apache/cordova-fetch/commit/307638d63604eb283b581c01a2e702ce39249473] Got rid of all that diff logic > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Blocker > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518150#comment-16518150 ] Austin France edited comment on CB-14150 at 6/20/18 1:53 PM: - Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-geolocation = UNMET result is cordova-plugin-background-geolocation obj1.cordova-plugin-camera = 4.0.3 obj2.cordova-plugin-camera = 4.0.3 obj1.cordova-plugin-compat = 1.2.0 obj2.cordova-plugin-compat = 1.2.0 obj1.cordova-plugin-file = 6.0.1 obj2.cordova-plugin-file = 6.0.1 obj1.cordova-plugin-network-information = 2.0.1 obj2.cordova-plugin-network-information = 2.0.1 obj1.cordova-plugin-printer = 0.7.3 obj2.cordova-plugin-printer = 0.7.3 obj1.cordova-plugin-statusbar = 2.4.2 obj2.cordova-plugin-statusbar = 2.4.2 obj1.cordova-plugin-vibration = 3.1.0 obj2.cordova-plugin-vibration = 3.1.0 obj1.cordova-plugin-whitelist = 1.3.3 obj2.cordova-plugin-whitelist = 1.3.3 obj1.redsky-background-fetch = 1.0.0 obj2.redsky-background-fetch = 1.0.0 obj1.redsky-firebase = 1.0.7 obj2.redsky-firebase = 1.0.7 obj1.redsky-utility = 1.0.8 obj2.redsky-utility = 1.0.8 json diff cordova-plugin-background-geolocation getPath: args id cordova-plugin-background-geolocation dest /Users/adf/.../RMCv2/node_modules target /Users/adf/.../plugins/redsky-firebase getPath returns: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Error: Failed to get absolute path to installed module I did wonder about the UNMET handling, as the code has an re of /UNMET PEER DEPENDENCY/ which it tests the key of tree 1 against, but this has UNMET as obj2[key] don't know if thats significant or not. If I change the following line in index.js:getJsonDiff() {code:java} if (obj2[key] !== obj1[key]) { {code} to {code:java} if (obj2[key] !== obj1[key] && obj2[key] !== 'UNMET') {{code} The second plugin installs, as getJsonDiff returns nothing so trimID is called instead. (ofc I have no idea if thats a sensible change as I have no idea what that logic is doing) was (Author: mehuge): Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-ge
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518150#comment-16518150 ] Austin France edited comment on CB-14150 at 6/20/18 1:52 PM: - Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-geolocation = UNMET result is cordova-plugin-background-geolocation obj1.cordova-plugin-camera = 4.0.3 obj2.cordova-plugin-camera = 4.0.3 obj1.cordova-plugin-compat = 1.2.0 obj2.cordova-plugin-compat = 1.2.0 obj1.cordova-plugin-file = 6.0.1 obj2.cordova-plugin-file = 6.0.1 obj1.cordova-plugin-network-information = 2.0.1 obj2.cordova-plugin-network-information = 2.0.1 obj1.cordova-plugin-printer = 0.7.3 obj2.cordova-plugin-printer = 0.7.3 obj1.cordova-plugin-statusbar = 2.4.2 obj2.cordova-plugin-statusbar = 2.4.2 obj1.cordova-plugin-vibration = 3.1.0 obj2.cordova-plugin-vibration = 3.1.0 obj1.cordova-plugin-whitelist = 1.3.3 obj2.cordova-plugin-whitelist = 1.3.3 obj1.redsky-background-fetch = 1.0.0 obj2.redsky-background-fetch = 1.0.0 obj1.redsky-firebase = 1.0.7 obj2.redsky-firebase = 1.0.7 obj1.redsky-utility = 1.0.8 obj2.redsky-utility = 1.0.8 json diff cordova-plugin-background-geolocation getPath: args id cordova-plugin-background-geolocation dest /Users/adf/.../RMCv2/node_modules target /Users/adf/.../plugins/redsky-firebase getPath returns: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Error: Failed to get absolute path to installed module I did wonder about the UNMET handling, as the code has an re of /UNMET PEER DEPENDENCY/ which it tests the key of tree 1 against, but this has UNMET as obj2[key] don't know if thats significant or not. If I change the following line in index.js:getJsonDiff() {code:java} if (obj2[key] !== obj1[key]) { {code} to {code:java} if (obj2[key] !== obj1[key] && obj2[key] ) not found.== 'UNMET') {{code} The second plugin installs, as getJsonDiff returns nothing so trimID is called instead. (ofc I have no idea if thats a sensible change as I have no idea what that logic is doing) was (Author: mehuge): Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-ba
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518150#comment-16518150 ] Austin France edited comment on CB-14150 at 6/20/18 1:51 PM: - Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-geolocation = UNMET result is cordova-plugin-background-geolocation obj1.cordova-plugin-camera = 4.0.3 obj2.cordova-plugin-camera = 4.0.3 obj1.cordova-plugin-compat = 1.2.0 obj2.cordova-plugin-compat = 1.2.0 obj1.cordova-plugin-file = 6.0.1 obj2.cordova-plugin-file = 6.0.1 obj1.cordova-plugin-network-information = 2.0.1 obj2.cordova-plugin-network-information = 2.0.1 obj1.cordova-plugin-printer = 0.7.3 obj2.cordova-plugin-printer = 0.7.3 obj1.cordova-plugin-statusbar = 2.4.2 obj2.cordova-plugin-statusbar = 2.4.2 obj1.cordova-plugin-vibration = 3.1.0 obj2.cordova-plugin-vibration = 3.1.0 obj1.cordova-plugin-whitelist = 1.3.3 obj2.cordova-plugin-whitelist = 1.3.3 obj1.redsky-background-fetch = 1.0.0 obj2.redsky-background-fetch = 1.0.0 obj1.redsky-firebase = 1.0.7 obj2.redsky-firebase = 1.0.7 obj1.redsky-utility = 1.0.8 obj2.redsky-utility = 1.0.8 json diff cordova-plugin-background-geolocation getPath: args id cordova-plugin-background-geolocation dest /Users/adf/.../RMCv2/node_modules target /Users/adf/.../plugins/redsky-firebase getPath returns: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Error: Failed to get absolute path to installed module I did wonder about the UNMET handling, as the code has an re of /UNMET PEER DEPENDENCY/ which it tests the key of tree 1 against, but this has UNMET as obj2[key] don't know if thats significant or not. If I change the following line in index.js:getJsonDiff() if (obj2[key] !== obj1[key]) { to if (obj2[key] !== obj1[key] && obj2[key] !== 'UNMET') { The second plugin installs, as getJsonDiff returns nothing so trimID is called instead. (ofc I have no idea if thats a sensible change as I have no idea what that logic is doing) was (Author: mehuge): Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-geolocation = UNMET r
[jira] [Comment Edited] (CB-12074) Cookies are ignored on first application execution
[ https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518153#comment-16518153 ] Stephen Warren edited comment on CB-12074 at 6/20/18 1:48 PM: -- thanks for the plugin. how did you get CORS to work with cookies? We had to set our allowed origin to *, which disallows cookies according to the CORS spec. How do you get around having to set your allowed CORS origin to * on the server? was (Author: swarrenvcc): thanks for the plugin. next question – how did you get CORS to work with cookies? We had to set our allowed origin to *, which disallows cookies according to the CORS spec. How do you get around having to set your allowed CORS origin to * on the server? > Cookies are ignored on first application execution > -- > > Key: CB-12074 > URL: https://issues.apache.org/jira/browse/CB-12074 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-wkwebview-engine > Environment: Cordova 5.4.0, iOS 9.3.5 >Reporter: Maxim >Assignee: Shazron Abdullah >Priority: Major > Labels: wkwebview-known-issues > > Our application authenticates to the server. The server sets a 'JSESSIONID' > cookie. The cookie is used by the server for session management. > The issue is WKWebView does not send this cookie back to the server on > subsequent requests. However, this only happens on first execution of the > application, after its installation. Once the application closed and > re-opened, the cookies are properly sent and authentication completes > successfully. > The problematic behavior is consistent, and was observed on several devices. > On the other hand, there are no such issues with UIWebView. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12074) Cookies are ignored on first application execution
[ https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518153#comment-16518153 ] Stephen Warren commented on CB-12074: - thanks for the plugin. next question – how did you get CORS to work with cookies? We had to set our allowed origin to *, which disallows cookies according to the CORS spec. How do you get around having to set your allowed CORS origin to * on the server? > Cookies are ignored on first application execution > -- > > Key: CB-12074 > URL: https://issues.apache.org/jira/browse/CB-12074 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-wkwebview-engine > Environment: Cordova 5.4.0, iOS 9.3.5 >Reporter: Maxim >Assignee: Shazron Abdullah >Priority: Major > Labels: wkwebview-known-issues > > Our application authenticates to the server. The server sets a 'JSESSIONID' > cookie. The cookie is used by the server for session management. > The issue is WKWebView does not send this cookie back to the server on > subsequent requests. However, this only happens on first execution of the > application, after its installation. Once the application closed and > re-opened, the cookies are properly sent and authentication completes > successfully. > The problematic behavior is consistent, and was observed on several devices. > On the other hand, there are no such issues with UIWebView. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518150#comment-16518150 ] Austin France commented on CB-14150: Some debugs from cordova-fetch index.js for the cordova plugin add ../plugins/redsky-firebase (the fetch following installation of geolocation plugin) tree 1: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"2.2.8","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} tree 2: \{"cordova-android":"6.3.0","cordova-custom-config":"5.0.2","cordova-ios":"4.5.4","cordova-plugin-background-geolocation":"UNMET","cordova-plugin-camera":"4.0.3","cordova-plugin-compat":"1.2.0","cordova-plugin-file":"6.0.1","cordova-plugin-network-information":"2.0.1","cordova-plugin-printer":"0.7.3","cordova-plugin-statusbar":"2.4.2","cordova-plugin-vibration":"3.1.0","cordova-plugin-whitelist":"1.3.3","redsky-background-fetch":"1.0.0","redsky-firebase":"1.0.7","redsky-utility":"1.0.8"} jsonDiff obj1.cordova-android = 6.3.0 obj2.cordova-android = 6.3.0 obj1.cordova-custom-config = 5.0.2 obj2.cordova-custom-config = 5.0.2 obj1.cordova-ios = 4.5.4 obj2.cordova-ios = 4.5.4 obj1.cordova-plugin-background-geolocation = 2.2.8 obj2.cordova-plugin-background-geolocation = UNMET result is cordova-plugin-background-geolocation obj1.cordova-plugin-camera = 4.0.3 obj2.cordova-plugin-camera = 4.0.3 obj1.cordova-plugin-compat = 1.2.0 obj2.cordova-plugin-compat = 1.2.0 obj1.cordova-plugin-file = 6.0.1 obj2.cordova-plugin-file = 6.0.1 obj1.cordova-plugin-network-information = 2.0.1 obj2.cordova-plugin-network-information = 2.0.1 obj1.cordova-plugin-printer = 0.7.3 obj2.cordova-plugin-printer = 0.7.3 obj1.cordova-plugin-statusbar = 2.4.2 obj2.cordova-plugin-statusbar = 2.4.2 obj1.cordova-plugin-vibration = 3.1.0 obj2.cordova-plugin-vibration = 3.1.0 obj1.cordova-plugin-whitelist = 1.3.3 obj2.cordova-plugin-whitelist = 1.3.3 obj1.redsky-background-fetch = 1.0.0 obj2.redsky-background-fetch = 1.0.0 obj1.redsky-firebase = 1.0.7 obj2.redsky-firebase = 1.0.7 obj1.redsky-utility = 1.0.8 obj2.redsky-utility = 1.0.8 json diff cordova-plugin-background-geolocation getPath: args id cordova-plugin-background-geolocation dest /Users/adf/.../RMCv2/node_modules target /Users/adf/.../plugins/redsky-firebase getPath returns: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Error: Failed to get absolute path to installed module I did wonder about the UNMET handling, as the code has an re of /UNMET PEER DEPENDENCY/ which it tests the key of tree 1 against, but this has UNMET as obj2[key] don't know if thats significant or not. > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Blocker > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [http
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518098#comment-16518098 ] Austin France edited comment on CB-14150 at 6/20/18 12:40 PM: -- Ok, it does't just affect plugins it affects anything that it fetched. I changed my build script sequence to avoid the above issue but it just crops up later. So instead of doing $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase $ cordova platform add android I now do $ cordova plugin add ../plugins/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android But now, the platform add fails to fetch android, because $ cordova --verbose platform add --save android No scripts found for hook "before_platform_add". No version supplied. Retrieving version from config.xml... Grabbing pinned version. Using cordova-fetch for cordova-android@~6.3.0 saving exact Running command: npm install cordova-android@~6.3.0 --production --save-exact Command finished with error code 0: npm install,cordova-android@~6.3.0,--production,--save-exact {color:#d04437}getPath: /Users/adf/Sites/.../RMCv2/node_modules/cordova-plugin-background-geolocation{color} Error: Failed to fetch platform cordova-android@~6.3.0 was (Author: mehuge): Ok, it does't just affect plugins it affects anything that it fetched. I changed my build script sequence to avoid the above issue but it just crops up later. So instead of doing $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase $ cordova platform add android I now do $ cordova plugin add ../plugins/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android But now, the platform add fails to fetch android, because $ cordova --verbose platform add --save android No scripts found for hook "before_platform_add". No version supplied. Retrieving version from config.xml... Grabbing pinned version. Using cordova-fetch for cordova-android@~6.3.0 saving exact Running command: npm install cordova-android@~6.3.0 --production --save-exact Command finished with error code 0: npm install,cordova-android@~6.3.0,--production,--save-exact {color:#d04437}getPath: /Users/adf/Sites/RMC2/trunk/Cordova/RMCv2/node_modules/cordova-plugin-background-geolocation{color} Error: Failed to fetch platform cordova-android@~6.3.0 > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Blocker > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plug
[jira] [Comment Edited] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518098#comment-16518098 ] Austin France edited comment on CB-14150 at 6/20/18 12:39 PM: -- Ok, it does't just affect plugins it affects anything that it fetched. I changed my build script sequence to avoid the above issue but it just crops up later. So instead of doing $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase $ cordova platform add android I now do $ cordova plugin add ../plugins/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android But now, the platform add fails to fetch android, because $ cordova --verbose platform add --save android No scripts found for hook "before_platform_add". No version supplied. Retrieving version from config.xml... Grabbing pinned version. Using cordova-fetch for cordova-android@~6.3.0 saving exact Running command: npm install cordova-android@~6.3.0 --production --save-exact Command finished with error code 0: npm install,cordova-android@~6.3.0,--production,--save-exact {color:#d04437}getPath: /Users/adf/Sites/RMC2/trunk/Cordova/RMCv2/node_modules/cordova-plugin-background-geolocation{color} Error: Failed to fetch platform cordova-android@~6.3.0 was (Author: mehuge): Ok, it does't just affect plugins it affects anything that it fetched. I changed my build script sequence to avoid the above issue but it just crops up later. So instead of doing $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase $ cordova platform add android I now do $ cordova plugin add ../plugins/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android But now, the platform add fails to fetch android, because, you guessed it. $ cordova --verbose platform add --save android No scripts found for hook "before_platform_add". No version supplied. Retrieving version from config.xml... Grabbing pinned version. Using cordova-fetch for cordova-android@~6.3.0 saving exact Running command: npm install cordova-android@~6.3.0 --production --save-exact Command finished with error code 0: npm install,cordova-android@~6.3.0,--production,--save-exact _*getPath: /Users/adf/Sites/RMC2/trunk/Cordova/RMCv2/node_modules/cordova-plugin-background-geolocation *_Error: Failed to fetch platform cordova-android@~6.3.0 > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Blocker > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first p
[jira] [Commented] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518098#comment-16518098 ] Austin France commented on CB-14150: Ok, it does't just affect plugins it affects anything that it fetched. I changed my build script sequence to avoid the above issue but it just crops up later. So instead of doing $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova plugin add ../plugins/redsky-firebase $ cordova platform add android I now do $ cordova plugin add ../plugins/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git] $ cordova platform add android But now, the platform add fails to fetch android, because, you guessed it. $ cordova --verbose platform add --save android No scripts found for hook "before_platform_add". No version supplied. Retrieving version from config.xml... Grabbing pinned version. Using cordova-fetch for cordova-android@~6.3.0 saving exact Running command: npm install cordova-android@~6.3.0 --production --save-exact Command finished with error code 0: npm install,cordova-android@~6.3.0,--production,--save-exact _*getPath: /Users/adf/Sites/RMC2/trunk/Cordova/RMCv2/node_modules/cordova-plugin-background-geolocation *_Error: Failed to fetch platform cordova-android@~6.3.0 > Error: CordovaError: Failed to get absolute path to installed module > > > Key: CB-14150 > URL: https://issues.apache.org/jira/browse/CB-14150 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Austin France >Priority: Blocker > > cordova-fetch@1.2.0 > I have the following situation when building my cordova project from clean. > By clean I mean > rm -rf platforms plugins > So I have my config.xml prepared (which I generate from a template) and I sit > in the project directory and I do > _$ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ > _$ cordova plugin add ../plugins/redsky-firebase_ > (the real commands include variables, but for purposes of reproducing this > issue, they are not required) > The second plugin add fails with: > (where ... is /usr/local/lib/node_modules/cordova/node_modules) > {code:java} > Error: CordovaError: Failed to get absolute path to installed module > at Function.getPath (.../cordova-fetch/index.js:203:15) > at .../cordova-fetch/index.js:102:35 > at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) > at self.promiseDispatch.done > (.../cordova-fetch/node_modules/q/q.js:883:30) > at Promise.promise.promiseDispatch > (.../cordova-fetch/node_modules/q/q.js:816:13) > at .../cordova-fetch/node_modules/q/q.js:624:44 > at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) > at flush (.../cordova-fetch/node_modules/q/q.js:125:13) > at process._tickCallback (internal/process/next_tick.js:150:11) > {code} > I added a console.log to getPath in cordova-fetch index.js and the output is > as follows: > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation > Thats right, the second plugin add is using the first plugins path, and this > fails. > Further more, if I run the second cordova plugin add command again, it then > works with getPath using the correct path this time. > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > If I reverse the order in which I install plugins, it works ok > _$ cordova plugin add ../plugins/redsky-firebase_ > getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase > $ cordova plugin add > [https://github.com/redskyit/cordova-plugin-background-geolocation.git > getPath: > /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin France updated CB-14150: --- Description: cordova-fetch@1.2.0 I have the following situation when building my cordova project from clean. By clean I mean rm -rf platforms plugins So I have my config.xml prepared (which I generate from a template) and I sit in the project directory and I do _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ _$ cordova plugin add ../plugins/redsky-firebase_ (the real commands include variables, but for purposes of reproducing this issue, they are not required) The second plugin add fails with: (where ... is /usr/local/lib/node_modules/cordova/node_modules) {code:java} Error: CordovaError: Failed to get absolute path to installed module at Function.getPath (.../cordova-fetch/index.js:203:15) at .../cordova-fetch/index.js:102:35 at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) at self.promiseDispatch.done (.../cordova-fetch/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (.../cordova-fetch/node_modules/q/q.js:816:13) at .../cordova-fetch/node_modules/q/q.js:624:44 at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) at flush (.../cordova-fetch/node_modules/q/q.js:125:13) at process._tickCallback (internal/process/next_tick.js:150:11) {code} I added a console.log to getPath in cordova-fetch index.js and the output is as follows: $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Thats right, the second plugin add is using the first plugins path, and this fails. Further more, if I run the second cordova plugin add command again, it then works with getPath using the correct path this time. _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase If I reverse the order in which I install plugins, it works ok _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation was: cordova-fetch@1.2.0 I have the following situation when building my cordova project from clean. By clean I mean rm -rf platforms plugins So I have my config.xml prepared (which I generate from a template) and I sit in the project directory and I do _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ _$ cordova plugin add ../plugins/redsky-firebase_ (the real commands include variables, but for purposes of reproducing this issue, they are not required) The second plugin add fails with: (where ... is /usr/local/lib/node_modules/cordova/node_modules) {code:java} Error: CordovaError: Failed to get absolute path to installed module at Function.getPath (.../cordova-fetch/index.js:203:15) at .../cordova-fetch/index.js:102:35 at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) at self.promiseDispatch.done (.../cordova-fetch/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (.../cordova-fetch/node_modules/q/q.js:816:13) at .../cordova-fetch/node_modules/q/q.js:624:44 at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) at flush (.../cordova-fetch/node_modules/q/q.js:125:13) at process._tickCallback (internal/process/next_tick.js:150:11) {code} I added a console.log to getPath in cordova-fetch index.js and the output is as follows: $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Thats right, the second plugin add is using the first plugins path, and this fails. Further more, if I run the second cordova plugin add command again, it then works with getPath using the correct path this time. _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase If I reverse the order in which I install plugins, it works ok at least in my isolated tests, not yet amended my build scripts _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-backg
[jira] [Updated] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
[ https://issues.apache.org/jira/browse/CB-14150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin France updated CB-14150: --- Description: cordova-fetch@1.2.0 I have the following situation when building my cordova project from clean. By clean I mean rm -rf platforms plugins So I have my config.xml prepared (which I generate from a template) and I sit in the project directory and I do _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ _$ cordova plugin add ../plugins/redsky-firebase_ (the real commands include variables, but for purposes of reproducing this issue, they are not required) The second plugin add fails with: (where ... is /usr/local/lib/node_modules/cordova/node_modules) {code:java} Error: CordovaError: Failed to get absolute path to installed module at Function.getPath (.../cordova-fetch/index.js:203:15) at .../cordova-fetch/index.js:102:35 at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) at self.promiseDispatch.done (.../cordova-fetch/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (.../cordova-fetch/node_modules/q/q.js:816:13) at .../cordova-fetch/node_modules/q/q.js:624:44 at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) at flush (.../cordova-fetch/node_modules/q/q.js:125:13) at process._tickCallback (internal/process/next_tick.js:150:11) {code} I added a console.log to getPath in cordova-fetch index.js and the output is as follows: $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Thats right, the second plugin add is using the first plugins path, and this fails. Further more, if I run the second cordova plugin add command again, it then works with getPath using the correct path this time. _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase If I reverse the order in which I install plugins, it works ok at least in my isolated tests, not yet amended my build scripts _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase $ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation was: cordova-fetch@1.2.0 I have the following situation when building my cordova project from clean. By clean I mean rm -rf platforms plugins So I have my config.xml prepared (which I generate from a template) and I sit in the project directory and I do _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ _$ cordova plugin add ../plugins/redsky-firebase_ (the real commands include variables, but for purposes of reproducing this issue, they are not required) The second plugin add fails with: (where ... is /usr/local/lib/node_modules/cordova/node_modules) {code:java} Error: CordovaError: Failed to get absolute path to installed module at Function.getPath (.../cordova-fetch/index.js:203:15) at .../cordova-fetch/index.js:102:35 at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) at self.promiseDispatch.done (.../cordova-fetch/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (.../cordova-fetch/node_modules/q/q.js:816:13) at .../cordova-fetch/node_modules/q/q.js:624:44 at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) at flush (.../cordova-fetch/node_modules/q/q.js:125:13) at process._tickCallback (internal/process/next_tick.js:150:11) {code} I added a console.log to getPath in cordova-fetch index.js and the output is as follows: _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git ]_getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Thats right, the second plugin add is using the first plugins path, and this fails. Further more, if I run the second cordova plugin add command again, it then works with getPath using the correct path this time. _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase If I reverse the order in which I install plugins, it works ok at least in my isolated tests, not yet amended my build scripts _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git ]
[jira] [Created] (CB-14150) Error: CordovaError: Failed to get absolute path to installed module
Austin France created CB-14150: -- Summary: Error: CordovaError: Failed to get absolute path to installed module Key: CB-14150 URL: https://issues.apache.org/jira/browse/CB-14150 Project: Apache Cordova Issue Type: Bug Components: cordova-fetch Affects Versions: cordova@7.1.0 Reporter: Austin France cordova-fetch@1.2.0 I have the following situation when building my cordova project from clean. By clean I mean rm -rf platforms plugins So I have my config.xml prepared (which I generate from a template) and I sit in the project directory and I do _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git]_ _$ cordova plugin add ../plugins/redsky-firebase_ (the real commands include variables, but for purposes of reproducing this issue, they are not required) The second plugin add fails with: (where ... is /usr/local/lib/node_modules/cordova/node_modules) {code:java} Error: CordovaError: Failed to get absolute path to installed module at Function.getPath (.../cordova-fetch/index.js:203:15) at .../cordova-fetch/index.js:102:35 at _fulfilled (${NPM}/cordova-fetch/node_modules/q/q.js:854:54) at self.promiseDispatch.done (.../cordova-fetch/node_modules/q/q.js:883:30) at Promise.promise.promiseDispatch (.../cordova-fetch/node_modules/q/q.js:816:13) at .../cordova-fetch/node_modules/q/q.js:624:44 at runSingle (.../cordova-fetch/node_modules/q/q.js:137:13) at flush (.../cordova-fetch/node_modules/q/q.js:125:13) at process._tickCallback (internal/process/next_tick.js:150:11) {code} I added a console.log to getPath in cordova-fetch index.js and the output is as follows: _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git ]_getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation Thats right, the second plugin add is using the first plugins path, and this fails. Further more, if I run the second cordova plugin add command again, it then works with getPath using the correct path this time. _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase If I reverse the order in which I install plugins, it works ok at least in my isolated tests, not yet amended my build scripts _$ cordova plugin add ../plugins/redsky-firebase_ getPath: /Users/adf/.../RMCv2/node_modules/redsky-firebase _$ cordova plugin add [https://github.com/redskyit/cordova-plugin-background-geolocation.git ]_getPath: /Users/adf/.../RMCv2/node_modules/cordova-plugin-background-geolocation -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14149) Android usage of cordova.file.dataDirectory does not let save the audio
Massimiliano Perantoni created CB-14149: --- Summary: Android usage of cordova.file.dataDirectory does not let save the audio Key: CB-14149 URL: https://issues.apache.org/jira/browse/CB-14149 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-media Affects Versions: 5.0.1 Reporter: Massimiliano Perantoni Hello, due to a difference between mount points I think, the call to {color:#80}public void {color}moveFile(String file) { after recording fails due to the impossibility of moving data from the tmp save to the final destination, as f.renameTo fails I replaced the f.renameTo with other code {code:java} try { File f = new File(this.tempFile); File fileOut = new File(file); fileOut.createNewFile(); Reader in = new FileReader(f); Writer out = new FileWriter(fileOut); IOUtils.copy(in,out); in.close(); out.close(); f.delete(); } catch (IOException e) { e.printStackTrace(); } //if (!f.renameTo()) LOG.e(LOG_TAG, "FAILED " + logMsg);{code} It seems to work properly, and is more generic, even if I had to add IOUtils ad dependency to use it (it can be even without, but there's more code). If you prefer, I can join and patch the code with this, just to contribute. Hope it helps -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org